[PATCH v2 6/8] vdso: Modify vdso/getrandom.h to include the asm header

Vincenzo Frascino posted 8 patches 2 months ago
There is a newer version of this series
[PATCH v2 6/8] vdso: Modify vdso/getrandom.h to include the asm header
Posted by Vincenzo Frascino 2 months ago
The VDSO implementation includes headers from outside of the
vdso/ namespace.

Modify vdso/getrandom.h to include the getrandom asm header.

Cc: Andy Lutomirski <luto@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
---
 include/vdso/getrandom.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/vdso/getrandom.h b/include/vdso/getrandom.h
index 6ca4d6de9e46..5cf3f75d6fb6 100644
--- a/include/vdso/getrandom.h
+++ b/include/vdso/getrandom.h
@@ -7,6 +7,7 @@
 #define _VDSO_GETRANDOM_H
 
 #include <linux/types.h>
+#include <asm/vdso/getrandom.h>
 
 #define CHACHA_KEY_SIZE         32
 #define CHACHA_BLOCK_SIZE       64
-- 
2.34.1
Re: [PATCH v2 6/8] vdso: Modify vdso/getrandom.h to include the asm header
Posted by Christophe Leroy 2 months ago

Le 23/09/2024 à 16:19, Vincenzo Frascino a écrit :
> The VDSO implementation includes headers from outside of the
> vdso/ namespace.
> 
> Modify vdso/getrandom.h to include the getrandom asm header.

You should explain why this is needed, i.e. what item in 
vdso/getrandom.h requires asm/vdso/getrandom.h

> 
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
> ---
>   include/vdso/getrandom.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/vdso/getrandom.h b/include/vdso/getrandom.h
> index 6ca4d6de9e46..5cf3f75d6fb6 100644
> --- a/include/vdso/getrandom.h
> +++ b/include/vdso/getrandom.h
> @@ -7,6 +7,7 @@
>   #define _VDSO_GETRANDOM_H
>   
>   #include <linux/types.h>
> +#include <asm/vdso/getrandom.h>
>   
>   #define CHACHA_KEY_SIZE         32
>   #define CHACHA_BLOCK_SIZE       64