From nobody Fri Nov 29 13:18:52 2024 Received: from ironport.ite.com.tw (60-251-196-230.hinet-ip.hinet.net [60.251.196.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 341861428E3 for ; Fri, 20 Sep 2024 08:25:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=60.251.196.230 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726820726; cv=none; b=Qkh/Lm98ht8PpPqe9eyOz/mctS6UH/Cwt+8yEtZFjcC17iM+1WgDOmCSscqgemF06TB9tDQ9SWHGP3XNbiM5kknm0jOZfvYo8DBzSC8NOXhGLtitynel7FIKKvglAGITTiBwnQ0ZVVxkr+A1ZtqelN+G6/58gR1iSHVIoCD5II0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726820726; c=relaxed/simple; bh=0Hi92K2eNfUO6gp3VVENifkz/DtzOvaySvv1fHcWtLs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VaVMW5dFcAtTt4AX89tJ3b4QyZVp0GEgGiR366O4lT55NanqufiFJ+RU5lTnU/Spqz6weICyMHRxJi/vjNZyEvgZr3MYQd5fsxrCDUyXJ67MzvUYw2pLoBywCdLDgbNTIyUPSEQOytxU5xW/dt7uvS2AhfqwaLSQK0+y1jYU1f8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ite.com.tw; spf=pass smtp.mailfrom=ite.com.tw; dkim=fail (0-bit key) header.d=ite.com.tw header.i=@ite.com.tw header.b=g1Clok1b reason="key not found in DNS"; arc=none smtp.client-ip=60.251.196.230 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ite.com.tw Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ite.com.tw Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ite.com.tw header.i=@ite.com.tw header.b="g1Clok1b" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ite.com.tw; s=dkim; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kxv6XIW0XqSH04P9Ee5p6gPpAZLINsmYVj9xYMLqSdw=; b=g1Clok1bv3e+cKeHVOZZ07S50X3jwLWLhRId0ZWPD5URTzC6bsX55SuY MWq55gHbgTmBXlGH5R+JGC8i0uVuyGVUS238TZuB6T42JPIh1SfuoXIJd xXdHd9DgrERsB+LFmoN/GYMpOJGDljAgyuzisuoq4qMbO2AyGmtXAeQ21 nFT5H1kOdt3sQS94y1RgS+a/2xE9uGRllXbggiLSdfzZ7xXMHmB78cs3t 0ofT7f/QP4CopxFyCUYsnU/tL0qsj5f2upAbORLIqMt28fOOoNwkVUGut dQFDK2++SkrLV+pPBLOjQPdwZFyumvLUUvr99FwcSYqp2qBCIv37rTMj6 w==; X-CSE-ConnectionGUID: sBgUl2LAQ0utM6vKrqWV8g== X-CSE-MsgGUID: 4AKL5Fj/ReimPE1InGcEpQ== Received: from unknown (HELO mse.ite.com.tw) ([192.168.35.30]) by ironport.ite.com.tw with ESMTP; 20 Sep 2024 16:25:12 +0800 Received: from tpemail1.internal.ite.com.tw (TPEMAIL1.internal.ite.com.tw [192.168.15.58]) by mse.ite.com.tw with ESMTP id 48K8P5QZ024299; Fri, 20 Sep 2024 16:25:05 +0800 (GMT-8) (envelope-from Hermes.Wu@ite.com.tw) Received: from LAPTOP-C4GM1L3U.localdomain (192.168.82.6) by TPEMAIL1.internal.ite.com.tw (192.168.15.58) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 20 Sep 2024 16:25:05 +0800 From: Hermes Wu To: Pin-yen Lin , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , "open list:DRM DRIVERS" , open list CC: Kenneth Hung , Hermes Wu Subject: [PATCH v2 1/2] drm/bridge: it6505: HDCP CTS fail on repeater Date: Fri, 20 Sep 2024 16:24:50 +0800 Message-ID: <20240920082451.9240-6-Hermes.Wu@ite.com.tw> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240920082451.9240-1-Hermes.Wu@ite.com.tw> References: <20240920082451.9240-1-Hermes.Wu@ite.com.tw> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TPEMAIL1.internal.ite.com.tw (192.168.15.58) To TPEMAIL1.internal.ite.com.tw (192.168.15.58) X-TM-SNTS-SMTP: 1D9FB2EFC60E5A84FF29CD7FC87FCB5C429BB40FB509DA0286F40653CBD9025C2002:8 X-MAIL: mse.ite.com.tw 48K8P5QZ024299 Content-Type: text/plain; charset="utf-8" From: Hermes Wu Fix HDCP CTS items on UNIGRAF DPR-100 Signed-off-by: Hermes Wu --- drivers/gpu/drm/bridge/ite-it6505.c | 152 ++++++++++++++++++---------- 1 file changed, 101 insertions(+), 51 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/i= te-it6505.c index 7a4608844de3..cef02c8c363e 100644 --- a/drivers/gpu/drm/bridge/ite-it6505.c +++ b/drivers/gpu/drm/bridge/ite-it6505.c @@ -298,11 +298,11 @@ #define MAX_LANE_COUNT 4 #define MAX_LINK_RATE HBR #define AUTO_TRAIN_RETRY 3 -#define MAX_HDCP_DOWN_STREAM_COUNT 10 +#define MAX_HDCP_DOWN_STREAM_COUNT 127 #define MAX_CR_LEVEL 0x03 #define MAX_EQ_LEVEL 0x03 #define AUX_WAIT_TIMEOUT_MS 15 -#define AUX_FIFO_MAX_SIZE 32 +#define AUX_FIFO_MAX_SIZE 16 #define PIXEL_CLK_DELAY 1 #define PIXEL_CLK_INVERSE 0 #define ADJUST_PHASE_THRESHOLD 80000 @@ -326,6 +326,9 @@ enum aux_cmd_type { CMD_AUX_NATIVE_READ =3D 0x0, CMD_AUX_NATIVE_WRITE =3D 0x5, CMD_AUX_I2C_EDID_READ =3D 0xB, + + /*extend read ncommand */ + CMD_AUX_GET_KSV_LIST =3D 0x10, }; =20 enum aux_cmd_reply { @@ -973,7 +976,7 @@ static ssize_t it6505_aux_operation(struct it6505 *it65= 05, it6505_set_bits(it6505, REG_AUX_CTRL, AUX_USER_MODE, AUX_USER_MODE); =20 aux_op_start: - if (cmd =3D=3D CMD_AUX_I2C_EDID_READ) { + if (cmd =3D=3D CMD_AUX_I2C_EDID_READ || cmd =3D=3D CMD_AUX_GET_KSV_LIST) { /* AUX EDID FIFO has max length of AUX_FIFO_MAX_SIZE bytes. */ size =3D min_t(size_t, size, AUX_FIFO_MAX_SIZE); /* Enable AUX FIFO read back and clear FIFO */ @@ -1004,7 +1007,7 @@ static ssize_t it6505_aux_operation(struct it6505 *it= 6505, size); =20 /* Aux Fire */ - it6505_write(it6505, REG_AUX_CMD_REQ, cmd); + it6505_write(it6505, REG_AUX_CMD_REQ, (cmd & 0x0F)); =20 ret =3D it6505_aux_wait(it6505); if (ret < 0) @@ -1038,7 +1041,7 @@ static ssize_t it6505_aux_operation(struct it6505 *it= 6505, goto aux_op_start; } =20 - if (cmd =3D=3D CMD_AUX_I2C_EDID_READ) { + if (cmd =3D=3D CMD_AUX_I2C_EDID_READ || cmd =3D=3D CMD_AUX_GET_KSV_LIST) { for (i =3D 0; i < size; i++) { ret =3D it6505_read(it6505, REG_AUX_DATA_FIFO); if (ret < 0) @@ -1063,7 +1066,7 @@ static ssize_t it6505_aux_operation(struct it6505 *it= 6505, ret =3D i; =20 aux_op_err: - if (cmd =3D=3D CMD_AUX_I2C_EDID_READ) { + if (cmd =3D=3D CMD_AUX_I2C_EDID_READ || cmd =3D=3D CMD_AUX_GET_KSV_LIST) { /* clear AUX FIFO */ it6505_set_bits(it6505, REG_AUX_CTRL, AUX_EN_FIFO_READ | CLR_EDID_FIFO, @@ -1084,18 +1087,25 @@ static ssize_t it6505_aux_do_transfer(struct it6505= *it6505, size_t size, enum aux_cmd_reply *reply) { int i, ret_size, ret =3D 0, request_size; + struct device *dev =3D &it6505->client->dev; =20 mutex_lock(&it6505->aux_lock); - for (i =3D 0; i < size; i +=3D 4) { - request_size =3D min((int)size - i, 4); + for (i =3D 0; i < size; ) { + if (cmd =3D=3D CMD_AUX_I2C_EDID_READ || cmd =3D=3D CMD_AUX_GET_KSV_LIST) + request_size =3D min((int)size - i, AUX_FIFO_MAX_SIZE); + else + request_size =3D min((int)size - i, 4); + ret_size =3D it6505_aux_operation(it6505, cmd, address + i, buffer + i, request_size, reply); + if (ret_size < 0) { ret =3D ret_size; goto aux_op_err; } =20 + i +=3D request_size; ret +=3D ret_size; } =20 @@ -1186,6 +1196,35 @@ static int it6505_get_edid_block(void *data, u8 *buf= , unsigned int block, return 0; } =20 +static int it6505_get_ksvlist(struct it6505 *it6505, u8 *buf, size_t len) +{ + int i, request_size, ret; + struct device *dev =3D &it6505->client->dev; + enum aux_cmd_reply reply; + + for (i =3D 0; i < len; ) { + request_size =3D min((int)len - i, 15); + + ret =3D it6505_aux_do_transfer(it6505, CMD_AUX_GET_KSV_LIST, + DP_AUX_HDCP_KSV_FIFO, + buf + i, request_size, &reply); + + DRM_DEV_DEBUG_DRIVER(dev, "request_size =3D %d, ret =3D%d", request_size= , ret); + if (ret < 0) + return ret; + + i +=3D request_size; + } + + DRM_DEV_DEBUG_DRIVER(dev, "ksv read cnt =3D %d down_stream_cnt=3D%d ", i,= i/5); + + for (i =3D 0 ; i < len; i +=3D 5) + DRM_DEV_DEBUG_DRIVER(dev, "ksv[%d] =3D %02X%02X%02X%02X%02X", + i/5, buf[i], buf[i + 1], buf[i + 2], buf[i + 3], buf[i + 4]); + + return len; +} + static void it6505_variable_config(struct it6505 *it6505) { it6505->link_rate_bw_code =3D HBR; @@ -1927,6 +1966,7 @@ static void it6505_hdcp_part1_auth(struct it6505 *it6= 505) it6505_set_bits(it6505, REG_HDCP_TRIGGER, HDCP_TRIGGER_START, HDCP_TRIGGER_START); =20 + it6505->is_repeater =3D (hdcp_bcaps & DP_BCAPS_REPEATER_PRESENT); it6505->hdcp_status =3D HDCP_AUTH_GOING; } =20 @@ -1963,7 +2003,7 @@ static int it6505_setup_sha1_input(struct it6505 *it6= 505, u8 *sha1_input) { struct device *dev =3D &it6505->client->dev; u8 binfo[2]; - int down_stream_count, i, err, msg_count =3D 0; + int down_stream_count, err, msg_count =3D 0; =20 err =3D it6505_get_dpcd(it6505, DP_AUX_HDCP_BINFO, binfo, ARRAY_SIZE(binfo)); @@ -1989,17 +2029,12 @@ static int it6505_setup_sha1_input(struct it6505 *i= t6505, u8 *sha1_input) return 0; } =20 - for (i =3D 0; i < down_stream_count; i++) { - err =3D it6505_get_dpcd(it6505, DP_AUX_HDCP_KSV_FIFO + - (i % 3) * DRM_HDCP_KSV_LEN, - sha1_input + msg_count, - DRM_HDCP_KSV_LEN); =20 - if (err < 0) - return err; + err =3D it6505_get_ksvlist(it6505, sha1_input, down_stream_count * 5); + if (err < 0) + return err; =20 - msg_count +=3D 5; - } + msg_count +=3D down_stream_count * 5; =20 it6505->hdcp_down_stream_count =3D down_stream_count; sha1_input[msg_count++] =3D binfo[0]; @@ -2027,7 +2062,7 @@ static bool it6505_hdcp_part2_ksvlist_check(struct it= 6505 *it6505) { struct device *dev =3D &it6505->client->dev; u8 av[5][4], bv[5][4]; - int i, err; + int i, err, retry; =20 i =3D it6505_setup_sha1_input(it6505, it6505->sha1_input); if (i <=3D 0) { @@ -2037,21 +2072,28 @@ static bool it6505_hdcp_part2_ksvlist_check(struct = it6505 *it6505) =20 it6505_sha1_digest(it6505, it6505->sha1_input, i, (u8 *)av); =20 - err =3D it6505_get_dpcd(it6505, DP_AUX_HDCP_V_PRIME(0), (u8 *)bv, - sizeof(bv)); + for (retry =3D 0; retry < 3; retry++) { =20 - if (err < 0) { - dev_err(dev, "Read V' value Fail"); - return false; - } + err =3D it6505_get_dpcd(it6505, DP_AUX_HDCP_V_PRIME(0), (u8 *)bv, + sizeof(bv)); =20 - for (i =3D 0; i < 5; i++) - if (bv[i][3] !=3D av[i][0] || bv[i][2] !=3D av[i][1] || - bv[i][1] !=3D av[i][2] || bv[i][0] !=3D av[i][3]) - return false; + if (err < 0) { + dev_err(dev, "Read V' value Fail %d", retry); + continue; + } =20 - DRM_DEV_DEBUG_DRIVER(dev, "V' all match!!"); - return true; + for (i =3D 0; i < 5; i++) { + if (bv[i][3] !=3D av[i][0] || bv[i][2] !=3D av[i][1] || + bv[i][1] !=3D av[i][2] || bv[i][0] !=3D av[i][3]) + break; + + DRM_DEV_DEBUG_DRIVER(dev, "V' all match!! %d, %d", retry, i); + return true; + } + } + + DRM_DEV_DEBUG_DRIVER(dev, "V' NOT match!! %d", retry); + return false; } =20 static void it6505_hdcp_wait_ksv_list(struct work_struct *work) @@ -2059,7 +2101,7 @@ static void it6505_hdcp_wait_ksv_list(struct work_str= uct *work) struct it6505 *it6505 =3D container_of(work, struct it6505, hdcp_wait_ksv_list); struct device *dev =3D &it6505->client->dev; - unsigned int timeout =3D 5000; + unsigned int timeout =3D 2000; u8 bstatus =3D 0; bool ksv_list_check; =20 @@ -2079,21 +2121,18 @@ static void it6505_hdcp_wait_ksv_list(struct work_s= truct *work) =20 if (timeout =3D=3D 0) { DRM_DEV_DEBUG_DRIVER(dev, "timeout and ksv list wait failed"); - goto timeout; + goto hdcp_ksvlist_fail; } =20 ksv_list_check =3D it6505_hdcp_part2_ksvlist_check(it6505); DRM_DEV_DEBUG_DRIVER(dev, "ksv list ready, ksv list check %s", - ksv_list_check ? "pass" : "fail"); - if (ksv_list_check) { - it6505_set_bits(it6505, REG_HDCP_TRIGGER, - HDCP_TRIGGER_KSV_DONE, HDCP_TRIGGER_KSV_DONE); + ksv_list_check ? "pass" : "fail"); + + if (ksv_list_check) return; - } -timeout: - it6505_set_bits(it6505, REG_HDCP_TRIGGER, - HDCP_TRIGGER_KSV_DONE | HDCP_TRIGGER_KSV_FAIL, - HDCP_TRIGGER_KSV_DONE | HDCP_TRIGGER_KSV_FAIL); + +hdcp_ksvlist_fail: + it6505_start_hdcp(it6505); } =20 static void it6505_hdcp_work(struct work_struct *work) @@ -2139,7 +2178,7 @@ static void it6505_hdcp_work(struct work_struct *work) it6505_hdcp_part1_auth(it6505); } =20 -static void it6505_show_hdcp_info(struct it6505 *it6505) +static void it6505_show_hdcp_info(struct it6505 *it6505, bool repeater_inf= o) { struct device *dev =3D &it6505->client->dev; int i; @@ -2150,7 +2189,7 @@ static void it6505_show_hdcp_info(struct it6505 *it65= 05) DRM_DEV_DEBUG_DRIVER(dev, "bksv =3D 0x%*ph", (int)ARRAY_SIZE(it6505->bksvs), it6505->bksvs); =20 - if (it6505->is_repeater) { + if ((repeater_info) && (it6505->is_repeater)) { DRM_DEV_DEBUG_DRIVER(dev, "hdcp_down_stream_count: %d", it6505->hdcp_down_stream_count); DRM_DEV_DEBUG_DRIVER(dev, "sha1_input: 0x%*ph", @@ -2251,12 +2290,11 @@ static void it6505_link_training_work(struct work_s= truct *work) if (ret) { it6505->auto_train_retry =3D AUTO_TRAIN_RETRY; it6505_link_train_ok(it6505); - return; } else { it6505->auto_train_retry--; + it6505_dump(it6505); } =20 - it6505_dump(it6505); } =20 static void it6505_plugged_status_to_codec(struct it6505 *it6505) @@ -2311,14 +2349,22 @@ static int it6505_process_hpd_irq(struct it6505 *it= 6505) DRM_DEV_DEBUG_DRIVER(dev, "dp_irq_vector =3D 0x%02x", dp_irq_vector); =20 if (dp_irq_vector & DP_CP_IRQ) { - it6505_set_bits(it6505, REG_HDCP_TRIGGER, HDCP_TRIGGER_CPIRQ, - HDCP_TRIGGER_CPIRQ); =20 bstatus =3D it6505_dpcd_read(it6505, DP_AUX_HDCP_BSTATUS); if (bstatus < 0) return bstatus; =20 DRM_DEV_DEBUG_DRIVER(dev, "Bstatus =3D 0x%02x", bstatus); + + /*1B-02 ignore when bstatus is 0 */ + if ((bstatus & DP_BSTATUS_R0_PRIME_READY) && + (it6505->hdcp_status =3D=3D HDCP_AUTH_GOING)) + it6505_set_bits(it6505, REG_HDCP_TRIGGER, HDCP_TRIGGER_CPIRQ, + HDCP_TRIGGER_CPIRQ); + else if ((bstatus & (DP_BSTATUS_REAUTH_REQ | DP_BSTATUS_LINK_FAILURE)) && + (it6505->hdcp_status =3D=3D HDCP_AUTH_DONE)) + it6505_start_hdcp(it6505); + } =20 ret =3D drm_dp_dpcd_read_link_status(&it6505->aux, link_status); @@ -2431,7 +2477,7 @@ static void it6505_irq_hdcp_done(struct it6505 *it650= 5) =20 DRM_DEV_DEBUG_DRIVER(dev, "hdcp done interrupt"); it6505->hdcp_status =3D HDCP_AUTH_DONE; - it6505_show_hdcp_info(it6505); + it6505_show_hdcp_info(it6505, false); } =20 static void it6505_irq_hdcp_fail(struct it6505 *it6505) @@ -2440,7 +2486,7 @@ static void it6505_irq_hdcp_fail(struct it6505 *it650= 5) =20 DRM_DEV_DEBUG_DRIVER(dev, "hdcp fail interrupt"); it6505->hdcp_status =3D HDCP_AUTH_IDLE; - it6505_show_hdcp_info(it6505); + it6505_show_hdcp_info(it6505, true); it6505_start_hdcp(it6505); } =20 @@ -2455,7 +2501,11 @@ static void it6505_irq_hdcp_ksv_check(struct it6505 = *it6505) { struct device *dev =3D &it6505->client->dev; =20 - DRM_DEV_DEBUG_DRIVER(dev, "HDCP event Interrupt"); + DRM_DEV_DEBUG_DRIVER(dev, "HDCP repeater R0 event Interrupt"); + + it6505_set_bits(it6505, REG_HDCP_TRIGGER, + HDCP_TRIGGER_KSV_DONE, HDCP_TRIGGER_KSV_DONE); + schedule_work(&it6505->hdcp_wait_ksv_list); } =20 --=20 2.34.1