From nobody Sat Nov 30 01:54:09 2024 Received: from out187-17.us.a.mail.aliyun.com (out187-17.us.a.mail.aliyun.com [47.90.187.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1628818027 for ; Fri, 13 Sep 2024 14:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=47.90.187.17 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726237322; cv=none; b=JlWy3kyHNzz66CrFlhUwTMmxdyNqpefCBJ8wjbTS7cUxV802TzAXtyAxLEBiNvWsrNgMiXHWM9LFyewkf3m2LMk7bAqluMFOY4oJRrxGvn+NkLwigvWjmNvngyyzk/2wIU6aqaU6h+Rc9VbCK3L2j8hHzDb/M2oz68LYpTzG5HY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726237322; c=relaxed/simple; bh=r7oQNiZ9QJ8H31IDoblAeH7GZMz6IMWkWZk8ZBCiR9E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uYFIt+0/uTNpggIqGsdkd2x+Dt68RUE3c4xzNnk/C6zbm3rjYcy+bUZtEST36u7ZU2IvAzn3Y547m7rhJk/jidfKtcEmnG3299BScqM9N4oLEAPiDm2Y7CXE+3Xe25pXU1KBwMpDjUA2ah1tGiZ4u+I+hDQ/7f+AaU1KapQ/0QY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=antgroup.com; spf=pass smtp.mailfrom=antgroup.com; dkim=pass (1024-bit key) header.d=antgroup.com header.i=@antgroup.com header.b=KecviXKu; arc=none smtp.client-ip=47.90.187.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=antgroup.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=antgroup.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=antgroup.com header.i=@antgroup.com header.b="KecviXKu" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=antgroup.com; s=default; t=1726237306; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=2iMqCL16nvIVqbFIVvASdDsc9aD2h+9cgin+rWYCLmc=; b=KecviXKuLBzh6COzxJlebdwcHw1EI0FN5wSdwJqSH6XGsm6PoLA1NkuDYSTKdOrD3984axRo2fFBdZohkEuJXF8cPi743Jd2eV1ZXjM3b4S4gxi+tBOc8xN+7pVve0g2ltUWUyZtxOpz+/2XiZbMCry33DdYLvsgzJ7HS0SLrFE= Received: from ubuntu..(mailfrom:tiwei.btw@antgroup.com fp:SMTPD_---.ZIP7E8L_1726237305) by smtp.aliyun-inc.com; Fri, 13 Sep 2024 22:21:46 +0800 From: "Tiwei Bie" To: richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net Cc: , , "Tiwei Bie" Subject: [PATCH 2/3] um: Remove highmem leftovers Date: Fri, 13 Sep 2024 22:21:36 +0800 Message-Id: <20240913142137.248245-3-tiwei.btw@antgroup.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240913142137.248245-1-tiwei.btw@antgroup.com> References: <20240913142137.248245-1-tiwei.btw@antgroup.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Highmem was only supported on UML/i386. And the support has been removed by commit a98a6d864d3b ("um: Remove broken highmem support"). Remove the leftovers and stop UML from trying to setup highmem when the sum of physmem_size and iomem_size exceeds max_physmem. Signed-off-by: Tiwei Bie --- arch/um/drivers/virtio_uml.c | 9 +-------- arch/um/include/shared/as-layout.h | 1 - arch/um/include/shared/mem_user.h | 5 ++--- arch/um/kernel/mem.c | 3 --- arch/um/kernel/physmem.c | 30 +++++++++++------------------- arch/um/kernel/um_arch.c | 17 +++++++---------- 6 files changed, 21 insertions(+), 44 deletions(-) diff --git a/arch/um/drivers/virtio_uml.c b/arch/um/drivers/virtio_uml.c index 2b6e701776b6..e7f5556e3c96 100644 --- a/arch/um/drivers/virtio_uml.c +++ b/arch/um/drivers/virtio_uml.c @@ -72,7 +72,7 @@ struct virtio_uml_vq_info { bool suspended; }; =20 -extern unsigned long long physmem_size, highmem; +extern unsigned long long physmem_size; =20 #define vu_err(vu_dev, ...) dev_err(&(vu_dev)->pdev->dev, ##__VA_ARGS__) =20 @@ -673,13 +673,6 @@ static int vhost_user_set_mem_table(struct virtio_uml_= device *vu_dev) =20 if (rc < 0) return rc; - if (highmem) { - msg.payload.mem_regions.num++; - rc =3D vhost_user_init_mem_region(__pa(end_iomem), highmem, - &fds[1], &msg.payload.mem_regions.regions[1]); - if (rc < 0) - return rc; - } =20 return vhost_user_send(vu_dev, false, &msg, fds, msg.payload.mem_regions.num); diff --git a/arch/um/include/shared/as-layout.h b/arch/um/include/shared/as= -layout.h index 06292fca5a4d..61965a06c18a 100644 --- a/arch/um/include/shared/as-layout.h +++ b/arch/um/include/shared/as-layout.h @@ -41,7 +41,6 @@ extern unsigned long uml_physmem; extern unsigned long uml_reserved; extern unsigned long end_vm; extern unsigned long start_vm; -extern unsigned long long highmem; =20 extern unsigned long brk_start; =20 diff --git a/arch/um/include/shared/mem_user.h b/arch/um/include/shared/mem= _user.h index 11a723a58545..adfa08062f88 100644 --- a/arch/um/include/shared/mem_user.h +++ b/arch/um/include/shared/mem_user.h @@ -47,10 +47,9 @@ extern int iomem_size; #define ROUND_4M(n) ((((unsigned long) (n)) + (1 << 22)) & ~((1 << 22) - 1= )) =20 extern unsigned long find_iomem(char *driver, unsigned long *len_out); -extern void mem_total_pages(unsigned long physmem, unsigned long iomem, - unsigned long highmem); +extern void mem_total_pages(unsigned long physmem, unsigned long iomem); extern void setup_physmem(unsigned long start, unsigned long usable, - unsigned long len, unsigned long long highmem); + unsigned long len); extern void map_memory(unsigned long virt, unsigned long phys, unsigned long len, int r, int w, int x); =20 diff --git a/arch/um/kernel/mem.c b/arch/um/kernel/mem.c index a5b4fe2ad931..5026668dc054 100644 --- a/arch/um/kernel/mem.c +++ b/arch/um/kernel/mem.c @@ -6,7 +6,6 @@ #include #include #include -#include #include #include #include @@ -51,8 +50,6 @@ EXPORT_SYMBOL(empty_zero_page); pgd_t swapper_pg_dir[PTRS_PER_PGD]; =20 /* Initialized at boot time, and readonly after that */ -unsigned long long highmem; -EXPORT_SYMBOL(highmem); int kmalloc_ok =3D 0; =20 /* Used during early boot */ diff --git a/arch/um/kernel/physmem.c b/arch/um/kernel/physmem.c index fb2adfb49945..cc5238c1bf1e 100644 --- a/arch/um/kernel/physmem.c +++ b/arch/um/kernel/physmem.c @@ -24,17 +24,14 @@ EXPORT_SYMBOL(high_physmem); =20 extern unsigned long long physmem_size; =20 -void __init mem_total_pages(unsigned long physmem, unsigned long iomem, - unsigned long highmem) +void __init mem_total_pages(unsigned long physmem, unsigned long iomem) { - unsigned long phys_pages, highmem_pages; - unsigned long iomem_pages, total_pages; + unsigned long phys_pages, iomem_pages, total_pages; =20 - phys_pages =3D physmem >> PAGE_SHIFT; - iomem_pages =3D iomem >> PAGE_SHIFT; - highmem_pages =3D highmem >> PAGE_SHIFT; + phys_pages =3D physmem >> PAGE_SHIFT; + iomem_pages =3D iomem >> PAGE_SHIFT; =20 - total_pages =3D phys_pages + iomem_pages + highmem_pages; + total_pages =3D phys_pages + iomem_pages; =20 max_mapnr =3D total_pages; } @@ -64,13 +61,12 @@ void map_memory(unsigned long virt, unsigned long phys,= unsigned long len, * @reserve_end: end address of the physical kernel memory. * @len: Length of total physical memory that should be mapped/made * available, in bytes. - * @highmem: Number of highmem bytes that should be mapped/made available. * - * Creates an unlinked temporary file of size (len + highmem) and memory m= aps + * Creates an unlinked temporary file of size (len) and memory maps * it on the last executable image address (uml_reserved). * * The offset is needed as the length of the total physical memory - * (len + highmem) includes the size of the memory used be the executable = image, + * (len) includes the size of the memory used be the executable image, * but the mapped-to address is the last address of the executable image * (uml_reserved =3D=3D end address of executable image). * @@ -78,19 +74,19 @@ void map_memory(unsigned long virt, unsigned long phys,= unsigned long len, * of all user space processes/kernel tasks. */ void __init setup_physmem(unsigned long start, unsigned long reserve_end, - unsigned long len, unsigned long long highmem) + unsigned long len) { unsigned long reserve =3D reserve_end - start; long map_size =3D len - reserve; int err; =20 - if(map_size <=3D 0) { + if (map_size <=3D 0) { os_warn("Too few physical memory! Needed=3D%lu, given=3D%lu\n", reserve, len); exit(1); } =20 - physmem_fd =3D create_mem_file(len + highmem); + physmem_fd =3D create_mem_file(len); =20 err =3D os_map_memory((void *) reserve_end, physmem_fd, reserve, map_size, 1, 1, 1); @@ -109,7 +105,7 @@ void __init setup_physmem(unsigned long start, unsigned= long reserve_end, os_write_file(physmem_fd, __syscall_stub_start, PAGE_SIZE); os_fsync_file(physmem_fd); =20 - memblock_add(__pa(start), len + highmem); + memblock_add(__pa(start), len); memblock_reserve(__pa(start), reserve); =20 min_low_pfn =3D PFN_UP(__pa(reserve_end)); @@ -137,10 +133,6 @@ int phys_mapping(unsigned long phys, unsigned long lon= g *offset_out) region =3D region->next; } } - else if (phys < __pa(end_iomem) + highmem) { - fd =3D physmem_fd; - *offset_out =3D phys - iomem_size; - } =20 return fd; } diff --git a/arch/um/kernel/um_arch.c b/arch/um/kernel/um_arch.c index 8e594cda6d77..8f86aa468b50 100644 --- a/arch/um/kernel/um_arch.c +++ b/arch/um/kernel/um_arch.c @@ -366,18 +366,15 @@ int __init linux_main(int argc, char **argv) =20 setup_machinename(init_utsname()->machine); =20 - highmem =3D 0; + physmem_size =3D (physmem_size + PAGE_SIZE - 1) & PAGE_MASK; iomem_size =3D (iomem_size + PAGE_SIZE - 1) & PAGE_MASK; + max_physmem =3D TASK_SIZE - uml_physmem - iomem_size - MIN_VMALLOC; =20 - /* - * Zones have to begin on a 1 << MAX_PAGE_ORDER page boundary, - * so this makes sure that's true for highmem - */ - max_physmem &=3D ~((1 << (PAGE_SHIFT + MAX_PAGE_ORDER)) - 1); if (physmem_size + iomem_size > max_physmem) { - highmem =3D physmem_size + iomem_size - max_physmem; - physmem_size -=3D highmem; + physmem_size =3D max_physmem - iomem_size; + os_info("Physical memory size shrunk to %llu bytes\n", + physmem_size); } =20 high_physmem =3D uml_physmem + physmem_size; @@ -413,8 +410,8 @@ void __init setup_arch(char **cmdline_p) u8 rng_seed[32]; =20 stack_protections((unsigned long) &init_thread_info); - setup_physmem(uml_physmem, uml_reserved, physmem_size, highmem); - mem_total_pages(physmem_size, iomem_size, highmem); + setup_physmem(uml_physmem, uml_reserved, physmem_size); + mem_total_pages(physmem_size, iomem_size); uml_dtb_init(); read_initrd(); =20 --=20 2.34.1