From nobody Sat Nov 30 01:48:43 2024 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 850331DC070; Fri, 13 Sep 2024 13:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726234219; cv=none; b=uXfzjnBvgWaJDqEr0P9mjL57Oqi/JjSuLDnluRkZuIbv4XBiCpzKDvgru17eRY6FsGJHqCwp/5pH3Cwp0Xe2JQsrzspJnX5jn1M4xExFlZWzQsQxCH6Z4f8omb/xt5BJa4hAimhaml3wivY8ITZT3Y5TV8Y2j233NrV/HzlBEtA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726234219; c=relaxed/simple; bh=jsQsJU164fMv9WxIfqsMhRwMKkOPkK0XRf4AMdSrmmc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IR55U0tlId+v2hOx/lQ1M5+NJmEvCB0al2sNEC9MGRk0uQfysoD/GexydWuHV7/YcBYBWf4Sgwd7J9JWZXQYCW7bieqsuEZUEvoX2KOocl4MmwBnQRcVJDLVZfBSPXovdzlEPF/LIh0Md/QmXNhXx0udUcWydfk4F1jqEvNNLyw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C9F413D5; Fri, 13 Sep 2024 06:30:47 -0700 (PDT) Received: from e125905.cambridge.arm.com (e125905.cambridge.arm.com [10.1.194.73]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 51B503F73B; Fri, 13 Sep 2024 06:30:16 -0700 (PDT) From: Beata Michalska To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, ionela.voinescu@arm.com, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, rafael@kernel.org, viresh.kumar@linaro.org Cc: sumitg@nvidia.com, yang@os.amperecomputing.com, vanshikonda@os.amperecomputing.com, lihuisong@huawei.com, zhanjie9@hisilicon.com Subject: [PATCH v7 4/4] arm64: Update AMU-based freq scale factor on entering idle Date: Fri, 13 Sep 2024 14:29:44 +0100 Message-Id: <20240913132944.1880703-5-beata.michalska@arm.com> In-Reply-To: <20240913132944.1880703-1-beata.michalska@arm.com> References: <20240913132944.1880703-1-beata.michalska@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Now that the frequency scale factor has been activated for retrieving current frequency on a given CPU, trigger its update upon entering idle. This will, to an extent, allow querying last known frequency in a non-invasive way. It will also improve the frequency scale factor accuracy when a CPU entering idle did not receive a tick for a while. As a consequence, for idle cores, the reported frequency will be the last one observed before entering the idle state. Suggested-by: Vanshidhar Konda Signed-off-by: Beata Michalska --- arch/arm64/kernel/topology.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c index 22e510733336..dbde62fd013c 100644 --- a/arch/arm64/kernel/topology.c +++ b/arch/arm64/kernel/topology.c @@ -213,6 +213,19 @@ static __always_inline bool amu_fie_cpu_supported(unsi= gned int cpu) cpumask_test_cpu(cpu, amu_fie_cpus); } =20 +void arch_cpu_idle_enter(void) +{ + unsigned int cpu =3D smp_processor_id(); + + if (!amu_fie_cpu_supported(cpu)) + return; + + /* Kick in AMU update but only if one has not happened already */ + if (housekeeping_cpu(cpu, HK_TYPE_TICK) && + time_is_before_jiffies(per_cpu(cpu_amu_samples.last_scale_update, cpu= ))) + amu_scale_freq_tick(); +} + #define AMU_SAMPLE_EXP_MS 20 =20 int arch_freq_avg_get_on_cpu(int cpu) --=20 2.25.1