From nobody Sat Nov 30 02:45:23 2024 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4165D1DC040; Fri, 13 Sep 2024 13:30:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726234217; cv=none; b=s1BsdPw9lv+1Qb8un8skE3KfFWeF1SiF9ugNYzchK5xDyB87REUagrlz0jGfw+3Rur+5QBC83hwCu2wLpA3+/C8+Eah1o4STjhn/5VuPv8xVxI+GWNIW3X580VOOkGNKc/2m5qwW+EIVHL6P02E9TL/WFHDxBg4N/IUa7j14uEg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726234217; c=relaxed/simple; bh=wK0YP5iJvrhd9dEKqQhIJv4RKjgl6Jp/5cjj6cOfQhU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cnsU0VuIoVcDRyNKT8wTirG9/QpSMAlscJP1v5XZ1TTQ/UBVDnyloxSa4/mNP2oHFoU9uTZiOZpZHSHCzqWuIEWeja6heHqUJsEPb/w76jswBrrCBifKEld1cy7nuhuUaMoef7dzTdHVnzBxO34qplTrKaGIPwiVipxhPhHlRsc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 791A01650; Fri, 13 Sep 2024 06:30:45 -0700 (PDT) Received: from e125905.cambridge.arm.com (e125905.cambridge.arm.com [10.1.194.73]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5F5233F73B; Fri, 13 Sep 2024 06:30:14 -0700 (PDT) From: Beata Michalska To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, ionela.voinescu@arm.com, sudeep.holla@arm.com, will@kernel.org, catalin.marinas@arm.com, rafael@kernel.org, viresh.kumar@linaro.org Cc: sumitg@nvidia.com, yang@os.amperecomputing.com, vanshikonda@os.amperecomputing.com, lihuisong@huawei.com, zhanjie9@hisilicon.com Subject: [PATCH v7 3/4] arm64: Provide an AMU-based version of arch_freq_avg_get_on_cpu Date: Fri, 13 Sep 2024 14:29:43 +0100 Message-Id: <20240913132944.1880703-4-beata.michalska@arm.com> In-Reply-To: <20240913132944.1880703-1-beata.michalska@arm.com> References: <20240913132944.1880703-1-beata.michalska@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With the Frequency Invariance Engine (FIE) being already wired up with sched tick and making use of relevant (core counter and constant counter) AMU counters, getting the average frequency for a given CPU, can be achieved by utilizing the frequency scale factor which reflects an average CPU frequency for the last tick period length. The solution is partially based on APERF/MPERF implementation of arch_freq_get_on_cpu. Suggested-by: Ionela Voinescu Signed-off-by: Beata Michalska --- arch/arm64/kernel/topology.c | 109 +++++++++++++++++++++++++++++++---- 1 file changed, 99 insertions(+), 10 deletions(-) diff --git a/arch/arm64/kernel/topology.c b/arch/arm64/kernel/topology.c index cb180684d10d..22e510733336 100644 --- a/arch/arm64/kernel/topology.c +++ b/arch/arm64/kernel/topology.c @@ -17,6 +17,7 @@ #include #include #include +#include =20 #include #include @@ -88,18 +89,28 @@ int __init parse_acpi_topology(void) * initialized. */ static DEFINE_PER_CPU_READ_MOSTLY(unsigned long, arch_max_freq_scale) =3D = 1UL << (2 * SCHED_CAPACITY_SHIFT); -static DEFINE_PER_CPU(u64, arch_const_cycles_prev); -static DEFINE_PER_CPU(u64, arch_core_cycles_prev); static cpumask_var_t amu_fie_cpus; =20 +struct amu_cntr_sample { + u64 arch_const_cycles_prev; + u64 arch_core_cycles_prev; + unsigned long last_scale_update; +}; + +static DEFINE_PER_CPU_SHARED_ALIGNED(struct amu_cntr_sample, cpu_amu_sampl= es); + void update_freq_counters_refs(void) { - this_cpu_write(arch_core_cycles_prev, read_corecnt()); - this_cpu_write(arch_const_cycles_prev, read_constcnt()); + struct amu_cntr_sample *amu_sample =3D this_cpu_ptr(&cpu_amu_samples); + + amu_sample->arch_core_cycles_prev =3D read_corecnt(); + amu_sample->arch_const_cycles_prev =3D read_constcnt(); } =20 static inline bool freq_counters_valid(int cpu) { + struct amu_cntr_sample *amu_sample =3D per_cpu_ptr(&cpu_amu_samples, cpu); + if ((cpu >=3D nr_cpu_ids) || !cpumask_test_cpu(cpu, cpu_present_mask)) return false; =20 @@ -108,8 +119,8 @@ static inline bool freq_counters_valid(int cpu) return false; } =20 - if (unlikely(!per_cpu(arch_const_cycles_prev, cpu) || - !per_cpu(arch_core_cycles_prev, cpu))) { + if (unlikely(!amu_sample->arch_const_cycles_prev || + !amu_sample->arch_core_cycles_prev)) { pr_debug("CPU%d: cycle counters are not enabled.\n", cpu); return false; } @@ -152,17 +163,22 @@ void freq_inv_set_max_ratio(int cpu, u64 max_rate) =20 static void amu_scale_freq_tick(void) { + struct amu_cntr_sample *amu_sample =3D this_cpu_ptr(&cpu_amu_samples); u64 prev_core_cnt, prev_const_cnt; u64 core_cnt, const_cnt, scale; =20 - prev_const_cnt =3D this_cpu_read(arch_const_cycles_prev); - prev_core_cnt =3D this_cpu_read(arch_core_cycles_prev); + prev_const_cnt =3D amu_sample->arch_const_cycles_prev; + prev_core_cnt =3D amu_sample->arch_core_cycles_prev; =20 update_freq_counters_refs(); =20 - const_cnt =3D this_cpu_read(arch_const_cycles_prev); - core_cnt =3D this_cpu_read(arch_core_cycles_prev); + const_cnt =3D amu_sample->arch_const_cycles_prev; + core_cnt =3D amu_sample->arch_core_cycles_prev; =20 + /* + * This should not happen unless the AMUs have been reset and the + * counter values have not been restored - unlikely + */ if (unlikely(core_cnt <=3D prev_core_cnt || const_cnt <=3D prev_const_cnt)) return; @@ -182,6 +198,8 @@ static void amu_scale_freq_tick(void) =20 scale =3D min_t(unsigned long, scale, SCHED_CAPACITY_SCALE); this_cpu_write(arch_freq_scale, (unsigned long)scale); + + amu_sample->last_scale_update =3D jiffies; } =20 static struct scale_freq_data amu_sfd =3D { @@ -189,6 +207,77 @@ static struct scale_freq_data amu_sfd =3D { .set_freq_scale =3D amu_scale_freq_tick, }; =20 +static __always_inline bool amu_fie_cpu_supported(unsigned int cpu) +{ + return cpumask_available(amu_fie_cpus) && + cpumask_test_cpu(cpu, amu_fie_cpus); +} + +#define AMU_SAMPLE_EXP_MS 20 + +int arch_freq_avg_get_on_cpu(int cpu) +{ + struct amu_cntr_sample *amu_sample; + unsigned int start_cpu =3D cpu; + unsigned long last_update; + unsigned int freq =3D 0; + u64 scale; + + if (!amu_fie_cpu_supported(cpu) || !arch_scale_freq_ref(cpu)) + return -EOPNOTSUPP; + +retry: + amu_sample =3D per_cpu_ptr(&cpu_amu_samples, cpu); + + last_update =3D amu_sample->last_scale_update; + + /* + * For those CPUs that are in full dynticks mode, and those that have + * not seen tick for a while, try an alternative source for the counters + * (and thus freq scale), if available, for given policy: this boils + * down to identifying an active cpu within the same freq domain, if any. + */ + if (!housekeeping_cpu(cpu, HK_TYPE_TICK) || + time_is_before_jiffies(last_update + msecs_to_jiffies(AMU_SAMPLE_EXP_= MS))) { + struct cpufreq_policy *policy =3D cpufreq_cpu_get(cpu); + int ref_cpu =3D cpu; + + if (!policy) + return 0; + + if (!cpumask_intersects(policy->related_cpus, + housekeeping_cpumask(HK_TYPE_TICK))) { + cpufreq_cpu_put(policy); + return -EOPNOTSUPP; + } + + + do { + ref_cpu =3D cpumask_next_wrap(ref_cpu, policy->cpus, + start_cpu, false); + + } while (ref_cpu < nr_cpu_ids && idle_cpu(ref_cpu)); + + cpufreq_cpu_put(policy); + + if (ref_cpu >=3D nr_cpu_ids) + /* No alternative to pull info from */ + return 0; + + cpu =3D ref_cpu; + goto retry; + } + /* + * Reversed computation to the one used to determine + * the arch_freq_scale value + * (see amu_scale_freq_tick for details) + */ + scale =3D arch_scale_freq_capacity(cpu); + freq =3D scale * arch_scale_freq_ref(cpu); + freq >>=3D SCHED_CAPACITY_SHIFT; + return freq; +} + static void amu_fie_setup(const struct cpumask *cpus) { int cpu; --=20 2.25.1