From nobody Sat Nov 30 02:36:21 2024 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 66AB51D2790; Fri, 13 Sep 2024 02:02:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726192939; cv=none; b=TkAKaC0CwV9YH/dkedC0q+ixHrskPOvdvSDrzB+ebq1XgLKmTlVm8VQaZ1AZYkYxRaLvscBkhyYU46iIAMUeigVkks/fjaTee/tIVMS+CTJJ8E7IDNK7+EW9TwbeKGs8O5c0Mq4Xws9MRuJMRWD8CVYcvbIFVKvF2K3o20BXPwQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726192939; c=relaxed/simple; bh=3ckeeUMnarcilUH6BQ5qjU1nAgcET4kYYseVsVrI/OQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=aaVEgv1SEWvIeCzDf7NJgHIpTqVlNs0Kz51UuScoAq5t09CLdEHryAaYij7gS0aDsGQPg3E1sdWvfbMTNOpmZUHDtKltOaXuwRiAfJz81Lus5IX0PY2n+lIZ8PBsPE2cgVcEaxmKka5FisxKmI1p3Mdhkn/1ljYtgKzs9XeuzIs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A26D1477; Thu, 12 Sep 2024 19:02:45 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0F3433F66E; Thu, 12 Sep 2024 19:02:13 -0700 (PDT) From: Levi Yun To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, james.clark@linaro.org, asmadeus@codewreck.org Cc: nd@arm.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Levi Yun Subject: [PATCH v2 1/2] perf stat: Close cork_fd when create_perf_stat_counter() failed Date: Fri, 13 Sep 2024 03:02:08 +0100 Message-Id: <20240913020209.520104-2-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240913020209.520104-1-yeoreum.yun@arm.com> References: <20240913020209.520104-1-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When create_perf_stat_counter() failed, it doesn't close workload.cork_fd open in evlist__prepare_workload(). This could make too many open file error while __run_perf_stat() repeats. Introduce evlist__cancel_workload to close workload.cork_fd and wait workload.child_pid until exit to clear child process when create_perf_stat_counter() is failed with COUNTER_FATAL. Signed-off-by: Levi Yun Reviewed-by: James Clark --- tools/perf/builtin-stat.c | 4 ++++ tools/perf/util/evlist.c | 14 +++++++++++++- tools/perf/util/evlist.h | 1 + 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 661832756a24..954eb37ce7b8 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -763,6 +763,8 @@ static int __run_perf_stat(int argc, const char **argv,= int run_idx) switch (stat_handle_error(counter)) { case COUNTER_FATAL: + if (forks) + evlist__cancel_workload(evsel_list); return -1; case COUNTER_RETRY: goto try_again; @@ -804,6 +806,8 @@ static int __run_perf_stat(int argc, const char **argv,= int run_idx) switch (stat_handle_error(counter)) { case COUNTER_FATAL: + if (forks) + evlist__cancel_workload(evsel_list); return -1; case COUNTER_RETRY: goto try_again_reset; diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 3a719edafc7a..51a221679c92 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c @@ -46,6 +46,7 @@ #include #include #include +#include #include #include @@ -1465,7 +1466,7 @@ int evlist__prepare_workload(struct evlist *evlist, s= truct target *target, const * For cancelling the workload without actually running it, * the parent will just close workload.cork_fd, without writing * anything, i.e. read will return zero and we just exit() - * here. + * here (See evlist__cancel_workload()). */ if (ret !=3D 1) { if (ret =3D=3D -1) @@ -1546,6 +1547,17 @@ int evlist__start_workload(struct evlist *evlist) return 0; } +void evlist__cancel_workload(struct evlist *evlist) +{ + int status; + + if (evlist->workload.cork_fd > 0) { + close(evlist->workload.cork_fd); + evlist->workload.cork_fd =3D -1; + waitpid(evlist->workload.pid, &status, WNOHANG); + } +} + int evlist__parse_sample(struct evlist *evlist, union perf_event *event, s= truct perf_sample *sample) { struct evsel *evsel =3D evlist__event2evsel(evlist, event); diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h index cb91dc9117a2..12f929ffdf92 100644 --- a/tools/perf/util/evlist.h +++ b/tools/perf/util/evlist.h @@ -184,6 +184,7 @@ int evlist__prepare_workload(struct evlist *evlist, str= uct target *target, const char *argv[], bool pipe_output, void (*exec_error)(int signo, siginfo_t *info, void *ucontext)); int evlist__start_workload(struct evlist *evlist); +void evlist__cancel_workload(struct evlist *evlist); struct option; -- LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7} From nobody Sat Nov 30 02:36:21 2024 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4BCF91D3199; Fri, 13 Sep 2024 02:02:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726192940; cv=none; b=uIpBIJAKqL7Ztc1LNF6HR+BVfEfAuc8G5EYQNpEH9vYANs8VM91aRSrTwGrEly2ewaNz0+jPqCUy1HrL+slKwr3Px6N3PBTwE6eEOxBdDDC9m833+QioSnlSuTSmwMN4JOeLLAfgniCOchYMTjWR93iw6her9x9kz/g1LsV9RsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726192940; c=relaxed/simple; bh=atQ2R8pD/pTPo3SqpiX8/UYHoq8DEAfBiIARSOB7iW0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Gd5GKk/RPaaX9by7XR9XZFGD7Etona9I0SL42kO8AAtMasdi/p1fBFkjgJTKXIOgGpGxFzmiI4ZYtHOC9/oU1UnPGIuPJ0+3HLH2EcmjsNff8hQXyeaJl0HGXEfrO5Kmuf96FSoxqJ7Zx1LzNqmafjtxBSH6j4J92kihi7bpbSM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09DF11650; Thu, 12 Sep 2024 19:02:48 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 74B2B3F66E; Thu, 12 Sep 2024 19:02:16 -0700 (PDT) From: Levi Yun To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, james.clark@linaro.org, asmadeus@codewreck.org Cc: nd@arm.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Levi Yun Subject: [PATCH v2 2/2] perf stat: Stop repeating when ref_perf_stat() returns -1 Date: Fri, 13 Sep 2024 03:02:09 +0100 Message-Id: <20240913020209.520104-3-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240913020209.520104-1-yeoreum.yun@arm.com> References: <20240913020209.520104-1-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Exit when run_perf_stat() returns an error to avoid continuously repeating the same error message. It's not expected that COUNTER_FATAL or internal errors are recoverable so there's no point in retrying. This fixes the following flood of error messages for permission issues, for example when perf_event_paranoid=3D=3D3: perf stat -r 1044 -- false Error: Access to performance monitoring and observability operations is limited. ... Error: Access to performance monitoring and observability operations is limited. ... (repeating for 1044 times). Signed-off-by: Levi Yun --- Changes in v2: - Add some comments. --- tools/perf/builtin-stat.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 954eb37ce7b8..0153925f2382 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -2875,7 +2875,15 @@ int cmd_stat(int argc, const char **argv) evlist__reset_prev_raw_counts(evsel_list); status =3D run_perf_stat(argc, argv, run_idx); - if (forever && status !=3D -1 && !interval) { + /* + * * Meet COUNTER_FATAL situation (i.e) can't open event counter. + * * In this case, there is a high chance of failure in the next attempt + * * as well with the same reason. so, stop it. + * */ + if (status =3D=3D -1) + break; + + if (forever && !interval) { print_counters(NULL, argc, argv); perf_stat__reset_stats(); } -- LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}