From nobody Sat Nov 30 05:26:06 2024 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EECE1AD9FD; Wed, 11 Sep 2024 14:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.60.130.6 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726065952; cv=none; b=BDb7SlBG4QD6jLArC/ORyJnxKFquSzNACScn/zmcDOzRXKvlwbSd893TaUFecvWSICQq3H6MCC7gpxcQts7m0DqMqFdTVm1vHqK5Gh5mtmBsvKmUVSZH7w7d28gTIpkY+GzHsWHSckOmj1FfRmeN8fmmYoFDCnu5jW2eIHgyy28= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726065952; c=relaxed/simple; bh=+4df8y2p/MI9R+0ry8uI0ow98RTEWRxW2HDqEQ0Sz54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EIXT5ejuJ/aYGfzWZIvIWd1u/LV+YQm8rkdEAHSxS2HqwjGRynjZutbTUraKIgVc23Amh7VNEvdgDiH0IW1sg+YVicnMeP8jOu44zQf3zWodoWpQSIXz10eDIq0LJzt4YKAA+llwwTL14ZxftlP3BR+4Yc/oPaCEAP/+jxcQSSQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=FmEHDMG7; arc=none smtp.client-ip=178.60.130.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="FmEHDMG7" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kMwi9DgjI7/4v55ZzZscrcyDvk5lH8JPPPnq5o6cGm4=; b=FmEHDMG7eXG0TEGGUg8tka63zK RnKBDbAXjJqpfqHBUAcPugh2cNDiWQ0po9F4c3IwIaT0Jc7gVNacP6mCQMf0yPKzqfOQfZs8IwGmv 5iKwUQQ775VWfdLlDKuT6Z/eLOdkST79naFS28AUdk0lxUjvDxginAYs5OSVEdu59EGsUO3p1PGc4 va4ORflAzosENoLy71Jw4KuKkR3poXZC93u7SrvFwMV4keO9skIW6nHStCFY8bzfBXa9kgw2HAH9g zHoxIJKJhA+iQm3bu4SUKXKDLIeymG7T13PVtH9ZYRNy2ITJsW3PtqXN/cYB6B1jGyyovMLfOo4dV uj/VJYow==; Received: from [177.172.122.98] (helo=localhost.localdomain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1soObF-00CTwi-2s; Wed, 11 Sep 2024 16:45:41 +0200 From: =?UTF-8?q?Andr=C3=A9=20Almeida?= To: Hugh Dickins , Andrew Morton , Alexander Viro , Christian Brauner , Jan Kara , krisman@kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-dev@igalia.com, Daniel Rosenberg , smcv@collabora.com, Christoph Hellwig , Theodore Ts'o , =?UTF-8?q?Andr=C3=A9=20Almeida?= Subject: [PATCH v4 07/10] tmpfs: Add casefold lookup support Date: Wed, 11 Sep 2024 11:44:59 -0300 Message-ID: <20240911144502.115260-8-andrealmeid@igalia.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240911144502.115260-1-andrealmeid@igalia.com> References: <20240911144502.115260-1-andrealmeid@igalia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Enable casefold lookup in tmpfs, based on the encoding defined by userspace. That means that instead of comparing byte per byte a file name, it compares to a case-insensitive equivalent of the Unicode string. * Dcache handling There's a special need when dealing with case-insensitive dentries. First of all, we currently invalidated every negative casefold dentries. That happens because currently VFS code has no proper support to deal with that, giving that it could incorrectly reuse a previous filename for a new file that has a casefold match. For instance, this could happen: $ mkdir DIR $ rm -r DIR $ mkdir dir $ ls DIR/ And would be perceived as inconsistency from userspace point of view, because even that we match files in a case-insensitive manner, we still honor whatever is the initial filename. Along with that, tmpfs stores only the first equivalent name dentry used in the dcache, preventing duplications of dentries in the dcache. The d_compare() version for casefold files uses a normalized string, so the filename under lookup will be compared to another normalized string for the existing file, achieving a casefolded lookup. * Enabling casefold via mount options Most filesystems have their data stored in disk, so casefold option need to be enabled when building a filesystem on a device (via mkfs). However, as tmpfs is a RAM backed filesystem, there's no disk information and thus no mkfs to store information about casefold. For tmpfs, create casefold options for mounting. Userspace can then enable casefold support for a mount point using: $ mount -t tmpfs -o casefold=3Dutf8-12.1.0 fs_name mount_dir/ Userspace must set what Unicode standard is aiming to. The available options depends on what the kernel Unicode subsystem supports. And for strict encoding: $ mount -t tmpfs -o casefold=3Dutf8-12.1.0,strict_encoding fs_name mount_di= r/ Strict encoding means that tmpfs will refuse to create invalid UTF-8 sequences. When this option is not enabled, any invalid sequence will be treated as an opaque byte sequence, ignoring the encoding thus not being able to be looked up in a case-insensitive way. Signed-off-by: Andr=C3=A9 Almeida --- Changes from v3: - Simplified shmem_parse_opt_casefold() - sb->s_d_op is set to shmem_ci_dentry_ops during mount time - got rid of shmem_lookup(), modified simple_lookup() Changes from v2: - simple_lookup() now sets d_ops - reworked shmem_parse_opt_casefold() - if `mount -o casefold` has no param, load latest UTF-8 version - using (IS_ENABLED(CONFIG_UNICODE) && IS_CASEFOLDED(dir) when possible --- mm/shmem.c | 119 +++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 115 insertions(+), 4 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index 5a77acf6ac6a..4fde63596ab3 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -40,6 +40,8 @@ #include #include #include +#include +#include #include "swap.h" =20 static struct vfsmount *shm_mnt __ro_after_init; @@ -123,6 +125,8 @@ struct shmem_options { bool noswap; unsigned short quota_types; struct shmem_quota_limits qlimits; + struct unicode_map *encoding; + bool strict_encoding; #define SHMEM_SEEN_BLOCKS 1 #define SHMEM_SEEN_INODES 2 #define SHMEM_SEEN_HUGE 4 @@ -3427,6 +3431,10 @@ shmem_mknod(struct mnt_idmap *idmap, struct inode *d= ir, if (IS_ERR(inode)) return PTR_ERR(inode); =20 + if (IS_ENABLED(CONFIG_UNICODE) && + !generic_ci_validate_strict_name(dir, &dentry->d_name)) + return -EINVAL; + error =3D simple_acl_create(dir, inode); if (error) goto out_iput; @@ -3442,7 +3450,12 @@ shmem_mknod(struct mnt_idmap *idmap, struct inode *d= ir, dir->i_size +=3D BOGO_DIRENT_SIZE; inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); inode_inc_iversion(dir); - d_instantiate(dentry, inode); + + if (IS_ENABLED(CONFIG_UNICODE) && IS_CASEFOLDED(dir)) + d_add(dentry, inode); + else + d_instantiate(dentry, inode); + dget(dentry); /* Extra count - pin the dentry in core */ return error; =20 @@ -3533,7 +3546,10 @@ static int shmem_link(struct dentry *old_dentry, str= uct inode *dir, inc_nlink(inode); ihold(inode); /* New dentry reference */ dget(dentry); /* Extra pinning count for the created dentry */ - d_instantiate(dentry, inode); + if (IS_ENABLED(CONFIG_UNICODE) && IS_CASEFOLDED(dir)) + d_add(dentry, inode); + else + d_instantiate(dentry, inode); out: return ret; } @@ -3553,6 +3569,14 @@ static int shmem_unlink(struct inode *dir, struct de= ntry *dentry) inode_inc_iversion(dir); drop_nlink(inode); dput(dentry); /* Undo the count from "create" - does all the work */ + + /* + * For now, VFS can't deal with case-insensitive negative dentries, so + * we invalidate them + */ + if (IS_ENABLED(CONFIG_UNICODE) && IS_CASEFOLDED(dir)) + d_invalidate(dentry); + return 0; } =20 @@ -3697,7 +3721,10 @@ static int shmem_symlink(struct mnt_idmap *idmap, st= ruct inode *dir, dir->i_size +=3D BOGO_DIRENT_SIZE; inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); inode_inc_iversion(dir); - d_instantiate(dentry, inode); + if (IS_ENABLED(CONFIG_UNICODE) && IS_CASEFOLDED(dir)) + d_add(dentry, inode); + else + d_instantiate(dentry, inode); dget(dentry); return 0; =20 @@ -4050,6 +4077,9 @@ enum shmem_param { Opt_usrquota_inode_hardlimit, Opt_grpquota_block_hardlimit, Opt_grpquota_inode_hardlimit, + Opt_casefold_version, + Opt_casefold, + Opt_strict_encoding, }; =20 static const struct constant_table shmem_param_enums_huge[] =3D { @@ -4081,9 +4111,53 @@ const struct fs_parameter_spec shmem_fs_parameters[]= =3D { fsparam_string("grpquota_block_hardlimit", Opt_grpquota_block_hardlimit), fsparam_string("grpquota_inode_hardlimit", Opt_grpquota_inode_hardlimit), #endif + fsparam_string("casefold", Opt_casefold_version), + fsparam_flag ("casefold", Opt_casefold), + fsparam_flag ("strict_encoding", Opt_strict_encoding), {} }; =20 +#if IS_ENABLED(CONFIG_UNICODE) +static int shmem_parse_opt_casefold(struct fs_context *fc, struct fs_param= eter *param, + bool latest_version) +{ + struct shmem_options *ctx =3D fc->fs_private; + unsigned int version =3D UTF8_LATEST; + struct unicode_map *encoding; + char *version_str =3D param->string + 5; + + if (!latest_version) { + if (strncmp(param->string, "utf8-", 5)) + return invalfc(fc, "Only UTF-8 encodings are supported " + "in the format: utf8-"); + + version =3D utf8_parse_version(version_str); + if (version < 0) + return invalfc(fc, "Invalid UTF-8 version: %s", version_str); + } + + encoding =3D utf8_load(version); + + if (IS_ERR(encoding)) { + return invalfc(fc, "Failed loading UTF-8 version: utf8-%u.%u.%u\n", + unicode_major(version), unicode_minor(version), unicode_rev(version)); + } + + pr_info("tmpfs: Using encoding : utf8-%u.%u.%u\n", + unicode_major(version), unicode_minor(version), unicode_rev(version)); + + ctx->encoding =3D encoding; + + return 0; +} +#else +static int shmem_parse_opt_casefold(struct fs_context *fc, struct fs_param= eter *param, + bool latest_version) +{ + return invalfc(fc, "tmpfs: Kernel not built with CONFIG_UNICODE\n"); +} +#endif + static int shmem_parse_one(struct fs_context *fc, struct fs_parameter *par= am) { struct shmem_options *ctx =3D fc->fs_private; @@ -4242,6 +4316,13 @@ static int shmem_parse_one(struct fs_context *fc, st= ruct fs_parameter *param) "Group quota inode hardlimit too large."); ctx->qlimits.grpquota_ihardlimit =3D size; break; + case Opt_casefold_version: + return shmem_parse_opt_casefold(fc, param, false); + case Opt_casefold: + return shmem_parse_opt_casefold(fc, param, true); + case Opt_strict_encoding: + ctx->strict_encoding =3D true; + break; } return 0; =20 @@ -4471,6 +4552,11 @@ static void shmem_put_super(struct super_block *sb) { struct shmem_sb_info *sbinfo =3D SHMEM_SB(sb); =20 +#if IS_ENABLED(CONFIG_UNICODE) + if (sb->s_encoding) + utf8_unload(sb->s_encoding); +#endif + #ifdef CONFIG_TMPFS_QUOTA shmem_disable_quotas(sb); #endif @@ -4481,6 +4567,17 @@ static void shmem_put_super(struct super_block *sb) sb->s_fs_info =3D NULL; } =20 +#if IS_ENABLED(CONFIG_UNICODE) +static const struct dentry_operations shmem_ci_dentry_ops =3D { + .d_hash =3D generic_ci_d_hash, + .d_compare =3D generic_ci_d_compare, +#ifdef CONFIG_FS_ENCRYPTION + .d_revalidate =3D fscrypt_d_revalidate, +#endif + .d_delete =3D always_delete_dentry, +}; +#endif + static int shmem_fill_super(struct super_block *sb, struct fs_context *fc) { struct shmem_options *ctx =3D fc->fs_private; @@ -4515,9 +4612,21 @@ static int shmem_fill_super(struct super_block *sb, = struct fs_context *fc) } sb->s_export_op =3D &shmem_export_ops; sb->s_flags |=3D SB_NOSEC | SB_I_VERSION; + +#if IS_ENABLED(CONFIG_UNICODE) + if (ctx->encoding) { + sb->s_encoding =3D ctx->encoding; + sb->s_d_op =3D &shmem_ci_dentry_ops; + if (ctx->strict_encoding) + sb->s_encoding_flags =3D SB_ENC_STRICT_MODE_FL; + } #else - sb->s_flags |=3D SB_NOUSER; + sb->s_d_op =3D &simple_dentry_operations; #endif + +#else + sb->s_flags |=3D SB_NOUSER; +#endif /* CONFIG_TMPFS */ sbinfo->max_blocks =3D ctx->blocks; sbinfo->max_inodes =3D ctx->inodes; sbinfo->free_ispace =3D sbinfo->max_inodes * BOGO_INODE_SIZE; @@ -4791,6 +4900,8 @@ int shmem_init_fs_context(struct fs_context *fc) ctx->uid =3D current_fsuid(); ctx->gid =3D current_fsgid(); =20 + ctx->encoding =3D NULL; + fc->fs_private =3D ctx; fc->ops =3D &shmem_fs_context_ops; return 0; --=20 2.46.0