From nobody Sat Nov 30 10:30:46 2024 Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F80C12B143 for ; Tue, 10 Sep 2024 09:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.19.142 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725959864; cv=none; b=mYA/0QpdbLi/0ryeh0pZvOyqPa6HbfJox/z/w6tBOBarCURghzeGPqMn1GxojEG8O3AHiXWbcfdw17iDb7hXyHvq6XGBieQ1x8tR69mIvAZ0b85ZaNhc7HR9z/KCybEpcUrpGg53spMO3NHfNSQ0EFI4pPVGMXF5WX2fxhgoEu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725959864; c=relaxed/simple; bh=aKkuHX71S9fU6GRL+LigNEcI7X+CvpxPZPfHkU0SEpI=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=PQA0R3FlN94tnxKSE9cU4DwEXignbRCPgoclNiwvnNb8BpUIDyELRhcxmDMgmcO8JNlAPT+ySj5bBnOeFxBOdPFghYUunjmFtmKmQutHuJ91kcn5Tk40+7ruCWXbkVkwAZ/8kSOvY7HhfDWGD1ii4CpBTFWHa+jYMNAcXBWhBY0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=jfkHrxq4; arc=none smtp.client-ip=198.47.19.142 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="jfkHrxq4" Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 48A9HJvS083998; Tue, 10 Sep 2024 04:17:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1725959839; bh=b8yjZV6nv1Rb/0+iyalrSE6khPKZSm0V4DNGNDmHOxs=; h=From:To:CC:Subject:Date; b=jfkHrxq4bs4/rSJwp9eYjsznvsC8LWhu4T61T1L8ziLhmcRnru6bVfPF3JGxIdYvR xFL7URMf5u1zxc9xcsaHY9ums5Q2jJ1ZPtDbluPg+hnekvC35HhoqIHRnfAtHVVmgD GtlsszUYsODBlfI1wXokrTlKaUb53SVV1mGsayT4= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 48A9HJsg121695 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 10 Sep 2024 04:17:19 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 10 Sep 2024 04:17:18 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 10 Sep 2024 04:17:18 -0500 Received: from uda0492258.dhcp.ti.com (dhcp-10-24-72-81.dhcp.ti.com [10.24.72.81]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 48A9HFsp051241; Tue, 10 Sep 2024 04:17:15 -0500 From: Siddharth Vadapalli To: , , , , , CC: , , , , Subject: [PATCH] phy: ti: phy-j721e-wiz: fix usxgmii configuration Date: Tue, 10 Sep 2024 14:47:14 +0530 Message-ID: <20240910091714.1082191-1-s-vadapalli@ti.com> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Content-Type: text/plain; charset="utf-8" Commit b64a85fb8f53 ("phy: ti: phy-j721e-wiz.c: Add usxgmii support in wiz driver") added support for USXGMII mode. In doing so, P0_REFCLK_SEL was set to "pcs_mac_clk_divx1_ln_0" (0x3) and P0_STANDARD_MODE was set to LANE_MODE_GEN1, which results in a data rate of 5.15625 Gbps. However, since the USXGMII mode can support up to 10.3125 Gbps data rate, the aforementioned fields should be set to "pcs_mac_clk_divx0_ln_0" (0x2) and LANE_MODE_GEN2 respectively. Fix the configuration accordingly to truly support USXGMII up to 10G. Fixes: b64a85fb8f53 ("phy: ti: phy-j721e-wiz.c: Add usxgmii support in wiz = driver") Signed-off-by: Siddharth Vadapalli --- Hello, This patch is based on commit bc83b4d1f086 Merge tag 'bcachefs-2024-09-09' of git://evilpiepirate.org/bca= chefs of Mainline Linux. Regards, Siddharth. drivers/phy/ti/phy-j721e-wiz.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index 7f626c597025..aa45d77dd733 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers/phy/ti/phy-j721e-wiz.c @@ -450,8 +450,8 @@ static int wiz_mode_select(struct wiz *wiz) } else if (wiz->lane_phy_type[i] =3D=3D PHY_TYPE_USXGMII) { ret =3D regmap_field_write(wiz->p0_mac_src_sel[i], 0x3); ret =3D regmap_field_write(wiz->p0_rxfclk_sel[i], 0x3); - ret =3D regmap_field_write(wiz->p0_refclk_sel[i], 0x3); - mode =3D LANE_MODE_GEN1; + ret =3D regmap_field_write(wiz->p0_refclk_sel[i], 0x2); + mode =3D LANE_MODE_GEN2; } else { continue; } --=20 2.40.1