From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 022031779AE for ; Sun, 8 Sep 2024 19:26:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823601; cv=none; b=rxRFr5gM7z4+5LoSDqPMXNuH6pflLbxokGJnFUvh1MiN7twD/k1Id/wfchgFEvQH60iVgi6nhOe21DPR2a87XseWCwRM8Vu3U7ky5MDmU+DWp+/ZFVcvtE/SEdKcdKucj6n5Mo6uTPa5GvQwg/LyOMzo8kaJ+faqKpKFbykuH5Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823601; c=relaxed/simple; bh=xScMRekyrWd3mUiQ7E0L3/MfqmlH5JFDA/Bn1zYmYeY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ABUo+pIM4E8okqbeHNs5acWgjhVwjZIh5fMXJ0CTDJS8h/zBiCXq0fHxd4XgpFWwLa1KLasU+vtEvnbSL3L7GbbYZ3UniuxMmRs3Bt+5gUI0WUhbgTs6YYKU3pjeCUdxMu6UbtYMiFEHLkzOw34Mc9usIvnLqjCVx+ZBm9fA+hw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=B2HBznQW; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="B2HBznQW" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-20551eeba95so32318935ad.2 for ; Sun, 08 Sep 2024 12:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823597; x=1726428397; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OwXZUX4Z+vcVxrrhy8ieqDIViAshGkVvuwYrqufxEM4=; b=B2HBznQWyz8ueMNeFcHTmZ+k+fHlcegA5fCewRcbQRNEU/eJ/UDc9z0t9GOPua7y/c oK/exqWa4Ba153+xw9GCCrNqFbkPMuMFbJQgeuhoXCxsmCL1gmt9AUYb/jvsXXyHob4s 3YpWudRQqrYkCI0X+vB4fIQ649/gxMLIfFaiC/fSRT2wr/3Pw42//Y4adtPl2XBTbVEZ Fh4GUazCMu3l/ZAgwnx83jyElyQgF34gidugfdM3y2qjpVZ0NQ2SfHOXxrBubM/KR28O c1s96p9s4hoi0KSCzV9jAbuCs9nLj4xnIp5nmAhcFEf/Z6DGcTCYG9qJS5fowgdrmxH5 vmyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823597; x=1726428397; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OwXZUX4Z+vcVxrrhy8ieqDIViAshGkVvuwYrqufxEM4=; b=AVE4t7VO6dsBdfTx/bpSLYbdrPMtTX1oslD1AcZ1z6+P86M4/GygGJ1ewyYA2h1bFD I/HCipMoSg9m7YZTey5tvOCUOYgygVY/DcgQYkieRnOHhaRHxToKFteXwz0kCyIp+xAk bqT+LQPjzaAcBNhyOScxUts+F34kMnXfhgJKfgixjbROL8rm70gVsh1ZXsoylPC1HYpY 2NJOHHvYNjeOzRMbXHyHlUE4i7JZ7sM6SfzFUh3S1bYD2stlnOHS0QRuXRyfdxYDn0KY 8qBdyLAHwW9yjIng/47DdpSPpXwV+bM93iWBb1t8b4f/XIWwz62PE2brqbMNBkGuClWL bExw== X-Forwarded-Encrypted: i=1; AJvYcCW6XTid2vGzItVvFWXESKwZ/q9lFk0jtZBxB4SzxKMjRc/QcxJbZqeJwJHGmC4JKUlvgVNe9gDZtKm3WsQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzifkVuDMvdF8eFnf3tgH/datJ0Ig6l95D5bP4cySv5R6yGY2C7 0rZesZOXrBE2M3YOC+ljhpFG1jXU6ZnVJWrxpvwo26i5+Wf5R1FU9FBYXbjhAtc= X-Google-Smtp-Source: AGHT+IFqoRo27AOGROybqNX+oapincC/8GNKCPEbxqvSBUXbpCpbzrJ22xGg5K4nn2C0xHkwKlFINQ== X-Received: by 2002:a17:902:ce81:b0:1fb:1afb:b864 with SMTP id d9443c01a7336-206f049d07amr77361585ad.5.1725823597113; Sun, 08 Sep 2024 12:26:37 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:36 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 01/16] Staging: rtl8192e: Rename variable pReorderEntry Date: Sun, 8 Sep 2024 12:26:18 -0700 Message-Id: <20240908192633.94144-2-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable pReorderEntry to reorder_entry to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl819x_TSProc.c | 20 +++++------ drivers/staging/rtl8192e/rtllib_rx.c | 44 +++++++++++------------ 2 files changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index ed6a488bc7ac..abdae7e36588 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -14,7 +14,7 @@ static void RxPktPendingTimeout(struct timer_list *t) struct rtllib_device *ieee =3D container_of(ts, struct rtllib_device, rx_ts_records[ts->num]); =20 - struct rx_reorder_entry *pReorderEntry =3D NULL; + struct rx_reorder_entry *reorder_entry =3D NULL; =20 unsigned long flags =3D 0; u8 index =3D 0; @@ -23,31 +23,31 @@ static void RxPktPendingTimeout(struct timer_list *t) spin_lock_irqsave(&(ieee->reorder_spinlock), flags); if (ts->rx_timeout_indicate_seq !=3D 0xffff) { while (!list_empty(&ts->rx_pending_pkt_list)) { - pReorderEntry =3D (struct rx_reorder_entry *) + reorder_entry =3D (struct rx_reorder_entry *) list_entry(ts->rx_pending_pkt_list.prev, struct rx_reorder_entry, list); if (index =3D=3D 0) - ts->rx_indicate_seq =3D pReorderEntry->SeqNum; + ts->rx_indicate_seq =3D reorder_entry->SeqNum; =20 - if (SN_LESS(pReorderEntry->SeqNum, + if (SN_LESS(reorder_entry->SeqNum, ts->rx_indicate_seq) || - SN_EQUAL(pReorderEntry->SeqNum, + SN_EQUAL(reorder_entry->SeqNum, ts->rx_indicate_seq)) { - list_del_init(&pReorderEntry->list); + list_del_init(&reorder_entry->list); =20 - if (SN_EQUAL(pReorderEntry->SeqNum, + if (SN_EQUAL(reorder_entry->SeqNum, ts->rx_indicate_seq)) ts->rx_indicate_seq =3D (ts->rx_indicate_seq + 1) % 4096; =20 netdev_dbg(ieee->dev, "%s(): Indicate SeqNum: %d\n", - __func__, pReorderEntry->SeqNum); + __func__, reorder_entry->SeqNum); ieee->stats_IndicateArray[index] =3D - pReorderEntry->prxb; + reorder_entry->prxb; index++; =20 - list_add_tail(&pReorderEntry->list, + list_add_tail(&reorder_entry->list, &ieee->RxReorder_Unused_List); } else { pkt_in_buf =3D true; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index d7d59761e0f4..cba4b244f808 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -403,26 +403,26 @@ static int is_duplicate_packet(struct rtllib_device *= ieee, } =20 static bool add_reorder_entry(struct rx_ts_record *ts, - struct rx_reorder_entry *pReorderEntry) + struct rx_reorder_entry *reorder_entry) { struct list_head *list =3D &ts->rx_pending_pkt_list; =20 while (list->next !=3D &ts->rx_pending_pkt_list) { - if (SN_LESS(pReorderEntry->SeqNum, ((struct rx_reorder_entry *) + if (SN_LESS(reorder_entry->SeqNum, ((struct rx_reorder_entry *) list_entry(list->next, struct rx_reorder_entry, list))->SeqNum)) list =3D list->next; - else if (SN_EQUAL(pReorderEntry->SeqNum, + else if (SN_EQUAL(reorder_entry->SeqNum, ((struct rx_reorder_entry *)list_entry(list->next, struct rx_reorder_entry, list))->SeqNum)) return false; else break; } - pReorderEntry->list.next =3D list->next; - pReorderEntry->list.next->prev =3D &pReorderEntry->list; - pReorderEntry->list.prev =3D list; - list->next =3D &pReorderEntry->list; + reorder_entry->list.next =3D list->next; + reorder_entry->list.next->prev =3D &reorder_entry->list; + reorder_entry->list.prev =3D list; + list->next =3D &reorder_entry->list; =20 return true; } @@ -524,7 +524,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, struct rx_ts_record *ts, u16 SeqNum) { struct rt_hi_throughput *ht_info =3D ieee->ht_info; - struct rx_reorder_entry *pReorderEntry =3D NULL; + struct rx_reorder_entry *reorder_entry =3D NULL; u8 win_size =3D ht_info->rx_reorder_win_size; u16 win_end =3D 0; u8 index =3D 0; @@ -598,25 +598,25 @@ static void rx_reorder_indicate_packet(struct rtllib_= device *ieee, } else { /* Current packet is going to be inserted into pending list.*/ if (!list_empty(&ieee->RxReorder_Unused_List)) { - pReorderEntry =3D (struct rx_reorder_entry *) + reorder_entry =3D (struct rx_reorder_entry *) list_entry(ieee->RxReorder_Unused_List.next, struct rx_reorder_entry, list); - list_del_init(&pReorderEntry->list); + list_del_init(&reorder_entry->list); =20 /* Make a reorder entry and insert * into a the packet list. */ - pReorderEntry->SeqNum =3D SeqNum; - pReorderEntry->prxb =3D prxb; + reorder_entry->SeqNum =3D SeqNum; + reorder_entry->prxb =3D prxb; =20 - if (!add_reorder_entry(ts, pReorderEntry)) { + if (!add_reorder_entry(ts, reorder_entry)) { int i; =20 netdev_dbg(ieee->dev, "%s(): Duplicate packet is dropped. IndicateSeq: %d, NewSeq: %d\n", __func__, ts->rx_indicate_seq, SeqNum); - list_add_tail(&pReorderEntry->list, + list_add_tail(&reorder_entry->list, &ieee->RxReorder_Unused_List); =20 for (i =3D 0; i < prxb->nr_subframes; i++) @@ -653,12 +653,12 @@ static void rx_reorder_indicate_packet(struct rtllib_= device *ieee, netdev_dbg(ieee->dev, "%s(): start RREORDER indicate\n", __func__); =20 - pReorderEntry =3D (struct rx_reorder_entry *) + reorder_entry =3D (struct rx_reorder_entry *) list_entry(ts->rx_pending_pkt_list.prev, struct rx_reorder_entry, list); - if (SN_LESS(pReorderEntry->SeqNum, ts->rx_indicate_seq) || - SN_EQUAL(pReorderEntry->SeqNum, ts->rx_indicate_seq)) { + if (SN_LESS(reorder_entry->SeqNum, ts->rx_indicate_seq) || + SN_EQUAL(reorder_entry->SeqNum, ts->rx_indicate_seq)) { /* This protect struct buffer from overflow. */ if (index >=3D REORDER_WIN_SIZE) { netdev_err(ieee->dev, @@ -668,18 +668,18 @@ static void rx_reorder_indicate_packet(struct rtllib_= device *ieee, break; } =20 - list_del_init(&pReorderEntry->list); + list_del_init(&reorder_entry->list); =20 - if (SN_EQUAL(pReorderEntry->SeqNum, ts->rx_indicate_seq)) + if (SN_EQUAL(reorder_entry->SeqNum, ts->rx_indicate_seq)) ts->rx_indicate_seq =3D (ts->rx_indicate_seq + 1) % 4096; =20 - ieee->prxb_indicate_array[index] =3D pReorderEntry->prxb; + ieee->prxb_indicate_array[index] =3D reorder_entry->prxb; netdev_dbg(ieee->dev, "%s(): Indicate SeqNum %d!\n", - __func__, pReorderEntry->SeqNum); + __func__, reorder_entry->SeqNum); index++; =20 - list_add_tail(&pReorderEntry->list, + list_add_tail(&reorder_entry->list, &ieee->RxReorder_Unused_List); } else { pkt_in_buf =3D true; --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5537E17839E for ; Sun, 8 Sep 2024 19:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823602; cv=none; b=BbP4dFmMhPe2HS2XKu4I+/eU6tT82n6OLH4GX2tkO9X9vjbKmU1AAO2dIIXfNdS7Ha0hhfmMa+Y2G/0+tfTghlNF1W9Oz7r+bRzbHY942mJTGoFtQBx8STJvQ3GzJjBo58Ag4vtSO6IoNrf8bwes2coe7wfiRXljlf2b9Di9ZEQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823602; c=relaxed/simple; bh=nnxSeJG1du5Z643YEwdX5f5Vtc1/2IdyblEz7jkp4yc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Enps81W7Zpugs/HNVPo5O0rTrAoYG4/UIAW4VnYbSceBcU/HMfFafsT9mpCYaxpOmNsfLefnd0r9fBJ4WS3bVJhyKuw/BvlY2K/L0RSQdjLNx3pv/SMueFx1+GNMZvEEN5n40CzF7lnAHSPkoC0JYFuQYb+dvEBTIN4CWI5V9j8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=U1wshDkC; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="U1wshDkC" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-20543fdb7acso25379925ad.1 for ; Sun, 08 Sep 2024 12:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823599; x=1726428399; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2KFmE8ZulfeBSFNzpno4ob0I7YnPxB69tGPDL4yyv3E=; b=U1wshDkC0oumaURVKLje5B6MSX7o5caWlKqeZ6XQKQleffGbl16oy1NHPMmiZAF1/I Ng2T6sWW6byw4P16AsUHP5ZO/mUw7Y0hIvG8Hc3XN6wU7VTgpJXLS0Q4LBRdRZsj92PL cF3U1QLAcO9zQbj7BHYaSQNP6wjO7QfDZZ8GRSl3jl/F62cm7CY/RudqF1OIyje78eM2 aC/3k9qox9SKEPzxo0OWSxK7gUIKTTwX09Zx5RLo2VT7KgyMFRpXWwKJ2YDqLBbaaPW9 DM5C80H4Fy0uQVmVIjPcNp1ClvsBN4335m1WPn1DXT2BOvd0NN2vsNhZj/mZeNPrrSsQ tfsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823599; x=1726428399; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2KFmE8ZulfeBSFNzpno4ob0I7YnPxB69tGPDL4yyv3E=; b=w7MpClfdvUfzvdEn2yAvbG4bnTYn7KkBC2YnKXg99ywKfnqIEGE3KIjbsEHaiiK5Ci bySHszKJwmv/hgyq2sCZnU9/o6rijsFekSb8y6DBM2Z0jtxuKUNoqIiTeMTYpikbdNTe QBp9Yln1K588fc/drJwIpAQi7F2PbKhpclyXDgw+V7igcEsmI9sRedZmAW5ej0/myW2F o7bS945PI9n8K3aj7xjZY9tKPbzHnSwJQnYlO9Vjculkpo8/ldXsx+Qkbs3h7NnfUGDJ u1c20t9s3jQojgt1lJ6+nk5sQzV2nxmeJUbYWbtkQDuSICbSaxrAyrkTenOq9u5Svu6W 5jFg== X-Forwarded-Encrypted: i=1; AJvYcCWICgNMc9iP1VrYejvYtAZ9EijfTw4VixSbFoM3OKNY7uLagLzys0RU4yvY+89AhnZvsOMtBdSEb9TKOek=@vger.kernel.org X-Gm-Message-State: AOJu0YxJ9wRb1/JSHsrHJ3kiCgJmZ0Bvvw4mh15YWXH4BxBK70QKAcUZ h8DQPGLkWV/QTzAWIQGOrjdeGeM9CDcrzvD/JMkDR4ciqCdvyOO3ZEh2sBJjBnM= X-Google-Smtp-Source: AGHT+IFvS1aEBHwmx8e4GGbJhqwm4CP0mEI0CwkXQ6mMnwELs5iJUf/tFOkWbnuJ9pDWYSn3VV8rag== X-Received: by 2002:a17:902:dacc:b0:206:8c4a:7bbb with SMTP id d9443c01a7336-206f065bddbmr87077335ad.58.1725823598394; Sun, 08 Sep 2024 12:26:38 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:37 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 02/16] Staging: rtl8192e: Rename variable SeqNum Date: Sun, 8 Sep 2024 12:26:19 -0700 Message-Id: <20240908192633.94144-3-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable SeqNum to seq_num to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl819x_TSProc.c | 16 ++--- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_rx.c | 78 +++++++++++------------ 3 files changed, 48 insertions(+), 48 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index abdae7e36588..18b717a7409c 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -27,22 +27,22 @@ static void RxPktPendingTimeout(struct timer_list *t) list_entry(ts->rx_pending_pkt_list.prev, struct rx_reorder_entry, list); if (index =3D=3D 0) - ts->rx_indicate_seq =3D reorder_entry->SeqNum; + ts->rx_indicate_seq =3D reorder_entry->seq_num; =20 - if (SN_LESS(reorder_entry->SeqNum, + if (SN_LESS(reorder_entry->seq_num, ts->rx_indicate_seq) || - SN_EQUAL(reorder_entry->SeqNum, + SN_EQUAL(reorder_entry->seq_num, ts->rx_indicate_seq)) { list_del_init(&reorder_entry->list); =20 - if (SN_EQUAL(reorder_entry->SeqNum, + if (SN_EQUAL(reorder_entry->seq_num, ts->rx_indicate_seq)) ts->rx_indicate_seq =3D (ts->rx_indicate_seq + 1) % 4096; =20 netdev_dbg(ieee->dev, - "%s(): Indicate SeqNum: %d\n", - __func__, reorder_entry->SeqNum); + "%s(): Indicate seq_num: %d\n", + __func__, reorder_entry->seq_num); ieee->stats_IndicateArray[index] =3D reorder_entry->prxb; index++; @@ -336,8 +336,8 @@ static void RemoveTsEntry(struct rtllib_device *ieee, pRxReorderEntry =3D (struct rx_reorder_entry *) list_entry(ts->rx_pending_pkt_list.prev, struct rx_reorder_entry, list); - netdev_dbg(ieee->dev, "%s(): Delete SeqNum %d!\n", - __func__, pRxReorderEntry->SeqNum); + netdev_dbg(ieee->dev, "%s(): Delete seq_num %d!\n", + __func__, pRxReorderEntry->seq_num); list_del_init(&pRxReorderEntry->list); { int i =3D 0; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 4762cb52261a..b033e8345b0a 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1015,7 +1015,7 @@ struct bandwidth_autoswitch { #define REORDER_ENTRY_NUM 128 struct rx_reorder_entry { struct list_head list; - u16 SeqNum; + u16 seq_num; struct rtllib_rxb *prxb; }; =20 diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index cba4b244f808..86beac9dd3a5 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -408,13 +408,13 @@ static bool add_reorder_entry(struct rx_ts_record *ts, struct list_head *list =3D &ts->rx_pending_pkt_list; =20 while (list->next !=3D &ts->rx_pending_pkt_list) { - if (SN_LESS(reorder_entry->SeqNum, ((struct rx_reorder_entry *) + if (SN_LESS(reorder_entry->seq_num, ((struct rx_reorder_entry *) list_entry(list->next, struct rx_reorder_entry, - list))->SeqNum)) + list))->seq_num)) list =3D list->next; - else if (SN_EQUAL(reorder_entry->SeqNum, + else if (SN_EQUAL(reorder_entry->seq_num, ((struct rx_reorder_entry *)list_entry(list->next, - struct rx_reorder_entry, list))->SeqNum)) + struct rx_reorder_entry, list))->seq_num)) return false; else break; @@ -504,8 +504,8 @@ void rtllib_flush_rx_ts_pending_pkts(struct rtllib_devi= ce *ieee, pRxReorderEntry =3D (struct rx_reorder_entry *) list_entry(ts->rx_pending_pkt_list.prev, struct rx_reorder_entry, list); - netdev_dbg(ieee->dev, "%s(): Indicate SeqNum %d!\n", __func__, - pRxReorderEntry->SeqNum); + netdev_dbg(ieee->dev, "%s(): Indicate seq_num %d!\n", __func__, + pRxReorderEntry->seq_num); list_del_init(&pRxReorderEntry->list); =20 ieee->rfd_array[rfd_cnt] =3D pRxReorderEntry->prxb; @@ -521,7 +521,7 @@ void rtllib_flush_rx_ts_pending_pkts(struct rtllib_devi= ce *ieee, =20 static void rx_reorder_indicate_packet(struct rtllib_device *ieee, struct rtllib_rxb *prxb, - struct rx_ts_record *ts, u16 SeqNum) + struct rx_ts_record *ts, u16 seq_num) { struct rt_hi_throughput *ht_info =3D ieee->ht_info; struct rx_reorder_entry *reorder_entry =3D NULL; @@ -533,20 +533,20 @@ static void rx_reorder_indicate_packet(struct rtllib_= device *ieee, =20 netdev_dbg(ieee->dev, "%s(): Seq is %d, ts->rx_indicate_seq is %d, win_size is %d\n", - __func__, SeqNum, ts->rx_indicate_seq, win_size); + __func__, seq_num, ts->rx_indicate_seq, win_size); =20 spin_lock_irqsave(&(ieee->reorder_spinlock), flags); =20 win_end =3D (ts->rx_indicate_seq + win_size - 1) % 4096; /* Rx Reorder initialize condition.*/ if (ts->rx_indicate_seq =3D=3D 0xffff) - ts->rx_indicate_seq =3D SeqNum; + ts->rx_indicate_seq =3D seq_num; =20 - /* Drop out the packet which SeqNum is smaller than WinStart */ - if (SN_LESS(SeqNum, ts->rx_indicate_seq)) { + /* Drop out the packet which seq_num is smaller than WinStart */ + if (SN_LESS(seq_num, ts->rx_indicate_seq)) { netdev_dbg(ieee->dev, "Packet Drop! IndicateSeq: %d, NewSeq: %d\n", - ts->rx_indicate_seq, SeqNum); + ts->rx_indicate_seq, seq_num); ht_info->rx_reorder_drop_counter++; { int i; @@ -561,38 +561,38 @@ static void rx_reorder_indicate_packet(struct rtllib_= device *ieee, } =20 /* Sliding window manipulation. Conditions includes: - * 1. Incoming SeqNum is equal to WinStart =3D>Window shift 1 - * 2. Incoming SeqNum is larger than the win_end =3D> Window shift N + * 1. Incoming seq_num is equal to WinStart =3D>Window shift 1 + * 2. Incoming seq_num is larger than the win_end =3D> Window shift N */ - if (SN_EQUAL(SeqNum, ts->rx_indicate_seq)) { + if (SN_EQUAL(seq_num, ts->rx_indicate_seq)) { ts->rx_indicate_seq =3D (ts->rx_indicate_seq + 1) % 4096; match_win_start =3D true; - } else if (SN_LESS(win_end, SeqNum)) { - if (SeqNum >=3D (win_size - 1)) - ts->rx_indicate_seq =3D SeqNum + 1 - win_size; + } else if (SN_LESS(win_end, seq_num)) { + if (seq_num >=3D (win_size - 1)) + ts->rx_indicate_seq =3D seq_num + 1 - win_size; else ts->rx_indicate_seq =3D 4095 - - (win_size - (SeqNum + 1)) + 1; + (win_size - (seq_num + 1)) + 1; netdev_dbg(ieee->dev, "Window Shift! IndicateSeq: %d, NewSeq: %d\n", - ts->rx_indicate_seq, SeqNum); + ts->rx_indicate_seq, seq_num); } =20 /* Indication process. * After Packet dropping and Sliding Window shifting as above, we can - * now just indicate the packets with the SeqNum smaller than latest + * now just indicate the packets with the seq_num smaller than latest * WinStart and struct buffer other packets. * * For Rx Reorder condition: - * 1. All packets with SeqNum smaller than WinStart =3D> Indicate - * 2. All packets with SeqNum larger than or equal to + * 1. All packets with seq_num smaller than WinStart =3D> Indicate + * 2. All packets with seq_num larger than or equal to * WinStart =3D> Buffer it. */ if (match_win_start) { /* Current packet is going to be indicated.*/ netdev_dbg(ieee->dev, "Packets indication! IndicateSeq: %d, NewSeq: %d\n", - ts->rx_indicate_seq, SeqNum); + ts->rx_indicate_seq, seq_num); ieee->prxb_indicate_array[0] =3D prxb; index =3D 1; } else { @@ -606,7 +606,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, /* Make a reorder entry and insert * into a the packet list. */ - reorder_entry->SeqNum =3D SeqNum; + reorder_entry->seq_num =3D seq_num; reorder_entry->prxb =3D prxb; =20 if (!add_reorder_entry(ts, reorder_entry)) { @@ -615,7 +615,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, netdev_dbg(ieee->dev, "%s(): Duplicate packet is dropped. IndicateSeq: %d, NewSeq: %d\n", __func__, ts->rx_indicate_seq, - SeqNum); + seq_num); list_add_tail(&reorder_entry->list, &ieee->RxReorder_Unused_List); =20 @@ -626,7 +626,7 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, } else { netdev_dbg(ieee->dev, "Pkt insert into struct buffer. IndicateSeq: %d, NewSeq: %d\n", - ts->rx_indicate_seq, SeqNum); + ts->rx_indicate_seq, seq_num); } } else { /* Packets are dropped if there are not enough reorder @@ -657,8 +657,8 @@ static void rx_reorder_indicate_packet(struct rtllib_de= vice *ieee, list_entry(ts->rx_pending_pkt_list.prev, struct rx_reorder_entry, list); - if (SN_LESS(reorder_entry->SeqNum, ts->rx_indicate_seq) || - SN_EQUAL(reorder_entry->SeqNum, ts->rx_indicate_seq)) { + if (SN_LESS(reorder_entry->seq_num, ts->rx_indicate_seq) || + SN_EQUAL(reorder_entry->seq_num, ts->rx_indicate_seq)) { /* This protect struct buffer from overflow. */ if (index >=3D REORDER_WIN_SIZE) { netdev_err(ieee->dev, @@ -670,13 +670,13 @@ static void rx_reorder_indicate_packet(struct rtllib_= device *ieee, =20 list_del_init(&reorder_entry->list); =20 - if (SN_EQUAL(reorder_entry->SeqNum, ts->rx_indicate_seq)) + if (SN_EQUAL(reorder_entry->seq_num, ts->rx_indicate_seq)) ts->rx_indicate_seq =3D (ts->rx_indicate_seq + 1) % 4096; =20 ieee->prxb_indicate_array[index] =3D reorder_entry->prxb; - netdev_dbg(ieee->dev, "%s(): Indicate SeqNum %d!\n", - __func__, reorder_entry->SeqNum); + netdev_dbg(ieee->dev, "%s(): Indicate seq_num %d!\n", + __func__, reorder_entry->seq_num); index++; =20 list_add_tail(&reorder_entry->list, @@ -731,10 +731,10 @@ static u8 parse_subframe(struct rtllib_device *ieee, = struct sk_buff *skb, bool is_aggregate_frame =3D false; u16 subframe_len; u8 pad_len =3D 0; - u16 SeqNum =3D 0; + u16 seq_num =3D 0; struct sk_buff *sub_skb; /* just for debug purpose */ - SeqNum =3D WLAN_GET_SEQ_SEQ(le16_to_cpu(hdr->seq_ctrl)); + seq_num =3D WLAN_GET_SEQ_SEQ(le16_to_cpu(hdr->seq_ctrl)); if ((RTLLIB_QOS_HAS_SEQ(fc)) && (((union frameqos *)(skb->data + RTLLIB_3ADDR_LEN))->field.reserved)) is_aggregate_frame =3D true; @@ -796,8 +796,8 @@ static u8 parse_subframe(struct rtllib_device *ieee, st= ruct sk_buff *skb, "nRemain_Length is %d and subframe_len is : %d\n", skb->len, subframe_len); netdev_info(ieee->dev, - "The Packet SeqNum is %d\n", - SeqNum); + "The Packet seq_num is %d\n", + seq_num); return 0; } =20 @@ -1227,7 +1227,7 @@ static int rtllib_rx_infra_adhoc(struct rtllib_device= *ieee, struct sk_buff *skb struct lib80211_crypt_data *crypt =3D NULL; struct rtllib_rxb *rxb =3D NULL; struct rx_ts_record *ts =3D NULL; - u16 fc, sc, SeqNum =3D 0; + u16 fc, sc, seq_num =3D 0; u8 type, stype, multicast =3D 0, unicast =3D 0, nr_subframes =3D 0, TID = =3D 0; u8 dst[ETH_ALEN]; u8 src[ETH_ALEN]; @@ -1321,7 +1321,7 @@ static int rtllib_rx_infra_adhoc(struct rtllib_device= *ieee, struct sk_buff *skb if (ieee->current_network.qos_data.active && is_qos_data_frame(skb->data) && !is_multicast_ether_addr(hdr->addr1)) { TID =3D frame_qos_tid(skb->data); - SeqNum =3D WLAN_GET_SEQ_SEQ(sc); + seq_num =3D WLAN_GET_SEQ_SEQ(sc); rtllib_get_ts(ieee, (struct ts_common_info **)&ts, hdr->addr2, TID, RX_DIR, true); if (TID !=3D 0 && TID !=3D 3) @@ -1362,7 +1362,7 @@ static int rtllib_rx_infra_adhoc(struct rtllib_device= *ieee, struct sk_buff *skb if (!ieee->ht_info->cur_rx_reorder_enable || !ts) rtllib_rx_indicate_pkt_legacy(ieee, rx_stats, rxb, dst, src); else - rx_reorder_indicate_packet(ieee, rxb, ts, SeqNum); + rx_reorder_indicate_packet(ieee, rxb, ts, seq_num); =20 dev_kfree_skb(skb); =20 --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA948177991 for ; Sun, 8 Sep 2024 19:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823601; cv=none; b=XVy7gkfuzs59auVY9bm+jZAp+3GNafrX2qtBrjhNFNrebL+oe9wzVaCGJuUQ5EVAaD5Lhb9usDnx3EUsly352zsDofEgpKLVTfGt7cLzWIBQ/s0VGqTVzslTm3r2hLDKIB0oVb4sYXoXiNfvLnfavNRWJXcQ63dTCTKAJucHOIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823601; c=relaxed/simple; bh=zbNIVZ0EAkXjfEs2RH4lfSau8YChUlUuLtWGlnaS4k8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PMHcxO/M21jABRY3AwrMXoWwCPPCRT+CChS3SuFbO36oAxZuvTd24jJjYzUsYRzGVQoTyf4f8mJgChiHtw6ou9iWd/b7pbVE16VTHcqICKGrWjzA0rPdCrMP6AGxZrnww30jsO1a8wKfanrBeuBRqoEiknpuERtU8rtnGtdDk4E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=RlaLCNxZ; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="RlaLCNxZ" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2055136b612so42597575ad.0 for ; Sun, 08 Sep 2024 12:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823599; x=1726428399; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZwzpOQ/aAEGoHuaN2ZwbC1rSJVDkP7/Zcai6c3SwE5E=; b=RlaLCNxZbgPPv/WrpqcEBV9ckc/hIXi4WQ0B8EIWKncj34PY0D3z5sAgEUtkf85vol kKk4KjRT0V7r42mOFOq6kdDY/o+M4Z17CIWeOOU55ZxXnyFeMUhKBXMWRyHqPtKgrr+f DuyG8aY/8OTE7LMP5LXVOc/qp+3Un/MGJmxzKeVkT24q9pnzhoNnTUbBi0hhvxuWPmt5 uocvabRhCz6zoQ3PRguFts+p/fVNtfNPT5P63vGwSSzeZ0neYRzp8Ci1tEeUmoVjgjy6 ZA6FuRRj68GKx4bWzR789M9Yo2vxZMVtLvqUxKyB3vfVqPOInExcAK1lUfQ/Ja3gzTuk nlag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823599; x=1726428399; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZwzpOQ/aAEGoHuaN2ZwbC1rSJVDkP7/Zcai6c3SwE5E=; b=WCAhv9UpBaYKySYkb0n38oVDToD8Sfw1nJ4H4KQ2vb9YYdfUhF7h9Yb4OBjpm9QyXO k6iXl+6ClG701cXaKT0Gj1Yp0HWstV63YUMe2dze5y/Ye6lXtybdKX1CJAsQXJEIM4xv FB3EJuln43jIWxC04BiNBqv755MO9VyYOcRVhQh5yJ6crBAU4F4iP5Oq0nylMFVC89wN yiFNeXbzNZQfYeWpy/0GAJlC91PsV/keWDyeA4AS7wzQBTWspqALtfkqwxwOBTOzFDXo e2nf+/wN0WPN0xFUC5XPIbPUmZ8VGaqug1I4UJGYoAw0qgGchJvMXPp65PZtEwC5QZt3 CBDg== X-Forwarded-Encrypted: i=1; AJvYcCUlVpF5i5vesSOp0Ba37AHCV43I8HsXoklH0fZbsOq04Fp6oVGxrvM0OX9UvJCdM/TgqqnO5ycHsRaXih4=@vger.kernel.org X-Gm-Message-State: AOJu0YygREVKsvGct3dT0dsYj8wTg7Io37OaqTKoJ4sMDLf98bD9zP8S Ro873TG2/5+Wf7NsgYSJvYudIQ1UN7Pnw0CQBD1JEd1E7CUPJRnqKeDjT3GgAhz9BtSI3lwNLYT /fwk= X-Google-Smtp-Source: AGHT+IG8TETov1t4f/DlwsU0CtYcnIJ0Wy1ttjyQCelK2ApFt+/VfhEz16eA0j6St9aZ1UIi7e2t6Q== X-Received: by 2002:a17:902:ea01:b0:206:cfb3:7232 with SMTP id d9443c01a7336-206f05e7eafmr145690675ad.48.1725823599059; Sun, 08 Sep 2024 12:26:39 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:38 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 03/16] Staging: rtl8192e: Rename variable SignalStrength Date: Sun, 8 Sep 2024 12:26:20 -0700 Message-Id: <20240908192633.94144-4-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable SignalStrength to signal_strength to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 ++++---- drivers/staging/rtl8192e/rtllib.h | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index f5a46754d65f..a8bb2d3f7e9d 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1319,12 +1319,12 @@ static void _rtl92e_query_rxphystatus(struct r8192_= priv *priv, } =20 if (is_cck_rate) { - pstats->SignalStrength =3D precord_stats->SignalStrength =3D + pstats->signal_strength =3D precord_stats->signal_strength =3D _rtl92e_signal_scale_mapping(priv, (long)pwdb_all); =20 } else { if (rf_rx_num !=3D 0) - pstats->SignalStrength =3D precord_stats->SignalStrength =3D + pstats->signal_strength =3D precord_stats->signal_strength =3D _rtl92e_signal_scale_mapping(priv, (long)(total_rssi /=3D rf_rx_num)); } @@ -1352,10 +1352,10 @@ static void _rtl92e_process_phyinfo(struct r8192_pr= iv *priv, u8 *buffer, last_rssi =3D priv->stats.slide_signal_strength[slide_rssi_index]; priv->stats.slide_rssi_total -=3D last_rssi; } - priv->stats.slide_rssi_total +=3D prev_st->SignalStrength; + priv->stats.slide_rssi_total +=3D prev_st->signal_strength; =20 priv->stats.slide_signal_strength[slide_rssi_index++] =3D - prev_st->SignalStrength; + prev_st->signal_strength; if (slide_rssi_index >=3D PHY_RSSI_SLID_WIN_MAX) slide_rssi_index =3D 0; =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index b033e8345b0a..9f812cedd1b3 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -466,7 +466,7 @@ struct rtllib_rx_stats { u16 Length; u8 SignalQuality; s32 RecvSignalPower; - u8 SignalStrength; + u8 signal_strength; u16 hw_error:1; u16 bCRC:1; u16 bICV:1; @@ -951,7 +951,7 @@ struct rtllib_network { bool unknown_cap_exist; bool berp_info_valid; bool buseprotection; - u8 SignalStrength; + u8 signal_strength; u8 RSSI; struct list_head list; }; diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 86beac9dd3a5..8fe224a83dd6 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -2177,8 +2177,8 @@ static inline int rtllib_network_init( network->marvell_cap_exist =3D false; network->airgo_cap_exist =3D false; network->turbo_enable =3D 0; - network->SignalStrength =3D stats->SignalStrength; - network->RSSI =3D stats->SignalStrength; + network->signal_strength =3D stats->signal_strength; + network->RSSI =3D stats->signal_strength; network->country_ie_len =3D 0; memset(network->country_ie_buf, 0, MAX_IE_LEN); ht_initialize_bss_desc(&network->bssht); @@ -2215,7 +2215,7 @@ static inline int rtllib_network_init( } if (rtllib_is_empty_essid(network->ssid, network->ssid_len)) network->flags |=3D NETWORK_EMPTY_ESSID; - stats->signal =3D 30 + (stats->SignalStrength * 70) / 100; + stats->signal =3D 30 + (stats->signal_strength * 70) / 100; stats->noise =3D rtllib_translate_todbm((u8)(100 - stats->signal)) - 25; =20 memcpy(&network->stats, stats, sizeof(network->stats)); @@ -2334,7 +2334,7 @@ static inline void update_network(struct rtllib_devic= e *ieee, src->wmm_param[3].ac_aci_acm_aifsn) memcpy(dst->wmm_param, src->wmm_param, WME_AC_PRAM_LEN); =20 - dst->SignalStrength =3D src->SignalStrength; + dst->signal_strength =3D src->signal_strength; dst->RSSI =3D src->RSSI; dst->turbo_enable =3D src->turbo_enable; =20 --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AA5E179202 for ; Sun, 8 Sep 2024 19:26:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823601; cv=none; b=BOvAk7oC//vGwxOWtRva54ej/e91DrVT+vajjbiCIRd3HK8P6+5dQmb3aFt0U5EhfrYybOWOSmiMED7RpjFXhtHHxKGYJy/D21qto9F6Txc5kie4s6yQiCpGm3DW2AyMfVxI6JLmKgfRaMxY9SzWms26mlJs6ksfRyIug3m4yGY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823601; c=relaxed/simple; bh=XHwe7H6bexz83D+eLYTBzL3QtD3B+r1/0yJ6B8ukoh0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oLALqwv/v7exezy87eeQajEQFpi6/EKQjrmsTva8B3mob88AxVqqja2VimaGPKMKY4KtXIX9ahfGGJv1nNASiD0pBURu6tjJdqaFNzxef6tqM8xQeypZNcnQbenurh4XRKv/lzRW1Csa6xwL6STRQC1jHuuQjhnmPtWFMROXK98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=SAsjYiXS; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="SAsjYiXS" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2068a7c9286so32786875ad.1 for ; Sun, 08 Sep 2024 12:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823600; x=1726428400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lAAFNjlraLtXoBlcyevuGi2oA1bUESdHP74uZQrkAmE=; b=SAsjYiXSpbyakR7LqE4toSZbHfDQ3ijxhyLy4uIFvvPqyS2yswzvBxnA0JXvHC3vUM ++y7AFpvbpNEsj89+Xwk5/P8t+yPaIfenxsOsu1TUXjWLYOLmh+N2ZjEbwLRSeQClkbr ozEWKUE2z0PtYCi4wh5FP/lIWf65vszHJeiY8a80bvXgQLX8nZdRnakdDiFyF/JVAwMT JLFxOZc1QKxa0Kzp/CRsvrdsTcrX6oYqCMGxB7VITVC8i9v9gRUXjmPCNLvCapQeyTfr 4lsGULFAXxk4Ijr8hjtM6TYafL/MobqZFbBdW7FztzR7g3uObFlD29Fk6pNr+y4eBaKo iL3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823600; x=1726428400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lAAFNjlraLtXoBlcyevuGi2oA1bUESdHP74uZQrkAmE=; b=czf0edgO2BnmXptiqz8xaY6zRecsw+I4X6PySozSl8z85XWutUdnrC67d/Jfhtb1b5 ZosDu0ubpPY+O04FanBgYwUxiM+NsxLF5Y6kady3fslFjT8s2cuzSpecP7PNGaTbuXW4 3Nhu8NIQ6X9kRtdnyW+7bhI+fKKkH3D2Cbd5v+Ec43nJ/1RA0Aslrx0mZnnQLfdt7dpy ERQb4GLxX1wRlDdmwT3BJe9Nx4VJZFjI7bTbsiEUtsXmmTFItJvZp2NSReOX0pBWgcqP LPFNkHyhACUq2Ms9UWWg7OEyy78lniB2uOjt8mYSqEjxfnGbOH4Se2gkrNX08AfM968y wmGA== X-Forwarded-Encrypted: i=1; AJvYcCXYgF1AVjKSn/qpcKVy04XUEBndT1GnJ86iUPEdvK8QzyOjk8CAgIXZrZCN0ZJGccc/l24suq+OxRGIQ/c=@vger.kernel.org X-Gm-Message-State: AOJu0YwPUjXTU/c3IMK0PM2TlPRdEwfRNNPGcIThkQldvokAeg5MjJnl X83OlKk+XVo32mceOtHq97lKEBcybinp/NUjI4obBZjl5I0qA9iw6AKRBpI4BuI= X-Google-Smtp-Source: AGHT+IHN/69yw/KFeXchSAAkjGr/WSIwkimD6G+sYs+qcUtKVBw5d1hD3Uo0qO9V73Yx/2Jyk+ARrQ== X-Received: by 2002:a17:902:dacc:b0:205:76b1:175f with SMTP id d9443c01a7336-206f04e9593mr115995855ad.21.1725823599808; Sun, 08 Sep 2024 12:26:39 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:39 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 04/16] Staging: rtl8192e: Rename variable pFrame Date: Sun, 8 Sep 2024 12:26:21 -0700 Message-Id: <20240908192633.94144-5-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable pFrame to frame to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 188e1fd9554d..9c9c0bc0cfde 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -622,10 +622,10 @@ void HT_update_self_and_peer_setting(struct rtllib_de= vice *ieee, } EXPORT_SYMBOL(HT_update_self_and_peer_setting); =20 -u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame) +u8 ht_c_check(struct rtllib_device *ieee, u8 *frame) { if (ieee->ht_info->current_ht_support) { - if ((is_qos_data_frame(pFrame) && frame_order(pFrame)) =3D=3D 1) { + if ((is_qos_data_frame(frame) && frame_order(frame)) =3D=3D 1) { netdev_dbg(ieee->dev, "HT CONTROL FILED EXIST!!\n"); return true; } diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 9f812cedd1b3..95e1c81bf132 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1740,7 +1740,7 @@ u8 ht_get_highest_mcs_rate(struct rtllib_device *ieee= , u8 *pMCSRateSet, u8 *pMCSFilter); extern u8 MCS_FILTER_ALL[]; extern u16 MCS_DATA_RATE[2][2][77]; -u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame); +u8 ht_c_check(struct rtllib_device *ieee, u8 *frame); void ht_reset_iot_setting(struct rt_hi_throughput *ht_info); bool is_ht_half_nmode_aps(struct rtllib_device *ieee); u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate); --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43F0617A586 for ; Sun, 8 Sep 2024 19:26:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823602; cv=none; b=Cf2YRjwCntDwB3KAaJD9fOVHw3KqHwMWXKXehlgBV5pRNKiU0bD75ZxdxCHKEGQAhhR0YdhmRVsGYa7+u6kwRVi8p/AeIeFPMbMBsCFY0j52JDV5TG+M8KjAoD5wh1TjYkxrlo/B4fSesgPin/XDA23IakcLg9AmmLDN/x4e8u4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823602; c=relaxed/simple; bh=0Osi9Yn1SgzAZQTXb4Yn4PxeMRBsG64qXNCZzkLmdgo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QiVxTbVW28iT+HL+GiqXjmMZHS8fH/4mI1zuWqf8Y9cyjnPe+vlW/fYp9rHYbHiBb3ZYIc42h7Qj6G1pofSpDKKVWZrXjBY4lMWJucERq7nO8FBr8KXVRHO8AwBf9a+VqKGoB2oIVRejZaIiIKYUIOGe+ImF4B49Nzr5M2gba2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=NGHNqJvR; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="NGHNqJvR" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-6bce380eb96so2289832a12.0 for ; Sun, 08 Sep 2024 12:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823600; x=1726428400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zWBGCmSM+rSBL4Vikquo8FMOlw1JZM7mKto3SCU6yFA=; b=NGHNqJvRbZyvB1Fv4nbFQR+EoODTJxERkqF1C8hngCYcHQ8C2d9MyjEAfF5Huoa/gV 3MrlVva2T8aA9AFWEOwAwo0gEn2eNasGRS/b8HjSjsryAy0ObVeydOD3/4AAX3YmQtom n1EhBzYNtC8h2VMufpiMfr7HKUvgg6eHEmnwz0QfupncsKiAoeyYT1CzWDYsixXmxJEw kUSpKa8cp9HFvuvMvT+TNj1T/3tW8U7oA1O3ETn4cyTqwPrCt/5W6LI1RZbcyIPVpi3y NtBGJq6Yy+oc7sLeYI694bcn8twhk5zTEYi3ijeLfG8uwHPk3qCB2fU9QC+GDZxHklbX 7MFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823600; x=1726428400; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zWBGCmSM+rSBL4Vikquo8FMOlw1JZM7mKto3SCU6yFA=; b=FGXO5jCk3oWHmQTsewEKvR1j7ONNNarwBdT8buAiFBs2ZDjYk8xBV9mTtpFaf2TA4n dbUNGnTubriinokl7GCmlNORSFsyAlutBF4kf7ZsprK9g+DuDeQRqs40YtmBdWQXz2r1 KK3gRn6+p3qWCmAnV3eVYQBVdnpY+bNcbot0SFDp7eyz1xjk4FRwLFo9PvMyzaQYY0U2 awE3rNJrYPMzCrsJucN60Sg3cHutAW14Lom4BrwP4Qviqijr08oiH4sX7f5UAhUxRkYt QhVYasep1uyj3yIG537kAx12LQeNj/YoUQUjCvCRzrW6WIKtj9YUqsVfKc/5bwzwYlcB 7qVw== X-Forwarded-Encrypted: i=1; AJvYcCUiEIOVDn6VDUf/7umNw7n8du4JGzfJ32nbx69VskqYGKyZBuBmMFNCbcE2jLhPUoroTMHUdrL/86Z5sAw=@vger.kernel.org X-Gm-Message-State: AOJu0YxV2LsdxlDfBhOeEpKXOrr0wFdYNt6VNQXkJPn/81+b2yFHsh0m YFRHmysGPGou6WhpcKB4BW8G2njv3zSEamghAhYVITeq1rtoKaCw7i2RMPXhz7M= X-Google-Smtp-Source: AGHT+IHN8SVFJ3fukm2YkQUPrYgt/gYprUUlJtojprTR0QqIUOSgiZFTaLNtsj0rYmL3PlOGexyGZQ== X-Received: by 2002:a17:902:f711:b0:202:5255:357b with SMTP id d9443c01a7336-206f0612f17mr137706165ad.41.1725823600548; Sun, 08 Sep 2024 12:26:40 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:40 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 05/16] Staging: rtl8192e: Rename variable bPacketToSelf Date: Sun, 8 Sep 2024 12:26:22 -0700 Message-Id: <20240908192633.94144-6-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bPacketToSelf to packet_to_self to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 10 +++++----- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index a8bb2d3f7e9d..078e36962197 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1172,7 +1172,7 @@ static void _rtl92e_query_rxphystatus(struct r8192_pr= iv *priv, memset(precord_stats, 0, sizeof(struct rtllib_rx_stats)); pstats->bPacketMatchBSSID =3D precord_stats->bPacketMatchBSSID =3D bpacket_match_bssid; - pstats->bPacketToSelf =3D precord_stats->bPacketToSelf =3D bpacket_toself; + pstats->packet_to_self =3D precord_stats->packet_to_self =3D bpacket_tose= lf; pstats->bIsCCK =3D precord_stats->bIsCCK =3D is_cck_rate; pstats->bPacketBeacon =3D precord_stats->bPacketBeacon =3D bPacketBeacon; pstats->bToSelfBA =3D precord_stats->bToSelfBA =3D bToSelfBA; @@ -1370,7 +1370,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv= *priv, u8 *buffer, if (!bcheck) return; =20 - if (!prev_st->bIsCCK && prev_st->bPacketToSelf) { + if (!prev_st->bIsCCK && prev_st->packet_to_self) { for (rfpath =3D RF90_PATH_A; rfpath < priv->num_total_rf_path; rfpath++)= { if (priv->stats.rx_rssi_percentage[rfpath] =3D=3D 0) { priv->stats.rx_rssi_percentage[rfpath] =3D @@ -1416,7 +1416,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv= *priv, u8 *buffer, if (prev_st->RxPWDBAll >=3D 3) prev_st->RxPWDBAll -=3D 3; } - if (prev_st->bPacketToSelf || prev_st->bPacketBeacon || + if (prev_st->packet_to_self || prev_st->bPacketBeacon || prev_st->bToSelfBA) { if (priv->undecorated_smoothed_pwdb < 0) priv->undecorated_smoothed_pwdb =3D prev_st->RxPWDBAll; @@ -1437,7 +1437,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv= *priv, u8 *buffer, } =20 if (prev_st->SignalQuality !=3D 0) { - if (prev_st->bPacketToSelf || prev_st->bPacketBeacon || + if (prev_st->packet_to_self || prev_st->bPacketBeacon || prev_st->bToSelfBA) { if (slide_evm_statistics++ >=3D PHY_RSSI_SLID_WIN_MAX) { slide_evm_statistics =3D PHY_RSSI_SLID_WIN_MAX; @@ -1458,7 +1458,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv= *priv, u8 *buffer, priv->stats.last_signal_strength_inpercent =3D tmp_val; } =20 - if (prev_st->bPacketToSelf || + if (prev_st->packet_to_self || prev_st->bPacketBeacon || prev_st->bToSelfBA) { for (ij =3D 0; ij < 2; ij++) { diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 95e1c81bf132..f444e85a6264 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -484,7 +484,7 @@ struct rtllib_rx_stats { s8 RxMIMOSignalQuality[2]; bool bPacketMatchBSSID; bool bIsCCK; - bool bPacketToSelf; + bool packet_to_self; bool bPacketBeacon; bool bToSelfBA; }; --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DEE417ADEB for ; Sun, 8 Sep 2024 19:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823603; cv=none; b=OZgPrvqG1ARSYhIfkifxFo3BAdEnZMHbfUBSW2G1ubbOA5c+IiNbu3OgtJTYwDUG8gP2U2Xu+8k9bGCmelSjnDT7iYB4ZOx/BDkOjEZAQNGy7KGc0HtZFShgsMBU2cGQWxYDOnRkmz/f1Arc8YBqQJE8nMIqvhDeCSwZ2XdZP+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823603; c=relaxed/simple; bh=Uv453XChzqhmZWRMQkqOnlFkUs+lQ3us5Ni+/tRzF+w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YqCRiRY0qHU5WDepHUuxabt3n2mFu+8QovWYBDJsLbu/mwOFYmmjrHspqbBlK8yIAHU8TFRC99tR+ZmU/P/bXXR+IXPbB2482c8Li154V5kYM20w9sm455PW2b+0xWw4m/ZcK+ALBbCpItX5BFNpb7W5xV+d1p+Ur2NrHyAdZkc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=MWFtjGyT; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="MWFtjGyT" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-206aee40676so29932995ad.0 for ; Sun, 08 Sep 2024 12:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823601; x=1726428401; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g7XnG9e/QAF4rnhFuQuRFT1GYuJxlU3KXfTtbx67LXk=; b=MWFtjGyT2iEDBdgvdMv1msj8kODNi/42xnrO+04GutbpfSlevVzZMij69KoTus4+hd K1lWEn+bJJrM1IpZe8gFkCbGlR5dV6YxuAD+A7SQUBUECG2/z/R09y9+PKTb8/YprEgq mpR432fFu9gj4ZuTAkm/Bug6dXcS132wPKgtiBs9tXMkKZcFp0O6FRRLi3UVZAVrnO6P cxsV3sYOV1lDhaPWuTbM/nF2kchOLpMYZD0a5adeM0I7W4YLldXRoIQ1sUgKXZgrA9s/ +F1w/oC5sA3PbxqiaF/qJxO+6pQbY8pJYV1j7mhl3kru61MBZm817jZv2+urZF9abwVN urUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823601; x=1726428401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g7XnG9e/QAF4rnhFuQuRFT1GYuJxlU3KXfTtbx67LXk=; b=M/qk4Eucu99xjcJWoi4htr5KNAwfVxfuq/z/ozWcv/xaQmpw8wI+u0Jo4UrRm9bzsi EG567XAjbR3jSl7TpB1zCuCDTINdpzg37QW3ZPQw2EYnXCEw7wJ97G02nlJYPgt7iHId cuppKhV3gxXrOJ/4HcF4fSmS0PgzVp/P27ZD6e6HBHqWazzDrRFFTV++o8wRT+QfVDra afRYIIxSKLxWimTeRR/DqW+5V12lbWLtB3xEO4rT4VfC+AM9tMSdCeNqsnQal1ifoa1L fJSMTeMurx8PFPePrXpQYUgSebzTkHQ3/vTCXdRvDsJa6jKoYilcl0nWYN8btcu5AOsI v/zw== X-Forwarded-Encrypted: i=1; AJvYcCXhX50/7ZPDzggmBjYGIuRStblgGnW8XsyV3P0dKZJUsSRbExje0pCk+fSi4judOXLE0UlmiTbdPWXskow=@vger.kernel.org X-Gm-Message-State: AOJu0YwUf/3nzPdlBc5/TlYagAr/WtJPQFraFrka9nW/FH4/ASRWjJNE BwQSYF4E4Vnq5zhFCKSYL33xmyvYpCdtXQMx4RBipI3c2w5xHz3KnJo/CR/Nuys= X-Google-Smtp-Source: AGHT+IHTjVvZ1RJRgf1Ym9zLzVykf3yLayQCY1X3N7JsfRGY0hhZBr6pA2fD8901J3hslv0NU1M5Ug== X-Received: by 2002:a17:902:ecd2:b0:206:d6ac:8552 with SMTP id d9443c01a7336-20707019e1emr49683815ad.52.1725823601421; Sun, 08 Sep 2024 12:26:41 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:40 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 06/16] Staging: rtl8192e: Rename variable Para1 Date: Sun, 8 Sep 2024 12:26:23 -0700 Message-Id: <20240908192633.94144-7-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable Para1 to para1 to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 12 ++++++------ drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 059b1f478a6c..797ae6896d62 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -510,7 +510,7 @@ static u8 _rtl92e_phy_set_sw_chnl_cmd_array(struct net_= device *dev, struct sw_chnl_cmd *CmdTable, u32 CmdTableIdx, u32 CmdTableSz, enum sw_chnl_cmd_id cmd_id, - u32 Para1, u32 Para2, u32 ms_delay) + u32 para1, u32 Para2, u32 ms_delay) { struct sw_chnl_cmd *pCmd; =20 @@ -525,7 +525,7 @@ static u8 _rtl92e_phy_set_sw_chnl_cmd_array(struct net_= device *dev, =20 pCmd =3D CmdTable + CmdTableIdx; pCmd->cmd_id =3D cmd_id; - pCmd->Para1 =3D Para1; + pCmd->para1 =3D para1; pCmd->Para2 =3D Para2; pCmd->ms_delay =3D ms_delay; =20 @@ -618,15 +618,15 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_= device *dev, u8 channel, channel); break; case cmd_id_write_port_ulong: - rtl92e_writel(dev, CurrentCmd->Para1, + rtl92e_writel(dev, CurrentCmd->para1, CurrentCmd->Para2); break; case cmd_id_write_port_ushort: - rtl92e_writew(dev, CurrentCmd->Para1, + rtl92e_writew(dev, CurrentCmd->para1, CurrentCmd->Para2); break; case cmd_id_write_port_uchar: - rtl92e_writeb(dev, CurrentCmd->Para1, + rtl92e_writeb(dev, CurrentCmd->para1, CurrentCmd->Para2); break; case cmd_id_rf_write_reg: @@ -634,7 +634,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_de= vice *dev, u8 channel, priv->num_total_rf_path; eRFPath++) rtl92e_set_rf_reg(dev, (enum rf90_radio_path)eRFPath, - CurrentCmd->Para1, bMask12Bits, + CurrentCmd->para1, bMask12Bits, CurrentCmd->Para2 << 7); break; default: diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index f444e85a6264..1e119192ad38 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -164,7 +164,7 @@ enum sw_chnl_cmd_id { =20 struct sw_chnl_cmd { enum sw_chnl_cmd_id cmd_id; - u32 Para1; + u32 para1; u32 Para2; u32 ms_delay; }; --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E851417B507 for ; Sun, 8 Sep 2024 19:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823604; cv=none; b=uX4IIei5AnL8mS4zUA4vYDg6OjJQA7rjjw3cKYHaFhsD1jAIR+CFTGyt/4SIitRB+7RHBzjeXWyWjuyMHhRwQ6WYQWjQ6oBRU17E5UTYzkrcrQ7eAD9OhXjRVPaxueDnUfZfrx4Lm3yICzWcX3JoseCOJoZ1gv0TIU/3nZ/c6lQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823604; c=relaxed/simple; bh=MH6aGyjyCR3+hd4QwFcOX19n1eDoWHGgClfqbba9mJA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VOxLFGgwDdo/4yRua9ffgBqmHRXdVUCPHZmuGGyANLGDmZCzt7gCfw/Bj5lO71PNoHiPPYmnqucA5Xsv4osdeiS3xfzgjKvWst/EFPtEHFafzDPfbeIOziWYa2xm9iUKTXuUyDnTLCQYAddwstk4O76pozmBzkbc2gyX9huad2g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=Dtq5986z; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="Dtq5986z" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-206aee40676so29933085ad.0 for ; Sun, 08 Sep 2024 12:26:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823602; x=1726428402; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ftqolyz8gWWGPvTvx6N+frI8E1w5G5SfE2BkdB0MfNU=; b=Dtq5986zn5qXHdE8DWwBZTjNJhb0AYI74mbp1xETq0uziPI7AU53yFMF4bdz3N/3bA FYYMPQvhDK4cEaM9RaJUJ4tKXYgLWjDYv71Rl7xFykE4K0HiJskFuxKPV5NOjyAF/tlC vjC86BTJioc2JgUgd3R4XfcB3LcYQIVVlqp5gD5uwxEXa5UjKxV9YXq7DXOz7GqedfKJ dGUgXxHjVthj772e6fpaJ2hrxaIrbjfbzq4cLes33XOPbGIpTU5pWZ7G9JPCBzqx+NWX xEbbJ5caLQ22fucGqIsHmjIPPgha7KNVQAx2p+elI7+BeLX7JMPi6qE8zPtgKONHbKS1 OayA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823602; x=1726428402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ftqolyz8gWWGPvTvx6N+frI8E1w5G5SfE2BkdB0MfNU=; b=aQwYMrKpIsGRyc4Dhk71x+8oJCkFDOLdmi+CjcyuMCdVtVnY+fv7ys7575IiNHNs9V T+bX/5eyKVHLP3cqgRNEAPEKUBBd2ExavAX5JWJu5wTZSyZEdcvdW8VGtPmAgLdUEweR D/N50orfGPzYenddVeAmT9bo4jQ70FLtu4jk2TIMLYBAsZ0rr8ndxpKbKXhwMZYA2Kf8 RYtrpyYqd44ChTIsWp2Qi8cUg8LWL/Y2FRONbYECxJ5fSIEUawjTXHlh+KWgR0m9BEpa eORC8Pv4iY1oBsOEfNX5WrRQ32zQtX6EvaKpkR61JDaDRZPvPkt9f4NQZ42woLZTQgo9 Am8g== X-Forwarded-Encrypted: i=1; AJvYcCVXEvnl3FIOpeyJKLunSK1qNKFB0MC01ivqa0SrVVFZWx4feKfByjgHNt5DIjnK0EK4lYixR4aekHNw6pg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxxo3KDk0UPE2rFRMujWSYvMXiVgAWnc/kh/o6OekDYwDV3Et8O WWSlxW0Qz4U+zZUda94lM162562bCifP90znYLtHIOYzX4JW8JXwpBFs+hxxNWo= X-Google-Smtp-Source: AGHT+IGeZ7nGmva47T5cynSPkefa4WBJUMwXsmqFnSfY/ZmN9V9xEJjArTMrOHW5UbRafO+3C6POGA== X-Received: by 2002:a17:902:e811:b0:206:9536:9778 with SMTP id d9443c01a7336-20706f2e3e7mr57113045ad.19.1725823602240; Sun, 08 Sep 2024 12:26:42 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:41 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 07/16] Staging: rtl8192e: Rename variable Para2 Date: Sun, 8 Sep 2024 12:26:24 -0700 Message-Id: <20240908192633.94144-8-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable Para2 to para2 to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 12 ++++++------ drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.c index 797ae6896d62..fbe624e235df 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c @@ -510,7 +510,7 @@ static u8 _rtl92e_phy_set_sw_chnl_cmd_array(struct net_= device *dev, struct sw_chnl_cmd *CmdTable, u32 CmdTableIdx, u32 CmdTableSz, enum sw_chnl_cmd_id cmd_id, - u32 para1, u32 Para2, u32 ms_delay) + u32 para1, u32 para2, u32 ms_delay) { struct sw_chnl_cmd *pCmd; =20 @@ -526,7 +526,7 @@ static u8 _rtl92e_phy_set_sw_chnl_cmd_array(struct net_= device *dev, pCmd =3D CmdTable + CmdTableIdx; pCmd->cmd_id =3D cmd_id; pCmd->para1 =3D para1; - pCmd->Para2 =3D Para2; + pCmd->para2 =3D para2; pCmd->ms_delay =3D ms_delay; =20 return true; @@ -619,15 +619,15 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_= device *dev, u8 channel, break; case cmd_id_write_port_ulong: rtl92e_writel(dev, CurrentCmd->para1, - CurrentCmd->Para2); + CurrentCmd->para2); break; case cmd_id_write_port_ushort: rtl92e_writew(dev, CurrentCmd->para1, - CurrentCmd->Para2); + CurrentCmd->para2); break; case cmd_id_write_port_uchar: rtl92e_writeb(dev, CurrentCmd->para1, - CurrentCmd->Para2); + CurrentCmd->para2); break; case cmd_id_rf_write_reg: for (eRFPath =3D 0; eRFPath < @@ -635,7 +635,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_de= vice *dev, u8 channel, rtl92e_set_rf_reg(dev, (enum rf90_radio_path)eRFPath, CurrentCmd->para1, bMask12Bits, - CurrentCmd->Para2 << 7); + CurrentCmd->para2 << 7); break; default: break; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 1e119192ad38..d63044607fb5 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -165,7 +165,7 @@ enum sw_chnl_cmd_id { struct sw_chnl_cmd { enum sw_chnl_cmd_id cmd_id; u32 para1; - u32 Para2; + u32 para2; u32 ms_delay; }; =20 --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C46AE17BB3F for ; Sun, 8 Sep 2024 19:26:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823605; cv=none; b=A+H8YhAEACp0WwfABIJDQkIc1ukIVWPboPUoZqDlGHUr1Rslzop3Wo8QX+bJPCl8jq6D3wuwPpAJ26z5q8wWLBwaIBnUYK84xiwbMA/1QK8k1ke8FxsEXKIx/5wPhywACqaxSobZVQWKn8+bJGGgCfTzssWwnakIowp7U6rILd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823605; c=relaxed/simple; bh=oSGIlgcB5bk+3npew6/oY4O3djXBrXcqVa3FtH6ssNQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rBm5s84SziqeefWXFIDb1PMKhUUI4/zAQFOPlUlCgRCIToUfJruBUZUAIlMe19p980rNvkhd4NyQ/xusZrMTk8iW9uLhAoujkP1Y9aSDryIX/L0acxuYMyUf6Q96PcR1Gd+ApU4bKB1XZCdneseJUw3PDECPT8kkkd6mP65Y/QI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=Jt202Uic; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="Jt202Uic" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-6c5bcb8e8edso2856169a12.2 for ; Sun, 08 Sep 2024 12:26:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823603; x=1726428403; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3pbiBs+OMZdnPenhE+VdtplWlVCSPQUlYP7gfJvkFEk=; b=Jt202Uic/G15aUkKDYu9nM1QgG+eBSkxJEYlbM1TAnDv0F9umPmOD3ksyg4qMhLpAC GZ9WVdRluxvGLdRPibxCrJnF2JsTgMpe395H46qgXh0oCXFKTUQj6WsrXzlhycSxtZyI edyRiqIYSNyUeT3jjwbnuwjEqubbMCCE4a+Eafz17/fsXrSz7bRCjflTRtw8/LNGHsq9 tXExs73hG34nDNIOkiJCrNNrZlherf6ynYs8Au0LmcDpwRJQekOwOAPzUYDZhrZxjkUB k3fE7lsIhBRDbor1cCGHxAq+5iAIBl8B3YrfkcDMtRJmDDz5o/W/WfPh8NKW/VAZ3Re5 fCNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823603; x=1726428403; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3pbiBs+OMZdnPenhE+VdtplWlVCSPQUlYP7gfJvkFEk=; b=NXd83xcwLOgwT+fw4q3PFMpPRma27oXWiHVbuO8RIZ9KIqyKk01vP7p0McGjqYr77B +5NGtDgf8UKv/yaF4Qjpif2yVkVeihRI8VtRhhKw1syqmwufHlFOC3Q01DY5DH8ckZWJ Q2MNyyVS9Gue6Yf4bSjh7LljDvbkuRTCCNCC3RxhOJsp3dkHqgTmERrqqF2cDJYroIVk Vx8ZqbHys7GNPH0Zve1azETzLgPafSuhH2jbtjYDOo4b+ftX65zN0iX7HSnq+AZ/gr3L RNXGayhQOzRpFqItivO0vWTYoIorRICXL0PfQ9Xbwuixuj7gOU4Sn71xbGd9qZpNZ3uN Vw7w== X-Forwarded-Encrypted: i=1; AJvYcCWY40IF/iWG4JNsh7Z4YiTzl2vrvAs7qMNCIRjFqvTjjrC68Sa6qDGpBqmUZvPVymN7DbpXq8fcdik54DY=@vger.kernel.org X-Gm-Message-State: AOJu0YzeI8NK1OGsxqGPtcZY+pTtEpyhT1Ozkq9X1nzvVADo3HMRfAfF 91A0zxi2ZiKSEFVCmbcL6Yg6lnimcLsJ44Hcj07/0OhhlY6Rg1/+68jVNPougoA1iSybEiqUSrx iOeo= X-Google-Smtp-Source: AGHT+IEfiqlAgyYC3n/LMWnEE7mW3A8pj0k79UjUYmC0ClBY3O71MuUBybCEb6fRCI5pgMLH6QL/Ag== X-Received: by 2002:a17:902:e952:b0:205:56e8:4a3f with SMTP id d9443c01a7336-206f0624654mr74639885ad.61.1725823603009; Sun, 08 Sep 2024 12:26:43 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:42 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 08/16] Staging: rtl8192e: Rename variable ScanOperationBackupHandler Date: Sun, 8 Sep 2024 12:26:25 -0700 Message-Id: <20240908192633.94144-9-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable ScanOperationBackupHandler to scan_operation_backup_handler to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 ++-- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 744588a27302..a5980253183e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -665,7 +665,7 @@ static void _rtl92e_init_priv_handler(struct net_device= *dev) priv->rtllib->init_gain_handler =3D rtl92e_init_gain; priv->rtllib->rtllib_ips_leave_wq =3D rtl92e_rtllib_ips_leave_wq; priv->rtllib->rtllib_ips_leave =3D rtl92e_rtllib_ips_leave; - priv->rtllib->ScanOperationBackupHandler =3D rtl92e_scan_op_backup; + priv->rtllib->scan_operation_backup_handler =3D rtl92e_scan_op_backup; } =20 static void _rtl92e_init_priv_variable(struct net_device *dev) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_wx.c index a054592a7364..fe3a42a4fcd5 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c @@ -288,11 +288,11 @@ static int _rtl92e_wx_set_scan(struct net_device *dev, if (priv->rtllib->rf_power_state !=3D rf_off) { priv->rtllib->actscanning =3D true; =20 - ieee->ScanOperationBackupHandler(ieee->dev, SCAN_OPT_BACKUP); + ieee->scan_operation_backup_handler(ieee->dev, SCAN_OPT_BACKUP); =20 rtllib_start_scan_syncro(priv->rtllib); =20 - ieee->ScanOperationBackupHandler(ieee->dev, SCAN_OPT_RESTORE); + ieee->scan_operation_backup_handler(ieee->dev, SCAN_OPT_RESTORE); } ret =3D 0; } else { diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index d63044607fb5..ee5de93a90c1 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1461,7 +1461,7 @@ struct rtllib_device { bool (*get_half_nmode_support_by_aps_handler)(struct net_device *dev); u8 (*rtllib_ap_sec_type)(struct rtllib_device *ieee); void (*init_gain_handler)(struct net_device *dev, u8 Operation); - void (*ScanOperationBackupHandler)(struct net_device *dev, + void (*scan_operation_backup_handler)(struct net_device *dev, u8 Operation); void (*set_hw_reg_handler)(struct net_device *dev, u8 variable, u8 *val); =20 diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging= /rtl8192e/rtllib_softmac_wx.c index 11542aea4a20..c59686d68a33 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c @@ -314,7 +314,7 @@ void rtllib_wx_sync_scan_wq(void *data) /* wait for ps packet to be kicked out successfully */ msleep(50); =20 - ieee->ScanOperationBackupHandler(ieee->dev, SCAN_OPT_BACKUP); + ieee->scan_operation_backup_handler(ieee->dev, SCAN_OPT_BACKUP); =20 if (ieee->ht_info->current_ht_support && ieee->ht_info->enable_ht && ieee->ht_info->cur_bw_40mhz) { @@ -339,7 +339,7 @@ void rtllib_wx_sync_scan_wq(void *data) ieee->set_chan(ieee->dev, chan); } =20 - ieee->ScanOperationBackupHandler(ieee->dev, SCAN_OPT_RESTORE); + ieee->scan_operation_backup_handler(ieee->dev, SCAN_OPT_RESTORE); =20 ieee->link_state =3D MAC80211_LINKED; ieee->link_change(ieee->dev); --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E43B217C7D9 for ; Sun, 8 Sep 2024 19:26:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823606; cv=none; b=kHzE1wPNirFtf4udBola8LsH33NTs19dIJC9v62p2vGJ4zZNSasMR8FZyrILnd2re+X9S0Ll+cutwbNlUFrwkJbHmA4D07t1SQ24lna2NX7xSqtaWwSs9luPLM3pOiA2IOPcQYY8QULoPMLzR45wHc0Xu/ZTOIucN4BSS8B7mps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823606; c=relaxed/simple; bh=qqKcKGI24ZLluphP0qMulOyEU/6MpzTHCItJT29kvoA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oKN4M3N4NK/w264vUMlSd4FfD6OLE39SbcoN8YGJLmj6pWVvF8pQDDUgVmz4stEFpHWYmgZ2V4NU81ionyAKlvyE71qIrfyM1K4sCKJ9HjSMHA/kN7C49uSehx37ZrYJioB12yp5/oeVBTdHAGQVpirdYfY/zcp25PL+tobiaEM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=lPzTUXm4; arc=none smtp.client-ip=209.85.161.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="lPzTUXm4" Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5e1d5acb04bso138574eaf.0 for ; Sun, 08 Sep 2024 12:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823604; x=1726428404; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YVHa5epj2p1dAms9PACg6c0dVYf4FlgMjQpCOuLBg4g=; b=lPzTUXm4EcMp28gNhx/KPTI17hXDN1m5lTQ2sdnuz/eNmClrUMaajhErGOi7BzPdOO P6wsXsb7Ld6Yvy37ZSKlgjt2GRTnz1LKoRSu+IRDU3H4IJE3GGQJiy1nPwDHG3sa58/b oPsi1uLm0Tq5XCvgBvik+q6NGIkbiHdSsrLu6/fGDvM/WlcIFk3ePBk6TNLZoX5tWj6H TOyQeUzh0+tY5Ol84WYPrTj+BhGoDKlxnkZJLyAA9JF1mbZk5eslz+yA0Tmt5CvizLe1 HEPHV1wi6w6kUJAjFsXb2vZp6N7ThBOh+vMiGWQmJzrOMmq5/umkZQyup6f0MdkH3n7C mt3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823604; x=1726428404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YVHa5epj2p1dAms9PACg6c0dVYf4FlgMjQpCOuLBg4g=; b=sr2B+sbQd1eJHCtHZ8vVU+ObCsKwQYL6b702dmXGOVNimmolDqG7Fbdgnw323RC//e 8xwSpwqB5WygkGn9oDb4xp2KOq9s7eWW/tikEHi3ZDrx10a4qM8o1FoFt+PY0XR8p74r WXKeQepL7PDOJ9xCIYTRKSQ4PKEqRZP7rIA/7etJl7kIrq/kOifOeoBgQibGYBINtpv/ Bwnwjjbd5o9uFMNAupPH+9p+q7weKWj7j9Vqy9D+dNh1xFLg0wNtCHxLSz7MU+UqXJvj bK1aAifYlNgzNmH3ELQmhFrbpOlMM8Xp7usLmD2GP/A3zZaG6gUSCFt/PCpvJns2w211 MyZA== X-Forwarded-Encrypted: i=1; AJvYcCU2qLaGGEjMfQ45HXHSjsSPIeyUMPc+uyDqmZ9wDzFYvFDBvCUoSq7WPMIUly0qdhgjNx8wq0a3UYoy2Mw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxg4GNvW4KPltvegd8gKd0iGj8tFXDxZhMhGZwkjdGKqXW4t5Xi EYoZYliGA+n+y/auNwDzPVS3sQmVF2ttUUfelehg8Hvo4ubC7343XKAXMzSheaA= X-Google-Smtp-Source: AGHT+IEgfQxng7tLhbSWEjoMiuayrwGJkE9DyAouF6RW/y2GMbl2QBRXJ3lKHYLnWg5xEXd9Ce7l8g== X-Received: by 2002:a05:6358:9204:b0:1ac:f109:e248 with SMTP id e5c5f4694b2df-1b8385b2c39mr1123143055d.2.1725823603918; Sun, 08 Sep 2024 12:26:43 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:43 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 09/16] Staging: rtl8192e: Rename variable Operation Date: Sun, 8 Sep 2024 12:26:26 -0700 Message-Id: <20240908192633.94144-10-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable Operation to operation to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h | 4 ++-- drivers/staging/rtl8192e/rtllib.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_phy.h index c928bc2b218b..956dfbdd5b68 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.h @@ -43,13 +43,13 @@ void rtl92e_set_channel(struct net_device *dev, u8 chan= nel); void rtl92e_set_bw_mode(struct net_device *dev, enum ht_channel_width bandwidth, enum ht_extchnl_offset Offset); -void rtl92e_init_gain(struct net_device *dev, u8 Operation); +void rtl92e_init_gain(struct net_device *dev, u8 operation); =20 void rtl92e_set_rf_off(struct net_device *dev); =20 bool rtl92e_set_rf_power_state(struct net_device *dev, enum rt_rf_power_state rf_power_state); =20 -void rtl92e_scan_op_backup(struct net_device *dev, u8 Operation); +void rtl92e_scan_op_backup(struct net_device *dev, u8 operation); =20 #endif diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index ee5de93a90c1..3621f27b083b 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1460,9 +1460,9 @@ struct rtllib_device { void (*set_wireless_mode)(struct net_device *dev, u8 wireless_mode); bool (*get_half_nmode_support_by_aps_handler)(struct net_device *dev); u8 (*rtllib_ap_sec_type)(struct rtllib_device *ieee); - void (*init_gain_handler)(struct net_device *dev, u8 Operation); + void (*init_gain_handler)(struct net_device *dev, u8 operation); void (*scan_operation_backup_handler)(struct net_device *dev, - u8 Operation); + u8 operation); void (*set_hw_reg_handler)(struct net_device *dev, u8 variable, u8 *val); =20 void (*allow_all_dest_addr_handler)(struct net_device *dev, --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 633A417C9FA for ; Sun, 8 Sep 2024 19:26:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823607; cv=none; b=AAXJJzYdlq0MvI5qOgL1NtWSqoCM5UmWpWuqEiTJbnnI6bqCT4zWHZ625+i+kUrwejJ+M+y1csr9liGyh3IJxqyo78FidbAbhMRKV3+ePysD8gdv1iFCIWoT3Pvm8nRim1eqtG8YzqGAzkvIdxuI9x7F4aHkJFV3WYOWN1xjpHI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823607; c=relaxed/simple; bh=L02lVgIrPVpyX1TYuHNwcoDskfqxKULdXO2b/ru4OiI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Le2V82/0BOk7Ao864SDU9IcsnPn1z994ePXs+1znxwF+47qgfM6eesEEUFUcTe50FS1FDiNPD8LM3z0P3Q0S8XO7TG97JSS+fKNOaQfWb65cwEzk7L9yKKx4xkiZDy94M3M179oL+Ta78pRVespyoWtkp4Y7QwtNck7ULIGtfu0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=PG1EVOyh; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="PG1EVOyh" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2021c08b95cso35049805ad.0 for ; Sun, 08 Sep 2024 12:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823604; x=1726428404; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O6pmwMlirClkh1arNo035bBhvK2xtwOFwf4bLdJcZv0=; b=PG1EVOyh4ajz8u/4Vs/B88Jis/zMuTrYxFP6WGIwJ8f2a99vA/7vMa+eG0d0M5Y9NK GFEX0B2BjxVr9xkUYWONMPdr/PjrSaKIJS46kh+9X/FsvTzf1ZF5drMkiUI8jKeYIHRs qm+S+m+8m5OmxFKP7ey4JSHUUW8AbeJD5RGwip3DkO0ExY40XLwNACUXwFTmjUQMPfsy c5XlntalHVIfw9yOIme5RtiiRMv7jJ2OCD6tligfK04JRKB4sab4PTQTqeQJizU9F2BA GR/lwSuaq9h/PVbMp3QMEcaqn1Q+r+m/DzyNzBjgbBtC++y4D+X5Ii+0/abGrZ0bfadm K8Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823604; x=1726428404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O6pmwMlirClkh1arNo035bBhvK2xtwOFwf4bLdJcZv0=; b=qEwtmNf6aOeJLN8XrFrppQvH9RvXeboglOoCKpovv4xIiR5fXlFCo/WxVHBi8kC5s4 INPw0LXz7iCSecyBfL08zNTfwddib/4XAoQcDpo+GlBjxBbic2TA4ZBA6heERbZmVY07 9YwMKom7C1o5CDRmhfkOJU59SVj1t0zZ1BAD52gWUylkhfEPQdF9e2FOl3dVYLFk5ebi EUo7tX2r96eQap+RTB+QaQDPjLi25vUoLzpcyoGN/FUBanAfR81drbJbzR4BOVN9/6nJ DqrFVmN1BEJo3D+TvrsC7zcY/Q7eWTHeTpdppWJ30Bnx/U7qzCVQFWdntYGPtD4M5+V1 CTJw== X-Forwarded-Encrypted: i=1; AJvYcCVAwRtZBFkYL7CffzOxW2B2OwM2rUrmclJ67w9HnCyaINIHADVQAQ2xP3b13PeHbZLgRCZpqSoT7LBmlzM=@vger.kernel.org X-Gm-Message-State: AOJu0YwD4/NqUJ5zMdiOeymRsc3rqA3q7y5n98V76wm21izXCrHhCtYS wMGzIMUhkkgtto04vpYiNrAVlBaXqr1E+Uz0HgSVPP1ksTeGWIClM3Tf5zcndU8= X-Google-Smtp-Source: AGHT+IE/8ODkzgxNwDLCGK+TWiTrZJsd1x1ngShkhBybZ/34KWM3l3AWoD1iX3aQ2MbOa2GOwmQb4Q== X-Received: by 2002:a17:902:e545:b0:206:892c:b758 with SMTP id d9443c01a7336-206b833e57amr266089905ad.13.1725823604553; Sun, 08 Sep 2024 12:26:44 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:44 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 10/16] Staging: rtl8192e: Rename variable bAssoc Date: Sun, 8 Sep 2024 12:26:27 -0700 Message-Id: <20240908192633.94144-11-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bAssoc to assoc to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 3621f27b083b..b599309b70ff 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1726,7 +1726,7 @@ void ht_set_connect_bw_mode(struct rtllib_device *iee= e, void ht_update_default_setting(struct rtllib_device *ieee); void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, u8 *len, - u8 isEncrypt, bool bAssoc); + u8 isEncrypt, bool assoc); void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee, u8 *posRT2RTAgg, u8 *len); void ht_on_assoc_rsp(struct rtllib_device *ieee); --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5DB717DE36 for ; Sun, 8 Sep 2024 19:26:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823607; cv=none; b=LszHomsVTHjGVTgY+4zPcUVMx/4WZMzuS7Ht6Vn7Lui6JxmS1Y6MnMgYyl0hTsECdBlZn+d8mE/PynEXfDHM658M9LBweuE8esaFL3oLNq9oy9fVCGNxIVlKmlUZEa0Sy8efXN/4M8Q/a/ZMdGCQ9bZ+5508+5PT4NgwXNenNoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823607; c=relaxed/simple; bh=LTYeFszybk7UogGptFrkCYxtXAHySb6fBAYEP3TvpU0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uP1VIAKi0zjQlAxt/b3KVHXxEwCQDYFrHBAxg29TCClVOoJCrE2Xc02O75JEmUon1eAvaVm21gUtCfrlFb7njexg9j77od4immLusa5oUbuWmhhmmhJ6itF8Yp5+k5KiBRIKyo+u6u/xi+B/FTsrr567szEr9mIS3uqbStmq3TI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=JcuMu43G; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="JcuMu43G" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-20551eeba95so32319315ad.2 for ; Sun, 08 Sep 2024 12:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823605; x=1726428405; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CokQS4kXNUYPMSO/bhNH26UTp/Z0p345ebJ88SlkfZg=; b=JcuMu43GS8JbnAoviWAgJ+UXn0yREiEuO1fO+jmdyAJab48xf7qJcUjK3Hm8VCTnBI ZjmVvGUdh4nInrxU3HKe924fiDgOIw+w2QJR7HZp4zU+9ldMBFRYKKnnYOqZfQzGzicl i+Ph9RHqek+qnujEM1KEcjKnWUZryC4brx7ohxdXeRygtveZdFI2s9Ug788HxWApJrli Cj04v9ZspKofyjx7EkBV79YX6E/yCRqhdcbZTlh3a6p83gj2ntiPsMfFT96wgm4DGFKq SitmOBSaBVeV3GEWvI1RiyDK3edfalyMJJLXEH/CpE4/hqMwL2SWODaQCQdYkplv5azQ 6FNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823605; x=1726428405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CokQS4kXNUYPMSO/bhNH26UTp/Z0p345ebJ88SlkfZg=; b=ZyRG31s/diyvHUAUQqRxasBvWvM17sCQfh5EMnTAfJ8FA8KnEQnJpaWEGyVP+8+uT5 4u3JmpXa4xPHdZEGNYFSnSxvd7I9B1/er177Tc8IIIXAPL9VZVxtCZEcMTFKuJxUZJb/ fl7qJJDOhiinBUTfmIVnR1fBVkq2nor0Vv7Yvzm2v27LOEhqk/QNgJI4cQ3lqtfuBIVD TkNDArg/A/T+YVkRP2eeC79708vzPocJcSBHJjWT/+4tshP+d4XKvueiYwo8+WV5Q0XO O8Yrei+w8XUN8s2ezzmLqPPEPO/PCfk9nu4rdxa1nK5nF78TV9xwnvpCg1elbYcJkpqi wMag== X-Forwarded-Encrypted: i=1; AJvYcCVauKgDD4sbnk+WGRivSVUAiXDaakAOCwULg+AT47jRnQdr4f1Y8u+FqgTzT1x6FtdygTKGCX2BdVo0gPs=@vger.kernel.org X-Gm-Message-State: AOJu0YwAlprVzJSOQx8Hrhy00CI/QdIq86X/6mKLuCA4OKswlyfYHND1 TXad5IjkpnoclqR2+PQtaufBa6t8PhNVQuuoflVrsc/B574FdIDnU1z+2Tb5D2I= X-Google-Smtp-Source: AGHT+IG2dsp94gPihKGFg5H5haq3c+EPQj+JUdDhx0pe14/DtjqT3zFZ1C+fHjy51BvMA1Shdl5g6g== X-Received: by 2002:a17:903:2412:b0:202:4b99:fd27 with SMTP id d9443c01a7336-206f0620834mr84000685ad.51.1725823605335; Sun, 08 Sep 2024 12:26:45 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:44 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 11/16] Staging: rtl8192e: Rename variable SignalQuality Date: Sun, 8 Sep 2024 12:26:28 -0700 Message-Id: <20240908192633.94144-12-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable SignalQuality to signal_quality to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 14 +++++++------- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 078e36962197..eab6bbf9f3bf 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1264,8 +1264,8 @@ static void _rtl92e_query_rxphystatus(struct r8192_pr= iv *priv, else sq =3D ((64 - sq) * 100) / 44; } - pstats->SignalQuality =3D sq; - precord_stats->SignalQuality =3D sq; + pstats->signal_quality =3D sq; + precord_stats->signal_quality =3D sq; pstats->RxMIMOSignalQuality[0] =3D sq; precord_stats->RxMIMOSignalQuality[0] =3D sq; pstats->RxMIMOSignalQuality[1] =3D -1; @@ -1309,8 +1309,8 @@ static void _rtl92e_query_rxphystatus(struct r8192_pr= iv *priv, evm =3D rtl92e_evm_db_to_percent(rx_evmX); if (bpacket_match_bssid) { if (i =3D=3D 0) { - pstats->SignalQuality =3D evm & 0xff; - precord_stats->SignalQuality =3D evm & 0xff; + pstats->signal_quality =3D evm & 0xff; + precord_stats->signal_quality =3D evm & 0xff; } pstats->RxMIMOSignalQuality[i] =3D evm & 0xff; precord_stats->RxMIMOSignalQuality[i] =3D evm & 0xff; @@ -1436,7 +1436,7 @@ static void _rtl92e_process_phyinfo(struct r8192_priv= *priv, u8 *buffer, rtl92e_update_rx_statistics(priv, prev_st); } =20 - if (prev_st->SignalQuality !=3D 0) { + if (prev_st->signal_quality !=3D 0) { if (prev_st->packet_to_self || prev_st->bPacketBeacon || prev_st->bToSelfBA) { if (slide_evm_statistics++ >=3D PHY_RSSI_SLID_WIN_MAX) { @@ -1446,10 +1446,10 @@ static void _rtl92e_process_phyinfo(struct r8192_pr= iv *priv, u8 *buffer, priv->stats.slide_evm_total -=3D last_evm; } =20 - priv->stats.slide_evm_total +=3D prev_st->SignalQuality; + priv->stats.slide_evm_total +=3D prev_st->signal_quality; =20 priv->stats.slide_evm[slide_evm_index++] =3D - prev_st->SignalQuality; + prev_st->signal_quality; if (slide_evm_index >=3D PHY_RSSI_SLID_WIN_MAX) slide_evm_index =3D 0; =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index b599309b70ff..76792268629d 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -464,7 +464,7 @@ struct rtllib_rx_stats { u8 mask; u16 len; u16 Length; - u8 SignalQuality; + u8 signal_quality; s32 RecvSignalPower; u8 signal_strength; u16 hw_error:1; --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5C95183CDB for ; Sun, 8 Sep 2024 19:26:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823608; cv=none; b=uSJqdmTwV4kLLxvn2/Kry0z54Il9zCK/Ggb4Sl70LKLNO1BXZptY+AF4lUUOTXGQZgwcdVxUXIEx8m5oZuEE88w5zuBoFqw+vkRTM8ZELOtMC4InzNEnOAtWvRY23xH2rUsuXIX/gQojasD34pt1MSscLvLWyhXJ/tTo7rDKuGc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823608; c=relaxed/simple; bh=GNDbS0umag34Ow3QhNqy860zt7/gRMadMUGvB79LHYA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rvLhiVQBcfSEZ+wignWBKsZ+/ZP5KhiWuJknjMsPOQvmZfv7A7FkggR2qIsfYfVarulbCD9KsRsiLHpwSaFPqTTBpo9p6qRJO4q9PPQF1cW3oGkQapzC3urHc+7C2Gg2g2DcKfvGo4TrtnA783XP4GL+43a7Sa4rpSHOgqsCSFQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=RguVAjEY; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="RguVAjEY" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2054feabfc3so31164535ad.1 for ; Sun, 08 Sep 2024 12:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823606; x=1726428406; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tqCCIR0Jh0d9TyP+sguj0pDsMoKfiPe8e6/V/reMWic=; b=RguVAjEYHd/7hNTASr46l2d5X+SGRvRrqNxe4rGKhdixnjhY1mk9+E2hnxZymplW4i vMITc/JzG4gAmq6iEVWlFgZ6NOQVnst/OEdTcnxK8skq4xpL+9fvE5eu4bx29F/X1fTF sweL6QEVV0FVHZPNwtoIhWYMWqhHR5BRlYmQhrovQmojRPuUoUqwyR6YWgx2eb1X9lbS /wYsQ1LwVv308pTcdZdLLWccDdVVmlb0ThfVX3RC+NHlZcSpvAVdRpw3W3YkNCnopjbU BskLeIrBczq7RYfwJhkJEXd3KjOIYATAVXBuBykZ9R4I5GUhRN8AA9iJ0g9UvRbVcyjN 6UTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823606; x=1726428406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tqCCIR0Jh0d9TyP+sguj0pDsMoKfiPe8e6/V/reMWic=; b=X43b7WxoNWsYJrFpzBz8A84UJvLGU3/IWK5wRHu3KjqqEUYkxAHeuhAc/DX72yjBn0 P4D3PiMMkr8y6psXriWDEvJN/pn16Hik41mr+TeernszR56Ot8BgoNKA5Z/QnRTF7TxE +WoaE7VcjKuReJXSDjOA7jZlx00bW7jKoSpW4nDjPBng1aOPYVF8dzwK1QuQ7+12ra+H vQNBXqweeLU2+kO3Zv+n7sKwvyu4/JAM+542rUTnBwdTbbZnx2KPv4jt/0esKa/MIG6E Y1xxyKRf00l2xBWFrMwVBFFrnPa3ZICggAMVBPZqQT3+nSjT5GFtSyTFAR83aHv7daMk tQUA== X-Forwarded-Encrypted: i=1; AJvYcCVatvo/ljI3Nb2FXMuvxN/xXds1V0WJeliEySPfxJy38mQBuRlVbaEYNiT54FQ9F5f35LRaa0c2IbTTY2Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwPbBP+6FmIZgPW1RPNiCaFHXfJ85wX6Lg6elNmNnPgMjRxICmm Bymf7TEzCWCyW0TNn+/fLduCSRSeasTaGKxji518JdbyOPXi/i+S1+21TOIu3z8= X-Google-Smtp-Source: AGHT+IFf+CJ+L/oMeqQ3S4xbOCAFT6SydeZF6Pq1lh9SCPpH4CJrBlA3KlPQrllXs236WcvdDi8ryQ== X-Received: by 2002:a17:902:e543:b0:1fd:8c25:415d with SMTP id d9443c01a7336-206f058c6bbmr148199455ad.36.1725823606155; Sun, 08 Sep 2024 12:26:46 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:45 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 12/16] Staging: rtl8192e: Rename variable isEncrypt Date: Sun, 8 Sep 2024 12:26:29 -0700 Message-Id: <20240908192633.94144-13-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable isEncrypt to is_encrypt to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtllib.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 76792268629d..5ff3fab72589 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1726,7 +1726,7 @@ void ht_set_connect_bw_mode(struct rtllib_device *iee= e, void ht_update_default_setting(struct rtllib_device *ieee); void ht_construct_capability_element(struct rtllib_device *ieee, u8 *pos_ht_cap, u8 *len, - u8 isEncrypt, bool assoc); + u8 is_encrypt, bool assoc); void ht_construct_rt2rt_agg_element(struct rtllib_device *ieee, u8 *posRT2RTAgg, u8 *len); void ht_on_assoc_rsp(struct rtllib_device *ieee); --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE7BB1862B4 for ; Sun, 8 Sep 2024 19:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823609; cv=none; b=g0ruU1lW1Wd2DfEn7XVTXtrQT2VRSbLTlAeHBgFI/s+bpJiueLIjfhWp7+qJaAiLgCWMUIJ6w1M3nb8z9jswbCvtKUEAIFlBEBWkB0/FlNpqjmgnQLHvd+QlLLQmPEOMq3O+aGN5WcTSHe5I5F9oOcgJcGsljz0dVJGTNqbgpFc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823609; c=relaxed/simple; bh=JzkYesItRdPywlcTwoNQUMjC7AQGa+S9Iz69eRwz31Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sPU4DIaLkGoI8I2ciqwD8zRtUWRdFEt/z62hHPGHY43LusyS9Ax5qSR1FNsXEovuLaDuT24nrmNe65bSXOrZ+6nb9FD0kX+jkKOM0zeqNKdH+is46B27ef8GC7gROppvZuTpTbe6pCgrc5sbSCHqKk+QY37hFoApIMelkVdY1AE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=dHtDpadk; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="dHtDpadk" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-7d50532d335so1277009a12.1 for ; Sun, 08 Sep 2024 12:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823607; x=1726428407; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3b2uQ0KLJAAtQJ2wmUi2c9S1xBAjjzTRADBi7POwrfY=; b=dHtDpadkZvB5/vH8TYpTwShQD8aedY7qkWUspAyigWKJ+YM+dboZB0Nz0aFdeJi+ed vo6LOMbyxMQIEvlm0i3tiW70+jSh4D/CB+4DyowOaMrbFuS6RzALQXg2xNSMxu3WRDJA pQsuE3Wa9Bcdi5K8TRM2QypK5XeJz0/pZoJhSTWgfeE6UfS+z0p4DBms6AwT2eoBlYGG JWdDuxKPsTUcb/ZGubOxWcZnbe3BsLKftKmhv69ox9E6xQUTCzMy0Pgv/2sNOYZ0wjAM HuEn/C4f/SaJLUzCfgr3A28Z9zCzGui7Ew9LxOfBjZv2O2/UqaTthWltpBl1Kmj3aFhm D42w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823607; x=1726428407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3b2uQ0KLJAAtQJ2wmUi2c9S1xBAjjzTRADBi7POwrfY=; b=rkcXhdKQ/qIESZppQ3lJo11zdWP/b4oYK14wwaK+qfRivmMtr8nDBarDIbj9i8d2FZ qTGaC8ERQ0DYOBinLel46Ar/7UgF2GnWkQn7vhu/qOsZtK0we1zVd5fYThhA/BERGolY vh/LCc0KjlYA05kQuzHjzVcubyA6taaCYCPr+LSNgaj3lFN6j27VljYPo4GdAWMBz3pK QoeuWHq0I2KzfkUvlutWlsQp6UxVqRxKQa5eNhitAQvNbpn7I7qO6IUclyEYAlZ0vGED aycdHQxYTcWEtDNikUw4pbjw/uYmNtuwBTWwYFtmhIlOgj+dN0b/9LGbIelYCYDt2GQD XV1g== X-Forwarded-Encrypted: i=1; AJvYcCUr2DWGRygZWyQvmwWlXdMaBw65xr91blmUUnikXw2MdO7m3qRM45MzGTr5C1wXwrXbrsHNu1OK66h9vVM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3JVXhLauXpBLTSJ8COpCCJ+xCsw7Ko8EukErw5QYj389YlOGa knJQfuApDB2/N135KS/ZAySs+RAC+GO8VBhOHZa0nUT9Y/EUc1v2VIShJqZAwIc= X-Google-Smtp-Source: AGHT+IHDxtbQnGaGi1juqUlvIl0ykr1sv4pKQVI8yozX2KId5ji/h6/YeJ0OSduDeyLYMC7fvWQDkw== X-Received: by 2002:a17:902:e847:b0:205:755c:dde6 with SMTP id d9443c01a7336-2070c0d83b2mr72644015ad.30.1725823606904; Sun, 08 Sep 2024 12:26:46 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:46 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 13/16] Staging: rtl8192e: Rename variable nStuckCount Date: Sun, 8 Sep 2024 12:26:30 -0700 Message-Id: <20240908192633.94144-14-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable nStuckCount to stuck_count to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 8 ++++---- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index a5980253183e..5a4113c97b1c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -860,13 +860,13 @@ static enum reset_type _rtl92e_tx_check_stuck(struct = net_device *dev) skb =3D __skb_peek(&ring->queue); tcb_desc =3D (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE); - tcb_desc->nStuckCount++; + tcb_desc->stuck_count++; bCheckFwTxCnt =3D true; - if (tcb_desc->nStuckCount > 1) + if (tcb_desc->stuck_count > 1) netdev_info(dev, - "%s: QueueID=3D%d tcb_desc->nStuckCount=3D%d\n", + "%s: QueueID=3D%d tcb_desc->stuck_count=3D%d\n", __func__, QueueID, - tcb_desc->nStuckCount); + tcb_desc->stuck_count); } } spin_unlock_irqrestore(&priv->irq_th_lock, flags); diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 5ff3fab72589..540ab4e34e70 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -107,7 +107,7 @@ struct cb_desc { u8 tx_use_drv_assinged_rate:1; u8 hw_sec:1; =20 - u8 nStuckCount; + u8 stuck_count; =20 /* Tx Firmware Related flags (10-11)*/ u8 cts_enable:1; --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EFF5186E4B for ; Sun, 8 Sep 2024 19:26:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823609; cv=none; b=dDWOo8ZJ0Y3MkZLoDAY02LkYajv3vBQIP+05c0Kaaw7NXPR+ppC/E5ug9jRedO8z384oGbdi57AGdEx8D02Zl6FqE9SN0l8ShBVfYjRGAH6g4LbeKgLMLXi8wpm5pznMHfMNpCz3actewzxZbTQZTOOooLEvo1hF8QAaOYjkoW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823609; c=relaxed/simple; bh=Zqbwng7d7h0S8knzbUlqjwzbO3ykL8Eo3fydFeADDEM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BnsDCGQo9WOiHGtQ7LMZecRwv36jkLdYhqcfU3wwJzzqlYF7JN174DxlQ/vjQjHE6Kjw36PfmLvetBxhn/zg3jSx9Puom+hTxQJKZPSfeQkNt1okDVoM5ITd4dk8R+mQmaocBh6catIvpUFVwl2eFvxNhn6u0V/WwElBINF+GXM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=RMLnW/aA; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="RMLnW/aA" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-205909afad3so36245205ad.2 for ; Sun, 08 Sep 2024 12:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823607; x=1726428407; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aDbUHTQNvzkg+oP3apbjo+jZaKg79sPfnGmQtUM6Ar8=; b=RMLnW/aAyDaSZST+9qjYljiCOsUDATViTt0F/57Gw+aqMkrMuG3WXQ8KQfOlBDPI4L 4x7WEh3frkCq3ZIdOKuFdmd7FWJziwHEO5fe9RfjHnKRuhHsO43Po+fyY2LIZga4ccdZ ftetx8PvMh1Yg8eKa6/EszWxn6gaixqKWnVx+wKh5vIQn9YCk4ddGRzTTmkeju0ywQFM 51h8E8ap3mFdY9ysRQfBFEdzGHTLc9tK6oMhn9sMzxHhm4y/Preg8GWSiThon6bAWOLg Q7FC0R/1YJ7NRHumKi7tHOI4CbZMcorcTlyd9ryNwv4MWwW9Z6zF31nMq5/yr13CLEdl u3KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823607; x=1726428407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aDbUHTQNvzkg+oP3apbjo+jZaKg79sPfnGmQtUM6Ar8=; b=X/vGxFHzfvCd6MYqBTlbx8Zbbi8r56dkrX5NCtQvo904lKJdOoV2sM2b6B6KVaDS6X URtrvUAWPmE+1Q46DejibDEu8AOoXAZ1zdcFtd7kJa00L24gf7adC1K0IwgUsqKuLpWx UUNvlRBFNmMs2PRbyPgHfl2haR/sCMJSfGuoI1hyVhKvq2Vp/AL/qbB/tSYNbo2SVkgH dN8MEGabH8H4Ath/xQ64UkTpC29h3oaHgRMoMMUbXcheWaQ5uu6ZV7ulCRYYKeFnocJT m7IGdXOKXgrGlymrJlGNGg+h4US+KHPExNuswfF1PRIV+i3/J7INJmoKcyZMdkwpo7c8 Bwww== X-Forwarded-Encrypted: i=1; AJvYcCWHylnIv1Gxob/bMlEuV2carGGZeUXH/mFurDu94tpXs6GOx8qb/FetzUnzPCxoVSdoE2MGBFIoIbjV+mo=@vger.kernel.org X-Gm-Message-State: AOJu0YyoU9SXtYu6UJZBbjE/OEoW8A8DVJ357/XystDBM9mYdyObnidg dFjMTQzrU6hWEq7E9ksM6tyNNq9ekCTB/xQnAmbrXYUJs2y6qT0jeqO9696Smt0= X-Google-Smtp-Source: AGHT+IGByVUqHkABLGee6fEJ4eJSe1A9yIRg1vpq8Lj59i+jhoVTBdkFOKVH0lIAJOQDwqW91cIitw== X-Received: by 2002:a17:903:943:b0:206:cc29:e4f7 with SMTP id d9443c01a7336-2070a5789d4mr76933035ad.34.1725823607589; Sun, 08 Sep 2024 12:26:47 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:47 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 14/16] Staging: rtl8192e: Rename variable bAddNewTs Date: Sun, 8 Sep 2024 12:26:31 -0700 Message-Id: <20240908192633.94144-15-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bAddNewTs to add_new_ts to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl819x_TSProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index 18b717a7409c..89092cd434de 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -225,7 +225,7 @@ static void MakeTSEntry(struct ts_common_info *ts_commo= n_info, u8 *addr, } =20 bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppT= S, - u8 *addr, u8 TID, enum tr_select tx_rx_select, bool bAddNewTs) + u8 *addr, u8 TID, enum tr_select tx_rx_select, bool add_new_ts) { u8 UP =3D 0; struct qos_tsinfo tspec; @@ -269,7 +269,7 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct t= s_common_info **ppTS, if (*ppTS) return true; =20 - if (!bAddNewTs) { + if (!add_new_ts) { netdev_dbg(ieee->dev, "add new TS failed(tid:%d)\n", UP); return false; } diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 540ab4e34e70..d8155ea3a002 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1757,7 +1757,7 @@ void rtllib_tx_ba_inact_timeout(struct timer_list *t); void rtllib_rx_ba_inact_timeout(struct timer_list *t); void rtllib_reset_ba_entry(struct ba_record *ba); bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppT= S, u8 *addr, - u8 TID, enum tr_select tx_rx_select, bool bAddNewTs); + u8 TID, enum tr_select tx_rx_select, bool add_new_ts); void rtllib_ts_init(struct rtllib_device *ieee); void rtllib_ts_start_add_ba_process(struct rtllib_device *ieee, struct tx_ts_record *pTxTS); --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDD8618785E for ; Sun, 8 Sep 2024 19:26:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823610; cv=none; b=EXTdl/spCKUBZSVTA64LSsTsaqHWO3E78Df2+7ok2B+y7zAlVHteCHM3TDf4Fe+uhzRdfRHI6Yhz4pbv1o9kLFLdQM+GYHSYEEyQ2gLXrduLua4xjnehv0C9QQNCY/RfcZ0wKSaZO1yy2bcSV56GsthhNzRAgW9eXp+aLcV2er0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823610; c=relaxed/simple; bh=QOJK5XCFnUgF4GgLDRGGWmBcTIrKAWOlHImOERfob9I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NOMZgK8aBB4t7HaqDCjRiENjYL/pSDBDcLMdVdwHc4iB67BnElt8CQ1dzOCYIywIKGkANKmlkPk7ej09ELkSAyM95PfPShyWzrchPMhoQB1BZVMkl+yrfbvPN6NSdxDlBorSt9G2bWJ9z1aSpUE/mHtu5Lt7inRv7v3LeGiQwDQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=fF+/CxoL; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="fF+/CxoL" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7d4fbe62bf5so2335609a12.0 for ; Sun, 08 Sep 2024 12:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823608; x=1726428408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=by6Pfc3Lz7+BT06vS7vmVqgE+mV643pZhMGdpE7msFg=; b=fF+/CxoL+BVDNTzHqE+8ybgirmed++Mf6twDK9Zkz4IqW5/nRDgTIPTq1CXCHA6NVJ ZkNpcIEkXtNsJ9yCr1vNvJHFfBcwGusEEWrKG2K0yAZz4iWzOonN+yJRAuzQ95cSjcFJ VpXQK7OT+ur8ucvV6h2QwClT+DGydHhmVmk2GEtJwos1owXWgVQBU2VmadZr3d4WhBAY 4H3A6HXwia2RbhtJkXEOVrh9Vj9SwXoOVm9Xv0/HYcQGmI8xXTxoXcHllzNew+Wf5wCU e++TjXumf9Bt9HHKDTh0kyiyy8/RGiAIu9rm7PcKqVMaIjjIdFPEBcbtaVplc+Ca4BFy AZ2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823608; x=1726428408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=by6Pfc3Lz7+BT06vS7vmVqgE+mV643pZhMGdpE7msFg=; b=VDn+lwAC2LIPB+7MPlQM21KWsTGkOSKCfgGpa3k6MfvwztB5APBE7cpTzxSdiaokBc 2vv0KzmhmHryjiJwh6hz456ymZoF0Xv7ZsfHcNimzTRCu5E4tllSPL3d9jl1LBCdqqiV TN3jDb40xsCMIpOwBo5Rw5goCNk0lixvdS0W1vINUeeiHsgeQR4ntrJQ3OVUf4n1SuWv cltTHbwu/T8CE+kn/h9G4Pem1XO0IWo2gIRm+VBB1ecqrvu1hl0mog+5XLWXKUh2nljx COjnYSJZtTVgXcCqFOtLwopN3Ip9593KP4ut9irL2v8TjM9TMLbF0gPUiHIKbT3CllpL kDTA== X-Forwarded-Encrypted: i=1; AJvYcCXtK5LYrD3rs73N2VgrMU2hYzVps+7gR7Gz4Js1WULsgfJS/lyFIUlCGoTX15sDymB17O4vOwA7w1RUOko=@vger.kernel.org X-Gm-Message-State: AOJu0YzaEvfr7S9ewFfRVKXi2KoU+EpULMmgscBaJDlOeQYgtUhVP6xX EJzSSlpyF4uUJA0/d7z9RcG57/MTPt1g8/SenTr0uaD2wNdg28vR3lN+zHK5DEg= X-Google-Smtp-Source: AGHT+IF0GAwWiGPFMhHa4izSvBq9RDiVdKEosBub1bRKUBYV9DctApLpV695+6Qkw9GxW02kKEZhPg== X-Received: by 2002:a05:6a20:d80a:b0:1cf:3245:5227 with SMTP id adf61e73a8af0-1cf324553d2mr3042023637.46.1725823608345; Sun, 08 Sep 2024 12:26:48 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:47 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 15/16] Staging: rtl8192e: Rename variable RxBufShift Date: Sun, 8 Sep 2024 12:26:32 -0700 Message-Id: <20240908192633.94144-16-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable RxBufShift to rx_buf_shift to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 6 +++--- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index eab6bbf9f3bf..d25ac5adfc49 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1493,7 +1493,7 @@ static void _rtl92e_translate_rx_signal_stats(struct = net_device *dev, u8 *tmp_buf; u8 *praddr; =20 - tmp_buf =3D skb->data + pstats->RxDrvInfoSize + pstats->RxBufShift; + tmp_buf =3D skb->data + pstats->RxDrvInfoSize + pstats->rx_buf_shift; =20 hdr =3D (struct ieee80211_hdr_3addr *)tmp_buf; fc =3D le16_to_cpu(hdr->frame_control); @@ -1640,10 +1640,10 @@ bool rtl92e_get_rx_stats(struct net_device *dev, st= ruct rtllib_rx_stats *stats, return false; =20 stats->RxDrvInfoSize =3D pdesc->RxDrvInfoSize; - stats->RxBufShift =3D (pdesc->Shift) & 0x03; + stats->rx_buf_shift =3D (pdesc->Shift) & 0x03; stats->decrypted =3D !pdesc->SWDec; =20 - pDrvInfo =3D (struct rx_fwinfo *)(skb->data + stats->RxBufShift); + pDrvInfo =3D (struct rx_fwinfo *)(skb->data + stats->rx_buf_shift); =20 stats->rate =3D _rtl92e_rate_hw_to_mgn((bool)pDrvInfo->RxHT, pDrvInfo->RxRate); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 5a4113c97b1c..d43841a9b21b 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1523,7 +1523,7 @@ static void _rtl92e_rx_normal(struct net_device *dev) =20 skb_put(skb, pdesc->Length); skb_reserve(skb, stats.RxDrvInfoSize + - stats.RxBufShift); + stats.rx_buf_shift); skb_trim(skb, skb->len - S_CRC_LEN); rtllib_hdr =3D (struct ieee80211_hdr *)skb->data; if (!is_multicast_ether_addr(rtllib_hdr->addr1)) { diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index d8155ea3a002..6cd374a9a955 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -475,7 +475,7 @@ struct rtllib_rx_stats { u32 time_stamp_high; =20 u8 RxDrvInfoSize; - u8 RxBufShift; + u8 rx_buf_shift; bool bIsAMPDU; bool bFirstMPDU; bool contain_htc; --=20 2.30.2 From nobody Sat Nov 30 16:23:43 2024 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8C16188006 for ; Sun, 8 Sep 2024 19:26:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823611; cv=none; b=s9X6SI7+QZNz3+u3QwaXNHhyig2bxI8nIavs44ItGAbhjBXTS7jNaPTc5OACzeW7+2+S2gjh/WHD0aepIuWWb8vyoWj0yhhFXaYZu9CE8Nu6rRcQ3ORoOWCM/OpZafLmljZ+P81YbQ8f0Chcv3jLq8zsJLM+pXneQaMB1fLwB+g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725823611; c=relaxed/simple; bh=MBbbnSXdZOhUn3Mse4L+r57MOuPjC5Eyv5DHhhmPN8s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VhuQnplJT5U6JYDc6xsihrAco8KJy4dUICwDAx+waDM8wgfMq5s8vMzlDTONzQPjKYsvtDu8p0AWgkje13TfjUN4IcC3Y6nAFspnAQozv3raJaz0//QP5Jd6RI/as9NTXPEHRK28X6SA4cNhG5I5mdOooceNiX2bacnleyhy1CI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=CZloKlLd; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="CZloKlLd" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7163489149eso2950035a12.1 for ; Sun, 08 Sep 2024 12:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1725823609; x=1726428409; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mON3Z21zmcNJw0Qu/8FEVGELLEA3M0aDfstnX5lY/gs=; b=CZloKlLdxNQjMzNrZOpkHskLb3wkJf77T1p/V7QqUZ8DBhEMXPIkB4T9EPtwqY+MRg 9JD2Ui3YuE8fOK9CWZKv30zfvpy7YVegSy6fM1YOc1+kzE57dwQ1mVgPaCxC3Fp18HWj WAnU7C//CK4M+30qc8UV0WkaihP7MuvzkN/qoy2/mafLpEEgX8x9BmrBvYSg7Hlum4Yt 1yGm/FltEJ+cm63kLz+WNes0BmST1rJR36tSR0oTphn2UFAVilHL8qgy0pMXUFnl6/rZ IHwG2qXCmn0fAn5hLDFQSdWTw17GFJ8VRwjZLRrxxpqUjAV4tLwVN/u4alp4o3gv+Goy qgCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725823609; x=1726428409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mON3Z21zmcNJw0Qu/8FEVGELLEA3M0aDfstnX5lY/gs=; b=CHV6rkmoZThJpl59A0jiO60IWkcK/ZzesBwXfv6Umsm6WpgQSS9MuH0aaIBjmITIXG kZ/TfFtKXmeYjn8yuXeyUtYiENBENqTe4Cqab+SbnRnd9rwzeuMZ+SE4eqkp/Vq2T3I/ b0wPX6Q5F3k1Jly9SwWT/NiCY/qrW309EFObMvQV3eYQm0WYmOxExYJYk1yjUTBnSaCf M5vLc5OV6JFAN2tDSNH6g+2oETIZ94GvpFIeCeHtMzACsesbqTcykB+v+N6KJs9jAN6Z LjBrnU3to4iUFmnYNG0kUaetaGRxY3rBPeVzrKPQ0RjJUi1q0HQF4JYytCOHNUDmLXO3 KGPw== X-Forwarded-Encrypted: i=1; AJvYcCVFTuJFVvitb8s4juCpNVvi8VXaSuEXzipt7FKO3JX2MVpk3a9lbn+fTYBXAEr6YgyeDL7C3kN7KIPQ4Gw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywbq7sImFtor/zEdOHSPBVS6BhdyO6gTx54zOjzJm46S/yEkuQO xKTCLGcq4q3JfRFJXJ/5Kpx1iBBU9cMlURXb50jFUxBfQShKCMez9J6h8pM4OUs= X-Google-Smtp-Source: AGHT+IFESgMCPQX8ayf3dx86Bk87zLc7Y3V/rHMhrJthqHllrR2mLJw/t1HsMRatPWpjBSSJSr2upA== X-Received: by 2002:a17:903:18a:b0:202:4047:e419 with SMTP id d9443c01a7336-206f051c897mr136127355ad.25.1725823609076; Sun, 08 Sep 2024 12:26:49 -0700 (PDT) Received: from lunchbox.darkphysics (c-73-83-183-190.hsd1.wa.comcast.net. [73.83.183.190]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710e1b085sm22703305ad.36.2024.09.08.12.26.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Sep 2024 12:26:48 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 16/16] Staging: rtl8192e: Rename variable RxDrvInfoSize Date: Sun, 8 Sep 2024 12:26:33 -0700 Message-Id: <20240908192633.94144-17-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240908192633.94144-1-tdavies@darkphysics.net> References: <20240908192633.94144-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable RxDrvInfoSize to rx_drv_info_size to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Tested-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 ++-- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/stagi= ng/rtl8192e/rtl8192e/r8190P_def.h index de0cd40df25f..552fd9b6e3e5 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h @@ -227,7 +227,7 @@ struct rx_desc { u16 Length:14; u16 CRC32:1; u16 ICV:1; - u8 RxDrvInfoSize; + u8 rx_drv_info_size; u8 Shift:2; u8 PHYStatus:1; u8 SWDec:1; diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index d25ac5adfc49..2672b1ddf88e 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1493,7 +1493,7 @@ static void _rtl92e_translate_rx_signal_stats(struct = net_device *dev, u8 *tmp_buf; u8 *praddr; =20 - tmp_buf =3D skb->data + pstats->RxDrvInfoSize + pstats->rx_buf_shift; + tmp_buf =3D skb->data + pstats->rx_drv_info_size + pstats->rx_buf_shift; =20 hdr =3D (struct ieee80211_hdr_3addr *)tmp_buf; fc =3D le16_to_cpu(hdr->frame_control); @@ -1639,7 +1639,7 @@ bool rtl92e_get_rx_stats(struct net_device *dev, stru= ct rtllib_rx_stats *stats, if (stats->hw_error) return false; =20 - stats->RxDrvInfoSize =3D pdesc->RxDrvInfoSize; + stats->rx_drv_info_size =3D pdesc->rx_drv_info_size; stats->rx_buf_shift =3D (pdesc->Shift) & 0x03; stats->decrypted =3D !pdesc->SWDec; =20 diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index d43841a9b21b..dc1301f1a0c1 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1522,7 +1522,7 @@ static void _rtl92e_rx_normal(struct net_device *dev) priv->rxbuffersize, DMA_FROM_DEVICE); =20 skb_put(skb, pdesc->Length); - skb_reserve(skb, stats.RxDrvInfoSize + + skb_reserve(skb, stats.rx_drv_info_size + stats.rx_buf_shift); skb_trim(skb, skb->len - S_CRC_LEN); rtllib_hdr =3D (struct ieee80211_hdr *)skb->data; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 6cd374a9a955..d6615f787d53 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -474,7 +474,7 @@ struct rtllib_rx_stats { u32 time_stamp_low; u32 time_stamp_high; =20 - u8 RxDrvInfoSize; + u8 rx_drv_info_size; u8 rx_buf_shift; bool bIsAMPDU; bool bFirstMPDU; --=20 2.30.2