From nobody Fri Dec 19 15:19:35 2025 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 749961D79B2 for ; Wed, 4 Sep 2024 12:06:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725451565; cv=none; b=Hc/BQ8gcaYybNruSKa8UwdOXROGnsEOKeisaNj/h5HmvIogjcT+663y5jvpukrvfUZgrQzLLTcNYooq9ZqJ990mOreH2mPecxWZ4Z91CLborHtyB6yTOO27+4ciEQ8QBmr09iGzedD+41HUd+zis6WGQkvYwZ2TudpY6EqkwxM4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725451565; c=relaxed/simple; bh=RIq0jhtP6YL6dkDTRapgeHrjMsu8iAr0r6jGOaHjgA4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ani5Tm/p9DZSTQ4BM8+nHFuifMkYmZ8iZJY6Fm2A2A297bVeqn7zw6UuYW5V5vCGtv0kbI1B5XqdGXsnE9oLbsaP5Hi6ols3Y0gMyNKHAcJeE4Wge4vuCj/b8F24048mI0hGCnMcRMgS2AfrrPAJmHaUH+XEp8rNUpL0zLrzYwI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=Eg7bQhjl; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=BIhD0Qq5 reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="Eg7bQhjl"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="BIhD0Qq5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1725451562; x=1756987562; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=+wniz+SsuI6wCX4+/GYWYwCSgqsJJKE8f4C0qwqIRqo=; b=Eg7bQhjl2B2kdtKzuurpBNR8Df+8lEN+U9aTViQrB6DgezSseecve0FT 9mhJnSiw+433rQbypUC+rW1jAFI6oJRxINlBpoomgrtwQVehWADCxsy4y fYht2qmdZ6uoBfVeoLDDneNM8DmlOlIkAQcZzpnUOqjtf1oDw38hw8eGI 1imKxcUYzwAkSVY4Kyis1MSWNTsVVtFDrmbh1SL3X/qMUyIcgNOXsQWL0 7TRKyecn2aQU94i0H4upk4CFY1ou0O7vgneCnua9OFDywhgdp7PQmyDBC zOrCe1WPzdnYaS2yb58pjzh2sNgwRl6y6QxxpzPy/iZ5Y3YV8qegUvR2k Q==; X-CSE-ConnectionGUID: PWyeOEUfQ26Pmot6NRxlYQ== X-CSE-MsgGUID: JNNvjltyR5OhzyIgrq/67g== X-IronPort-AV: E=Sophos;i="6.10,201,1719871200"; d="scan'208";a="38762443" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 04 Sep 2024 14:06:01 +0200 X-CheckPoint: {66D84D29-22-5FF8EC80-F6CEE9F8} X-MAIL-CPID: ADE970C8E52F6C1278F0055BC2A836CD_0 X-Control-Analysis: str=0001.0A782F29.66D84D29.00E6,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id A2E8B160024; Wed, 4 Sep 2024 14:05:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1725451557; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=+wniz+SsuI6wCX4+/GYWYwCSgqsJJKE8f4C0qwqIRqo=; b=BIhD0Qq5dqLldx2+dAnbTLi0SbQY9D4vLX40CB0D6y4/aqZlaMBTNTWfRqXvSXNspidAk1 bEiNvMt//odEf4FuEhE3ANDJHspPUhNQJERFnQ2uTbHDF5q0xu5KhKP9fci589hYDphJSN MPS4oDmOq+m0OOrvzKl8qmsRsGhWC/uqGztLXdN+7ZDKR0TrPtYSnBxJQIMUxDZ9nMd9Uz EDnegmDPt+3RtrAYNWfves3ZZYQf2/FXHBvJhCLldZuFkL4FQZ4JwVpQMvyt91zlbwiVDq fIddJiq0Buj9NV7Gbe9A/uo3wKPVq3lQTTWoCODJYjhYEkARCRRZaq6KG0lCPg== From: Alexander Stein To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Alexander Stein , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov Subject: [PATCH v3 1/3] drm/bridge: tc358767: Use dev_err_probe Date: Wed, 4 Sep 2024 14:05:43 +0200 Message-Id: <20240904120546.1845856-2-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240904120546.1845856-1-alexander.stein@ew.tq-group.com> References: <20240904120546.1845856-1-alexander.stein@ew.tq-group.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" The function calls preceding these returns can return -EPROBE_DEFER. So use dev_err_probe to add some information to /sys/kernel/debug/devices_deferred Signed-off-by: Alexander Stein Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/bridge/tc358767.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc3= 58767.c index 290e2532fab19..5ef33ce33dcaa 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -2298,7 +2298,8 @@ static int tc_probe_dpi_bridge_endpoint(struct tc_dat= a *tc) /* port@1 is the DPI input/output port */ ret =3D drm_of_find_panel_or_bridge(dev->of_node, 1, 0, &panel, &bridge); if (ret && ret !=3D -ENODEV) - return ret; + return dev_err_probe(dev, ret, + "Could not find DPI panel or bridge\n"); =20 if (panel) { bridge =3D devm_drm_panel_bridge_add(dev, panel); @@ -2326,7 +2327,8 @@ static int tc_probe_edp_bridge_endpoint(struct tc_dat= a *tc) /* port@2 is the output port */ ret =3D drm_of_find_panel_or_bridge(dev->of_node, 2, 0, &panel, NULL); if (ret && ret !=3D -ENODEV) - return ret; + return dev_err_probe(dev, ret, + "Could not find DSI panel or bridge\n"); =20 if (panel) { struct drm_bridge *panel_bridge; @@ -2550,7 +2552,7 @@ static int tc_probe(struct i2c_client *client) ret =3D tc_mipi_dsi_host_attach(tc); if (ret) { drm_bridge_remove(&tc->bridge); - return ret; + return dev_err_probe(dev, ret, "Failed to attach DSI host\n"); } } =20 --=20 2.34.1 From nobody Fri Dec 19 15:19:35 2025 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2BD21DC051 for ; Wed, 4 Sep 2024 12:06:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725451571; cv=none; b=rBWoge4xn/EKXg2xI5hjhTj8uruT/4dLKAzVb9bd2EmHkHXrnjh5eFs5KEsa/4wHqz5oTwFl7q0iWCyR0yEL2wGxh0oHX7gEiZ0uXnEs1oKlVUtY8m9SYPgoBSyZh0GBXae+vDXBviWGT+ZG6vceLIHy2qfGKdmot1gZ8HfrhAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725451571; c=relaxed/simple; bh=dwyFZOK7PN76ClG5q0V8YIcTXrsqKNvFopwLfgLFcos=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IskKlakbyhKrzVr/aLhDIWBdts/anlTpi2+VcyMakjFN7DZY5THrYA5QI/ACl3UXbQ3CV21MQmfO8NlTOmpywYdiOY7E6yToNs2ZQtxkSqR3eAkKwV6VBqa+KFWva88THKmvyIZnYOIe/aMur/QA8jjmcfCo5Cd0ocxitQvPRZE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=T0MGXfu/; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=mZXwE9sr reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="T0MGXfu/"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="mZXwE9sr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1725451569; x=1756987569; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=d5Md8bHzoNzLwbzoZBJBctmmy6rpnRNZXRRNsmdR80A=; b=T0MGXfu/F6oabNHCOpAPGsr0GahQPGTxtcrUjoxD4OZuYqWkH3fgdK3Y 6aB/Sj+rOMoMntnuAMFDs1bgr5FpHIOeTTBnruYYaXqJl+JLb2qXr3PfX gahDz66uNXYibdBSBVU18iumyPA5zOQ9h1qwZ84ztYE+XpvW3JLkMkqtK V3FdPHUr9O7KsbwjBoPQLpG7CBaZFQXGkORLgxNo6QUuhG7DWedIAKZ7R IMaiA+Y5oIi6GgumbH+H4us2M9bGgKQAkdsWUiAhN+A67eUzg80V/6n61 7HpZ3YsIzDE2uXjv/ZXHnw4fPkON8n+q2zO7rW2ZaiViF5YHFas8rhVAT A==; X-CSE-ConnectionGUID: sGVoKHSITN6Yi/ND3hv12g== X-CSE-MsgGUID: MeWdwC68Q7iKf38XIjDxpw== X-IronPort-AV: E=Sophos;i="6.10,201,1719871200"; d="scan'208";a="38762447" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 04 Sep 2024 14:06:06 +0200 X-CheckPoint: {66D84D2E-1E-6568578B-E2E34638} X-MAIL-CPID: 224E837B4563D50180A4D2595120254A_3 X-Control-Analysis: str=0001.0A782F18.66D84D2E.0133,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C7C9B160024; Wed, 4 Sep 2024 14:06:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1725451562; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=d5Md8bHzoNzLwbzoZBJBctmmy6rpnRNZXRRNsmdR80A=; b=mZXwE9srDpVPK4vusd1EIw1J/Nq/EsMxEb2XR2h9C55c1ibJAjgREedv9YoXLQHhj4mBUU DY98wSXReoqsw908xBedZtSSX8D8zX2cO1PQmuyOnqYbRn91N4Jsv3+DHFuMf/JEvy/xpD 8Qudxn1jJep61CqBfh8GVI9xFIlya4I+up9rW7hVYJws5q0z4jfX9WIQXVJsKr3FEXxaYq n7CmQTVSL6uFRrQHdAWIPnoLFfjKtugL56Mwb/bHYntrP+ZiozVKwGIvu/W3dc+CVF/VD3 cQ3KDx2USyvw12/P4WQHetuOGqjaVMYBsCnWGlEUEVu/vaL9ECqlBOYEs92t5g== From: Alexander Stein To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Alexander Stein , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/3] drm/bridge: tc358767: Only print GPIO debug output if they actually occur Date: Wed, 4 Sep 2024 14:05:44 +0200 Message-Id: <20240904120546.1845856-3-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240904120546.1845856-1-alexander.stein@ew.tq-group.com> References: <20240904120546.1845856-1-alexander.stein@ew.tq-group.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Currently the output the following output is printed upon each interrupt: tc358767 1-000f: GPIO0: This spams the kernel log while debugging an IRQ storm from the bridge. Only print the debug output if the GPIO hotplug event actually happened. Signed-off-by: Alexander Stein Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358767.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc3= 58767.c index 5ef33ce33dcaa..1c42c8c6e632e 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -2229,11 +2229,11 @@ static irqreturn_t tc_irq_handler(int irq, void *ar= g) bool h =3D val & INT_GPIO_H(tc->hpd_pin); bool lc =3D val & INT_GPIO_LC(tc->hpd_pin); =20 - dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin, - h ? "H" : "", lc ? "LC" : ""); - - if (h || lc) + if (h || lc) { + dev_dbg(tc->dev, "GPIO%d: %s %s\n", tc->hpd_pin, + h ? "H" : "", lc ? "LC" : ""); drm_kms_helper_hotplug_event(tc->bridge.dev); + } } =20 regmap_write(tc->regmap, INTSTS_G, val); --=20 2.34.1 From nobody Fri Dec 19 15:19:35 2025 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BD351DC05B for ; Wed, 4 Sep 2024 12:06:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725451574; cv=none; b=oMpMHxJeNDOII29Zn8ATOKjkIGZXk/i2gClAzj/S8cKU2X8SV8GuRTx4ZxOhunpxYg2ak4MgbDHCWN62T1WBpiqNhZpnn6aidwXFyMZRcbDkyW7AOXo4LVPioZdGmkOYy8wymOE8VfI6Hs9pV5sK5YS0qQ6eT+r9rv21zG9wCBw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725451574; c=relaxed/simple; bh=FM2Sg61QUKZNSOBLmUYNt05fapgkUNsA5G4V0Khchr0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IGlHhsydT25M0hwhPnKapqhsnPKalW/KC7zF+iJ6reG6Do3DMdzo8TsUIYAFL0LJuEJHmG3Ah1sinP7aWnnApYgeqKB7krwPkT78h+RPHRnUrQkgVuGEHi2ItrT7Yb4n/N2b8u0XdO8A9fDpR2zk5aPMjdmVMc6gwni80nPccCE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=dUZPCihh; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=Co8mFidp reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="dUZPCihh"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="Co8mFidp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1725451572; x=1756987572; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MZO2+A9qhMx/vtq4ZcJAHouq6Gc/o3MZqjq9U8ynBSU=; b=dUZPCihhvre2+veWkMfNVAv4PZ68fOxn77i7njgE1kHGN3Taobh8X5he zoBTicmAHjvgYgSPSs5BQJwJv5cY0lgUbh6BCrczneKsHs8Pn3FQdj/+U YRJgHlHRvJ8/bc3CooGkKb+zsGG3dzlweaZOko/fw7KNXFIDkrmP8ud2A rr31/O/PIdJVA+/YToFXkjaijOi00uYgRHDDrzvq3Wka5ZbIwDLKbjrcu 7Q3N5dvOzKXpLQK6974fn3SK8222VeSER2W8rJo33bz2hx8YkbfyWvbGc Ay11NMYbROPqsDRKdc3anZyLUV3mgapvRxMBr91dXid+UIASK7Oi7IVeJ A==; X-CSE-ConnectionGUID: uAeUHnF4Qv6Yru00un7Cyg== X-CSE-MsgGUID: yf8i1uEoQleF89+42bAuuQ== X-IronPort-AV: E=Sophos;i="6.10,201,1719871200"; d="scan'208";a="38762455" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 04 Sep 2024 14:06:11 +0200 X-CheckPoint: {66D84D33-28-E520F13A-D17B83D9} X-MAIL-CPID: 9456EAE7F1187E878E346CA9AC04C97F_2 X-Control-Analysis: str=0001.0A782F1C.66D84D34.0001,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 08C7A160024; Wed, 4 Sep 2024 14:06:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1725451567; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=MZO2+A9qhMx/vtq4ZcJAHouq6Gc/o3MZqjq9U8ynBSU=; b=Co8mFidpRANqj5uhUBrIkhmuJPZLlSak0cddvK+MiJWLMxHWQyQh6FzpDf4cv5zRtTEjZE GG62A8Q7VyBmHe4xtG6VJgZpQR0xnWFprDnuLBydQwFuxKTcotDrKHcbcn6GI5bBWb45Xh QGBySNQNu5McMaCf0c87Rd71eMx4RpBhKp4ESYYLpWKBBcM6HyiOHanGnVprIMoK9OYAy3 YpYfZDRtvFpL3E7mL4fToUp4OaXUlmLzGBK5K0xN5m8EOLnxnli7v9hXuWKmgkKK4sG16E s600d98QnJMmhWmzlnubX+Fr6EF+FkUS/yR/gpSN5LRegaMTGAE5d3WkInJo7g== From: Alexander Stein To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Alexander Stein , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/3] drm/bridge: tc358767: Support write-only registers Date: Wed, 4 Sep 2024 14:05:45 +0200 Message-Id: <20240904120546.1845856-4-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240904120546.1845856-1-alexander.stein@ew.tq-group.com> References: <20240904120546.1845856-1-alexander.stein@ew.tq-group.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 Content-Type: text/plain; charset="utf-8" Most registers are read-writable, but some are only RO or even WO. regmap does not support using readable_reg and wr_table when outputting in debugfs, so switch to writeable_reg. First check for RO or WO registers and fallback tc_readable_reg() for the leftover RW registers. Signed-off-by: Alexander Stein Reviewed-by: Robert Foss --- drivers/gpu/drm/bridge/tc358767.c | 40 ++++++++++++++++++++----------- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc3= 58767.c index 1c42c8c6e632e..159c95b26d33c 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -2169,19 +2169,31 @@ static const struct regmap_access_table tc_precious= _table =3D { .n_yes_ranges =3D ARRAY_SIZE(tc_precious_ranges), }; =20 -static const struct regmap_range tc_non_writeable_ranges[] =3D { - regmap_reg_range(PPI_BUSYPPI, PPI_BUSYPPI), - regmap_reg_range(DSI_BUSYDSI, DSI_BUSYDSI), - regmap_reg_range(DSI_LANESTATUS0, DSI_INTSTATUS), - regmap_reg_range(TC_IDREG, SYSSTAT), - regmap_reg_range(GPIOI, GPIOI), - regmap_reg_range(DP0_LTSTAT, DP0_SNKLTCHGREQ), -}; - -static const struct regmap_access_table tc_writeable_table =3D { - .no_ranges =3D tc_non_writeable_ranges, - .n_no_ranges =3D ARRAY_SIZE(tc_non_writeable_ranges), -}; +static bool tc_writeable_reg(struct device *dev, unsigned int reg) +{ + /* RO reg */ + switch (reg) { + case PPI_BUSYPPI: + case DSI_BUSYDSI: + case DSI_LANESTATUS0: + case DSI_LANESTATUS1: + case DSI_INTSTATUS: + case TC_IDREG: + case SYSBOOT: + case SYSSTAT: + case GPIOI: + case DP0_LTSTAT: + case DP0_SNKLTCHGREQ: + return false; + } + /* WO reg */ + switch (reg) { + case DSI_STARTDSI: + case DSI_INTCLR: + return true; + } + return tc_readable_reg(dev, reg); +} =20 static const struct regmap_config tc_regmap_config =3D { .name =3D "tc358767", @@ -2191,9 +2203,9 @@ static const struct regmap_config tc_regmap_config = =3D { .max_register =3D PLL_DBG, .cache_type =3D REGCACHE_MAPLE, .readable_reg =3D tc_readable_reg, + .writeable_reg =3D tc_writeable_reg, .volatile_table =3D &tc_volatile_table, .precious_table =3D &tc_precious_table, - .wr_table =3D &tc_writeable_table, .reg_format_endian =3D REGMAP_ENDIAN_BIG, .val_format_endian =3D REGMAP_ENDIAN_LITTLE, }; --=20 2.34.1