From nobody Fri Dec 19 17:13:23 2025 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38CC21CC17F; Wed, 4 Sep 2024 09:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725441052; cv=none; b=gM9KqSfAhTpg/BNMg8sQ19pvAxg8tEwJb9ZqZfz4tUfD3Ef6KEsqLmCEa+RDudcWQIG67nOYSfpLWM/QMpygtyKV2GDcy0yoJyjy6bzTBPHNi7T+QxiRQHaDLCx7ZfdWCgvzlDxVX0N9WLMS/DulBXTDXExOymnSV9wlTGCmVdk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725441052; c=relaxed/simple; bh=ZyXy6pk/7SswX/Ts0f9/hnODNCyRAbhT3bfmyghWwjA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qE2M2Bbr3AAY/LN+mFyvNeySejb6zZWMbqFR2aoN2R7wLjr4xKb/ydO43GDqkGJZUuTR3GlZ5MMoVJlsYFdSfrhniQZNLMdD8I13gE/7/b4CmM0fnzJeHQ5JJoi5i9sfsm/3W8kLt/NGOaa/koFifMlBOs21rXPoPdo99SbHzsI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=emxeqRxX; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="emxeqRxX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1725441051; x=1756977051; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZyXy6pk/7SswX/Ts0f9/hnODNCyRAbhT3bfmyghWwjA=; b=emxeqRxXJeZFjfSRuL82EhzM91IkmJlxNxfKD+nXc52XjGXXsa5iecEi lpvlQDOexaVbMXo8/19ExVKGa06B1n1QWbc6nIU7LLmTzlSyzLY+OxGA+ w9JWJtE2WUECQ1QBePTT01jTSxXHgmeE4ffNn8HzfeParJ0IKkCrk7amt dRPulk5RwZ7szGZN/ave/Od+Gnp2h0nh6M/xHyRe8wJ0J42GmDKzHMDvG nvG1DrRe49pj4WZd814fWzF6EaIhnB2LoHOo0ClAbwz/UkUjb4DVmg0Ot B8DLWxcRfGOvvrneEgagnrpYedjdEe3NnE9pXgP7wIxdjBgIqN3yZ5nYd Q==; X-CSE-ConnectionGUID: T9hQj/yXR7C6BLB59O45Pg== X-CSE-MsgGUID: 3l5skqaHTvWYNMqJ4uSF9Q== X-IronPort-AV: E=Sophos;i="6.10,201,1719903600"; d="scan'208";a="31212934" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Sep 2024 02:10:48 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 4 Sep 2024 02:10:47 -0700 Received: from HYD-DK-UNGSW21.microchip.com (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Wed, 4 Sep 2024 02:10:42 -0700 From: Raju Lakkaraju To: CC: , , , , , , , , , , , , , Subject: [PATCH net-next V5 2/5] net: lan743x: Create separate PCS power reset function Date: Wed, 4 Sep 2024 14:36:42 +0530 Message-ID: <20240904090645.8742-3-Raju.Lakkaraju@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240904090645.8742-1-Raju.Lakkaraju@microchip.com> References: <20240904090645.8742-1-Raju.Lakkaraju@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Create separate PCS power reset function from lan743x_sgmii_config () to use as subroutine. Reviewed-by: Andrew Lunn Signed-off-by: Raju Lakkaraju --- Change List: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D V4 -> V5: - No change V3 -> V4: - No change V2 -> V3: - No change V1 -> V2: - No change drivers/net/ethernet/microchip/lan743x_main.c | 55 ++++++++++--------- 1 file changed, 29 insertions(+), 26 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/et= hernet/microchip/lan743x_main.c index e418539565b1..ce1e104adc20 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -1147,12 +1147,39 @@ static int lan743x_pcs_seq_state(struct lan743x_ada= pter *adapter, u8 state) return 0; } =20 +static int lan743x_pcs_power_reset(struct lan743x_adapter *adapter) +{ + int mii_ctl; + int ret; + + /* SGMII/1000/2500BASE-X PCS power down */ + mii_ctl =3D lan743x_sgmii_read(adapter, MDIO_MMD_VEND2, MII_BMCR); + if (mii_ctl < 0) + return mii_ctl; + + mii_ctl |=3D BMCR_PDOWN; + ret =3D lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl); + if (ret < 0) + return ret; + + ret =3D lan743x_pcs_seq_state(adapter, PCS_POWER_STATE_DOWN); + if (ret < 0) + return ret; + + /* SGMII/1000/2500BASE-X PCS power up */ + mii_ctl &=3D ~BMCR_PDOWN; + ret =3D lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl); + if (ret < 0) + return ret; + + return lan743x_pcs_seq_state(adapter, PCS_POWER_STATE_UP); +} + static int lan743x_sgmii_config(struct lan743x_adapter *adapter) { struct net_device *netdev =3D adapter->netdev; struct phy_device *phydev =3D netdev->phydev; enum lan743x_sgmii_lsd lsd =3D POWER_DOWN; - int mii_ctl; bool status; int ret; =20 @@ -1209,31 +1236,7 @@ static int lan743x_sgmii_config(struct lan743x_adapt= er *adapter) netif_dbg(adapter, drv, adapter->netdev, "SGMII 1G mode enable\n"); =20 - /* SGMII/1000/2500BASE-X PCS power down */ - mii_ctl =3D lan743x_sgmii_read(adapter, MDIO_MMD_VEND2, MII_BMCR); - if (mii_ctl < 0) - return mii_ctl; - - mii_ctl |=3D BMCR_PDOWN; - ret =3D lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl); - if (ret < 0) - return ret; - - ret =3D lan743x_pcs_seq_state(adapter, PCS_POWER_STATE_DOWN); - if (ret < 0) - return ret; - - /* SGMII/1000/2500BASE-X PCS power up */ - mii_ctl &=3D ~BMCR_PDOWN; - ret =3D lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl); - if (ret < 0) - return ret; - - ret =3D lan743x_pcs_seq_state(adapter, PCS_POWER_STATE_UP); - if (ret < 0) - return ret; - - return 0; + return lan743x_pcs_power_reset(adapter); } =20 static void lan743x_mac_set_address(struct lan743x_adapter *adapter, --=20 2.34.1