From nobody Fri Dec 19 12:04:01 2025 Received: from pfhigh7-smtp.messagingengine.com (fhigh7-smtp.messagingengine.com [103.168.172.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBC3A1A0BED for ; Tue, 3 Sep 2024 10:15:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725358529; cv=none; b=YxBd3TTLcK0vEixd64OuaA9Ihxso0P/0NDcUP4jqfMONkAIHSeni28p9jeUTvFffXn7GRtALaTmpa5H9TjAqk3zeSYfvn/IwvH/6/dL5rPDBivKkcnZonUHvdwokbp+pU9h0f/uDx9JlVbgNRYDIXs57Lj9lRuvklqsX4/emDoU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725358529; c=relaxed/simple; bh=G/PvEY3igPVstOiobgTRHCXGTmIr9SML5otHwVdoxFE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lM84NYM0E6sZM3uXVi4E0rSx26Ee7Aapw9Kh3e1uTf3/oAksje2A07yk5D1vdbXT0rJTZBZNCi6DUIbS9uGwlHRbSRt8ani1s7vPOtkwK0RLmAE7i77vr0BC5dASMmOsaKD8ALr/E25mBgBfRLYuQ4t+TcWaiivFg85bGCNLEmM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=cSLMPLFk; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=pkaA3Df1; arc=none smtp.client-ip=103.168.172.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="cSLMPLFk"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="pkaA3Df1" Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.phl.internal (Postfix) with ESMTP id EDEE91140100; Tue, 3 Sep 2024 06:15:26 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-05.internal (MEProxy); Tue, 03 Sep 2024 06:15:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm1; t=1725358526; x=1725444926; bh=hievqMDYxf TONiyF8th4rDfFHnRvVJ8WTM3zZAohKSo=; b=cSLMPLFktmplNGaHNwoeAaYyZc S6Um4dWP4cQnpmmUIoPHX2JBBGN92pXhMIaYEcrJwWJ2A0p0x2BJeqYoF3BmJHhz Ae6cu0Nemawze80s2gSpQf899n4Rpf03/3odFBiao9V41m3JrIZSccSFztWBXi0L bhmyiKFWmwYf6+LaHUFMSoEu2PNqV50SLWdHMj5zk1QgOrZyrlsYIGAqgi7c3E1e 6gRmv+tvcmlpvkrbrtdf8kAxGWP4SauJ0N9yMzLAw0S85e7MI87svgkf9o+eGykB +lBMh1/HloTZuwok+GH2K69NRiuqAKTI0GOCo+mK8abW695Ue7hA3FyduTGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1725358526; x=1725444926; bh=hievqMDYxfTONiyF8th4rDfFHnRv VJ8WTM3zZAohKSo=; b=pkaA3Df1Lb6hzf8S27UsEXHjrwjb74RrVzs2H4PUn5kY c/xFT5bP/9IiolwQbfGcx0h7DL72gtJ1hvDQ6+h643drKDf2bwmtS0skIPRcyawd azC0u0upH4HOShHMxFdWQQYHU1srj9k0KZWwVobM9KrtV8AeGoarVzSlCvlWWSbC qA0LbUO3rhrxjDTSxDtz5Xuaf5sz3ZnEQQUW9kfmsDCHK0q2ldVsCeL+KDnflwOD EBolFXi6ss7nsECjIiE782d1R7x4+iYbfoGc7wRBHKomK1T/bXIKcr6KyF5ab3/F 2hqL1SRXDjcM1SrgKtuqIhpttZxLthFUkxzRJUmrOg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehhedgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf ffkffoggfgsedtkeertdertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohht ohcuoehoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtth gvrhhnpeffvdeuleffveekudfhteejudffgefhtedtgfeutdfgvdfgueefudehveehveek keenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqd htrghkrghshhhisehsrghkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedvpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvghlse hlihhsthhsrdhsohhurhgtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhugidq khgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Sep 2024 06:15:25 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH] firewire: ohci: obsolete direct usage of printk_ratelimit() Date: Tue, 3 Sep 2024 19:15:23 +0900 Message-ID: <20240903101523.317110-1-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A commit 77006a0a8282 ("ratelimit: add comment warning people off printk_ratelimit()") has already deprecated printk_ratelimit(). This commit uses alternative functions to obsolete its usage. Signed-off-by: Takashi Sakamoto --- drivers/firewire/ohci.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index e662dc30c21f..3930fdd56155 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -2268,13 +2268,11 @@ static irqreturn_t irq_handler(int irq, void *data) reg_read(ohci, OHCI1394_PostedWriteAddressLo); reg_write(ohci, OHCI1394_IntEventClear, OHCI1394_postedWriteErr); - if (printk_ratelimit()) - ohci_err(ohci, "PCI posted write error\n"); + dev_err_ratelimited(ohci->card.device, "PCI posted write error\n"); } =20 if (unlikely(event & OHCI1394_cycleTooLong)) { - if (printk_ratelimit()) - ohci_notice(ohci, "isochronous cycle too long\n"); + dev_notice_ratelimited(ohci->card.device, "isochronous cycle too long\n"= ); reg_write(ohci, OHCI1394_LinkControlSet, OHCI1394_LinkControl_cycleMaster); } @@ -2286,8 +2284,7 @@ static irqreturn_t irq_handler(int irq, void *data) * stop active cycleMatch iso contexts now and restart * them at least two cycles later. (FIXME?) */ - if (printk_ratelimit()) - ohci_notice(ohci, "isochronous cycle inconsistent\n"); + dev_notice_ratelimited(ohci->card.device, "isochronous cycle inconsisten= t\n"); } =20 if (unlikely(event & OHCI1394_unrecoverableError)) --=20 2.43.0