From nobody Fri Dec 19 12:07:25 2025 Received: from pfhigh7-smtp.messagingengine.com (fhigh7-smtp.messagingengine.com [103.168.172.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9766745003 for ; Tue, 3 Sep 2024 10:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725358502; cv=none; b=YWTa+vg6od9CY1I6QHY8xQpdap9YWyDNEVBxidWfoRrhy2hK51hQEw+b+3iAczHYYFWv8KIMhb30XlBs/v6o9/OdPPNvMorLZXeCnkD7T5lbkX31OA7ZTia63Xrn+tpFN97sjRDGCJ1lxM9TTinoYt2oWzQmE82E240TlePtgUo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725358502; c=relaxed/simple; bh=KVMOq3+sSI0aDG//k6mpQqkxfoGps7TxFTMp1ubr8Q0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nXvm1YdoowBXMwghOMUqw/1jiFwqKeb1mJNQXtKF3Ef3H2O5x6a2v1z1v+O31uYKp7R5aGdg99fRk3SScvTagq8PrFscvw/ft6LatkRT9hvKgo+YqggWb7F4PJdWGfvIijN8UvLhOyn/hi7997rZl8LSwZXVJNddohxUUiLteT8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=G8DkbHzp; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=H8ejT175; arc=none smtp.client-ip=103.168.172.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="G8DkbHzp"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="H8ejT175" Received: from phl-compute-04.internal (phl-compute-04.phl.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 961811140100; Tue, 3 Sep 2024 06:14:59 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Tue, 03 Sep 2024 06:14:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm1; t=1725358499; x=1725444899; bh=cQ3Cmnl22p JyvQzeMH+44ginKFaS1ZMnNT2AenBDixc=; b=G8DkbHzpEnATt0/HLcv+Eqf8B/ JAtOAzQkCI+wbkXCIYHblnwv09ze9cLfpiTNAdOjMBMWOJSZWGHkU8e47ihEiYqP rG8mPpBYflwF3JdfX68t9ddVcYw/g8SbtAypJPisZfubdfMPpQwzUynh+quOfuFA qTfE3FmzgVUQdcg58C/Sh1oyu6kFiq8QabUU0FHKhXNUs0kvtnYRuFu7ukAq2CRI Uo952jgQiN+xQebqnIcApr/eXlT5Iyh7/HuMVOoZ5bTH15tpSsXRMYaKQaqBBqEW KX8jPjMUwQmKN/CkKB5Dh42s5AYgiBZ6DXR/QrvbtpNDL14t4K2LdI7tH38g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1725358499; x=1725444899; bh=cQ3Cmnl22pJyvQzeMH+44ginKFaS 1ZMnNT2AenBDixc=; b=H8ejT175tuxnTA/zEuvxb2q7daPqZTApKJm9L2p5Rx2O F7e8tZbYcGpJTZegJnfMKMwxx3gOBHecsNxBCVaj2l6VHKDzcmv1oiHkO1sGNvSO Kh1GABW0YJIumAiVp2tu90vqfoSmrbFkSh0XxkVQJp8SXO4TqUyP4iLm5kzUONK1 vDGsYUje7UKWDY3L882Uxw+OOTMMFsXRC1UANNr7QIMJxb94qgmzWNLJAgLlDXw2 9wtTvqqU5x7H2pfELlCXVN4lI4/aEh6Jz+2tLtVEweC7Bs576gFLjP6oakiDFXmF gqpPGxz9h/38w9OBRfJGtZ/GyYZ+XFPL7tYA2SgymQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehhedgvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf ffkffoggfgsedtkeertdertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghmohht ohcuoehoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrghtth gvrhhnpeffvdeuleffveekudfhteejudffgefhtedtgfeutdfgvdfgueefudehveehveek keenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehoqd htrghkrghshhhisehsrghkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedvpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvghlse hlihhsthhsrdhsohhurhgtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhugidq khgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 Sep 2024 06:14:58 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH] firewire: ohci: deprecate debug parameter Date: Tue, 3 Sep 2024 19:14:55 +0900 Message-ID: <20240903101455.317067-1-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Many tracepoints events have been added to 6.10 and 6.11 kernels. They are available as an alternative of debug parameter in firewire-ohci module. The logging messages enabled by the parameter require some cumbersomes in a point of maintenance; e.g. the code to decode transaction frame. This commit adds deprecation text to conduct users to them.. Signed-off-by: Takashi Sakamoto --- drivers/firewire/ohci.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index a3a37955b174..e662dc30c21f 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -396,7 +396,7 @@ MODULE_PARM_DESC(quirks, "Chip quirks (default =3D 0" =20 static int param_debug; module_param_named(debug, param_debug, int, 0644); -MODULE_PARM_DESC(debug, "Verbose logging (default =3D 0" +MODULE_PARM_DESC(debug, "Verbose logging, deprecated in v6.11 kernel or la= ter. (default =3D 0" ", AT/AR events =3D " __stringify(OHCI_PARAM_DEBUG_AT_AR) ", self-IDs =3D " __stringify(OHCI_PARAM_DEBUG_SELFIDS) ", IRQs =3D " __stringify(OHCI_PARAM_DEBUG_IRQS) @@ -2197,6 +2197,11 @@ static irqreturn_t irq_handler(int irq, void *data) if (!event || !~event) return IRQ_NONE; =20 + if (unlikely(param_debug > 0)) { + dev_notice_ratelimited(ohci->card.device, + "The debug parameter is superceded by tracepoints events, and d= eprecated."); + } + /* * busReset and postedWriteErr events must not be cleared yet * (OHCI 1.1 clauses 7.2.3.2 and 13.2.8.1) --=20 2.43.0