From nobody Fri Dec 19 07:32:33 2025 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86F3E1BD00A for ; Fri, 30 Aug 2024 18:02:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725040969; cv=none; b=R7Hb+InZXhyukqS1xaaAW2qqO4sy+Or5P7UR/vntrPZuO4Q3XXsvi8Fy6qb6NUFJK7qfG9pFHhnxxh77Lbu6Etk2n/rXb6l3CcVTep67HsPjq8Gr/R9xLe9Ex3tK9Sbn3lC7E6/KaQfbJR5VME/q0TjDuTWXT684As3O8l/2aD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725040969; c=relaxed/simple; bh=GLtC4xIckdCAewMsXHXW4AA3wd60JBWkFbVxXIaLVMw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=I2BzmqVl9lrw5X3bZhnDhmZVkhAALWMItHtAzxM5Zz/CDRfPevDJuRM7RthIF7JEHDjHsJVturUJHp77EaAY08gi1WOBreXw/0ipSwlqzIa6Ml3R8qSK6+NKUiojUcuvgnYjsx+sxivc9OkluFRzsAG/i4pnzPhbMRsarK6B9jA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=KMoX53yV; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="KMoX53yV" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-7c3d415f85eso268320a12.0 for ; Fri, 30 Aug 2024 11:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1725040967; x=1725645767; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UsW4WSHclFQuxQsQy9Vi261+UBXUohqxuc8CpQQRsjc=; b=KMoX53yVJRPoHeAT84Fsukey+7ojBsgv4aVMzRqjRDiA+OkfRseRj/l2W1Z0eY/0on pPs2M7Am9UvW32Ha06NX6OFxIU67veKrYDMLw7mRZLd2vMcDDbknDPVAdOVd8o9cQv+7 gAletdxK5ble92UdOV6nqgY5hWwpgeORMipiA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725040967; x=1725645767; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UsW4WSHclFQuxQsQy9Vi261+UBXUohqxuc8CpQQRsjc=; b=rtAe0CGgTwctOEm8WG/WAnyrnh/+3piCOnltBo3q6q1TZd8SUgVFggcXLA6eULFjp7 sGkak3OiaAayLZU/gnqIa22OF7MVJbdeYtZmhV0QG6vYdi83vg2On6Ij3MgaHdmKx6tn xHc2c2nQtYSTulBtlkyx5KYWKNdaLXaLT03kBr+QmDIyBuNqOqIPq8RAu5jVOYfjeHmY 50IltflPm7PVDNP1FvX4UqQGT44wkS4zA4Pn+D6nBK3jpJ0/g4lJPoGeIqxy1hkyBswY AlsTvouTKngIaGAtv6mxLBGGdAr6mKAE3FQHakWoIhcbBGUXT/c0pcXB8yRlfJBAYwsz 2NiQ== X-Forwarded-Encrypted: i=1; AJvYcCVpE+VnTdG7yUX5cbRCVt/aFs0aPfCWLilqq+lns1W5ryMHbnMXlN1KCoUJddmb2EplPfIsj/qJ3v2z7+0=@vger.kernel.org X-Gm-Message-State: AOJu0Yyhg/apzh8Orxbw2M1u9bhEd865wxB/YBAgw8Dm5YvAKzqjYehj B33T0SmNmTCkIO7npmW18MA8kmt+qLOX1BpcoTUCKT+lu2zxQbnwW2lwHMrhfflCzy/7RgBROaI = X-Google-Smtp-Source: AGHT+IFVcv9BKi1oAf72gfGg95j/WA/x6/ipRZgMh/F89Lt2abZpbCyTm4IVK3HWruQmyswmFRdJyw== X-Received: by 2002:a05:6a21:3385:b0:1c4:af14:d9a4 with SMTP id adf61e73a8af0-1ccee3bc42dmr1727971637.3.1725040966307; Fri, 30 Aug 2024 11:02:46 -0700 (PDT) Received: from localhost (150.12.83.34.bc.googleusercontent.com. [34.83.12.150]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-715e56d7278sm3153762b3a.171.2024.08.30.11.02.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Aug 2024 11:02:45 -0700 (PDT) From: jeffxu@chromium.org To: akpm@linux-foundation.org Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, pedro.falcato@gmail.com, willy@infradead.org, lorenzo.stoakes@oracle.com, broonie@kernel.org, vbabka@suse.cz, Liam.Howlett@oracle.com, rientjes@google.com, keescook@chromium.org, Jeff Xu Subject: [PATCH v3 5/5] selftests/mseal: add more tests for mremap Date: Fri, 30 Aug 2024 18:02:37 +0000 Message-ID: <20240830180237.1220027-6-jeffxu@chromium.org> X-Mailer: git-send-email 2.46.0.469.g59c65b2a67-goog In-Reply-To: <20240830180237.1220027-1-jeffxu@chromium.org> References: <20240830180237.1220027-1-jeffxu@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Jeff Xu Add sealing test to cover mremap for Expand/shrink/move across vmas. Signed-off-by: Jeff Xu --- tools/testing/selftests/mm/mseal_test.c | 202 +++++++++++++++++++++++- 1 file changed, 201 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/selfte= sts/mm/mseal_test.c index 3516389034a7..fee655bbbf0a 100644 --- a/tools/testing/selftests/mm/mseal_test.c +++ b/tools/testing/selftests/mm/mseal_test.c @@ -2339,6 +2339,197 @@ static void test_seal_mmap_reuse_addr(bool seal) REPORT_TEST_PASS(); } =20 +static void test_seal_mremap_shrink_multiple_vmas(bool seal) +{ + void *ptr; + unsigned long page_size =3D getpagesize(); + unsigned long size =3D 12 * page_size; + int ret; + void *ret2; + int prot; + + setup_single_address(size, &ptr); + FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + + ret =3D sys_mprotect(ptr + 4 * page_size, 4 * page_size, PROT_NONE); + FAIL_TEST_IF_FALSE(!ret); + + size =3D get_vma_size(ptr, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + size =3D get_vma_size(ptr + 4 * page_size, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + if (seal) { + ret =3D sys_mseal(ptr + 4 * page_size, 4 * page_size); + FAIL_TEST_IF_FALSE(!ret); + } + + ret2 =3D sys_mremap(ptr, 12 * page_size, 6 * page_size, 0, 0); + if (seal) { + FAIL_TEST_IF_FALSE(ret2 =3D=3D (void *) MAP_FAILED); + FAIL_TEST_IF_FALSE(errno =3D=3D EPERM); + + size =3D get_vma_size(ptr, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + size =3D get_vma_size(ptr + 4 * page_size, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + } else { + FAIL_TEST_IF_FALSE(ret2 =3D=3D ptr); + + size =3D get_vma_size(ptr, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + size =3D get_vma_size(ptr + 4 * page_size, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 2 * page_size); + } + + REPORT_TEST_PASS(); +} + +static void test_seal_mremap_expand_multiple_vmas(bool seal) +{ + void *ptr; + unsigned long page_size =3D getpagesize(); + unsigned long size =3D 12 * page_size; + int ret; + void *ret2; + int prot; + + setup_single_address(size, &ptr); + FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + + ret =3D sys_mprotect(ptr + 4 * page_size, 4 * page_size, PROT_NONE); + FAIL_TEST_IF_FALSE(!ret); + + /* ummap last 4 pages. */ + ret =3D sys_munmap(ptr + 8 * page_size, 4 * page_size); + FAIL_TEST_IF_FALSE(!ret); + + size =3D get_vma_size(ptr, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + size =3D get_vma_size(ptr + 4 * page_size, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + if (seal) { + ret =3D sys_mseal(ptr + 4 * page_size, 4 * page_size); + FAIL_TEST_IF_FALSE(!ret); + } + + ret2 =3D sys_mremap(ptr, 8 * page_size, 12 * page_size, 0, 0); + FAIL_TEST_IF_FALSE(ret2 =3D=3D (void *) MAP_FAILED); + + size =3D get_vma_size(ptr, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + size =3D get_vma_size(ptr + 4 * page_size, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + REPORT_TEST_PASS(); +} + +static void test_seal_mremap_move_expand_multiple_vmas(bool seal) +{ + void *ptr; + unsigned long page_size =3D getpagesize(); + unsigned long size =3D 12 * page_size; + int ret; + void *ret2; + int prot; + void *ptr2; + + setup_single_address(size, &ptr); + FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + + setup_single_address(size, &ptr2); + FAIL_TEST_IF_FALSE(ptr2 !=3D (void *)-1); + + ret =3D sys_munmap(ptr2, 12 * page_size); + FAIL_TEST_IF_FALSE(!ret); + + ret =3D sys_mprotect(ptr + 4 * page_size, 4 * page_size, PROT_NONE); + FAIL_TEST_IF_FALSE(!ret); + + /* ummap last 4 pages. */ + ret =3D sys_munmap(ptr + 8 * page_size, 4 * page_size); + FAIL_TEST_IF_FALSE(!ret); + + size =3D get_vma_size(ptr, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + size =3D get_vma_size(ptr + 4 * page_size, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + if (seal) { + ret =3D sys_mseal(ptr + 4 * page_size, 4 * page_size); + FAIL_TEST_IF_FALSE(!ret); + } + + /* move and expand cross VMA boundary will fail */ + ret2 =3D sys_mremap(ptr, 8 * page_size, 10 * page_size, MREMAP_FIXED | MR= EMAP_MAYMOVE, ptr2); + FAIL_TEST_IF_FALSE(ret2 =3D=3D (void *) MAP_FAILED); + + size =3D get_vma_size(ptr, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + size =3D get_vma_size(ptr + 4 * page_size, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + + REPORT_TEST_PASS(); +} + +static void test_seal_mremap_move_shrink_multiple_vmas(bool seal) +{ + void *ptr; + unsigned long page_size =3D getpagesize(); + unsigned long size =3D 12 * page_size; + int ret; + void *ret2; + int prot; + void *ptr2; + + setup_single_address(size, &ptr); + FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); + + setup_single_address(size, &ptr2); + FAIL_TEST_IF_FALSE(ptr2 !=3D (void *)-1); + + ret =3D sys_munmap(ptr2, 12 * page_size); + FAIL_TEST_IF_FALSE(!ret); + + ret =3D sys_mprotect(ptr + 4 * page_size, 4 * page_size, PROT_NONE); + FAIL_TEST_IF_FALSE(!ret); + + size =3D get_vma_size(ptr, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + FAIL_TEST_IF_FALSE(prot =3D=3D 4); + + size =3D get_vma_size(ptr + 4 * page_size, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + FAIL_TEST_IF_FALSE(prot =3D=3D 0); + + if (seal) { + ret =3D sys_mseal(ptr + 4 * page_size, 4 * page_size); + FAIL_TEST_IF_FALSE(!ret); + } + + /* move and shrink cross VMA boundary is NOK */ + ret2 =3D sys_mremap(ptr, 12 * page_size, 8 * page_size, MREMAP_FIXED | MR= EMAP_MAYMOVE, ptr2); + FAIL_TEST_IF_FALSE(ret2 =3D=3D (void *) MAP_FAILED); + + size =3D get_vma_size(ptr, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + FAIL_TEST_IF_FALSE(prot =3D=3D 4); + + size =3D get_vma_size(ptr + 4 * page_size, &prot); + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); + FAIL_TEST_IF_FALSE(prot =3D=3D 0); + + REPORT_TEST_PASS(); +} + int main(int argc, char **argv) { bool test_seal =3D seal_support(); @@ -2360,7 +2551,7 @@ int main(int argc, char **argv) if (!get_vma_size_supported()) ksft_exit_skip("get_vma_size not supported\n"); =20 - ksft_set_plan(97); + ksft_set_plan(105); =20 test_seal_addseal(); test_seal_unmapped_start(); @@ -2481,5 +2672,14 @@ int main(int argc, char **argv) test_seal_mmap_reuse_addr(false); test_seal_mmap_reuse_addr(true); =20 + test_seal_mremap_shrink_multiple_vmas(false); + test_seal_mremap_shrink_multiple_vmas(true); + test_seal_mremap_expand_multiple_vmas(false); + test_seal_mremap_expand_multiple_vmas(true); + test_seal_mremap_move_expand_multiple_vmas(false); + test_seal_mremap_move_expand_multiple_vmas(true); + test_seal_mremap_move_shrink_multiple_vmas(false); + test_seal_mremap_move_shrink_multiple_vmas(true); + ksft_finished(); } --=20 2.46.0.469.g59c65b2a67-goog