From nobody Fri Dec 19 07:19:02 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 88609188A27; Fri, 30 Aug 2024 10:31:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725013906; cv=none; b=Zc/leU3n2Q84w8IOy+LW3SnX/FmlocCZbZnpmqnmD7JMupa7Khptl6hE8ZEeKq+pfa4zH4kSTeezgbiNsReFnz/AS+2J9xf+u4aFzBpRa/Jn4+P3ydx+lK9UMBuloTh4Xf7wu1ce0ZGCxyVxFnAiCPTMMY+cOaTcPHhccGPOTyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725013906; c=relaxed/simple; bh=oIWhLUW9Fzm+X2SHRM8qbM4Uhw1DqeO8zaQG0zDMfS4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SQN6mIiZwvueiTxpU55F5w4Jdyb9WLD7PkYXJWrZCRMErm8GRoEmb0R1bTd4g3dpNOchSgiYjXwrMNVrtAynPwRNjcTOAorSN+9J85gA2vHPT0mQAB2y2KegmXp2wczeYtigKMJ23BetAgu0Yyj4H9AeeY3gw+XXAn9yf5JzKZ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30E681477; Fri, 30 Aug 2024 03:32:10 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A58563F762; Fri, 30 Aug 2024 03:31:41 -0700 (PDT) From: Levi Yun To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, james.clark@linaro.org, asmadeus@codewreck.org, yangjihong1@huawei.com Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Levi Yun Subject: [PATCH 1/2] perf stat: Close cork_fd when create_perf_stat_counter() failed Date: Fri, 30 Aug 2024 11:31:15 +0100 Message-Id: <20240830103116.2117896-2-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240830103116.2117896-1-yeoreum.yun@arm.com> References: <20240830103116.2117896-1-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When create_perf_stat_counter() failed, it doesn't close workload.cork_fd open in evlist__prepare_workload(). This could make too many open file error while __run_perf_stat() repeats. Introduce evlist__cancel_workload to close workload.cork_fd and wait workload.child_pid until exit to clear child process when create_perf_stat_counter() is failed with COUNTER_FATAL. Signed-off-by: Levi Yun --- tools/perf/builtin-stat.c | 4 ++++ tools/perf/util/evlist.c | 14 +++++++++++++- tools/perf/util/evlist.h | 1 + 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 661832756a24..954eb37ce7b8 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -763,6 +763,8 @@ static int __run_perf_stat(int argc, const char **argv,= int run_idx) =20 switch (stat_handle_error(counter)) { case COUNTER_FATAL: + if (forks) + evlist__cancel_workload(evsel_list); return -1; case COUNTER_RETRY: goto try_again; @@ -804,6 +806,8 @@ static int __run_perf_stat(int argc, const char **argv,= int run_idx) =20 switch (stat_handle_error(counter)) { case COUNTER_FATAL: + if (forks) + evlist__cancel_workload(evsel_list); return -1; case COUNTER_RETRY: goto try_again_reset; diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 3a719edafc7a..51a221679c92 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c @@ -46,6 +46,7 @@ #include #include #include +#include =20 #include #include @@ -1465,7 +1466,7 @@ int evlist__prepare_workload(struct evlist *evlist, s= truct target *target, const * For cancelling the workload without actually running it, * the parent will just close workload.cork_fd, without writing * anything, i.e. read will return zero and we just exit() - * here. + * here (See evlist__cancel_workload()). */ if (ret !=3D 1) { if (ret =3D=3D -1) @@ -1546,6 +1547,17 @@ int evlist__start_workload(struct evlist *evlist) return 0; } =20 +void evlist__cancel_workload(struct evlist *evlist) +{ + int status; + + if (evlist->workload.cork_fd > 0) { + close(evlist->workload.cork_fd); + evlist->workload.cork_fd =3D -1; + waitpid(evlist->workload.pid, &status, WNOHANG); + } +} + int evlist__parse_sample(struct evlist *evlist, union perf_event *event, s= truct perf_sample *sample) { struct evsel *evsel =3D evlist__event2evsel(evlist, event); diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h index cb91dc9117a2..12f929ffdf92 100644 --- a/tools/perf/util/evlist.h +++ b/tools/perf/util/evlist.h @@ -184,6 +184,7 @@ int evlist__prepare_workload(struct evlist *evlist, str= uct target *target, const char *argv[], bool pipe_output, void (*exec_error)(int signo, siginfo_t *info, void *ucontext)); int evlist__start_workload(struct evlist *evlist); +void evlist__cancel_workload(struct evlist *evlist); =20 struct option; =20 --=20 LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7} From nobody Fri Dec 19 07:19:02 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 10130188A27; Fri, 30 Aug 2024 10:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725013909; cv=none; b=BS2MRh2W20t5GXh7phuGShJZA9kc1iNVDJM2WeSZQtyvf5BBKQPP6WV7ZGKvuTitO0osbcHjCKU5ErnO3qSQFh4JP0P4d/CyNLFQTg6M0XJyzszYHKVSuKXYNcaonjrUBULJKkthkn5YdElkTIuUwDPgUMDlwcaKbxKd65p6KIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725013909; c=relaxed/simple; bh=8SD+wl0TVMXNGrfNXjbzyBYDvKcVCD6qD/wBmBGuR+8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SWGHH2tpBBfXhBkIH1sgBiCrylUqZmzkc/+rQ2LCYUg8MoNOg446lif7bq5dxbBPIoslA8FjJfMtSwGs/2i51TVzH1BHriTIQPdKSTVTDPjzw2QsOjJEBZ30JQFChQghSWfR2BdsYPBhl8ymIGZGTb0qzETv4jXdS7PrgWN9DUM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA09C1515; Fri, 30 Aug 2024 03:32:13 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 413AF3F762; Fri, 30 Aug 2024 03:31:45 -0700 (PDT) From: Levi Yun To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, james.clark@linaro.org, asmadeus@codewreck.org, yangjihong1@huawei.com Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Levi Yun Subject: [PATCH 2/2] perf stat: Stop repeating when ref_perf_stat() returns -1 Date: Fri, 30 Aug 2024 11:31:16 +0100 Message-Id: <20240830103116.2117896-3-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240830103116.2117896-1-yeoreum.yun@arm.com> References: <20240830103116.2117896-1-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Exit when run_perf_stat() returns an error to avoid continuously repeating the same error message. It's not expected that COUNTER_FATAL or internal errors are recoverable so there's no point in retrying. This fixes the following flood of error messages for permission issues, for example when perf_event_paranoid=3D=3D3: perf stat -r 1044 -- false Error: Access to performance monitoring and observability operations is limited. ... Error: Access to performance monitoring and observability operations is limited. ... (repeating for 1044 times). Signed-off-by: Levi Yun --- tools/perf/builtin-stat.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 954eb37ce7b8..18197ded88a7 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -2875,7 +2875,10 @@ int cmd_stat(int argc, const char **argv) evlist__reset_prev_raw_counts(evsel_list); =20 status =3D run_perf_stat(argc, argv, run_idx); - if (forever && status !=3D -1 && !interval) { + if (status =3D=3D -1) + break; + + if (forever && !interval) { print_counters(NULL, argc, argv); perf_stat__reset_stats(); } --=20 LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}