From nobody Mon Feb 9 01:34:34 2026 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BAE1481AB for ; Fri, 30 Aug 2024 06:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.190 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724999067; cv=none; b=CjyEoOYq0xfZ92YhEg2+HMrOZQ16WX0VmYLo913ExhOuFdUqgKyD2TH4BgXebAxz4GNDfZTyplb30d2g4wQ2cdtl8WKmaWjIgRkrBjfyBApjlTOY0LTsZh2BPB/7e36gCEIQBjIfw6obEFdNbT+k+Ec5kqUj8KrfAkeyXIgxRW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724999067; c=relaxed/simple; bh=gd+aO52l1rCow7tkh7szgx8hR94Y2MtKVz/B1/ntNRs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EHtUePW0xuGcxSFTYwdt6Q5/8U136C+aV7bB/jsNxeEQ295OrfSjYvBdOmSlqLtHWEiqEmPByZ+BiII5d0SeYguwCZEdvRqYb9zq1pbS8mNlSHzAQgmU6boZ6c29wOdftXdwSVEztZt0XNOHQ2uD0usRPTbgIp+lgQ5Tjr56Syc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Ww7KG1XSVz20n3V; Fri, 30 Aug 2024 14:19:30 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 8EECA1A016C; Fri, 30 Aug 2024 14:24:21 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 30 Aug 2024 14:24:21 +0800 From: Jinjie Ruan To: , , , , , CC: Subject: [PATCH -next v2 1/4] soc: ti: knav_dma: Simplify with scoped for each OF child loop Date: Fri, 30 Aug 2024 14:32:25 +0800 Message-ID: <20240830063228.3519385-2-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240830063228.3519385-1-ruanjinjie@huawei.com> References: <20240830063228.3519385-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" Use scoped for_each_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Signed-off-by: Jinjie Ruan --- v2: - Split into 2 patches. --- drivers/soc/ti/knav_dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index fb0746d8caad..15e41d3a5e22 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -706,7 +706,6 @@ static int knav_dma_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct device_node *node =3D pdev->dev.of_node; - struct device_node *child; int ret =3D 0; =20 if (!node) { @@ -732,10 +731,9 @@ static int knav_dma_probe(struct platform_device *pdev) } =20 /* Initialise all packet dmas */ - for_each_child_of_node(node, child) { + for_each_child_of_node_scoped(node, child) { ret =3D dma_init(node, child); if (ret) { - of_node_put(child); dev_err(&pdev->dev, "init failed with %d\n", ret); break; } --=20 2.34.1 From nobody Mon Feb 9 01:34:34 2026 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0256214882D for ; Fri, 30 Aug 2024 06:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.189 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724999069; cv=none; b=HabAqbli5GSihmo8w0pQVF0ai3W/Rj/0gP7SsEUpsIIITdWaZEeIxzVetiv7APx45f7ngVomQ19uvL/13vS9GI6DKLZo4RcHN4kGkerj+jbQJhEEKYINL0nPZUGV6SF3vd9vkFavubWu3DHzX8930f4WQewPgYVfBymvMD0FK+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724999069; c=relaxed/simple; bh=qDkA+oquu4u+k7V1LPRaq8PiyWtihhyUduWC7161rqo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SfBzmPD2Obv6VwbuQGd8kHVXkqLNAgPfrroQ8Sy4sPFNhEZNDKq/OJomruGs9p2ZIWHZ2A5KnjRRqKKagZX9d2EGbSPT71nTEa9r8cd2QBdqZ5yNOFclamlfDB83yr302j+g/CblkN4mjpW/KcT2AcT/F4bVepBe6vZrl2grWsM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4Ww7KG0yLhzQrBd; Fri, 30 Aug 2024 14:19:30 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id E2B35140360; Fri, 30 Aug 2024 14:24:21 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 30 Aug 2024 14:24:21 +0800 From: Jinjie Ruan To: , , , , , CC: Subject: [PATCH -next v2 2/4] soc: ti: knav_dma: Use dev_err_probe() to simplfy code Date: Fri, 30 Aug 2024 14:32:26 +0800 Message-ID: <20240830063228.3519385-3-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240830063228.3519385-1-ruanjinjie@huawei.com> References: <20240830063228.3519385-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: Jinjie Ruan --- v2: - Split into 2 patches. --- drivers/soc/ti/knav_dma.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c index 15e41d3a5e22..eeec422a46f0 100644 --- a/drivers/soc/ti/knav_dma.c +++ b/drivers/soc/ti/knav_dma.c @@ -708,17 +708,13 @@ static int knav_dma_probe(struct platform_device *pde= v) struct device_node *node =3D pdev->dev.of_node; int ret =3D 0; =20 - if (!node) { - dev_err(&pdev->dev, "could not find device info\n"); - return -EINVAL; - } + if (!node) + return dev_err_probe(&pdev->dev, -EINVAL, "could not find device info\n"= ); =20 kdev =3D devm_kzalloc(dev, sizeof(struct knav_dma_pool_device), GFP_KERNEL); - if (!kdev) { - dev_err(dev, "could not allocate driver mem\n"); - return -ENOMEM; - } + if (!kdev) + return dev_err_probe(dev, -ENOMEM, "could not allocate driver mem\n"); =20 kdev->dev =3D dev; INIT_LIST_HEAD(&kdev->list); --=20 2.34.1 From nobody Mon Feb 9 01:34:35 2026 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BB1D482DD for ; Fri, 30 Aug 2024 06:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.190 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724999067; cv=none; b=OB2VzhJk8xZnHPU8qqwqrhl0YyC5KKXROcLw4OxUKADAtyI9zOGEZzfBb6ko1hi1YC3ny8zqWkjVHLN4NkTdTgr/Jmc4w4cNbsEaplQnrYRQ/9T51ehLc90pV0K7CIK0cnmgJ+Gio8FnMudbVxGkBNc8uDacPsLwVHFGMYdQRvw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724999067; c=relaxed/simple; bh=49IQeLOULWHmDKOrDfXIlbTQuX/7ep0g4VwWqiW3INs=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=V74HzjPcDGbIxKFsIGoC55QaMec2Hys9abXOEHJnpOn7v4/zLg9IuPwANU6tgo/5zl3JqAOTFR7lVEtkq9THnwYKJGNxQ3CdFeYVwyWugPztJuiWUrl3Q3HbkvUxWQqsU8TFeIIBWRXRfonCggCTfuz9e1lhvWuvhTNXST+E0OE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.190 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Ww7KG6ScQz20llM; Fri, 30 Aug 2024 14:19:30 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 42F0A140136; Fri, 30 Aug 2024 14:24:22 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 30 Aug 2024 14:24:21 +0800 From: Jinjie Ruan To: , , , , , CC: Subject: [PATCH -next v2 3/4] soc: ti: knav_qmss_queue: Simplify with scoped for each OF child loop Date: Fri, 30 Aug 2024 14:32:27 +0800 Message-ID: <20240830063228.3519385-4-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240830063228.3519385-1-ruanjinjie@huawei.com> References: <20240830063228.3519385-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" Use scoped for_each_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Signed-off-by: Jinjie Ruan --- v2: - Split into 2 patches. - Rebased the newest next. - Update the commit message. --- drivers/soc/ti/knav_qmss_queue.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index 6c98738e548a..02983f8ba1b6 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -1082,7 +1082,6 @@ static int knav_queue_setup_regions(struct knav_devic= e *kdev, struct device_node *regions __free(device_node) =3D of_get_child_by_name(node, "descriptor-regions"); struct knav_region *region; - struct device_node *child; u32 temp[2]; int ret; =20 @@ -1090,10 +1089,9 @@ static int knav_queue_setup_regions(struct knav_devi= ce *kdev, return dev_err_probe(dev, -ENODEV, "descriptor-regions not specified\n"); =20 - for_each_child_of_node(regions, child) { + for_each_child_of_node_scoped(regions, child) { region =3D devm_kzalloc(dev, sizeof(*region), GFP_KERNEL); if (!region) { - of_node_put(child); dev_err(dev, "out of memory allocating region\n"); return -ENOMEM; } @@ -1400,7 +1398,6 @@ static int knav_queue_init_qmgrs(struct knav_device *= kdev, struct device_node *qmgrs __free(device_node) =3D of_get_child_by_name(node, "qmgrs"); struct knav_qmgr_info *qmgr; - struct device_node *child; u32 temp[2]; int ret; =20 @@ -1408,10 +1405,9 @@ static int knav_queue_init_qmgrs(struct knav_device = *kdev, return dev_err_probe(dev, -ENODEV, "queue manager info not specified\n"); =20 - for_each_child_of_node(qmgrs, child) { + for_each_child_of_node_scoped(qmgrs, child) { qmgr =3D devm_kzalloc(dev, sizeof(*qmgr), GFP_KERNEL); if (!qmgr) { - of_node_put(child); dev_err(dev, "out of memory allocating qmgr\n"); return -ENOMEM; } @@ -1506,12 +1502,10 @@ static int knav_queue_init_pdsps(struct knav_device= *kdev, { struct device *dev =3D kdev->dev; struct knav_pdsp_info *pdsp; - struct device_node *child; =20 - for_each_child_of_node(pdsps, child) { + for_each_child_of_node_scoped(pdsps, child) { pdsp =3D devm_kzalloc(dev, sizeof(*pdsp), GFP_KERNEL); if (!pdsp) { - of_node_put(child); dev_err(dev, "out of memory allocating pdsp\n"); return -ENOMEM; } --=20 2.34.1 From nobody Mon Feb 9 01:34:35 2026 Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65BE344C7C for ; Fri, 30 Aug 2024 06:24:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.191 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724999069; cv=none; b=N3kIfJkkWAM2kPwQ11BA7EAinTYcBbEPyxHc64qIOWpDY0JjqfALl5vTMqb9lq3JZOwVF5DjJ1aHacMSJbGHu8IAF8vFjQTY5JnYXZ3SE8PsqPglS1fVCAcqmcDrXNXSmang4SSZStjv5jAhYhpWoOcgqIZc/yLna4R7ZBVCNJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724999069; c=relaxed/simple; bh=17UmYdRDdA0n2Xm8qnAv+pEzia4GZ2vXwqeWsE3MvXw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=heJLeJm6QhoA2gIEsFmoUJQzbqfcAviRH41/g5lyif5RvJS2Hcd/j81Vjzf5V3qA5rfbL4or/9nHZYmaLCrDbApzqR6gvI4/GRHqDPu2HBihsqX7wNznu/ZFeIlH57WNLjJf9GRg0Ndb1DOWen1Msct3YE1eybLb9Ij3pXfGtXE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.191 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Ww7Qd1Hfrz1j7PT; Fri, 30 Aug 2024 14:24:09 +0800 (CST) Received: from kwepemh500013.china.huawei.com (unknown [7.202.181.146]) by mail.maildlp.com (Postfix) with ESMTPS id 9EA3F140136; Fri, 30 Aug 2024 14:24:22 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemh500013.china.huawei.com (7.202.181.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 30 Aug 2024 14:24:22 +0800 From: Jinjie Ruan To: , , , , , CC: Subject: [PATCH -next v2 4/4] soc: ti: knav_qmss_queue: Simplify with dev_err_probe() Date: Fri, 30 Aug 2024 14:32:28 +0800 Message-ID: <20240830063228.3519385-5-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240830063228.3519385-1-ruanjinjie@huawei.com> References: <20240830063228.3519385-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemh500013.china.huawei.com (7.202.181.146) Content-Type: text/plain; charset="utf-8" Use the dev_err_probe() helper to simplify error handling during probe. Signed-off-by: Jinjie Ruan --- v2: - Split into 2 patches. - Rebased the newest next. - Update the commit message. --- drivers/soc/ti/knav_qmss_queue.c | 33 +++++++++++--------------------- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_qu= eue.c index 02983f8ba1b6..d583a86028af 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -1091,10 +1091,8 @@ static int knav_queue_setup_regions(struct knav_devi= ce *kdev, =20 for_each_child_of_node_scoped(regions, child) { region =3D devm_kzalloc(dev, sizeof(*region), GFP_KERNEL); - if (!region) { - dev_err(dev, "out of memory allocating region\n"); - return -ENOMEM; - } + if (!region) + return dev_err_probe(dev, -ENOMEM, "out of memory allocating region\n"); =20 region->name =3D knav_queue_find_name(child); of_property_read_u32(child, "id", ®ion->id); @@ -1407,10 +1405,8 @@ static int knav_queue_init_qmgrs(struct knav_device = *kdev, =20 for_each_child_of_node_scoped(qmgrs, child) { qmgr =3D devm_kzalloc(dev, sizeof(*qmgr), GFP_KERNEL); - if (!qmgr) { - dev_err(dev, "out of memory allocating qmgr\n"); - return -ENOMEM; - } + if (!qmgr) + return dev_err_probe(dev, -ENOMEM, "out of memory allocating qmgr\n"); =20 ret =3D of_property_read_u32_array(child, "managed-queues", temp, 2); @@ -1505,10 +1501,8 @@ static int knav_queue_init_pdsps(struct knav_device = *kdev, =20 for_each_child_of_node_scoped(pdsps, child) { pdsp =3D devm_kzalloc(dev, sizeof(*pdsp), GFP_KERNEL); - if (!pdsp) { - dev_err(dev, "out of memory allocating pdsp\n"); - return -ENOMEM; - } + if (!pdsp) + return dev_err_probe(dev, -ENOMEM, "out of memory allocating pdsp\n"); pdsp->name =3D knav_queue_find_name(child); pdsp->iram =3D knav_queue_map_reg(kdev, child, @@ -1784,16 +1778,12 @@ static int knav_queue_probe(struct platform_device = *pdev) u32 temp[2]; int ret; =20 - if (!node) { - dev_err(dev, "device tree info unavailable\n"); - return -ENODEV; - } + if (!node) + return dev_err_probe(dev, -ENODEV, "device tree info unavailable\n"); =20 kdev =3D devm_kzalloc(dev, sizeof(struct knav_device), GFP_KERNEL); - if (!kdev) { - dev_err(dev, "memory allocation failed\n"); - return -ENOMEM; - } + if (!kdev) + return dev_err_probe(dev, -ENOMEM, "memory allocation failed\n"); =20 if (device_get_match_data(dev)) kdev->version =3D QMSS_66AK2G; @@ -1810,8 +1800,7 @@ static int knav_queue_probe(struct platform_device *p= dev) ret =3D pm_runtime_resume_and_get(&pdev->dev); if (ret < 0) { pm_runtime_disable(&pdev->dev); - dev_err(dev, "Failed to enable QMSS\n"); - return ret; + return dev_err_probe(dev, ret, "Failed to enable QMSS\n"); } =20 if (of_property_read_u32_array(node, "queue-range", temp, 2)) { --=20 2.34.1