From nobody Sat Nov 9 17:05:42 2024 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75B4C1B86F8; Thu, 29 Aug 2024 19:41:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724960507; cv=none; b=TJ2ECqxujVYfrGuKn8Hp0Ws8E9HF+p5KniftmZ0iA06u0NCH1DVCcK7P7jKrCtFyz6zKgCuxuDHI5QHbHeact0j0IlSXhQ0aDYLpp4tWqzyFqTosBCYrgFMXc6AQ14ojXMa9lifxUvJ8LBwlcb0Xf1h7DzS5ykqLAhFV83BUUSA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724960507; c=relaxed/simple; bh=LMgZJtpp5IqFSVGY70RFNYLPMjCyW67R9ny/MJmsINI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=l1WNIgkIgXP8JRfTWj3v2cSvLRwTF7tlcw3j+jXjmHE2nwJdbId3Q8y5AbNPKTTdaxmfXwOPlnRGdvKCKbSl5T6o3eV9dJqAMkyQK5mDApgKdaW5g7GKSgKjPrDd+W2gA+LqYAardy6z7aAe1cokmNdIrC8YRRfjPYGB6lpWdEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=dcmr0sSb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="dcmr0sSb" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47THOvgg008033; Thu, 29 Aug 2024 19:41:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /UGrmEfPImPz4cy4goGqoN4O1dz0tLQnPRcjZrMRqt0=; b=dcmr0sSbPLGALv+y Q7ZW+OGR/Skw+BshSybjvVE8pZm9SNjXGnq45g/ZKmgkNA+JcJkmUs8rv5mesMy4 mhNmNatQmA46fF6KtxUDt7ZZS0Sn/3zkWn/FvUWicXqOYD4EJaig3JbQrtYvLBKb fyU7qr43z6sS7RwZ/FfatBiMGF6GNo1qNHiuTPl8uC11X+f1gnN5ImLJgtlsXsKn HQtWAHV2vYS1jpzba0CJ67zcjvcjM4dZ6CMPY4RhB6ANixvWWgGArIsIeS2vgRYo iuucftr148Qo0JDjYnVdNqOB2o8br9I2LsXIPFpCqKg1NRBmxY42LHtP1tE+LhhP ahmR6g== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 419pv0egw6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Aug 2024 19:41:27 +0000 (GMT) Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 47TJfQOH019292 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Aug 2024 19:41:26 GMT Received: from hu-wcheng-lv.qualcomm.com (10.49.16.6) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 29 Aug 2024 12:41:25 -0700 From: Wesley Cheng To: , , , , , , , , , , , , , CC: , , , , , , , , Wesley Cheng Subject: [PATCH v26 06/33] usb: host: xhci-mem: Allow for interrupter clients to choose specific index Date: Thu, 29 Aug 2024 12:40:38 -0700 Message-ID: <20240829194105.1504814-7-quic_wcheng@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240829194105.1504814-1-quic_wcheng@quicinc.com> References: <20240829194105.1504814-1-quic_wcheng@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: SJ1RvoQU5MRu4l6r7TxBPERQ_WRG9qHr X-Proofpoint-ORIG-GUID: SJ1RvoQU5MRu4l6r7TxBPERQ_WRG9qHr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-29_06,2024-08-29_02,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 mlxlogscore=785 mlxscore=0 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408290139 Content-Type: text/plain; charset="utf-8" Some clients may operate only on a specific XHCI interrupter instance. Allow for the associated class driver to request for the interrupter that it requires. Signed-off-by: Wesley Cheng --- drivers/usb/host/xhci-mem.c | 25 +++++++++++++++---------- drivers/usb/host/xhci-sideband.c | 5 +++-- drivers/usb/host/xhci.h | 2 +- include/linux/usb/xhci-sideband.h | 2 +- 4 files changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c index 651b42ac6296..c034e630eb98 100644 --- a/drivers/usb/host/xhci-mem.c +++ b/drivers/usb/host/xhci-mem.c @@ -2340,14 +2340,15 @@ xhci_add_interrupter(struct xhci_hcd *xhci, struct = xhci_interrupter *ir, =20 struct xhci_interrupter * xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs, - u32 imod_interval) + u32 imod_interval, unsigned int intr_num) { struct xhci_hcd *xhci =3D hcd_to_xhci(hcd); struct xhci_interrupter *ir; unsigned int i; int err =3D -ENOSPC; =20 - if (!xhci->interrupters || xhci->max_interrupters <=3D 1) + if (!xhci->interrupters || xhci->max_interrupters <=3D 1 || + intr_num >=3D xhci->max_interrupters) return NULL; =20 ir =3D xhci_alloc_interrupter(xhci, segs, GFP_KERNEL); @@ -2355,15 +2356,18 @@ xhci_create_secondary_interrupter(struct usb_hcd *h= cd, unsigned int segs, return NULL; =20 spin_lock_irq(&xhci->lock); - - /* Find available secondary interrupter, interrupter 0 is reserved for pr= imary */ - for (i =3D 1; i < xhci->max_interrupters; i++) { - if (xhci->interrupters[i] =3D=3D NULL) { - err =3D xhci_add_interrupter(xhci, ir, i); - break; + if (!intr_num) { + /* Find available secondary interrupter, interrupter 0 is reserved for p= rimary */ + for (i =3D 1; i < xhci->max_interrupters; i++) { + if (!xhci->interrupters[i]) { + err =3D xhci_add_interrupter(xhci, ir, i); + break; + } } + } else { + if (!xhci->interrupters[intr_num]) + err =3D xhci_add_interrupter(xhci, ir, intr_num); } - spin_unlock_irq(&xhci->lock); =20 if (err) { @@ -2374,8 +2378,9 @@ xhci_create_secondary_interrupter(struct usb_hcd *hcd= , unsigned int segs, } =20 xhci_set_interrupter_moderation(ir, imod_interval); + xhci_dbg(xhci, "Add secondary interrupter %d, max interrupters %d\n", - i, xhci->max_interrupters); + ir->intr_num, xhci->max_interrupters); =20 return ir; } diff --git a/drivers/usb/host/xhci-sideband.c b/drivers/usb/host/xhci-sideb= and.c index 324e1c45378a..c488d6a6ba1b 100644 --- a/drivers/usb/host/xhci-sideband.c +++ b/drivers/usb/host/xhci-sideband.c @@ -259,7 +259,7 @@ EXPORT_SYMBOL_GPL(xhci_sideband_get_event_buffer); */ int xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg, - bool ip_autoclear, u32 imod_interval) + bool ip_autoclear, u32 imod_interval, int intr_num) { int ret =3D 0; =20 @@ -273,7 +273,8 @@ xhci_sideband_create_interrupter(struct xhci_sideband *= sb, int num_seg, } =20 sb->ir =3D xhci_create_secondary_interrupter(xhci_to_hcd(sb->xhci), - num_seg, imod_interval); + num_seg, imod_interval, + intr_num); if (!sb->ir) { ret =3D -ENOMEM; goto out; diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h index e37d27190e3c..b4b411d63694 100644 --- a/drivers/usb/host/xhci.h +++ b/drivers/usb/host/xhci.h @@ -1833,7 +1833,7 @@ void xhci_free_container_ctx(struct xhci_hcd *xhci, struct xhci_container_ctx *ctx); struct xhci_interrupter * xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs, - u32 imod_interval); + u32 imod_interval, unsigned int intr_num); void xhci_remove_secondary_interrupter(struct usb_hcd *hcd, struct xhci_interrupter *ir); void xhci_skip_sec_intr_events(struct xhci_hcd *xhci, diff --git a/include/linux/usb/xhci-sideband.h b/include/linux/usb/xhci-sid= eband.h index bc5b56a77e37..f0223c5535e0 100644 --- a/include/linux/usb/xhci-sideband.h +++ b/include/linux/usb/xhci-sideband.h @@ -59,7 +59,7 @@ xhci_sideband_get_event_buffer(struct xhci_sideband *sb); =20 int xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg, - bool ip_autoclear, u32 imod_interval); + bool ip_autoclear, u32 imod_interval, int intr_num); =20 void xhci_sideband_remove_interrupter(struct xhci_sideband *sb);