From nobody Wed Dec 17 08:51:18 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D3A21B4C4C for ; Thu, 29 Aug 2024 14:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724941145; cv=none; b=bEiw3aMg6wdWdab7RLw5LlM6fTUFiLzgPo6VTMXvS4l0R7Rj5YpJq/wQf2LfHQHCEsmiz0O3iJMRXnSokr1Yt4ROzNaLcFG/xolWirb/FXNnkI67DDZ9qlB/YQqP0xzG+fAXzdPynQg5znD4LebGiOey3MBhxZtBKSGIQazgRu0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724941145; c=relaxed/simple; bh=JMbg4eMibkjbCBRT/iJAl8N9RNBguY/qcuyAy9Bi6uc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l1k2ViXlp9KRF1pWG8ZHKB7EiKNqRyB+obH1DWcjuig308pfQjHUVbYjjjrEZcvWPPDilEkOht0LRs4IVFJSGvoGIDB3i53VVTSNVa0Doy+POvDQkwifn0ZIvIWiLNwGSUt+DsOxwjc8SkzCXBBKRuKu8hLkME5IuT9SCDy6fUQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WbMPG3mS; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WbMPG3mS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724941142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=326BlglD5Q8k45ugPSVf+4k9+mzBOEJ61jidx8Y66gA=; b=WbMPG3mSbnaBr5G7d0v2yVEwfrt+QubrTB7wRFBROph2zRpcezGnOw1rMg18IcSFwJbZVq B98tHaaMRUvGcSEvkb8Bl8BmV6yiTFaejIROU7TGuwnaM4rX8TTJ64ciTFoHVGalDIbpBq SFBY0nvLR8DjUg+6qh6zzpDl8CB92Aw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-e0Qo9rexNvSNiLnOlYFc1A-1; Thu, 29 Aug 2024 10:18:59 -0400 X-MC-Unique: e0Qo9rexNvSNiLnOlYFc1A-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37193ed09b2so1090947f8f.1 for ; Thu, 29 Aug 2024 07:18:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724941138; x=1725545938; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=326BlglD5Q8k45ugPSVf+4k9+mzBOEJ61jidx8Y66gA=; b=gJAQ7vUQwUSMjdhE3gkNfHjGaL8Vl8pI+Y9g+tP9efwB1in0SeeGP5qv1HblHMyAa0 mzZcHNntY46BOuhBFF8lHp028rBPtivkcnssUs3Y4gdW9/keeImWon9vgGtfaFcs2htN BfCWvBtGb4hAlZq6KZmTBq9xoP+9cbysXpeg4oKrNfGGIYQBX3ardO0gGWMXikTQyDzq Cd49xQ2hurRy7b0DDPHZM1j5P5uBTogUZoz99JJbhhbjLTrZp2vckLaIKQXjcMDtE4N3 6LimmmMb9Qfte4COCdy3bMSr0fpR7O2c67ZxcW6NHieBgm9vahFk6WfwigFIVHV4kirs UlGQ== X-Forwarded-Encrypted: i=1; AJvYcCW0DNMYCmnETSPoUsKzbHNmuxwGQiCkYYJM4+HWvMDgmdbxFFlDG8+FGgZXnyQM9EiTDJmKkz/MtI4HtQg=@vger.kernel.org X-Gm-Message-State: AOJu0YzmzGtcOKe3uHsw1Q2KgFOglKtjkRWzPkDMAGFYFMLZEll1C+4j qg7QfGXc2AFzNWvOEoS/FyjseQ5wAFGPvXssrDnL+aioRJCMIhnVZygjQRk0rVHDtCTQhY6Uyw3 jVlhnztW7+GwUUDbrQHsn+kq4WvC8yOAG960DNTGaqhBDPBPTiSduT1Qhse+SFw== X-Received: by 2002:a5d:6588:0:b0:367:8418:fde4 with SMTP id ffacd0b85a97d-3749fe45f69mr1407085f8f.7.1724941138019; Thu, 29 Aug 2024 07:18:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGf/Cvj3uFdDafG6t/JWOmnytGzmW7NR6oQDE7fLIyJIivUhu4hLbo/UyEzITWoKFSXYk+WIQ== X-Received: by 2002:a5d:6588:0:b0:367:8418:fde4 with SMTP id ffacd0b85a97d-3749fe45f69mr1407017f8f.7.1724941137555; Thu, 29 Aug 2024 07:18:57 -0700 (PDT) Received: from eisenberg.muc.redhat.com (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ba63abebdsm52670425e9.27.2024.08.29.07.18.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 07:18:57 -0700 (PDT) From: Philipp Stanner To: Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Helgaas , Alvaro Karsz , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Richard Cochran , Damien Le Moal , Hannes Reinecke , John Garry , Philipp Stanner Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev, stable@vger.kernel.org, Christophe JAILLET Subject: [PATCH v5 6/7] vdpa: solidrun: Fix UB bug with devres Date: Thu, 29 Aug 2024 16:16:25 +0200 Message-ID: <20240829141844.39064-7-pstanner@redhat.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240829141844.39064-1-pstanner@redhat.com> References: <20240829141844.39064-1-pstanner@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In psnet_open_pf_bar() and snet_open_vf_bar() a string later passed to pcim_iomap_regions() is placed on the stack. Neither pcim_iomap_regions() nor the functions it calls copy that string. Should the string later ever be used, this, consequently, causes undefined behavior since the stack frame will by then have disappeared. Fix the bug by allocating the strings on the heap through devm_kasprintf(). Cc: stable@vger.kernel.org # v6.3 Fixes: 51a8f9d7f587 ("virtio: vdpa: new SolidNET DPU driver.") Reported-by: Christophe JAILLET Closes: https://lore.kernel.org/all/74e9109a-ac59-49e2-9b1d-d825c9c9f891@wa= nadoo.fr/ Suggested-by: Andy Shevchenko Signed-off-by: Philipp Stanner --- drivers/vdpa/solidrun/snet_main.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/solidrun/snet_main.c b/drivers/vdpa/solidrun/snet= _main.c index 99428a04068d..c8b74980dbd1 100644 --- a/drivers/vdpa/solidrun/snet_main.c +++ b/drivers/vdpa/solidrun/snet_main.c @@ -555,7 +555,7 @@ static const struct vdpa_config_ops snet_config_ops =3D= { =20 static int psnet_open_pf_bar(struct pci_dev *pdev, struct psnet *psnet) { - char name[50]; + char *name; int ret, i, mask =3D 0; /* We don't know which BAR will be used to communicate.. * We will map every bar with len > 0. @@ -573,7 +573,10 @@ static int psnet_open_pf_bar(struct pci_dev *pdev, str= uct psnet *psnet) return -ENODEV; } =20 - snprintf(name, sizeof(name), "psnet[%s]-bars", pci_name(pdev)); + name =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, "psnet[%s]-bars", pci_nam= e(pdev)); + if (!name) + return -ENOMEM; + ret =3D pcim_iomap_regions(pdev, mask, name); if (ret) { SNET_ERR(pdev, "Failed to request and map PCI BARs\n"); @@ -590,10 +593,13 @@ static int psnet_open_pf_bar(struct pci_dev *pdev, st= ruct psnet *psnet) =20 static int snet_open_vf_bar(struct pci_dev *pdev, struct snet *snet) { - char name[50]; + char *name; int ret; =20 - snprintf(name, sizeof(name), "snet[%s]-bar", pci_name(pdev)); + name =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, "snet[%s]-bars", pci_name= (pdev)); + if (!name) + return -ENOMEM; + /* Request and map BAR */ ret =3D pcim_iomap_regions(pdev, BIT(snet->psnet->cfg.vf_bar), name); if (ret) { --=20 2.46.0