From nobody Thu Dec 18 23:41:02 2025 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5073D4D8C8 for ; Thu, 29 Aug 2024 03:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724902058; cv=none; b=Lt7zcnTjAyGUI9LRgYH1Vn1nHBgrPRrSOfDboK9r/J7MA+lzuu2viNY0WQKaQs00yMoNzES/fP43EJoxcWBr+UIHP2YhiqNPNO5uzIw8tHlLawusHAy9vTRxmj0C9dK4Ut9ZAXreTU64rWuKhGQ3cnkiJBCsZTstd3lmrr+o8Ao= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724902058; c=relaxed/simple; bh=J3x15FROvIGfErrr95eUsP3T0r5kfYqV9KPmq4IaenA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ITShf+aZfoEUVOxdbW3GCJELQyAwm/pmiN9fBXl/3l23p01AofSLpVEEaRatIX4nAlxXaim9CYXD+SB8F1UJ0rbfplinpLCt0tM6clqnS+yArF2Lwq16Olp71bTApD9jjBd6V99VPqh2fVRA9Nu2JAih1wxNRFBELAfTAAeCgns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dHeID1yK; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dHeID1yK" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2d3d7a1e45fso128087a91.3 for ; Wed, 28 Aug 2024 20:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724902056; x=1725506856; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yd0jWR3VXJxuNlLXtqGwbme+uoTJ0s2xTOcRj568YVg=; b=dHeID1yK84xNRghhYAvKzvs17IX+yY35AzHDfdyi5T6PdqhsFgn52DRfZp3G2VKg8C 7bMVNhNFkOT37S6pmYfUg2AMsQKK8BzOW1y0SUYKPCpngxo75mtJZ6wQzyfFE8mPBgJD yyxuPz/5eBcbwHzNgp00F2BXIJ89vxhuNWiEUkuF6w3+UH/hj36UOcHkz3nVNX0vUKP3 SMd4MAgjdAC6KE/11vw7Q5jlpMNYOvdSxXEfrkn/r6nznQwSu5f5Ym3SVbo7Zo2VJMfZ jdWprcPk/+yEsZQaGMJjFs7FdkIA75qHD5e21dbbb88MySgn/GqCYqHz19wcibaIa1QK IeOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724902056; x=1725506856; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yd0jWR3VXJxuNlLXtqGwbme+uoTJ0s2xTOcRj568YVg=; b=CecUS9E8FjXQsWQUYc7bRRcttQGBw3Vp7x5JTh1jOJfAmfNi93+fh3id+kXDeUGdLt 0RdrersSzmLli8oMeDGRIkzj7EBq9/8cWDuGauX/RdOD8Y7Dc/ruoVnqzr4npzEkB2RF mAauRDIEOI+TRcVnE+jIpQxPsX2k9PCQ12Alw79HvN7azEwyxMOMIC7AXTinuglXpnwF oruxzc5gtMe4qNjZ/dx/4ypjkUMHll/tfwPdF48uWrbk5kePS9SKurLDe6TgvxW2kznx 3f42pNIm+P+Vi7eb2gQO1nBlvbo493trc8koCm28MZGn1jsxPrFCT9tG42lt1n1KDIIa P6pA== X-Forwarded-Encrypted: i=1; AJvYcCXelMhSkOqqUohGA7XRH+kTPXopnh2zcyjwj0AvExFWX4UkfAJSu1MGEPeN9vSmXrq2DBIRT81IzUejFjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyOParYDc6pWsoKL4J1vjkuRTm8KnFcopRGN11TjC4VkWYUKRFS ALAti/5IIrJehItI1UlUYnBLwNYUZwJb9cqz4npErDjw3H96JcaM X-Google-Smtp-Source: AGHT+IG9vzMS34n3yQrqIZe1bl+5NJqDWVg/BsUpiS9mu0yGMFa3eQDSdfkFbu1or+R3IOgWVhw3KA== X-Received: by 2002:a17:90b:2652:b0:2ca:2c4b:476 with SMTP id 98e67ed59e1d1-2d85619d40bmr1665311a91.10.1724902056294; Wed, 28 Aug 2024 20:27:36 -0700 (PDT) Received: from twhmp6px (mxsmtp211.mxic.com.tw. [211.75.127.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d8445d8afdsm2810877a91.2.2024.08.28.20.27.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 20:27:35 -0700 (PDT) Received: from hqs-appsw-a2o.mp600.macronix.com (linux-patcher [172.17.236.67]) by twhmp6px (Postfix) with ESMTPS id B3207806A6; Thu, 29 Aug 2024 11:36:11 +0800 (CST) From: Cheng Ming Lin To: miquel.raynal@bootlin.com, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Cc: richard@nod.at, alvinzhou@mxic.com.tw, leoyu@mxic.com.tw, Cheng Ming Lin Subject: [PATCH v4 1/2] mtd: spinand: Add support for the flag Date: Thu, 29 Aug 2024 11:25:16 +0800 Message-Id: <20240829032517.1517198-2-linchengming884@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240829032517.1517198-1-linchengming884@gmail.com> References: <20240829032517.1517198-1-linchengming884@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Cheng Ming Lin Add two flags for inserting the Plane Select bit into the column address during the write_to_cache and the read_from_cache operation. Add the SPINAND_HAS_PP_PLANE_SELECT_BIT flag for serial NAND flash that require inserting the Plane Select bit into the column address during the write_to_cache operation. Add the SPINAND_HAS_READ_PLANE_SELECT_BIT flag for serial NAND flash that require inserting the Plane Select bit into the column address during the read_from_cache operation. Signed-off-by: Cheng Ming Lin --- drivers/mtd/nand/spi/core.c | 6 ++++++ include/linux/mtd/spinand.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index e0b6715e5dfe..49f2d66c3a9c 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -386,6 +386,9 @@ static int spinand_read_from_cache_op(struct spinand_de= vice *spinand, else rdesc =3D spinand->dirmaps[req->pos.plane].rdesc_ecc; =20 + if (spinand->flags & SPINAND_HAS_READ_PLANE_SELECT_BIT) + column |=3D req->pos.plane << fls(nanddev_page_size(nand)); + while (nbytes) { ret =3D spi_mem_dirmap_read(rdesc, column, nbytes, buf); if (ret < 0) @@ -460,6 +463,9 @@ static int spinand_write_to_cache_op(struct spinand_dev= ice *spinand, else wdesc =3D spinand->dirmaps[req->pos.plane].wdesc_ecc; =20 + if (spinand->flags & SPINAND_HAS_PP_PLANE_SELECT_BIT) + column |=3D req->pos.plane << fls(nanddev_page_size(nand)); + while (nbytes) { ret =3D spi_mem_dirmap_write(wdesc, column, nbytes, buf); if (ret < 0) diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h index 5c19ead60499..cec451e7c71c 100644 --- a/include/linux/mtd/spinand.h +++ b/include/linux/mtd/spinand.h @@ -312,6 +312,8 @@ struct spinand_ecc_info { =20 #define SPINAND_HAS_QE_BIT BIT(0) #define SPINAND_HAS_CR_FEAT_BIT BIT(1) +#define SPINAND_HAS_PP_PLANE_SELECT_BIT BIT(2) +#define SPINAND_HAS_READ_PLANE_SELECT_BIT BIT(3) =20 /** * struct spinand_ondie_ecc_conf - private SPI-NAND on-die ECC engine stru= cture --=20 2.25.1 From nobody Thu Dec 18 23:41:02 2025 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A45A84F20C for ; Thu, 29 Aug 2024 03:27:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724902059; cv=none; b=hKC1fJO3dcdaDJS2l8u4PAzSVOXrD38iUg2Z7vXz3ekgU1m4k8sbKIMmeiZb9DPBah/4UGdG1lLae/5ZQNFMXGOhfAI3oaQJMmZYTOItfEoqIDtrGvSghIGeSXQOz8VOVXQYyFsT6z2sMo3hQN7G4PhRZIdKo5r2feVpbSMz/38= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724902059; c=relaxed/simple; bh=sl+WUjX93oDz16xXdE4g23AatPaU3O7WYHJs7XBhCkU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lCpYm45Yl7XEtli97AP2GaCDmCNqwr2fXIc2eR8xQvqQcen5k8OW1LV+CDlKcMu9JTqoQZMwzK3LMVIJxCaqsCSejSq3rOggxSzfEPsznvqJCv+TXw91Ja05SpoHCJDUsQTQEGnUNaP18P2fxk4Mj/no/jBcyDqar4bgJ+SaOHo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lxTtmi4q; arc=none smtp.client-ip=209.85.161.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lxTtmi4q" Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-5df9dec9c0eso121378eaf.2 for ; Wed, 28 Aug 2024 20:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724902057; x=1725506857; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vhmAom+LVcmv0Mivl3IQDZRfWyPiO2Vvp66v1pNhYJY=; b=lxTtmi4qP7PPhvlwSZaNg5qFwy9uhmua7n36SIQepjOe1bbJHTWHh5IP4tOokefmdw gkS88GcDvnfZA6mFTgQFRinuleT7rruQSc7vFvnpE0DUYLR68W1OjRTwV+M+aTkBVdR1 F/ny32QMYVsOiMpCHj8X83RY/6VDLZpwjQvKK21bZJAHgwhHViARyOjRoxGZsMZiJRFX t9nh4MRf2w7ymy00Q5M5tbc7RjJ55SEfnda0FZKPqmg9HDxsKk6n6ddMf7sicHqTK7fZ sgMhmewxd3O346eBAfKHL5T+rqAyOmiOChoujQGwwLjq99U0SHX+KsT0rJLDxTbNKN2v 5B9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724902057; x=1725506857; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vhmAom+LVcmv0Mivl3IQDZRfWyPiO2Vvp66v1pNhYJY=; b=pgw5m3ljsMvGBVPnTzXOke/Lle6rop0HnkdQJTFLA2xJprQLD6HYjwSSAIp3FmyTQq 0qAtvdPTSUGule2LBpaZEbaHoWhaah3Y9MZSpgUQ2ILG2j8Oysg8d5wQ+aWqbG6Snpzn XXMz1GQHgTFVKn8buaCOHmCpP8on9KDcbDWjeq0a2m315i/1dT/oqRozyBcQnGeWiAkd x1E8KiaSHeFv7xKf7Qh48ijeooCuDjYMNB+SlcUUzGXX6i/eegGdo/dq23e82yzwSOwL bRKW4+tBZO6lHsaqYka3fox+RM+XrN2gmweTMpeGPgdG9sC5NUVwbxf2Vbj/OrO1gdCv DY9Q== X-Forwarded-Encrypted: i=1; AJvYcCVCW0ujP8mpgwSrJdQ3xLd+iPWZxlyvYUOb4FfTZr8oUd4QFN0IQnv3aSg/UWyvn4Og6rSsU+WMWOEvKms=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/0gMJphWDphhOEMppVSKtJhsn1S/7rcvfY2MUQ1c3lmwk4X6p tu4RYxxHrfixrNMKSpRvi4OZr6s0sPjWrHiMZ1ulYCfVBfhVA1GD X-Google-Smtp-Source: AGHT+IHIaBPww4NUweWCTqWg13olD2CoFRyn8srMULQxL28/S7iOsYX8yyzacHcoPFbRY9F8s4phJw== X-Received: by 2002:a05:6870:f153:b0:229:f022:ef83 with SMTP id 586e51a60fabf-2779035fabdmr1840332fac.43.1724902056599; Wed, 28 Aug 2024 20:27:36 -0700 (PDT) Received: from twhmp6px (mxsmtp211.mxic.com.tw. [211.75.127.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-715e569e34asm198107b3a.111.2024.08.28.20.27.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 20:27:36 -0700 (PDT) Received: from hqs-appsw-a2o.mp600.macronix.com (linux-patcher [172.17.236.67]) by twhmp6px (Postfix) with ESMTPS id 4B9E78070F; Thu, 29 Aug 2024 11:36:12 +0800 (CST) From: Cheng Ming Lin To: miquel.raynal@bootlin.com, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Cc: richard@nod.at, alvinzhou@mxic.com.tw, leoyu@mxic.com.tw, Cheng Ming Lin Subject: [PATCH v4 2/2] mtd: spinand: macronix: Use the flag in Macronix driver Date: Thu, 29 Aug 2024 11:25:17 +0800 Message-Id: <20240829032517.1517198-3-linchengming884@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240829032517.1517198-1-linchengming884@gmail.com> References: <20240829032517.1517198-1-linchengming884@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Cheng Ming Lin Macronix serial NAND flash with a two-plane structure requires insertion of the Plane Select bit into the column address during the write_to_cache operation. Additionally, for MX35{U,F}2G14AC and MX35LF2GE4AB, insertion of the Plane Select bit into the column address is required during the read_from_cache operation. Signed-off-by: Cheng Ming Lin --- drivers/mtd/nand/spi/macronix.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macroni= x.c index 3f9e9c572854..f17cd4a6f4d0 100644 --- a/drivers/mtd/nand/spi/macronix.c +++ b/drivers/mtd/nand/spi/macronix.c @@ -118,7 +118,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_INFO_OP_VARIANTS(&read_cache_variants, &write_cache_variants, &update_cache_variants), - SPINAND_HAS_QE_BIT, + SPINAND_HAS_QE_BIT | SPINAND_HAS_PP_PLANE_SELECT_BIT | + SPINAND_HAS_READ_PLANE_SELECT_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL)), SPINAND_INFO("MX35LF2GE4AD", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x26, 0x03), @@ -156,7 +157,7 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_INFO_OP_VARIANTS(&read_cache_variants, &write_cache_variants, &update_cache_variants), - SPINAND_HAS_QE_BIT, + SPINAND_HAS_QE_BIT | SPINAND_HAS_PP_PLANE_SELECT_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL)), SPINAND_INFO("MX35LF2G24AD-Z4I8", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x64, 0x03), @@ -174,7 +175,7 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_INFO_OP_VARIANTS(&read_cache_variants, &write_cache_variants, &update_cache_variants), - SPINAND_HAS_QE_BIT, + SPINAND_HAS_QE_BIT | SPINAND_HAS_PP_PLANE_SELECT_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL)), SPINAND_INFO("MX35LF4G24AD-Z4I8", SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x75, 0x03), @@ -213,7 +214,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_INFO_OP_VARIANTS(&read_cache_variants, &write_cache_variants, &update_cache_variants), - SPINAND_HAS_QE_BIT, + SPINAND_HAS_QE_BIT | SPINAND_HAS_PP_PLANE_SELECT_BIT | + SPINAND_HAS_READ_PLANE_SELECT_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, mx35lf1ge4ab_ecc_get_status)), SPINAND_INFO("MX35UF4G24AD", @@ -223,7 +225,7 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_INFO_OP_VARIANTS(&read_cache_variants, &write_cache_variants, &update_cache_variants), - SPINAND_HAS_QE_BIT, + SPINAND_HAS_QE_BIT | SPINAND_HAS_PP_PLANE_SELECT_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, mx35lf1ge4ab_ecc_get_status)), SPINAND_INFO("MX35UF4G24AD-Z4I8", @@ -253,7 +255,8 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_INFO_OP_VARIANTS(&read_cache_variants, &write_cache_variants, &update_cache_variants), - SPINAND_HAS_QE_BIT, + SPINAND_HAS_QE_BIT | SPINAND_HAS_PP_PLANE_SELECT_BIT | + SPINAND_HAS_READ_PLANE_SELECT_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, mx35lf1ge4ab_ecc_get_status)), SPINAND_INFO("MX35UF2G24AD", @@ -263,7 +266,7 @@ static const struct spinand_info macronix_spinand_table= [] =3D { SPINAND_INFO_OP_VARIANTS(&read_cache_variants, &write_cache_variants, &update_cache_variants), - SPINAND_HAS_QE_BIT, + SPINAND_HAS_QE_BIT | SPINAND_HAS_PP_PLANE_SELECT_BIT, SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, mx35lf1ge4ab_ecc_get_status)), SPINAND_INFO("MX35UF2G24AD-Z4I8", --=20 2.25.1