From nobody Fri Dec 19 16:19:01 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF27C74076 for ; Sun, 25 Aug 2024 18:31:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724610669; cv=none; b=T6py2WvN/bRAJTLXhkIv5KjRm46Jse4JdKP+F/FrRo6MM0vCkJ/TMOEyQ9OfZayJscqfMZLc2UPI8PUiecv74PbfCw9swacav+BJEHBcLQzRihcAcCxjeZ35PYtL/hba+O4e7rQpAOPZsrpLHSvWenFCY0mHw1FpP00KCYoXUkU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724610669; c=relaxed/simple; bh=331aaMLNzttvOKxi/Q/+mmK0DHaLczIPAXBxXCaSyKg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nlVHH5JcBrvnk4oLunamCd5zyTBIrrLtVeYFVKH3m9JTzr/idL0sRXsC3beSUGgimWgRR8HEzqPKuJTGN64t/DNNyR0nvNlwYWDyTj+fWIzucEo34RQm5urK7lRTFwsIfHXEqOzvwdGbrHqg3h5etIpvAqkESt1A1ICxedJxf0Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AQXZbDu6; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AQXZbDu6" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-42808a69a93so5569215e9.3 for ; Sun, 25 Aug 2024 11:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724610666; x=1725215466; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=w81sNAjj7bntfbvuI21+JZjX/UT6h5yzbhiBUj0PJK4=; b=AQXZbDu6qPxjvl00UDSvK30IFoQpjLXdD1GnzcWG+yxYYZmtuybHQic2wBx6sjFdO0 UWXv0JHfjo0KnDdzLSntWfIJOyKLWhP2F8H1u/bs4tdMHJ3FWOM0B6i8q36G1Rl0P/g8 DRdKdlFC33R2hIp9erRCKP7uzhgW208WJhBvkiuUd0NABD4hFuQNc6zcIjxpQk7d9oRE O7fbBZ3etSW5BCgfDG7hoCU4xGR5oNXT3v4i7mWGa8s0ycUd4W9H2zj3ka23g1riqbbR 0Ob81kYMF+DQ2C8+FyKlj5UHh7bBDGDMQnbNmuAHpyEy7kAye6KbDtkpBQIc4VezLTEh HmsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724610666; x=1725215466; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=w81sNAjj7bntfbvuI21+JZjX/UT6h5yzbhiBUj0PJK4=; b=bF70BOUGCrCj4epeOPd+epcRIR4ykxBntue6cbChHFbBY52OnBe27hk3DOCCeqvKcy hLseWjN2ZriqRq44UhKlX9+aP+yIPA84t6BhcXbnJOQtP867ylvUVp5QdSp9EqTIvrti QMDIu4AQEPxO30l2UhWyUwHAHSg5mYc9Rgim+UiO0sC3el8o6W1p7JfaTFrXeQ4+yyaV NTfTER1CThola7cOb6wkKdi315CHrZmEpgsd3aHRWLdbe80E1YWeBWC36zFvXGzkwDUA YepE5T6yzGbxDjm/iLW0oUYuuqxYWe+H6MIFNma6/VmAP5XrDmVCTMLz1N3xQ8Wq6EVV WT6w== X-Forwarded-Encrypted: i=1; AJvYcCWpVUjhHXpLipZGntn2HZerxVc7hWHnJo7yrwm8KTfSCz/l2H5LqP4/q7NleDRPMdBy9rvxytg+XvV1OMg=@vger.kernel.org X-Gm-Message-State: AOJu0YxogQvTSsdzAV25rACqvo3xszxUxU0adhV0kWsVLjk9/0AVPjVt t244cI/KeGXgMWqp6sQhzO8HvbbTYNb8C3myIHpLOrQcUZUjH+vEKZNZJWdWLfE= X-Google-Smtp-Source: AGHT+IFejGAuvYGwHP2LF9xrcXSzDcVV088gMtM4kujRFSeLgJtQZGFe1VXGPMy0SKXdemyo6Zw+ww== X-Received: by 2002:a5d:6481:0:b0:360:872b:7e03 with SMTP id ffacd0b85a97d-373117ba829mr3215443f8f.0.1724610665912; Sun, 25 Aug 2024 11:31:05 -0700 (PDT) Received: from krzk-bin.. ([178.197.222.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37308141dc3sm9034183f8f.41.2024.08.25.11.31.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 11:31:05 -0700 (PDT) From: Krzysztof Kozlowski To: Alexandre Belloni , Nicolas Ferre , Claudiu Beznea , Boris Brezillon , Johan Hovold , Arnd Bergmann , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , stable@vger.kernel.org Subject: [PATCH] rtc: at91sam9: fix OF node leak in probe() error path Date: Sun, 25 Aug 2024 20:31:03 +0200 Message-ID: <20240825183103.102904-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Driver is leaking an OF node reference obtained from of_parse_phandle_with_fixed_args(). Fixes: 43e112bb3dea ("rtc: at91sam9: make use of syscon/regmap to access GP= BR registers") Cc: Signed-off-by: Krzysztof Kozlowski --- drivers/rtc/rtc-at91sam9.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/rtc/rtc-at91sam9.c b/drivers/rtc/rtc-at91sam9.c index f93bee96e362..993c0878fb66 100644 --- a/drivers/rtc/rtc-at91sam9.c +++ b/drivers/rtc/rtc-at91sam9.c @@ -368,6 +368,7 @@ static int at91_rtc_probe(struct platform_device *pdev) return ret; =20 rtc->gpbr =3D syscon_node_to_regmap(args.np); + of_node_put(args.np); rtc->gpbr_offset =3D args.args[0]; if (IS_ERR(rtc->gpbr)) { dev_err(&pdev->dev, "failed to retrieve gpbr regmap, aborting.\n"); --=20 2.43.0