From nobody Fri Dec 19 18:11:54 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70FD915AADA for ; Sun, 25 Aug 2024 18:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724609158; cv=none; b=usnaUcd1Llfg7iqf7Qg4o/GtmuaT0hPnsH7czm8fYwdHjDDAs71lcLC3pquHXz+Fwue8IvmsaSpTXRYy8WletBuAL4eXByYiY/UgWLYVMzVTLzwEDyPbocGjV0xzy/VR6TibIbKA4ZtLBMwZbhJOAH69A3KyXq6HadSY6VNxMd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724609158; c=relaxed/simple; bh=djfTpzgwI9VayrirIxvL2d17DNLj3Y9kYYllCM4F/9I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BqHnyy1J58SUhhH3KQnWiBWVcuUE/jwq2/NidPgeRX64W3WEqr+vClBH6T/UdKNsSXGEvf6V9oeJtgq0yWYTUcc1DVkE+oKF2Agv9au9D0niswazbJhLUAoDV8YeZylvgEXWAV2Gaoyynb+xPYpHaFYFRkttlDBZIPaOX/b1iXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=L5IkOULt; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L5IkOULt" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4280772333eso5598855e9.0 for ; Sun, 25 Aug 2024 11:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724609155; x=1725213955; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=raI+n19QFN29zfHeug6+Nnj8oFJHmaYrdY3f2jmORFs=; b=L5IkOULtkUe6b+FYxYJ9BGFp1zpuCB48l7f6CsYL4ScPUotwg9grT6N+rQV0qOnCcW q1veIaZRIdW6XzwOC9doCBoFvNqavnFwXxqqdzMR1Pdepn/+3b6FOzn4ADa/f3ANBBte T1KdAWn0hx96DKDRt0CaspgyLbvBxlh+PyKpudJnMDKmqOFjF8JEvvMu1h4OZD/6uzNv LG/ulX2loufdgMNBNyV6dxZzpWUnwvDD0Sl5XzpdtjSK8YNiDIrDt/EjzUeo/GoTmWKa J7T6pMLKUnhQwQDWNL+nF/Syi30Jphc0AkDb/cDSshyeEH2Ord2adghhEoIux5kXm4h2 iwDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724609155; x=1725213955; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=raI+n19QFN29zfHeug6+Nnj8oFJHmaYrdY3f2jmORFs=; b=iaqeXPv1Drfk49OSFD3S5LuXR0DZXi+pcPDHt/RGVJuLSrO3GrA+PLrN2gnSyZM6Ni veXCOBa8QMMdD9opK8FXklAg/LfjIKXSJmYRq4+eW9kRzsvuvF1z8hSHP0XFjzyr0ZO1 unQZuVZc8udrZuS8yJm3x/H6JrDQoJQkYpj7+Eqx4KEu024pQzqqIdDaQry/Uxs/ceJ3 mIxWcOjz+kgLg51y1sROAbIBLCATyEIBXfZL7XzN2AwssvuLAQOvctdwg/RNqN/uKuZ2 xcMWgyYhAXLLex61ugVvNafc2QfP88yWl+KPv/OWYBvIBW1FnQ8MrNUKDj5TtiEu9o// vtUw== X-Forwarded-Encrypted: i=1; AJvYcCWOXLJA6xrZKI3sYivnmAgYt6FWwoiEwcfYr2y8kFMYgkZtEq6Dh24/jWIpMrVWRmTD1Fsn7cNH46TrvJA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyo0GdP4gY7T4gKOXFAmqgEqcl9K6sdbxrRd1eXQacIDUPUs5an ZKo4s2I6pSO3yV2JgB4SukDvFg/7RNZORLmWAmG/xB7mROQ4idSUutYQCQVT3gDaos9Y99Bccr0 7 X-Google-Smtp-Source: AGHT+IHovd9hBkcFA5+INtvXNRkDasxTeWwT194C24emqMwQsIKUln2/CHtoq+dBH9VjU22j1a5wgA== X-Received: by 2002:a05:6000:18a4:b0:367:811f:814c with SMTP id ffacd0b85a97d-37311852228mr2891104f8f.4.1724609154471; Sun, 25 Aug 2024 11:05:54 -0700 (PDT) Received: from [127.0.1.1] ([178.197.222.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37311dca113sm6438736f8f.16.2024.08.25.11.05.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 11:05:53 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 25 Aug 2024 20:05:24 +0200 Subject: [PATCH 3/4] soc: versatile: realview: fix soc_dev leak during device remove Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240825-soc-dev-fixes-v1-3-ff4b35abed83@linaro.org> References: <20240825-soc-dev-fixes-v1-0-ff4b35abed83@linaro.org> In-Reply-To: <20240825-soc-dev-fixes-v1-0-ff4b35abed83@linaro.org> To: Linus Walleij , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1464; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=djfTpzgwI9VayrirIxvL2d17DNLj3Y9kYYllCM4F/9I=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmy3J5hVAjigtLPRzXJclE2hY3l9wqGiPuN90+6 VH3b32MKzKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZstyeQAKCRDBN2bmhouD 1z6YD/4gu3mtH9IEh3ZQSvcoj0sIV5F5wo+z0K9BmcsSZ8OvhLEiUikWAeTcuLAhbgrn5gzoTq6 UNEzpe0Yo0SWsrpyYm5izi/pKTuvMt+RZtGft0HXS+P8EP0L1A4kFAQ4OJcyUPiN9wqkMqsCYKH LdyWHVivtTiQc/iirLNAAqEi6hlPgzGfxveGpcqqGnN+Wb6jk1OMB14UTc19pUbRO//gV8zlRaB 9HUtRYAB9LySEgj/dgH+Iip/I3nUyn8wW15yC9ZWFBl+KnENa1k/5jHLRqslK5TdSxHeLZmrrzW Zw/fgTZUKKt3Uq1hwZGbpqIT1RHsojTQ1uYH72sJXC+v62+B/1kaUrNrO7Ckhi6KCtSvY/u7QfL 6cn8UtXArp0XU/uHpfKCsFov/Gm6pKy5vQOT3KrOcY/K+LtrKxjbT6SQf8J4oYBSRuTJNIKfw4k v3XkaOxOhKZd0auFGwodSa6Dm/GCoV3Tr6Yx7+mqEiHduB3dTeJ30fsHjWllbBI1gdFEs/Fu6cj enC33MxBkGrsuD298hQViVZbeMOnK5huRM/M62eW3PuYAs+cE+MAZcztvReOZ7WWhsYST95kg4k O2Bk0sCgt26/4NpMbpPjYsc4KN6d8lm8NOhbMOxYoEvJF1q4RhmPsfAQ9qsSpH6YI3zEwBsXKHO 6FLUwK897TPmYQA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B If device is unbound, the soc_dev should be unregistered to prevent memory leak. Fixes: a2974c9c1f83 ("soc: add driver for the ARM RealView") Cc: Signed-off-by: Krzysztof Kozlowski --- drivers/soc/versatile/soc-realview.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/soc/versatile/soc-realview.c b/drivers/soc/versatile/s= oc-realview.c index d304ee69287a..cf91abe07d38 100644 --- a/drivers/soc/versatile/soc-realview.c +++ b/drivers/soc/versatile/soc-realview.c @@ -4,6 +4,7 @@ * * Author: Linus Walleij */ +#include #include #include #include @@ -81,6 +82,13 @@ static struct attribute *realview_attrs[] =3D { =20 ATTRIBUTE_GROUPS(realview); =20 +static void realview_soc_socdev_release(void *data) +{ + struct soc_device *soc_dev =3D data; + + soc_device_unregister(soc_dev); +} + static int realview_soc_probe(struct platform_device *pdev) { struct regmap *syscon_regmap; @@ -109,6 +117,11 @@ static int realview_soc_probe(struct platform_device *= pdev) if (IS_ERR(soc_dev)) return -ENODEV; =20 + ret =3D devm_add_action_or_reset(&pdev->dev, realview_soc_socdev_release, + soc_dev); + if (ret) + return ret; + ret =3D regmap_read(syscon_regmap, REALVIEW_SYS_ID_OFFSET, &realview_coreid); if (ret) --=20 2.43.0