From nobody Fri Dec 19 16:41:54 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4325D158D79 for ; Sun, 25 Aug 2024 18:05:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724609155; cv=none; b=nQk32cqgx+o+4ZZCz15vLsXt6o1KPV6p/v7AzM5dGDi63ZXWiic1enSBuS0i/j3fql4kyV0epFj0N6JPKmWspNQNAaWa69nOYo7K6b1WE9Njpkb1WTBFJuecUZ637TJTeBLITCUqmyX3wbDcwFPBuCH+RTmh6+PyyBQ3/m/9bj8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724609155; c=relaxed/simple; bh=LIZtMc9nHoVSkfFptUxs0Y+Ob0r38B/hMi0Yhl8M4mY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RALwAlliu0o8qy5deWWFnSWG2BTjmTTqHp80/wtp+//jBEhGFqumnnB3Ibs/22MJ8BIyO2n0BQgeDQoEanhfkHRV3SQYQB+FMG2t1am/X8aEdCiQLAEehyr+CEVHkU2mWu4bgIoMZcdQlq9VXpX6t56NtmANYlhRDRsJi9DZDgY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ghXanyug; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ghXanyug" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-37196229356so80763f8f.3 for ; Sun, 25 Aug 2024 11:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724609151; x=1725213951; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VYpIfMLevBxY0BufVpZdLlZOu4ayBivVHqKaTZPujng=; b=ghXanyugvrbAp/ewLMk7vJ+8BWnAIkp6la8z5J0jtw6DbFBqn8CXRFEkvZLpv6IYb7 9hS09zrVuOvbv24AAWr8IGAzSCfDu/d5gmDukIUfPG0P0Qb00TyW/bObLMqTdZzbmx5+ p3thhdO1YPiyIYdrdaJgIFJn789jyy3Ih7n0KbnEtR2i8uRpLupOGFhqsO4Y417/xBMy 7Qn1EegZhdrCiQC6zkru3ibyCBVZRqe57Gz9LPemOzmdQycHk+GUQpAUtPKpG0F4mKIo j48gJ6feNCRFrkvCwxRcsMdIGmxfkLFvCojJeY7Gijx5TjrT/cqItumvRiu9yT6DpKnX mRTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724609151; x=1725213951; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VYpIfMLevBxY0BufVpZdLlZOu4ayBivVHqKaTZPujng=; b=Le8dtrVefQJXBOHl/VCuvl+aR8BHk8mFh7a9qMCw4sAdE/xnI/ivnQr76lAOyRKAC8 obtwiGH2tRI32wJ3NSkaSVOW/D62Q95hQERkIO3nBOyHhqh037TAhZEvonbYeooYWF3G copnClPoZnS937nZTaGYSmFw9uwABnW6EqzrPKB2FX+e+GsN/OMklg4aos4mCPKbmDJQ MKIIObfaDK2kw5Epm9iGOzxpuhehexzkDzNBWGV4C85I7wSPu4afW1mhh+cZJE3niMCL gKcKCEgeP9uGMvtPWFUiEFlWfJNQARIlny+BKhC40UgzBMqITVuBo6HeMua8DPzlVHXv 9n0g== X-Forwarded-Encrypted: i=1; AJvYcCVm1Efct2a4nTtqcpIFJK8pjD34CjjrvDC0EOMq989TpTw4yAEJFVWbhUxsYJ63Cz+06Kie4RC+cX58y28=@vger.kernel.org X-Gm-Message-State: AOJu0YxNz1bbz/9G0uQRwmyxck2TQLkuQJbo+/WvtY8LTAOJ2qTmMV4S bX+jMYf/E92OTNnpu9Rs3HQzOoaghFIN8Zsd6yDv0pNhkuZeWw0Q55yTIVBQHtE= X-Google-Smtp-Source: AGHT+IGoA/Rn3FHpEkZNqq0MHOX/MSoH9qsr9KuvzwqRF1RAbel/snzk7XWVAhvi01a5m+hc/xV1Qg== X-Received: by 2002:a5d:59a9:0:b0:36b:36aa:a14e with SMTP id ffacd0b85a97d-373118d1d2fmr3488407f8f.8.1724609151554; Sun, 25 Aug 2024 11:05:51 -0700 (PDT) Received: from [127.0.1.1] ([178.197.222.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37311dca113sm6438736f8f.16.2024.08.25.11.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 11:05:50 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 25 Aug 2024 20:05:22 +0200 Subject: [PATCH 1/4] soc: versatile: integrator: fix OF node leak in probe() error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240825-soc-dev-fixes-v1-1-ff4b35abed83@linaro.org> References: <20240825-soc-dev-fixes-v1-0-ff4b35abed83@linaro.org> In-Reply-To: <20240825-soc-dev-fixes-v1-0-ff4b35abed83@linaro.org> To: Linus Walleij , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=798; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=LIZtMc9nHoVSkfFptUxs0Y+Ob0r38B/hMi0Yhl8M4mY=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmy3J3NpIXoshBZUGa2xvTz937PSCt1g8bClII7 Gypds9E0ceJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZstydwAKCRDBN2bmhouD 15J4D/sFI2Pwlgu5DaqVgnr27xueYqFfMd5lL4vwH2xoYNLT2//yN0INBwq03sGZAYd816ZG9Nb +3VPV2x03TUVQOYCPU1iMGpnepzP5ReVw/e+zT3lOpcZVN6sM4FUfgSbdUiPhLxYKdBnJVNfbOv aZcCWbTtKWefPVwHsV9hxmIPRBmV1RAjJxylzEDl7jcDju1moiDueV3LZie18q+A6GvjYPMzoGV BAgxnBi7mHkLQuF2rKnP5/xUgGFY5h+79ahsMQHiiCJspOTU2GQQZv0hHuWsEy+yqsuPJTwzNG/ HlPTz0ulAkdSyLCV7DwNVUnv7/rrt53x0wFzL1vNhRE1YfLazkPQCVS0nguJrr76GAcaOOQzSe9 ynF7BeTtJehayCDlUG4LEJWuAMT+v+UO9oE2rTqzIKlpDqdxXZQjHaPy116AMZAeTQmrh4NBsli kxJ5HqW+BHH22T8OOv1q3wE8N/9RMPdCEegGKkPbyu+6xe00WPM4/bXOQXasfrUcwF478KRbuIJ Q9XstIkj7EiqAA+JdxELQ+oYjhyAiiEnt43LHJUH5Td0uE9WYdxJqV8oEBsBFCROzNVesb7Rv3T n+5kJj6eNtVY/Lgi/Wx/7S1ZomQYAYtNsUTmpTeDZv5r1ko3dR8I6Y0dG4bREtpgIydIvvkNCkn 50OkEyWy90ezCMg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Driver is leaking OF node reference obtained from of_find_matching_node(). Fixes: f956a785a282 ("soc: move SoC driver for the ARM Integrator") Cc: Signed-off-by: Krzysztof Kozlowski --- drivers/soc/versatile/soc-integrator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/versatile/soc-integrator.c b/drivers/soc/versatile= /soc-integrator.c index bab4ad87aa75..d5099a3386b4 100644 --- a/drivers/soc/versatile/soc-integrator.c +++ b/drivers/soc/versatile/soc-integrator.c @@ -113,6 +113,7 @@ static int __init integrator_soc_init(void) return -ENODEV; =20 syscon_regmap =3D syscon_node_to_regmap(np); + of_node_put(np); if (IS_ERR(syscon_regmap)) return PTR_ERR(syscon_regmap); =20 --=20 2.43.0 From nobody Fri Dec 19 16:41:54 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4BF216F262 for ; Sun, 25 Aug 2024 18:05:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724609156; cv=none; b=pDT2rc+ja46B8Cxm8O1bdRZA2g35PKhvSjcYwbcaDNFpJ9VzkEsgXHJltP3YrqlmDD/kHhHDKnane889EpuU+3peYUPCE8BmKZZc5nVm07/1BAQ6lwPSXqiIZtk0aDLPRsdEM4/EK3MFH9rGxDUgGWUe9PyBJkav99GDJsRp2yE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724609156; c=relaxed/simple; bh=gLo2MRTXsFeq02SUdCwpMzugi/rrrP2OWGn4eDr68Nw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=imSd1j2w7Rx/zeDeb+mpNtMDpYZOQHFVtJT4dHpgiYsjgKl+qeBki99kG0xPJVG5aSeGbu+MiDvMVKnN0WoVAUWlrJw1YxESfI8ODJO6brDaADtB22Goy11C6J0HFzEgdwIXq7eGd5pDMsl6X89mQrHcvMQFbYQPzFpHc4j6xVQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CEFKMERZ; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CEFKMERZ" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4281da2cdaeso5557055e9.2 for ; Sun, 25 Aug 2024 11:05:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724609153; x=1725213953; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Px08219UxWUPNfHVakRaFgAR3n14DqjgVtECE2v++7A=; b=CEFKMERZyVMQ+uUOTlEJ8XSnN1XfUzJAYCDWzmghnULNlR4vwpz6bwFSnQmUsS8KXw QtoyB7P+4OcTv/G+U5vysJDMzC7qy25lc5KGd3BnAXwWIe1Y5nLTmyN5ycGXWz/fRDaL 6+3msKzpkFU+qry3oRwV5dh0qMMyVafPCJVl4B3N8RhyPHCzrjiqFzbRH73rjoRkfXR8 eRhzXgQzRU4OuYZmFkZuJaDUeEC7DNc9YCb7KJOKG8mD0zP1JYn8BsD7gRc8LucGzaKJ /Mepl/GpvVGn+zQuHuw1yDkczje+flVtH1CfYsTQj5gyVutX3gDHIwI9+YNutwinXCrV R06A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724609153; x=1725213953; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Px08219UxWUPNfHVakRaFgAR3n14DqjgVtECE2v++7A=; b=kFhT+mYbrO6Easr1iCFiTDFoJrHAC6xdnSTneqvKNVkA13CHfJyMLiY6z8Wy9czPLt IonnLT32PQz57+x7BR/cjNbFOxIdgerwVZ8QVnCybIhdogxEGloTVRpdKFGcnOZqLkB7 U8QyZZ5Mc3/lnGdOJ/lGKooNtkHKc7ZIph2B3O7DOJAbzb+u/yGr+HSjtPMJnwRiM/TA +idZ/mlrFQ4wISjvZPL7mDPExCyNBsvF7vb04nXEE97kM1PI6+cuBgPLkSGoNxY/yGSP o1rFPurPNwRhhIjLI2T7VTUQCIDApWIEEfVEIJii5a7AyX1zPMYyUX6WV9sAz4XuCDM0 5Tkw== X-Forwarded-Encrypted: i=1; AJvYcCVvb7u3udHTbnMtae5jHXRX9oeMV/OnE3q23YquOfNC+t63x75cBQfa1Vyij0OffF8zborpSCj18eFGbjY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7Jzf8HG+ICssACLLFXiLanup7ZeQCzawMs+UX7tQTw6GXzzIg GOW1AMMs/C6PKQq7V7IgvOfTUyU88i6p//zqcGVgO0Bu9213i9iEFC8PIv7Epdw= X-Google-Smtp-Source: AGHT+IEOT5xXGWdNvfDQNreEbDE2fIXiA0ElOhNl5gFlct2Dn9/6HfSzNT2X0our2pg7Lo1zqVH7UQ== X-Received: by 2002:a05:600c:1c0a:b0:427:9f6c:e4bc with SMTP id 5b1f17b1804b1-42acca11e53mr35783945e9.5.1724609153076; Sun, 25 Aug 2024 11:05:53 -0700 (PDT) Received: from [127.0.1.1] ([178.197.222.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37311dca113sm6438736f8f.16.2024.08.25.11.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 11:05:52 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 25 Aug 2024 20:05:23 +0200 Subject: [PATCH 2/4] soc: versatile: realview: fix memory leak during device remove Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240825-soc-dev-fixes-v1-2-ff4b35abed83@linaro.org> References: <20240825-soc-dev-fixes-v1-0-ff4b35abed83@linaro.org> In-Reply-To: <20240825-soc-dev-fixes-v1-0-ff4b35abed83@linaro.org> To: Linus Walleij , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1269; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=gLo2MRTXsFeq02SUdCwpMzugi/rrrP2OWGn4eDr68Nw=; b=kA0DAAoBwTdm5oaLg9cByyZiAGbLcnij66rKNDQtIYEA/f6SQA3a3xsRiZyOLMcWfi9UNQw/9 IkCMwQAAQoAHRYhBN3SYig9ERsjO264qME3ZuaGi4PXBQJmy3J4AAoJEME3ZuaGi4PXiaQP/36v XoZ+079iF8+XR3eHzzetL+GsXUMs7VVe8Z7VjIbpeWaqoiaCGLFlFjDWVQjJu9/wxPW5Fpi5qZb 93SXGFvnX4nL8n3TyKzCWnLRN0zV0LUQmo87Wf27T/JpSD9FJ37vChPQKdxPrXL7ZlgwVgyKHNM i2CG6bt17mvx8xux1a+QBTmlHFzpYVBkRwHtwQLyp3S88q/QPseosKB841/9b0bSrO6gRwVp0j6 gDd4xYZyEY2yCKRvJ/9ROQhXsrwMTcYPRC6VhLh1UwG5Uyk35e4+KE0dzO72fL7/F4vfN6m/Z7L VtenMv7B6zRR5beMseJKW/GlWMQiNfj+oSASbrZCd0qGOng0uPPnf1wiUXFrU/QuN68Bab4N5uM PLNkSTRj+E+C431Ol6ymM0NyZ9DdrctHOeWzSn6F0PVj5uAeBycy2wHLC1e8pquVOkui/mD7xc5 vgu3dTsKu0OmPjuwmwM7kGph8hUO8UwDd/DvkQbcg8WOvloa0j7vBdlipbvf2WAliJKDb8vFTq6 +9fwT554fce37h+MT0+6JtNUIY6u8pOU1kQ7nDfmPrSsW2zVOTO2aznPzkpOnXjnHR4LqqiJuWZ qM/caLV1KxpuT5QT9Nmff3YG8NAwvcoGjsWgkV4IwoJd4TCEOyDJ+PlEn5iGemw1xx0WMCwf4LC 4sdAw X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B If device is unbound, the memory allocated for soc_dev_attr should be freed to prevent leaks. Signed-off-by: Krzysztof Kozlowski --- drivers/soc/versatile/soc-realview.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/soc/versatile/soc-realview.c b/drivers/soc/versatile/s= oc-realview.c index c6876d232d8f..d304ee69287a 100644 --- a/drivers/soc/versatile/soc-realview.c +++ b/drivers/soc/versatile/soc-realview.c @@ -93,7 +93,7 @@ static int realview_soc_probe(struct platform_device *pde= v) if (IS_ERR(syscon_regmap)) return PTR_ERR(syscon_regmap); =20 - soc_dev_attr =3D kzalloc(sizeof(*soc_dev_attr), GFP_KERNEL); + soc_dev_attr =3D devm_kzalloc(&pdev->dev, sizeof(*soc_dev_attr), GFP_KERN= EL); if (!soc_dev_attr) return -ENOMEM; =20 @@ -106,10 +106,9 @@ static int realview_soc_probe(struct platform_device *= pdev) soc_dev_attr->family =3D "Versatile"; soc_dev_attr->custom_attr_group =3D realview_groups[0]; soc_dev =3D soc_device_register(soc_dev_attr); - if (IS_ERR(soc_dev)) { - kfree(soc_dev_attr); + if (IS_ERR(soc_dev)) return -ENODEV; - } + ret =3D regmap_read(syscon_regmap, REALVIEW_SYS_ID_OFFSET, &realview_coreid); if (ret) --=20 2.43.0 From nobody Fri Dec 19 16:41:54 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70FD915AADA for ; Sun, 25 Aug 2024 18:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724609158; cv=none; b=usnaUcd1Llfg7iqf7Qg4o/GtmuaT0hPnsH7czm8fYwdHjDDAs71lcLC3pquHXz+Fwue8IvmsaSpTXRYy8WletBuAL4eXByYiY/UgWLYVMzVTLzwEDyPbocGjV0xzy/VR6TibIbKA4ZtLBMwZbhJOAH69A3KyXq6HadSY6VNxMd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724609158; c=relaxed/simple; bh=djfTpzgwI9VayrirIxvL2d17DNLj3Y9kYYllCM4F/9I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BqHnyy1J58SUhhH3KQnWiBWVcuUE/jwq2/NidPgeRX64W3WEqr+vClBH6T/UdKNsSXGEvf6V9oeJtgq0yWYTUcc1DVkE+oKF2Agv9au9D0niswazbJhLUAoDV8YeZylvgEXWAV2Gaoyynb+xPYpHaFYFRkttlDBZIPaOX/b1iXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=L5IkOULt; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L5IkOULt" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4280772333eso5598855e9.0 for ; Sun, 25 Aug 2024 11:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724609155; x=1725213955; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=raI+n19QFN29zfHeug6+Nnj8oFJHmaYrdY3f2jmORFs=; b=L5IkOULtkUe6b+FYxYJ9BGFp1zpuCB48l7f6CsYL4ScPUotwg9grT6N+rQV0qOnCcW q1veIaZRIdW6XzwOC9doCBoFvNqavnFwXxqqdzMR1Pdepn/+3b6FOzn4ADa/f3ANBBte T1KdAWn0hx96DKDRt0CaspgyLbvBxlh+PyKpudJnMDKmqOFjF8JEvvMu1h4OZD/6uzNv LG/ulX2loufdgMNBNyV6dxZzpWUnwvDD0Sl5XzpdtjSK8YNiDIrDt/EjzUeo/GoTmWKa J7T6pMLKUnhQwQDWNL+nF/Syi30Jphc0AkDb/cDSshyeEH2Ord2adghhEoIux5kXm4h2 iwDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724609155; x=1725213955; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=raI+n19QFN29zfHeug6+Nnj8oFJHmaYrdY3f2jmORFs=; b=iaqeXPv1Drfk49OSFD3S5LuXR0DZXi+pcPDHt/RGVJuLSrO3GrA+PLrN2gnSyZM6Ni veXCOBa8QMMdD9opK8FXklAg/LfjIKXSJmYRq4+eW9kRzsvuvF1z8hSHP0XFjzyr0ZO1 unQZuVZc8udrZuS8yJm3x/H6JrDQoJQkYpj7+Eqx4KEu024pQzqqIdDaQry/Uxs/ceJ3 mIxWcOjz+kgLg51y1sROAbIBLCATyEIBXfZL7XzN2AwssvuLAQOvctdwg/RNqN/uKuZ2 xcMWgyYhAXLLex61ugVvNafc2QfP88yWl+KPv/OWYBvIBW1FnQ8MrNUKDj5TtiEu9o// vtUw== X-Forwarded-Encrypted: i=1; AJvYcCWOXLJA6xrZKI3sYivnmAgYt6FWwoiEwcfYr2y8kFMYgkZtEq6Dh24/jWIpMrVWRmTD1Fsn7cNH46TrvJA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyo0GdP4gY7T4gKOXFAmqgEqcl9K6sdbxrRd1eXQacIDUPUs5an ZKo4s2I6pSO3yV2JgB4SukDvFg/7RNZORLmWAmG/xB7mROQ4idSUutYQCQVT3gDaos9Y99Bccr0 7 X-Google-Smtp-Source: AGHT+IHovd9hBkcFA5+INtvXNRkDasxTeWwT194C24emqMwQsIKUln2/CHtoq+dBH9VjU22j1a5wgA== X-Received: by 2002:a05:6000:18a4:b0:367:811f:814c with SMTP id ffacd0b85a97d-37311852228mr2891104f8f.4.1724609154471; Sun, 25 Aug 2024 11:05:54 -0700 (PDT) Received: from [127.0.1.1] ([178.197.222.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37311dca113sm6438736f8f.16.2024.08.25.11.05.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 11:05:53 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 25 Aug 2024 20:05:24 +0200 Subject: [PATCH 3/4] soc: versatile: realview: fix soc_dev leak during device remove Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240825-soc-dev-fixes-v1-3-ff4b35abed83@linaro.org> References: <20240825-soc-dev-fixes-v1-0-ff4b35abed83@linaro.org> In-Reply-To: <20240825-soc-dev-fixes-v1-0-ff4b35abed83@linaro.org> To: Linus Walleij , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1464; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=djfTpzgwI9VayrirIxvL2d17DNLj3Y9kYYllCM4F/9I=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmy3J5hVAjigtLPRzXJclE2hY3l9wqGiPuN90+6 VH3b32MKzKJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZstyeQAKCRDBN2bmhouD 1z6YD/4gu3mtH9IEh3ZQSvcoj0sIV5F5wo+z0K9BmcsSZ8OvhLEiUikWAeTcuLAhbgrn5gzoTq6 UNEzpe0Yo0SWsrpyYm5izi/pKTuvMt+RZtGft0HXS+P8EP0L1A4kFAQ4OJcyUPiN9wqkMqsCYKH LdyWHVivtTiQc/iirLNAAqEi6hlPgzGfxveGpcqqGnN+Wb6jk1OMB14UTc19pUbRO//gV8zlRaB 9HUtRYAB9LySEgj/dgH+Iip/I3nUyn8wW15yC9ZWFBl+KnENa1k/5jHLRqslK5TdSxHeLZmrrzW Zw/fgTZUKKt3Uq1hwZGbpqIT1RHsojTQ1uYH72sJXC+v62+B/1kaUrNrO7Ckhi6KCtSvY/u7QfL 6cn8UtXArp0XU/uHpfKCsFov/Gm6pKy5vQOT3KrOcY/K+LtrKxjbT6SQf8J4oYBSRuTJNIKfw4k v3XkaOxOhKZd0auFGwodSa6Dm/GCoV3Tr6Yx7+mqEiHduB3dTeJ30fsHjWllbBI1gdFEs/Fu6cj enC33MxBkGrsuD298hQViVZbeMOnK5huRM/M62eW3PuYAs+cE+MAZcztvReOZ7WWhsYST95kg4k O2Bk0sCgt26/4NpMbpPjYsc4KN6d8lm8NOhbMOxYoEvJF1q4RhmPsfAQ9qsSpH6YI3zEwBsXKHO 6FLUwK897TPmYQA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B If device is unbound, the soc_dev should be unregistered to prevent memory leak. Fixes: a2974c9c1f83 ("soc: add driver for the ARM RealView") Cc: Signed-off-by: Krzysztof Kozlowski --- drivers/soc/versatile/soc-realview.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/soc/versatile/soc-realview.c b/drivers/soc/versatile/s= oc-realview.c index d304ee69287a..cf91abe07d38 100644 --- a/drivers/soc/versatile/soc-realview.c +++ b/drivers/soc/versatile/soc-realview.c @@ -4,6 +4,7 @@ * * Author: Linus Walleij */ +#include #include #include #include @@ -81,6 +82,13 @@ static struct attribute *realview_attrs[] =3D { =20 ATTRIBUTE_GROUPS(realview); =20 +static void realview_soc_socdev_release(void *data) +{ + struct soc_device *soc_dev =3D data; + + soc_device_unregister(soc_dev); +} + static int realview_soc_probe(struct platform_device *pdev) { struct regmap *syscon_regmap; @@ -109,6 +117,11 @@ static int realview_soc_probe(struct platform_device *= pdev) if (IS_ERR(soc_dev)) return -ENODEV; =20 + ret =3D devm_add_action_or_reset(&pdev->dev, realview_soc_socdev_release, + soc_dev); + if (ret) + return ret; + ret =3D regmap_read(syscon_regmap, REALVIEW_SYS_ID_OFFSET, &realview_coreid); if (ret) --=20 2.43.0 From nobody Fri Dec 19 16:41:54 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6DD01714D9 for ; Sun, 25 Aug 2024 18:05:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724609159; cv=none; b=BLSYj4CYlaMJ4E5Ay9hEq28jUVBhpdJas26vBwL0gzQZEzQL/KyZClGbKaVQ0Nm10HiX2Edq4AjspyumSK1WXCA7OdAjC43rox5ROWor3jLffdFYuQZIii3lPJ2cm4y6kJMbGVVqUStMLH+2TrzvJid8qRhpM4PQ2JzsuXQHszw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724609159; c=relaxed/simple; bh=/iX2lwrQe9MmqSKr9pDmH8EVTSENP3ZuL4P3UVBcTPw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=onhBrXyYuFxRaHujKQumgy4uKCt2I7U/RnSrpWXt11OO5I4K+4YSD6CDfAXWRQ0ED7wddsrzmeH35J/uCUwyKW5vsSFxGizPv2CNZTgBCAuvuGNdpARzWAsH4rgbc1CI2PZyu9tqCof2NIOH1ZfKsT7EJbaZfyK5uh1wWQfe6xk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ByoTvzKt; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ByoTvzKt" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4290075c7e1so4511635e9.0 for ; Sun, 25 Aug 2024 11:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724609156; x=1725213956; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2fDrWsY1iZgM+nyCAHabCHTNPvbQeS69ZzWK0rFucpI=; b=ByoTvzKtReakfCSMoq9DO/vC+Rhp2qhYHh5VtEmhGtTf8p70oQqKh51izEovZ/SjCw LmUux1JjBCQahxC/9Mv1aB+jxitaBg3wG/HxuCxD4Q9K8Ef5iM010Yc6fu6x4DbJZG4E tn1vDOwK/lxjnXN/Kgup+vF7qC/gf7/Lma7ohHZ1DuuV1YWFu7DloY0I090al1AKBp1I HxidDqbJcFR6L9KOEVX4WejOUm7HNxZvr1fypdpCAAwGl+ic8hAbSRvv4LmUB1D9Ly+s JtEoBKh6u0bG7rW0kRvRfT0qdUeBPQygGaADmHxZd44ccWLqNc4Nqck2F86Q7lfmLKgU m12A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724609156; x=1725213956; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2fDrWsY1iZgM+nyCAHabCHTNPvbQeS69ZzWK0rFucpI=; b=YbpZJIcjW4izpKDTRWBYu0HqxZOFitRDOw7K2Qo6yXVf3muDRXdTSgijl/cx8VLRlY Cga6xW7hJdam/ikSdhe5MAVybB41844fRXGM5OzPbaDrFvQqIok7ekJmljjsVpR4q2fW jG3EivPYjr2miqj8MXVbhXKmD/4sHIp5aQuxB7J/Bn08y/WWQl99I3G0VjGVqBInZJ/0 hZhz9ElTbiNN6iabFyXp2THt5+OPVHRsPCsGN5Bx/3yIbi9271jr1ZPwQOVPsAS1LAx+ RfZfZWhc+gGJUb5/xW4xBkqXWz8srDzy+x2rrlYOtKiLR0zvPhUz63yaNJ5v4+Ktcx57 85lQ== X-Forwarded-Encrypted: i=1; AJvYcCXEKP9VGyXTDl+O7JD5Ht+iJdiTOiJKpu1MgIametEbAPCe/UC07Rmp9HTvr/8erTJRkruOnMX3kvJnGhw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6Auci5cNzolcZIz/hkA+yotkrlGciVyakvzl9SjTmHHv4V2f5 XH2EcTUNRgJ9d4OiUUZbwedxVJ7HjQbckVmVSH7VMDnB0qVYSEjPu/CseQ/YvDI= X-Google-Smtp-Source: AGHT+IEDYNS7iJF8sbKwxKBJ35bmHiraIvVb0X9+WzzxjqXzAuTu70MfBmpEuyUqMcMxv7uaH6fBeQ== X-Received: by 2002:a05:600c:4445:b0:425:65b1:abb4 with SMTP id 5b1f17b1804b1-42acc8a7756mr33568245e9.0.1724609156014; Sun, 25 Aug 2024 11:05:56 -0700 (PDT) Received: from [127.0.1.1] ([178.197.222.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37311dca113sm6438736f8f.16.2024.08.25.11.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2024 11:05:55 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 25 Aug 2024 20:05:25 +0200 Subject: [PATCH 4/4] soc: versatile: enable compile testing Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240825-soc-dev-fixes-v1-4-ff4b35abed83@linaro.org> References: <20240825-soc-dev-fixes-v1-0-ff4b35abed83@linaro.org> In-Reply-To: <20240825-soc-dev-fixes-v1-0-ff4b35abed83@linaro.org> To: Linus Walleij , Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1712; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=/iX2lwrQe9MmqSKr9pDmH8EVTSENP3ZuL4P3UVBcTPw=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmy3J6dz7Weq/ta3ekEdu3b9XYUa4uI5fiye4RS 6JUBZJSWqeJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZstyegAKCRDBN2bmhouD 13hBD/wLP4PBvPVVbcABSQEE4DtJV2kF7Kk0LFiYeTx8O4xZb9nDIt/oQzKGYrwwIRBHmlvdSDv 9ZMctbNkN+ArrhA39bSQ1nNjIjymsEaZaSe0tLnWn0GKu/MDdtbQOzYhSl/a15/33JUJxdSB+b4 SIQNahan0N3O703qOJ5soQYAS5GCXop3nYfj1qniBwgllv9Le9dNRlTjjyWTltfWMxmqTncYvDI Xzgw8DkNi/q7SAqMm+HkcVVdxWl737M/XHsrFe1XSCqhmhf/RFf9dT2Pk7xj1lNZ6xig/f2YsIy nqb8yGZ0gseB07NjchxINBWOinC5WCJgp4vfnGwmaljn+y/JzUdcN6ELkgQR52Dp31uRDMkJ5rD fG3vT7pumB+Izu9zj5WVmZ301FrupehIXCRCg09ESXfXXjmov5VmBdO72RIUMznVxjgklW/keKd 8AT+yYJT1BSP15gK8eBGi0Lnu4LKcv1G37O89eAa+OkPJsno0ups0XFZtunmHolYf/JzzhHkVr4 oh+HqIZDDfWEV6Od2XXH0TMVzCh4b7/f745Epol8BsXbbq9y67hhX4Q02Il/oZJ7YibLtMWZVo6 mB/pFRaMA68NiqoNhDPVNgXPv8A/kqQnSMu9ApU73jEe3RVeop0Rgi79oTRn/kelkcjYdk+9nwk hgaYGzoyd2i6K3Q== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Enable compile testing for broader build coverage. None of the drivers use anything from "asm", so code should build everywhere. CONFIG_PLAT_VERSATILE is being selected by driver dependencies (CONFIG_ARCH_INTEGRATOR and CONFIG_ARCH_REALVIEW), so directory can be always added to Makefile targets without impacting other configurations. Signed-off-by: Krzysztof Kozlowski --- drivers/soc/Makefile | 2 +- drivers/soc/versatile/Kconfig | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile index fb2bd31387d0..56f476a12847 100644 --- a/drivers/soc/Makefile +++ b/drivers/soc/Makefile @@ -32,5 +32,5 @@ obj-y +=3D sunxi/ obj-$(CONFIG_ARCH_TEGRA) +=3D tegra/ obj-y +=3D ti/ obj-$(CONFIG_ARCH_U8500) +=3D ux500/ -obj-$(CONFIG_PLAT_VERSATILE) +=3D versatile/ +obj-y +=3D versatile/ obj-y +=3D xilinx/ diff --git a/drivers/soc/versatile/Kconfig b/drivers/soc/versatile/Kconfig index c3792c0a84ac..7bbf54a8d879 100644 --- a/drivers/soc/versatile/Kconfig +++ b/drivers/soc/versatile/Kconfig @@ -4,7 +4,7 @@ # config SOC_INTEGRATOR_CM bool "SoC bus device for the ARM Integrator platform core modules" - depends on ARCH_INTEGRATOR + depends on ARCH_INTEGRATOR || COMPILE_TEST select SOC_BUS help Include support for the SoC bus on the ARM Integrator platform @@ -13,7 +13,7 @@ config SOC_INTEGRATOR_CM =20 config SOC_REALVIEW bool "SoC bus device for the ARM RealView platforms" - depends on ARCH_REALVIEW + depends on ARCH_REALVIEW || COMPILE_TEST select SOC_BUS help Include support for the SoC bus on the ARM RealView platforms --=20 2.43.0