From nobody Fri Dec 19 16:51:18 2025 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CD6B42A97; Sat, 24 Aug 2024 18:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724524479; cv=none; b=H6WRpHEaaVoMXdCQ/UTT7/zF4/8FdgKMDF5lqHcm6bCV7diG8QaXeFzZtzdUs0yL7PPSlUxhCwpnzpgty+aSZpobz710HGHpvTNe7XZpjLEzpy/JrwZ3ImgOr988zrg+LAOjd2S3r0Soo9R//2UoFpoS7JZPrM0DjGUmCFIriso= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724524479; c=relaxed/simple; bh=jPTjo8xHszfHKo7sgVPOL9TrpX9WTP+c7wzcRqjMglI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L7m/HdcKeIdvmM/FpgJ4fgk0cr2gRaEF7IZVeuuYHlLJaY2ZW/MKus5BrZMneaS2n7EGDlp7ptpdnTKvdB6c7G8/9nnaSGdiUi06i/l6d5q3R4krBokQf3IVwd+6i2kf2oRU4d0TGXkv71MWp7jjIE4kia0+yU5KylQqUghBAEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=cireCPew; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="cireCPew" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1724524474; bh=jPTjo8xHszfHKo7sgVPOL9TrpX9WTP+c7wzcRqjMglI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=cireCPew2EtzY8gJ16x3cRSM4QRjWkOE3BkIqskFFXZZWdJebxj2H7EHGTmdyxz+n XaN8QNsINVUO80tk5XZaXZCofpHR0EIIPIv2xnKoeQn8W0kJp5G8B6VIqZ+T9YqKrj Qa2EZUKmv1iSBfpPXCJw3cKlg/4k2XlgE7ioFe2E= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Sat, 24 Aug 2024 20:33:54 +0200 Subject: [PATCH v6 1/4] drm: Add panel backlight quirks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240824-amdgpu-min-backlight-quirk-v6-1-1ed776a17fb3@weissschuh.net> References: <20240824-amdgpu-min-backlight-quirk-v6-0-1ed776a17fb3@weissschuh.net> In-Reply-To: <20240824-amdgpu-min-backlight-quirk-v6-0-1ed776a17fb3@weissschuh.net> To: Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Harry Wentland , Leo Li , Rodrigo Siqueira , Mario Limonciello , Matt Hartley , Kieran Levin , Hans de Goede , Jani Nikula , Xinhui Pan , Jonathan Corbet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dustin Howett , linux-doc@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1724524474; l=4991; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=jPTjo8xHszfHKo7sgVPOL9TrpX9WTP+c7wzcRqjMglI=; b=GvmUKTrjus/ulbBqwnDfwuFvjdkFTYj3oL5MAAFXHLvhMy/7bLvwYdulBAheGb+JFahDvYvL1 dTrGKRO8A20DSoM8PTZtpzA5dJ9uw8Z9ZRQxmY+aDXIqymSOWVL19XT X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= Panels using a PWM-controlled backlight source do not have a standard way to communicate their valid PWM ranges. On x86 the ranges are read from ACPI through driver-specific tables. The built-in ranges are not necessarily correct, or may grow stale if an older device can be retrofitted with newer panels. Add a quirk infrastructure with which the minimum valid backlight value can be maintained as part of the kernel. Signed-off-by: Thomas Wei=C3=9Fschuh Tested-by: Dustin L. Howett Reviewed-by: Mario Limonciello Reviewed-by: Harry Wentland --- Documentation/gpu/drm-kms-helpers.rst | 3 ++ drivers/gpu/drm/Kconfig | 4 ++ drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/drm_panel_backlight_quirks.c | 70 ++++++++++++++++++++++++= ++++ include/drm/drm_utils.h | 4 ++ 5 files changed, 82 insertions(+) diff --git a/Documentation/gpu/drm-kms-helpers.rst b/Documentation/gpu/drm-= kms-helpers.rst index 8435e8621cc0..a26989500129 100644 --- a/Documentation/gpu/drm-kms-helpers.rst +++ b/Documentation/gpu/drm-kms-helpers.rst @@ -230,6 +230,9 @@ Panel Helper Reference .. kernel-doc:: drivers/gpu/drm/drm_panel_orientation_quirks.c :export: =20 +.. kernel-doc:: drivers/gpu/drm/drm_panel_backlight_quirks.c + :export: + Panel Self Refresh Helper Reference =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 6b2c6b91f962..9ebb8cdb535e 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -454,6 +454,10 @@ config DRM_HYPERV config DRM_EXPORT_FOR_TESTS bool =20 +# Separate option as not all DRM drivers use it +config DRM_PANEL_BACKLIGHT_QUIRKS + tristate + config DRM_LIB_RANDOM bool default n diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 68cc9258ffc4..adf85999aee2 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -92,6 +92,7 @@ drm-$(CONFIG_DRM_PANIC) +=3D drm_panic.o obj-$(CONFIG_DRM) +=3D drm.o =20 obj-$(CONFIG_DRM_PANEL_ORIENTATION_QUIRKS) +=3D drm_panel_orientation_quir= ks.o +obj-$(CONFIG_DRM_PANEL_BACKLIGHT_QUIRKS) +=3D drm_panel_backlight_quirks.o =20 # # Memory-management helpers diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm= /drm_panel_backlight_quirks.c new file mode 100644 index 000000000000..6b8bbed77c7f --- /dev/null +++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c @@ -0,0 +1,70 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include +#include +#include +#include +#include +#include + +struct drm_panel_min_backlight_quirk { + struct { + enum dmi_field field; + const char * const value; + } dmi_match; + struct drm_edid_ident ident; + u8 min_brightness; +}; + +static const struct drm_panel_min_backlight_quirk drm_panel_min_backlight_= quirks[] =3D { +}; + +static bool drm_panel_min_backlight_quirk_matches(const struct drm_panel_m= in_backlight_quirk *quirk, + const struct drm_edid *edid) +{ + if (!dmi_match(quirk->dmi_match.field, quirk->dmi_match.value)) + return false; + + if (!drm_edid_match(edid, &quirk->ident)) + return false; + + return true; +} + +/** + * drm_get_panel_min_brightness_quirk - Get minimum supported brightness l= evel for a panel. + * @edid: EDID of the panel to check + * + * This function checks for platform specific (e.g. DMI based) quirks + * providing info on the minimum backlight brightness for systems where th= is + * cannot be probed correctly from the hard-/firm-ware. + * + * Returns: + * A negative error value or + * an override value in the range [0, 255] representing 0-100% to be scale= d to + * the drivers target range. + */ +int drm_get_panel_min_brightness_quirk(const struct drm_edid *edid) +{ + const struct drm_panel_min_backlight_quirk *quirk; + size_t i; + + if (!IS_ENABLED(CONFIG_DMI)) + return -ENODATA; + + if (!edid) + return -EINVAL; + + for (i =3D 0; i < ARRAY_SIZE(drm_panel_min_backlight_quirks); i++) { + quirk =3D &drm_panel_min_backlight_quirks[i]; + + if (drm_panel_min_backlight_quirk_matches(quirk, edid)) + return quirk->min_brightness; + } + + return -ENODATA; +} +EXPORT_SYMBOL(drm_get_panel_min_brightness_quirk); + +MODULE_DESCRIPTION("Quirks for panel backlight overrides"); +MODULE_LICENSE("GPL"); diff --git a/include/drm/drm_utils.h b/include/drm/drm_utils.h index 70775748d243..15fa9b6865f4 100644 --- a/include/drm/drm_utils.h +++ b/include/drm/drm_utils.h @@ -12,8 +12,12 @@ =20 #include =20 +struct drm_edid; + int drm_get_panel_orientation_quirk(int width, int height); =20 +int drm_get_panel_min_brightness_quirk(const struct drm_edid *edid); + signed long drm_timeout_abs_to_jiffies(int64_t timeout_nsec); =20 #endif --=20 2.46.0 From nobody Fri Dec 19 16:51:18 2025 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CDA8433CF; Sat, 24 Aug 2024 18:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724524479; cv=none; b=qj5olGBaTIjhpMzCFZTyUbQa+AvXMzIinmTDQ6hTWLS3EceGyBsnMXyFnQ3+0UIbn+dmS2SBenXTBEcTZiSR5EvdUNfOi91J8EUcw3Y53L0Wg5yyHXLSXNe7zQArfYpyhiA/By8XyKQaLunCDGFgK03OWl3QZwLNx0ocpxIBBFU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724524479; c=relaxed/simple; bh=pXwPNuj1+2MaBbsgOKVjjIsLJ5HBVXKxLzYgXNTSWNY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pNnyYvZrxbNiG9sovKvr0tsQQxFtUi+/rNU3yFhY4mADmxeaJbDrIHsCeU1M8WwxXH0IZ+J68ZOgUolJI8qiuEzIny0k06i0o3z9Kl2SSdsV8wbqcdqBxLQLZCwgvX3/+Iv2deAtHp5TW9+RTabf+1WaFG9KV1Rka3NdVgrG1s0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=TB30hA5X; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="TB30hA5X" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1724524474; bh=pXwPNuj1+2MaBbsgOKVjjIsLJ5HBVXKxLzYgXNTSWNY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=TB30hA5XnEa7fyrihN7qLIn+P3NA0zkD1xPozEjokv3NczFvkhKQq0l2XRsojyQ9Y 8aAV106FaaH3e1hR6xC5fFVaM3RkpCpVakdlpj/KMg09Nu5ewBem4SLzNTSK6mlqwN VuzHCR23sJJIjuqz22qtmBKwy/VPwa1fJX/G3WVw= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Sat, 24 Aug 2024 20:33:55 +0200 Subject: [PATCH v6 2/4] drm/amd/display: Add support for minimum backlight quirk Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240824-amdgpu-min-backlight-quirk-v6-2-1ed776a17fb3@weissschuh.net> References: <20240824-amdgpu-min-backlight-quirk-v6-0-1ed776a17fb3@weissschuh.net> In-Reply-To: <20240824-amdgpu-min-backlight-quirk-v6-0-1ed776a17fb3@weissschuh.net> To: Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Harry Wentland , Leo Li , Rodrigo Siqueira , Mario Limonciello , Matt Hartley , Kieran Levin , Hans de Goede , Jani Nikula , Xinhui Pan , Jonathan Corbet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dustin Howett , linux-doc@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1724524474; l=2773; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=pXwPNuj1+2MaBbsgOKVjjIsLJ5HBVXKxLzYgXNTSWNY=; b=wZPXulQQnUKt4eZU7D/anz1D3UzcnVTFMef69VP4gLOdo12ou4ie823nDuY8HBS7Tlox1yc6c wUKJPUFEpRFCXW+39oSRRtA6Mb5muAIVtwUuLEoM+tj+O97iDinyO9N X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= Not all platforms provide the full range of PWM backlight capabilities supported by the hardware through ATIF. Use the generic drm panel minimum backlight quirk infrastructure to override the capabilities where necessary. Testing the backlight quirk together with the "panel_power_savings" sysfs file has not shown any negative impact. One quirk seems to be that 0% at panel_power_savings=3D0 seems to be slightly darker than at panel_power_savings=3D4. Signed-off-by: Thomas Wei=C3=9Fschuh Tested-by: Dustin L. Howett Reviewed-by: Mario Limonciello Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/amdgpu/Kconfig | 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgp= u/Kconfig index 0051fb1b437f..655c10aef2e3 100644 --- a/drivers/gpu/drm/amd/amdgpu/Kconfig +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig @@ -23,6 +23,7 @@ config DRM_AMDGPU select DRM_BUDDY select DRM_SUBALLOC_HELPER select DRM_EXEC + select DRM_PANEL_BACKLIGHT_QUIRKS # amdgpu depends on ACPI_VIDEO when ACPI is enabled, for select to work # ACPI_VIDEO's dependencies must also be selected. select INPUT if ACPI diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 983a977632ff..056960ea335c 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -93,6 +93,7 @@ #include #include #include +#include #include #include #include @@ -3333,6 +3334,8 @@ static void update_connector_ext_caps(struct amdgpu_d= m_connector *aconnector) struct drm_connector *conn_base; struct amdgpu_device *adev; struct drm_luminance_range_info *luminance_range; + const struct drm_edid *drm_edid; + int min_input_signal_override; =20 if (aconnector->bl_idx =3D=3D -1 || aconnector->dc_link->connector_signal !=3D SIGNAL_TYPE_EDP) @@ -3367,6 +3370,13 @@ static void update_connector_ext_caps(struct amdgpu_= dm_connector *aconnector) caps->aux_min_input_signal =3D 0; caps->aux_max_input_signal =3D 512; } + + drm_edid =3D drm_edid_alloc(aconnector->edid, + EDID_LENGTH * (aconnector->edid->extensions + 1)); + min_input_signal_override =3D drm_get_panel_min_brightness_quirk(drm_edid= ); + drm_edid_free(drm_edid); + if (min_input_signal_override >=3D 0) + caps->min_input_signal =3D min_input_signal_override; } =20 void amdgpu_dm_update_connector_after_detect( --=20 2.46.0 From nobody Fri Dec 19 16:51:18 2025 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A993952F70; Sat, 24 Aug 2024 18:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724524479; cv=none; b=NosOHDk+sC7VMqZEKw1OiGYdRmDKsN+3AA7uwvP9gkVPL9cwq9BptsaxwehfEsrUNauW8zrBpe0xq8bexP6qXSxELqLh02GxUDrYR48t+nU3yr3L4rKkaGckGag2x28/sS8I9gV5P6cDNar/L3P2GX6553EbJJfYVb6pGuHDswE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724524479; c=relaxed/simple; bh=AfFeXIIAgQ9QcQOVPaJFq7joVIfw9zHjAXRU+l+Hz2c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nN368EzBn/MkaXLm90vbT5BxNFsq32axiHbgBkHkrJ590h5yu4LtU8p0IToJ/BJa0B5R5seW3liiHuu5/bBxqPqTVwAjzoMJTmXRhiZlFMjkNpcsxBE7ixKiEgoPx+e0PDtpzk+c89CWQOMRl+rM6pJqhN/zEPLyw+NckAx5xlE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=by+kF/rh; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="by+kF/rh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1724524474; bh=AfFeXIIAgQ9QcQOVPaJFq7joVIfw9zHjAXRU+l+Hz2c=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=by+kF/rhDcqEuvTj4uEr8LEyJldjHKcJxSSzc/QcP1ww5D2tXigDG4MXFU7sX21qQ 7PoYtVTBek4rF+boQNYvWXNR2aEAYFBBPskZppl5I7HH9xAAlv0RwmQXIcDiiqwfog Np+y3lQ8haKT+vzDUpeH51/g5WJxsL8+X0z2a24s= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Sat, 24 Aug 2024 20:33:56 +0200 Subject: [PATCH v6 3/4] drm: panel-backlight-quirks: Add Framework 13 matte panel Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240824-amdgpu-min-backlight-quirk-v6-3-1ed776a17fb3@weissschuh.net> References: <20240824-amdgpu-min-backlight-quirk-v6-0-1ed776a17fb3@weissschuh.net> In-Reply-To: <20240824-amdgpu-min-backlight-quirk-v6-0-1ed776a17fb3@weissschuh.net> To: Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Harry Wentland , Leo Li , Rodrigo Siqueira , Mario Limonciello , Matt Hartley , Kieran Levin , Hans de Goede , Jani Nikula , Xinhui Pan , Jonathan Corbet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dustin Howett , linux-doc@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1724524474; l=1482; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=AfFeXIIAgQ9QcQOVPaJFq7joVIfw9zHjAXRU+l+Hz2c=; b=aRBsXCe1+ZIvefXKrtVl3+KLKWtGSo3fVGq0sMRSB/Ro9OzQF+VgwHsWF15E4m6cz925Vfmma vDd7jK8eHFLCfuWbteIMbAv4v9rR+iDO61qALA+V8itnaqw8KcAdyFH X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Add a quirk to override that the minimum backlight PWM to "0" which leads to a much lower minimum brightness, which is still visible. Tested on a Framework AMD 13 BIOS 3.05 with the matte panel. Link: https://community.frame.work/t/25711/9 Link: https://community.frame.work/t/47036 Signed-off-by: Thomas Wei=C3=9Fschuh Tested-by: Dustin L. Howett Reviewed-by: Mario Limonciello Reviewed-by: Harry Wentland --- drivers/gpu/drm/drm_panel_backlight_quirks.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm= /drm_panel_backlight_quirks.c index 6b8bbed77c7f..f2aefff618dd 100644 --- a/drivers/gpu/drm/drm_panel_backlight_quirks.c +++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c @@ -17,6 +17,14 @@ struct drm_panel_min_backlight_quirk { }; =20 static const struct drm_panel_min_backlight_quirk drm_panel_min_backlight_= quirks[] =3D { + /* 13 inch matte panel */ + { + .dmi_match.field =3D DMI_BOARD_VENDOR, + .dmi_match.value =3D "Framework", + .ident.panel_id =3D drm_edid_encode_panel_id('B', 'O', 'E', 0x0bca), + .ident.name =3D "NE135FBM-N41", + .min_brightness =3D 0, + }, }; =20 static bool drm_panel_min_backlight_quirk_matches(const struct drm_panel_m= in_backlight_quirk *quirk, --=20 2.46.0 From nobody Fri Dec 19 16:51:18 2025 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7E3D53365; Sat, 24 Aug 2024 18:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724524479; cv=none; b=MnYFHvQuBgJdyotu8mWjFWTnD2oJtbFHhEiiHHJdjpaD2QPK3zzXwFkRwwMle8lOy+F7dXIzcExyN55jpnhbgH+GGrxqLpKDHR3+H7IpibSNBxZ4VJB2beCT1HxV/IhFEIWMTkedtpLFngOn+w407PJo78HdijQkfCq8yuGsNgQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724524479; c=relaxed/simple; bh=mTw6jyeW6NnH6hMUo80Xkpk+kXmEzTn3WVnf7UD8fF4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jvTR4f7XXmNlpzqMEVXPNKpithhoLcjXkiMgp0VDQ5tju0XHKNvJiYX/HvLf5Jda0yzHWKiaW31k2lnYV7iNpSxWdVYw6hwTd9DUZCVLVKRAXmqMlKWIB4R8CYOBz3S3JsRrgRBFW/DnoF6vzMRA9A7/WNaHLVIAYc/KRhIV0pY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=OrmVmDLp; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="OrmVmDLp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1724524474; bh=mTw6jyeW6NnH6hMUo80Xkpk+kXmEzTn3WVnf7UD8fF4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=OrmVmDLpNXYym67YQoExHgkOG4kFLVCsIQDj3j23GxFLUXDDOBypKfwOD+k8ORcGB 1BrUOnaFTylWc7yl5pRgP8PkOT/uH0kYW4Ozvpt8H3EXDqVMiAYPInKpeS+uS8gljL aWLQprfNAX6l8kIfgre+3V1bzpuerkGZ1YWUnWDU= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Sat, 24 Aug 2024 20:33:57 +0200 Subject: [PATCH v6 4/4] drm: panel-backlight-quirks: Add Framework 13 glossy and 2.8k panels Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240824-amdgpu-min-backlight-quirk-v6-4-1ed776a17fb3@weissschuh.net> References: <20240824-amdgpu-min-backlight-quirk-v6-0-1ed776a17fb3@weissschuh.net> In-Reply-To: <20240824-amdgpu-min-backlight-quirk-v6-0-1ed776a17fb3@weissschuh.net> To: Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Harry Wentland , Leo Li , Rodrigo Siqueira , Mario Limonciello , Matt Hartley , Kieran Levin , Hans de Goede , Jani Nikula , Xinhui Pan , Jonathan Corbet Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dustin Howett , linux-doc@vger.kernel.org, =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1724524474; l=1440; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=4PWZVYaIj9BWwhnUS2qlUz6H6bPcZd/2WgBOxYO5hgw=; b=uZISDVhsribEXW2iPNZoaYmx2fpVMDA+fMTjEw3Yb35y9ywEsVBwTCpxr008kXxwlG9Bt+J/W OIUcCoJ52nnCqIZmmD7viOm+HGusVawMmcXmJenCPTrA1X6QMX4yUvO X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= From: "Dustin L. Howett" I have tested these panels on the Framework Laptop 13 AMD with firmware revision 3.05 (latest at time of submission). Signed-off-by: Dustin L. Howett Signed-off-by: Thomas Wei=C3=9Fschuh Reviewed-by: Mario Limonciello Reviewed-by: Harry Wentland --- drivers/gpu/drm/drm_panel_backlight_quirks.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/drm_panel_backlight_quirks.c b/drivers/gpu/drm= /drm_panel_backlight_quirks.c index f2aefff618dd..c477d98ade2b 100644 --- a/drivers/gpu/drm/drm_panel_backlight_quirks.c +++ b/drivers/gpu/drm/drm_panel_backlight_quirks.c @@ -25,6 +25,22 @@ static const struct drm_panel_min_backlight_quirk drm_pa= nel_min_backlight_quirks .ident.name =3D "NE135FBM-N41", .min_brightness =3D 0, }, + /* 13 inch glossy panel */ + { + .dmi_match.field =3D DMI_BOARD_VENDOR, + .dmi_match.value =3D "Framework", + .ident.panel_id =3D drm_edid_encode_panel_id('B', 'O', 'E', 0x095f), + .ident.name =3D "NE135FBM-N41", + .min_brightness =3D 0, + }, + /* 13 inch 2.8k panel */ + { + .dmi_match.field =3D DMI_BOARD_VENDOR, + .dmi_match.value =3D "Framework", + .ident.panel_id =3D drm_edid_encode_panel_id('B', 'O', 'E', 0x0cb4), + .ident.name =3D "NE135A1M-NY1", + .min_brightness =3D 0, + }, }; =20 static bool drm_panel_min_backlight_quirk_matches(const struct drm_panel_m= in_backlight_quirk *quirk, --=20 2.46.0