From nobody Mon Feb 9 07:57:14 2026 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2041.outbound.protection.outlook.com [40.107.117.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6623D1C942B; Thu, 22 Aug 2024 14:06:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.117.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724335566; cv=fail; b=eL2T0MLwjnBTuJ9NgeBGBjZIu8Dlp3SnWk2EN1NL33mfz/iUgAaN5THll7mFhMELRnkpLA8QbR/9vA1FyT5Cjpwvi0Fgnl9vvFF9A2jYW8P+lAi3E+yTCoVSdi87YToITC6mfI1YHzCGphwIlGtf5lr5aGYfaPLgfGVg3+T/Wao= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724335566; c=relaxed/simple; bh=a0zLsE1j2Gf3/rVV9f8v3hrhEfqyf2LjHP7E5KBlJDk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=pvgAJCJWuBt1vUItq4aey5hUKgdU3pBJPmLNvBJ1lxOuQDybGODcICwIln07ZeL5rLA/o34dHWSdHBLJtgDCT13FtQKPUfUxX3XkBD4ryLstRJz33bRBEG5xqpxFBlEY3TwqDgXftKl3AxGs8+ZGeL6T89+bTLmgr/wbmtcgSVQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=VhnVhGP1; arc=fail smtp.client-ip=40.107.117.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="VhnVhGP1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nM1TzP3NZE8srqck8wnsxrF9m7xjYpOZtW+/kswnaqd5+DJWpyKNPlHqJQ5llZ9gSQDWwsOFKk7mqY2C/QuU33wpw+cUkBwyy/xcznu8AISjAJabKzG8oWMpYYfICr6ggHkwVIThh4E3Weoyhm1GtJ7RrLMu3cgEcopjTPPktKKoHlaTVPN3VpXgBhugkAkxAPiwUEYbzv0sGwtR66MsKkJj842tPhMImOsGHZDJUNjw3L6H9NHwyfWmQFoPEAjcUEOvaLZ7+sJClCC+xbNWlPwo55/InNQhzvMNLOF60R/5/kBsmoxumTxxhq+pUyV6JiE1CCY023xhmiT97VaaNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fh6gqHwq0sI6K+2JpXOAiq7ZlnK3XNIqM+42FuvrmE8=; b=VQXq2KZdc+714LJuGep7fggPWcvrF6yWH/sqwPd+k0PJrJf4aWF38RznOcjSQtKM8Y7E08audmSsNGQEJYXxstnGwc9ho/UJCqqfV28q7mPXArqYxg5TnK1JpuDF1TbvMWjyIPd7Sa1pei/QVQMU1YB+Eghk44gn9Jy1LkZJIFMX7vqk6PodrkajAgK8pNo8G82Kxo5ncBYK/nT/5iM4tvqqq89WBnaj/75VXKofHZxOD/d6tuduH4VXDraIx4EE8HEunDHB/m00GNw8mNfyI/soNvczam6IXPoBOX0p2VrkkLgkDP/1PVA5x+U3khVkvPJML2fM0kWwMPtm0/9+IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fh6gqHwq0sI6K+2JpXOAiq7ZlnK3XNIqM+42FuvrmE8=; b=VhnVhGP135GfpBm80Vg7EfMO7/fsgeIw7aa4uuszRt6pk0L9VGK7XneDo3+evENMmI29/gEkH3HKIuHro2EvfjGvXff4SZ+L1PSNTwtAKUzx8mdh8/gPMLNt5m+jBFvAvlaqccal8xfT+7u5Tlp7RPwzR7eW0VIgzDRl7oMbUMrzlLUvXy5ppCQhc6k8pXz6LCQZaEJX6EY+jX5phAWbrtpKR1rpd8/PF0q2gGhGf/+SA6sJWI8ftcGE+zEvyO145/ydXyvKSb0HvonwdUrfGnVciYYgrzg8LUhU8AqA8qfVemQs0lO9MIO2766K3skEN1U1VtvA3azbzat59rdfDQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by SEYPR06MB5301.apcprd06.prod.outlook.com (2603:1096:101:82::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.19; Thu, 22 Aug 2024 14:06:00 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%6]) with mapi id 15.20.7897.014; Thu, 22 Aug 2024 14:06:00 +0000 From: Rong Qianfeng To: biju.das.jz@bp.renesas.com, Wolfram Sang , Andi Shyti , Paul Cercueil , linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Cc: opensource.kernel@vivo.com, Rong Qianfeng Subject: [PATCH v2 1/3] i2c: emev2: Use devm_clk_get_enabled() helpers Date: Thu, 22 Aug 2024 22:04:10 +0800 Message-Id: <20240822140413.65369-2-rongqianfeng@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20240822140413.65369-1-rongqianfeng@vivo.com> References: <20240822140413.65369-1-rongqianfeng@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0294.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c8::6) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|SEYPR06MB5301:EE_ X-MS-Office365-Filtering-Correlation-Id: 5fb28585-9554-40dc-b380-08dcc2b38d41 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PDeDx5SsDV55zf4XkiI3P1RX1vyPWsgFgxbYjkSanJwVuQ7QWWvGAHXAAP2F?= =?us-ascii?Q?6WMhRnFvNiG3sCViuhMqErtwLMZiwnTJi85P6cX1nV3kvEYb4eThxHgScKqV?= =?us-ascii?Q?7ivGkqim0/+CH1y+T3p9FwJfSbBPPKUTTQe4J5nKefxdAd7ix3o57jmfoIrV?= =?us-ascii?Q?RbBwJ03rs57BRorT30WK4lBxgsFMv0WXTabJ5Xrh6iEH+5PGxMjLbjjTDWyP?= =?us-ascii?Q?G33l79HzT8bdD1SvRqYYe3knXrmWDtHfUphP5bqqDELKbeS2/PUCWKTjjeZP?= =?us-ascii?Q?VBb5OSvLyWkzkL2L4KXn3OO662fWOFG0wQwkkusIDRWYZnEQiXdEFIyCFMfC?= =?us-ascii?Q?SRbimEvzVgpbynSKlrHLINpIJMNL5UxQ7UlZo1AqPUNQ7qqgIl81oOKMlf/m?= =?us-ascii?Q?HRa55zsP61qY1cF07C1K0yyzT76/DRnDLBp3cvpXkdjXxQV/IkK67qvHDfsV?= =?us-ascii?Q?YNg0E/jWhCW4J8T8W2+Lh4h6o2c88VKix2sLMMaitoFvuCYBk7Jr961E0b4N?= =?us-ascii?Q?kAhFTwtWwtZiSLJVDvqj6mEU5TUJFd/9GeQm1gD2D+yxY1QEmZLFdvSEAN0n?= =?us-ascii?Q?bivPpeQJILbDKQjAYPxDb/ms1pnxqQR312MICkXJGFq6IqG9kPmcSYXmV1F1?= =?us-ascii?Q?EQlxCVBFijTubj4+0mIWU0wsqCZiqBmhByV4E1+aNRGYpjKgEJCWvX23/YAE?= =?us-ascii?Q?SvFWX/2DmhFMusDiNLq++CoQDILPfl27DXU6PaxzdDs22htSrWeBorbYrVBC?= =?us-ascii?Q?JnJ6ni+rzVHLFI0Jp9iNX+GO0NJXs4BQL8asJj+ymphFLjeVosX13KiJJGwF?= =?us-ascii?Q?AgOBKSi63jog/uziWTYdR8NUVEakP5j7srSUhnymI9jeD0Lr0V3gp7FqoMMq?= =?us-ascii?Q?So+3kUox97Xs3Gz793xlSyhfeuH3mTQzMCYfqxF+tA2tCLLQGyhpVfyaTxJ/?= =?us-ascii?Q?rqXfvMfqGhdqYBIw5jCO+UYHHp+DDmB6AM+i0400vOecMuegFzpYhvVkMaHx?= =?us-ascii?Q?HEW3KiF23jD/VdKPAfkf1pTolE7N8351OejdcER9xNUYS6harp29uTm7fF1S?= =?us-ascii?Q?uxTzrP1TWyH01VPg7u3vTvhG8s/R0P1/fa3XSOZc8KvxKkPMWb0wDr8nTcvT?= =?us-ascii?Q?j27F8ZUjq7EZy6EvzpDysGyWfycmo+DhscKfEMwofqd5iFEnGArP/qi6OvUz?= =?us-ascii?Q?soa1CC3mK3TomPmlEvIViFqFDXbkRZAEnbZ9LgkusVbXMK9v/zDksN80oaBU?= =?us-ascii?Q?g/7o9CPSQyQxpuIl1yejtWpX6pIRFF/38gWKVlZLNV62PcKV/4LT8WrAOMI2?= =?us-ascii?Q?V+JuwndNoh0aY7yc3MdJCRxqBn695/7RYnjl6qJfs6upfl2HM5JUWKEbKZ5t?= =?us-ascii?Q?BH1AG9W+GBmAe6z7t+xdrCAfykuYbvhD90+VAywBme4nTgC7Xg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?u0/ZOMVxP7ZFiIj28AIkgfjducrS1J3p2wODaGfKyAfUZzygwMxaRu6Kl2P/?= =?us-ascii?Q?+e6yfa7ZDePAlZDHU4rRahUeT0DtXkL1BzjMskOizuSYdT1dX5UzFZz+Yutl?= =?us-ascii?Q?KOVr9WDl3CPeGIP8GQIJKTq9f1a4eWqfE/4OqtvTgjNtoAWRLPsnDH/cxg41?= =?us-ascii?Q?T8Sd6dnS6w9wMG99VUcJEUcYrtGAQ/4B5MOMik/RayP2wNiwFcQ7GlWowGnF?= =?us-ascii?Q?hGO9vw4LkvGGYShcg8TOIfiHGV4pVA86Xm/6juW7/obnu4BTIRzTAYTLHDyL?= =?us-ascii?Q?g4gWQ4U7uqOzsiAZMgsmEfD1/kMbLG37Sp58dzGZYDL4jXBMJeteOKh17vTs?= =?us-ascii?Q?joP5kQxeo9QZtY9fBUxlSSDYDDTbkf7dG3c+1tWSErdcPiPqELVIRh8vGEns?= =?us-ascii?Q?h1yof7zujTcQ8YnxBSZj9+a9iy0y9rJOb9ElDCTFnpUKQB23H27ufgBWwcy0?= =?us-ascii?Q?jD4Vn3rF+WICHipHCazUyub3zp4fqd6CyaBMMUtX6zW9hK4BGVo4IoolQbKf?= =?us-ascii?Q?YDg4dzUiwESNyN/TrutOnZsEV5jsS6odeXDGSEc8a7EvXJMIIhbeDDCQ2bBu?= =?us-ascii?Q?LZNvU3rndEKbAkENqHVDDPGArhPb6xCMUImeP2kmvDfNI5vGb5+UVKeTabj4?= =?us-ascii?Q?JPuff4l4GcbMF+M1E5t9w0IRsYxHRz/s0Rs2HEtL4kbDG+OpdpnvWoNcfPnN?= =?us-ascii?Q?Z/GLQzwayeVf3AQZrJ63uQUm5ckzVTpF+D3jIraINtceP5FXE+AYBzrOV0fb?= =?us-ascii?Q?0n70liI3SXL+3VvcmWKY/SxqYPDdk8YIbHFxhTeUWNjzGQKK01oaC9ko2+RT?= =?us-ascii?Q?PjZ64Ir6kKFwzShxbyzBwdrA8VB4EaiVk/6SBs5KoWc1cV1QiFAVRhcSTwxW?= =?us-ascii?Q?cEBYMn645tP4gucH743UfOaM92RahcsXqnGydgc3u4merswt0pkAnUrJ6f0V?= =?us-ascii?Q?uS+cUMm7YLOpoaytvo/G0K2NJRWETXQd+7iBjmfmGOt7YtRmkGKlXkX6ZTv8?= =?us-ascii?Q?/VeeiqOTLSfiGRJ6/N6g7h12Q/aP4FvxR2ZjbpVcFEErUvz22zflhNEiezi9?= =?us-ascii?Q?N7OWrHyl4BUkdP98h4SR3eEQm0ni9FaV47JOqtOTMVQjHiVpy5aNRjQ2dxLF?= =?us-ascii?Q?IbnxYcP4lm53Y9r93w6gw7hA9U3ZFKsCUrJsBN4B2S8chLIy684sY9zCBy1C?= =?us-ascii?Q?ZFpHwf4ZEcttTH6ShMW+d/9Ibu4jUqjJOOskSuyoiLxOd9YDxTm0NtgCRiuN?= =?us-ascii?Q?zp1nwXGPeHyzOtX2yt4cDlc0AssdbmfgfbqNg+pojnIcNnrVZVu5S6UM9H1m?= =?us-ascii?Q?szU5iWbiO4Bk/zujql8ZvrlUsHYzCb58McX7eHAsxoOUHIK5GD+QOE3VUbI9?= =?us-ascii?Q?VKTLcMB1diYnwUOnmUowCyHf0R0T3GovGOvaOhOSYNqaV1pFd1o/YM1pkU6Z?= =?us-ascii?Q?OkKs8ZYGetRxJ2f01in7PeJT+Hqs0oyLmNDgD6T3s6iKlPBpuC4uRpPJ+Zvj?= =?us-ascii?Q?R9mKpEUyfKe+47pHn9RtI3yHIpZNkohvaPaWAj8MVCxzZzlUPFKUOlNzYwok?= =?us-ascii?Q?sg/RNzkuE1VOfhmz38GAsQVg+RswOEYhH4K80sJp?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5fb28585-9554-40dc-b380-08dcc2b38d41 X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2024 14:06:00.6603 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EdPxc4aRtQ/FFMCaChKOh/G17DpuOT0Mx1hxdSPnCGJNJvsZeieb2+pM2Vqe0BRD83oGClOtheoSaVR71HECnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5301 Content-Type: text/plain; charset="utf-8" The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). Signed-off-by: Rong Qianfeng --- drivers/i2c/busses/i2c-emev2.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/busses/i2c-emev2.c b/drivers/i2c/busses/i2c-emev2.c index 557409410445..20efe0b0cb85 100644 --- a/drivers/i2c/busses/i2c-emev2.c +++ b/drivers/i2c/busses/i2c-emev2.c @@ -373,14 +373,10 @@ static int em_i2c_probe(struct platform_device *pdev) =20 strscpy(priv->adap.name, "EMEV2 I2C", sizeof(priv->adap.name)); =20 - priv->sclk =3D devm_clk_get(&pdev->dev, "sclk"); + priv->sclk =3D devm_clk_get_enabled(&pdev->dev, "sclk"); if (IS_ERR(priv->sclk)) return PTR_ERR(priv->sclk); =20 - ret =3D clk_prepare_enable(priv->sclk); - if (ret) - return ret; - priv->adap.timeout =3D msecs_to_jiffies(100); priv->adap.retries =3D 5; priv->adap.dev.parent =3D &pdev->dev; @@ -397,26 +393,22 @@ static int em_i2c_probe(struct platform_device *pdev) =20 ret =3D platform_get_irq(pdev, 0); if (ret < 0) - goto err_clk; + return ret; priv->irq =3D ret; ret =3D devm_request_irq(&pdev->dev, priv->irq, em_i2c_irq_handler, 0, "em_i2c", priv); if (ret) - goto err_clk; + return ret; =20 ret =3D i2c_add_adapter(&priv->adap); =20 if (ret) - goto err_clk; + return ret; =20 dev_info(&pdev->dev, "Added i2c controller %d, irq %d\n", priv->adap.nr, priv->irq); =20 return 0; - -err_clk: - clk_disable_unprepare(priv->sclk); - return ret; } =20 static void em_i2c_remove(struct platform_device *dev) @@ -424,7 +416,6 @@ static void em_i2c_remove(struct platform_device *dev) struct em_i2c_device *priv =3D platform_get_drvdata(dev); =20 i2c_del_adapter(&priv->adap); - clk_disable_unprepare(priv->sclk); } =20 static const struct of_device_id em_i2c_ids[] =3D { --=20 2.39.0 From nobody Mon Feb 9 07:57:14 2026 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2076.outbound.protection.outlook.com [40.107.255.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22C2C1CBE93; Thu, 22 Aug 2024 14:06:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.255.76 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724335570; cv=fail; b=DbZ/4qbu8CHGiLRYo7eJ+9K2eSl6n+5TpGJdrLsRzVpwEV6O4CZ8zrAYLj5/fywttK4KFzf9PdjXz/YZxYQzC1zSCfaC+9K2z1dXc8ZBwPHqAbYlAWDUksq9CZRSp92iZfiNXakyiLXKE6hTDa1weY4kS6UMuoDWB8hkvwr1Gig= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724335570; c=relaxed/simple; bh=o81UGAtjWDlRk/lA4vWJRhoCIW+NdC52Xa5p9KaV0r8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=SA7HZkma4OJ9xSWyA3JqmR8OWVoH4w2MwjaHGyCTWsBwTZZGQYD/tQ01g9EVjr//4ImsmXzrDU4lTlYzUoxij+xeYYLGLdL5woGkR/Ngvkje1Nz2NzIvpoJf5eyw+HXvoMPvMFOSKmcEAxEdaJD0VLzhJbo68DGgNrKh6iX7qJ8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=Qdz7HYXC; arc=fail smtp.client-ip=40.107.255.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="Qdz7HYXC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t0DgNwcgKAnRiRE2YJEGu8piqQthF5Zthwq5Elf3BAMyI6IdvXvinE4kLR9qmP8odcJ8xD9yD6yQDG5Z71jUHmGs/VMojhC19JU0PMT61NyTQG+nPQOrOk81hQECR4q7LWTiyLG077NmiG0HlAOTUl2anbZwP4H9pv2RYK4l6sdejCXkY9xEwDGtmdLRxp67gm3y0GmibyvUIq0PXumH/FB7XrkhhFjA6NAF8f7OF8plKU2faxkogd248ViRodAGnk+ffu3tO5+YJ8BZ6llKXXG4jqAeOAcKeeQGaYAsOyl8X+DfOGmdhcT696r+BWAYf/ahUq9/YIouqcN8vGVD9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z+K4GFLAYa7hscPFFxUTLQlNVnCSpxclHSjUbJWB970=; b=Oc4uEoCZgUwdUjQCWokBgOVALyHk0A0MsOMILbHaaQByb8HOJ378fWgIRiMmQ81tNSawXwRnk/4FJIzGo8S3dhjgZMNXP5pLeoDpjemmwejJ6w6bAVr6FYvm/bCV02gjckpqkbmnJY6l9GX2xLFIO3aKIhYxdyRNLPkHlpwfd88B4uGIlZjWZC20gTKLyVIEeBiSLC8EPI1et2RMTG9j7i4+Em+8sI06TT6x9pKcuRw3SUPyClEMeIViooOLfxRBy4YgEnWa8yRPf9Xs1YsUOTWqHQXLX19X0VH5SBUtjlMLEHzU059FkWyCV/FOLlK9sgHC1FCXQcoGTxiRJ6pmgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z+K4GFLAYa7hscPFFxUTLQlNVnCSpxclHSjUbJWB970=; b=Qdz7HYXC14JLnoEtw86T3bJhhgbYy/QzWhqk81FOQI5uMoxvPCVZcPD060djeLLS8FX2vzugLDzUpl+2GuOy5Je0/liUpeYGGF6zwdD95jZ6+Y1wQ5Ebj8tEkFDvLwDnNjCmq4AQ72EDKgTKF2zlxdwK7/DskoYicnbEIXiJULbK5jJF2iOdV1oWlt7XrJa5jXD/scoV+9nPszvDTAPK3wm97Q5VLSVQzl9UsTBUpIznkH2NtHfRNuqgfaMQ2vzPSOSkE0tzi5bN2bsgISchNV8qEDqO8WtfHa1AEPZbhsXcz6WAic1iGooozLeJ3RyEONmfvJMoMCYvxW8SE0Fktw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by SEYPR06MB5301.apcprd06.prod.outlook.com (2603:1096:101:82::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.19; Thu, 22 Aug 2024 14:06:06 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%6]) with mapi id 15.20.7897.014; Thu, 22 Aug 2024 14:06:06 +0000 From: Rong Qianfeng To: biju.das.jz@bp.renesas.com, Wolfram Sang , Andi Shyti , Paul Cercueil , linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Cc: opensource.kernel@vivo.com, Rong Qianfeng Subject: [PATCH v2 2/3] i2c: emev2: Drop sclk from struct em_i2c_device Date: Thu, 22 Aug 2024 22:04:11 +0800 Message-Id: <20240822140413.65369-3-rongqianfeng@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20240822140413.65369-1-rongqianfeng@vivo.com> References: <20240822140413.65369-1-rongqianfeng@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0294.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c8::6) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|SEYPR06MB5301:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d65d099-e50b-4e3e-dbc1-08dcc2b3906c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?S691c6zuIrLLh0SM17WtnDSuS93KyDhiftU28qGiW4vOIYzcC1gM64ACp4px?= =?us-ascii?Q?3L8WvVcrhWeXWoBd9s24LpLKPgV5s/mrLBqhefH9B2MVEPoQNQ3QB9CkQiNi?= =?us-ascii?Q?HJT3tJip5OLTeQzxO2dJWfhYMq0JsWcsGYzwx/yZFKuiUxa1356fQ3DJ1hGO?= =?us-ascii?Q?HzQWntHdpGTfrSnT1MK9jitxl1sbVAeIwAeGNH9+c9MRvIoIxvEDWEJUowQG?= =?us-ascii?Q?LZ7CWL00BHyxJf0CrpUoO2xSUs5zvHDk1WBeLaRIY8N3YOuwhqTzmqtxK0Q+?= =?us-ascii?Q?K+MZCzywVcsPyf+ESCcX17qi/K7BnSWYZ7weCNw3d4HFvMjPPAD0SD1QEGX9?= =?us-ascii?Q?O1mNnQTLPnAdZgKeAUXdxS/ErBUKFaJ9GuC0trt5zZpjsHvZ0gB3lnDaFzpz?= =?us-ascii?Q?di0qWO9nagFMhdH+QhXBX979liU+4iKimteQg5vynF2SLy6nfvxeS2AD7X9L?= =?us-ascii?Q?wuCvkrpFjSN7DJvaxDFOgE2/WHn9U7w2S9uH0gNIX3NPrGeA6lfLyIyP4oS2?= =?us-ascii?Q?XqVkA9iqi7sOcnTrIFcBp2pO2lRJA33lJ8Yy+7HVuEihD7Utw4K3Xb52deHE?= =?us-ascii?Q?7pv+Pq0FYz0dIJ/cPa/D+y+9tTYPue/AnIEjeyFasjjqGTc8QTonM+B07zYb?= =?us-ascii?Q?Q4AM74Oj0yldcGKIAvlv3k2CGN+NzR0BOlkoo7ZStFpdxE0MNISHtJOUh/wl?= =?us-ascii?Q?4hIRKmmR+1eOS85wZHvc5sb5hj5AbSYIxOJqpnkbj/kTiYZuHbkD9x9XW1GG?= =?us-ascii?Q?fsZE220yzP0iXpjFcyDUKFWyIuZ6ukeX8oNgNAALhIIs7HqFByAa3969MprK?= =?us-ascii?Q?gJOA1e6sIOFqDPEwAGXY58yw52TWgito727daGkxCjOSfgX59S/eTIxrWbtK?= =?us-ascii?Q?iZokMn99fyijsAR0lW6bG4DLAaN3RSgJE055p1cOKtYkcXGd4RNJUS5ZnclC?= =?us-ascii?Q?Eb8uL5fkdrn9+ciKok6cR5bsL50wbVcB7VUHsVzQTT6vaT0Di/F79bdKv+Op?= =?us-ascii?Q?cKyeX+mq0EzJtibcAWYmSNQB7avoQgWVpnOhtkS5F2f0i4ZV7I/QQEvs5jiO?= =?us-ascii?Q?qBNnqLxipTuGqanTiHbxVO0fjIY06wtT7FFWDHJSUrzDLoGSkhfc/pJgU1Rp?= =?us-ascii?Q?+3JkLH1TQ7iN6lppwESSfXcq79PulwrLYNLFytTGqgJG5T+ilR0fRRSw1koL?= =?us-ascii?Q?9KpNblnobsHMf/nX/ojxRA9fa7VU8BgRz/+KSyzzv5Eh3RYHvu3i/+s+ehja?= =?us-ascii?Q?CQdWCqSQe39KtIh+9EF9evqZLyksaCoeUG0c4bkkTpihLCC9k6FKW/XJR7IY?= =?us-ascii?Q?izkSsXB0OvMayS+fMg/HLyc45sXC336pKBZXN5SJyKg0sI55r5RcXZN2YCFS?= =?us-ascii?Q?h7DDD8wciPmxDj++8CyvAEzKOFPe0F5oUsQt3dxx46i05bFxhg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ISK2dd64EwZCReI4lUkgwP3xA+lHnWehRNSHJyVBsdLo1VRq/fMGtfInZc+C?= =?us-ascii?Q?NxqquP9N8zHk0vjRqPiceFsnEiVTz+PYHN7LQyjAEGZ2RYCNoJCdq+N/Z+1o?= =?us-ascii?Q?Toqeff8EZpnd/3603VNVoaTg4ipg8wZYn4MpGYuZeMT8i52qjK1vQCXll3Ye?= =?us-ascii?Q?3rnb0tkiWaebcYbVC5NghlLJsSr3cEnAPXFdW91paw+WmAsHke+e9O7CyMRa?= =?us-ascii?Q?+lIaL1vXGM+UvVd0YiaDo4QuPxAX7U6WJMzlR+4bmEYiyW0jQUYBvXkZLv86?= =?us-ascii?Q?w6Mm9gKJFwU1DEyz8x2NNTKKllB8NdQkVzixoZiV4ShiR1rrvsD6Bdghw80w?= =?us-ascii?Q?IhtcCv4jIJdHCd/rqZ889vYzPSSlJvPqGQZPHxd0kaxu7YSGXkxi6ifd5tlz?= =?us-ascii?Q?6OfDUz0b6s46oQmttsLmK7mY7z2SnElm3hwFjMsi1u/7ZLIkdpsqoDG7ddMr?= =?us-ascii?Q?ytRoP6L805ZYKs0Og4wqJp7OXlEN68CzGF5KHFGdbITAKJjT/oHprG+P8H4i?= =?us-ascii?Q?GkXMJ33NMdKB0IYRCUsZcafki1aMAFbo1bY69nXmCvbvm/ZPhQGKOz4Qcy/L?= =?us-ascii?Q?HLGOnBSWSN4BASCyE1A8sbaHyd/IU1musc7kwwA+hfRNpUwWy4uyTXCSGous?= =?us-ascii?Q?cxOOy3ol2HUwbI+cJBJshTFIt/+0OsbaAqFjqxa8/A8F5AhWLEJlvtjHtc/X?= =?us-ascii?Q?myTkMOK7YsiGseFygIqfPvBz72gHKzGBVsUoVZWIJDWCJzEk7TPWLDw4yF/K?= =?us-ascii?Q?p52hLiezPZBivg7pQznrffZsQBhS+SiJy8fVyT7i3ansr1jahXYUWbRUmlqv?= =?us-ascii?Q?223JghR4H+uWp6CW/vHwZfJTSLfh6RJhiHtusHn/5fxeX6svx8K5LOTHTR/b?= =?us-ascii?Q?wjfq4vTBqGsUYsF1sehJ9dug5e8PBKqAqtdvGb6ZeZYW7O2Udtllm/6oGZ+8?= =?us-ascii?Q?a9kefMZlZHTS7RphRSQxQp5c3hCrSsIcph+2SO2R8kiINmKPYF0p3gZgu/55?= =?us-ascii?Q?QHVQ0ewNLjbZTHFy0nO1gI7iKWDWiFzs3xbvIuXBlR3LhhkLg6pMk83I9+Tk?= =?us-ascii?Q?M5gToUWGzoyJSr4SeaxPl8PQTsH8zOvdxBj2jq75VYsvPQS6GSeyxcb2N0/l?= =?us-ascii?Q?xGVkR254zdYnuMRT5OSFI24dtg6MOT9RaihfFGDm2lpIKW+tFcFZI/JFmGCU?= =?us-ascii?Q?QcP75ewuVR+Px7vVpbiNlhXrJwoB8e0ya5H7LB1uCeLkyKDQGSAOMBh7+AKw?= =?us-ascii?Q?qkBDQlShsdLuP2aU9uDVuwM0edllP34tEprT0mCPHpoyLkjyabZ5kIi9hL2X?= =?us-ascii?Q?Xk7eaYeiOuthB0PmyN7hreq3HKXlPUBDjpeXmt6TVmAsPAhkzGVtxn4tcXtz?= =?us-ascii?Q?kbcQmDf6RDhCtnXPtIeztu8L/eBxjvOUJttHbx+DEN7vmFWINV+2lgdpu44+?= =?us-ascii?Q?5dd8gQtRiaWNArkAoNOQRtph5Q8kG0G01yMRY7QcyEyhNZ8xt7NxyMo7h/Ag?= =?us-ascii?Q?clf1bV3W+Hb3zoWR16WNW3ciG/07hHR61QFRuhUPKAczVxM58w4wwtvIAQJ2?= =?us-ascii?Q?A52kXM1qzQg+AkWj6WLg+CAH3BrUjhO1+gop2C7C?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d65d099-e50b-4e3e-dbc1-08dcc2b3906c X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2024 14:06:06.1852 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C8OjlsEbqyJbw1rt8HRl+E9wo9b4vM3Lg+vuY2rPqNnLHhiMIPtYaxcAJw7iVpi/xsNIFoiYzWIvgxYy+Hp6jQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5301 Content-Type: text/plain; charset="utf-8" For no need to save clk pointer, drop sclk from struct em_i2c_device. Signed-off-by: Rong Qianfeng --- drivers/i2c/busses/i2c-emev2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-emev2.c b/drivers/i2c/busses/i2c-emev2.c index 20efe0b0cb85..2a5d9d658246 100644 --- a/drivers/i2c/busses/i2c-emev2.c +++ b/drivers/i2c/busses/i2c-emev2.c @@ -67,7 +67,6 @@ struct em_i2c_device { void __iomem *base; struct i2c_adapter adap; struct completion msg_done; - struct clk *sclk; struct i2c_client *slave; int irq; }; @@ -361,6 +360,7 @@ static const struct i2c_algorithm em_i2c_algo =3D { static int em_i2c_probe(struct platform_device *pdev) { struct em_i2c_device *priv; + struct clk *sclk; int ret; =20 priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); @@ -373,9 +373,9 @@ static int em_i2c_probe(struct platform_device *pdev) =20 strscpy(priv->adap.name, "EMEV2 I2C", sizeof(priv->adap.name)); =20 - priv->sclk =3D devm_clk_get_enabled(&pdev->dev, "sclk"); - if (IS_ERR(priv->sclk)) - return PTR_ERR(priv->sclk); + sclk =3D devm_clk_get_enabled(&pdev->dev, "sclk"); + if (IS_ERR(sclk)) + return PTR_ERR(sclk); =20 priv->adap.timeout =3D msecs_to_jiffies(100); priv->adap.retries =3D 5; --=20 2.39.0 From nobody Mon Feb 9 07:57:14 2026 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2074.outbound.protection.outlook.com [40.107.117.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A843217D354; Thu, 22 Aug 2024 14:06:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.117.74 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724335575; cv=fail; b=BGLJ1hPhfAFYquUwsn4SFsPAJxI+o+Qb5WQmKuSQHO32yDHHJAYFFmWQ4rHG45mywhIpWkQQje+4ErD5/k5vfnK59uGqtQaCZQVk+FzazSGC1i7wnnZibcu9Gz10SzBk81R8tWybl2wF3WdwyISR8/SY0VIjMMNem3klZ7uk4R8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724335575; c=relaxed/simple; bh=vnalnjId2K+5bbr4HlD5b3d5EsYOi8iZr3cfDy4oQNM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=pGzs6+E3SdKHu/Blu2J3SVFcc7OmUAP+b846xUj+5YN1ua5wFsPPi3c6XZcpnlDJ8RfE++m6GZsq3muZLlx9+mJDCAb0dg+bsHqgGAebPPScjm+hTqRRj/W22Q0ZMHGn4AVDaKSJa4yguikijtde9XDQeLmWD7PC4MgZDiERZQ8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=H3eC/EH2; arc=fail smtp.client-ip=40.107.117.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="H3eC/EH2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QSIXckn5ibmnHOhjIh0ACrf2JzhQinQk8SSEX7SR0Q+AdCA6fm4f0jALPMJP6GTYiRzJAOXgHy1//QbudxOJ2T0ZgDKOJMHseDQc/XbZ+LFqJ3Aj76m55P9hG33eXzN7TTaPkbFHKXsAQWFkWzqaupqbXbaDI5JUsQ1udqxjpZWlM+5qze26Wnq01HPYnxrHht7322eqgx2cM8ywrvpzszE1nQQ1IUTNdozeR6B82tE3Ckh2yK3fxJ5m5T5neiSvhsUKLDAn2bkC1C3aZA+mkMRyNCNi3zk7+U2/BxMtcjHnKKM1gJaZ/COyuV2XOR5FRJki5BDJzmRwY8MQ6/3jOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KD3mAZ47w3g6KpUQoAKSv2PDeCM4yshrE5QmLmclw4A=; b=fsugDLg7CZTP2kBXFmHZ3JN28QAp2JiH+UETELLqlH26Vi9sesGW6Mst8Pv3WNJ1ADPI6N9Q/3eXKMWfswlruTF3uX2zLfFrDLJ5qg2QNqKa2r4QYaSkTjM3o9zngj36w4Y76NQTHsR+o40vn5D2tAoJB66b29hFICDWUuk4XLPnmi0a3dLZubSTP2F52NbrHwSIHf4xO1H8gTUn3MDF7VnUVccdAmknC2zFPqv5PL4mfTQ7Bj9vQsXrfp1983hq3zuydTtEl8tO3pWUwje5uDltyD7JzBeijJSakXbsehLI16EH0JNhehy2XWPw/xe+S6deXKBmIOgDv2y3No1BVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KD3mAZ47w3g6KpUQoAKSv2PDeCM4yshrE5QmLmclw4A=; b=H3eC/EH2zbrQouLkWPiGni5jsUzbh+QzvJ1Mu+JeCVlllPOalHlY+5ydoyx+PiMbhmDIQe9388aaywfgJcMecuO054fkaqiOtc2LQMYZW8JPLWE+RP1dhTvzd4AXxKImUWpOk+lDeozHOTE/Uz0H23BmAUsqrryCHtSW55fs1FOKlK++DZrhGIYf5KEd6e67c+SN/lf9ybyzyatiAuS5VKnixEgfBbg2QapLPrbWusCRCjHKCOG22TUbbBlzD2/nZhPhKnq2uS8G/8xvtk6Pn6isIXZXDISQ1lkfniaIfMRXksh+BsygRfgXeE2WJZop6Nv9vujuPZwIrvUBktHZaA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) by SEYPR06MB5301.apcprd06.prod.outlook.com (2603:1096:101:82::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.19; Thu, 22 Aug 2024 14:06:11 +0000 Received: from SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666]) by SI2PR06MB5140.apcprd06.prod.outlook.com ([fe80::468a:88be:bec:666%6]) with mapi id 15.20.7897.014; Thu, 22 Aug 2024 14:06:10 +0000 From: Rong Qianfeng To: biju.das.jz@bp.renesas.com, Wolfram Sang , Andi Shyti , Paul Cercueil , linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Cc: opensource.kernel@vivo.com, Rong Qianfeng Subject: [PATCH v2 3/3] i2c: jz4780: Use devm_clk_get_enabled() helpers Date: Thu, 22 Aug 2024 22:04:12 +0800 Message-Id: <20240822140413.65369-4-rongqianfeng@vivo.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20240822140413.65369-1-rongqianfeng@vivo.com> References: <20240822140413.65369-1-rongqianfeng@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0294.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c8::6) To SI2PR06MB5140.apcprd06.prod.outlook.com (2603:1096:4:1af::9) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR06MB5140:EE_|SEYPR06MB5301:EE_ X-MS-Office365-Filtering-Correlation-Id: 4978fd37-006d-4e2d-57ac-08dcc2b39350 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aWlVKvXpTq3tjWTJWvN9PxtiMnWeitSxCgUseovHUKYyqINJbvGQ8u+99HmS?= =?us-ascii?Q?DW55EubMA9CSx/UpX3LjQnY01KWZ+XXfg71fnMJ0vB2Q2xkqtUrXVksbK1ct?= =?us-ascii?Q?VKJgF/9kbqPqIA8xiC1IeN91MPn1lw2/sJTOMKJIX1/7pnFkqz9/YuRER0Oi?= =?us-ascii?Q?DCt5Dy4LMrSYY27It1/GMqTQUT+unamRT44hxdRCgKPcYu+UZI20wcgzBENn?= =?us-ascii?Q?+lIDXdqbp8vWp70+p+EvUi1NkSqOQmHHTi2x/qCNsz07btVViAjB+9BQo14I?= =?us-ascii?Q?lzKI5/OTGip/UULjb26+sRy/x55D942e+y6qJ/krQUHUo5Abg7pavhKNuRuM?= =?us-ascii?Q?ixKjL9uXy4NsMtJvacPEho/R8bxDiYItgJGj98iVE14MWr71PFK2msGA4oCv?= =?us-ascii?Q?EXgAMJRU0VyaD8Qr3X1tYZlKtvccCkyO7Q8uq+1XD9hKVOroFVLwbSETYMjx?= =?us-ascii?Q?NOw+TVjWx1plyCkm3kemgGxTQXcrr+L5nnnkDpyK6tUvtWgikSZDBEhh3qqA?= =?us-ascii?Q?WBs2C73qLLMg1b+MrlMVvo1t9al5e1RAJwJs4K64u2w51QadrW+DQC0vNiJg?= =?us-ascii?Q?EZSteOO7HgCRgswcXPsdncnpea2sOAPOqnt/HsxMlPH4l/53PBYOSMtWEVGp?= =?us-ascii?Q?H7PNFTiKbIKzr7dunb4C7bpmotj9QxxEX6riTn5FkJtCfwyBVRnugx5mzGc7?= =?us-ascii?Q?2Vmc+jGrmTTAoNeB/W+/mNSMxKz+ZPLdXXDyHNYZ5gFUrifPR6pv2OY+Awia?= =?us-ascii?Q?fUZRvCQTfvVYUWCBQj5A6L1VIYxsZZHk5z3qPTks9RXcorz0VfC3YxmqzS6P?= =?us-ascii?Q?O0eTbvIn2bbsQ6AqYZsD6X+lZ28WrOhQkh6ZANtphPSkzlf+tT12izRtNUDA?= =?us-ascii?Q?D1Tv6E7DtcCxzsXeSNKVbbrq0T1A2lmIP0IKmd0ghC4rWzJDh4zKaOsQWtB9?= =?us-ascii?Q?rYmko1dD/lNokP+PBmzyfHqQbn0KqoEqmrQEioDYIUJnKT665Oe1Q+sGA0WW?= =?us-ascii?Q?W6jTbzSpkJdewb0lLUY0qWohN48zJgY6lZrSGMf8NclMqya3hx2Wb+HEqZxH?= =?us-ascii?Q?4mhgKXGvUTbgbyiDMGTh5LQC6S+2fbwoC7yIlVi3bLgVn89TT3de3jrZTAIv?= =?us-ascii?Q?vyxPz4bCAuJHlg1oq52l6CYRATIhTUelgV6pP0KPlMf8eZ2OeGjl5dnZ6U1x?= =?us-ascii?Q?ziOeYvGCoOg8Xh7lHumhntZJqC4FsLczEvnVy7OPeR4qM/lVD52QkQXfMYba?= =?us-ascii?Q?0u/G14pqjKfAQ9F+vY7O9/cNwKIOB73jTpi3PRgFyuoaKxkSI+eAs5GVV9wo?= =?us-ascii?Q?AOZQ81FTrB9XyLlwMXFl9gX6/4W+o5W+U++h1BI/PfEDiGBUxuK8+vK96zqT?= =?us-ascii?Q?+4F2DppfMHePQJ5XcgSgBdRNYgzjUAkpIZCRY02GIdTFzkL7sw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR06MB5140.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hf3qwd0W6O6qDJojWcq57AvM12BRtcYz0T8Avt6mMdE2096dsbIWz4p2YYG+?= =?us-ascii?Q?Gc5ypN3lu9iLVsXWDBs4pmeY8z2DeFI5XMNwM1zWegquh9tFske09TdRPPVP?= =?us-ascii?Q?e6L2U+aPsSv5luap/rXeSQ+ElM0QbrZEL8lmnZPsLiYmc86/JRRSso6XPs3U?= =?us-ascii?Q?rhA2ya5FBq3gg4hdYh9EXyyHubxuSGIRzYkig+99j51kwS3Y2VF+NQ4HbJoO?= =?us-ascii?Q?38CEP3+E3ib7BArFH3/+c6IA9RtR4MtyHezUWcniZJY1heZUv11yz1XuM9xo?= =?us-ascii?Q?RRj+zF118Cb3me9VqlhUeaSisyJ0l2mEy+ByVesPcNJqekTu9UoTIAl4Q/8b?= =?us-ascii?Q?mUXTqWFqNQr+iWvEEkMZDOUmZsd0qTw2RrcxewoCQSxbe/ydaxf+6xRWdQC+?= =?us-ascii?Q?fwBXiGCugxh/fOgTCJu+0jQj715JcUyddbm+NgheUKde0ejpGvwfSVx/fb2K?= =?us-ascii?Q?L2X/AmcxI2gwgh5oMgvWsAha33eHSzDw1Z34JaW5p+vKzZuNWw31pW5rYdA0?= =?us-ascii?Q?oLmSaS7NR4viQg5YICHwVJUUZw4jNnxdxLZuc+g8t1ykv8xknH5bzMLjJHCk?= =?us-ascii?Q?r64Z4Tm1Q5KKXRdbzG08gCiZWju0MwF2OsVhZEKO5NB+3eLEOlL1EjOsMrax?= =?us-ascii?Q?4AsB9BlAXSmMipodUITDh1AuoeN0kDo7zirnbMZ14suFvagzwkX9e03gQH6d?= =?us-ascii?Q?F/2q6QwnsN/FpDGR5gu2RLDBuNZF1yXcRECt9Fl5EXlG50kHJlgqCBSR0ysk?= =?us-ascii?Q?L6dwduQK6fZ2tfN+slWkhFy3N0rr/NRNLQyWtfY2i94PMte+wfsDug7gr/76?= =?us-ascii?Q?sugL+jE5epMQkiwxN5zKKQk++aNQSEiDMwl78rt/pH4WExHk45GGQ7/emyVt?= =?us-ascii?Q?vrcSJNoaDjCSCqTMYip6zZ7mAGPuIzN9jk8Mf+LV+kCnphAm6KYe8p6WfpYP?= =?us-ascii?Q?zxBhqTCU722oYgvq+2IxcoPZbxL7SPg5QQvfZ4dxhfvy/ux5IF43wx7WNlvR?= =?us-ascii?Q?DL15/NSw1sxh447jHg6M8Ff3Y6AzRB77wzrttPOUkysyr1a2hvr6qux64XPJ?= =?us-ascii?Q?anXwKkxCcquAttHkuRys056GN63aI2wa0BQyXRfjlUNfR2x9Fhbf6UbWn6VD?= =?us-ascii?Q?kFWK20MY//KHAg69YjHoFSvBlPgkcY3FCtYOar/WF++AlBmmDV6ZqjL630Ug?= =?us-ascii?Q?KyMnmKjTWVp/k6OduLKC7LvkoHPcmlfpbfRq4TmlmJqoCrdq6zDdey/tDAU+?= =?us-ascii?Q?tfcic5Kdv1nam2mbbvd6L/0XquJwwlTgrQPIvmWUEDoW26i9ZgPaVnkjt4jh?= =?us-ascii?Q?50xuPuFAKAuwjT7kwkkW7/fmc1TK8v7TLrpfSG3+rIOFfztWKuHk86Vjd0CU?= =?us-ascii?Q?7mfMFl+qdEFJM1YHuVRxGxQd7ZGff49y2aqaZqU+D/EaGUIhgMbQFt6NcW2o?= =?us-ascii?Q?ecsjZPaaLZTE3qg9HdXFV6mVzJiKTibrs6suIxzm9FXSogscfG9lz25ylh5v?= =?us-ascii?Q?pXjPo7k+hDz2pFrzJWsa0bLh/FfjoRFOIxPQ23n2Sztm3Zt+Yc9JQtXJP6AL?= =?us-ascii?Q?Vy0DCBOZ/3OYi2fsBwaum8ZmfH9cGtZmUCX2mZpZ?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4978fd37-006d-4e2d-57ac-08dcc2b39350 X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB5140.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2024 14:06:10.8681 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oZ9fa7wmpRjRBUmi5BEK+eicE9uGzfaJRXcUvlEZu9HiFyvEJRE4sQdebs3GM447Ueu8pbxb6hUosNDWIGwNrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5301 Content-Type: text/plain; charset="utf-8" The devm_clk_get_enabled() helpers: - call devm_clk_get() - call clk_prepare_enable() and register what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code and avoids the calls to clk_disable_unprepare(). While at it, no more special handling needed here, remove the goto label "err:". Signed-off-by: Rong Qianfeng Acked-by: Paul Cercueil --- drivers/i2c/busses/i2c-jz4780.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/i2c/busses/i2c-jz4780.c b/drivers/i2c/busses/i2c-jz478= 0.c index 4aafdfab6305..f5362c5dfb50 100644 --- a/drivers/i2c/busses/i2c-jz4780.c +++ b/drivers/i2c/busses/i2c-jz4780.c @@ -792,26 +792,22 @@ static int jz4780_i2c_probe(struct platform_device *p= dev) =20 platform_set_drvdata(pdev, i2c); =20 - i2c->clk =3D devm_clk_get(&pdev->dev, NULL); + i2c->clk =3D devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(i2c->clk)) return PTR_ERR(i2c->clk); =20 - ret =3D clk_prepare_enable(i2c->clk); - if (ret) - return ret; - ret =3D of_property_read_u32(pdev->dev.of_node, "clock-frequency", &clk_freq); if (ret) { dev_err(&pdev->dev, "clock-frequency not specified in DT\n"); - goto err; + return ret; } =20 i2c->speed =3D clk_freq / 1000; if (i2c->speed =3D=3D 0) { ret =3D -EINVAL; dev_err(&pdev->dev, "clock-frequency minimum is 1000\n"); - goto err; + return ret; } jz4780_i2c_set_speed(i2c); =20 @@ -827,29 +823,24 @@ static int jz4780_i2c_probe(struct platform_device *p= dev) =20 ret =3D platform_get_irq(pdev, 0); if (ret < 0) - goto err; + return ret; i2c->irq =3D ret; ret =3D devm_request_irq(&pdev->dev, i2c->irq, jz4780_i2c_irq, 0, dev_name(&pdev->dev), i2c); if (ret) - goto err; + return ret; =20 ret =3D i2c_add_adapter(&i2c->adap); if (ret < 0) - goto err; + return ret; =20 return 0; - -err: - clk_disable_unprepare(i2c->clk); - return ret; } =20 static void jz4780_i2c_remove(struct platform_device *pdev) { struct jz4780_i2c *i2c =3D platform_get_drvdata(pdev); =20 - clk_disable_unprepare(i2c->clk); i2c_del_adapter(&i2c->adap); } =20 --=20 2.39.0