From nobody Wed Feb 11 20:38:18 2026 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2071.outbound.protection.outlook.com [40.107.255.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DFDE1EC0DE; Wed, 21 Aug 2024 09:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.255.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232547; cv=fail; b=Bex/5pzPsExkEwUJf9RwZXd2iAEnFoj/S9V4XERnKDrfEdflaFtZzkI+6/CavZqnEM2lIV4xoZ6xkszvWM7s1rzV8LzSB6DXjMUWS5U/uyhfqRhZ+24DSJcyNRu4dpI6j4OWcwGB8QQLXX4OECRx1SvaLSbUpNwsvbgPbBteBVA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232547; c=relaxed/simple; bh=80wW6waMnLvB8XUFokLObOKYKZYA3XlQYx+RC0BRh9Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Te83rG0aFTm4MGG5s+QuBgt2qAspwpCPn3EvskSs7h4HIcIEQWq6YTqTjq0fNsyVbzC0u2uA12XZS/KGQlxm9dyKVu1o3NngFvDSz9f8wLoqTCoSUaYfYm9BCW0Kem/QCW+fuV0fOHzsk9LDnwMZPxEwHLunu3jyF/8pztu8U+4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=iJ43O2w2; arc=fail smtp.client-ip=40.107.255.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="iJ43O2w2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=H1jzWcr4BOcTcp58YvgyUdN+tDDk0zEUuhuCacwDdRWsUIPyEa6bSv0Q33z8JILk+ATYEpAV7FpIbuuu+fdEM4+cSGsThnmwhA/YXkEH9RRUl6CJEJhLzki+iXosyA/MVIYnT/6nrVEIRfP3Kb8FAr9/tgL1myTGOHtxfeJtySoDbrDOtWCM7cSdkYxYDei8+dgDHsB943oDi0mopM72ZrxVyQDLFFS7/9kdeGkHWZ4doP6TRNp2OAtmBxw2md43CEerF2r9eo4ovebWdA9C5acyrz5QEu/hVcybPXC4b25EEIu8W1LotghtBFfo/AFDxDTuncgXpjc7kXNqpoESgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iUjfxrEHEzvDkyc8U9vvSb3GanL/n92ZDLkSD8AIFWo=; b=kOs0XrYKMDB5X/3eiH4XXu6lSO2OvxvtxXm31nRmV1OQuSa1J8y77UdT4JknHmBkW5ANbZvs/sLzsVgXri522jsZLpEp5zPxiADo1t0ZwVdPdHK8HC4t2LHubClL6KMVPd8SgufZHmFpjMsgN36PyHz3CQw8ZcycpMPfAYDeNrli/0XaS1T1bcUu0PXMtz9eCn0UfVEAGJr2tH9w1ClRMonla5jfVaXQhCQVRK0cG/ZPSJLHpRdVTUCqpzwK8952WyVp97i7bnoOEVT9jFP9Sy20Fu+w72ERFNsSphZ5/MIz1BBH5guHkWPECF7TgOHQFXy586q8gUjrHEjknxYkgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iUjfxrEHEzvDkyc8U9vvSb3GanL/n92ZDLkSD8AIFWo=; b=iJ43O2w2oDwzczUYVtzRMntjT8u9d4Vx6DVhItX/d0dO9SKV+FPYGsFOpnS+H3yy/aArv2aNDfzMHkv3oI5VuXsUMA2C+HsDPrFpHJmO5FQRmHQeLKucJJc2wEINzVOD+FH0+opdGXANSkw0Xq8f/OAsW7I/3R9L2nyUqoYQjPZniOkYCFqhD6QOKdIYjBDxalIbQWzQoKAEP+SSulM/2buRoaIoaw+j0pmb3Flv9eV7cb+aGZrYkTAJptN/x03h9KuMrurBErFmrJNpVE/Mc3cYizTULkFzfsxwAfS8VKJd0q9a6+LsvhZ2PNXmUC6Euin+3aSv/NoKWiI83HKnmQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) by JH0PR06MB7199.apcprd06.prod.outlook.com (2603:1096:990:99::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.22; Wed, 21 Aug 2024 09:29:02 +0000 Received: from SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6]) by SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6%4]) with mapi id 15.20.7875.023; Wed, 21 Aug 2024 09:29:02 +0000 From: Liao Yuanhong To: alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Liao Yuanhong Subject: [PATCH 1/7] rtc:rtc-at91rm9200:Use devm_clk_get_enabled() helpers Date: Wed, 21 Aug 2024 17:28:40 +0800 Message-Id: <20240821092846.20138-2-liaoyuanhong@vivo.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240821092846.20138-1-liaoyuanhong@vivo.com> References: <20240821092846.20138-1-liaoyuanhong@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0001.jpnprd01.prod.outlook.com (2603:1096:405::13) To SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5576:EE_|JH0PR06MB7199:EE_ X-MS-Office365-Filtering-Correlation-Id: 9eea1b28-84cb-464c-b2f0-08dcc1c3b17b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7Rgddbk8gGuJzl15sneMdakKwHNiNZH+rcwYBW83VObSIoN8crTXiJvS+FTW?= =?us-ascii?Q?ISk5kYtgzN8kFtDhjqz7TvLou5iUJStpGYTvA8We2yXtud6H7gC+adpV/uIF?= =?us-ascii?Q?jfmG3v1jlGnziPRLM1/f0FyhYCNuzE6ysv/AfeQTm+91e2MzXa0feIHmKGyC?= =?us-ascii?Q?9GxagHPyMIyJmjUPiCtD4iOVpy4ZwHFDoIi+RjfGGqXN3AYob4ub88hVwVYz?= =?us-ascii?Q?rkbVZej1vpwYg6dhWr/6tc5OblTi5yDjJpI51SVZby/DryyI7yNrz6HxK3E+?= =?us-ascii?Q?nTvQ20fHXQmVl5T2iMkYSWpuzAkuacj8otK+6acL9gmMU/5U1KKnZeNCXiIu?= =?us-ascii?Q?mNnBHI1aLAbssYWBZ5jTNGYmusVMBVh7qnTJceqNuBZ+XsqUlh3muxWG3Xiq?= =?us-ascii?Q?nEskfbWuVHo5TIIUvf/0QSBR2MzVtAfwDpIrT+PnDuaoBu9QoHWtds43J7gI?= =?us-ascii?Q?bZbYAB5Ym818bOEFN6kcpfgUoRy/Xr7xpscGBU2XvuJtlIFZllkDbqeahIlF?= =?us-ascii?Q?d/bSutL9VDopo3u/OGt+4ihaxMlAWTWXOJV8zplQtxyi44spTbf+2sWm6yLo?= =?us-ascii?Q?+Zi/OU6QmPKc6mQEGIeZS4qczdltu2uDEIlBiPcO1qRgUuq+nem/Jmcxn3CQ?= =?us-ascii?Q?CCbPfTNL8Xl2+im/hl6HX/ZNWSk8zJmuU5N816HyqnyHy9/6Agwu0kvKs2Zd?= =?us-ascii?Q?fYTNgxGlU/1j2a0ai27GkmrfaFwt1HLQHq8InwBRiQZI3Nj7APCezLFOLmQX?= =?us-ascii?Q?F3GKC+D/WnwLnAGHmZt8WV5jKlPIxqmMSOJ6fEVY7HqhsWyiuMuBBxTqUa0T?= =?us-ascii?Q?IU/+ZtdIk+2X4hz65Kud16LUvN32cs7vKxetTLlSK+kzhQlhEetcrzUnuZdv?= =?us-ascii?Q?w5kkmfQ8FZVg2aMjjaNMNvGtGeDi6s4+D3PixgGibMOOJY4fdNH54BS9FCIy?= =?us-ascii?Q?xmHqrMTMPRgv3dnJz19hgQ8EJrawesSPdWDf1BsvV0dC4hR/ybaNCORqtduZ?= =?us-ascii?Q?GxB2HEDwKcynCjMbdH54wezNkw/+8pzwXos5xMdVAPFriZdRt7jXmbekl5b0?= =?us-ascii?Q?Nom1Svd+It6NpjQJA+40kMhxm6WdSbls67DaXiOZV3bBsA0SlZEsz+NyThNn?= =?us-ascii?Q?b9qtzMZLEAZHLH7KOCTcH7RytndmaR3EbxzwxdRA87YFydTb3iBnnY1RC4rA?= =?us-ascii?Q?8M0uXbgJQH0r7X277vUMfXwuWYNHwD8fdw55YEzapZLOEtM8VrQQRJEQLQeB?= =?us-ascii?Q?ZrVk7rWieUVd6eaNQzQv0dQyVanbHigJUUB0/fddCk4dtg/sGncv6iOhudM7?= =?us-ascii?Q?jIwYXrfLqdut7UU5zaejHvle/3vqwpVFC+0Qr6IqRW4q/H4O5Umv0o3ui4RZ?= =?us-ascii?Q?oVCI3US9HPImu7xwQr+we0jBirqtdtsaaLESZTP4EQJTWPVkyQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5576.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aJq5914ugiY1VFgZBiPZ5e5EP/fta9O4VQxt7sLH6XtjJEqLJ4nysvLMJEXD?= =?us-ascii?Q?apwfGAdHsCppyuQvBRDMcLHcqM6JBMNLGYmeGJB+CBHl7Ue0v3SwT3i4Tmaj?= =?us-ascii?Q?qnrpyJerb/mSF8iWZAjM9BUJCctWlU8zKkKmlC5ZrwlJ6QNWRiKsea0IeBtp?= =?us-ascii?Q?wdmPOCTIcB0e/Hs/r7SPEJ43k7zb1PtmlAu9/tpheFxwPKCg67/IldIXFeaW?= =?us-ascii?Q?NX6jB/XPcMgCfmKSsGGJjy82hlekgvwcZHItTGpDKzuYW+2jI0Eh2C3fnTTz?= =?us-ascii?Q?qsOVfrCmDhgs+N248lx9T8HGtEMEP7UR1HBpaUTnavQEKZJg2iqdHJJCTmpg?= =?us-ascii?Q?RscJGfAhKrB3KnnnMX4fu1D4BjGzXf+Zn0zNPkXg/fnSHr2+npi8kIAPSKwH?= =?us-ascii?Q?U9YQ/2Hkn8JLaTHmprCY78BB029m69H3V0++8gPa9PBJKQfdX9kJqMrpXs/h?= =?us-ascii?Q?4KymfVohIfRQqRrDidwrxKSydGYr+cDr3sa1x77NxWnK1MvYpLXIGFjfOpKZ?= =?us-ascii?Q?N0N7f/NoWE98n4FH8Rf5KxWx44UwzCd55CA8ZGogszr7vuUzc/g7uE9cWeeJ?= =?us-ascii?Q?lyZSO1lYXMoLs2+hN3LinXnsZdG2OD4ZJDy7hQ3mIYflj1ONabh5KAsYAt6R?= =?us-ascii?Q?NQxPgv/2sKrMvyR8yIbrJRKCsJ8UcoP4zdIMH9X1dkOUaB6mBRiic8nf1fiy?= =?us-ascii?Q?HZz3hSZqg5edgVmkA20XLPfK7IGbijF5xUbHKVHFpHUGFi0kgLB4vEyQJyXE?= =?us-ascii?Q?WA7rn3MeJPStVZQgQX0WXzDuGudrjfsV8yXVNa9TdCxnvYfJGSReJqvn4o+l?= =?us-ascii?Q?p486WAXML6rloX6jKXqL86rm2ylM/658xM2hd1rpX0yNxdU94CQcQfY21a/R?= =?us-ascii?Q?dTFcmK0/9harK52XyWqDSASS4Hwv8/BJLcejnUgXM+buf+j9FjUXwINVZFVD?= =?us-ascii?Q?jBXXA3p50M/hTKT7KBbHl+Vyp0wAIGCXci73ehdatKJQSKsD+lvEyjaXeHAa?= =?us-ascii?Q?pTYcmTgatsTusEK4lvOn8UDu+/wo0i680aFqJPIG2l5rrshXrAocuLhrD7xm?= =?us-ascii?Q?3HhoLhw5f8wC1Msh5xia8iijv+SEmlwUNnh6fyTNEotjjIC5VNLQYpaCyWOB?= =?us-ascii?Q?hUKh2ifgy1drPE6GXCUAfEXyCWomw87wqjY24l5nvZiQhPO1kPx/wIPKIsyC?= =?us-ascii?Q?SLBqdTFF15SykSufRnbYQY1kvAsS3b3nWs617w07/ETFLjkjCCEfUkTw6JgC?= =?us-ascii?Q?mIxWix0l1ydsWx5DyVk5c2ocZOqVPKLVmqx7pLJLObZM3f5tkr4wwC5CmXtv?= =?us-ascii?Q?GkWSe+SdkNqL8q3X23r0Rpa2zv5q4B2VPCETX5GDgs53wQxvblT3rTk2rWPC?= =?us-ascii?Q?3XlQbm/Dwi4pd213IruER1ziAn+Urlhrf9tEkzb7SlbV+s4RJc6NiHlt3GDq?= =?us-ascii?Q?e8b2muD0y5pwglrP4AM5DbezNn8MFuuC6xYqPjj2NNwuU20UFb4hMDvKHAm2?= =?us-ascii?Q?W/2bYOG149bDW5kqY6Psqr5cEWDUlHG5y3jHEmgcJ3/K88FHBk2UNuBpSCoB?= =?us-ascii?Q?hoxxZMORbTQKPhEv3E3VCZ/Jse1kfLy+OQ0Gn6y7?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9eea1b28-84cb-464c-b2f0-08dcc1c3b17b X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5576.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2024 09:29:02.2389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bihBVj3GVfr4QWjZ1pD3lcGndvpQubX4WNoFW5j7IVixMaOF/aEL19SEzhhpUls72GcQCohXUgwfwTQbab65Bw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB7199 Content-Type: text/plain; charset="utf-8" Use devm_clk_get_enabled() instead of clk functions in rtc-at91rm9200. Signed-off-by: Liao Yuanhong --- drivers/rtc/rtc-at91rm9200.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c index c16fe711a0d9..81b2556930bb 100644 --- a/drivers/rtc/rtc-at91rm9200.c +++ b/drivers/rtc/rtc-at91rm9200.c @@ -498,14 +498,9 @@ static int __init at91_rtc_probe(struct platform_devic= e *pdev) return PTR_ERR(rtc); platform_set_drvdata(pdev, rtc); =20 - sclk =3D devm_clk_get(&pdev->dev, NULL); + sclk =3D devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(sclk)) return PTR_ERR(sclk); - - ret =3D clk_prepare_enable(sclk); - if (ret) { - dev_err(&pdev->dev, "Could not enable slow clock\n"); - return ret; } =20 at91_rtc_write(AT91_RTC_CR, 0); @@ -521,7 +516,7 @@ static int __init at91_rtc_probe(struct platform_device= *pdev) "at91_rtc", pdev); if (ret) { dev_err(&pdev->dev, "IRQ %d already in use.\n", irq); - goto err_clk; + return ret; } =20 /* cpu init code should really have flagged this device as @@ -539,7 +534,7 @@ static int __init at91_rtc_probe(struct platform_device= *pdev) rtc->range_max =3D RTC_TIMESTAMP_END_2099; ret =3D devm_rtc_register_device(rtc); if (ret) - goto err_clk; + return ret; =20 /* enable SECEV interrupt in order to initialize at91_rtc_upd_rdy * completion. @@ -548,11 +543,6 @@ static int __init at91_rtc_probe(struct platform_devic= e *pdev) =20 dev_info(&pdev->dev, "AT91 Real Time Clock driver.\n"); return 0; - -err_clk: - clk_disable_unprepare(sclk); - - return ret; } =20 /* @@ -564,8 +554,6 @@ static void __exit at91_rtc_remove(struct platform_devi= ce *pdev) at91_rtc_write_idr(AT91_RTC_ACKUPD | AT91_RTC_ALARM | AT91_RTC_SECEV | AT91_RTC_TIMEV | AT91_RTC_CALEV); - - clk_disable_unprepare(sclk); } =20 static void at91_rtc_shutdown(struct platform_device *pdev) --=20 2.25.1 From nobody Wed Feb 11 20:38:18 2026 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2071.outbound.protection.outlook.com [40.107.255.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EECF1EB123; Wed, 21 Aug 2024 09:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.255.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232549; cv=fail; b=aGFhUm3ixIpQ1Fn3uyk4eADa0PKlstlA0GAKBfmDE54ApLDb5rRHH1r5tjGEE82+/uhqfi7wxnBw0GHcvN5cZNUkZxRQ/IGHlri0l/AuXyFTaIXlJWAJ88vjilm2/xalJiF6V1Ex/P7LjRVdhDKHes05+m/YzH4t41hxEvN0Ajo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232549; c=relaxed/simple; bh=IbNEFCZxiqwZqn/qeK5t2lXr5khkPyJ7Ke6mq16MIx4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Ka9Rbq5tpzkEyOvEbvKSHgnI/8F93laF5/uCxbCcFlQG5AlRr4R+EvhoM6WKN63dTEyqfeN4H13b7TAqPXKWJpeknZGFBouVXff1soaYc0NcfL+1ZxgCRcwuo2bwxugUzGwwNSbegBfSq7ptY6Hdtx2utrb8f7+QsBZZ60C2nQI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=TwTs6/Ty; arc=fail smtp.client-ip=40.107.255.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="TwTs6/Ty" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IEAG6wrt+c3x5/mRlmiCDir7VaP2O1p5yrp1VfsgKSy2AqbvT1qEKZQcfUwTVOpgx9DxFBQLzTTnWCCMhc+R7IZx1lmK6E29uAPxXKCwB/7ek99Lsly8lKK4CTcH7CFIkXTNFAhBJXw/8FH/VxzJMupfFSOQHAPXBaVS8JePZODTAqvkby2KkbuFAhDeZB9sI4EU7lLz+wIdCYYmlZg0AGSWIivDYEegAyuBd/s0pJMCajDuFhXCBMClbaZqgLI3rkNT/cTTGpJmIcEHdOJYLbkU1MiSsAr9+Zw/Co3gjm6Xx6KTXNvHCTFGq6vFIwAubodi5XdJaOjDpT3lomP7BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NADE9bwzc/fkj+YIGmvrP0pY+RyhvL/8hiMsQygvGBs=; b=j6W5xJi2p0otXpKM7myyqPhI1spWti43JN5uYy1zdIl5/KDcCZfOibObnc//f5gXmnGu8fqzhyGF7A8Xwb1wSVDzNc7rsGzPfPkDsQNKlY0QhBOodaiiUQk7KJgclAJ/2jViGKvrqq8SH/nypmuYN3TIZw3Lr7h5cK820E3eGev5ffMuK/9CEbhHaHbS9ELXtYFOgGouVLFm+KhcQuaTtR17M15fwjw1jyJJwR/0xheDASka600dFLmLxCfmy1ysDUi5xt1KBDGW2pELxezcPUsItJ4Bit+HF6478kSscBq+IdFYe+qVveJizZaRJyPUbtZ+5FM7ukKtJn/e3iabeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NADE9bwzc/fkj+YIGmvrP0pY+RyhvL/8hiMsQygvGBs=; b=TwTs6/TyJF/+0iUJ7Qoj3zhawHdUo5WQGLh6zktor2KcGJ8o3f9fnmYX6xTMG035/d9VDQOgvcxUqW33MSaKGdhqnjpFU8v6ZrwZDm/yn8w1M7FD+U9BFSS3PaPwq0U4LRjdJ7VmIWxAYaunnUbIfKIHFk/NZ9OIZqmbsm+N5yWQNsSz6Lw3V7lYOzrMasSq8PoopXWKQM/OoBXU4Z0a/uZ9tpBMJhz8JI4laJ+OVQ7d1KeITlXFvr4UtgcFnoPH2nw37aSVq7IKNs52YcfknjNsDYZvvBSLa/FY5DfqrP0EgL3Wf6Mp/Cf2cK41AZF+3lZOQUa9R+kp2NMK2A8/mA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) by JH0PR06MB7199.apcprd06.prod.outlook.com (2603:1096:990:99::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.22; Wed, 21 Aug 2024 09:29:04 +0000 Received: from SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6]) by SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6%4]) with mapi id 15.20.7875.023; Wed, 21 Aug 2024 09:29:04 +0000 From: Liao Yuanhong To: alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Liao Yuanhong Subject: [PATCH 2/7] rtc:rtc-imxdi:Use devm_clk_get_enabled() helpers Date: Wed, 21 Aug 2024 17:28:41 +0800 Message-Id: <20240821092846.20138-3-liaoyuanhong@vivo.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240821092846.20138-1-liaoyuanhong@vivo.com> References: <20240821092846.20138-1-liaoyuanhong@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0001.jpnprd01.prod.outlook.com (2603:1096:405::13) To SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5576:EE_|JH0PR06MB7199:EE_ X-MS-Office365-Filtering-Correlation-Id: 17fa5e64-7211-4240-c582-08dcc1c3b29e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?TOIQwYB6BI5GrRhvVx9bbpNQh2c0zWZ2jfTsCc51ReaaVApDDHeSo1SpXteR?= =?us-ascii?Q?1ECU/NBeQeXRRa2GhbprMpcLTEZscod0pwm/njgLv44c/m6rioPPe2fejI37?= =?us-ascii?Q?qq3+/8uOgYaTr5FwIJ5UVslnlHz+I2v6OJMc5olr64XuqCnpZY/wjNfaSXWb?= =?us-ascii?Q?kCaEPCpCsxeo9JQ0luju+MHqxBffINnwPeEjk0dMjM/dozFvUwEUKMt/nqwl?= =?us-ascii?Q?5kjQF1kW6rbogFbkM1CrSnoRyNnhSGmt5G1RG6UxQaGOlDihGgw5XfSrwSed?= =?us-ascii?Q?AWgn/tmlNM0xdTh41D8nDiuZVikmscPKqUx2KEru0BCQcwZHEMS1daNtL7zI?= =?us-ascii?Q?8Kl3Wyra7Cau/finmrF9h2EmuiZ+N8oe3j74oQUB77IvJ5WBYDDtzExC7yyJ?= =?us-ascii?Q?pXGZUkTy7A8WcvK0pZfmjxC9sp+IvsKA5SeoULIcayRNxVzNSmh8reNOYCq9?= =?us-ascii?Q?O+QfsuMttGI7L+eGKdrSZHwZCddBvZRc9qAuesSePPh9Ck9kqNKUxEx6U9NO?= =?us-ascii?Q?7qgMAZb4McCOXp4A1NiT+bdAghFIACKoEyeyrHxuBwQYGPfJLT/UGA6ct+/K?= =?us-ascii?Q?xG6x1fVhR2URnokeoKrgD5x0LSSdVVijEwahiV/ONJVEeoPIEAWNd3Z/HVcU?= =?us-ascii?Q?Mp/IywQKzGSSwbGN29Vjas06InPV/50JAhkZAxdPis5lDEIx7ov9NlCmKD+C?= =?us-ascii?Q?EPdWI54eq+ia+HSeQs/VhWhBewylAW/imirqSe0D00TK/m3DbBaE6XkBF8pI?= =?us-ascii?Q?fzcaYplHAkaFJtgSYpPiDY6J7xHLjlh4ZYG35OYaV5+9LO4lgKjpEuK35SOg?= =?us-ascii?Q?H49Br6tcLH7gSSHF8XS0AEEf2g69zsq4SYz4biaX8IMNccoTMwftmgEC20nB?= =?us-ascii?Q?NDkCaY2Nz1bAxosAsaWQfVH5UfzE9CNfO5vbB86ojFQMtHRlaQamhduIgj53?= =?us-ascii?Q?D6vwgAVrUZ8kEGFrK+Ylg8wHCgU4nxLQVht4FtucSlBidLdVtqvdfhJ3F5Jj?= =?us-ascii?Q?Zll3+8vCQ2JGRrM2F6q51JfGN5dn/Va54YNgi9G/x67aaLTeQDSpxEXDoN1s?= =?us-ascii?Q?ThiozKrGvfO2zqLGsueFvEqw2vhO7bcEbolcYiWnsyqQ+TF5x09Mn+vbRCbb?= =?us-ascii?Q?4p3rVBK/xGUSswzIVV2/9oNiotbqx+epkkMkEwX5CAgefGWwRKBnER2//hFx?= =?us-ascii?Q?CbwknwhxWvS8Wn6plnNMRx3c9NJpDFTc+2RvG1FhpMzVVrfplBTAExH1/bYi?= =?us-ascii?Q?m5EaM72pUCPLlCNqy75AbUGJF2dUiZzw9K0a5GVhNHfoBnw151r7HshmgaYm?= =?us-ascii?Q?dkdp1cPJ1J9qITteu9DilJ9imJWXsKFO/xBhBfoxQl4R4698fYN59Sfy6pI9?= =?us-ascii?Q?CVd3gelkztOqiKgf/EWiqkCx70xfbkB0VgR1AFiU+qOat7rlzw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5576.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aTkoCBIG56wMaa1+omCTniV/WXMbIg1mAKveRobqssnzXy7cYn//jzjesRYT?= =?us-ascii?Q?Myo1DsmsI3xK5Ju4T7lVisZfKVeXo5Pog1lpJfK3qkVy0hh2HLc7/xd8lcOu?= =?us-ascii?Q?pPavHmdRaoYzeJbQ0fgXWZx3u3KeCsNSMx2YDSC/5PDJHCthuPRXlS3GInoS?= =?us-ascii?Q?B+GsvVDmB/aAtaoKydh2tAuISnEqwgXk+aAeag3KH9xEAaPwTkns9TMlVK95?= =?us-ascii?Q?qmravfO62gLI10AJxOsWm43R1OpwPczQOgKv6Bwv1Rr6GleBEl/RXITWIgsH?= =?us-ascii?Q?0wJ9lZcPw52lCsixhz1WxaU5BcX7LMMFc1kWk/85ZhTWpiTiqVqLlsUB9gx7?= =?us-ascii?Q?NeCidcbP8xssfzuWt1ZrvTATS4eG8aEj91gMf9WWPf8WmoEz/H72WJaK/ryV?= =?us-ascii?Q?fnGX/kSbxbFDx38cQt1SGyWgtQNkAECPT/woXf9o2Zjen4BLszIJPLA6ztAv?= =?us-ascii?Q?oHyZc0YxNId38EOh0XgEXLHXZW4unwu9uS4vt3Z1Nr2DWoBSyRD1yHM2uT6x?= =?us-ascii?Q?zcPECrDoGmBccG3Epv/1LcqYFeMSnks44NwlOYOIVIvLarf19nKE8/mXnW23?= =?us-ascii?Q?K9dFhg1Z8CLkNfSnmDiVPPuuk6grczVw1ZbIk+C92IY1sBgd6rO5j/iHdvwo?= =?us-ascii?Q?hk9wznXr0LmNN3JIL01y7szF0cccz1pgHT/d553CuVSn49WzEn590a++XW/W?= =?us-ascii?Q?2E6LPAKLSG6/HydBbn8MjXxwk0r9pb+KTvjB6FdoeZzwFT0NXOnbH6UMAkJl?= =?us-ascii?Q?3gjlCKEx3+i7Xs0pp8otnbOnoagpctlCp5SsFkgQAtNPtLHfcVFzZ3lmA312?= =?us-ascii?Q?08yqQYxUjoA6lJlJ6U/xj7+3Guo3hiK9xFrEQnNlWfTgaytxKBNFc1w4fXC5?= =?us-ascii?Q?IYUSEDmfYcEbHnJVHx/J+8llRVaBodVDNJnvU6aaMQHIwNR2p1SPRICDuMCr?= =?us-ascii?Q?b2lIizoTE+sqs5K8wb7z/tGQYy5z+jVQRxH4zXuoN+rRLwB9JjoUw/pt1NZo?= =?us-ascii?Q?U8QcQduG72KZmob0G1/jtIccxHPMJJZHUg1XoBUQRa/0H0OSlyhavZysUcTE?= =?us-ascii?Q?izVMznS8ypAIIJ1hId8qfNDm9Vn+D89ZYkmBfpiJBvGnOQFM0GDWf8dhv2Uj?= =?us-ascii?Q?OYIFDC5808BBOVyF+Ib1HwG66mt4pCaaj1Q4+Md60d7Hq3OXdt5Q1uF+9ulf?= =?us-ascii?Q?e3kFnhybAX87MO4gwo9UR+P9In/P+imo4QflGRR8kk0Lzqr9JuYOf4T4Gh1M?= =?us-ascii?Q?kffH1bAP/gqpbYoI58R64Mqk5RMbxzOMsir3VWAm/B6sENTdPhc67mhVZsA2?= =?us-ascii?Q?+vq811xPoa+OwxLCm+nY53N20WIpaduG5CrqMP364ucmBRfdPv0NFHEunUrQ?= =?us-ascii?Q?DH8WbFXkey5jfWgJCBoMUMuPKeKIlcymfbp5/h7UitpNlsuecC2URTCgu9os?= =?us-ascii?Q?m/e2hepl1DITJ+wYZwXK/aOghK3QnrHsH0ZWJrd7+Z+2EF9T6wCZCNRyFLMk?= =?us-ascii?Q?p4H1z9bmhNJeuqHSzt/95+NH8Z/08pDAnlJiBRJJZ4mNdwsilw7Nww3dtTmy?= =?us-ascii?Q?B3lzClpwcjDYdLWL7C0n0byIwXs1k/lMZ1hk1rRb?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17fa5e64-7211-4240-c582-08dcc1c3b29e X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5576.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2024 09:29:04.0976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gjTwIcu9bxow6Q/N1A5r7KDUKtzkkD0xAZB2Mr+rwhTG5CumWlLgCM+rg6lwnPYQDmV+UT1FpeHQOtgTWvJmiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB7199 Content-Type: text/plain; charset="utf-8" Use devm_clk_get_enabled() instead of clk functions in rtc-imxdi. Signed-off-by: Liao Yuanhong --- drivers/rtc/rtc-imxdi.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-imxdi.c b/drivers/rtc/rtc-imxdi.c index 284011c419db..6cd75c5d8a9a 100644 --- a/drivers/rtc/rtc-imxdi.c +++ b/drivers/rtc/rtc-imxdi.c @@ -778,12 +778,9 @@ static int __init dryice_rtc_probe(struct platform_dev= ice *pdev) if (IS_ERR(imxdi->rtc)) return PTR_ERR(imxdi->rtc); =20 - imxdi->clk =3D devm_clk_get(&pdev->dev, NULL); + imxdi->clk =3D devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(imxdi->clk)) return PTR_ERR(imxdi->clk); - rc =3D clk_prepare_enable(imxdi->clk); - if (rc) - return rc; =20 /* * Initialize dryice hardware @@ -794,13 +791,13 @@ static int __init dryice_rtc_probe(struct platform_de= vice *pdev) =20 rc =3D di_handle_state(imxdi); if (rc !=3D 0) - goto err; + return rc; =20 rc =3D devm_request_irq(&pdev->dev, norm_irq, dryice_irq, IRQF_SHARED, pdev->name, imxdi); if (rc) { dev_warn(&pdev->dev, "interrupt not available.\n"); - goto err; + return rc; } =20 rc =3D devm_request_irq(&pdev->dev, sec_irq, dryice_irq, @@ -820,14 +817,9 @@ static int __init dryice_rtc_probe(struct platform_dev= ice *pdev) =20 rc =3D devm_rtc_register_device(imxdi->rtc); if (rc) - goto err; + return rc; =20 return 0; - -err: - clk_disable_unprepare(imxdi->clk); - - return rc; } =20 static void __exit dryice_rtc_remove(struct platform_device *pdev) @@ -838,8 +830,6 @@ static void __exit dryice_rtc_remove(struct platform_de= vice *pdev) =20 /* mask all interrupts */ writel(0, imxdi->ioaddr + DIER); - - clk_disable_unprepare(imxdi->clk); } =20 static const struct of_device_id dryice_dt_ids[] =3D { --=20 2.25.1 From nobody Wed Feb 11 20:38:18 2026 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2071.outbound.protection.outlook.com [40.107.255.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 642681ECB30; Wed, 21 Aug 2024 09:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.255.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232551; cv=fail; b=Dj0PbMj6ZMWZd9Hjxv7l5+Gv3vhwqiExGgVEAEDp4DzYy077xqu1RknJDSQz2wnLmSmD7lFkhPqLKri/Isxj9kHxbSBAcis55r+zotSEp7n4zWxsnkqH+pG5ilZeCTOW9cmsSwk2B4F/6rwN+F8Uwts6BmGPGB2m3UqDmf0ENIY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232551; c=relaxed/simple; bh=sTrs1af+NefrbPT5hyU6znGsEDtUdNYVz4c60WxYrS8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=tGMKqKLlWTNRT5erdREV9q6h0PyXvIlM5B5Dv3sPxCP3nVXAW5zWYvGkQ96JH6hEqxHxRMz2z4GuIUt8xiazlnSdYPA4nKVYn1Ep7bezpjYRLX2By9PNPM/YjzpjXToIjB3VrW9UT2wF0+X3+7ux9SSmRNoKfdd07cmG2NMrCw4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=DYVpyG5S; arc=fail smtp.client-ip=40.107.255.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="DYVpyG5S" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VolSG/UPvhWfnCjslgqecTPgKQL9NE2ou5DmG2qiT/ALE4tkdJCj7ybDhYHnsI9HALApRhRHdYBhVEOlif52lclOAcl1iXpejDq+Tahx9Tj9WjHwilTMeaAra5r8mHAWlE0NFwnmhCcUrNQz+4nWOlr/hi1LkDKnwgvCOJdh2oGNL2AogQDvm/BCcTQMVdB4MS6sbd/31qTSoRFuGbery0NoTogABEnJxoMfn780z8eJ3lT9BCDBJD/mVq1RGiwAVgKseuwuJ2EufXu6/RHZnm8Ck70W0YUgfM5SfP8nHwTT61bp7FLBLOVnrmfCK1eOsYGWmg1qk5Y6/7MY68blyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YX85R/VLrGsa0e8uONqpXoV8xfl3YmN5hQ3ndbPJL/c=; b=tt+MhByA70Ez/yushzaeHa23Wb+PZgM/voylrIg3a7Xuw0Xs4khZ7y0kV9WYEUazOlF9LIxDj6CJypKSLbjK16ORJMXgULiGIK4KSQQajxxW3GiLcmbIi6Rm9mtIk6pNnPGW6A9LU7rMH6D+msA7K5OosPCbiZ2O8Gmulf8VtrEFdy69t+ZRS0+q2EpYme+mcsxn85KbkbBaZCOaco+N6pf1LzdfuPjD/jWYEJLIaAlE885IRiFiHcy2b2CudrEzEBdJaR2dArBuN/9B+iiEyp794BKcH4MM+esvGr15D3vsWMhf+QUVwK/bnyrx3k0m3z7/c85RODaWCSUNlx/hmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YX85R/VLrGsa0e8uONqpXoV8xfl3YmN5hQ3ndbPJL/c=; b=DYVpyG5SUecfc8RzLhhEYZNEVWwENM6HM+uPTsXvVdd4TTBwePri4T9CBZnxl0+ysHZizgD832XFfwq6RgZecsrdUdY1x0KTIXA0eRZbYG3nWZJgNmfZt/Cyst/6vWGC3Otsa86gszkjOTuDogGBfGSM32oLRS1hFRdGOo61q430n4FgZ5Sl+80JAgWUeA4vv9A1rQVpINNtwST8Ds0LLoFX8PU+lhTLcU1nV+6Or/VHdIg9MRN0xrf8ay8Dg1YSDFOeoVpcXL2MD7vnofbp+k/NdgFqb+ICW1lkB5tDKhmWwLtrLai+jRMMrgGgid4LjkRyuGwW2+lp6WbFU78ZfA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) by JH0PR06MB7199.apcprd06.prod.outlook.com (2603:1096:990:99::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.22; Wed, 21 Aug 2024 09:29:06 +0000 Received: from SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6]) by SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6%4]) with mapi id 15.20.7875.023; Wed, 21 Aug 2024 09:29:05 +0000 From: Liao Yuanhong To: alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Liao Yuanhong Subject: [PATCH 3/7] rtc:rtc-mt7622:Use devm_clk_get_enabled() helpers Date: Wed, 21 Aug 2024 17:28:42 +0800 Message-Id: <20240821092846.20138-4-liaoyuanhong@vivo.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240821092846.20138-1-liaoyuanhong@vivo.com> References: <20240821092846.20138-1-liaoyuanhong@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0001.jpnprd01.prod.outlook.com (2603:1096:405::13) To SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5576:EE_|JH0PR06MB7199:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ffff655-d756-4ee8-3b1a-08dcc1c3b3af X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?H/nW1uxnRroxz46vVJLPn0cKHyEY1Z1TqniQOwb/ZQ61+yz4RY/rErkW0gWv?= =?us-ascii?Q?iHEz74Q3rWrrScyiHu3rRY98ZvT99uNvo3rwSqhm0BKAnGgOos2eE1JReKBO?= =?us-ascii?Q?JuOQbxlWC1hj0E9XYdRe07cqle4A8RYg+tbi9o+XSU76oHNFW3oLbMA6uBnQ?= =?us-ascii?Q?BhOaiGX0+F85ysoJ2odj5xJInsGP16Ilch321AJ+bTdCRqsM08cmll2v3U7d?= =?us-ascii?Q?QBCkuqYC8T/+x35av3ymJIKPDqyUlBxBaQimiOboNY5W08VeBsJpmPcx6bsH?= =?us-ascii?Q?1M/QI42tfm91CNKgerpKnQG3eGwiC/ZWI/OC47gla11PY5kqTbaIazECpZYH?= =?us-ascii?Q?nagtectPnGi66NswGQw6k9R/M3t9LVU4Ec8iqoJdniLs2xdth3PzQ9EUFTGT?= =?us-ascii?Q?fW9lH13+cX3kG7yAY9cGZYmN8DCTpP49MK07XNvn6Hv3nWWWZiupYCPJfohl?= =?us-ascii?Q?fSuJFI1LWJO04Oln7C4uD8i1M+srCuxqnGNHdqL1CUenrbsoNEJ8u9ZCU/3w?= =?us-ascii?Q?LH7Pku8zwgUcAfruBbHJwjL+QnpTcvSNbMJrvtnIkwiPXBisRo+LFnm7xpcg?= =?us-ascii?Q?BI7uTO6+COyp1yBKiOupXxZTX/qBub85NbGsb0iZ3LAP/PAG+MwVApSAn9zF?= =?us-ascii?Q?8GEgXG9X7t5ygU3omgZApDB4a3o9Yfh7zCOnsKCmDLt5NhzB/YUFKjyYOyVj?= =?us-ascii?Q?/VnzxBmnNw+ZmpyhoXyrEFxOzw976EAbou2R0eEj7JEFa+rKVmv1YDIpNEHW?= =?us-ascii?Q?D3X7yUsVsZW40ET8TkyCcXpsbyDORoNMRCExBLChYnCXFG8hHce2aORk+oLX?= =?us-ascii?Q?rdeDRXMwOURBUvLJsoescix8RJPXWzYWmZgi54e9gkLpsK/YNGQePKmatpPt?= =?us-ascii?Q?l4CxrANrj8U2Az5RZAw7wn88cvH53F/CxC6CddfGbe2zrMxc32ho6bl4jqaQ?= =?us-ascii?Q?OoZ+hQIU92zNvOoQHshRhhpuc348fdv515keKa5wyNqo1PJALpjSM46tY1x4?= =?us-ascii?Q?RFIiIhJd64xvsOUgSWNghhJBcrCvmgMMIwQXRUDTrQ5K3excH/DRrVOC7d8h?= =?us-ascii?Q?0Ilg00vU3r8CRD6MszwmaK8ppRkQSWisASTrYe4o2JpHBN5+RDJgSkzzdOsf?= =?us-ascii?Q?im4l+LsvTkkgd9FNvfeK5udYiFsnEhN753o7YEb/H7pZ6wgCvunoKPsrRL9A?= =?us-ascii?Q?AHWoKY1+6WDnp83V6NlRbbigxqjR4OliDcdk6eDrAacyRBaz86LPZuUslIko?= =?us-ascii?Q?hNiP2o/5ffnkBMoDzMi7ErhAFOXkBjlBHosm7eXcgmcFtg+HgWSVyh/Z1ZPU?= =?us-ascii?Q?P5qkk8Gsl/JxMksL5YzVBBotrSPso9J+zb/yMdCVuHUZaGo+hz5m82I+pDUm?= =?us-ascii?Q?QHigow9XxPV7nqs2owXMFKdu249bgOMBu7HTzuBdqRzR3rxGiA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5576.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ayB2/wqkbzI/2m54Z8yUnAywRh8YUN4gWtcGYgJ8QlG5LGgXuwqUgdZma0Az?= =?us-ascii?Q?jsGYNlsSyaDDVNWzwSm8O1bj3nyzF4p9u0s3FuXA5fm1OcX3HZB6p6aRHNmr?= =?us-ascii?Q?lje1YqgPj+JdE0we/7tDXpkWo39sEl0UKtJEnANLiDB//6turK4vvMluWV6C?= =?us-ascii?Q?X0G0EkQ61Ux+T8OEpT7QdSrI0443anOYp7gp8XHOG2O12hx8Eb9jNZarA6Fh?= =?us-ascii?Q?9KrOEVkSgn++KEDt0zoEOxvnYxjvSXdFDXLF4qR8hipkacf89i36PzhCAs/S?= =?us-ascii?Q?GF/5Ob3NyR77lm2QfcDhfjyKHVYxB4wXHJn1MFrg3I1ld67a86XzyT5ZX6Lq?= =?us-ascii?Q?B9xDPgNQPs4Aow45lhS0wAwR0HqjTTeo+Ez/amnX98UeKc2uhRqcLWtamBst?= =?us-ascii?Q?bqEsxns0cYMaepAKh1/lAT+PG64PLgYr2YGAEc2wm6nRlpdK7/OEjTyYmwNc?= =?us-ascii?Q?3FqnOjvoHeA1+nEW9HRyj/Uwpcdq/SaTSxjj0LOwp/lyMyOH3XzMgGwfzqgz?= =?us-ascii?Q?Su8eeQ0d9w7bajdDRhueVw7gAIGHY1Z/dOupP7x4df4SCuK7k0pshQINGIKw?= =?us-ascii?Q?NxpQqZptGeK+pfVJipJYk5NUIE63WjQPbTdNtLaKn32kfWW8iLQqY1H5Uf92?= =?us-ascii?Q?dc9Rndp6VyWE2q5wkSxXt0I9YcxfP4Uv3+3yXlThAb4jsDcpCQR0+r9es7ze?= =?us-ascii?Q?g0ToxMemzXtFU6U9Hlvk3K1kZakgeHJ3u+XDqtilDRNYN4pcaeOGhC160NsJ?= =?us-ascii?Q?7CcqJR1nlsxj/xAEIrEoa7XZEV7cAqkHCoqEjm3u0mvPrdcz23J9D0e1hO+W?= =?us-ascii?Q?DQFrEwp73/17UxYClF+/0VhCa9uhTn35GlSAf7ws0OVCuDDU6Mcu8WanvRXn?= =?us-ascii?Q?2bPtfwfR83iNPcE3qyZJ2frqAlA9Zvg63U+KHFBU4kUHYio59IxFx9JDxcWv?= =?us-ascii?Q?8TE8oyBRtqQVd8gLgoMeWIy6t67sH/BVpdIebGtePSqAyFBbUSZRJngV8DWJ?= =?us-ascii?Q?YLx9j3IJW1k0b2cpIKomNFNGN1Qf0i6G+GccsM5qVBBV+fuIYk4JGzuk+56H?= =?us-ascii?Q?5TbkV/7ombPDtcWrLI5CT1w8SHRqjufsv3TFKc6yVA5Dlf/h3pPjIrFKngGk?= =?us-ascii?Q?x8SsMgQmm/vp72m+j9ff+cWG817dKuH//w66cH6wmlqfLqPkcmlHcSHuZR1u?= =?us-ascii?Q?6OjzA0oxuBa990x1xuTYYyj7I2h89mAXSuAzMV6KX1l/SY1xh/Kintzlw0Qo?= =?us-ascii?Q?9kyLOCDVRnHsWJOIycAYRtfRjnkpvvauN64Lv3H3EGrbH6NCzAsHNP8IUHwo?= =?us-ascii?Q?+pMkO8AioeJmlVtKmeJp1VUguUQqHMQ2tw23IuFC/iv3Ch5BP0+1leSoGjtJ?= =?us-ascii?Q?H9xnS/gsQ6PoDlyMG+MOP5cTEuoING6dW+8zXwJgloKqRxtBB0a9gQNX9H95?= =?us-ascii?Q?jxLqKxk7lSoO8bblpyl+M4lrG1XlojWrjwLMyQA2bv+3nh0iCqDUhoZAvXph?= =?us-ascii?Q?IYChf6F5++e8E9LOYYPGB7IK84rh34hkRMmS+fMR7gw3pJTzOZcJs9Hvlcf7?= =?us-ascii?Q?na3CL8ySP8J/jceHn8ZZNEC2cCi7e52ozlmYy20D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ffff655-d756-4ee8-3b1a-08dcc1c3b3af X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5576.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2024 09:29:05.8878 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VghUEysWhfEphn8OrxoUvu3bIgTujPM1CQnWC8vPggk2qGispk1p3wimCT1cPVyWpM4ITrjCyIACPccY81tTvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB7199 Content-Type: text/plain; charset="utf-8" Use devm_clk_get_enabled() instead of clk functions in rtc-mt7622. Signed-off-by: Liao Yuanhong --- drivers/rtc/rtc-mt7622.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/rtc/rtc-mt7622.c b/drivers/rtc/rtc-mt7622.c index 094c649fc137..da1d9652d6da 100644 --- a/drivers/rtc/rtc-mt7622.c +++ b/drivers/rtc/rtc-mt7622.c @@ -315,27 +315,23 @@ static int mtk_rtc_probe(struct platform_device *pdev) if (IS_ERR(hw->base)) return PTR_ERR(hw->base); =20 - hw->clk =3D devm_clk_get(&pdev->dev, "rtc"); + hw->clk =3D devm_clk_get_enabled(&pdev->dev, "rtc"); if (IS_ERR(hw->clk)) { dev_err(&pdev->dev, "No clock\n"); return PTR_ERR(hw->clk); } =20 - ret =3D clk_prepare_enable(hw->clk); - if (ret) - return ret; - hw->irq =3D platform_get_irq(pdev, 0); if (hw->irq < 0) { ret =3D hw->irq; - goto err; + return ret; } =20 ret =3D devm_request_irq(&pdev->dev, hw->irq, mtk_rtc_alarmirq, 0, dev_name(&pdev->dev), hw); if (ret) { dev_err(&pdev->dev, "Can't request IRQ\n"); - goto err; + return ret; } =20 mtk_rtc_hw_init(hw); @@ -347,21 +343,10 @@ static int mtk_rtc_probe(struct platform_device *pdev) if (IS_ERR(hw->rtc)) { ret =3D PTR_ERR(hw->rtc); dev_err(&pdev->dev, "Unable to register device\n"); - goto err; + return ret; } =20 return 0; -err: - clk_disable_unprepare(hw->clk); - - return ret; -} - -static void mtk_rtc_remove(struct platform_device *pdev) -{ - struct mtk_rtc *hw =3D platform_get_drvdata(pdev); - - clk_disable_unprepare(hw->clk); } =20 #ifdef CONFIG_PM_SLEEP @@ -394,7 +379,6 @@ static SIMPLE_DEV_PM_OPS(mtk_rtc_pm_ops, mtk_rtc_suspen= d, mtk_rtc_resume); =20 static struct platform_driver mtk_rtc_driver =3D { .probe =3D mtk_rtc_probe, - .remove_new =3D mtk_rtc_remove, .driver =3D { .name =3D MTK_RTC_DEV, .of_match_table =3D mtk_rtc_match, --=20 2.25.1 From nobody Wed Feb 11 20:38:18 2026 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2071.outbound.protection.outlook.com [40.107.255.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B7481ECB4D; Wed, 21 Aug 2024 09:29:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.255.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232552; cv=fail; b=Sos1BSg010zGs+V8CYAtI9Uga8xZ+XjbAOXGiF44OOBgamkN2QMCHGsEHFDhlp2nyCAI9iAFHQE3cYDlwM1/aopx7LfAfmI08/yk2XwpZrdoEBiVm+Oc51VGGUsTbYaiLmjw8htRpepdX1JnKXT8CCZWhfkz3LC7s5FQWKGhf6g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232552; c=relaxed/simple; bh=WwcDPcn0fw2Rei3qdIh94r4VMBzPSD1ci5vC6vesDPA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=kf+nvGt4LWhHHSMewzf/3dvBc72gUMNhb9UP83gPnyiUjYtcVNBZe8xUuVK2P2NpeaXnAnKSq/8WRI0H+E5oX5kdo5TsxiP/VKbfwNjTN43sWjFqC8Z4OUeNEqxTUO5/fnad9EkBjYBQkOvNw2LrtxM1egtHHsNq7Rgcq35zAEc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=FVAWQaPZ; arc=fail smtp.client-ip=40.107.255.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="FVAWQaPZ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iTgvz8TZEMVPlGgnkD2vsPFgWF809LXjkEUd0pXFcpxSrSksuw7FNq8zwIS/zZaHLPachFKJf1MoDJ+Pl27hUiFtLIDbYArPoLQwZEg4oZDZTecj0zcNT6KhSDvqtWkXhBNBAlJiQG4KDNLa1fj8bbce1VkMJEDt0x/jRdLe8wcZbS4eJYTWbHX64pLNrQng0Owa6DXZtJFeH30M5dfENStdhWRW/fImO6Bi2ydJFrzK+LseWyyIpdpy0Qf474K5vr7BuNd7LjbbjdfhoisNZmSAKL9I22nQSJWvbzIcHTLxvwyxKMoufJGyUDjyuGhAUDLlTJMS9+lFcrKSptDCGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WAdlHXocZLjenC+WvGLU14zj/mGpIL6nxB70i4Qm5x0=; b=u0xzf9LAVCc5VwwUR4cEf7HS15GvinQb8yG+qQU/m5dp2C2Fe2djbjlNDhGXNZqeEqNngxzRjWYGbIXdfWV7HwAqV2xCndCEZz02zxnJ2Z8KdkAi1x2D+0mwh2Zc3pSsvvNs++i+M2RCqNJgnL6gMO8PgI2kCpvo54VdwGV9PNIDXtCySDefF/lje3GAEAQar7GoN0fSykpuEZb2ZMKvid9GrQAs0IOsVqxtBsAqSsdrV02/5TmqEA+TTShUC6k4ENtNtp7Fyx0v8jC4/yUviw3FMe2vWpQcAW2F3NsNaVfknY5uWCkUC+bN73cmy1EhOs8KC1BXACuaGWCAiSo0eQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WAdlHXocZLjenC+WvGLU14zj/mGpIL6nxB70i4Qm5x0=; b=FVAWQaPZJ9buemhnkBQJrQ0hWdE3l61bikgQ9XTFsO1cRBdyOHn6rWntFwhRjt2V4Jo7SXWXbS54h+dk6UDUa3+MGrG/dBhu0Mf/vtga7Ha19B2G57nLoUDlThbc4c/I+NRNXota6BbrE+YOqIfw/siSe1/wPqu1VeUN4suP6PNOwORsu/GFyU0Nv4L9kLSX0uwgSeVxWKQfnGZoovmBvWhitOco236IBmc5/5MIQv8ltnXCwpvqWL9A2fxac/iab9mvM79bQ3OCnCfTtOG0jqFdIW3yef3QLEPbu2kFpgTf5fnDoi/F+CaBLYvlfd9lZQ7dYjxrawFxt3oywrpOMQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) by JH0PR06MB7199.apcprd06.prod.outlook.com (2603:1096:990:99::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.22; Wed, 21 Aug 2024 09:29:07 +0000 Received: from SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6]) by SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6%4]) with mapi id 15.20.7875.023; Wed, 21 Aug 2024 09:29:07 +0000 From: Liao Yuanhong To: alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Liao Yuanhong Subject: [PATCH 4/7] rtc:rtc-s3c:Use devm_clk_get_enabled() helpers Date: Wed, 21 Aug 2024 17:28:43 +0800 Message-Id: <20240821092846.20138-5-liaoyuanhong@vivo.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240821092846.20138-1-liaoyuanhong@vivo.com> References: <20240821092846.20138-1-liaoyuanhong@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0001.jpnprd01.prod.outlook.com (2603:1096:405::13) To SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5576:EE_|JH0PR06MB7199:EE_ X-MS-Office365-Filtering-Correlation-Id: 5616cfea-a253-47d1-1c1c-08dcc1c3b4c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?V+yDE8hZs9sar4910hOgertOkG1/CUOoAwQ3edslMyKVcyAa6U7H5ANDIA+X?= =?us-ascii?Q?nUbef9HHEHFkZbbRWfJOMUAlDRfHS2YwmxjEKYQGb3wE36nY179I7wUInQgn?= =?us-ascii?Q?9/zYs7CNzptZscxhy5Hwzw0h2hG/bq11XezJqM4xIsDFTN7kFB4JYkBOJq4U?= =?us-ascii?Q?6I8aUn+qcXW8pmoz5AP/9xxjQffCkj1DHITSsx+h/caS8Y19xh/hu1ySBxLC?= =?us-ascii?Q?dFOV6/dAY4en2OycjScESqtDXEMSecRiWCCnIFE2YodgY4unWVE19GET7YPN?= =?us-ascii?Q?3kRAbZwlivTAdwJekU3NXDRy4qL9cB/ns+AEbEHz6OMyMlq5gGvt1BK9vF+a?= =?us-ascii?Q?+4d/fa7xhj8IcbQIfrRKaqRSweP5EDcycC/ZJl3i5uHXLCJgoCfNXOvJ/Nep?= =?us-ascii?Q?NiToSo1pOsOwedlbHVCofY6XVRgZKN4RR3xcuG3Qanp+llfVUZ1+cD6+xLTH?= =?us-ascii?Q?gyfSQ9Xr/d3NBeKj0vWpA+AJsNcFhksBzHTgTw4kPrWFoJzJb2ii0zpzzXJr?= =?us-ascii?Q?f4lmBzS/wAJgOX9e1V6t0BAQOJ8SxEq3txiDOMS8IqfW860XxKjQ2mm25fSB?= =?us-ascii?Q?vdmf1yApZ+o/YI8mLggP57cayOgm1HvlQPhVtKL9zkmVUX8IY1A7iKkhllmh?= =?us-ascii?Q?gDCqiT3rqy5JMfEjorrtjnaGvxk9DiIXATeqWbz4xiU3R2B4gyUOQKnaXMFY?= =?us-ascii?Q?E+dzj5PPRSPn923C3z7/D5rbhYj9RO7kIauqDk64Xns2O7SCV2liK9P1o6Pm?= =?us-ascii?Q?kpd7nYNMWh/hnvQ8ARru39UNUKG3UMpSD7BcHSiA0ZUmio7lOkINYK+DDGSb?= =?us-ascii?Q?GvgStARYjaVlEtz7sL5CNgT0wPn3LtglUoc8uN4EGS46od5oE4U7DEOZyp+3?= =?us-ascii?Q?DgML2VO+DSG369lZUNO+TM0uZRqVQrGSSJR7KjGgLccb0f9DbXT+1TX3NM5t?= =?us-ascii?Q?7fizC5s/kHkKip1oQbT1JPX5a97rq3MZ7RzejtYX2z4ooMAUd3RhryComPAF?= =?us-ascii?Q?/gxCfyoy6+W9CKRYah1PPGZU0Ul1nD6UPXN59UaIEHN9iaUNJiOAvyNlTLrp?= =?us-ascii?Q?IPw8lRRfhbI/PNLy8EHJE960H+PauT/R50qtVSkTPd2/qj4KqOh6xK83rRfE?= =?us-ascii?Q?ZKZG/DxWDdfFi8JFoNfz6m753fIgRAGi57098/4NZchK8Xzb3vKj5hFuTeaf?= =?us-ascii?Q?FrTtoeSrgBxs7Mmg9u5Tr15dxbqzXgq18b1+wtKc/DQuXqT+wiykn2XtqUI9?= =?us-ascii?Q?F8q7cGndOs+UMEU+/FudLQEfUs0rNQQkxTGXSsXMnuvUaYPSGaaZcxAVeRNf?= =?us-ascii?Q?pC+kRPejMbebjiNEsAt/kVFFyZRXXE6ZMlGpAyEPjU8rfqCOgAXCGeOp/3PP?= =?us-ascii?Q?Yc3HQ6qG7ZEpMJwA6Dgp3zm3gI9RfJVyAnx4u4FT/PuB6stnrA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5576.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?b3vNcd1AwmfPV1wSzCGUL+vzvtPihRQagmYU7+xXkb8cGhwHJtsV2SnIq1+g?= =?us-ascii?Q?4b91mInhKB3G/LUPWLSkxsa79WP49ZKqyB1pSCf/AhkAXXtR4KrG5Kb+zBVv?= =?us-ascii?Q?crh9oscurLgVwklym/W5Z4pqTKLk01qIubx1N0FIrKV/9Okm9mEAe4hukayF?= =?us-ascii?Q?ff1FkNtj8DWG89oWOEwHuZsn6Q8Pfrn2rkEgxI42EJ1ykqIBd0we4CAAyhTf?= =?us-ascii?Q?nCNkz5tLgz4LK8mr8sFVoejJ0RyPsGlLyCby1f6fAwUfie9nYPNM1l719s4n?= =?us-ascii?Q?KpGrxLdXHdv6YM1InqJvxu1trIcI+1n2sEaRCw0OryMtxFLfEwhW6gx6XPcN?= =?us-ascii?Q?y1AvNWydyatDpbWBOF6HUL7+WdjAEmbmDp92g1abnb7KRFYy7zauef2ZQec9?= =?us-ascii?Q?gT4n6hPO42Rux7ECWEwPXFLRHMGaOBQMzx+wJXUyqH5PMK4YfW3D/L3K7jp/?= =?us-ascii?Q?ZFk62ZaBBej77R94TdwLeEuW+Pp2VVg7p/Zf75odIhhytlZdYfUnI7M+z1w4?= =?us-ascii?Q?1qh1T28LwA39nuuQ//4/bpMl1w1hYPHaTXiuI6kwaO6obei9rCDGcYJleC8J?= =?us-ascii?Q?jGPqtCeO5F3/tq49ielWfDLPaLeK4N6bIJFF9E/j/ea5k9k+WY+eohxjYG6K?= =?us-ascii?Q?X6kZRt9qdorJJjGyPdZXKJN87zaEnzySrKUpcWXNTejpHWJ9/QTFyerSmaWk?= =?us-ascii?Q?l60UZNO+7H32RVlroWZz1Cbonu+f0JIsUKilTXw0AA+DdDgIevcOEe4CC1nC?= =?us-ascii?Q?cQQhTZUEyq9YXeylCuzlcwg6jjMe3EJEPguYF5fF5H+UXPKI5xJoRoRRmy7G?= =?us-ascii?Q?YUheKTNfuv8aUHOceZ6evnnh7GtXr1Lxz7+ipjX4qc4qoSFvRTQb31x4892n?= =?us-ascii?Q?XtgLEMZF89o4GUUJ9/8dWwF/XBxe+x2Xd1NLXGgf4ZfIWS/x1zZyH0dnthtT?= =?us-ascii?Q?nyHwhYVtNUrz4mtS5xQcyhezuplkk9tSFSbWO1SuwfBA3jAbZ83yb23wDj4E?= =?us-ascii?Q?W0S26zK8+TgJwqHuoC1T1bRkrrMrkIMUY2clazQb1PzeaKYd6D4gzN3QKO0L?= =?us-ascii?Q?J24BxuUk73lw7bnThqEzvS8oozlCft7JULEZUZUCWxwGf1dWz5+2fGP28vtz?= =?us-ascii?Q?GoPZ+TEVD7w2Pmi4FtkRaP8x0JnZgUMHd5kNUKdvzTTWAgroqrTgemq17qdB?= =?us-ascii?Q?MTVEd4gEtE+k9SEU0pdG7Rq5Hm9wpFhTUnrdcE04S0F5Ls8T9zG4jNw8mViO?= =?us-ascii?Q?WVcixLWWC4MKG7BHyJbIXSKJqhBZdZxdyztS99xgzO0B4clxBlyHrMgKs5zH?= =?us-ascii?Q?187g36sFbidxWrGLGQkCtc+rpkXfJkSnYZP9zEGbuRrEXF0W49L0s9f7jkut?= =?us-ascii?Q?/3uptbRSYZiSkRsHxMYD+S+nlZcxWPmvkB974FNk3cgHHJomzzgMXd3HyMCh?= =?us-ascii?Q?kMu0hSXyoTl5S7Hg+YltT0OO4u8i3bxEjFlO0A/pMcqlXvcvy/QBgPsgNsBp?= =?us-ascii?Q?7cRe0JNN8z7u102iAkAHm9Pk08UHLAcF2+Fu8WRPXT5ZNmHUa7avk6rDSNPG?= =?us-ascii?Q?btJN3eBjYH79VDMBd7vSFSdJSrm+VVAqlnxhGVS0?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5616cfea-a253-47d1-1c1c-08dcc1c3b4c8 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5576.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2024 09:29:07.6523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wDHrs+eg/zNZr1XL2LQ4WSrG4rURrC+HRq697QA1muOyLZLLMXAhuSXOKui7gQ7cmJkA97ez9R6VOTMK0KZP0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB7199 Content-Type: text/plain; charset="utf-8" Use devm_clk_get_enabled() instead of clk functions in rtc-s3c. Signed-off-by: Liao Yuanhong --- drivers/rtc/rtc-s3c.c | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index 282238818f63..dd6a72b999e1 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -425,24 +425,18 @@ static int s3c_rtc_probe(struct platform_device *pdev) if (IS_ERR(info->base)) return PTR_ERR(info->base); =20 - info->rtc_clk =3D devm_clk_get(&pdev->dev, "rtc"); + info->rtc_clk =3D devm_clk_get_enabled(&pdev->dev, "rtc"); if (IS_ERR(info->rtc_clk)) return dev_err_probe(&pdev->dev, PTR_ERR(info->rtc_clk), "failed to find rtc clock\n"); - ret =3D clk_prepare_enable(info->rtc_clk); - if (ret) - return ret; =20 if (info->data->needs_src_clk) { - info->rtc_src_clk =3D devm_clk_get(&pdev->dev, "rtc_src"); + info->rtc_src_clk =3D devm_clk_get_enabled(&pdev->dev, "rtc_src"); if (IS_ERR(info->rtc_src_clk)) { ret =3D dev_err_probe(&pdev->dev, PTR_ERR(info->rtc_src_clk), "failed to find rtc source clock\n"); - goto err_src_clk; + return ret; } - ret =3D clk_prepare_enable(info->rtc_src_clk); - if (ret) - goto err_src_clk; } =20 /* disable RTC enable bits potentially set by the bootloader */ @@ -486,13 +480,6 @@ static int s3c_rtc_probe(struct platform_device *pdev) err_nortc: if (info->data->disable) info->data->disable(info); - - if (info->data->needs_src_clk) - clk_disable_unprepare(info->rtc_src_clk); -err_src_clk: - clk_disable_unprepare(info->rtc_clk); - - return ret; } =20 #ifdef CONFIG_PM_SLEEP --=20 2.25.1 From nobody Wed Feb 11 20:38:18 2026 Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01on2071.outbound.protection.outlook.com [40.107.255.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D68D1EA645; Wed, 21 Aug 2024 09:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.255.71 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232555; cv=fail; b=Ntq+QKbJKJe9HsNi7bcmSqDrWZsaEwNG1A0VV8RfqlKMCKTh73lLcbmtOxcXqjco9L5OW86La2ImrygDKuH/IB8USsAVjatP5Da4LQziVh9NaHs0/VWdi2APC3pvK26GE6YwHal63JiMMBZSVe2AXMUIUBiEhG6LjY/KXjDEXKg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232555; c=relaxed/simple; bh=7yKS26VVEWgk7VuNcnvZdO0yhSOvLe88FU+byA89C7c=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=n5rU6SQeGQb7hNurHz02JScYLewjjqAH55tvIRstZndEz74/6XSAOSyDyqPW8FB/8QrZ/cEYz4QtWBulp5FmUcjQcNJrGE3t8szCE4PdiMnGJrVwvQupUoHW9kAn/mb7JB/bC0rFDEVPm5S+5aszYYtp/MsZLVrGgRKhUEdIve0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=CRK2Kaxz; arc=fail smtp.client-ip=40.107.255.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="CRK2Kaxz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aMQATHWCt8iuFawuSVJPSDM9JglGe4F4F61cGRrAVW26fTg91bFvqvdnysISFqA3KArUYW8o+/+w8sPlVvXlfeky0iWolZo4GM3Cz9S18XZacBshZUeiThYC1vel8X2qCCqtlR0La57srs1WCFT3SeTahlQBwJ6OhsluvnxRqqX7fLyfdFt/pjXzH83nqp8es3DaQly2U7s0LRuA+1KZN0lNAYi+F9wXDWTz3RSUOYWcZUjGRC8CGp648m/uUx4o4FqAIvgkeef2XwG4rW2iRy4Opr367gBfGDGRlFIhpVwvi5IMzq06L1v9sHzCFAD/D9TEGvCWMj9ILDElHmXnIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V6HlZrq1q1mW+t19yIIp1YgZ9VJC1IcuSuO6oDr8sOQ=; b=Q5dHYqKyNUB2rFJW0ZXsWOVbmEM23PQ06gOREfIm43zrzJ3cZb3b64b+6fmXfW8N3N2RaEqj/IExjul7Zse6J0GNxW7vGC5UN4uCRGIIRT1uw866ybjOYZvy33Lxwi4p2DYRsP5Y6iELn5hAMgaLR31XUydpXJZJ08kTkYjxvCz7wDBxXv4Lsw+NGennl+JcnOiNUYh2ZPjfzOI/LKANNwyd+9/DpBUgjp+66a7nmEiHEzeVfCTVPyXHNFLO7K9puiUdSAgw03N0fZ7o25WFRNeAtxyAnGSqTP4LoeXi8J6iFuKdPqp0H+bm4M74wmcIPd2xDj+cVjyf7ssAJdVz4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V6HlZrq1q1mW+t19yIIp1YgZ9VJC1IcuSuO6oDr8sOQ=; b=CRK2KaxzxUN/4KNN/ItKKR120fOBRbNKIKxhY1o2WuhSDu0pq4SqdXS7oR6D1wYAnOaei+g6jX52NIkbXB7/TaXY/fqfjn6ERSU6f11sOFX6aK/YPTWa3m7gaqdxHtgODSmeHCfCIzKcaVaKYirlFnSU5GCY7RXfMpIN341uJcjFUxtXzmvOuuZ2iZPb0iDbwlKuRMZdQ5htzk6XFeTjKohxnncqXH7KKQOt433AH6MVQa0EYH4HgqsY3ShOojGSPK8mo9umC6BJbe5GjzB2rwvp/vJfWJI2Yi270jl0A1b+lr1rcRxHMfppjPQPaE48XYa0qzy6BLGa7dnN9krLkg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) by JH0PR06MB7199.apcprd06.prod.outlook.com (2603:1096:990:99::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.22; Wed, 21 Aug 2024 09:29:09 +0000 Received: from SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6]) by SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6%4]) with mapi id 15.20.7875.023; Wed, 21 Aug 2024 09:29:09 +0000 From: Liao Yuanhong To: alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Liao Yuanhong Subject: [PATCH 5/7] rtc:rtc-sa1100:Use devm_clk_get_enabled() helpers Date: Wed, 21 Aug 2024 17:28:44 +0800 Message-Id: <20240821092846.20138-6-liaoyuanhong@vivo.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240821092846.20138-1-liaoyuanhong@vivo.com> References: <20240821092846.20138-1-liaoyuanhong@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0001.jpnprd01.prod.outlook.com (2603:1096:405::13) To SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5576:EE_|JH0PR06MB7199:EE_ X-MS-Office365-Filtering-Correlation-Id: a174344c-718c-4af5-8e42-08dcc1c3b5cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DVNewSdwnSi2iWD2WTAYFxMhQDP589Rnf/3hqBFLeBNpB1ScQgld/388aNbs?= =?us-ascii?Q?F70TZFJ1CKDS6KxQPosXHSLblPN3Veob1mKmBd0KWe6b6kf2eYNdDjAtaPN6?= =?us-ascii?Q?AbLR1F0uQy9wiWVgdZKf9fqKTKiT7/69u62S4q3J/i/5pbvMPP5nEfZqWsU+?= =?us-ascii?Q?rlG40dxw51tl2F4D1Av2JLiUD0BzU5XlOIPHoejkji1xfBIha1AeXlNF6GRg?= =?us-ascii?Q?M16GzscKCJDZvAmmw1mM4vtOGsZywUxDirUuPVqMe4xEwEr1aLh/T3XvmcmZ?= =?us-ascii?Q?+5rLRlRw4ztBwKuhg86j7wTzwZGvEkNFOE5tQDKJXq0OyHsUz4L0m76jGTiq?= =?us-ascii?Q?DpUcFu10DC4gRYNWt2YLFTIjTpQUFdaoWz5yRMM1t/UdH2/kaRTbxuV2ullG?= =?us-ascii?Q?BHg04F/1xcYjyymL+lbBE7qo1E/Z4mF0Nh68CGzfyOEKZAVo5jFizEyb1RON?= =?us-ascii?Q?/Ki8p25XSFzITi2ufaVLaxZv50sEo37VwHC+0PWAvmKcdUsI7rUz4JwNlm7M?= =?us-ascii?Q?x4wLJDOoGIEAEnADacA2Mz7SSHM3gZ+3S/TzHnPjR2MJVmXeRApkZbqjjzS1?= =?us-ascii?Q?VhlmzaTu1TkrRMEDprGi7KewrXWAuZ9ViLW2JtRiB3Y79qcEH1jYDC8CCS4W?= =?us-ascii?Q?Oc4TNHh454CCFZ2vxuIVQgBJv9Tqh5XV59WfEBFCJCWYmmxhY87nqeuctA6p?= =?us-ascii?Q?ZaO45mENHf3Imj158NM+6HbKNK6x/RD3I7Bc5ieG8XT/UbxCAPraOj00BzUm?= =?us-ascii?Q?QCIKnpKd4S/2L/MuR6lCCxhHdHEq+ychIS+WweKhSjB0txN6vswABfqN+I7r?= =?us-ascii?Q?tDEFQ8niJjj/ZI3klmok3MJjop5OZE9ruHxkEv6BzcvhyQiuE8G+QfSSeYxo?= =?us-ascii?Q?uuYgETPIefLjsZPqtpEcdz/t0gDRPHxHFzvniesH7WA99qOXCbFRvDcvx4f9?= =?us-ascii?Q?qCPtE2wyocirdZLCnzkaf+EeEDkv1DCAkWePQdh9FOYTb6t6yXqJGvceqA9g?= =?us-ascii?Q?dHE3Ot1RkKnNFMMGXcooCM3mOZdEEVeb0sJ5nPs9SNZQqRwsH8xpdrvlBCwQ?= =?us-ascii?Q?WaT3kNzXHyGS+SQEd+xd1JyOXe+z49BzdTKCmW8KhqzB1eDFs/jbxIpmQFRC?= =?us-ascii?Q?94gBnIddZKC/0QH9PyZ1JUFSDAqEuvzByzONdv6REkNgvG3Qi94hSIqOARHB?= =?us-ascii?Q?63ppElXdyKbcjGCi26fLW7Ovt8s/EFRLJ1Y/xU8Zu0bxO/z1v2ePiM/GCyJi?= =?us-ascii?Q?T6topwuk4yeVI4O+6uyUoUVmWlWkffQ1nC0ZLZzB7lxOJIjuQKJ/drEhu9Od?= =?us-ascii?Q?8KM7jPuAwWOz12Z7R6SwXr/Cnc397Z40GWc80mscib7Ot+986ZYjhK0zn63A?= =?us-ascii?Q?oufHwvgkyenDRQGEmy60F0Pv+eqHVAgr3CEh+zeWrfRX08xx1g=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5576.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+AF8u5R8WorpT84xg6Ydg+BJ+E9mvibDqokBCorn3PPBlznRYu4qPEND6iqk?= =?us-ascii?Q?Sk/fJw+GkNs14mQ/0ZCTPyCP00POoyFtJQgaU0gIBqWjjJWfU/LdOISyl9us?= =?us-ascii?Q?xBvKMi79C63yvPAzMYIN7KdHBar2Zn5fCCQZkMyllMmPvF02aMEc1JgOEWUG?= =?us-ascii?Q?oXvMH/SopdtB1Lp70noKosKOzfkWos1loQgCmvoS/J6UfuoFp63Df59nHh7U?= =?us-ascii?Q?lnSpb68mIwA89JeYAHcdkPxb7pIHaheNjE4xJyZzyp2BN4LoTILTCIvapzlL?= =?us-ascii?Q?heM1VuO9qiDxrGeEMVsiL/e8ngGyJR0owkCUn4FOihOFuDXGq6hzsWYSvc9F?= =?us-ascii?Q?kaDHTv/0PIpXpB5mQcJxeWKY3dt8gqvdw6ImS2z0MSiReamp5DVqCmtaUgy0?= =?us-ascii?Q?spNQTxht8dkjfob+pBSwgMSVSWv+skwCXalKRjPX/rXxqcIxX226LkyoBzb3?= =?us-ascii?Q?R5AltYw9f+dK3V49jGtwMHdVgrrk616zTXMbrF9sNgxO5cGmP7NrbPrn68nQ?= =?us-ascii?Q?vn6uXye2ylkjx587jjqk+dFAOO2dt68uQlsCFdaQ1jkYkOaXUqEUaiRpOCvg?= =?us-ascii?Q?LJgul+VKzXt9IgWaAi6xGoK7EKxBb75MlXX3nYdFS6PSbswtyD6Ns8bcM0hN?= =?us-ascii?Q?QpMlNVbH+eWakZWshkh51IvhZSx40ZZaKmWzleHCs6IlD2Pg0z6D+006HHyz?= =?us-ascii?Q?vC6pd83/HjeZWo4dnDHw8XkI9dQZNKUWtjRROycpD6t7ogZPUkl8fLT9vQq7?= =?us-ascii?Q?c7G7g0yHbek/+pSuovnmm7QlZ1KSnv2hm7fx6elWrPTvZ5hMMkZNAifJB0eW?= =?us-ascii?Q?pKBwDtkSCm5fCaFmf/Hqu+cyPiZNxAzCx+oCsn0fMjKtK0p9V22sOASLhNnf?= =?us-ascii?Q?Ry+HBHXYanQ7kZBpkFDPaJTVSJ9GwLALYq8Pj+SvqrQs5RAzcNffc5MBI1R/?= =?us-ascii?Q?LOYwYJZiPfQLYafk4JDEWrvGhtIR2ycmPO88AWP4MalghY+cBYYjFKehrzNm?= =?us-ascii?Q?AL51PdvSZSI89QzCIVYeuMxVK+mAZVERXF4rJHViuvIhqw/mTXMNQB7WyiSc?= =?us-ascii?Q?psIY1vSQ3dAHeOn5VQODVs/MTuhYSmtv2gwIXbGUNo9Ge9c3xlRPW59Cb5ct?= =?us-ascii?Q?ZjkgJkqOdKJ/1vqfvELQST0at7rp2oohbnVSoNaMUPGaiyW2SZfCkz6qPdlT?= =?us-ascii?Q?qiMA4/W4pbFqvkBogK7cs8als51pCgoT8zmU0CCn9kWGjVjqvZgNjN3Gmxf5?= =?us-ascii?Q?SDRnhTHrDqdj6c2t3HiTh2PCXv5CVju1/w5wAOe5fVmf6HoqcFp8M3arsC2f?= =?us-ascii?Q?AYHmfr3KTKs01sI6508alkuIUxj814R1zR5gCE67RRCifWwEyVJv1SdXEcbk?= =?us-ascii?Q?Z4XOSa303vgB3Eh6CUJWKnuHGdWnsBZ4hQzh/DXa7BV5ILIlDh5QbyOHDrzr?= =?us-ascii?Q?aLc7LBHoevf10PQC321K1MTkaLx6uIQnSCb9fYB9Am6/dB75DwsM9RcyVb/6?= =?us-ascii?Q?hnri7IWeW/7ZwIoRqu8xB/s1HtrK78d3d/Zfj9mj+OnLTcJLj9+5xL8CWrVu?= =?us-ascii?Q?YiPD55DGU/QgUAh3ldad+M6Gn6/n5EM+FXaEOQco?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a174344c-718c-4af5-8e42-08dcc1c3b5cb X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5576.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2024 09:29:09.5352 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LnqBjE/2n/q8PqnD9vf5KLpGxCrRiJeGXoJgv6sxTuozxzGC1R4ssSpiVYy7LJPXvmqsAHMMv4VOst0lGmbgBQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB7199 Content-Type: text/plain; charset="utf-8" Use devm_clk_get_enabled() instead of clk functions in rtc-sa1100. Signed-off-by: Liao Yuanhong --- drivers/rtc/rtc-sa1100.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-sa1100.c b/drivers/rtc/rtc-sa1100.c index 0b2cfa8ca05b..2e72daa6a152 100644 --- a/drivers/rtc/rtc-sa1100.c +++ b/drivers/rtc/rtc-sa1100.c @@ -177,15 +177,12 @@ int sa1100_rtc_init(struct platform_device *pdev, str= uct sa1100_rtc *info) =20 spin_lock_init(&info->lock); =20 - info->clk =3D devm_clk_get(&pdev->dev, NULL); + info->clk =3D devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(info->clk)) { dev_err(&pdev->dev, "failed to find rtc clock source\n"); return PTR_ERR(info->clk); } =20 - ret =3D clk_prepare_enable(info->clk); - if (ret) - return ret; /* * According to the manual we should be able to let RTTR be zero * and then a default diviser for a 32.768KHz clock is used. @@ -206,10 +203,8 @@ int sa1100_rtc_init(struct platform_device *pdev, stru= ct sa1100_rtc *info) info->rtc->range_max =3D U32_MAX; =20 ret =3D devm_rtc_register_device(info->rtc); - if (ret) { - clk_disable_unprepare(info->clk); + if (ret) return ret; - } =20 /* Fix for a nasty initialization problem the in SA11xx RTSR register. * See also the comments in sa1100_rtc_interrupt(). @@ -305,7 +300,6 @@ static void sa1100_rtc_remove(struct platform_device *p= dev) spin_lock_irq(&info->lock); writel_relaxed(0, info->rtsr); spin_unlock_irq(&info->lock); - clk_disable_unprepare(info->clk); } } =20 --=20 2.25.1 From nobody Wed Feb 11 20:38:18 2026 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2067.outbound.protection.outlook.com [40.107.117.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86B741EA659; Wed, 21 Aug 2024 09:29:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.117.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232556; cv=fail; b=Fr+R27ZBTPcM6XX5L3Y+6FokCRl1hrF6x6JfEA7jN0SK5QZFVHUJTQMDyFJONlhKRij40ziTaBe3iqESVnOPSlfHOA6udUxb4JA8fBH0fhiJ6xlczfoWDKpJhFe0DeKyC+S/2MdT9kI7qBT10npQ7fEhvEwlpxUGFxeEMNVdajk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232556; c=relaxed/simple; bh=Q3rCL/VOfCnybaX6C1aZjp5ldwRPJZgp77pk58itpN8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=Kjj4hP6PR4Myjtq2Skbabku1HJMwUlKgs3tBPL38a3BroEDENQL94GFEpb6IynnE43YnIPCxbJlpCYo1S3spxxi2mjEbaBGv+tDlI/5O25BfN3XIyRxkBgOrAg3meGawdQfYHlTCe/+hMgYq0lgzoQ6xP8xdypERfxMqelRMypQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=alXNH3Nl; arc=fail smtp.client-ip=40.107.117.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="alXNH3Nl" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o7B24rIVe1jgODiU1dTECcsjBFD9k1iajvOMNlNU+eQBXzYdP8UZI01CzylPR8lZ5wm0+fOutk32KtAKoT4MDPSlxwPr1Ngjg/9qlm1tdqXASDcWezTGgESxrKUSAtuq4XFNXZAf66yq/5NeaaPexTfMc2JxajOiGwXbrlxVALxFqzKcvwSiAvGQdOY7NnydbIt+IFB6AELT46Q006TWf3VH9M4WKy1ZqjBN7mVUWiPYtzFsPK2dc34ZNGAY3IjC0Or9UEKHhHHH/SpDn0eoDgDvqmrjmN7IuSNTVGazZka3b4/YNWR+Y5IKGkmqg7aDcg1ER74H/W883Qn+e8bNAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NxBG4zkDUcJFOjixKybmMVqitqT/HyTi6LrglXFB7Kc=; b=kHCXJSaY5SNRwC06nRNpw0/lVHK3oSvTnlozz9n7BNkXEEk5wupVmJLVsq4/NxFxVoIzrMtG3IgufsGreZWDYXLVP/4KR8otvoQu1siAOoWa3TTzy7UQ5hetLmw9UVSvNleyXHgn7dbQpRjscdtrnxHwdX/MMFqd0pRqJkUm6Vdb1jjaWW9Vo7ywBzMXhLD62JGxVgaMqzOHtWejl/e+1wGcajoYDedW3rjLPWJ1SsQLNpFQXvcTvu5YMv01U9vpzHukpZN0QX0LVse5xXq6GWSrC5M3d0ntvRVR1+uTjyvUZjDm5Ji6CUlP81bJtPoFKIxuSMzqrP/4AqxfS4OLzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NxBG4zkDUcJFOjixKybmMVqitqT/HyTi6LrglXFB7Kc=; b=alXNH3NlbIRNSkpYO7J/o0odbr9O4mZALkFf0nVUINFRp48YfcA5joDCoa4skZ5bLlc6Dw1mRDGpl0k/vgM0MEwK4pLHNlzleE7KtQkv1khinJdivwfwey+GAAIm/TNdjs3hcLm5oxNsZd/drjCIG+tXKQ0PmhaYY+ytT0MevJdPMs6hlBo+Nin0UPl8wsD3j9mN6G5raFTeq6jxfH7e5S0AXtpS9GSxGeADEF+75YPvjOl4Fqopo4CcOwQD+/G62ablve5fAK84bRzPPHlSXPN+JrvKzfp9u0B0aO2BMgkl8mTgVDAlvzHJC+rV0j0iUzSn6aFcq5riVdJRcflI7g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) by TYZPR06MB6093.apcprd06.prod.outlook.com (2603:1096:400:33b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.21; Wed, 21 Aug 2024 09:29:11 +0000 Received: from SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6]) by SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6%4]) with mapi id 15.20.7875.023; Wed, 21 Aug 2024 09:29:11 +0000 From: Liao Yuanhong To: alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Liao Yuanhong Subject: [PATCH 6/7] rtc:rtc-tegra:Use devm_clk_get_enabled() helpers Date: Wed, 21 Aug 2024 17:28:45 +0800 Message-Id: <20240821092846.20138-7-liaoyuanhong@vivo.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240821092846.20138-1-liaoyuanhong@vivo.com> References: <20240821092846.20138-1-liaoyuanhong@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0001.jpnprd01.prod.outlook.com (2603:1096:405::13) To SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5576:EE_|TYZPR06MB6093:EE_ X-MS-Office365-Filtering-Correlation-Id: fc403504-dc37-4085-e6f3-08dcc1c3b6e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LJxtruSUwaFSQW8VAhvzNJ4Ke49kfSChRl+fwbZA4qvrsXZgN6Yt4gucge8/?= =?us-ascii?Q?Jxeryj0+vZR84Wtf9Jfh7VAX9hnekIc2x9/bwB8EiWAqxBXyXrzXoKRca1XD?= =?us-ascii?Q?LeCLc9d3GA+8HuHWkZ38h0KK/GigsF2Ygw5uMGX+Xt0adsuxghmnWNp+oDD2?= =?us-ascii?Q?cos1h9fDGh8z5SWgRy/aOb/LniWyToZ7v4pAbsZEEBpgbXT1SCXDMQ9/AUj7?= =?us-ascii?Q?60IDS4PmeJ5alkd2VerItFl1xmS4JlQjQ9hjibgi6o5IaAeeS0b2WcrbGIxr?= =?us-ascii?Q?yLPCdSRkweX2rc2fCQ3QmKHQmysosf5asJaRdRsK9Gs3fVX9gaoiXLEdAPeU?= =?us-ascii?Q?GdPqwFRTpUh7fboK7HSDsOvVXy/OKtLajr8Wpoo1iBwj1lUwfxAbbfAR7VZx?= =?us-ascii?Q?vnIccA6ulyADqbeIoLl/NzZVrq8di428/05QwhW1OWVmZEzE+9n9KCeYCDZF?= =?us-ascii?Q?C2HtwRgfXvxy+N/aIG5EnAcd5SYhxOURiay4MDtq8AMNRLAmDop0DI1Lzh/d?= =?us-ascii?Q?12DsjkafQvr5WxD0Hq2XMr0QovDYNo2jERwoRyF4tie85emPfLbgchNboboH?= =?us-ascii?Q?W8uAt5bfYYrITya7w3cBySK6y/HGQR2ySmLBYEDFqNsYjGDxQ5cgdRsKuA6w?= =?us-ascii?Q?BpuqoTeighU9iJa3YVHNWwWvPDA1zMTO/bNi7I9Da9GaYR8rkQYpYBV8s5Jw?= =?us-ascii?Q?vzHoi5WEUS+4DFZnyHP93GGoxQiFtTmflkSbpFtmMZR+OB7ytMsXruPieaGE?= =?us-ascii?Q?i9rU+gwWFJ1OUKBYVlYNGavHPqY57hdBhhFhf7Jdq0IKTv1EhqkWIFOMRgGi?= =?us-ascii?Q?JGSN2sOW8szfNfXx1l73tq3BWtQfEcXaTPMoPUnZb3Ny57UfaIvna+mNg7M6?= =?us-ascii?Q?BFKLPZ9FQBwVzNYhVp5AJy/HYYK9Ar/EEIsueYIfVfXaLfI6mutKOg8OLJ3J?= =?us-ascii?Q?2R2a1YdDF2IjfF/Ba7NoMhZdfKp2IGcikXoXiSFEcvu+khKiaDwx/NMnS8gD?= =?us-ascii?Q?leRoEOQ+nY71jBtul6sTQrMmW4J39HO0ScXzqXc7KuT7IjXSatoVxpUdVUUp?= =?us-ascii?Q?7o1wl4fC2qie59ZKg8oi1ZIWR8WqVqsb7t/d267xJ3l00uOiQrcO5duMxBUO?= =?us-ascii?Q?yTyUmSf+ppuxP+9Rpd0FZN8x1Uy8tyUhAJqGM8yOk9vsIjlPMu6TXPVLtf3e?= =?us-ascii?Q?qaXzYYfWVwy3eGeorJnF1WQW9N7w5nvtdlkQFwvrQUlzSuRfP0jslq0Bfrno?= =?us-ascii?Q?VzD95FsW67v0fDh37Q9Rb1N5bMQnRc0RQ2NuVHo5b4v7c3i58X5eHMMBooaz?= =?us-ascii?Q?VSp+/xAT2Se29DNRp4i4+xxmn6/AeUYJHZdVOqZSdmgeJpMU2luXJGhyrBFQ?= =?us-ascii?Q?hfPbUDM5HpNxXENkO1Low/c/e/Un2SIOzW4lqzHLjxZCjllh2w=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5576.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ABNJI6qhLjI+k1oBNyRYH/8dZNMDjVhXea9u71mJJHSXjdI4WpcYFwkWhnGd?= =?us-ascii?Q?JNEbHvHLaPH8jdkzZjgBRWMWQLZICkHMnuyYmcMC1A+92t4MgfrnKcP+gR2D?= =?us-ascii?Q?OxlTVlcDMpmH12/XAxsILjKIfLZQOuAmsVz4+XB4JaWVc5U6M35Ucbjq+a/U?= =?us-ascii?Q?KxN+h9lzc9/J/n9LJGXGfAwvNXWKkM3ednKW4eJH+SC2626/D3juGjxY3Fah?= =?us-ascii?Q?aQAZ12BPxNXcYw4BjM0wuzfeNcKFqc7caLisweLU0KeOI9FyL0F0BjcOZ0MK?= =?us-ascii?Q?5muRuT+OTlk5iKFQeIsHxbn2zmrfiJ4YnAP9v7tlG4YpQXe9sQuQZ+1kb6tk?= =?us-ascii?Q?yTmQcmGBntNGXeHE1oJ/4U+1l0SCDNgH4NH/zZPvRwsOHCPPIKak/L5QzhMK?= =?us-ascii?Q?TZnjyj2ZRuQmVohaPzl1aNxXAUZxqMtSh2leJYcshJ+YhuRBFxeyAImO7uSn?= =?us-ascii?Q?7kQiUYZsYMY4uKtxzIrImSV7h7w74SmN7hKtw7NYs8BXFPDEzRULxWL1pfpl?= =?us-ascii?Q?hve1SEhosVIvBSdIZjNbC1h05Cijp2pqtKgaWK6JEN2OYEb8FSxRTQY3GY0F?= =?us-ascii?Q?uAFUwSxjVXvjUURttvCM/iA8NgBNAQqUWUiJOBOGeHlohwD8krb4ikN8geJy?= =?us-ascii?Q?AX2rTk8kUwASrGiQ+CGh2/lg1k6yyjQkDXBLmZRkdeRWEaJbKJ06zdIjvENv?= =?us-ascii?Q?+Kqg2xukSZZtGTdpr0BF6dP3DQHwZxHCdzsaFv30ffs/ePKTCXEtVc7++xh9?= =?us-ascii?Q?7kD37Awm36MnO6AawDpqCO+zoMeArNHfLO6d4kgSR40V6XfkWg+YNHHGaeP1?= =?us-ascii?Q?QpK3xN17xr2Q5necKeXkHSY46OT8EhQkJ14rXfwz0W0zNBjSkjwP5SpiAPBW?= =?us-ascii?Q?oIL0nCrYlj+4aShWWG1KpNq11ub0+0dVrVs0wVZUQyMU/6Xf4V80EM+sJ28q?= =?us-ascii?Q?0GuQp7mdK4jWYbDBPyXMdyHIYZoUBpYxHqgR6osUmBenhxpqMth0u7l4mjnD?= =?us-ascii?Q?5Nx1oEjNvnSV7jqBgvz8wGJo7deW0vj8GFR97cy6/iZOLzzL90rHjm5X1Ljw?= =?us-ascii?Q?t19EgCy5LnKEFm8A7lt027RRcf5E71KiWlWRr88fxt9atLd2ECmQuwyWnV3e?= =?us-ascii?Q?EHaF9lFpZ80n6y0fMjVe3cF5ZRtMH0nm5iiRwv5fBgKBnZM/8twF4+h3mzpH?= =?us-ascii?Q?/6Axsrkl0puAApxlUCekEhC8lm6I4shG35hoRHUm0C3XHnrq6f+/tS0nukzG?= =?us-ascii?Q?v0KrojzK14GBpPbFVOxO+8VlOwmDrMKS9vI88mC/irigv3sheP3TYmrfoau6?= =?us-ascii?Q?9tGgjIt3OaXcOqxzEoqWQXpiKe76bf34Ho+na7w7h1E45GBitynUEqJyHX4y?= =?us-ascii?Q?Zw+KwfFJ6drM+6aUX1hIX7i8ptlu5/w4j0oPiyIUGcazKr2rl6rHhCu0xEqL?= =?us-ascii?Q?Xfe50WdcQeYOwvpC6Vb8Ui2BYq70tidqMYLteXa/EuRj+iwnergw1DnYsv7V?= =?us-ascii?Q?i8N6hYB+AcAKrbf1ZQ6bR8+ESdBgFMmAga8ekdkR5fuuvfT2cnpUwQxjhkyo?= =?us-ascii?Q?MaLasukhWp2FzyuxYJr7AsDZI2CcY1AooAXuvxT3?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc403504-dc37-4085-e6f3-08dcc1c3b6e8 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5576.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2024 09:29:11.3120 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hRRQx3CdFuOA2C6QSe+CLAx2N8UWhkoSLpbMBSIKsG6ny80o6dDnwyQxvbKzXFyq9Ae+vtw5JA6BeX4lrX37oQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6093 Content-Type: text/plain; charset="utf-8" Use devm_clk_get_enabled() instead of clk functions in rtc-tegra. Signed-off-by: Liao Yuanhong --- drivers/rtc/rtc-tegra.c | 22 +++------------------- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c index 441e0a66b215..28db5b8cabdb 100644 --- a/drivers/rtc/rtc-tegra.c +++ b/drivers/rtc/rtc-tegra.c @@ -300,14 +300,10 @@ static int tegra_rtc_probe(struct platform_device *pd= ev) info->rtc->ops =3D &tegra_rtc_ops; info->rtc->range_max =3D U32_MAX; =20 - info->clk =3D devm_clk_get(&pdev->dev, NULL); + info->clk =3D devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(info->clk)) return PTR_ERR(info->clk); =20 - ret =3D clk_prepare_enable(info->clk); - if (ret < 0) - return ret; - /* set context info */ info->pdev =3D pdev; spin_lock_init(&info->lock); @@ -326,27 +322,16 @@ static int tegra_rtc_probe(struct platform_device *pd= ev) &pdev->dev); if (ret) { dev_err(&pdev->dev, "failed to request interrupt: %d\n", ret); - goto disable_clk; + return ret; } =20 ret =3D devm_rtc_register_device(info->rtc); if (ret) - goto disable_clk; + return ret; =20 dev_notice(&pdev->dev, "Tegra internal Real Time Clock\n"); =20 return 0; - -disable_clk: - clk_disable_unprepare(info->clk); - return ret; -} - -static void tegra_rtc_remove(struct platform_device *pdev) -{ - struct tegra_rtc_info *info =3D platform_get_drvdata(pdev); - - clk_disable_unprepare(info->clk); } =20 #ifdef CONFIG_PM_SLEEP @@ -399,7 +384,6 @@ static void tegra_rtc_shutdown(struct platform_device *= pdev) =20 static struct platform_driver tegra_rtc_driver =3D { .probe =3D tegra_rtc_probe, - .remove_new =3D tegra_rtc_remove, .shutdown =3D tegra_rtc_shutdown, .driver =3D { .name =3D "tegra_rtc", --=20 2.25.1 From nobody Wed Feb 11 20:38:18 2026 Received: from APC01-TYZ-obe.outbound.protection.outlook.com (mail-tyzapc01on2067.outbound.protection.outlook.com [40.107.117.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41C6E1EA676; Wed, 21 Aug 2024 09:29:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.117.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232557; cv=fail; b=VZQ1iA2N3t+VOybWPqzK8aLBdg+VTr72PYuJUnq/9PSAMfpa+cpyBXyIt4lAL4/iKbt0Ed0qOb19p9abvgYZs0fPaDY4AD3ng7wi1YzLkCuPcbwl24C4rH5N1a1siNM4/NTkrrFEjy7MyJ48nYrlPKTwVd2i/NQ9GOHaCkmQAEE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724232557; c=relaxed/simple; bh=L+0nTnBwGyyaVYt0ctpr34Fh+dPCcOKwzPebP2OdXs0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=CnxSXS0rDHiOQEgEj+ryXRaiNBhvOd5l3mavYzZfhPvTSzqe80KtEFRCYudwQkyyBNpVjJzSehsiHBmA7syoyXXN9IFZ//pa4yfSuWz2i5T6XJ5Fdy7BmLamniyEV2fabyUNfKLfnB+Mpj8Exo9LVM7I68PEnx6x1qpHHD6g0/Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=idkpE8a1; arc=fail smtp.client-ip=40.107.117.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="idkpE8a1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G+a0zr0T7BCl//NE8Atm5qlu/U6ZsIiPCTCW/4V/Xhi6frf6QpOwMUUbWR5sDjAe02isaN5FnEIzJiECj+W0sUMRo2rwV4dQx4fC6YznYRNgfZXbGKoDsdl5T6fvTMxMDvrsMzLU+zjFi85bazCCtN24EXzmoV8vWlVd2tzrcHF2cuoAXeOIoMyZXXijRXnd/B2CQ1E4KJ8TSZoisaeKBpP7a9P9dihiSKa3xg49pWnUXHD61HJW7QhpxAKZSCtocYs823wfZfYpoKiZ8jmwCX/FiS9tfAXsHKZfP5tYnug8yhl6CWwhGs+PB7zeCNe3s5aQt5PDEbXQv58/Nv2cgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MfJGTBnnQHpNSt3ROQlwAAJ4CMsk3ueNjLX19doj7Ak=; b=SWuOd0MeTlDQlxRvwWyM09ACepG96HGh9FGdvVE2K91Od5LAHSbQoCltzW+Jz0hG94/19TrY57l6+Q8asLUtxDLsauQJlqcLKX6bKWpKsCB7cnvdlkcY6m1tC3FUqmcZR/do+1/ZASKRvn4wT7q6oBg4rGiv3QDWKpscY3kXAlScvmJB7Ar6oRAE80Gkp9QUSy2McabSkaRni3OurYNeRBiW+i3J/DvgfSVADhMQm4RY3zxjJYb3gvZLiAKMjf5J+ZRHiU0YoCDP76ZZ8gJDZ8Ga+0lOBcpXDFWBMcMwGVjADsB7RiKCftxbjQ65hA5Cq5GH8ANCtehyXRgnYRfKqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MfJGTBnnQHpNSt3ROQlwAAJ4CMsk3ueNjLX19doj7Ak=; b=idkpE8a1iYjtVHbilO3BwYLA6UHdSnxfsrjLSIVMdMuJbm6qhZQkCGF0rkDD01va8PV5EtmXKRRmRgH2/SEqcOeB/mnlYU1N0RO0hYsw637HG4v64VBIkD4Dym5gv3590/6bDW86OCCMiJ+H/mXInBABYQvbiUwyn2P9BIrRPHm5NRQLOCLc7eHlnH4IUKF5EYGjWytJMz5aCUI8YW8AL5OTD3hky/jvcZ7n57UTq7T6sn1kPP7XJJREY2oL4jCzJRuTRwbnBdQtEFqg3JubyffihMipquL41fgKAPpU229vO4cJThSAl7msKb6bPUJWevEoOuD2xFXYz8yUfKj4Fg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) by TYZPR06MB6093.apcprd06.prod.outlook.com (2603:1096:400:33b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.21; Wed, 21 Aug 2024 09:29:13 +0000 Received: from SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6]) by SEZPR06MB5576.apcprd06.prod.outlook.com ([fe80::5c0a:2748:6a72:99b6%4]) with mapi id 15.20.7875.023; Wed, 21 Aug 2024 09:29:13 +0000 From: Liao Yuanhong To: alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Liao Yuanhong Subject: [PATCH 7/7] rtc:rtc-xgene:Use devm_clk_get_enabled() helpers Date: Wed, 21 Aug 2024 17:28:46 +0800 Message-Id: <20240821092846.20138-8-liaoyuanhong@vivo.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240821092846.20138-1-liaoyuanhong@vivo.com> References: <20240821092846.20138-1-liaoyuanhong@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0001.jpnprd01.prod.outlook.com (2603:1096:405::13) To SEZPR06MB5576.apcprd06.prod.outlook.com (2603:1096:101:c9::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5576:EE_|TYZPR06MB6093:EE_ X-MS-Office365-Filtering-Correlation-Id: a668406b-b7f6-4e4c-c3cd-08dcc1c3b7f5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?C5VyZzf7ML84VNuE/Sr5th+nlLf6GOjHRUoPnvHeR6tA/0V9SYLa8ltc+fn8?= =?us-ascii?Q?9GhvwR9bpueVHhef0TVj0BKBl5U++sgptWKzPOKm19Y7fq21XpSPqWviMU43?= =?us-ascii?Q?4hb+eHXMW2jTFMBI/p15FUkpD4zzzn3d4RRgUnjc+G8GEh+3NLqQvdZY2f+u?= =?us-ascii?Q?AAlXoOiFdceZnS7xGTEZb8JQJpk+y+rfaWPtOrFyL2L+5/akcCyDXOvDlGc5?= =?us-ascii?Q?heJhVdZtf7bRjaLoRmvVu8qrf836VDJsL28AHgL2NEZI0AA2LHJoV2ursCJ0?= =?us-ascii?Q?/RSMb8ahLbQ6Fv0JPk4bu/1GEhiKLQsNaMSPiSNLBpD0K2lG6K6Dkn/4aqfX?= =?us-ascii?Q?sbkIGKqFiJqk7SY6EYUJ+kZZ8pPiMeOsmeAWXZGNd/rcMQOrWP+WG7VgZ/Ue?= =?us-ascii?Q?9IbyOGymL7J/JZD3lwTRoGZtcIF7BK2g5INax+1ci6VKd4RLz9T1Kx1lcmkk?= =?us-ascii?Q?EpgznoOkvNZpgrkQqs7SK2fF4MpsgdA+SxfokUsEZNDnfN7dT1N4mnRcS3Re?= =?us-ascii?Q?1U/qPTI8Kqgn4Oao3NrlTuF09hFvhiKsred44ufNYxrThXJzzWAGDt8CdoOk?= =?us-ascii?Q?BHbi3EW55m5TekiMQd2tbPRev2CnWFJivJ9hpMu4Mo8+2bcL5Dwpre5vTuXr?= =?us-ascii?Q?4dY/6XsQJMjb3o/ewUTkzwaK/xOJTRZcxKSM5eynq2GWAUvLt1AL9GB2WLI4?= =?us-ascii?Q?dyRwNvh8jbzBn3p0M30xH6MO9PAHXgM4kCQ9nT9pUBFknw9g9iBSt6wkTWFj?= =?us-ascii?Q?e/9a+qNE2FCb9/P7XJfscgMWjBicf2L6oJy0Bvwulc2kTZ30ldMB6pjIGdFX?= =?us-ascii?Q?xiAIBlsYP7+15QQTzMjh7CiuzkAWFiJShbqZPwYCIBm1P6KqdL6ldJ8mG2mO?= =?us-ascii?Q?9ft/KiC4kajPxSU44haw+BBjUBdsTFmXQP6uZoMI+VJI30B+wrRv5K6FI8lc?= =?us-ascii?Q?z8rjjVDTOwMxEIqItdWHnGGE5vd5ZT/NRiDFX2vllkN9hRVeq0N9Mo8+7zOC?= =?us-ascii?Q?rdpPdLw6145Z+tsBraWv5ag5XpHxI/hLddIPC49jTPhjLl83R/sY5zOe1nKh?= =?us-ascii?Q?HR+MTC57BOyop90G0Ab6HF2jje7R6TDJxGoRg1FpZKP+TXDcjV4Z0iRMd8g4?= =?us-ascii?Q?vgpgJNvfzMKdFSCF25A4xupDXqYPC2TXovUkcxZwMsCj2LEKku0Te6bwfEr5?= =?us-ascii?Q?1UfZ1MRrg01EgcXd3vwAM+pEyvx/l/vIfZuuuj5FSn1X/KTI40UcMFosVw5V?= =?us-ascii?Q?t2Eu2X9M9y3dlnBoTnFnpRVwp15BMM98ESYuYOrY/dfdcVu9cLvr/nNkli+b?= =?us-ascii?Q?Gn5pi2YcC6oNca5BqywqvNlFgklU/M8PTuUBGRbN7duGTF76OfMFcwdxgxpj?= =?us-ascii?Q?cIn37omV1h/8wQoyFeX5XBMMReZp4xRw29VEhvflutwkA36Fzw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5576.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/bEglT5BDGNlRwON9jKtyKdkK6EHc5jWD4W/zaE7Y7DZBZhYiCKMOxUYeTUk?= =?us-ascii?Q?NwEe1K/3172ReXHWcLEJ7zjCFLmJcwcpuvNdZ/2ttNzjSkIAjf8cwe8kemvZ?= =?us-ascii?Q?EyavV6ZbTkTnza9ma8HKHZvXch2uYy05l8pbOQ7BIr+1rzk8YricMrzqQVPe?= =?us-ascii?Q?VPsyaOA8aqW2fsm2jY212HGwIcC65v8bNE3gWyqg1Ku/NqCaFAnclBGDZMlX?= =?us-ascii?Q?Sn4GxTpHyj1Cu640dvaSUj+ZqcfNsGMz4FTA4X362c6FxLmqN2GSTCVBs1U+?= =?us-ascii?Q?jrxb5S94ERyVKY9pjq/sgc9arJRrFMBCbBWTgM40a5rZW/uNRB4gNXhrP5ve?= =?us-ascii?Q?DJokzsw1p/beapI5dFOi8XnbMWsIRHeQYzqaguqGHBREjtEKEjxbQdoINKlQ?= =?us-ascii?Q?7kCF0I+MmvH8lPhq3vROzsW9YIFETQRvKWcS23Tc90Pu17HwuX/EE40mM03E?= =?us-ascii?Q?0Nj1zNXaMmjaWZqGvMQrLkA/7v57IZWaibJE8C9EF6vblS/TZcUl/a+GNCFM?= =?us-ascii?Q?j010Lo/7lf5zDNtSZsvvcgOyFNSCI7GT2CVUJezmYFSQ23bvIK0YmY1jKAed?= =?us-ascii?Q?picQRpNUIB4CsbSxnaZuvRKmR00Rv7L3jwaEZHpL3OdL2MzjkKOKgb2MbtQd?= =?us-ascii?Q?ruKzYQDyJRuwJq5MZywxwJ1X3ETxQQfyq5WqT461n4ZPTwg44X3RkVrAr+fC?= =?us-ascii?Q?Ebzd7L5PdIqadSmpDG7S9wbzOZjOQx1j+bhcOkb8JNfX3NW9zwncqnTbZK+h?= =?us-ascii?Q?YKYbmSoohTWmf93/mdD0OFZwQw6S4gVT1Y+xrjIZA+ABd9OU6mFUKtmPNrVU?= =?us-ascii?Q?CYvC49sanvDdtHebghyN7k7wGXW1vwLTDXuVzmo2bNT+0cr5FQ1G6Ramy5zi?= =?us-ascii?Q?1dHGVwNIGLCHzVvVBbBNSNcHd0eIOZMCIJmZwLEcP/hmR0PDPV7hEfum1P0T?= =?us-ascii?Q?gorxDz0z671QD7n1BUilsWUBuwlmfVyddpNSy7n+ypj6P1SuS12i3DuHCTay?= =?us-ascii?Q?db9UkouzOvLChWBnipbXytvwzIe38YXtejngF/lGxE9rQRFtp1OASRtPMIXS?= =?us-ascii?Q?4Uaj6NRYCWEfjXb8UznuUgxbdkqfN7OJXWsIp1RE5oGXEwqm2NJp9WTovcgC?= =?us-ascii?Q?+q/TRmygcptQqoR2yNLP3osQcHDffjks6i+WDIWU0hTjNm/aAdNAW2KJFEsr?= =?us-ascii?Q?silwNxDOR+/vNQjBlGdSMRjwL8jN4q1eeBMJOFpuWzozr73totvmr2nZsyx0?= =?us-ascii?Q?1WAoNqjM4N1Yh1l1uwxfyWL4ev3PMUFoZD/kp7Iy4nxIavztV1c4pEuitRrZ?= =?us-ascii?Q?HerwOnFizsEOVHA7N1VCPfvD+/8YdNrHn0F/E5i4vRaI9RHv+FdY5VMiVUIR?= =?us-ascii?Q?cRV5qV7OIAQ9Uc+XewYX9r5eqSYzGiWI1PcZ1LAaurvJgbtaqlB5BhQv0DPD?= =?us-ascii?Q?oEOTCs9DFQXE1v3kPDQhSKrKUs2w2NX6JvD+5LnPGdKkXL1V580/USOuSBca?= =?us-ascii?Q?WMbIRcGgKyK/Ygzot743e/6DfU5rARbX+iPph6heAcFeDS5LSz1huJFZtHcy?= =?us-ascii?Q?QYBTfYJnwwKFPdYK3goNZzNCZbaERo1ag/EukqTe?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: a668406b-b7f6-4e4c-c3cd-08dcc1c3b7f5 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5576.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2024 09:29:13.0830 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 79wqwf2HoZdN+YnrPdIXj/BznEhszUhjkxf+1MC+yAsC7ixohEoXEqp/YRaqdEsiKa+XHnXDISP4+x08MGqyKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR06MB6093 Content-Type: text/plain; charset="utf-8" Use devm_clk_get_enabled() instead of clk functions in rtc-xgene. Signed-off-by: Liao Yuanhong --- drivers/rtc/rtc-xgene.c | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/drivers/rtc/rtc-xgene.c b/drivers/rtc/rtc-xgene.c index f78efc9760c0..96567c3906c1 100644 --- a/drivers/rtc/rtc-xgene.c +++ b/drivers/rtc/rtc-xgene.c @@ -162,32 +162,25 @@ static int xgene_rtc_probe(struct platform_device *pd= ev) return ret; } =20 - pdata->clk =3D devm_clk_get(&pdev->dev, NULL); + pdata->clk =3D devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(pdata->clk)) { dev_err(&pdev->dev, "Couldn't get the clock for RTC\n"); return -ENODEV; } - ret =3D clk_prepare_enable(pdata->clk); - if (ret) - return ret; =20 /* Turn on the clock and the crystal */ writel(RTC_CCR_EN, pdata->csr_base + RTC_CCR); =20 ret =3D device_init_wakeup(&pdev->dev, 1); - if (ret) { - clk_disable_unprepare(pdata->clk); + if (ret) return ret; - } =20 pdata->rtc->ops =3D &xgene_rtc_ops; pdata->rtc->range_max =3D U32_MAX; =20 ret =3D devm_rtc_register_device(pdata->rtc); - if (ret) { - clk_disable_unprepare(pdata->clk); + if (ret) return ret; - } =20 return 0; } @@ -198,7 +191,6 @@ static void xgene_rtc_remove(struct platform_device *pd= ev) =20 xgene_rtc_alarm_irq_enable(&pdev->dev, 0); device_init_wakeup(&pdev->dev, 0); - clk_disable_unprepare(pdata->clk); } =20 static int __maybe_unused xgene_rtc_suspend(struct device *dev) @@ -220,7 +212,6 @@ static int __maybe_unused xgene_rtc_suspend(struct devi= ce *dev) } else { pdata->irq_enabled =3D xgene_rtc_alarm_irq_enabled(dev); xgene_rtc_alarm_irq_enable(dev, 0); - clk_disable_unprepare(pdata->clk); } return 0; } @@ -239,14 +230,8 @@ static int __maybe_unused xgene_rtc_resume(struct devi= ce *dev) disable_irq_wake(irq); pdata->irq_wake =3D 0; } - } else { - rc =3D clk_prepare_enable(pdata->clk); - if (rc) { - dev_err(dev, "Unable to enable clock error %d\n", rc); - return rc; - } + } else xgene_rtc_alarm_irq_enable(dev, pdata->irq_enabled); - } =20 return 0; } --=20 2.25.1