From nobody Tue Feb 10 00:40:00 2026 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86CA449652 for ; Sun, 18 Aug 2024 10:43:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723977829; cv=none; b=DUWod7t1hb/AjPIw+o67H5V1as8n5T5Djr/UTAyWZP6jYzSZoadcI2xv6/1W/Jba0UW+YUrCf15UGDuS20I6qYhHKK8giG9FiEzf7e/5eSVehjX8XNEy4DUhc5OgoRndJHV0a1SgHTwKdCvcYIICAGkiItc0hopsHTjMdvFlHc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723977829; c=relaxed/simple; bh=8OwIe+Om8PJ/rkkIDNqTcxOw4A34J4vOTXzTD8uyJD8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C27Q/xEvDmMgg8MQM6no4QHxy5MrZTAtgbmIBqKvfZ6yO+WCht1T/aoCIOfifuv5fYuF7eVjOxXb2pGFRlbWiTZhCRmEA8jXLOh62FPuC+sQCCDynFuHhbGlQLa7I9j/KhyrCiJBswIHEawB1kXtWo5r3KRw2ZnbC1Xeek8UtTc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=oNPK3y9K; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="oNPK3y9K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1723977821; bh=8OwIe+Om8PJ/rkkIDNqTcxOw4A34J4vOTXzTD8uyJD8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=oNPK3y9KB0tVRgWv7dpEZrbSixZh0XGTbRjOOD+4vpffIP8ZLeZLshQTjGS9W13rO bP4LCpMtxds5+Xrt3dUMkNUx6qujeMEE+QhmpVnM1Vtb0P4fLhBSgzyMR9NRmUoLg5 FCNaRcPpJHUqqGoXRbdcDJ9hJOTieHX9bE/e+0U0= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Sun, 18 Aug 2024 12:43:32 +0200 Subject: [PATCH 08/12] drm/amdgpu: Switch amdgpu_connector to struct drm_edid Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240818-amdgpu-drm_edid-v1-8-aea66c1f7cf4@weissschuh.net> References: <20240818-amdgpu-drm_edid-v1-0-aea66c1f7cf4@weissschuh.net> In-Reply-To: <20240818-amdgpu-drm_edid-v1-0-aea66c1f7cf4@weissschuh.net> To: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , Xinhui Pan , David Airlie , Daniel Vetter , jinzh , Aric Cyr , Alan Liu , Tony Cheng , Andrey Grodzovsky , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Harry Wentland , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1723977820; l=11816; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=8OwIe+Om8PJ/rkkIDNqTcxOw4A34J4vOTXzTD8uyJD8=; b=0Zk8WvCbJZ7DRz5Olf7xiaL2ZhTfRI4okKsiaumYhHpWKPjK4EV8Wyv+JPPc8LHlSuIfWAzYy TfI2BsB6l9CBeFIKxU/9MBk8Ana4yhe7XLsiqXQTRYvcZOl2nTt2QF+ X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= "struct drm_edid" is the safe and recommended alternative to "struct edid". Rename the member to make sure that no usage sites are missed, as "struct drm_edid" has some restrictions, for example it can not be used with kfree(). Signed-off-by: Thomas Wei=C3=9Fschuh --- drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 56 +++++++++++++---------= ---- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 3 +- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 4 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 4 +- 6 files changed, 38 insertions(+), 37 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/d= rm/amd/amdgpu/amdgpu_connectors.c index 344e0a9ee08a..75eac808b9e3 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c @@ -246,10 +246,10 @@ amdgpu_connector_find_encoder(struct drm_connector *c= onnector, return NULL; } =20 -static struct edid * +static const struct drm_edid * amdgpu_connector_get_hardcoded_edid(struct amdgpu_device *adev) { - return drm_edid_duplicate(drm_edid_raw(adev->mode_info.bios_hardcoded_edi= d)); + return drm_edid_dup(adev->mode_info.bios_hardcoded_edid); } =20 static void amdgpu_connector_get_edid(struct drm_connector *connector) @@ -258,7 +258,7 @@ static void amdgpu_connector_get_edid(struct drm_connec= tor *connector) struct amdgpu_device *adev =3D drm_to_adev(dev); struct amdgpu_connector *amdgpu_connector =3D to_amdgpu_connector(connect= or); =20 - if (amdgpu_connector->edid) + if (amdgpu_connector->drm_edid) return; =20 /* on hw with routers, select right port */ @@ -268,8 +268,8 @@ static void amdgpu_connector_get_edid(struct drm_connec= tor *connector) if ((amdgpu_connector_encoder_get_dp_bridge_encoder_id(connector) !=3D ENCODER_OBJECT_ID_NONE) && amdgpu_connector->ddc_bus->has_aux) { - amdgpu_connector->edid =3D drm_get_edid(connector, - &amdgpu_connector->ddc_bus->aux.ddc); + amdgpu_connector->drm_edid =3D drm_edid_read_ddc( + connector, &amdgpu_connector->ddc_bus->aux.ddc); } else if ((connector->connector_type =3D=3D DRM_MODE_CONNECTOR_DisplayPo= rt) || (connector->connector_type =3D=3D DRM_MODE_CONNECTOR_eDP)) { struct amdgpu_connector_atom_dig *dig =3D amdgpu_connector->con_priv; @@ -277,32 +277,34 @@ static void amdgpu_connector_get_edid(struct drm_conn= ector *connector) if ((dig->dp_sink_type =3D=3D CONNECTOR_OBJECT_ID_DISPLAYPORT || dig->dp_sink_type =3D=3D CONNECTOR_OBJECT_ID_eDP) && amdgpu_connector->ddc_bus->has_aux) - amdgpu_connector->edid =3D drm_get_edid(connector, - &amdgpu_connector->ddc_bus->aux.ddc); + amdgpu_connector->drm_edid =3D drm_edid_read_ddc( + connector, &amdgpu_connector->ddc_bus->aux.ddc); else if (amdgpu_connector->ddc_bus) - amdgpu_connector->edid =3D drm_get_edid(connector, - &amdgpu_connector->ddc_bus->adapter); + amdgpu_connector->drm_edid =3D drm_edid_read_ddc( + connector, &amdgpu_connector->ddc_bus->adapter); } else if (amdgpu_connector->ddc_bus) { - amdgpu_connector->edid =3D drm_get_edid(connector, - &amdgpu_connector->ddc_bus->adapter); + amdgpu_connector->drm_edid =3D drm_edid_read_ddc( + connector, &amdgpu_connector->ddc_bus->adapter); } =20 - if (!amdgpu_connector->edid) { + if (!amdgpu_connector->drm_edid) { /* some laptops provide a hardcoded edid in rom for LCDs */ if (((connector->connector_type =3D=3D DRM_MODE_CONNECTOR_LVDS) || (connector->connector_type =3D=3D DRM_MODE_CONNECTOR_eDP))) { - amdgpu_connector->edid =3D amdgpu_connector_get_hardcoded_edid(adev); - drm_connector_update_edid_property(connector, amdgpu_connector->edid); + amdgpu_connector->drm_edid =3D amdgpu_connector_get_hardcoded_edid(adev= ); + drm_edid_connector_update(connector, amdgpu_connector->drm_edid); } } + + drm_edid_connector_update(connector, amdgpu_connector->drm_edid); } =20 static void amdgpu_connector_free_edid(struct drm_connector *connector) { struct amdgpu_connector *amdgpu_connector =3D to_amdgpu_connector(connect= or); =20 - kfree(amdgpu_connector->edid); - amdgpu_connector->edid =3D NULL; + drm_edid_free(amdgpu_connector->drm_edid); + amdgpu_connector->drm_edid =3D NULL; } =20 static int amdgpu_connector_ddc_get_modes(struct drm_connector *connector) @@ -310,12 +312,12 @@ static int amdgpu_connector_ddc_get_modes(struct drm_= connector *connector) struct amdgpu_connector *amdgpu_connector =3D to_amdgpu_connector(connect= or); int ret; =20 - if (amdgpu_connector->edid) { - drm_connector_update_edid_property(connector, amdgpu_connector->edid); - ret =3D drm_add_edid_modes(connector, amdgpu_connector->edid); + if (amdgpu_connector->drm_edid) { + drm_edid_connector_update(connector, amdgpu_connector->drm_edid); + ret =3D drm_edid_connector_add_modes(connector); return ret; } - drm_connector_update_edid_property(connector, NULL); + drm_edid_connector_update(connector, NULL); return 0; } =20 @@ -731,7 +733,7 @@ amdgpu_connector_lvds_detect(struct drm_connector *conn= ector, bool force) =20 /* check for edid as well */ amdgpu_connector_get_edid(connector); - if (amdgpu_connector->edid) + if (amdgpu_connector->drm_edid) ret =3D connector_status_connected; /* check acpi lid status ??? */ =20 @@ -881,13 +883,13 @@ amdgpu_connector_vga_detect(struct drm_connector *con= nector, bool force) amdgpu_connector_free_edid(connector); amdgpu_connector_get_edid(connector); =20 - if (!amdgpu_connector->edid) { + if (!amdgpu_connector->drm_edid) { DRM_ERROR("%s: probed a monitor but no|invalid EDID\n", connector->name); ret =3D connector_status_connected; } else { - amdgpu_connector->use_digital =3D - !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); + amdgpu_connector->use_digital =3D drm_edid_is_digital( + amdgpu_connector->drm_edid); =20 /* some oems have boards with separate digital and analog connectors * with a shared ddc line (often vga + hdmi) @@ -1062,14 +1064,14 @@ amdgpu_connector_dvi_detect(struct drm_connector *c= onnector, bool force) amdgpu_connector_free_edid(connector); amdgpu_connector_get_edid(connector); =20 - if (!amdgpu_connector->edid) { + if (!amdgpu_connector->drm_edid) { DRM_ERROR("%s: probed a monitor but no|invalid EDID\n", connector->name); ret =3D connector_status_connected; broken_edid =3D true; /* defer use_digital to later */ } else { - amdgpu_connector->use_digital =3D - !!(amdgpu_connector->edid->input & DRM_EDID_INPUT_DIGITAL); + amdgpu_connector->use_digital =3D drm_edid_is_digital( + amdgpu_connector->drm_edid); =20 /* some oems have boards with separate digital and analog connectors * with a shared ddc line (often vga + hdmi) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/drm/amd= /amdgpu/amdgpu_mode.h index 5e3faefc5510..e584997c7777 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h @@ -50,7 +50,6 @@ struct amdgpu_device; struct amdgpu_encoder; struct amdgpu_router; struct amdgpu_hpd; -struct edid; struct drm_edid; =20 #define to_amdgpu_crtc(x) container_of(x, struct amdgpu_crtc, base) @@ -623,7 +622,7 @@ struct amdgpu_connector { bool use_digital; /* we need to mind the EDID between detect and get modes due to analog/digital/tvencoder */ - struct edid *edid; + const struct drm_edid *drm_edid; void *con_priv; bool dac_load_detect; bool detected_by_load; /* if the connection status was determined by load= */ diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c b/drivers/gpu/drm/amd/a= mdgpu/dce_v10_0.c index 742adbc460c9..3ad9e58979ab 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v10_0.c @@ -1299,7 +1299,7 @@ static void dce_v10_0_audio_write_speaker_allocation(= struct drm_encoder *encoder return; } =20 - sad_count =3D drm_edid_to_speaker_allocation(amdgpu_connector->edid, &sad= b); + sad_count =3D drm_edid_to_speaker_allocation(drm_edid_raw(amdgpu_connecto= r->drm_edid), &sadb); if (sad_count < 0) { DRM_ERROR("Couldn't read Speaker Allocation Data Block: %d\n", sad_count= ); sad_count =3D 0; @@ -1369,7 +1369,7 @@ static void dce_v10_0_audio_write_sad_regs(struct drm= _encoder *encoder) return; } =20 - sad_count =3D drm_edid_to_sad(amdgpu_connector->edid, &sads); + sad_count =3D drm_edid_to_sad(drm_edid_raw(amdgpu_connector->drm_edid), &= sads); if (sad_count < 0) DRM_ERROR("Couldn't read SADs: %d\n", sad_count); if (sad_count <=3D 0) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c b/drivers/gpu/drm/amd/a= mdgpu/dce_v11_0.c index 8d46ebadfa46..5df1d69a2759 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v11_0.c @@ -1331,7 +1331,7 @@ static void dce_v11_0_audio_write_speaker_allocation(= struct drm_encoder *encoder return; } =20 - sad_count =3D drm_edid_to_speaker_allocation(amdgpu_connector->edid, &sad= b); + sad_count =3D drm_edid_to_speaker_allocation(drm_edid_raw(amdgpu_connecto= r->drm_edid), &sadb); if (sad_count < 0) { DRM_ERROR("Couldn't read Speaker Allocation Data Block: %d\n", sad_count= ); sad_count =3D 0; @@ -1401,7 +1401,7 @@ static void dce_v11_0_audio_write_sad_regs(struct drm= _encoder *encoder) return; } =20 - sad_count =3D drm_edid_to_sad(amdgpu_connector->edid, &sads); + sad_count =3D drm_edid_to_sad(drm_edid_raw(amdgpu_connector->drm_edid), &= sads); if (sad_count < 0) DRM_ERROR("Couldn't read SADs: %d\n", sad_count); if (sad_count <=3D 0) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c b/drivers/gpu/drm/amd/am= dgpu/dce_v6_0.c index f08dc6a3886f..dbdb060a578c 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v6_0.c @@ -1217,7 +1217,7 @@ static void dce_v6_0_audio_write_speaker_allocation(s= truct drm_encoder *encoder) return; } =20 - sad_count =3D drm_edid_to_speaker_allocation(amdgpu_connector->edid, &sad= b); + sad_count =3D drm_edid_to_speaker_allocation(drm_edid_raw(amdgpu_connecto= r->drm_edid), &sadb); if (sad_count < 0) { DRM_ERROR("Couldn't read Speaker Allocation Data Block: %d\n", sad_count= ); sad_count =3D 0; @@ -1292,7 +1292,7 @@ static void dce_v6_0_audio_write_sad_regs(struct drm_= encoder *encoder) return; } =20 - sad_count =3D drm_edid_to_sad(amdgpu_connector->edid, &sads); + sad_count =3D drm_edid_to_sad(drm_edid_raw(amdgpu_connector->drm_edid), &= sads); if (sad_count < 0) DRM_ERROR("Couldn't read SADs: %d\n", sad_count); if (sad_count <=3D 0) diff --git a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c b/drivers/gpu/drm/amd/am= dgpu/dce_v8_0.c index a6a3adf2ae13..f6b8deab9b49 100644 --- a/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/dce_v8_0.c @@ -1272,7 +1272,7 @@ static void dce_v8_0_audio_write_speaker_allocation(s= truct drm_encoder *encoder) return; } =20 - sad_count =3D drm_edid_to_speaker_allocation(amdgpu_connector->edid, &sad= b); + sad_count =3D drm_edid_to_speaker_allocation(drm_edid_raw(amdgpu_connecto= r->drm_edid), &sadb); if (sad_count < 0) { DRM_ERROR("Couldn't read Speaker Allocation Data Block: %d\n", sad_count= ); sad_count =3D 0; @@ -1340,7 +1340,7 @@ static void dce_v8_0_audio_write_sad_regs(struct drm_= encoder *encoder) return; } =20 - sad_count =3D drm_edid_to_sad(amdgpu_connector->edid, &sads); + sad_count =3D drm_edid_to_sad(drm_edid_raw(amdgpu_connector->drm_edid), &= sads); if (sad_count < 0) DRM_ERROR("Couldn't read SADs: %d\n", sad_count); if (sad_count <=3D 0) --=20 2.46.0