From nobody Thu Sep 19 23:15:26 2024 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B917B1C37B1 for ; Fri, 16 Aug 2024 15:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723822335; cv=none; b=VRL2GI9hIc2Pt/PK4S59UusLs6dN01+4Ft7+ILap2vjX8hP+44W9SgsgvSB4Ie7+gPfsTAx/359QeOzjYhULJo+6IYxvV+dzUX4z8sCkWZJboWajyBAns5BHJ3MA/UqwbyhMgxxN5kye4H1+DBJ2DSl3s74/DbJSvJdqo8OVD0w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723822335; c=relaxed/simple; bh=dbGzjAZfh7gVxRz/TIXrMdBv0rDvyB2K7+HnKJ4gJaE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ooylpq4mEYlOj0MspfZadq774yNxBrSnxFHB2PgyuRZV89+pnG3LSbW0NC8cuPaPCMv82IAsrcJS5WkfXOMweTtfFFcysSDwlnaOSpRah+QKeAIgnvtmhGgDVQp0lX/yyBYV7pi1U87LvLDzIbCjeAcSG2JZr2LbMoXBmUobsNA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hMZTPDJc; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hMZTPDJc" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-37198a6da58so440516f8f.0 for ; Fri, 16 Aug 2024 08:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723822332; x=1724427132; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BqtNBWOnQ3Xg+u5frXQomaMjbI/CKyIXNSmcFe+MZzY=; b=hMZTPDJcK8kcTMmYxXBesHldyBQEnCLrt8mnvPhqcjnQ+tyErspfNMW7oSDChh89XI ZVal1dnvbPorPzD2TMoi/2f/TXRDapTY0JDlkHajoeK7b3mhTHrqPQTOSbpB36u1AptO DL9DVoNp5NfqNSAra6AoZ/h1SYNwYlBb7LuJ/d1HYnm0whgYgNAqoUcvyBjXR9qIsjNS 6Y4zcwuZsDlQRlgmDhW5e7tAhjHDkLvptmYC2s17Vi1AzmxgkLRMWy1tZiS5NvE4tnoz BU6c57GZxJrYWQZClXRVX33NYmqC163AHm6/pxqBxulcyiOGH7SzIs/9UopLz6+lcL6O b5tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723822332; x=1724427132; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BqtNBWOnQ3Xg+u5frXQomaMjbI/CKyIXNSmcFe+MZzY=; b=vkbzYFWlrowmgUoABHw2W+uO6xKdhPKHfKA4MTGlXX7EO4FMmYG/q1u4s7/40H4uU0 82AiQV8fem5YiNKX4gu7KHlYlfyKbb3I0F2s6jych+pa2pWH6IaDYy9r5xBvaExHvxpq fTMD35mO+x5qd/WzSKHENReh/uiljCWg+IG1cTUnRA0C3F5+jDE+TzY+lw/VsQpnce2u UXzJOXgp+Bqdl+jPuEN+E+/ZBYv56Rx4SRu4kw/CZtcWwtvimkm0K+8r27aJcKTO6ATK Xq9lIypLeuiJPQ75p80n/67F4AAdHZOYPj59tD499wwx96eG8Mk6iDdPf+uD35jm5+Wm jWaQ== X-Forwarded-Encrypted: i=1; AJvYcCVAq64MP7otG5/O8vhp5t547/LUJgxEIii3nhEi98nzbUqGcEtgCSeVuw2gnHGN8B1dicmFRMYBb/nYVqDdUl0hhwVeO72FWWgqMXJ5 X-Gm-Message-State: AOJu0YyI1SjFWdIbPyS90PXXoghEjhWnFXxhJSW/CAhFyvtdriFqRZ6u orvEGaEkZJePiga82xiBd1OcTNhElgqF4vJDnOcrj3LFY0z7wNRXe+j5FRO6lVA= X-Google-Smtp-Source: AGHT+IGnK3961YuWU4oZFJTYCKl0K2mdOewbI1FmFnvK2B2BUfG+eWPO7zTzTcEARCDrYvRBocT5SA== X-Received: by 2002:adf:fe03:0:b0:368:4def:921a with SMTP id ffacd0b85a97d-3719469f891mr2605779f8f.48.1723822332005; Fri, 16 Aug 2024 08:32:12 -0700 (PDT) Received: from [127.0.1.1] ([178.197.215.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-371898497f0sm3853661f8f.39.2024.08.16.08.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2024 08:32:11 -0700 (PDT) From: Krzysztof Kozlowski Date: Fri, 16 Aug 2024 17:31:44 +0200 Subject: [PATCH 12/17] leds: mt6323: Simplify with scoped for each OF child loop Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240816-cleanup-h-of-node-put-var-v1-12-1d0292802470@linaro.org> References: <20240816-cleanup-h-of-node-put-var-v1-0-1d0292802470@linaro.org> In-Reply-To: <20240816-cleanup-h-of-node-put-var-v1-0-1d0292802470@linaro.org> To: Pavel Machek , Lee Jones , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Riku Voipio , Orson Zhai , Baolin Wang , Chunyan Zhang , =?utf-8?q?Marek_Beh=C3=BAn?= Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Krzysztof Kozlowski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2340; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=dbGzjAZfh7gVxRz/TIXrMdBv0rDvyB2K7+HnKJ4gJaE=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBmv3Djss2TXuF8dbygBzG44V3L56XAVS0ojN1I5 q5iB2VHMQSJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZr9w4wAKCRDBN2bmhouD 1yUUD/92B+FeoNj59qOoLdJpY0L0jdj1oyZClGW92U7HP3VT2O9z9IFmIMEsFaaI70ggtfNrrGo n3LOrAyB3l1wKms4gb+ZQSmDRYF5Aa0oupBSWPo4/aDejYD6KmRMAG6N1jQlZSmmmbDOYITeoJd pHY3KY4kK5eIJy1/HBfZ4YmW0yQp1zlOJYB+JlaPWYtOU4whCpzmVuXybd33sRRgAKutoEzPJSK QfRT7WC9b+BMO5Z5XYutvBjQszr0jXXfkJuznDkY2yYLDhZJ1aBxdW+aY/BX1re1l0S3/dD48xH xkhARVtXmtZHfioc97M9oW1CJJmzNdsK5JaE/6/hFEghYexU2cN5K8VdAx7ydXoRFJTZGwguwZq SEcdGBMuI272hkbmFHQQsXr3mScckzIePahhWqnSh+hG49AcsO6DZ4J44sD230+IsaXQYmqlmxF RJrtUXpKSFLuN9+xRUPtEkKwnxLGIzOZC2Fa571U5F71wPuGmfVZ8FMNuw430ewjLkDcmyh4Tpl knNeNMNGypnIQTo3/FXuuXkjkgg6zZdomcMYrOTE9PfDpVsGWt8O/bJeetz5k6c5H6Qc/3zFYgD MpW3r9d2aTq7KnrbfguCP3P+CA84Qd+xusPgfqTB2WQ13DGwInvp81b0AQbKe/WXO67p8qpCloV XifrHJi3R9eQxcg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Use scoped for_each_available_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Signed-off-by: Krzysztof Kozlowski --- drivers/leds/leds-mt6323.c | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/drivers/leds/leds-mt6323.c b/drivers/leds/leds-mt6323.c index 40d508510823..a19e8e0b6d1b 100644 --- a/drivers/leds/leds-mt6323.c +++ b/drivers/leds/leds-mt6323.c @@ -527,7 +527,6 @@ static int mt6323_led_probe(struct platform_device *pde= v) { struct device *dev =3D &pdev->dev; struct device_node *np =3D dev_of_node(dev); - struct device_node *child; struct mt6397_chip *hw =3D dev_get_drvdata(dev->parent); struct mt6323_leds *leds; struct mt6323_led *led; @@ -565,28 +564,25 @@ static int mt6323_led_probe(struct platform_device *p= dev) return ret; } =20 - for_each_available_child_of_node(np, child) { + for_each_available_child_of_node_scoped(np, child) { struct led_init_data init_data =3D {}; bool is_wled; =20 ret =3D of_property_read_u32(child, "reg", ®); if (ret) { dev_err(dev, "Failed to read led 'reg' property\n"); - goto put_child_node; + return ret; } =20 if (reg >=3D max_leds || reg >=3D MAX_SUPPORTED_LEDS || leds->led[reg]) { dev_err(dev, "Invalid led reg %u\n", reg); - ret =3D -EINVAL; - goto put_child_node; + return -EINVAL; } =20 led =3D devm_kzalloc(dev, sizeof(*led), GFP_KERNEL); - if (!led) { - ret =3D -ENOMEM; - goto put_child_node; - } + if (!led) + return -ENOMEM; =20 is_wled =3D of_property_read_bool(child, "mediatek,is-wled"); =20 @@ -612,7 +608,7 @@ static int mt6323_led_probe(struct platform_device *pde= v) if (ret < 0) { dev_err(leds->dev, "Failed to LED set default from devicetree\n"); - goto put_child_node; + return ret; } =20 init_data.fwnode =3D of_fwnode_handle(child); @@ -621,15 +617,11 @@ static int mt6323_led_probe(struct platform_device *p= dev) &init_data); if (ret) { dev_err(dev, "Failed to register LED: %d\n", ret); - goto put_child_node; + return ret; } } =20 return 0; - -put_child_node: - of_node_put(child); - return ret; } =20 static void mt6323_led_remove(struct platform_device *pdev) --=20 2.43.0