From nobody Sat Feb 7 15:12:36 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 405BDB644 for ; Thu, 15 Aug 2024 00:47:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723682864; cv=none; b=DXX9UYEhdEo+w3EUVE5cNRFXeUq9P2ivmoBCJlrGmxlPZmTDX98rDFc2c+iGyusTxv3EvGG4MhIXtTsvls4M29S70Akf9c9VOJ+kXRKdUZtmH+V1qEG13Tbeb7e0vi25SqvbEDDifTSPRL4ZEqXkBLwWFX2Go5wuxAJgr9JsRAI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723682864; c=relaxed/simple; bh=r4BuNVkYuudg6mssyMhySpqB69LfFwKvJIwhIwlq9vw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=p5Y404rx+XvVZcpx/lqs55BRVVi7DIe12CdTrDSh8rFdpI6ynHPAXbas8GHJdn5HwDo5x0cvfrYh6xerPmcjovTXDogJIx4dL05KQuGFR8MKoCMYYax+LdITxLy4uYV7vYiByPfKgmhjmDst/qcDJoBTMlrJMEXt/irFbo9rRiY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WTjUI5eB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WTjUI5eB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 322EDC116B1; Thu, 15 Aug 2024 00:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723682863; bh=r4BuNVkYuudg6mssyMhySpqB69LfFwKvJIwhIwlq9vw=; h=From:To:Cc:Subject:Date:From; b=WTjUI5eBcl/eUzAvbxSR7N3TpnNseMvcrBzAHKcSyZ5GQG+DkxhjwB1IpTzfy4noD eJhFX8H5ZZ+HZnskPK/q5Gn7IxS1m6Q3Iz8Dr7rEZ5YDfXq/hakAhl3xBiK2kzW+jh 9PBjPGZG9qo31nhOkfTDSJRRZ6xhCq4iMH6nAFdLjzp//pmdHGFKxaaRsF+9GXyzJg DVlXsOTzH5gQamzdrM44uFTuQlsQ7Roig51x9Rt9YReLxy0ccV8P2/3ulkFfyuOchP Q6HiTt2nPqG+JTPN9beKqmeFyH3957mSAuF3OeK7D3qAlSd5blWlQzlT/KlxsA/nKp bla2ShBXs4LIw== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Christophe JAILLET , Chao Yu Subject: [PATCH RESEND] f2fs: Use sysfs_emit_at() to simplify code Date: Thu, 15 Aug 2024 08:47:28 +0800 Message-Id: <20240815004728.983290-1-chao@kernel.org> X-Mailer: git-send-email 2.40.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Christophe JAILLET This file already uses sysfs_emit(). So be consistent and also use sysfs_emit_at(). This slightly simplifies the code and makes it more readable. Reviewed-by: Chao Yu Signed-off-by: Christophe JAILLET --- fs/f2fs/sysfs.c | 45 +++++++++++++++++++++------------------------ 1 file changed, 21 insertions(+), 24 deletions(-) diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c index ed4bf434207a..654a541dcc45 100644 --- a/fs/f2fs/sysfs.c +++ b/fs/f2fs/sysfs.c @@ -188,50 +188,50 @@ static ssize_t features_show(struct f2fs_attr *a, int len =3D 0; =20 if (f2fs_sb_has_encrypt(sbi)) - len +=3D scnprintf(buf, PAGE_SIZE - len, "%s", + len +=3D sysfs_emit_at(buf, len, "%s", "encryption"); if (f2fs_sb_has_blkzoned(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "blkzoned"); if (f2fs_sb_has_extra_attr(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "extra_attr"); if (f2fs_sb_has_project_quota(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "projquota"); if (f2fs_sb_has_inode_chksum(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "inode_checksum"); if (f2fs_sb_has_flexible_inline_xattr(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "flexible_inline_xattr"); if (f2fs_sb_has_quota_ino(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "quota_ino"); if (f2fs_sb_has_inode_crtime(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "inode_crtime"); if (f2fs_sb_has_lost_found(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "lost_found"); if (f2fs_sb_has_verity(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "verity"); if (f2fs_sb_has_sb_chksum(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "sb_checksum"); if (f2fs_sb_has_casefold(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "casefold"); if (f2fs_sb_has_readonly(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "readonly"); if (f2fs_sb_has_compression(sbi)) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "compression"); - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s%s", + len +=3D sysfs_emit_at(buf, len, "%s%s", len ? ", " : "", "pin_file"); - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "\n"); + len +=3D sysfs_emit_at(buf, len, "\n"); return len; } =20 @@ -329,17 +329,14 @@ static ssize_t f2fs_sbi_show(struct f2fs_attr *a, int hot_count =3D sbi->raw_super->hot_ext_count; int len =3D 0, i; =20 - len +=3D scnprintf(buf + len, PAGE_SIZE - len, - "cold file extension:\n"); + len +=3D sysfs_emit_at(buf, len, "cold file extension:\n"); for (i =3D 0; i < cold_count; i++) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s\n", - extlist[i]); + len +=3D sysfs_emit_at(buf, len, "%s\n", extlist[i]); =20 - len +=3D scnprintf(buf + len, PAGE_SIZE - len, - "hot file extension:\n"); + len +=3D sysfs_emit_at(buf, len, "hot file extension:\n"); for (i =3D cold_count; i < cold_count + hot_count; i++) - len +=3D scnprintf(buf + len, PAGE_SIZE - len, "%s\n", - extlist[i]); + len +=3D sysfs_emit_at(buf, len, "%s\n", extlist[i]); + return len; } =20 --=20 2.40.1