From nobody Mon Feb 9 11:36:16 2026 Received: from fhigh7-smtp.messagingengine.com (fhigh7-smtp.messagingengine.com [103.168.172.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00A7D1B012A for ; Wed, 14 Aug 2024 13:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723641151; cv=none; b=YLPIadhHVUcVvkUxqeapqGP+aRvHDNDu65q1pB0DPzayC5hGQLC8kL+IzCGZdGgTpz+JDCcRJeAvH519dMwJBzTmUJyMJojYlZezamyw4Qid9JMBeJalgswC4B4reangGDp1D2N5fE+IJSttk57T36n7R9PrCOYdqjlutuGrSDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723641151; c=relaxed/simple; bh=ivJRk012mBJD8+SxgKSBAYqDXl7Pp+8GZdDzU/NNFk0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IqAeuiwkt3AN3EeSACfkLaWk8PyDE/cE5SKIV5JXoH5BKrgRaid+4hwQs4rghaYdTTVx4sNWDY+yoLXzFh5dIThi/FW3+KNSyTFj9eUI4IA0lrkTixDCSOasyD4yqwKy2Ib49nL6YtCGvLIloF0GbGC69sb9NghDevXkmAu+x4I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=XFB62eAB; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=bwyhsEFl; arc=none smtp.client-ip=103.168.172.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="XFB62eAB"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="bwyhsEFl" Received: from phl-compute-07.internal (phl-compute-07.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id DD6781148181; Wed, 14 Aug 2024 09:12:28 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-07.internal (MEProxy); Wed, 14 Aug 2024 09:12:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1723641148; x= 1723727548; bh=h51XzvDsQ4hxBQvXZZLP1R6qybew4VWlvslb3JFlNp8=; b=X FB62eABSmegj7ptEy834ChE65aYkfTyQnPoQb+ROX/xrAK9PQuAGlxqcv20I6D4l BFMD6009ONuxzNus2G0M2v9yWHCnNXvPtbXKRlxVx6h2mS5VVUyzBGAmgr7bpjVV hy/59JABhfNfWXbOXGUVE2YdceJZcE0o2wM6zpOZ7FM0KaTiOKIpmkRLzK1jRPT7 jZI5evv+wauXRNSygfaMp2G9Cq9UcP1/wNMYxFJ30jgrFiir7/7i/o5t3rHFblKZ mC327Ucesy9o0DbGX1lv8vmxe5Ci46un7hFxB9AXznlLhyKp8C8QY7MD66zkW6Fy Y1jE7hCCQjRKHBtAptrJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1723641148; x= 1723727548; bh=h51XzvDsQ4hxBQvXZZLP1R6qybew4VWlvslb3JFlNp8=; b=b wyhsEFlsSNiiOUQowixvOgLYhTvnUnl1jhRG6lKIpaWf4sVNafxm8ITMJuhYDqy1 EEcjwWBFK2jWhJW2ynkmE9Fyyi555S664Zz+6H8jkFzfpmRbhIT79B7zcsErfW/+ U98EyA43fGhsR2DBFwVtUi5uCFckzgPB4ETXdnKV+3rNZwpgZ31SxX/CmquaraO9 HvjbrASy6nu+0MLaKtbDFQo6bLmbHK8eaHk0PsNldUexz6yl/MHKhGXepsw0/KjN BC7vaQpvBO6MllWvoqENXzD8BA0lJRR80p1+ZXSg3HqyW5rDk0eP+eboI7bPEQqG qLMwAwDXW/fHtBtu1EWfA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddtgedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf ffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghm ohhtohcuoehoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrg htthgvrhhnpedvjefgjeeuvdfguddukeelveetgfdtvefhtdfffeeigfevueetffeivdff kedvtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedv pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvg hlsehlihhsthhsrdhsohhurhgtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhu gidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Aug 2024 09:12:27 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH 1/3] firewire: ohci: use helper macro for compiler aligned attribute Date: Wed, 14 Aug 2024 22:12:20 +0900 Message-ID: <20240814131222.69949-2-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240814131222.69949-1-o-takashi@sakamocchi.jp> References: <20240814131222.69949-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The __aligned() macro has been available since v4.19 kernel by a commit 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually exclusive"). This commit replaces with the macro. Signed-off-by: Takashi Sakamoto --- drivers/firewire/ohci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index e1d24e0ec991..198c96d75155 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -77,7 +77,7 @@ struct descriptor { __le32 branch_address; __le16 res_count; __le16 transfer_status; -} __attribute__((aligned(16))); +} __aligned(16); =20 #define CONTROL_SET(regs) (regs) #define CONTROL_CLEAR(regs) ((regs) + 4) --=20 2.43.0 From nobody Mon Feb 9 11:36:16 2026 Received: from fhigh7-smtp.messagingengine.com (fhigh7-smtp.messagingengine.com [103.168.172.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BEEC1B1500 for ; Wed, 14 Aug 2024 13:12:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723641154; cv=none; b=VFoFOkdgplzV5PhiNqUU8UkkhfWR4ad4PEEMqE3MAMWD0DQNfqKhd/vcpTDQsw58+HGcOHktc65vuoeWrWoKzIxnj0ieA0tpgk45AhNau5qydwJeqGvNl8B/9kfflJDJ2d7OP+oYnhV7QuDmzpUTxlW33kWxx+ymVIYGltzc+1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723641154; c=relaxed/simple; bh=3WlfIPqkbrudVak44YOMPBki/afyuF8q+IRmlXes7oo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KicPazWvIaMnTLrol2IZOFdyJvia/AubIvwFOWrGZwmMWXuzkP1blhXku3ImFz4l/4D0uaaKCAM/K9TJi0buznab26EQ5vlxi+cnyOgz3Q8Ng/K6T07YWERyukyRjVjSuDakkxX3m8rWQslNtxFAgiIPkDCBN1AbFByIv/0emoE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=BsoG3U/n; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Tk3dT+zW; arc=none smtp.client-ip=103.168.172.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="BsoG3U/n"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Tk3dT+zW" Received: from phl-compute-08.internal (phl-compute-08.nyi.internal [10.202.2.48]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 3B8D9114C2A4; Wed, 14 Aug 2024 09:12:30 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Wed, 14 Aug 2024 09:12:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1723641150; x= 1723727550; bh=y/gk/oa4qjodJlJZB+T+ovRfgKRyorStmelbqCHzu6M=; b=B soG3U/nhcwwwT4ODwO3d3iEePjsyOXqUowdX2g0X0tY8SoaHrtQTeoWNlojf2L1f bIRHrzcEeFdna/AoemUMO1KFvTxl/KUqUtEnzGu34c1msDW5dEDnrbW5egF1vHYi +6vYxptp6yHOnZKjUp6orGtx/vliyLlwvt1cPJVRK59npb7ixyQnmhpW710pSLVI Q9t8ZhcxlSVUnLV4rICzwtv/tSZeR1OZR3S/dTQYrrLBT1aZ1unWAnxXGR3zuLkG EaQwcP/dhEThVR+NRIPF5gucUPnB2qXZQZwnCGl7VZHhgX+xacTFrmjOTzMHWZ0J 2xg1S/cDVZ00ooKrrI/XQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1723641150; x= 1723727550; bh=y/gk/oa4qjodJlJZB+T+ovRfgKRyorStmelbqCHzu6M=; b=T k3dT+zWd08QX9OqglVaNnWfkHLU1RZphmTZ/5SP1Ib5p6LmMMcGdtWytzGnIJhOw pzdF0G3b0dZSm/NDYuS6OMiAJTx6jAlhfRt+cyxkdpk0K5zefO82Bp1Z3DZRUJxb yNlW+4f8hs+L/7rCFT4tqhjrewodcCBjiTE4E3MzjDHEjh8mRci1F1uiyFCQN9v6 Ej2+fgPoRCwi7Rggfhlp6frJYVULBxuqPWul6w4qF14cTDlgY08ey6zGB4VtX2IK i1SSt9Z8dWw9HMgfY/lBumztYryuk1Gh8PwHkQpa3bbfDTlPEHSpyvvNVyeb1tPM yHjOo2BNHE79BPxPOzN3g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddtgedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf ffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghm ohhtohcuoehoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrg htthgvrhhnpedvjefgjeeuvdfguddukeelveetgfdtvefhtdfffeeigfevueetffeivdff kedvtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedv pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvg hlsehlihhsthhsrdhsohhurhgtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhu gidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Aug 2024 09:12:29 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/3] firewire: ohci: remove unused wrapper macro for dev_info() Date: Wed, 14 Aug 2024 22:12:21 +0900 Message-ID: <20240814131222.69949-3-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240814131222.69949-1-o-takashi@sakamocchi.jp> References: <20240814131222.69949-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ohci_info() macro is a thin wrapper of dev_info(), while it is never used. Signed-off-by: Takashi Sakamoto --- drivers/firewire/ohci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index 198c96d75155..979f1e1f2d16 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -50,7 +50,6 @@ static u32 cond_le32_to_cpu(__le32 value, bool has_be_hea= der_quirk); #define CREATE_TRACE_POINTS #include =20 -#define ohci_info(ohci, f, args...) dev_info(ohci->card.device, f, ##args) #define ohci_notice(ohci, f, args...) dev_notice(ohci->card.device, f, ##a= rgs) #define ohci_err(ohci, f, args...) dev_err(ohci->card.device, f, ##args) =20 --=20 2.43.0 From nobody Mon Feb 9 11:36:16 2026 Received: from fout4-smtp.messagingengine.com (fout4-smtp.messagingengine.com [103.168.172.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9265D1B150A for ; Wed, 14 Aug 2024 13:12:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.147 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723641154; cv=none; b=GrqP03Lx5UXVyJUF5RZyzRvHgjN94JKl48XgQ83aIospHqK+jqc5r8hvEgwMlyAmrnVCK/+atEtlHdc6Tx04zWEgrh0w8ip2bXIe7S5yC7XctinK+c3DctSTprLKy9iYLeTOQ7FwLdzEUBjxxlLNHJbWhsXGSCE/b+WIxtrhAkw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723641154; c=relaxed/simple; bh=z77wcTGipU3vU3Z9hRt3R4GCiGBDCqnr3cJoObfy3Sg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k1XxAOSEUDJltVvy14jRMaqVH/WK4p6b2BeZ57PbgiKcJedk900OaQrcw3CfUVRzU93WLNOfYEZQGmI/PiXTuZPLW6B0RlcLclBpv3UypHdYt0ITTE0iLtljsayaucNVLXGmKt/thwIievAtF1WjSkm0Bh9Ga3Ze2eD0BtYSbZE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=Fq/CHCG2; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=faSfH/me; arc=none smtp.client-ip=103.168.172.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="Fq/CHCG2"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="faSfH/me" Received: from phl-compute-06.internal (phl-compute-06.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id A01071389445; Wed, 14 Aug 2024 09:12:31 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Wed, 14 Aug 2024 09:12:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1723641151; x= 1723727551; bh=6eQz40i7Qbf0+e3nqYJywvuPegD2nGTCSj//GbNl60U=; b=F q/CHCG22HXcNnD+Lu+tzXCbEKOS5teQH3+7frIt3/9g0YQVVmdkNzzFD3PObw1dO JlF1mxqeBWsPYf6nvUGSCZgJBbGoGyah8umKuHYRk30yLkqdoThRlxKg9apRx2lC 7Lqip80a9JscNRqm/JuhaI31VvGSGwz5Djf9EXigOdv8xH+Qal61OwLtnEaG/Geh Iw2+lGCedWdTVS4NG10DhnW1MYPxRNRB4PTHkzeSx+pUOEP0/RTGcU+3toGeWJsT AwUvqQ0B+n2DjMQ+jSTHGMNDK+4V0YAqwbSda54e2LR4C9WW7cWG0JbcgoXHLwT+ Fd0gicNjR0uc67cjav4Qw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1723641151; x= 1723727551; bh=6eQz40i7Qbf0+e3nqYJywvuPegD2nGTCSj//GbNl60U=; b=f aSfH/meWOQpAk66Nq2mMFcLcJnf+P64H2D70u526GD77MdComXDmljw6HTorZPzu L44yKkLAzCA3Vldlb77ZvzLLD8XiuHQaHENF6v9zfR+CyrvX+T8EuqegjNvL4Sx+ 3TRmuDdCaJl5taovmJMA8jrZNe7EoiNLc+9gF6fxB3htBwGjugJAw6qKguKQN7tI S+7TydKqLAuyIjhSJ4ludL13apZHQgcCcMIW1+3N2D/4oV3eDKc2HrZex1E/OLQf RxsTajRRe9WPC6u1Z9/AeS3ovReu3xsSJYsuwBDg6vMGzRT1L8RNwoK3mshyJffh MKjz2wyqt1zwuO4fs9QOw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddtgedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevuf ffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvrghkrghshhhiucfurghkrghm ohhtohcuoehoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjhhpqeenucggtffrrg htthgvrhhnpedvjefgjeeuvdfguddukeelveetgfdtvefhtdfffeeigfevueetffeivdff kedvtdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hoqdhtrghkrghshhhisehsrghkrghmohgttghhihdrjhhppdhnsggprhgtphhtthhopedv pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehlihhnuhigudefleegqdguvghvvg hlsehlihhsthhsrdhsohhurhgtvghfohhrghgvrdhnvghtpdhrtghpthhtoheplhhinhhu gidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Aug 2024 09:12:30 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH 3/3] firewire: core/ohci: minor refactoring for computation of configuration ROM size Date: Wed, 14 Aug 2024 22:12:22 +0900 Message-ID: <20240814131222.69949-4-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240814131222.69949-1-o-takashi@sakamocchi.jp> References: <20240814131222.69949-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The size of space for configuration ROM is defined by IEEE 1212. The start and end offsets are available as some macros in UAPI header. This commit uses these macros to compute the size. Signed-off-by: Takashi Sakamoto --- drivers/firewire/core-device.c | 3 ++- drivers/firewire/ohci.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c index 32ac0f115793..f71e118ef60a 100644 --- a/drivers/firewire/core-device.c +++ b/drivers/firewire/core-device.c @@ -564,7 +564,8 @@ static int read_rom(struct fw_device *device, return rcode; } =20 -#define MAX_CONFIG_ROM_SIZE 256 +// By quadlet unit. +#define MAX_CONFIG_ROM_SIZE ((CSR_CONFIG_ROM_END - CSR_CONFIG_ROM) / sizeo= f(u32)) =20 /* * Read the bus info block, perform a speed probe, and read all of the res= t of diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index 979f1e1f2d16..53132eae37fe 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -174,7 +174,7 @@ struct iso_context { u8 tags; }; =20 -#define CONFIG_ROM_SIZE 1024 +#define CONFIG_ROM_SIZE (CSR_CONFIG_ROM_END - CSR_CONFIG_ROM) =20 struct fw_ohci { struct fw_card card; --=20 2.43.0