From nobody Sun Feb 8 13:52:53 2026 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6135C1AD416 for ; Wed, 14 Aug 2024 10:06:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630009; cv=none; b=HYPvj20/NdJUMry5qKPakojFmRxUN4XA1kr4CPXWNnGp7YDGK85LoLqX98fYFdHLglDZ1TDPUmE7ClrjyHvj/PalWSm0V7OKp/46hUcxV15Stww9g1VOKzbmT/WdTDtgq6HZ1fX4nT0PCoyLdvbFOSbjxsQK1naQby0msyZZcjg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630009; c=relaxed/simple; bh=7l9F+GjR2AMJA+FyA16K/exYwFNddc+C870KBH/L+Gc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=c3o+SqBpWGa6qQnZOUuUAyOqhu7l/ASoEM1hzprsRs0zcFYp/NWBrjYw7zZvNhUpOM48tJsLONccpIMA2fAbZtMAMnmXQrv6+TqrkXFGfscjGKrm9Mog/zJEyojEDrdRG15u/nr+Z5krA001osUi87Ts3VKtK/EtnLilr7fjXog= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=W8bAdbSy; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="W8bAdbSy" Received: by mail.gandi.net (Postfix) with ESMTPSA id 05A91240007; Wed, 14 Aug 2024 10:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1723630005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=87g0M6ZkmmYQQmzMtdqvd4ET66nRxVANFyNtJSg2Umo=; b=W8bAdbSyMvBv9KLU0Ob5OOUMQi8VUznxq5qgV0p2EpF0NRx5kDiwZ3GfOylHk/oO0BYryX neYH0/F3cZP6NVR03QAkMFL3F8e7EYpJ1sPowh3Q8v5ez3HDgHw37iJVugjoSLGV403W5u BHFJFmz6nZc14pT1Kmfu5PIdL5O9kwwQyJUHgLbHT2rsqQhatZVzl1HQLwtBfanIOJCvMh 2S6UMqsuFaMyd1F5g4X1FiXlJBVjL8KxxMw4knPVPnXI6UxOFj2aEyOc+81zkwMGWuB/dl jKIfT/n1zfMXwhKQIJreSWv9d/dLvloRlmZBh8fGd3CNZgQ94QfJx1HVFR2qrg== From: Louis Chauvet Date: Wed, 14 Aug 2024 12:06:34 +0200 Subject: [PATCH RFC 1/4] drm/vkms: Switch to managed for connector Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240814-google-vkms-managed-v1-1-7ab8b8921103@bootlin.com> References: <20240814-google-vkms-managed-v1-0-7ab8b8921103@bootlin.com> In-Reply-To: <20240814-google-vkms-managed-v1-0-7ab8b8921103@bootlin.com> To: Rodrigo Siqueira , Melissa Wen , =?utf-8?q?Ma=C3=ADra_Canal?= , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Cc: dri-devel@lists.freedesktop.org, arthurgrillo@riseup.net, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, nicolejadeyee@google.com, Louis Chauvet X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=3314; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=7l9F+GjR2AMJA+FyA16K/exYwFNddc+C870KBH/L+Gc=; b=owEBbQKS/ZANAwAIASCtLsZbECziAcsmYgBmvIGzpWkYdOXlSWres+b+S9l+1mlpSd1TOWQhu WQPlhj9lmKJAjMEAAEIAB0WIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCZryBswAKCRAgrS7GWxAs 4q0fEACi+01RkYzF+A2z7xtimM3n3U7Yv729EsDGV3UYl8vYip6U9YYLkcWop+AcMP02/Y/5O3c yG7p2QtJCv1JbSDkTgmU/7EFN2jg9lHu8beFLUD3sZg1XdL+tmTGa+p6RYV+7UyNocAl4Ujdg1Z XoLpm0GpF73k4SF4LypGphwsfxpRyIv/Pu97VLGWw0sa7op2ZyX2LYB7nCAiB1G4swQX8CU8UrF tMwGKvz8ujB03VPh7IvTvHloE4ktIBVbHGGvfefpTIEEHze02gLCcNehIZqFhpfBhqqWcKWyWsN Tzx22SYriwxeULpKfEvB7G0S5P6W+D4gUj08v7KGt6xFXRbX3jDz8RxUATlBqMhPUEKySBnN62c FppvBcEEMvqYPtC+ROQEOTcMNrOqE1yLzt/jCEmkYesID1ZlbKyHGqnocqtnhebg2u5pZPD4Rqf 90Ch++hPUTjZlDLElIkXNufIS0Q8LtqqBA5QMtj2H3wV+OIvIy+Ai4kMF49955m87szEsVySNuR kf62SRIwVxJkBOwIg5mHyFoxDhXwbLktRYKJ8JLtVe7brfDLscVH1RpLPI+6BbvYswOqMhx2gd3 f2ZgtrRQ6Ys4uALXh3CWhIvV10Lx3iOXCKzVx+64Qx0+olAwNWzjv9iIAQVwxpcfsi1Yel8LcTq 5PTrHkAMxlnSQzw== X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-GND-Sasl: louis.chauvet@bootlin.com The current VKMS driver uses non-managed function to create connectors. It is not an issue yet, but in order to support multiple devices easily, convert this code to use drm and device managed helpers. Signed-off-by: Louis Chauvet Reviewed-by: Jos=C3=A9 Exp=C3=B3sito --- drivers/gpu/drm/vkms/vkms_drv.h | 1 - drivers/gpu/drm/vkms/vkms_output.c | 22 ++++++++++------------ 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_dr= v.h index f74a5c2045f9..cea7b2640c5d 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.h +++ b/drivers/gpu/drm/vkms/vkms_drv.h @@ -43,7 +43,6 @@ struct vkms_output { struct drm_crtc crtc; struct drm_encoder encoder; - struct drm_connector connector; struct drm_writeback_connector wb_connector; struct hrtimer vblank_hrtimer; ktime_t period_ns; diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms= _output.c index 20073a00b200..4767838c3a73 100644 --- a/drivers/gpu/drm/vkms/vkms_output.c +++ b/drivers/gpu/drm/vkms/vkms_output.c @@ -3,6 +3,7 @@ #include #include #include +#include =20 #include "vkms_writeback.h" #include "vkms_plane.h" @@ -10,7 +11,6 @@ =20 static const struct drm_connector_funcs vkms_connector_funcs =3D { .fill_modes =3D drm_helper_probe_single_connector_modes, - .destroy =3D drm_connector_cleanup, .reset =3D drm_atomic_helper_connector_reset, .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, @@ -54,7 +54,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int pos= sible_crtc_index) { struct vkms_output *output =3D &vkmsdev->output; struct drm_device *dev =3D &vkmsdev->drm; - struct drm_connector *connector =3D &output->connector; + struct drm_connector *connector; struct drm_encoder *encoder =3D &output->encoder; struct drm_crtc *crtc =3D &output->crtc; struct vkms_plane *primary, *cursor =3D NULL; @@ -90,11 +90,15 @@ int vkms_output_init(struct vkms_device *vkmsdev, int p= ossible_crtc_index) if (ret) return ret; =20 - ret =3D drm_connector_init(dev, connector, &vkms_connector_funcs, - DRM_MODE_CONNECTOR_VIRTUAL); + connector =3D drmm_kzalloc(&vkmsdev->drm, sizeof(*connector), GFP_KERNEL); + if (!connector) + return -ENOMEM; + + ret =3D drmm_connector_init(dev, connector, &vkms_connector_funcs, + DRM_MODE_CONNECTOR_VIRTUAL, NULL); if (ret) { DRM_ERROR("Failed to init connector\n"); - goto err_connector; + return ret; } =20 drm_connector_helper_add(connector, &vkms_conn_helper_funcs); @@ -103,7 +107,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int p= ossible_crtc_index) DRM_MODE_ENCODER_VIRTUAL, NULL); if (ret) { DRM_ERROR("Failed to init encoder\n"); - goto err_encoder; + return ret; } /* * This is an hardcoded value to select crtc for the encoder. @@ -130,11 +134,5 @@ int vkms_output_init(struct vkms_device *vkmsdev, int = possible_crtc_index) err_attach: drm_encoder_cleanup(encoder); =20 -err_encoder: - drm_connector_cleanup(connector); - -err_connector: - drm_crtc_cleanup(crtc); - return ret; } --=20 2.44.2 From nobody Sun Feb 8 13:52:53 2026 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 646AA1AD418 for ; Wed, 14 Aug 2024 10:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630010; cv=none; b=T6pGmPgIL+W/0EUmNBbFjNWj7cy/hW7e7dOo6dlYmtpBfqdsTNo/KCn/aTSNLg5bj4ykOJKDewB9Y8f7QqLhsXH6hjRQ0YUqU8BKkDmxjhjbdKCXoOsPmbZCnwgobd4FENAom1owT3OeXIcoU3Y7WMkIjuPkHcM06u8is78efhI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630010; c=relaxed/simple; bh=+Jyk2eUD6perkmgLy3xL+6KheoendQENPyVEwQZ5FMo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LSXss3gs1ub/ry0YrH26mc0F87dJjs8c1N1Q1dS/ldgJqdk0SZQ8z2LYLyebF5QIy3eEKWwI2AeiCsLgvIB8j5YZeEMfRe6P6jOnS4LsveRa80RT3rWjWSUw7n0y37/jn+kAgN+xTdlT6r7IVNN+pXQkQIMTjd8nhp+nv6TyNkU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=PaI6ySCk; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="PaI6ySCk" Received: by mail.gandi.net (Postfix) with ESMTPSA id C8E94240002; Wed, 14 Aug 2024 10:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1723630006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fttNKQGPbUwSF9BG5K39AeZmnZZJyYqnKRHMDtWuGnI=; b=PaI6ySCkUQ1XQo+yPbxYwQqsfIjXqlUJ/MSqcuDTFj0vyRAGt/4H0VDSFD+P3ByhwlORB0 WnQjNQRAXH9wNiRUQj/61dz7wmgC08f+vFygGcdWhxmVZDxkqutAo0IPad+025RY9QUV+N uAm8vHghBkAINR9e4epMXMumttfkLZN60tt3rAmuZa5YM+my+wfokUHYa6JK2A3r2O/+Bx ZNqg3XBjcNkNhPOSdZUm8F92JJki90I2SWvh/jjcEeZRwJuPWB0l7YWxe1OMjgTBk1vEKO DxQY0ZteY3Gv2wp/bqmue+dc0+6fGLf5c6TIdspf/SchmvOC71VRkOA/TcSwuA== From: Louis Chauvet Date: Wed, 14 Aug 2024 12:06:35 +0200 Subject: [PATCH RFC 2/4] drm/vkms: Switch to managed for encoder Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240814-google-vkms-managed-v1-2-7ab8b8921103@bootlin.com> References: <20240814-google-vkms-managed-v1-0-7ab8b8921103@bootlin.com> In-Reply-To: <20240814-google-vkms-managed-v1-0-7ab8b8921103@bootlin.com> To: Rodrigo Siqueira , Melissa Wen , =?utf-8?q?Ma=C3=ADra_Canal?= , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Cc: dri-devel@lists.freedesktop.org, arthurgrillo@riseup.net, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, nicolejadeyee@google.com, Louis Chauvet X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=2956; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=+Jyk2eUD6perkmgLy3xL+6KheoendQENPyVEwQZ5FMo=; b=owEBbQKS/ZANAwAIASCtLsZbECziAcsmYgBmvIGzTZ1LWiqeOO2oyj8l0Yr+fWA/ngVV5QUTO NXVtUzvf42JAjMEAAEIAB0WIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCZryBswAKCRAgrS7GWxAs 4rRUEADC78cD0i68D45js+dABIkT+M7Z0sGJZd2fgIJR+1yfcZ3Pbz2xZAbXpMVxI05/XjUGii3 fzgm1uf99LlWmjerM6Cm//vt5r4K2YqRg643454AK1dbB/TgMTcAucUu9pAZRiSnlztJkPeCMWq HAJIO+G4Dw9crkQ9vPh2F419zzj5/01DWgPyySe9oLx3YWJ6MNUTH/GtbE49mJAh8eCYAV/QSEC cT3rdkQktcZqyWP1+1PsRTT/5qbkmKdFkDjKXEgejsbUSlsLWYXfPMU+3xxseH5a8uYoOyoht4f m3jIWrUZETQ+Sk8FdDSJ03k0Na6/Y0e56YQ8XBg2dubm3RQaqGXELwXcg5w/WLtTdNxMA0y2FIC kv0p4LyXw7ACRp09rrhh1bdU6/JqC6R7+qBZ2vkkI5DKI5B/XLyaZ2bKSzmndlWIUk25BW7qnxH 8kTZ+Ne5aHKye4y0S8gzP4+tP5xFKV0x8/MBGNaMG0a5lFVQ9MlqOsaq30hcIFTDBonH4uBB06B 6OEQh5HqllaNaerm+FdLhUfkZzFpWtF/cUDC0GrcVn7toakgAZe9QL2V/JbXAKbPxSAtVk4cTWH 91WRB0zRBPrAaIyV7xZuRxzNevkJU++tnync+qmEyHEMxDdIl7r9Cr9pFIiLO/chFQ/BMkHrc3V iUyrTjAjQz6fsqQ== X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-GND-Sasl: louis.chauvet@bootlin.com The current VKMS driver uses non-managed function to create encoders. It is not an issue yet, but in order to support multiple devices easly, convert this code to use drm and device managed helpers. Signed-off-by: Louis Chauvet Reviewed-by: Jos=C3=A9 Exp=C3=B3sito --- drivers/gpu/drm/vkms/vkms_drv.h | 1 - drivers/gpu/drm/vkms/vkms_output.c | 21 +++++++++------------ 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_dr= v.h index cea7b2640c5d..2c9d1f20ce84 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.h +++ b/drivers/gpu/drm/vkms/vkms_drv.h @@ -42,7 +42,6 @@ */ struct vkms_output { struct drm_crtc crtc; - struct drm_encoder encoder; struct drm_writeback_connector wb_connector; struct hrtimer vblank_hrtimer; ktime_t period_ns; diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms= _output.c index 4767838c3a73..cb8507917b5f 100644 --- a/drivers/gpu/drm/vkms/vkms_output.c +++ b/drivers/gpu/drm/vkms/vkms_output.c @@ -16,9 +16,7 @@ static const struct drm_connector_funcs vkms_connector_fu= ncs =3D { .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, }; =20 -static const struct drm_encoder_funcs vkms_encoder_funcs =3D { - .destroy =3D drm_encoder_cleanup, -}; +static const struct drm_encoder_funcs vkms_encoder_funcs =3D {}; =20 static int vkms_conn_get_modes(struct drm_connector *connector) { @@ -55,7 +53,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int pos= sible_crtc_index) struct vkms_output *output =3D &vkmsdev->output; struct drm_device *dev =3D &vkmsdev->drm; struct drm_connector *connector; - struct drm_encoder *encoder =3D &output->encoder; + struct drm_encoder *encoder; struct drm_crtc *crtc =3D &output->crtc; struct vkms_plane *primary, *cursor =3D NULL; int ret; @@ -103,8 +101,12 @@ int vkms_output_init(struct vkms_device *vkmsdev, int = possible_crtc_index) =20 drm_connector_helper_add(connector, &vkms_conn_helper_funcs); =20 - ret =3D drm_encoder_init(dev, encoder, &vkms_encoder_funcs, - DRM_MODE_ENCODER_VIRTUAL, NULL); + encoder =3D drmm_kzalloc(&vkmsdev->drm, sizeof(*encoder), GFP_KERNEL); + if (!encoder) + return -ENOMEM; + + ret =3D drmm_encoder_init(dev, encoder, &vkms_encoder_funcs, + DRM_MODE_ENCODER_VIRTUAL, NULL); if (ret) { DRM_ERROR("Failed to init encoder\n"); return ret; @@ -118,7 +120,7 @@ int vkms_output_init(struct vkms_device *vkmsdev, int p= ossible_crtc_index) ret =3D drm_connector_attach_encoder(connector, encoder); if (ret) { DRM_ERROR("Failed to attach connector to encoder\n"); - goto err_attach; + return ret; } =20 if (vkmsdev->config->writeback) { @@ -130,9 +132,4 @@ int vkms_output_init(struct vkms_device *vkmsdev, int p= ossible_crtc_index) drm_mode_config_reset(dev); =20 return 0; - -err_attach: - drm_encoder_cleanup(encoder); - - return ret; } --=20 2.44.2 From nobody Sun Feb 8 13:52:53 2026 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CDE61AD41A for ; Wed, 14 Aug 2024 10:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630011; cv=none; b=lle/UyQrtxIBsWBKTrw6OUTHSS6S5ms4sDxg6OdHQ0L4tibjoB0e9J/Uj4sgU7526YijNaMZpccfZs6U6A95iqu25pegm1SDwm/YBtPGK5g9SSLeC8NMz7G8OUkrK0tVX1OxcyCaznu2QH6uNug5lxB+B56Hm3EdhVJF4L9mxJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630011; c=relaxed/simple; bh=447DXhpuWoU6mXV2ts2DEGjZ3z0uENfAAoXerVIq7Aw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=o4i4S6xQgnCQ55Po6ZgfnGgRfbqch302NK8fU1kyJvq0h1584MVK2V9qgNy+O2iYFJhwO6moX78exLm9peTrLm9ncI1DtA7TA0fHgoQ7Mgsz2DDZKihEFLleG6BKAQNy9X+PF7BlvpPWKVDymqbzS+0EELOxefS7g0C0ucw2Lhc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=aEV557H8; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="aEV557H8" Received: by mail.gandi.net (Postfix) with ESMTPSA id A8E60240008; Wed, 14 Aug 2024 10:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1723630007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KfERX9xzlyi5AfqZW0bSS+seZK9raHfJpKULq1eBSzc=; b=aEV557H85BQqbbCR2xoUpOQkX3qzwFRQ9n/0KwiVHgc7pH21REOyn5Rc9yvfd6fbvQzYUX 6NXNyKZc2Jj2uFYz6w1hSFW/eF2Mw4YXjN7Bqzcf5wTYBpMvdjvCt2mW93nvsqpuuFuS2Z 7n4CaCBIVo0/bZLoCHhFFz+Bx8fMYHjs/oWQ5EMBF3EG5h9iSMCCLoNP5dOOENXVFOZORU 9zzoYekgdmftiSchEmcRTg7a3jb2ZuQoJmyE53JdXyX2lfQiuyal+nMw0LP8zxkj+GcwtW Hwks+W51H8+YEntISHja2AUZQLkUDynjy9Tty+TLWDKeaPlV3HPtwUOF3cI7eQ== From: Louis Chauvet Date: Wed, 14 Aug 2024 12:06:36 +0200 Subject: [PATCH RFC 3/4] drm/vkms: Switch to managed for crtc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240814-google-vkms-managed-v1-3-7ab8b8921103@bootlin.com> References: <20240814-google-vkms-managed-v1-0-7ab8b8921103@bootlin.com> In-Reply-To: <20240814-google-vkms-managed-v1-0-7ab8b8921103@bootlin.com> To: Rodrigo Siqueira , Melissa Wen , =?utf-8?q?Ma=C3=ADra_Canal?= , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Cc: dri-devel@lists.freedesktop.org, arthurgrillo@riseup.net, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, nicolejadeyee@google.com, Louis Chauvet X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=26440; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=447DXhpuWoU6mXV2ts2DEGjZ3z0uENfAAoXerVIq7Aw=; b=owEBbQKS/ZANAwAIASCtLsZbECziAcsmYgBmvIGzgN5sJ6qpe05DSVALeHlgumahThf5zM9iq eIrfwlKBaSJAjMEAAEIAB0WIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCZryBswAKCRAgrS7GWxAs 4oA2D/0WEWVhSJsoMedrkf02PM/yby3maE4IGkfCVpnq+P7LtZ6Wdbo6//TukibfjUOyZqnbmnZ Sak6o4MgE7SGTLj5lUk+7zZ3cjCavy/4keb0TGs+ov+ctqkfzHHUo8vBfblSPHRKQ9XWs6uyU7h /pAevYWY8ClqWegapkXis+vCW8nA60zre3M9SaPFvbNWm1Hps+Vl+k2n2/pmzgGvDAQrIW5tSwl gG9rrL9rD7k0qEveQ3JIct4pHCJTfOUdXnD6nQuslaRRaz7tTttL5HpiRhKC39brOMWmv5R3yPW KjCnAHflM015J+R4mN2qrXlzZt5/KUCTWX4gWg4msSxcLJ/B2GuG+cvoFqKE9qW9ttOy4y8hz3a x+jWR6Tm2m8xszPvw0XQxQ8XW6qw3oDXrzLnhJDYcnGRDTvANnAngMCIDCtxYhtJMUAwYQCM2OH ozX1eLevytinObJPMW7LNYLb/bm8J9sVY37hQ4UYSKCCAHGQmvNOb+0W2gVYcKpytLMN5f7fD7z Z2wlN0+xfFYyX5Ph3Rh1/905loI8VSVgOEOjuFhKTuQPz/Aabi9llLNE08t68Pwcffv4hX+j4jm NLLmJPMdKjuZ85xaKtefE6ODjUTGIHNao6qgnHXaglZ/zmO+cR2pEKs3/2km3SBi6GWp0+BAuf+ o8ch33g9qZMKsFg== X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-GND-Sasl: louis.chauvet@bootlin.com The current VKMS driver uses non-managed function to create crtcs. It is not an issue yet, but in order to support multiple devices easly, convert this code to use drm and device managed helpers. Signed-off-by: Louis Chauvet --- drivers/gpu/drm/vkms/vkms_composer.c | 10 +-- drivers/gpu/drm/vkms/vkms_composer.h | 2 +- drivers/gpu/drm/vkms/vkms_crtc.c | 75 ++++++++++++------- drivers/gpu/drm/vkms/vkms_crtc.h | 19 +++-- drivers/gpu/drm/vkms/vkms_drv.c | 134 ++++++++++++++++++++++++++++++= --- drivers/gpu/drm/vkms/vkms_drv.h | 43 ----------- drivers/gpu/drm/vkms/vkms_output.c | 135 ------------------------------= ---- drivers/gpu/drm/vkms/vkms_writeback.c | 20 +++-- drivers/gpu/drm/vkms/vkms_writeback.h | 2 +- 9 files changed, 197 insertions(+), 243 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vk= ms_composer.c index 15ef07ed304e..9b2f578c2eb1 100644 --- a/drivers/gpu/drm/vkms/vkms_composer.c +++ b/drivers/gpu/drm/vkms/vkms_composer.c @@ -515,7 +515,7 @@ void vkms_composer_worker(struct work_struct *work) composer_work); struct drm_crtc *crtc =3D crtc_state->base.crtc; struct vkms_writeback_job *active_wb =3D crtc_state->active_writeback; - struct vkms_output *out =3D drm_crtc_to_vkms_output(crtc); + struct vkms_crtc *out =3D drm_crtc_to_vkms_crtc(crtc); bool crc_pending, wb_pending; u64 frame_start, frame_end; u32 crc32 =3D 0; @@ -616,12 +616,12 @@ int vkms_verify_crc_source(struct drm_crtc *crtc, con= st char *src_name, return 0; } =20 -void vkms_set_composer(struct vkms_output *out, bool enabled) +void vkms_set_composer(struct vkms_crtc *out, bool enabled) { bool old_enabled; =20 if (enabled) - drm_crtc_vblank_get(&out->crtc); + drm_crtc_vblank_get(&out->base); =20 spin_lock_irq(&out->lock); old_enabled =3D out->composer_enabled; @@ -629,12 +629,12 @@ void vkms_set_composer(struct vkms_output *out, bool = enabled) spin_unlock_irq(&out->lock); =20 if (old_enabled) - drm_crtc_vblank_put(&out->crtc); + drm_crtc_vblank_put(&out->base); } =20 int vkms_set_crc_source(struct drm_crtc *crtc, const char *src_name) { - struct vkms_output *out =3D drm_crtc_to_vkms_output(crtc); + struct vkms_crtc *out =3D drm_crtc_to_vkms_crtc(crtc); bool enabled =3D false; int ret =3D 0; =20 diff --git a/drivers/gpu/drm/vkms/vkms_composer.h b/drivers/gpu/drm/vkms/vk= ms_composer.h index 91b33af1e013..77efd2e3a63a 100644 --- a/drivers/gpu/drm/vkms/vkms_composer.h +++ b/drivers/gpu/drm/vkms/vkms_composer.h @@ -7,7 +7,7 @@ #include "vkms_crtc.h" =20 void vkms_composer_worker(struct work_struct *work); -void vkms_set_composer(struct vkms_output *out, bool enabled); +void vkms_set_composer(struct vkms_crtc *out, bool enabled); =20 /* CRC Support */ const char *const *vkms_get_crc_sources(struct drm_crtc *crtc, size_t *cou= nt); diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_c= rtc.c index 6fae43932b60..47e62fb3e404 100644 --- a/drivers/gpu/drm/vkms/vkms_crtc.c +++ b/drivers/gpu/drm/vkms/vkms_crtc.c @@ -6,6 +6,8 @@ #include #include #include +#include +#include #include =20 #include "vkms_crtc.h" @@ -14,9 +16,8 @@ =20 static enum hrtimer_restart vkms_vblank_simulate(struct hrtimer *timer) { - struct vkms_output *output =3D container_of(timer, struct vkms_output, - vblank_hrtimer); - struct drm_crtc *crtc =3D &output->crtc; + struct vkms_crtc *output =3D hrtimer_to_vkms_crtc(timer); + struct drm_crtc *crtc =3D &output->base; struct vkms_crtc_state *state; u64 ret_overrun; bool ret, fence_cookie; @@ -64,8 +65,9 @@ static enum hrtimer_restart vkms_vblank_simulate(struct h= rtimer *timer) =20 static int vkms_enable_vblank(struct drm_crtc *crtc) { + struct drm_device *dev =3D crtc->dev; struct drm_vblank_crtc *vblank =3D drm_crtc_vblank_crtc(crtc); - struct vkms_output *out =3D drm_crtc_to_vkms_output(crtc); + struct vkms_crtc *out =3D drm_crtc_to_vkms_crtc(crtc); =20 drm_calc_timestamping_constants(crtc, &crtc->mode); =20 @@ -79,7 +81,7 @@ static int vkms_enable_vblank(struct drm_crtc *crtc) =20 static void vkms_disable_vblank(struct drm_crtc *crtc) { - struct vkms_output *out =3D drm_crtc_to_vkms_output(crtc); + struct vkms_crtc *out =3D drm_crtc_to_vkms_crtc(crtc); =20 hrtimer_cancel(&out->vblank_hrtimer); } @@ -89,8 +91,7 @@ static bool vkms_get_vblank_timestamp(struct drm_crtc *cr= tc, bool in_vblank_irq) { struct drm_device *dev =3D crtc->dev; - struct vkms_device *vkmsdev =3D drm_device_to_vkms_device(dev); - struct vkms_output *output =3D &vkmsdev->output; + struct vkms_crtc *output =3D drm_crtc_to_vkms_crtc(crtc); struct drm_vblank_crtc *vblank =3D drm_crtc_vblank_crtc(crtc); =20 if (!READ_ONCE(vblank->enabled)) { @@ -137,7 +138,7 @@ vkms_atomic_crtc_duplicate_state(struct drm_crtc *crtc) static void vkms_atomic_crtc_destroy_state(struct drm_crtc *crtc, struct drm_crtc_state *state) { - struct vkms_crtc_state *vkms_state =3D to_vkms_crtc_state(state); + struct vkms_crtc_state *vkms_state =3D drm_crtc_state_to_vkms_crtc_state(= state); =20 __drm_atomic_helper_crtc_destroy_state(state); =20 @@ -178,7 +179,7 @@ static int vkms_crtc_atomic_check(struct drm_crtc *crtc, { struct drm_crtc_state *crtc_state =3D drm_atomic_get_new_crtc_state(state, crtc); - struct vkms_crtc_state *vkms_state =3D to_vkms_crtc_state(crtc_state); + struct vkms_crtc_state *vkms_state =3D drm_crtc_state_to_vkms_crtc_state(= crtc_state); struct drm_plane *plane; struct drm_plane_state *plane_state; int i =3D 0, ret; @@ -234,7 +235,7 @@ static void vkms_crtc_atomic_disable(struct drm_crtc *c= rtc, static void vkms_crtc_atomic_begin(struct drm_crtc *crtc, struct drm_atomic_state *state) { - struct vkms_output *vkms_output =3D drm_crtc_to_vkms_output(crtc); + struct vkms_crtc *vkms_output =3D drm_crtc_to_vkms_crtc(crtc); =20 /* This lock is held across the atomic commit to block vblank timer * from scheduling vkms_composer_worker until the composer is updated @@ -245,7 +246,7 @@ static void vkms_crtc_atomic_begin(struct drm_crtc *crt= c, static void vkms_crtc_atomic_flush(struct drm_crtc *crtc, struct drm_atomic_state *state) { - struct vkms_output *vkms_output =3D drm_crtc_to_vkms_output(crtc); + struct vkms_crtc *vkms_output =3D drm_crtc_to_vkms_crtc(crtc); =20 if (crtc->state->event) { spin_lock(&crtc->dev->event_lock); @@ -260,7 +261,7 @@ static void vkms_crtc_atomic_flush(struct drm_crtc *crt= c, crtc->state->event =3D NULL; } =20 - vkms_output->composer_state =3D to_vkms_crtc_state(crtc->state); + vkms_output->composer_state =3D drm_crtc_state_to_vkms_crtc_state(crtc->s= tate); =20 spin_unlock_irq(&vkms_output->lock); } @@ -273,30 +274,48 @@ static const struct drm_crtc_helper_funcs vkms_crtc_h= elper_funcs =3D { .atomic_disable =3D vkms_crtc_atomic_disable, }; =20 -int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, - struct drm_plane *primary, struct drm_plane *cursor) +static void vkms_crtc_destroy_workqueue(struct drm_device *dev, void *raw_= vkms_crtc) +{ + struct vkms_crtc *vkms_crtc =3D raw_vkms_crtc; + + destroy_workqueue(vkms_crtc->composer_workq); +} + +struct vkms_crtc *vkms_crtc_init(struct vkms_device *vkmsdev, + struct drm_plane *primary, + struct drm_plane *cursor) { - struct vkms_output *vkms_out =3D drm_crtc_to_vkms_output(crtc); + struct drm_device *dev =3D &vkmsdev->drm; + struct vkms_crtc *vkms_crtc; int ret; =20 - ret =3D drmm_crtc_init_with_planes(dev, crtc, primary, cursor, - &vkms_crtc_funcs, NULL); + vkms_crtc =3D drmm_crtc_alloc_with_planes(dev, struct vkms_crtc, base, pr= imary, cursor, + &vkms_crtc_funcs, NULL); + if (IS_ERR(vkms_crtc)) { + DRM_DEV_ERROR(vkmsdev->drm.dev, "Failed to init CRTC\n"); + return vkms_crtc; + } + + drm_crtc_helper_add(&vkms_crtc->base, &vkms_crtc_helper_funcs); + + ret =3D drm_mode_crtc_set_gamma_size(&vkms_crtc->base, VKMS_LUT_SIZE); if (ret) { - DRM_ERROR("Failed to init CRTC\n"); - return ret; + DRM_DEV_ERROR(vkmsdev->drm.dev, "Failed to set gamma size\n"); + return ERR_PTR(ret); } =20 - drm_crtc_helper_add(crtc, &vkms_crtc_helper_funcs); + drm_crtc_enable_color_mgmt(&vkms_crtc->base, 0, false, VKMS_LUT_SIZE); =20 - drm_mode_crtc_set_gamma_size(crtc, VKMS_LUT_SIZE); - drm_crtc_enable_color_mgmt(crtc, 0, false, VKMS_LUT_SIZE); + spin_lock_init(&vkms_crtc->lock); + spin_lock_init(&vkms_crtc->composer_lock); =20 - spin_lock_init(&vkms_out->lock); - spin_lock_init(&vkms_out->composer_lock); + vkms_crtc->composer_workq =3D alloc_ordered_workqueue("vkms_composer", 0); + if (!vkms_crtc->composer_workq) + return ERR_PTR(-ENOMEM); =20 - vkms_out->composer_workq =3D alloc_ordered_workqueue("vkms_composer", 0); - if (!vkms_out->composer_workq) - return -ENOMEM; + ret =3D drmm_add_action_or_reset(&vkmsdev->drm, vkms_crtc_destroy_workque= ue, vkms_crtc); + if (ret) + return ERR_PTR(ret); =20 - return ret; + return vkms_crtc; } diff --git a/drivers/gpu/drm/vkms/vkms_crtc.h b/drivers/gpu/drm/vkms/vkms_c= rtc.h index 9f5ce21f3425..dde28884a0a5 100644 --- a/drivers/gpu/drm/vkms/vkms_crtc.h +++ b/drivers/gpu/drm/vkms/vkms_crtc.h @@ -48,7 +48,6 @@ struct vkms_crtc_state { * @wb_connecter: DRM writeback connector used for this output * @vblank_hrtimer: * @period_ns: - * @event: * @composer_workq: Ordered workqueue for composer_work * @lock: Lock used to project concurrent acces to the composer * @composer_enabled: Protected by @lock. @@ -61,7 +60,6 @@ struct vkms_crtc { struct drm_writeback_connector wb_connector; struct hrtimer vblank_hrtimer; ktime_t period_ns; - struct drm_pending_vblank_event *event; struct workqueue_struct *composer_workq; spinlock_t lock; =20 @@ -71,17 +69,22 @@ struct vkms_crtc { spinlock_t composer_lock; }; =20 -#define to_vkms_crtc_state(target)\ +#define drm_crtc_state_to_vkms_crtc_state(target)\ container_of(target, struct vkms_crtc_state, base) =20 +#define drm_crtc_to_vkms_crtc(target) \ + container_of(target, struct vkms_crtc, base) + +#define hrtimer_to_vkms_crtc(target) \ + container_of(target, struct vkms_crtc, vblank_hrtimer) + /** * vkms_crtc_init() - Initialize a crtc for vkms - * @dev: drm_device associated with the vkms buffer - * @crtc: uninitialized crtc device + * @vkmsdev: drm_device associated with the vkms buffer * @primary: primary plane to attach to the crtc * @cursor plane to attach to the crtc */ -int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, - struct drm_plane *primary, struct drm_plane *cursor); - +struct vkms_crtc *vkms_crtc_init(struct vkms_device *vkmsdev, + struct drm_plane *primary, + struct drm_plane *cursor); #endif //_VKMS_CRTC_H diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_dr= v.c index 5907877bdfa0..e79832e10f3c 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.c +++ b/drivers/gpu/drm/vkms/vkms_drv.c @@ -31,6 +31,7 @@ =20 #include #include +#include =20 #define DRIVER_NAME "vkms" #define DRIVER_DESC "Virtual Kernel Mode Setting" @@ -46,7 +47,8 @@ MODULE_PARM_DESC(enable_cursor, "Enable/Disable cursor su= pport"); =20 static bool enable_writeback =3D true; module_param_named(enable_writeback, enable_writeback, bool, 0444); -MODULE_PARM_DESC(enable_writeback, "Enable/Disable writeback connector sup= port"); +MODULE_PARM_DESC(enable_writeback, + "Enable/Disable writeback connector support"); =20 static bool enable_overlay; module_param_named(enable_overlay, enable_overlay, bool, 0444); @@ -54,14 +56,6 @@ MODULE_PARM_DESC(enable_overlay, "Enable/Disable overlay= support"); =20 DEFINE_DRM_GEM_FOPS(vkms_driver_fops); =20 -static void vkms_release(struct drm_device *dev) -{ - struct vkms_device *vkms =3D drm_device_to_vkms_device(dev); - - if (vkms->output.composer_workq) - destroy_workqueue(vkms->output.composer_workq); -} - static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state) { struct drm_device *dev =3D old_state->dev; @@ -82,7 +76,8 @@ static void vkms_atomic_commit_tail(struct drm_atomic_sta= te *old_state) drm_atomic_helper_wait_for_flip_done(dev, old_state); =20 for_each_old_crtc_in_state(old_state, crtc, old_crtc_state, i) { - struct vkms_crtc_state *vkms_state =3D to_vkms_crtc_state(old_crtc_state= ); + struct vkms_crtc_state *vkms_state =3D + drm_crtc_state_to_vkms_crtc_state(old_crtc_state); =20 flush_work(&vkms_state->composer_work); } @@ -109,7 +104,6 @@ static const struct drm_debugfs_info vkms_config_debugf= s_list[] =3D { =20 static const struct drm_driver vkms_driver =3D { .driver_features =3D DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_GEM, - .release =3D vkms_release, .fops =3D &vkms_driver_fops, DRM_GEM_SHMEM_DRIVER_OPS, =20 @@ -148,6 +142,124 @@ static const struct drm_mode_config_helper_funcs vkms= _mode_config_helpers =3D { .atomic_commit_tail =3D vkms_atomic_commit_tail, }; =20 +static const struct drm_connector_funcs vkms_connector_funcs =3D { + .fill_modes =3D drm_helper_probe_single_connector_modes, + .reset =3D drm_atomic_helper_connector_reset, + .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, + .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, +}; + +static const struct drm_encoder_funcs vkms_encoder_funcs =3D {}; + +static int vkms_conn_get_modes(struct drm_connector *connector) +{ + int count; + + /* Use the default modes list from drm */ + count =3D drm_add_modes_noedid(connector, XRES_MAX, YRES_MAX); + drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF); + + return count; +} + +static const struct drm_connector_helper_funcs vkms_conn_helper_funcs =3D { + .get_modes =3D vkms_conn_get_modes, +}; + +static int vkms_output_init(struct vkms_device *vkmsdev, int possible_crtc) +{ + struct drm_device *dev =3D &vkmsdev->drm; + struct drm_connector *connector; + struct drm_encoder *encoder; + struct vkms_crtc *crtc; + struct drm_plane *plane; + struct vkms_plane *primary, *cursor, *overlay =3D NULL; + int ret; + int writeback; + unsigned int n; + + /* + * Initialize used plane. One primary plane is required to perform the co= mposition. + * + * The overlay and cursor planes are not mandatory, but can be used to pe= rform complex + * composition. + */ + primary =3D vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_PRIMARY, possible_crt= c); + if (IS_ERR(primary)) + return PTR_ERR(primary); + + if (vkmsdev->config->overlay) { + for (n =3D 0; n < NUM_OVERLAY_PLANES; n++) { + overlay =3D vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_OVERLAY, possible_c= rtc); + if (IS_ERR(overlay)) + return PTR_ERR(overlay); + } + } + + if (vkmsdev->config->cursor) { + cursor =3D vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_CURSOR, possible_crtc= ); + if (IS_ERR(cursor)) + return PTR_ERR(cursor); + } + + /* [1]: Initialize the crtc component */ + crtc =3D vkms_crtc_init(vkmsdev, &primary->base, + cursor ? &cursor->base : NULL); + if (IS_ERR(crtc)) + return PTR_ERR(crtc); + + /* Enable the output's CRTC for all the planes */ + drm_for_each_plane(plane, &vkmsdev->drm) { + plane->possible_crtcs |=3D drm_crtc_mask(&crtc->base); + } + + /* Initialize the connector component */ + connector =3D drmm_kzalloc(&vkmsdev->drm, sizeof(*connector), GFP_KERNEL); + if (!connector) + return -ENOMEM; + + ret =3D drmm_connector_init(dev, connector, &vkms_connector_funcs, + DRM_MODE_CONNECTOR_VIRTUAL, NULL); + if (ret) { + DRM_ERROR("Failed to init connector\n"); + return ret; + } + + drm_connector_helper_add(connector, &vkms_conn_helper_funcs); + + /* Initialize the encoder component */ + encoder =3D drmm_kzalloc(&vkmsdev->drm, sizeof(*encoder), GFP_KERNEL); + if (!encoder) + return -ENOMEM; + + ret =3D drmm_encoder_init(dev, encoder, &vkms_encoder_funcs, + DRM_MODE_ENCODER_VIRTUAL, NULL); + if (ret) { + DRM_ERROR("Failed to init encoder\n"); + return ret; + } + + encoder->possible_crtcs =3D drm_crtc_mask(&crtc->base); + + /* Attach the encoder and the connector */ + ret =3D drm_connector_attach_encoder(connector, encoder); + if (ret) { + DRM_ERROR("Failed to attach connector to encoder\n"); + return ret; + } + + /* Initialize the writeback component */ + if (vkmsdev->config->writeback) { + writeback =3D vkms_enable_writeback_connector(vkmsdev, crtc); + if (writeback) + DRM_ERROR("Failed to init writeback connector\n"); + } + + drm_mode_config_reset(dev); + + return 0; +} + static int vkms_modeset_init(struct vkms_device *vkmsdev) { struct drm_device *dev =3D &vkmsdev->drm; diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_dr= v.h index 2c9d1f20ce84..08d0ef106e37 100644 --- a/drivers/gpu/drm/vkms/vkms_drv.h +++ b/drivers/gpu/drm/vkms/vkms_drv.h @@ -25,35 +25,6 @@ =20 #define VKMS_LUT_SIZE 256 =20 -/** - * struct vkms_output - Internal representation of all output components i= n vkms - * - * @crtc: Base crtc in drm - * @encoder: DRM encoder used for this output - * @connector: DRM connector used for this output - * @wb_connecter: DRM writeback connector used for this output - * @vblank_hrtimer: - * @period_ns: - * @composer_workq: Ordered workqueue for composer_work - * @lock: Lock used to project concurrent acces to the composer - * @composer_enabled: Protected by @lock. - * @composer_state: - * @composer_lock: Lock used internally to protect @composer_state members - */ -struct vkms_output { - struct drm_crtc crtc; - struct drm_writeback_connector wb_connector; - struct hrtimer vblank_hrtimer; - ktime_t period_ns; - struct workqueue_struct *composer_workq; - spinlock_t lock; - - bool composer_enabled; - struct vkms_crtc_state *composer_state; - - spinlock_t composer_lock; -}; - /** * struct vkms_config - General configuration for VKMS driver * @@ -80,7 +51,6 @@ struct vkms_config { struct vkms_device { struct drm_device drm; struct platform_device *platform; - struct vkms_output output; const struct vkms_config *config; }; =20 @@ -88,20 +58,7 @@ struct vkms_device { * The following helpers are used to convert a member of a struct into its= parent. */ =20 -#define drm_crtc_to_vkms_output(target) \ - container_of(target, struct vkms_output, crtc) - #define drm_device_to_vkms_device(target) \ container_of(target, struct vkms_device, drm) =20 -/** - * vkms_output_init() - Initialize all sub-components needed for a vkms de= vice. - * - * @vkmsdev: vkms device to initialize - * @possible_crtc_index: Crtc which can be attached to the planes. The cal= ler must ensure that - * possible_crtc_index is positive and less or equals to 31. - */ - -int vkms_output_init(struct vkms_device *vkmsdev, int possible_crtc_index); - #endif /* _VKMS_DRV_H_ */ diff --git a/drivers/gpu/drm/vkms/vkms_output.c b/drivers/gpu/drm/vkms/vkms= _output.c deleted file mode 100644 index cb8507917b5f..000000000000 --- a/drivers/gpu/drm/vkms/vkms_output.c +++ /dev/null @@ -1,135 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ - -#include -#include -#include -#include - -#include "vkms_writeback.h" -#include "vkms_plane.h" -#include "vkms_crtc.h" - -static const struct drm_connector_funcs vkms_connector_funcs =3D { - .fill_modes =3D drm_helper_probe_single_connector_modes, - .reset =3D drm_atomic_helper_connector_reset, - .atomic_duplicate_state =3D drm_atomic_helper_connector_duplicate_state, - .atomic_destroy_state =3D drm_atomic_helper_connector_destroy_state, -}; - -static const struct drm_encoder_funcs vkms_encoder_funcs =3D {}; - -static int vkms_conn_get_modes(struct drm_connector *connector) -{ - int count; - - /* Use the default modes list from drm */ - count =3D drm_add_modes_noedid(connector, XRES_MAX, YRES_MAX); - drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF); - - return count; -} - -static const struct drm_connector_helper_funcs vkms_conn_helper_funcs =3D { - .get_modes =3D vkms_conn_get_modes, -}; - -static int vkms_add_overlay_plane(struct vkms_device *vkmsdev, int possibl= e_crtc_index, - struct drm_crtc *crtc) -{ - struct vkms_plane *overlay; - - overlay =3D vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_OVERLAY, possible_crt= c_index); - if (IS_ERR(overlay)) - return PTR_ERR(overlay); - - if (!overlay->base.possible_crtcs) - overlay->base.possible_crtcs =3D drm_crtc_mask(crtc); - - return 0; -} - -int vkms_output_init(struct vkms_device *vkmsdev, int possible_crtc_index) -{ - struct vkms_output *output =3D &vkmsdev->output; - struct drm_device *dev =3D &vkmsdev->drm; - struct drm_connector *connector; - struct drm_encoder *encoder; - struct drm_crtc *crtc =3D &output->crtc; - struct vkms_plane *primary, *cursor =3D NULL; - int ret; - int writeback; - unsigned int n; - - /* - * Initialize used plane. One primary plane is required to perform the co= mposition. - * - * The overlay and cursor planes are not mandatory, but can be used to pe= rform complex - * composition. - */ - primary =3D vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_PRIMARY, possible_crt= c_index); - if (IS_ERR(primary)) - return PTR_ERR(primary); - - if (vkmsdev->config->overlay) { - for (n =3D 0; n < NUM_OVERLAY_PLANES; n++) { - ret =3D vkms_add_overlay_plane(vkmsdev, possible_crtc_index, crtc); - if (ret) - return ret; - } - } - - if (vkmsdev->config->cursor) { - cursor =3D vkms_plane_init(vkmsdev, DRM_PLANE_TYPE_CURSOR, possible_crtc= _index); - if (IS_ERR(cursor)) - return PTR_ERR(cursor); - } - - ret =3D vkms_crtc_init(dev, crtc, &primary->base, &cursor->base); - if (ret) - return ret; - - connector =3D drmm_kzalloc(&vkmsdev->drm, sizeof(*connector), GFP_KERNEL); - if (!connector) - return -ENOMEM; - - ret =3D drmm_connector_init(dev, connector, &vkms_connector_funcs, - DRM_MODE_CONNECTOR_VIRTUAL, NULL); - if (ret) { - DRM_ERROR("Failed to init connector\n"); - return ret; - } - - drm_connector_helper_add(connector, &vkms_conn_helper_funcs); - - encoder =3D drmm_kzalloc(&vkmsdev->drm, sizeof(*encoder), GFP_KERNEL); - if (!encoder) - return -ENOMEM; - - ret =3D drmm_encoder_init(dev, encoder, &vkms_encoder_funcs, - DRM_MODE_ENCODER_VIRTUAL, NULL); - if (ret) { - DRM_ERROR("Failed to init encoder\n"); - return ret; - } - /* - * This is an hardcoded value to select crtc for the encoder. - * 1 here designate the first registered CRTC, the one allocated in [1] - */ - encoder->possible_crtcs =3D 1; - - ret =3D drm_connector_attach_encoder(connector, encoder); - if (ret) { - DRM_ERROR("Failed to attach connector to encoder\n"); - return ret; - } - - if (vkmsdev->config->writeback) { - writeback =3D vkms_enable_writeback_connector(vkmsdev); - if (writeback) - DRM_ERROR("Failed to init writeback connector\n"); - } - - drm_mode_config_reset(dev); - - return 0; -} diff --git a/drivers/gpu/drm/vkms/vkms_writeback.c b/drivers/gpu/drm/vkms/v= kms_writeback.c index 5e75880a5845..322e247979b2 100644 --- a/drivers/gpu/drm/vkms/vkms_writeback.c +++ b/drivers/gpu/drm/vkms/vkms_writeback.c @@ -110,7 +110,7 @@ static void vkms_wb_cleanup_job(struct drm_writeback_co= nnector *connector, struct drm_writeback_job *job) { struct vkms_writeback_job *vkmsjob =3D job->priv; - struct vkms_device *vkmsdev; + struct vkms_crtc *vkms_crtc =3D container_of(connector, struct vkms_crtc,= wb_connector); =20 if (!job->fb) return; @@ -119,8 +119,7 @@ static void vkms_wb_cleanup_job(struct drm_writeback_co= nnector *connector, =20 drm_framebuffer_put(vkmsjob->wb_frame_info.fb); =20 - vkmsdev =3D drm_device_to_vkms_device(job->fb->dev); - vkms_set_composer(&vkmsdev->output, false); + vkms_set_composer(vkms_crtc, false); kfree(vkmsjob); } =20 @@ -129,10 +128,8 @@ static void vkms_wb_atomic_commit(struct drm_connector= *conn, { struct drm_connector_state *connector_state =3D drm_atomic_get_new_connec= tor_state(state, conn); - struct vkms_device *vkmsdev =3D drm_device_to_vkms_device(conn->dev); - struct vkms_output *output =3D &vkmsdev->output; + struct vkms_crtc *output =3D drm_crtc_to_vkms_crtc(connector_state->crtc); struct drm_writeback_connector *wb_conn =3D &output->wb_connector; - struct drm_connector_state *conn_state =3D wb_conn->base.state; struct vkms_crtc_state *crtc_state =3D output->composer_state; struct drm_framebuffer *fb =3D connector_state->writeback_job->fb; u16 crtc_height =3D crtc_state->base.crtc->mode.vdisplay; @@ -141,12 +138,12 @@ static void vkms_wb_atomic_commit(struct drm_connecto= r *conn, struct vkms_frame_info *wb_frame_info; u32 wb_format =3D fb->format->format; =20 - if (!conn_state) + if (!connector_state) return; =20 - vkms_set_composer(&vkmsdev->output, true); + vkms_set_composer(output, true); =20 - active_wb =3D conn_state->writeback_job->priv; + active_wb =3D connector_state->writeback_job->priv; wb_frame_info =3D &active_wb->wb_frame_info; =20 spin_lock_irq(&output->composer_lock); @@ -167,9 +164,10 @@ static const struct drm_connector_helper_funcs vkms_wb= _conn_helper_funcs =3D { .atomic_check =3D vkms_wb_atomic_check, }; =20 -int vkms_enable_writeback_connector(struct vkms_device *vkmsdev) +int vkms_enable_writeback_connector(struct vkms_device *vkmsdev, + struct vkms_crtc *vkms_crtc) { - struct drm_writeback_connector *wb =3D &vkmsdev->output.wb_connector; + struct drm_writeback_connector *wb =3D &vkms_crtc->wb_connector; =20 drm_connector_helper_add(&wb->base, &vkms_wb_conn_helper_funcs); =20 diff --git a/drivers/gpu/drm/vkms/vkms_writeback.h b/drivers/gpu/drm/vkms/v= kms_writeback.h index 44dff15faff6..39613a2408be 100644 --- a/drivers/gpu/drm/vkms/vkms_writeback.h +++ b/drivers/gpu/drm/vkms/vkms_writeback.h @@ -16,6 +16,6 @@ struct vkms_writeback_job { }; =20 /* Writeback */ -int vkms_enable_writeback_connector(struct vkms_device *vkmsdev); +int vkms_enable_writeback_connector(struct vkms_device *vkmsdev, struct vk= ms_crtc *vkms_crtc); =20 #endif //_VKMS_WRITEBACK_H --=20 2.44.2 From nobody Sun Feb 8 13:52:53 2026 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB6191AD9C6 for ; Wed, 14 Aug 2024 10:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630012; cv=none; b=i3b9oxioN+VT8/Mfck/8brlrJR06u4LRMiJ1AbsUQ3Z59916nP8qhg+3RaVu9bwCduiQqyUJ6ThfhaDNXEZNFWEUsQsuvsKuBb9uhJFKbsnkg2mMTRMyCY8XILag/otUC+zYbvQlSPRB3qlQoPpwHK1c0kNQZAsS7vk3xbfXOFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723630012; c=relaxed/simple; bh=ki/lFkpR1RrA123peJlktjkk+feg0St36zz0X5xujE4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wx6Ip6oNOGzuAjcY16rkpX8nYsXpEBEsFHOdsWf3TssFi0BfSU7bx8tzK921+Lp3pigMai+sLPqSigmTnY6ziV5/vsOcDzkzJM1r2ICShai3PtYi4KtBASo9ZRGVcmbeq+3cl914HUuyL79F06X++TO6+kIlnExeGJh4EyW1Zu0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=NyR4qyMU; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="NyR4qyMU" Received: by mail.gandi.net (Postfix) with ESMTPSA id 98AA324000D; Wed, 14 Aug 2024 10:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1723630008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ea7pVN4/fiWlgVdZQ+grfVtQw6oY9NFZLxK+AjxJGtA=; b=NyR4qyMU832FCiAia9GW3rFrVmSoJ44LfSu9KK3VeL9H4kiM+ukpQa8qfzjzMB68BtLcwG hsby1z/GNuFVjHzzHtk3jGErawwZFb5jpSwxSLzuws3e02J7QX66GKemGKolg6RDdiYsbx u9z0ct2ExB7A1EChd5SEHxQh3ALJWzggQZUcOKftxOcHLyIoDptTIT2lX7k32FrndOjRjc oLV+dX9RFJ59B3QrPSNhZkqMEx/A7hStNKZJ9wwOh+SERkx9w7KcK9woeZYFK7ZJwcISt6 ODaiRL4u4wvIIKRFlszzQvkHW0cZWuq0ZvF4ikf6dvuaGmASEVH42YzjWB/BZw== From: Louis Chauvet Date: Wed, 14 Aug 2024 12:06:37 +0200 Subject: [PATCH RFC 4/4] drm/vkms: Rename all vkms_crtc instance to be consistent Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240814-google-vkms-managed-v1-4-7ab8b8921103@bootlin.com> References: <20240814-google-vkms-managed-v1-0-7ab8b8921103@bootlin.com> In-Reply-To: <20240814-google-vkms-managed-v1-0-7ab8b8921103@bootlin.com> To: Rodrigo Siqueira , Melissa Wen , =?utf-8?q?Ma=C3=ADra_Canal?= , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie Cc: dri-devel@lists.freedesktop.org, arthurgrillo@riseup.net, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, nicolejadeyee@google.com, Louis Chauvet X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=11324; i=louis.chauvet@bootlin.com; h=from:subject:message-id; bh=ki/lFkpR1RrA123peJlktjkk+feg0St36zz0X5xujE4=; b=owEBbQKS/ZANAwAIASCtLsZbECziAcsmYgBmvIGzwH4/6a2ovZgPAqsi1cTj7ZqKRe0GYdgTI Bt0y9cLfBiJAjMEAAEIAB0WIQRPj7g/vng8MQxQWQQgrS7GWxAs4gUCZryBswAKCRAgrS7GWxAs 4q09D/9FturdGjy0wC4VisWT8ev2JLI1K5QJT/4NscwouO4A51sQPMsoGF2+0JmuMoNvQ8jqHnM 0SB8KifPsWW6P3FAEIlHg0CMYJqkH9h4jwgZQBbNQ9047+R0wTR7tMZnqmtOhLTSq2fZGQCBu1n qmdLnE3LdZd5Gm+Ly2Ycvo0iJ1s60iuSdVpDoaAUhOtm4cODT+oD7QyibQtnmIISePZ1WU0OkZb M6aXjySsZ6KCsw3vfksQ2Vyl2hfaqztEdqSuBoetDfGZyeg/MntR8DzfMtHW6xLSb3CmPbDMQER /5S8plQNtPeQ8QymCQpTp1ZxO2xl5umcsvo9ujtMFki4SX+5/lsP1CgJna8DBdW3OQMyuvrRtEU fuRyjmCcOic+dWsAb+x7/h6syh8WzEvdpWO40IcA430aokaq4yWP3ml+d6HrsBodK8YgjmRSKHv O2RTF4q0A/a0ieZUjNZFrM3YVHpDLY41KXybOD/e0++0hwleIww2xhjbQsw5SRNmCDvRiw5ABEL G/XK/KbhgG+8ip4XgyG8S37RDtjIGv1Rp6/OAizJ/dxKV3ESXhC7BKge+R+WdG1r4xmR0HY75qF qRqdSC0NIk0TY/T43V/ieMp+kBPBnQQ5/nl+MIDClEbJlVA5o9Wh8DRH7rILs9tT8FchLiwR75g kxg77mtmYPz7bRg== X-Developer-Key: i=louis.chauvet@bootlin.com; a=openpgp; fpr=8B7104AE9A272D6693F527F2EC1883F55E0B40A5 X-GND-Sasl: louis.chauvet@bootlin.com To avoid inconsistency in the VKMS code, rename all struct vkms_crtc instances to vkms_crtc. This should not change the behavior of the driver. Signed-off-by: Louis Chauvet Reviewed-by: Jos=C3=A9 Exp=C3=B3sito --- drivers/gpu/drm/vkms/vkms_composer.c | 30 ++++++++++---------- drivers/gpu/drm/vkms/vkms_composer.h | 2 +- drivers/gpu/drm/vkms/vkms_crtc.c | 52 +++++++++++++++++--------------= ---- drivers/gpu/drm/vkms/vkms_writeback.c | 12 ++++---- 4 files changed, 48 insertions(+), 48 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vk= ms_composer.c index 9b2f578c2eb1..4376900b4986 100644 --- a/drivers/gpu/drm/vkms/vkms_composer.c +++ b/drivers/gpu/drm/vkms/vkms_composer.c @@ -515,13 +515,13 @@ void vkms_composer_worker(struct work_struct *work) composer_work); struct drm_crtc *crtc =3D crtc_state->base.crtc; struct vkms_writeback_job *active_wb =3D crtc_state->active_writeback; - struct vkms_crtc *out =3D drm_crtc_to_vkms_crtc(crtc); + struct vkms_crtc *vkms_crtc =3D drm_crtc_to_vkms_crtc(crtc); bool crc_pending, wb_pending; u64 frame_start, frame_end; u32 crc32 =3D 0; int ret; =20 - spin_lock_irq(&out->composer_lock); + spin_lock_irq(&vkms_crtc->composer_lock); frame_start =3D crtc_state->frame_start; frame_end =3D crtc_state->frame_end; crc_pending =3D crtc_state->crc_pending; @@ -545,7 +545,7 @@ void vkms_composer_worker(struct work_struct *work) crtc_state->gamma_lut.base =3D NULL; } =20 - spin_unlock_irq(&out->composer_lock); + spin_unlock_irq(&vkms_crtc->composer_lock); =20 /* * We raced with the vblank hrtimer and previous work already computed @@ -563,10 +563,10 @@ void vkms_composer_worker(struct work_struct *work) return; =20 if (wb_pending) { - drm_writeback_signal_completion(&out->wb_connector, 0); - spin_lock_irq(&out->composer_lock); + drm_writeback_signal_completion(&vkms_crtc->wb_connector, 0); + spin_lock_irq(&vkms_crtc->composer_lock); crtc_state->wb_pending =3D false; - spin_unlock_irq(&out->composer_lock); + spin_unlock_irq(&vkms_crtc->composer_lock); } =20 /* @@ -616,31 +616,31 @@ int vkms_verify_crc_source(struct drm_crtc *crtc, con= st char *src_name, return 0; } =20 -void vkms_set_composer(struct vkms_crtc *out, bool enabled) +void vkms_set_composer(struct vkms_crtc *vkms_crtc, bool enabled) { bool old_enabled; =20 if (enabled) - drm_crtc_vblank_get(&out->base); + drm_crtc_vblank_get(&vkms_crtc->base); =20 - spin_lock_irq(&out->lock); - old_enabled =3D out->composer_enabled; - out->composer_enabled =3D enabled; - spin_unlock_irq(&out->lock); + spin_lock_irq(&vkms_crtc->lock); + old_enabled =3D vkms_crtc->composer_enabled; + vkms_crtc->composer_enabled =3D enabled; + spin_unlock_irq(&vkms_crtc->lock); =20 if (old_enabled) - drm_crtc_vblank_put(&out->base); + drm_crtc_vblank_put(&vkms_crtc->base); } =20 int vkms_set_crc_source(struct drm_crtc *crtc, const char *src_name) { - struct vkms_crtc *out =3D drm_crtc_to_vkms_crtc(crtc); + struct vkms_crtc *vkms_crtc =3D drm_crtc_to_vkms_crtc(crtc); bool enabled =3D false; int ret =3D 0; =20 ret =3D vkms_crc_parse_source(src_name, &enabled); =20 - vkms_set_composer(out, enabled); + vkms_set_composer(vkms_crtc, enabled); =20 return ret; } diff --git a/drivers/gpu/drm/vkms/vkms_composer.h b/drivers/gpu/drm/vkms/vk= ms_composer.h index 77efd2e3a63a..5a676b9960aa 100644 --- a/drivers/gpu/drm/vkms/vkms_composer.h +++ b/drivers/gpu/drm/vkms/vkms_composer.h @@ -7,7 +7,7 @@ #include "vkms_crtc.h" =20 void vkms_composer_worker(struct work_struct *work); -void vkms_set_composer(struct vkms_crtc *out, bool enabled); +void vkms_set_composer(struct vkms_crtc *vkms_crtc, bool enabled); =20 /* CRC Support */ const char *const *vkms_get_crc_sources(struct drm_crtc *crtc, size_t *cou= nt); diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_c= rtc.c index 47e62fb3e404..6f6d3118b2f2 100644 --- a/drivers/gpu/drm/vkms/vkms_crtc.c +++ b/drivers/gpu/drm/vkms/vkms_crtc.c @@ -16,34 +16,34 @@ =20 static enum hrtimer_restart vkms_vblank_simulate(struct hrtimer *timer) { - struct vkms_crtc *output =3D hrtimer_to_vkms_crtc(timer); - struct drm_crtc *crtc =3D &output->base; + struct vkms_crtc *vkms_crtc =3D hrtimer_to_vkms_crtc(timer); + struct drm_crtc *crtc =3D &vkms_crtc->base; struct vkms_crtc_state *state; u64 ret_overrun; bool ret, fence_cookie; =20 fence_cookie =3D dma_fence_begin_signalling(); =20 - ret_overrun =3D hrtimer_forward_now(&output->vblank_hrtimer, - output->period_ns); + ret_overrun =3D hrtimer_forward_now(&vkms_crtc->vblank_hrtimer, + vkms_crtc->period_ns); if (ret_overrun !=3D 1) pr_warn("%s: vblank timer overrun\n", __func__); =20 - spin_lock(&output->lock); + spin_lock(&vkms_crtc->lock); ret =3D drm_crtc_handle_vblank(crtc); if (!ret) DRM_ERROR("vkms failure on handling vblank"); =20 - state =3D output->composer_state; - spin_unlock(&output->lock); + state =3D vkms_crtc->composer_state; + spin_unlock(&vkms_crtc->lock); =20 - if (state && output->composer_enabled) { + if (state && vkms_crtc->composer_enabled) { u64 frame =3D drm_crtc_accurate_vblank_count(crtc); =20 /* update frame_start only if a queued vkms_composer_worker() * has read the data */ - spin_lock(&output->composer_lock); + spin_lock(&vkms_crtc->composer_lock); if (!state->crc_pending) state->frame_start =3D frame; else @@ -51,9 +51,9 @@ static enum hrtimer_restart vkms_vblank_simulate(struct h= rtimer *timer) state->frame_start, frame); state->frame_end =3D frame; state->crc_pending =3D true; - spin_unlock(&output->composer_lock); + spin_unlock(&vkms_crtc->composer_lock); =20 - ret =3D queue_work(output->composer_workq, &state->composer_work); + ret =3D queue_work(vkms_crtc->composer_workq, &state->composer_work); if (!ret) DRM_DEBUG_DRIVER("Composer worker already queued\n"); } @@ -67,23 +67,23 @@ static int vkms_enable_vblank(struct drm_crtc *crtc) { struct drm_device *dev =3D crtc->dev; struct drm_vblank_crtc *vblank =3D drm_crtc_vblank_crtc(crtc); - struct vkms_crtc *out =3D drm_crtc_to_vkms_crtc(crtc); + struct vkms_crtc *vkms_crtc =3D drm_crtc_to_vkms_crtc(crtc); =20 drm_calc_timestamping_constants(crtc, &crtc->mode); =20 - hrtimer_init(&out->vblank_hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); - out->vblank_hrtimer.function =3D &vkms_vblank_simulate; - out->period_ns =3D ktime_set(0, vblank->framedur_ns); - hrtimer_start(&out->vblank_hrtimer, out->period_ns, HRTIMER_MODE_REL); + hrtimer_init(&vkms_crtc->vblank_hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_RE= L); + vkms_crtc->vblank_hrtimer.function =3D &vkms_vblank_simulate; + vkms_crtc->period_ns =3D ktime_set(0, vblank->framedur_ns); + hrtimer_start(&vkms_crtc->vblank_hrtimer, vkms_crtc->period_ns, HRTIMER_M= ODE_REL); =20 return 0; } =20 static void vkms_disable_vblank(struct drm_crtc *crtc) { - struct vkms_crtc *out =3D drm_crtc_to_vkms_crtc(crtc); + struct vkms_crtc *vkms_crtc =3D drm_crtc_to_vkms_crtc(crtc); =20 - hrtimer_cancel(&out->vblank_hrtimer); + hrtimer_cancel(&vkms_crtc->vblank_hrtimer); } =20 static bool vkms_get_vblank_timestamp(struct drm_crtc *crtc, @@ -91,7 +91,7 @@ static bool vkms_get_vblank_timestamp(struct drm_crtc *cr= tc, bool in_vblank_irq) { struct drm_device *dev =3D crtc->dev; - struct vkms_crtc *output =3D drm_crtc_to_vkms_crtc(crtc); + struct vkms_crtc *vkms_crtc =3D drm_crtc_to_vkms_crtc(crtc); struct drm_vblank_crtc *vblank =3D drm_crtc_vblank_crtc(crtc); =20 if (!READ_ONCE(vblank->enabled)) { @@ -99,7 +99,7 @@ static bool vkms_get_vblank_timestamp(struct drm_crtc *cr= tc, return true; } =20 - *vblank_time =3D READ_ONCE(output->vblank_hrtimer.node.expires); + *vblank_time =3D READ_ONCE(vkms_crtc->vblank_hrtimer.node.expires); =20 if (WARN_ON(*vblank_time =3D=3D vblank->time)) return true; @@ -111,7 +111,7 @@ static bool vkms_get_vblank_timestamp(struct drm_crtc *= crtc, * the vblank core expects. Therefore we need to always correct the * timestampe by one frame. */ - *vblank_time -=3D output->period_ns; + *vblank_time -=3D vkms_crtc->period_ns; =20 return true; } @@ -235,18 +235,18 @@ static void vkms_crtc_atomic_disable(struct drm_crtc = *crtc, static void vkms_crtc_atomic_begin(struct drm_crtc *crtc, struct drm_atomic_state *state) { - struct vkms_crtc *vkms_output =3D drm_crtc_to_vkms_crtc(crtc); + struct vkms_crtc *vkms_crtc =3D drm_crtc_to_vkms_crtc(crtc); =20 /* This lock is held across the atomic commit to block vblank timer * from scheduling vkms_composer_worker until the composer is updated */ - spin_lock_irq(&vkms_output->lock); + spin_lock_irq(&vkms_crtc->lock); } =20 static void vkms_crtc_atomic_flush(struct drm_crtc *crtc, struct drm_atomic_state *state) { - struct vkms_crtc *vkms_output =3D drm_crtc_to_vkms_crtc(crtc); + struct vkms_crtc *vkms_crtc =3D drm_crtc_to_vkms_crtc(crtc); =20 if (crtc->state->event) { spin_lock(&crtc->dev->event_lock); @@ -261,9 +261,9 @@ static void vkms_crtc_atomic_flush(struct drm_crtc *crt= c, crtc->state->event =3D NULL; } =20 - vkms_output->composer_state =3D drm_crtc_state_to_vkms_crtc_state(crtc->s= tate); + vkms_crtc->composer_state =3D drm_crtc_state_to_vkms_crtc_state(crtc->sta= te); =20 - spin_unlock_irq(&vkms_output->lock); + spin_unlock_irq(&vkms_crtc->lock); } =20 static const struct drm_crtc_helper_funcs vkms_crtc_helper_funcs =3D { diff --git a/drivers/gpu/drm/vkms/vkms_writeback.c b/drivers/gpu/drm/vkms/v= kms_writeback.c index 322e247979b2..69c710f21e57 100644 --- a/drivers/gpu/drm/vkms/vkms_writeback.c +++ b/drivers/gpu/drm/vkms/vkms_writeback.c @@ -128,9 +128,9 @@ static void vkms_wb_atomic_commit(struct drm_connector = *conn, { struct drm_connector_state *connector_state =3D drm_atomic_get_new_connec= tor_state(state, conn); - struct vkms_crtc *output =3D drm_crtc_to_vkms_crtc(connector_state->crtc); - struct drm_writeback_connector *wb_conn =3D &output->wb_connector; - struct vkms_crtc_state *crtc_state =3D output->composer_state; + struct vkms_crtc *vkms_crtc =3D drm_crtc_to_vkms_crtc(connector_state->cr= tc); + struct drm_writeback_connector *wb_conn =3D &vkms_crtc->wb_connector; + struct vkms_crtc_state *crtc_state =3D vkms_crtc->composer_state; struct drm_framebuffer *fb =3D connector_state->writeback_job->fb; u16 crtc_height =3D crtc_state->base.crtc->mode.vdisplay; u16 crtc_width =3D crtc_state->base.crtc->mode.hdisplay; @@ -141,15 +141,15 @@ static void vkms_wb_atomic_commit(struct drm_connecto= r *conn, if (!connector_state) return; =20 - vkms_set_composer(output, true); + vkms_set_composer(vkms_crtc, true); =20 active_wb =3D connector_state->writeback_job->priv; wb_frame_info =3D &active_wb->wb_frame_info; =20 - spin_lock_irq(&output->composer_lock); + spin_lock_irq(&vkms_crtc->composer_lock); crtc_state->active_writeback =3D active_wb; crtc_state->wb_pending =3D true; - spin_unlock_irq(&output->composer_lock); + spin_unlock_irq(&vkms_crtc->composer_lock); drm_writeback_queue_job(wb_conn, connector_state); active_wb->pixel_write =3D get_pixel_write_line_function(wb_format); drm_rect_init(&wb_frame_info->src, 0, 0, crtc_width, crtc_height); --=20 2.44.2