From nobody Mon Feb 9 19:55:38 2026 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C7E31B32B8 for ; Wed, 14 Aug 2024 14:10:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723644631; cv=none; b=qzh2mHWjvp/ZpBEMlbblCQE9qToDXR/SFJtFR8uhXAUdveDkl9Kk3cjaPHLhLOw0AlWAirV/B5Ur6bIUxoOGg53AUMsYnwTlRP0JeSi8FaD+uyf8obAKcUqymFdUp1paRuq7SIOlKuz+43Ypbdrh/EtMMZYr/BkBsOV4kZ0uCf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723644631; c=relaxed/simple; bh=p1d0PwsGi9ZIQzfl23z0qmpUMB44j2s2TwRUGtvJ61k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dsZ3FGE0Ap7Moa7yx0Uae2kZ/9B8jYgG/Dk2GLn6Y0g5QjAVgPm09nXvnIN077aQhddO6N3GOM7uFGEdQGSqcmDxuz3h4Yb8wDnPwE64/H7DCJlZvGKGPy9OWxm7PHLLUX2MiQ81OJPSS2SlxBQwZRXxo+Hi/bC6lh8azMNnZc8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=gLu8p6SJ; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gLu8p6SJ" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-44ff7cc5432so48623891cf.3 for ; Wed, 14 Aug 2024 07:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723644628; x=1724249428; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J+MnvoDMkIDZgtH/+nAB3DNM4UvBw/qkbvF0T8ogQzM=; b=gLu8p6SJ5cnCC/Pvk7rQtaTqjCkNvx3VaJzzlp/t1T6zrg1Lewrfudu4Li7EqnovMc yqOqcCFdwqj7kyAiyLRq0pq1LyCZWqDmQzyLH/6KaDrlwKBnpDCEZP7meecDnY7bRh6q UIhP2MlZR0T0CJv31iQkgZtkyhWWxUGLjzHAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723644628; x=1724249428; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J+MnvoDMkIDZgtH/+nAB3DNM4UvBw/qkbvF0T8ogQzM=; b=Jvxmk+HQ6IZPFnLqcWQtbx4xKKUSm4Jipi0I4e8tUTZyJzeq9QwYaCbjrmgL792sDi ZsAunNtt7fCnVRhZ3JwV6pMDv+G3LqXb41ehB7FkBRhGfnOc+VOTb39KSDxklf9HgsVH 7HCtY6Fw8TRjX04N1MqyJCIlIVR8kjTTAO5G7fxGOLWqcVVzg8G4nkDXY9I/oUHxbhRy kJw58NkL79WgTt0AcO/tktVMHZeOhh6Ce7p6ZMftqgHXBtwgdQlLn61PPI+6o8JPrWuW scpkUfASXlfJJ6XgLEpVbBG4XsMq+YoXKtL9bBLMjeXI+ixd2ULYtvD5pLoIn06n8DdJ ng6A== X-Forwarded-Encrypted: i=1; AJvYcCVhFYVvf4Fht0RRwJ0KODJiI1yd52MXs18ecxZx2cVaFzj5TNJj5NNQagpRRwPUl5MhQy35tK4ZqCtH7aI2LzLDYMogl0I1EhYDEhXU X-Gm-Message-State: AOJu0Yyw9uFJ+nKJa/gonLDILJdDCBOlI78RnoT1cU++377+yt34KlzL VfIWocIU1zRiuZFrmJuzNQHMwBhrVlxshiBGD/jAkP+u4N7pR/6Bt7OnZHp5hGgS2+fxejlSlM2 riONw X-Google-Smtp-Source: AGHT+IGKGbuNG7hmYX5BMf9s5t22zLanCeUhBuhAdconaflpMOvPAASHFkv4KPsCl1wH4eumOOYE+Q== X-Received: by 2002:a05:6214:2f08:b0:6b7:ab98:b8b3 with SMTP id 6a1803df08f44-6bf5d1f954dmr27328656d6.34.1723644628071; Wed, 14 Aug 2024 07:10:28 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bd82c61637sm43861036d6.7.2024.08.14.07.10.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 07:10:27 -0700 (PDT) From: Ricardo Ribalda Date: Wed, 14 Aug 2024 14:10:22 +0000 Subject: [PATCH v2 1/2] media: drivers/media/dvb-core: Split dvb_frontend_open() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240814-coccinelle-followup-v2-1-88b4e4a9af56@chromium.org> References: <20240814-coccinelle-followup-v2-0-88b4e4a9af56@chromium.org> In-Reply-To: <20240814-coccinelle-followup-v2-0-88b4e4a9af56@chromium.org> To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.13.0 Move the actual opening to its own function. Not intended code change. This is a preparation for the next patch. Signed-off-by: Ricardo Ribalda --- drivers/media/dvb-core/dvb_frontend.c | 143 +++++++++++++++++-------------= ---- 1 file changed, 70 insertions(+), 73 deletions(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core= /dvb_frontend.c index 4f78f30b3646..e81b9996530e 100644 --- a/drivers/media/dvb-core/dvb_frontend.c +++ b/drivers/media/dvb-core/dvb_frontend.c @@ -2760,80 +2760,13 @@ static __poll_t dvb_frontend_poll(struct file *file= , struct poll_table_struct *w return 0; } =20 -static int dvb_frontend_open(struct inode *inode, struct file *file) +static int __dvb_frontend_open(struct inode *inode, struct file *file) { struct dvb_device *dvbdev =3D file->private_data; struct dvb_frontend *fe =3D dvbdev->priv; struct dvb_frontend_private *fepriv =3D fe->frontend_priv; - struct dvb_adapter *adapter =3D fe->dvb; int ret; =20 - dev_dbg(fe->dvb->device, "%s:\n", __func__); - if (fe->exit =3D=3D DVB_FE_DEVICE_REMOVED) - return -ENODEV; - - if (adapter->mfe_shared =3D=3D 2) { - mutex_lock(&adapter->mfe_lock); - if ((file->f_flags & O_ACCMODE) !=3D O_RDONLY) { - if (adapter->mfe_dvbdev && - !adapter->mfe_dvbdev->writers) { - mutex_unlock(&adapter->mfe_lock); - return -EBUSY; - } - adapter->mfe_dvbdev =3D dvbdev; - } - } else if (adapter->mfe_shared) { - mutex_lock(&adapter->mfe_lock); - - if (!adapter->mfe_dvbdev) - adapter->mfe_dvbdev =3D dvbdev; - - else if (adapter->mfe_dvbdev !=3D dvbdev) { - struct dvb_device - *mfedev =3D adapter->mfe_dvbdev; - struct dvb_frontend - *mfe =3D mfedev->priv; - struct dvb_frontend_private - *mfepriv =3D mfe->frontend_priv; - int mferetry =3D (dvb_mfe_wait_time << 1); - - mutex_unlock(&adapter->mfe_lock); - while (mferetry-- && (mfedev->users !=3D -1 || - mfepriv->thread)) { - if (msleep_interruptible(500)) { - if (signal_pending(current)) - return -EINTR; - } - } - - mutex_lock(&adapter->mfe_lock); - if (adapter->mfe_dvbdev !=3D dvbdev) { - mfedev =3D adapter->mfe_dvbdev; - mfe =3D mfedev->priv; - mfepriv =3D mfe->frontend_priv; - if (mfedev->users !=3D -1 || - mfepriv->thread) { - mutex_unlock(&adapter->mfe_lock); - return -EBUSY; - } - adapter->mfe_dvbdev =3D dvbdev; - } - } - } - - if (dvbdev->users =3D=3D -1 && fe->ops.ts_bus_ctrl) { - if ((ret =3D fe->ops.ts_bus_ctrl(fe, 1)) < 0) - goto err0; - - /* If we took control of the bus, we need to force - reinitialization. This is because many ts_bus_ctrl() - functions strobe the RESET pin on the demod, and if the - frontend thread already exists then the dvb_init() routine - won't get called (which is what usually does initial - register configuration). */ - fepriv->reinitialise =3D 1; - } - if ((ret =3D dvb_generic_open(inode, file)) < 0) goto err1; =20 @@ -2871,8 +2804,6 @@ static int dvb_frontend_open(struct inode *inode, str= uct file *file) =20 dvb_frontend_get(fe); =20 - if (adapter->mfe_shared) - mutex_unlock(&adapter->mfe_lock); return ret; =20 err3: @@ -2891,9 +2822,75 @@ static int dvb_frontend_open(struct inode *inode, st= ruct file *file) err1: if (dvbdev->users =3D=3D -1 && fe->ops.ts_bus_ctrl) fe->ops.ts_bus_ctrl(fe, 0); -err0: - if (adapter->mfe_shared) - mutex_unlock(&adapter->mfe_lock); + + return ret; +} + +static int dvb_frontend_open(struct inode *inode, struct file *file) +{ + struct dvb_device *dvbdev =3D file->private_data; + struct dvb_frontend *fe =3D dvbdev->priv; + struct dvb_adapter *adapter =3D fe->dvb; + int ret; + + dev_dbg(fe->dvb->device, "%s:\n", __func__); + if (fe->exit =3D=3D DVB_FE_DEVICE_REMOVED) + return -ENODEV; + + if (!adapter->mfe_shared) + return __dvb_frontend_open(inode, file); + + if (adapter->mfe_shared =3D=3D 2) { + mutex_lock(&adapter->mfe_lock); + if ((file->f_flags & O_ACCMODE) !=3D O_RDONLY) { + if (adapter->mfe_dvbdev && + !adapter->mfe_dvbdev->writers) { + mutex_unlock(&adapter->mfe_lock); + return -EBUSY; + } + adapter->mfe_dvbdev =3D dvbdev; + } + } else { + mutex_lock(&adapter->mfe_lock); + + if (!adapter->mfe_dvbdev) { + adapter->mfe_dvbdev =3D dvbdev; + } else if (adapter->mfe_dvbdev !=3D dvbdev) { + struct dvb_device + *mfedev =3D adapter->mfe_dvbdev; + struct dvb_frontend + *mfe =3D mfedev->priv; + struct dvb_frontend_private + *mfepriv =3D mfe->frontend_priv; + int mferetry =3D (dvb_mfe_wait_time << 1); + + mutex_unlock(&adapter->mfe_lock); + while (mferetry-- && (mfedev->users !=3D -1 || + mfepriv->thread)) { + if (msleep_interruptible(500)) { + if (signal_pending(current)) + return -EINTR; + } + } + + mutex_lock(&adapter->mfe_lock); + if (adapter->mfe_dvbdev !=3D dvbdev) { + mfedev =3D adapter->mfe_dvbdev; + mfe =3D mfedev->priv; + mfepriv =3D mfe->frontend_priv; + if (mfedev->users !=3D -1 || + mfepriv->thread) { + mutex_unlock(&adapter->mfe_lock); + return -EBUSY; + } + adapter->mfe_dvbdev =3D dvbdev; + } + } + } + + ret =3D __dvb_frontend_open(inode, file); + mutex_unlock(&adapter->mfe_lock); + return ret; } =20 --=20 2.46.0.76.ge559c4bf1a-goog From nobody Mon Feb 9 19:55:38 2026 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7EB91B32C7 for ; Wed, 14 Aug 2024 14:10:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723644632; cv=none; b=LAzoB+gqFg9pNsXkhlJIMTQrIDbAmCr03C1QEy6kOVR9CgfFVB7SsmnQNCl4RV2GvxHI4/YupHYMqrPpQ1iHjDlHN/ZgFgXoWXjz5HnTaSzVUL32/bgLlP3qr4AtGoV2TbbzghLEqrqYJpDVbFQJvYt80Pgm1ZQ8BCKT8q0jaeA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723644632; c=relaxed/simple; bh=4gn8bYoICNRPD5yYaXqN7k4ps+ZaI5ktDDh23/kBYnI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WAbZUB+Pfk3yGqUYe2s2oY009bRUd3ZNU3+0Ojkei/Yz5/6C7roQiVzz37yGAAzEuontdjWEm+uvvviz3egi1FgNYTFqCCCVZp6WFB971XpRW3pekHQC4bcgmy5SjS2e4KW4/MoOR+18bzVYd6iYBax5ngft344FWYpuHOWrlnQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=DB1WRNnI; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DB1WRNnI" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6bb96ef0e96so36666166d6.2 for ; Wed, 14 Aug 2024 07:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723644629; x=1724249429; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=54a5u/AIPf3FUAW8TNrqnrThXWk83FvG6faGGYYzLrQ=; b=DB1WRNnIlvhxurNUWgR+OE5VSZXk0ZEjvalmFRPFIo9xZp4lxnKLG8aCRC6+cPFXJF 4f5vc2x3XkTOMr4i/MLhPzlqBYiXSU5/4WiAAohhXiYJ30AUlfKBd5+ukIwTGHVWKo6Z 5IlDSJukIbgxCcfZFzAp8PI8hzA2LAdKZ6Lx4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723644629; x=1724249429; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=54a5u/AIPf3FUAW8TNrqnrThXWk83FvG6faGGYYzLrQ=; b=icQXMxw/AeH54eM4rS6RpW9T501A5V6WcEve1l0s7lpZZghsuTZWrdvVxD6xlw8fXm SEeCODsObJiVJArSXyQE/iLKEAe3RwdFF+3OFmsLhMX8176BDC7sdn1Ls5GIE3iEgP++ T63PKHzP5SknWTv1+OVKMTjCJgVyOt3jJHQYTbPvhyTrxl25pM+w+g3qVpY5Lcy9+kkv 7JYbMZdLetu2xJ+Da87dKGvEU3ef/fgqTVLBaDq/Thg2gpzwL+JEBNFjlsmFlTGmnQRB yUNVaFK2l5VV02zaWuH+kjEjTEL8jCqgjsNeFPxUbkjo++ELvvJFewcrTxZ/+gEJvQa6 jiEg== X-Forwarded-Encrypted: i=1; AJvYcCXpdjNjtAgzquT/yq6hISR2haCtSFu49rIXPYn8iN2vPhCuFtNeVv1WxuymIorXPnn33jWF8eKzqPb1BqnV+t/WbwhvThEzapl+iyv4 X-Gm-Message-State: AOJu0Yw1ybB6s6g1Pc/fLxQHUZC1SvyGQDCM/Q2lim0W4hNFmuwRJY/F CZO0TDWe4SW188llMhB9EStRthfXVRRVBV9oNP1xdZviJNf2yereGBHyMSy+i9BGALi/QOxMkDi Nefv3 X-Google-Smtp-Source: AGHT+IGoc+E8kKrWo1+MczAL0858Q7D1ror/nkleb+dMvRF8IpoDO/rkwov2Dl1lO/HtMEEoy1wPXA== X-Received: by 2002:a05:6214:225:b0:6bf:6375:397f with SMTP id 6a1803df08f44-6bf63753b38mr12558086d6.25.1723644628736; Wed, 14 Aug 2024 07:10:28 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bd82c61637sm43861036d6.7.2024.08.14.07.10.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 07:10:28 -0700 (PDT) From: Ricardo Ribalda Date: Wed, 14 Aug 2024 14:10:23 +0000 Subject: [PATCH v2 2/2] media: drivers/media/dvb-core: Refactor dvb_frontend_open locking Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240814-coccinelle-followup-v2-2-88b4e4a9af56@chromium.org> References: <20240814-coccinelle-followup-v2-0-88b4e4a9af56@chromium.org> In-Reply-To: <20240814-coccinelle-followup-v2-0-88b4e4a9af56@chromium.org> To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Verkuil , Ricardo Ribalda X-Mailer: b4 0.13.0 Split out the wait function, and introduce some new toys: guard and lockdep. This fixes the following cocci warnings: drivers/media/dvb-core/dvb_frontend.c:2897:1-7: preceding lock on line 2776 drivers/media/dvb-core/dvb_frontend.c:2897:1-7: preceding lock on line 2786 drivers/media/dvb-core/dvb_frontend.c:2897:1-7: preceding lock on line 2809 Signed-off-by: Ricardo Ribalda --- drivers/media/dvb-core/dvb_frontend.c | 58 ++++++++++++++++++++++---------= ---- 1 file changed, 37 insertions(+), 21 deletions(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core= /dvb_frontend.c index e81b9996530e..7f5d0c297464 100644 --- a/drivers/media/dvb-core/dvb_frontend.c +++ b/drivers/media/dvb-core/dvb_frontend.c @@ -30,6 +30,7 @@ #include #include #include +#include #include =20 #include @@ -2826,6 +2827,34 @@ static int __dvb_frontend_open(struct inode *inode, = struct file *file) return ret; } =20 +static int wait_dvb_frontend(struct dvb_adapter *adapter, + struct dvb_device *mfedev) +{ + struct dvb_frontend *mfe =3D mfedev->priv; + struct dvb_frontend_private *mfepriv =3D mfe->frontend_priv; + int mferetry =3D (dvb_mfe_wait_time << 1); + int ret =3D 0; + + lockdep_assert_held(&adapter->mfe_lock); + + if (mfedev->users =3D=3D -1 && !mfepriv->thread) + return 0; + + mutex_unlock(&adapter->mfe_lock); + + while (mferetry-- && (mfedev->users !=3D -1 || mfepriv->thread)) { + if (msleep_interruptible(500)) + if (signal_pending(current)) { + ret =3D -EINTR; + break; + } + } + + mutex_lock(&adapter->mfe_lock); + + return ret; +} + static int dvb_frontend_open(struct inode *inode, struct file *file) { struct dvb_device *dvbdev =3D file->private_data; @@ -2840,19 +2869,16 @@ static int dvb_frontend_open(struct inode *inode, s= truct file *file) if (!adapter->mfe_shared) return __dvb_frontend_open(inode, file); =20 + guard(mutex)(&adapter->mfe_lock); + if (adapter->mfe_shared =3D=3D 2) { - mutex_lock(&adapter->mfe_lock); if ((file->f_flags & O_ACCMODE) !=3D O_RDONLY) { if (adapter->mfe_dvbdev && - !adapter->mfe_dvbdev->writers) { - mutex_unlock(&adapter->mfe_lock); + !adapter->mfe_dvbdev->writers) return -EBUSY; - } adapter->mfe_dvbdev =3D dvbdev; } } else { - mutex_lock(&adapter->mfe_lock); - if (!adapter->mfe_dvbdev) { adapter->mfe_dvbdev =3D dvbdev; } else if (adapter->mfe_dvbdev !=3D dvbdev) { @@ -2862,34 +2888,24 @@ static int dvb_frontend_open(struct inode *inode, s= truct file *file) *mfe =3D mfedev->priv; struct dvb_frontend_private *mfepriv =3D mfe->frontend_priv; - int mferetry =3D (dvb_mfe_wait_time << 1); - - mutex_unlock(&adapter->mfe_lock); - while (mferetry-- && (mfedev->users !=3D -1 || - mfepriv->thread)) { - if (msleep_interruptible(500)) { - if (signal_pending(current)) - return -EINTR; - } - } =20 - mutex_lock(&adapter->mfe_lock); + ret =3D wait_dvb_frontend(adapter, mfedev); + if (ret) + return ret; + if (adapter->mfe_dvbdev !=3D dvbdev) { mfedev =3D adapter->mfe_dvbdev; mfe =3D mfedev->priv; mfepriv =3D mfe->frontend_priv; if (mfedev->users !=3D -1 || - mfepriv->thread) { - mutex_unlock(&adapter->mfe_lock); + mfepriv->thread) return -EBUSY; - } adapter->mfe_dvbdev =3D dvbdev; } } } =20 ret =3D __dvb_frontend_open(inode, file); - mutex_unlock(&adapter->mfe_lock); =20 return ret; } --=20 2.46.0.76.ge559c4bf1a-goog