From nobody Tue Feb 10 03:57:33 2026 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7E2F1A76B6 for ; Tue, 13 Aug 2024 22:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.92.199 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723589440; cv=none; b=Dv92OQUJ/9ubhHRhbw3ewKJ6I7E9NfAiEtazMsMgweUlqN9FsgWT4r3P2nBs7lkYRif5JnvmE9mb9mw4FARoYaJvv5e3gDdbBwFMl936OmC4kM2suR5nFTyuFiI69FN6VMrFZMwv1+3kKqdRAv7L0LioYbzXsVxV/SsHcUz++Vs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723589440; c=relaxed/simple; bh=TnZwOCNsTC50oF6WkkQSYwA75XDmDW0q3W7IG+O8RYo=; h=Message-Id:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=kNoYPjnFmwqJu/YGt+4pk7tT40CrDrU9mlJ+UxYzrvxYLWqk28yXfqYeEi7UKYBZf1nV67Z5Ogx2Fhw88OjDfHlnOhEeCWCuRn/Qdd33dj9bcilkJPdj2lYlk60Wa/BXHkLu8jaZaS3ab9oajLHLBgjwi1znCa46K2jU33/8o28= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=gnZy3Asg; arc=none smtp.client-ip=90.155.92.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="gnZy3Asg" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-Id:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=N4qqyYvidrFryHZvi0gNFY6ukjdqN3urPMEKouQkyVY=; b=gnZy3AsgiNu6CZhX9QSQDLum5D QmIvz0JJsAzn+5rF+ctYWSVlzoBUEXMfCh1kNXgN6fv5hUla+VfLd3buhYOPz5g6bG79nDdCYFhc0 QE3ziTwq968d+Z/CV+3UsGcrWUocYZ17ZRP2NVEkviLkNiazba8IvXndudVJ4KS8/8AZOsi9TVhfz aCPXvM0bNlYT855FcAydppQc1bSu2MctyNqXfpPiwIYRKyNRnAlRHxfREqTLdHoNIe9AlXvXiTdrV Vu6z7yWAvTRc9WgM/isZPgnz3dVAAzuM42QBEkxUjI7203O5k17FKsC1kI3odMvUsod0DqnUkImiu WPYr4wKg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.97.1 #2 (Red Hat Linux)) id 1se0LW-00000007s12-0hti; Tue, 13 Aug 2024 22:50:30 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 0) id 3DDE8302440; Wed, 14 Aug 2024 00:50:29 +0200 (CEST) Message-Id: <20240813224015.943143811@infradead.org> User-Agent: quilt/0.65 Date: Wed, 14 Aug 2024 00:25:52 +0200 From: Peter Zijlstra To: mingo@kernel.org, tj@kernel.org, void@manifault.com Cc: peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, linux-kernel@vger.kernel.org, joelaf@google.com Subject: [PATCH 4/9] sched: Split up put_prev_task_balance() References: <20240813222548.049744955@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" With the goal of pushing put_prev_task() after pick_task() / into pick_next_task(). Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -5841,8 +5841,8 @@ static inline void schedule_debug(struct schedstat_inc(this_rq()->sched_count); } =20 -static void put_prev_task_balance(struct rq *rq, struct task_struct *prev, - struct rq_flags *rf) +static void prev_balance(struct rq *rq, struct task_struct *prev, + struct rq_flags *rf) { #ifdef CONFIG_SMP const struct sched_class *class; @@ -5860,8 +5860,6 @@ static void put_prev_task_balance(struct } #endif =20 - put_prev_task(rq, prev); - /* * We've updated @prev and no longer need the server link, clear it. * Must be done before ->pick_next_task() because that can (re)set @@ -5917,7 +5915,8 @@ __pick_next_task(struct rq *rq, struct t } =20 restart: - put_prev_task_balance(rq, prev, rf); + prev_balance(rq, prev, rf); + put_prev_task(rq, prev); =20 for_each_class(class) { p =3D class->pick_next_task(rq); @@ -6017,7 +6016,8 @@ pick_next_task(struct rq *rq, struct tas goto out; } =20 - put_prev_task_balance(rq, prev, rf); + prev_balance(rq, prev, rf); + put_prev_task(rq, prev); =20 smt_mask =3D cpu_smt_mask(cpu); need_sync =3D !!rq->core->core_cookie;