From nobody Tue Feb 10 01:50:21 2026 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C30A9199259; Tue, 13 Aug 2024 12:10:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723551016; cv=none; b=cbVoC/8shW7qi06rluMBFHDcphXbjkJexQrsjn/6zVFcZ0itH2893lZkzmboCtgcOlZdXeNGq+HcWeYQyMCDBCa7gOE+5iDya31rJaDBRKKzscX3zwjgI+3pAzXdfoWRlSbb3EuDDOUZ3/TjNMURXpqeFNMpSEmqgcTzfShHWx4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723551016; c=relaxed/simple; bh=fS3pAxeY7KXNMzgv/VZvJo2TdW5N7JjyW6d84O4Uetg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=moLUbmg3P8GlVC/xtHqwE5bNEFuxe4zDcRlJjp8lTQwoXiaOe7Lg+rItrrA7vCXWtAVUIPec76e4kgUVhSDBnwBlFi2+M1803cY+wLWxFZux48lrbMfCxfYHhIQgeztI9wLWUPQ5PWxfQg8FUF6J+cEm5p1oIz7gh4E5Kqnoo8c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=none smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.93.142]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4WjqvV0Jknz4f3jHh; Tue, 13 Aug 2024 20:09:58 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.252]) by mail.maildlp.com (Postfix) with ESMTP id B8AFD1A018D; Tue, 13 Aug 2024 20:10:11 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP3 (Coremail) with SMTP id _Ch0CgDnl7YhTbtmPh4XBg--.33191S6; Tue, 13 Aug 2024 20:10:11 +0800 (CST) From: Kemeng Shi To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/7] ext4: remove dead check in __ext4_new_inode Date: Tue, 13 Aug 2024 20:07:09 +0800 Message-Id: <20240813120712.2592310-5-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240813120712.2592310-1-shikemeng@huaweicloud.com> References: <20240813120712.2592310-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _Ch0CgDnl7YhTbtmPh4XBg--.33191S6 X-Coremail-Antispam: 1UD129KBjvdXoWruw43AFWktr1DXr1Uuw1DAwb_yoWfCwc_Ga yktr4kA3yYq3Z3JFWvqrs5tF4DKr48KF15uFy5K34fZ3W5JrWkCa1DAr43Ary7u3yqvr98 uFW7Jry7ta4rKjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbVAYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l82xGYIkIc2x26280x7IE14v26r126s 0DM28IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xG Y2AK021l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14 v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAF wI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2 WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkE bVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbV WUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF 67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42 IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF 0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxh VjvjDU0xZFpf9x07jeVbkUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ Content-Type: text/plain; charset="utf-8" If we can't grab any inode, the prvious find_inode_bit will set ino to be >=3D EXT4_INODES_PER_GROUP(sb). So the check of need to repeat in the same group is not needed. Signed-off-by: Kemeng Shi --- fs/ext4/ialloc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index df41aa079cb5..f446588af368 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -1067,7 +1067,6 @@ struct inode *__ext4_new_inode(struct mnt_idmap *idma= p, goto next_group; } =20 -repeat_in_this_group: ret2 =3D find_inode_bit(sb, group, inode_bitmap_bh, &ino); if (!ret2) goto next_group; @@ -1117,8 +1116,6 @@ struct inode *__ext4_new_inode(struct mnt_idmap *idma= p, if (!ret2) goto got; /* we grabbed the inode! */ =20 - if (ino < EXT4_INODES_PER_GROUP(sb)) - goto repeat_in_this_group; next_group: if (++group =3D=3D ngroups) group =3D 0; --=20 2.30.0