From nobody Fri Dec 19 22:03:11 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C100186E37; Tue, 13 Aug 2024 11:31:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723548717; cv=none; b=snCLzz9qlO7XLOxWHJRj4a0cOm5YFa5vgbWsfPrA9xz6z2YYMJg0pKFxyKhr/P++5ceGnHogcyxNH9WXmicNs+W7ZQVeICDwSXxuili8OR1unGDhxjRZAezynSIr+388iAnEAPYc4MagbH+yvDcTl8HdNZiftRJdTpFQLdWf20M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723548717; c=relaxed/simple; bh=zrjblW4tZJGZS02KKKIzCi8Z3jnHJwQ/UCFoFzmkP0o=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=o5hZcfn8kkWNxyZ8mTy2bbh4sUjlKyQjyfjHMfbQP04TJTsp3fNAeAZHowr6+YnA8Pkq5hQ6w1A+DCjlbkE76XbNBBQiwsd8es6vlRKx8MI5KET4+krP/4RK15PuRswri85/8w04PUvoYSrNsiKIsE1Pfrls5FwBa6vOo7/WtxE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 988baac0596711efa216b1d71e6e1362-20240813 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_DIGIT_LEN HR_FROM_NAME, HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM HR_SJ_PHRASE, HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT HR_TO_NO_NAME, IP_UNTRUSTED, SRC_UNTRUSTED, IP_UNFAMILIAR, SRC_UNFAMILIAR DN_TRUSTED, SRC_TRUSTED, SA_EXISTED, SN_EXISTED, SPF_NOPASS DKIM_NOPASS, DMARC_NOPASS, CIE_BAD, CIE_GOOD_SPF, CIE_UNKNOWN GTI_FG_BS, GTI_C_CI, GTI_FG_IT, GTI_RG_INFO, GTI_C_PP GTI_C_BU, AMN_T1, AMN_GOOD, AMN_C_TI, AMN_C_BU ABX_MISS_RDNS X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.38,REQID:9b98c4d9-6d46-41ef-b372-383cf6360baa,IP:20, URL:0,TC:0,Content:-5,EDM:25,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACT ION:release,TS:35 X-CID-INFO: VERSION:1.1.38,REQID:9b98c4d9-6d46-41ef-b372-383cf6360baa,IP:20,UR L:0,TC:0,Content:-5,EDM:25,RT:0,SF:-5,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:35 X-CID-META: VersionHash:82c5f88,CLOUDID:4482d10b48165bdb2116332a68ef9560,BulkI D:240804171638GUAHFMRT,BulkQuantity:2,Recheck:0,SF:66|23|17|19|43|74|200|1 02,TC:nil,Content:0,EDM:5,IP:-2,URL:1,File:nil,RT:nil,Bulk:40,QS:nil,BEC:n il,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_ULS X-UUID: 988baac0596711efa216b1d71e6e1362-20240813 X-User: zhanghao1@kylinos.cn Received: from pve.sebastian [(118.250.0.224)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 1628703220; Tue, 13 Aug 2024 19:31:34 +0800 From: zhanghao To: kent.overstreet@linux.dev Cc: linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, zhanghao , syzbot+1a11884d9c9f1353942d@syzkaller.appspotmail.com Subject: [PATCH] bcachefs: Add check for the size of combined key and value Date: Tue, 13 Aug 2024 19:31:19 +0800 Message-Id: <20240813113119.114475-1-zhanghao1@kylinos.cn> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The bkey_val_bytes() gets the number of bytes of value stored in bkey->u64s.If u64s is smaller than BKEY_U64s, it causes a negative number to be converted to an unsigned number. Reported-by: syzbot+1a11884d9c9f1353942d@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D1a11884d9c9f1353942d Fixes: ba81523eaac3 ("bcachefs: Split out bkey_types.h") Link: https://lore.kernel.org/all/00000000000025321f061d7b62ff@google.com/T/ Signed-off-by: zhanghao --- fs/bcachefs/bkey_types.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/bcachefs/bkey_types.h b/fs/bcachefs/bkey_types.h index c9ae9e42b385..60fa5af93032 100644 --- a/fs/bcachefs/bkey_types.h +++ b/fs/bcachefs/bkey_types.h @@ -21,6 +21,8 @@ static inline struct bkey_i *bkey_next(struct bkey_i *k) =20 static inline size_t bkey_val_bytes(const struct bkey *k) { + if (k->u64s < BKEY_U64s) + return 0; return bkey_val_u64s(k) * sizeof(u64); } =20 base-commit: d74da846046aeec9333e802f5918bd3261fb5509 prerequisite-patch-id: 1ec511753fc7aab35ba0e982013cf91ba4403da6 --=20 2.39.2