From nobody Fri Dec 19 06:56:59 2025 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3E3A199E93 for ; Tue, 13 Aug 2024 12:31:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552289; cv=none; b=U39KbrA7CGDzqIAy2fvkguGTBiH9QjDEdu9WtGw5FhJzYpjdHvXODHRX3DS4ZnJbee591/oFXYd2DRUNYmTMXdHcLcWkj9En2siTkdmyrjdtI46ySpNpqXlwwIlQ2nM6u+PYiB+waDkipq770w1IyWcmrTvH8fNdeJWOaqFrQgw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552289; c=relaxed/simple; bh=2hjYCqULrObPbnZbgHzv3uAJ+2uRB9aIgS9bUw6j1Ak=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Mtn4Idn2dwUjjHvhpxe9CC+Y0qrgWAFysoW60HcyumpUSVrwsmuI1VwoK2WgAAyhutO1cshYwxj8sGYJHihyZgrcdwaDvbfnXXrmgMmQC2vxE3g5kuMUt6U19XMpPmxLHTIZJ3o+4mUpe345G7oPSuyuinlQujJC+9DKqpBJLa0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=eQ9EUiEo; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eQ9EUiEo" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-70945a007f0so3271369a34.2 for ; Tue, 13 Aug 2024 05:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723552287; x=1724157087; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=T26HDWEax3Ht99GbJ/5oCiq/G1VLMfwUsOvAjWX6wxI=; b=eQ9EUiEoqF3JNSQxYYIv66MNO57vkb+5MRLgZSN4y4G1SLVjTrsHwVyoQYoJ8dyg12 5eFOKO+bEu4yPkWbCmjhcI1gaQem3uekT/5Pq0ZX58qUBDMCRIvBIn+keFdXIUmmMQG4 eBinKE0Yahqbp8bUI9IhD9u66dRG2u2z6/1yM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723552287; x=1724157087; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T26HDWEax3Ht99GbJ/5oCiq/G1VLMfwUsOvAjWX6wxI=; b=iZHxXazQftlVGPKjXlc/Rr4yEBAAVJrl8cipK4Jqp7gSe2p/e6uZUJvs+K9y23JKu4 CwDXD2tYkWPBpEdtMNmvWRX3Ei8G+WXox0SGVcqDTIU6/8koLGuNQI1lh70btMWuedg7 brBqH5L/dlbyzyCM6n9OJBjW4okfYOJ6/ZJiw8BMOqWRrcGvnfMHHg+Ismf3XovsZ6a9 Wmr8uRvbLaBUmbLEXSfS8hFGZcZd+c7oh30UIsVezkB450+L3/mrSfeDjrJpafUHLCaj 8SLUr8EgBCW8FxnapIXcU77/bpGNCLIimvp1KGGxFBZRlULNrTkhhIX0s6/q8KAUzSX0 e4Mg== X-Forwarded-Encrypted: i=1; AJvYcCUZyMHYbJ4j2ehtSBBcMc6scZPA/ww8MjInlaUMeHFW090M5miSYxSVwcR2eYIZzO+AkBh5c3MASkfVG1f2uH4NxKPIWZph6vVl8lwx X-Gm-Message-State: AOJu0YzsaPbrGqg9h1xcTP9BHPMcQsMjbbUdXj2F7XuXmt7gkLOOJl7U VAC7Wxiikhajgtrypkf97WEBrYDjW23O2SUKej7JglTi+sKZe9yQ+1vLfUgCeA== X-Google-Smtp-Source: AGHT+IEt8IEr4mOSgyEydVS86tXDc+nflK2P9LtnkTrXNE23dIpoewktVCky3idoeTnXKhksyaliGw== X-Received: by 2002:a05:6358:4287:b0:1a5:dca5:a902 with SMTP id e5c5f4694b2df-1b19d2d037amr358929755d.17.1723552287107; Tue, 13 Aug 2024 05:31:27 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d66093sm337126685a.12.2024.08.13.05.31.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 05:31:26 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 13 Aug 2024 12:31:21 +0000 Subject: [PATCH v6 01/10] media: venus: Use flex array for hfi_session_release_buffer_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240813-cocci-flexarray-v6-1-de903fd8d988@chromium.org> References: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> In-Reply-To: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> To: Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 Replace the old style single element array with a flex array. We do not allocate this structure, so the size change should not be an issue. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:204:5-16: WARNING use flexible= -array member instead (https://www.kernel.org/doc/html/latest/process/depre= cated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 20acd412ee7b..42825f07939d 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -227,7 +227,7 @@ struct hfi_session_release_buffer_pkt { u32 extradata_size; u32 response_req; u32 num_buffers; - u32 buffer_info[1]; + u32 buffer_info[]; }; =20 struct hfi_session_release_resources_pkt { --=20 2.46.0.76.ge559c4bf1a-goog From nobody Fri Dec 19 06:56:59 2025 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3938A199E9F for ; Tue, 13 Aug 2024 12:31:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552290; cv=none; b=IlM5Fuh3qvqNOiAlOJrgKyM5spiGm/UIDa7bM51oid2K8fE5I2/WtDMU+u0U+bwLZv3WVyBkUkt3DLI9RbxG0U/lnOZ5s0GoRqmtYznmh2K+Od1mTiOWb/tC8VWyxiCXHvVgf7GvBvMl/G1p+ROjS5oxqxzKpyOH7wVmUi6+N24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552290; c=relaxed/simple; bh=jhEUxn/pes1s4feDivojryv2JX3XefUWasZTSaw7ezk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dlY2dfSfB3Gx9Cad04ZSp3jdYgTUYDVTzzAaVPS2hX1C3V5ojFuU0Dywxv86bv0a45O0AFDeqH622p4+uBYV3Js4GocaeEFLsTkXFv1BhWmx3pFHCPdU7OJkrtSksOi4TaeONSHH9Ye6wXrZN/Bw+lju8dEUFZJgADPWtPzvlW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=BcYGVssX; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="BcYGVssX" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7a1dd2004e1so338811385a.3 for ; Tue, 13 Aug 2024 05:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723552288; x=1724157088; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kIXlD3Ol1LtfkD9H1UrkUWGH9uBnFxqi4VyzSloENMQ=; b=BcYGVssXRm6etUVCMvxxXrRbwwLiXtbPeHpTPHJWaPNuvma1TarNsFEv/X2KjlEhFP WXfhgTVD6UtXJmPX6+VoWHL7OsTufmBXvraPCsoNYIm2nyBniNhg+f8Mpm/6Wmq8zw1Y nCEusZPDmIjW4Sq/foIol6TUkhg1sGLbGucnY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723552288; x=1724157088; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kIXlD3Ol1LtfkD9H1UrkUWGH9uBnFxqi4VyzSloENMQ=; b=T55G0gebICKYXK3EawfO/pvT7Ofx83TfBObk0kOgevbjqvEax1WoQPnWlrvU0YC44O Q7HTCE8jH0l/UsPHnN0q7dxrHB2OXRaWQRaDh2ydNCTetinJFfUPr+/4yzaRSIiPyvn4 L1aGgrDbFUoX6DBzeVZIUJ94Mmqx9zaDpuT0YT1OPHVYCxA1v/xZuNKUDBJl8aI8JaWl ecNqqt21zekr3MKW0cjIYN25xSAqGki7WmGmNc+T/YjaZ1obBQ+tH1uvx9WJLCU/vfZe 06MP4ZBsUc3Knfdwej5B5sjHG8g9QXYUPg5cpKBtjR4PSpsXjaoqxvSii34h/42DJw3E PK8w== X-Forwarded-Encrypted: i=1; AJvYcCWdTddEXd5xT5fUFKZWuE7sxdYOkQNXoDvpU8ipeSePWkcPeanFj13sxtOzboanjsgHjWtuus3hK6oubbmDknuw17qbzyGS2Sfm2gpf X-Gm-Message-State: AOJu0YxR1ua25a3YiK41waSvH4QKeBmSecoyQI09IeQmRQBBIY8TLhPU m5IDx06NXXN0bWpduUhB1gXadWedKq2GvRllKTbq2E4/lLhJOoLsR/iPvma1Og== X-Google-Smtp-Source: AGHT+IE2xmMkDbsMy07f7CYEHgKUTqwYARJxNMOEOo1+wr1sMyllp6Sk+ESICy3o68XiwLOXgbyOlw== X-Received: by 2002:a05:620a:40d0:b0:7a2:275:4841 with SMTP id af79cd13be357-7a4e15ab32bmr328777585a.34.1723552288115; Tue, 13 Aug 2024 05:31:28 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d66093sm337126685a.12.2024.08.13.05.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 05:31:27 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 13 Aug 2024 12:31:22 +0000 Subject: [PATCH v6 02/10] media: venus: Refactor struct hfi_uncompressed_plane_info Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240813-cocci-flexarray-v6-2-de903fd8d988@chromium.org> References: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> In-Reply-To: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> To: Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 This field is never used, but if we remove it we would change the size of the struct and can lead to behavior change. Stay on the safe side by replacing the single element array with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1003:43-60: WARNING use flex= ible-array member instead (https://www.kernel.org/doc/html/latest/process/d= eprecated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index e4c05d62cfc7..5e91f3f6984d 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1005,7 +1005,7 @@ struct hfi_uncompressed_plane_constraints { struct hfi_uncompressed_plane_info { u32 format; u32 num_planes; - struct hfi_uncompressed_plane_constraints plane_constraints[1]; + struct hfi_uncompressed_plane_constraints plane_constraints; }; =20 struct hfi_uncompressed_format_supported { --=20 2.46.0.76.ge559c4bf1a-goog From nobody Fri Dec 19 06:56:59 2025 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E15119AD85 for ; Tue, 13 Aug 2024 12:31:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552292; cv=none; b=k0xhM3qE4/UCEgbErL/9a9tDeiUr5QEoVoSP/Tfj6dAHTDnaqMcTw5pBbtT5Yuz3db7K6lBQagcsvf+XdUQohxe8arkboHHKZ2inki6ycKhf9jaLQlPppNkypfGU16oKJagwbn0rVcj7I5tbsWCkhZrsh43wxX92R/GTFPqbS3Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552292; c=relaxed/simple; bh=ZL1NQsUr+liQywEoPKyXYweeFBwJ9jb0tSJpH+9ycBc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AykOaqATbp2ZbRMF25rP5Ebk+TGwf1r/q9vXsg+aSsxf0kuyfuzrvEVT1Ft+EN7oM9yGVfTjBtKmAMemulRc8yKHuBbZ8k80QDFwoFEQ8VboyZfwXN/edAOqJObX2FFHMTxt9p5hqyh4cqCO7GQ9u0ri6UZjt+S4UCCliSogJ38= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QMn15TvD; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QMn15TvD" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7a1d6f47112so324054185a.0 for ; Tue, 13 Aug 2024 05:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723552289; x=1724157089; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SPUEi7uFjzY/rlu/HW/qtzhNgJ8EHrsVhU1gvPc5vvQ=; b=QMn15TvDv7mlw3QTOAGW/Y5rko3pr7VharwKEr86efGIgyVGIOIi++LbfDZTDGW2IX hYsKDB/xGqqZ48QJRuxU3dhXT3iBbSM6zNyYL/P/LGlxHkYh6elIGHo8EIEH+zPDnCZR 6KKC5Z24qfC5SuEqTDuPkcjKlljfWQidAdaxw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723552289; x=1724157089; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SPUEi7uFjzY/rlu/HW/qtzhNgJ8EHrsVhU1gvPc5vvQ=; b=t+ekQGXGKtxMlC/HWdejxI1oPBwW0ufaFlCa8Rj+/Rv0AM5f9c0xJ4gwgJjc6djkDY RhXpXl1T8hzcKRUFlWQR0aHkrAdzYFBzzFQdT1Me3X/it2DuNsspOPl3v6TgngcHWr/y /6/8WAb0e2UQsefOCRKdDoVpdOQZAQtQA19tYg1v6fXX7Bb8hvwoABtQWDfGl9ESWL8z C6gunM8NNan1hHW2xRslJ2v1uWll3FFu2VXYbCenKWoDx4hi3QejTiZSR7A737JgI990 Cn4UyGmn7zYVWnR58HgRvTYLRTy3D1Ehi51zkGNHMcDnodINpUAmSrP6/c3tDqnC75yq JT7Q== X-Forwarded-Encrypted: i=1; AJvYcCX3EkljncKffIcCFqlus8MZ41AfhaKAQOO+/aqenesk0zbxRwJuLjV6hoLmQdh7HuuPaGkYVRIncrzQkjlilyZjzaisdkoaJQ/92ygO X-Gm-Message-State: AOJu0Yyl5hZTn/FR51Bkqgwc+fZ32tn8ON5dYn0mxIMW3CNX+FW14P+s RnxvzowNzRVD1M6iuIblWW+Cju2FkFTy28BXf/9UQKDSF1E/v3UxciH1S1lZew== X-Google-Smtp-Source: AGHT+IHWcYMugnNAohBPlXl4Q5k2szXJLte2T2nQmFxv7LgGGp8+7SOgzgt3nTX3WjhN51/yObzS/g== X-Received: by 2002:a05:620a:3193:b0:7a1:d022:a3ae with SMTP id af79cd13be357-7a4e15b9c43mr381001685a.56.1723552289433; Tue, 13 Aug 2024 05:31:29 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d66093sm337126685a.12.2024.08.13.05.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 05:31:28 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 13 Aug 2024 12:31:23 +0000 Subject: [PATCH v6 03/10] media: venus: Refactor struct hfi_session_get_property_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240813-cocci-flexarray-v6-3-de903fd8d988@chromium.org> References: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> In-Reply-To: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> To: Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The struct hfi_session_get_property_pkt is always used to fetch a single property. Make that explicit in the code and avoid a single element array at the end of the struct. This change fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:194:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 4 ++-- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/p= latform/qcom/venus/hfi_cmds.c index 3418d2dd9371..75f4a3d3e748 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -402,7 +402,7 @@ static int pkt_session_get_property_1x(struct hfi_sessi= on_get_property_pkt *pkt, pkt->shdr.hdr.pkt_type =3D HFI_CMD_SESSION_GET_PROPERTY; pkt->shdr.session_id =3D hash32_ptr(cookie); pkt->num_properties =3D 1; - pkt->data[0] =3D ptype; + pkt->data =3D ptype; =20 return 0; } @@ -1110,7 +1110,7 @@ pkt_session_get_property_3xx(struct hfi_session_get_p= roperty_pkt *pkt, =20 switch (ptype) { case HFI_PROPERTY_CONFIG_VDEC_ENTROPY: - pkt->data[0] =3D HFI_PROPERTY_CONFIG_VDEC_ENTROPY; + pkt->data =3D HFI_PROPERTY_CONFIG_VDEC_ENTROPY; break; default: ret =3D pkt_session_get_property_1x(pkt, cookie, ptype); diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 42825f07939d..b158fcd00dd6 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -217,7 +217,7 @@ struct hfi_session_resume_pkt { struct hfi_session_get_property_pkt { struct hfi_session_hdr_pkt shdr; u32 num_properties; - u32 data[1]; + u32 data; }; =20 struct hfi_session_release_buffer_pkt { --=20 2.46.0.76.ge559c4bf1a-goog From nobody Fri Dec 19 06:56:59 2025 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5138419B3CE for ; Tue, 13 Aug 2024 12:31:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552292; cv=none; b=GG2JvCiOfTcx/WH0dYC7TnC3aPYgDvDfLugCYsaj8y+M6LJuU4oYdqaZl+ax+Cg7r5Sb6rEStYG+ZW10Xjp1XzA7cXQs+6+08R60vzFniAtLgVpKADKyu/J0GT498+4A2cPWrj8ye5+tg770He590rkiFgg3ZefnvkhB2/ZZLag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552292; c=relaxed/simple; bh=ApVSPxuYMUN4H8lzD4Upg+Z+gSvcQcwbvpLfoIq2hbE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t4E4BQnGUjw1K2/nrC2YivtGntJRnj1YPjugNuWrfsci4cuGyCYWL068+0yNkbbCp2UoFCvE/d+yGpVuJtkjJjTgrgxaKnLMYm+4A+4tM2PiDhoSIcoLBy1rcp/anFgHSPoRDoLZPVT6p7BVUU88F1MSyH9Gk9yPWTKc1VPsVBU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=SokGhc/P; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SokGhc/P" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7a1d436c95fso326696985a.3 for ; Tue, 13 Aug 2024 05:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723552290; x=1724157090; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cM75UgAWxu+REaaiYKxkbph00GT0OvjjuSsc322MsKo=; b=SokGhc/PmhWT/xmp4ulSQiLWsZttx4NqY4ECHZNAmK8LDrAEstEq46JWcEXzcc/oTV geaenCuvHw7M69kPnFtLvg6yz0OGiczUWcwHssVWVSvN9upLjQvnG0cMeKAwD9Mi9sAU PzYv8TzTMmE/gG6kGhq6eNshFFk3pg/f9FEFI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723552290; x=1724157090; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cM75UgAWxu+REaaiYKxkbph00GT0OvjjuSsc322MsKo=; b=wz1HPp+gdh/F9S6DIO0Y4/37TmZ/EyKUWa42SZ5w+tnrfK9g775WoVDpORTQtUs61J vw0ju1+YLw1vWHponMWb4goet2MCWnlt6Eo2ccIp5PKaSXNETCdTD7cf7PyK+kOdbHR2 FXeCzEQWQPM40rZZhJ+4t5h/Th9ujTVvFFZNjDm/zdtlFHcg0UQ1xHOQ3zOAOppvBZ7I +dWCQYYLZtplayT311cy6tOYS49RajWdba8jNg/cayt/22JUtSWZkePXA2inuFvHX63r glyQFLthFv6HP0Hyhdl07QIZgya7uouKIpWagiTlj1Z9nM14Ht8tdwuDSL3YW2OeBuOn YJjQ== X-Forwarded-Encrypted: i=1; AJvYcCWwLda3a2vp5AZW2twplKVDVY9XosUKekphWgPb1h4vFye8y6Oimzvj52hRfWDm+FotFVA83b5bsDZwr5OIdXQrjpEVV4yFhEBi6PfW X-Gm-Message-State: AOJu0Yz9OPOg6TZHBX3Oe5cHvr3m3UsSoA0iARYlYUJqTrEAbQMSTOiL L6uhepqZ8n2+ufXTzwKLZSiNZvg7R4ateAU9ozQ6QlGPdb1D7bqIh2DwXFIwQw== X-Google-Smtp-Source: AGHT+IGqUsckyjgQSDiOTZ2qQ5fmPaXoSD45meFlBIHRhS+FYbD9MyabumWybzKK7Lio3WuJ2DBAQA== X-Received: by 2002:a05:620a:371d:b0:79f:1783:4ba5 with SMTP id af79cd13be357-7a4e15102f8mr337731385a.12.1723552290179; Tue, 13 Aug 2024 05:31:30 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d66093sm337126685a.12.2024.08.13.05.31.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 05:31:29 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 13 Aug 2024 12:31:24 +0000 Subject: [PATCH v6 04/10] media: venus: Refactor struct hfi_uncompressed_format_supported Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240813-cocci-flexarray-v6-4-de903fd8d988@chromium.org> References: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> In-Reply-To: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> To: Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 plane_info is not a typical array, the data is not contiguous: pinfo =3D (void *)pinfo + sizeof(*constr) * num_planes + 2 * sizeof(u32); Replace the single element array with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1009:36-46: WARNING use flex= ible-array member instead (https://www.kernel.org/doc/html/latest/process/d= eprecated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- drivers/media/platform/qcom/venus/hfi_parser.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index 5e91f3f6984d..3edefa4edeb9 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1011,7 +1011,7 @@ struct hfi_uncompressed_plane_info { struct hfi_uncompressed_format_supported { u32 buffer_type; u32 format_entries; - struct hfi_uncompressed_plane_info plane_info[1]; + struct hfi_uncompressed_plane_info plane_info; }; =20 struct hfi_uncompressed_plane_actual { diff --git a/drivers/media/platform/qcom/venus/hfi_parser.c b/drivers/media= /platform/qcom/venus/hfi_parser.c index c43839539d4d..3df241dc3a11 100644 --- a/drivers/media/platform/qcom/venus/hfi_parser.c +++ b/drivers/media/platform/qcom/venus/hfi_parser.c @@ -157,7 +157,7 @@ static void parse_raw_formats(struct venus_core *core, u32 codecs, u32 domain, void *d= ata) { struct hfi_uncompressed_format_supported *fmt =3D data; - struct hfi_uncompressed_plane_info *pinfo =3D fmt->plane_info; + struct hfi_uncompressed_plane_info *pinfo =3D &fmt->plane_info; struct hfi_uncompressed_plane_constraints *constr; struct raw_formats rawfmts[MAX_FMT_ENTRIES] =3D {}; u32 entries =3D fmt->format_entries; --=20 2.46.0.76.ge559c4bf1a-goog From nobody Fri Dec 19 06:56:59 2025 Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A3F819B5BE for ; Tue, 13 Aug 2024 12:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552294; cv=none; b=kMBvzpD9bu7RuMolrtNJ7DuiR+esTXKT82Maju2/vqW3sEk7pIawdwhkERKgJiZtxAjOXbVD/jSB1p1eaS+n/ke9DlcPwFkxqVDCc4nk7r0LqYIgsEHhdGK4CxDnu9PaHriYvituxELwV0Xqsm+JganMtkPo+tOjUUkGOsGggfs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552294; c=relaxed/simple; bh=pg9ToY3eZZPX52hwA+vpBAJrwr/I05JuqPkuqgNqkes=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NuqZbWQQPjQ5fD+N7gMGox41VNEHhxZAbMwgHwJErWNlIi1IGYt5MbTKK54oOZD7A+QYzoc5anBQgPjdwEs9tlG41QkOuTPlkcbQd3vBJytk0gePEiiueaNO7MP/KCKgjvDtUa/U81pYLR+CgvEw1SJqeF4ilAjL4kfus1QJUIg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=gPowbZqF; arc=none smtp.client-ip=209.85.217.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gPowbZqF" Received: by mail-vs1-f53.google.com with SMTP id ada2fe7eead31-49291b02e20so1850059137.2 for ; Tue, 13 Aug 2024 05:31:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723552291; x=1724157091; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PD7uAa+iA+SJ/l3ATpDCq2SdEEBJK/PvJJHcjFH/M0o=; b=gPowbZqFUylKRiyV2nH7DSRqKYL6BFDUh9T9YVYglwSFuunFrAh2C36kZCUa++p75D eYVUXrkFu71DRvN3fouKLwqLBgjcqUU+4UB4JYBKZvNFglVUsKVTe+9NgoXHgxbD7wQt oAf+VmN/E9BKBIHqn+W96ZFaOmFuhhNynRDvo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723552291; x=1724157091; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PD7uAa+iA+SJ/l3ATpDCq2SdEEBJK/PvJJHcjFH/M0o=; b=PsJIlI7IqSbyhEaHVErnU+YDSGGFfsNBGTHlo7EJrfLjoVNfnZ1uz7mebIa9h0rw5C lTdHWWpqmM99LMGrpumGInLY6z8pNgUJN3ZSO5FaAJzhHJNnRajka2WQAPPWQoiGkoG+ VnKbUmg1XNTdVzIRm9bvF3GNJIG5uau7ctRbTkKWiEka0bK3WL7H5VLFklE0SoOsHBev VWh2gB7EDFM3YdJgVDMEd03lXtTXayZH0ehahj2BcKSGV1j9F5SUTNWXTKAbge6mJLcr QHIMax1rLGROJ95uMEfiE6Z1fC1GWc97yYFQaV6HX1hHu/NldTrBTq14BmMs5xX9zxWR dHeA== X-Forwarded-Encrypted: i=1; AJvYcCUHxWZBznQTOXKdBn1+tOFUucSZ92wvJSwnAfwLugM60S3ynaYB/8QI1HU37LigFu2eyvAajrdRikk4YnOOnaoBdHOScjCn0ZAQJgPe X-Gm-Message-State: AOJu0YwJ9IP8Fp3PEnyORqVnGV40n4VZjv0MsMTW3rffYaisOF/gt55+ QbsQO1OEkJKcCqiz0d5ywPbZqEEqVnXzYOZzb4CPoupO0m9n4EXmpeCSCruNoQ== X-Google-Smtp-Source: AGHT+IFVb/FCO4zojDS37rQuslFijZLZCXUsY63IfMRU3vxtSFRIIMGWvVO1eWkt+coPhL2FV4eZdw== X-Received: by 2002:a05:6102:370d:b0:494:10af:2bc8 with SMTP id ada2fe7eead31-49743ae9e3bmr3816743137.24.1723552291444; Tue, 13 Aug 2024 05:31:31 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d66093sm337126685a.12.2024.08.13.05.31.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 05:31:30 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 13 Aug 2024 12:31:25 +0000 Subject: [PATCH v6 05/10] media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240813-cocci-flexarray-v6-5-de903fd8d988@chromium.org> References: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> In-Reply-To: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> To: Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The single element array data[1] is never used. Replace it with a padding field of the same size. This fixes the following cocci error: drivers/media/platform/qcom/venus/hfi_cmds.h:163:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index b158fcd00dd6..01f5463e0fa2 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -168,7 +168,7 @@ struct hfi_session_empty_buffer_uncompressed_plane0_pkt= { u32 input_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 data; }; =20 struct hfi_session_empty_buffer_uncompressed_plane1_pkt { --=20 2.46.0.76.ge559c4bf1a-goog From nobody Fri Dec 19 06:56:59 2025 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF78F199EA3 for ; Tue, 13 Aug 2024 12:31:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552295; cv=none; b=hmcsxLDiAmMjXTsOHvRFAAPxmYgga4imjPHZLa8RLWr+sNp4iisZBcT7v2GpPobz6yvUKM3M2xLnyVnVJRN7MUf4zVVn3ARjMBDsigBtGA5elohyAxWmlv2euqvBCynLizvtqXEyToDjphb9xpYXJelJ4THXoT1cNcQjxZLha9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552295; c=relaxed/simple; bh=p3jpIeza54CehiKa4tgs3b0fLFLZmsQXlmR/9zDU8zE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nPjIe7D0f5MMw0VkVfAcE6cx1fg/jwpupmOexzp+BKtKkwqsLcGtWwssAU1J948C/FExc8EJKeRCqSaOJZ+iaacg6zyHK2Xyt59SaCBx3AvQx1w50cGyzoD1kCuCE6ieaw/uMeo98XQwBWL7xfNZy0sImufCKNn7/0VeySUYkmQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=MCa5iFVr; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MCa5iFVr" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7a20c529c77so347825685a.1 for ; Tue, 13 Aug 2024 05:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723552293; x=1724157093; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1m0qOojs5u3nnBaeP4R5XScsxR2jha5TQMuQ4WnxziM=; b=MCa5iFVrevFQRZCWEujwrjTneXRrA8m7gzExYD0227hDj52RkHFqIetXHo4TSJuET1 m9hOAvXd28ui95L4EJjCPyZAkynq5WjllxVk5qewPGEndIrj4WcQ9v9IuuejlDD5WiOD 6u5D5cNG7tpXnGEjEJlnkIcHyKNY2gAQkFNJ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723552293; x=1724157093; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1m0qOojs5u3nnBaeP4R5XScsxR2jha5TQMuQ4WnxziM=; b=uIFiQJjtNtIHLtrpff0MX/cqzr8YQSDwZbUWkyEkXsUYyGvQ6xqZ5wLqOSPgNCKWm7 Ok7IUsk6L6AJH4xG9Hkp39WBx3zFPc7xjIuvgoSVAvi8DgJuAvnhoSx3tFwbUnwNhvdl e9Wt5Fx2B3o2kc/df9nEpshbO0TImCOleE/5/7ctds1xIr7wEGt3V6+v4wtm2eRePf0t A15knbZ4hjlradojWrapC9UxrTXcPv/kwnPnhLWffZBQKSExb5NOkabCIfYSEKHbH/LY j2F3JJDWrQIpffsUJ10TZaBmeLwf3Ha4XWU1HbSfgqAae6VQVXO3R1q/Fsk50EFId9v1 HHtA== X-Forwarded-Encrypted: i=1; AJvYcCWIM58WCdRouDAyUdgVn8k4rl2MU2CEOe/gWNWEUZvVK98ZByfoutigOXBrWsyJAgPxoVKZ2KLP6pvQFAndlZruhGhCh7hR1C/Oz7HP X-Gm-Message-State: AOJu0Ywr/42E3WrybKpjc3O5OO2pRb4INSKZYSP948mOBeqRUpU6HT85 zbeo83LCfaEkLkUxEkslYCzbvpTe5lIL3kGCJqFXp9KcV/OM/u7rGREoO8ypnw== X-Google-Smtp-Source: AGHT+IENk8SpFwKWQLaKLf4cUuMptIr4tn+mOT99jzPw9kpr9RZ5Z+jGj/wE6VKPl37qKt0dMKu46w== X-Received: by 2002:a05:620a:2450:b0:79d:5b21:804a with SMTP id af79cd13be357-7a4e1500decmr422156385a.14.1723552292603; Tue, 13 Aug 2024 05:31:32 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d66093sm337126685a.12.2024.08.13.05.31.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 05:31:31 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 13 Aug 2024 12:31:26 +0000 Subject: [PATCH v6 06/10] media: venus: Refactor hfi_session_empty_buffer_compressed_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240813-cocci-flexarray-v6-6-de903fd8d988@chromium.org> References: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> In-Reply-To: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> To: Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The single element array data[1] is never used. Replace it with a padding field of the same size. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:146:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 01f5463e0fa2..de0bf2399505 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -151,7 +151,7 @@ struct hfi_session_empty_buffer_compressed_pkt { u32 input_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 data; }; =20 struct hfi_session_empty_buffer_uncompressed_plane0_pkt { --=20 2.46.0.76.ge559c4bf1a-goog From nobody Fri Dec 19 06:56:59 2025 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43BB319D082 for ; Tue, 13 Aug 2024 12:31:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552296; cv=none; b=MYx4Zk8OECoIJ+gLAm9UB16HxE1Yx/Svxqcq6PyyLr4voaAxf4dmnXSUEsNcX8zLcK4xWYystsi1cP3KU2/veEzdKzu/3BrPYELrMZpBsLdHqH++9oGm10BLYe7S953WAFhg6IrrZEghkJ2BDibEJVb+koMEmndplisvywdn+Uk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552296; c=relaxed/simple; bh=XHYQDkjDMyOGGgCU6Mjf54/QzhOW3tNUgMmebpG++2I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E6vjlRlTlJ161gBZmC8l80Amok5B1AhSV6zzzh5L8Sr9+HSLb+2rrKwY1iLM3MXdAmQtAO+wn5ZW1cvX6n1W74oTw8dFS8Qpi6NnTKYOdd/DtvE+gttPSIfzoz7H4m4OpmbUGUVlfRSfG2INvbRQT2UQirO0yRtmbbLoo6zUA6E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Jq50SsSY; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Jq50SsSY" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-704466b19c4so3163355a34.0 for ; Tue, 13 Aug 2024 05:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723552293; x=1724157093; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SmP2dlTbOpENrA/D3hKhfvN/jpkEsPn3dnXsTIK3Biw=; b=Jq50SsSY8fa1/W9DkR/dV5z1KQFHvz+1g65BkRr2PJYs82rMVI+RsCoDghiKBXDfiq Chb6QzfUTi6Jgi3AkLGRISnXeA4Ho4tyNKNdGrj8YYfFjrWqEfYEKEkCo0J2uOG0a24f AMtOqX7ZG1eYU60hBuOiz63JsiO0OlS3wWr9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723552293; x=1724157093; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SmP2dlTbOpENrA/D3hKhfvN/jpkEsPn3dnXsTIK3Biw=; b=CsvM4+13C6GEZi1A41w0KbifX6jfLVwIIONVmMLZKJ2b4flEfDpPcmM1PG7ubJw3D8 LiGHvXOLb/t2mOYQcLSVYrNSkR0XBoh6w7EwtVH+GyHEN1TMdZEGvvoLI5/0K+zvJcTo uVdqE34QMCDhFVMrKGFuINa9nf3J24+Ttb+s+nIRyuPz8A9UHFp8qpyBXlsda13sgdiZ iYtkOwMwqiHmaT2R7RRzjGTOvB/ZTOosY4kD8Mjf1iqUmCAY+l7mxXcnLwkBvofNry0T uHsrSKr9ywnP+G/KEHIPG+1PyrIJKH0O9f2QT/oy+oIdFzJCGTipV2xgEeR7eGNzbngs 7qXQ== X-Forwarded-Encrypted: i=1; AJvYcCXnvIP5yx+UsWCEJ6Jw4C5c2CyvlIfanKjm6OlWwTT2fKfVoV0YBWSEH2/jY8UiajZ+5x5troqUoRu7pWXiVRmTNs/nHpLF9xwU4ULV X-Gm-Message-State: AOJu0YyZhIxHWzef6pko16pP9MTX5OSGY1W3cFROUDdtGhQ7RK6olBmg HhCwOXzrFWZi9jNbPIpPfmSAffTrfyjxOokYhUQDmYeI8ZlvVk9PqkmdiVaI7w== X-Google-Smtp-Source: AGHT+IFUP1qwWY0UlEZOY+1Y9HfO9zE5pmTE6knRdTsVmzNpByhzpAcfuYpMMEA+syDSvg8RTIVLSQ== X-Received: by 2002:a05:6359:5a8d:b0:1aa:d5c8:ec94 with SMTP id e5c5f4694b2df-1b19d2f4aecmr435584955d.26.1723552293448; Tue, 13 Aug 2024 05:31:33 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d66093sm337126685a.12.2024.08.13.05.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 05:31:32 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 13 Aug 2024 12:31:27 +0000 Subject: [PATCH v6 07/10] media: venus: Refactor hfi_sys_get_property_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240813-cocci-flexarray-v6-7-de903fd8d988@chromium.org> References: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> In-Reply-To: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> To: Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 Replace a single length element array with an element. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:77:5-9: WARNING use flexible-a= rray member instead (https://www.kernel.org/doc/html/latest/process/depreca= ted.html#zero-length-and-one-element-arrays) Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/p= latform/qcom/venus/hfi_cmds.c index 75f4a3d3e748..0a4de8ca1df5 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -156,7 +156,7 @@ void pkt_sys_image_version(struct hfi_sys_get_property_= pkt *pkt) pkt->hdr.size =3D sizeof(*pkt); pkt->hdr.pkt_type =3D HFI_CMD_SYS_GET_PROPERTY; pkt->num_properties =3D 1; - pkt->data[0] =3D HFI_PROPERTY_SYS_IMAGE_VERSION; + pkt->data =3D HFI_PROPERTY_SYS_IMAGE_VERSION; } =20 int pkt_session_init(struct hfi_session_init_pkt *pkt, void *cookie, diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index de0bf2399505..615ac8d156a5 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -74,7 +74,7 @@ struct hfi_sys_set_property_pkt { struct hfi_sys_get_property_pkt { struct hfi_pkt_hdr hdr; u32 num_properties; - u32 data[1]; + u32 data; }; =20 struct hfi_sys_set_buffers_pkt { --=20 2.46.0.76.ge559c4bf1a-goog From nobody Fri Dec 19 06:56:59 2025 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4A3419D88B for ; Tue, 13 Aug 2024 12:31:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552297; cv=none; b=TOS/WZuuT8Tp/7w2pGhFECMIx7sMd9gW5F/teyT9q0k7/gZ4+GqQgKCHG0wSyj3whX9bH+NAftXPiUeqgvIQqKKFBgZ+shQpiPwlGRznAr07DGlujKTxiWplf+ZO2oGX5m4JlSt6xQuwrwNQXPY7SMyPvEpcGpwDqkHn+JvkG3Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552297; c=relaxed/simple; bh=KWjKLHgDnVqj5qogv7pkiKcxHSFjMmLdRbW4n/wiXWQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NcOGFBGjsEIZivILAFVPs3UWSi1rsPHa2y5cpmOCG42iXOYgqCPN1jey3mvgYzWJ95ggtB7gIHdnUqHvVW/Q6qF3qod0DyWx9EFBSJWp61T6/rcO5hUKNs4zvQ6m5AVTOZQQ+sg58etkpqss3tMg1VK/0HkUS38h8pE/LCgDIMw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Q8wI0bX5; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Q8wI0bX5" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7a1df0a9281so342916785a.1 for ; Tue, 13 Aug 2024 05:31:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723552295; x=1724157095; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gCqo6e1jk+3zjFaKrik7m1Dhac+Vev7BPrVsdbvmhKg=; b=Q8wI0bX5l+W0rWrd3rq70xPMWjCBOlA/3lk2hyDcEa4JLF1d2BO2DO6qegmbdPH2Tt AedDy5JAdRU8RaQLOJq6bRTGqXzgnWO+Q39w7w1pBxsABfyHU+yozJ5MEmOFxnHBrsVe kgvH4jhSB+PrF0Ujvj7AfmhAX2QFK3bHkcXPU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723552295; x=1724157095; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gCqo6e1jk+3zjFaKrik7m1Dhac+Vev7BPrVsdbvmhKg=; b=JI2K+HmjawqujWFbShvrR1QuUKNPq9iq5CGkD11vAq5+3ycimZnH50/wRvtUyawNH0 ZuXSUfkcupz8gx7BhJwW+eXc/8FgZFqfggeiFrP/CKNxIlR301lAaM+WBWK7sUXXVu1g 0uLczn2b6UxZIZGhMOTFFILVDHEg7SPF8wreGz8LJIea0fZ5yA7CyIjxXmqM+sAMJUIC wvMFcsv1zwCXrXhFXk/Yt588uTJfbuRIYhv8B6qUHWCwrIf4hZlrrZc7BuK0Z//BGxpq /jWbXHKDGYaBjLZw+/mBIE/5QBj0OEcdC7brgR6ijme4Un3A8yHHKugkP7wrSbXPu2O5 70sA== X-Forwarded-Encrypted: i=1; AJvYcCXg76KtRuCI2y2fDbQ4XwaBn+PUgaj430kRf+RiJ0iwnNyX2lCXkR9qV9h3x2lfT+wmLiqt3chmYCfzvvklatpiCGeLpeQIg8YR+hh7 X-Gm-Message-State: AOJu0Yzu8wIOvag4NNPvOQxDo2SyTzg/lAU76jIaxgbqSZp93uR5Blz1 GIH7eUWWwd/+/KMkugh4cy3z2xiRaCOeyLUH3tdyazze+emdLZQC05KB3oz3jA== X-Google-Smtp-Source: AGHT+IFSZcI2vQpbzSHhDMPF2LKB1Vu/we5Q43H8Pa5hdUliwBEvSfJGRA02XPjhL1KbnCoICuSCOA== X-Received: by 2002:a05:620a:2943:b0:79f:18e5:f730 with SMTP id af79cd13be357-7a4e152c430mr331382385a.28.1723552294730; Tue, 13 Aug 2024 05:31:34 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d66093sm337126685a.12.2024.08.13.05.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 05:31:33 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 13 Aug 2024 12:31:28 +0000 Subject: [PATCH v6 08/10] media: venus: Refactor hfi_session_fill_buffer_pkt Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240813-cocci-flexarray-v6-8-de903fd8d988@chromium.org> References: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> In-Reply-To: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> To: Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The single data array data[1] is only used to save the extradata_size. Replace it with a single element field. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_cmds.h:175:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Reviewed-by: Bryan O'Donoghue Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.c | 2 +- drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/p= latform/qcom/venus/hfi_cmds.c index 0a4de8ca1df5..3ae063094e3e 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.c +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c @@ -331,7 +331,7 @@ int pkt_session_ftb(struct hfi_session_fill_buffer_pkt = *pkt, void *cookie, pkt->alloc_len =3D out_frame->alloc_len; pkt->filled_len =3D out_frame->filled_len; pkt->offset =3D out_frame->offset; - pkt->data[0] =3D out_frame->extradata_size; + pkt->data =3D out_frame->extradata_size; =20 return 0; } diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 615ac8d156a5..63b93a34f609 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -198,7 +198,7 @@ struct hfi_session_fill_buffer_pkt { u32 output_tag; u32 packet_buffer; u32 extradata_buffer; - u32 data[1]; + u32 data; }; =20 struct hfi_session_flush_pkt { --=20 2.46.0.76.ge559c4bf1a-goog From nobody Fri Dec 19 06:56:59 2025 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC22819D8AF for ; Tue, 13 Aug 2024 12:31:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552298; cv=none; b=DioPYaesS/hsG/2OSTDWWRcACGmv+S1bj/FFLX6I4X0CIT9fxBMTqW60Ijc5oCY4T64TxongbWgx8+iTm75QqHfRGUBmZtF5ZbdxZGkaFYO4+wZs7xWKm4G9EDaeUWjYhG0heKoig2Hdpl42zI7YuI9BGVERvxrusPtM/8Lj3hA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552298; c=relaxed/simple; bh=2G5axLdjt8/znqK8sczk5VikDq1NXPTZO4Dwxvg8Dbw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Kc8MD92s3qneyGSBvJa2M3WHknXEGGfOnDrOZeZbdfIW0T2ZiKkwQuEmwEQSw6Sfxes9wm4kHWGGpPP525odvvvOGVKlRFHqaXKcFXDjV/xwbuDOFZWj9O6fFZAqWIGqnq+9iGC7wdaIDcKkbFBEgC18m0zej5f8t4Vu09lebT0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=CiYd1YOO; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CiYd1YOO" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-7a1dac7f0b7so365895485a.0 for ; Tue, 13 Aug 2024 05:31:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723552296; x=1724157096; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0W5qW56HRdoH3DHUCwvvl2OkM1BfHpuAL0bk81ubPZo=; b=CiYd1YOO9tQ7fdL9U+iSBgtiixe0dx9zX+7eN2VCvqxWYCO6b4kSq1ZLnlXktkXF2h 786IJB6u4mqduFlFeK6CvWf7p6VM80+oQk1QR6d5SK7eQX2jIkE++24hKh+8xNuJDJSF ol8TF3Cf/MILeef9BoNjg2Eduf4UhvUv77QTk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723552296; x=1724157096; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0W5qW56HRdoH3DHUCwvvl2OkM1BfHpuAL0bk81ubPZo=; b=s1mWxI7PtVC+Q4Ghkpnep6sX0EyXwoLm/C3bkpM3QvmUoWxmU76qDJH64lYV/lznxf 8wRMvXRmDHQObEeY+GKyFYUPaR+3VU1ANODyNFcprBbRgFSOl9TL5CpdtIdIXvUAT7wh cvZbJ9anDN5WSw+CMXy+EFtwOj0ldOB3md8MBUJQ0STgi2SlAZNDaLhZWQa3FOVDv2Yy HcAZH53hHm97ZoFcJ45BriGyK/0I2ze8kJ03lvogkaTq+TBJe45e+WkU/s1goRhfFsrk FAl+fuwysup/M98tG3JZF4F4XiW0KzlVsLiuoHdJcwBTD1FQ9HLyLa7RVR4prTg7lSjo 2rQw== X-Forwarded-Encrypted: i=1; AJvYcCV2ZMGXMq99RSd/gWdh5KTmaDpcfN6I9fsENzNyeglYtTF42IcbTHWrmnJ3dL0yoRlW2hNCpzqPymiHUfDAw62/tvPZJpM5ijM73Te4 X-Gm-Message-State: AOJu0Yz60mfCTIqTtf2672nOnC0BgKsLoUqfrkIqf4JBonFmU7q+dS0x mXap0S8jjocke7aKTuSZmRLcsANRMeH5sfONTAw31z2IvSYfKnDnxSyuKvDxfUxLsZ0gwY4UgYU = X-Google-Smtp-Source: AGHT+IEpFFQrr7nGY9feezV5QErFzlaHGDASr5/SqGvMjPOvkfIPG/a5NQ6X8RFSpTboNcExdfbKhQ== X-Received: by 2002:a05:620a:2456:b0:7a2:ce2:5ae2 with SMTP id af79cd13be357-7a4e152cb17mr405801285a.17.1723552295658; Tue, 13 Aug 2024 05:31:35 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d66093sm337126685a.12.2024.08.13.05.31.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 05:31:35 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 13 Aug 2024 12:31:29 +0000 Subject: [PATCH v6 09/10] media: venus: Refactor hfi_buffer_alloc_mode_supported Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240813-cocci-flexarray-v6-9-de903fd8d988@chromium.org> References: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> In-Reply-To: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> To: Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 Replace the old style single element array at the end of the struct with a flex array. The code does not allocate this structure, so the size change should not be a problem. This fixes the following cocci warning: drivers/media/platform/qcom/venus/hfi_helper.h:1233:5-9: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) Acked-by: Vikash Garodia Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index 3edefa4edeb9..755aabcd8048 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -1264,7 +1264,7 @@ struct hfi_interlace_format_supported { struct hfi_buffer_alloc_mode_supported { u32 buffer_type; u32 num_entries; - u32 data[1]; + u32 data[]; }; =20 struct hfi_mb_error_map { --=20 2.46.0.76.ge559c4bf1a-goog From nobody Fri Dec 19 06:56:59 2025 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0C2D19DF52 for ; Tue, 13 Aug 2024 12:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552299; cv=none; b=bqjAeDUgYdWv3ueAY56nT1jO6VZzQST42bPCKXMtsmPKDJalAYQSxCjQVi+l2wxxQj2YW8E/uz0nWS8AjCcEdK69ld/YqeL4AigugozaKspYH563tGEzqbS9GTJa+viMGXkKsuY7dIjAtnKe3/Fhqr929xq8sROdGKjxo8ufX4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723552299; c=relaxed/simple; bh=+CaEvMFtp6+vW8dd+4vdYR7UCy2/V+0eTuF+Ay8On5w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U4geYZqU9sbrjg2S3HVDxr0863yCCYrWDwQpQD9B1+JrhgWOkMRCItiwnFCjQfRQ8WsvFnOULXOrJjfwiZQru1WlyrbbVdlmO9rwHp+iV/He/lX/tHY2jtg3+smR369QHYxARpYGG2tIla2SSJaUb6O7+qjiqm9w56uJ9GrsCXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=advjup4V; arc=none smtp.client-ip=209.85.161.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="advjup4V" Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5cdf7edddc5so2870042eaf.0 for ; Tue, 13 Aug 2024 05:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1723552297; x=1724157097; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GH6hs7TBxxS/YEw6+1SJGhyHiJvtnJuQXXY87tDn62g=; b=advjup4VBND4CuAVj8l9GuqzmubjR+lgB6UfV/S5B0v5UudhjHRGF7s6n0wQUa8we0 OaOjX4GMaqAZb07kFx1EhJF82JQmo1M6WhEzKfu2EMqrn9GMmJqfx2/5yow0b7qct6L5 Od5IOWWUHXWK0AjLTaC55JGDUjuN1bDo3Q5tQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723552297; x=1724157097; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GH6hs7TBxxS/YEw6+1SJGhyHiJvtnJuQXXY87tDn62g=; b=objcRVtdHRwANMzyK9J7n/YNy0SiKT+hwxt/PXvTXaLuV9/3AN4aTCxmRfh0PEspj0 qPYd0ZXT86iFUL/6bz1c8M23PCnBmQNuOS9ML5CK8ILBXBwxbGqrH4rONxdlF7cgu3WF s5zuj1074l5isQDiEmXVeuTGY0sAqo0JNUfeLaq87dIYGcbMuygRVj6QB6QAGT/yTihZ YYi+Kfow4848JLJLLf5FrXbqA/RWv1lWI10UF5mcR3qIk/uQZ9gds0M1EoFdnupUJvkA Hsas/ySdELeHyWzZeIpQdAzL7nrDrBRnVDRc6atXR9iNMqEfoEueAoRwNThN0fStHW7Q q4Xw== X-Forwarded-Encrypted: i=1; AJvYcCUBXHntMX9ntYPYnGL1ioDUsew25dN7TZ819aFqgG9zHUkERpzKTuOjFhaphvyd+X5vnlFWO88VpylhVlgfv74LNGggJ8OXphLatW65 X-Gm-Message-State: AOJu0YyONZ6DwLG/qc2g4l1/2ftEQocDvjqje1IZXt+sdTGoCtUG68YC 1zucrim5Nc3B+QUQF0IxGaw8hKpA4YBgnN0d3+QN7shDttYkQuVe+gm9i/lIMg== X-Google-Smtp-Source: AGHT+IHogC7GOQUcmfObrPNW1iILSP+KxRxv47DDOynRgsgLm33kY19LjuOqUoeUX6BYwlxMP62DDA== X-Received: by 2002:a05:6358:7e47:b0:1ac:66ef:a369 with SMTP id e5c5f4694b2df-1b19d2eb1e2mr402285655d.21.1723552296539; Tue, 13 Aug 2024 05:31:36 -0700 (PDT) Received: from denia.c.googlers.com (123.178.145.34.bc.googleusercontent.com. [34.145.178.123]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a4c7d66093sm337126685a.12.2024.08.13.05.31.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Aug 2024 05:31:35 -0700 (PDT) From: Ricardo Ribalda Date: Tue, 13 Aug 2024 12:31:30 +0000 Subject: [PATCH v6 10/10] media: venus: Convert one-element-arrays to flex-arrays Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240813-cocci-flexarray-v6-10-de903fd8d988@chromium.org> References: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> In-Reply-To: <20240813-cocci-flexarray-v6-0-de903fd8d988@chromium.org> To: Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 This structures are not used, and have a single element array at the end of them. This fix the following cocci warnings: drivers/media/platform/qcom/venus/hfi_helper.h:764:5-15: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1041:5-15: WARNING use flexi= ble-array member instead (https://www.kernel.org/doc/html/latest/process/de= precated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1088:39-51: WARNING use flex= ible-array member instead (https://www.kernel.org/doc/html/latest/process/d= eprecated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1093:5-22: WARNING use flexi= ble-array member instead (https://www.kernel.org/doc/html/latest/process/de= precated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1144:4-8: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1239:4-8: WARNING use flexib= le-array member instead (https://www.kernel.org/doc/html/latest/process/dep= recated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_helper.h:1272:4-13: WARNING use flexi= ble-array member instead (https://www.kernel.org/doc/html/latest/process/de= precated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:85:5-16: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:180:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) drivers/media/platform/qcom/venus/hfi_cmds.h:189:5-9: WARNING use flexible-= array member instead (https://www.kernel.org/doc/html/latest/process/deprec= ated.html#zero-length-and-one-element-arrays) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/hfi_cmds.h | 6 +++--- drivers/media/platform/qcom/venus/hfi_helper.h | 14 +++++++------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/p= latform/qcom/venus/hfi_cmds.h index 63b93a34f609..1cd1b5e2d056 100644 --- a/drivers/media/platform/qcom/venus/hfi_cmds.h +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h @@ -82,7 +82,7 @@ struct hfi_sys_set_buffers_pkt { u32 buffer_type; u32 buffer_size; u32 num_buffers; - u32 buffer_addr[1]; + u32 buffer_addr[]; }; =20 struct hfi_sys_ping_pkt { @@ -177,7 +177,7 @@ struct hfi_session_empty_buffer_uncompressed_plane1_pkt= { u32 filled_len; u32 offset; u32 packet_buffer2; - u32 data[1]; + u32 data; }; =20 struct hfi_session_empty_buffer_uncompressed_plane2_pkt { @@ -186,7 +186,7 @@ struct hfi_session_empty_buffer_uncompressed_plane2_pkt= { u32 filled_len; u32 offset; u32 packet_buffer3; - u32 data[1]; + u32 data; }; =20 struct hfi_session_fill_buffer_pkt { diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media= /platform/qcom/venus/hfi_helper.h index 755aabcd8048..f44059f19505 100644 --- a/drivers/media/platform/qcom/venus/hfi_helper.h +++ b/drivers/media/platform/qcom/venus/hfi_helper.h @@ -761,7 +761,7 @@ struct hfi_multi_stream_3x { =20 struct hfi_multi_view_format { u32 views; - u32 view_order[1]; + u32 view_order[]; }; =20 #define HFI_MULTI_SLICE_OFF 0x1 @@ -1038,7 +1038,7 @@ struct hfi_codec_supported { =20 struct hfi_properties_supported { u32 num_properties; - u32 properties[1]; + u32 properties[]; }; =20 struct hfi_max_sessions_supported { @@ -1085,12 +1085,12 @@ struct hfi_resource_ocmem_requirement { =20 struct hfi_resource_ocmem_requirement_info { u32 num_entries; - struct hfi_resource_ocmem_requirement requirements[1]; + struct hfi_resource_ocmem_requirement requirements[]; }; =20 struct hfi_property_sys_image_version_info_type { u32 string_size; - u8 str_image_version[1]; + u8 str_image_version[]; }; =20 struct hfi_codec_mask_supported { @@ -1141,7 +1141,7 @@ struct hfi_extradata_header { u32 port_index; u32 type; u32 data_size; - u8 data[1]; + u8 data[]; }; =20 struct hfi_batch_info { @@ -1236,7 +1236,7 @@ static inline void hfi_bufreq_set_count_min_host(stru= ct hfi_buffer_requirements =20 struct hfi_data_payload { u32 size; - u8 data[1]; + u8 data[]; }; =20 struct hfi_enable_picture { @@ -1269,7 +1269,7 @@ struct hfi_buffer_alloc_mode_supported { =20 struct hfi_mb_error_map { u32 error_map_size; - u8 error_map[1]; + u8 error_map[]; }; =20 struct hfi_metadata_pass_through { --=20 2.46.0.76.ge559c4bf1a-goog