From nobody Thu Dec 18 13:40:46 2025 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25CD219B595 for ; Mon, 12 Aug 2024 20:48:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723495688; cv=none; b=WfYa2VbrVMvvB2pqK1GsmMG8q0/30L0HvUddIfDQOHldJpv+assl7OSwtmFy9H4ZHcWDK6K5IY7tZImzRqDaI+T8zavmxxOctPyAkRHmPPCDoA6KPX8xk0mX9jcRF2vsUxUR09aTAm+AUaoMrIoI1Nz3qpFbEu7DvAI7L05btk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723495688; c=relaxed/simple; bh=eQpDTuk3ZSz6r9lF7a8nKcTsMzqFFfSknou6gI+gPWA=; h=Date:In-Reply-To:Message-Id:Mime-Version:References:Subject:From: To:Content-Type; b=uP5Ox68KlD6D2BtjhktFComN327HWscUrcd96sNFNjEiLmS7IKgWRnWn5b5RHQEjKJ3IqSF9rgM2jiYQ8e7K+a5h9+d0P5Vz9FsW3bYn7OTkScMwbCc9j7rRUIo9AA8pn8bpHM2SrcxyiLYRcYUK2s9o06sspRVMZHEatDPYcso= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=RMPbkid5; arc=none smtp.client-ip=209.85.219.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RMPbkid5" Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-e0b7922ed63so8809630276.0 for ; Mon, 12 Aug 2024 13:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723495686; x=1724100486; darn=vger.kernel.org; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=Kpr+cu9QRMpy3TlpvKDVPMxM+YZp/esLhrg70XBtQYY=; b=RMPbkid5ljpkEwqSaacXUStG+AiWBo+OoHmEA0gFHtgYmtl+2Jjh6oyYoAIHKamHU9 Z8SJ3dkrEp0vWHCCUD/ruEhzEb6FJe3SQVUBtcaM/hYMJSOEcpuSrjJ9SeidFV6rk/4e FcVFwFzEhKtpLLxDyRrc3flpCydTVUhnAm3o0f4FLcTJBJ/7psxdcoR0o9eeRQMbbU9S gsfsrxZ8Bj2pJG/BpjFNqUx+xNFW3+Sem+EyDa4XQ+I80Fw5W1nSy6GIBdVdeiAD3JRv cSO7dveMXCO7ltQkde4Tia1vcNW8RAY3Ae9sJcefWTR+Svp0yN2Yl5xA1dLo94kqKoX/ JBww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723495686; x=1724100486; h=to:from:subject:references:mime-version:message-id:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kpr+cu9QRMpy3TlpvKDVPMxM+YZp/esLhrg70XBtQYY=; b=QjLYrZFLhUGMGAco8Z/Jvm4jYHy3DxLayepnYsrmxCTsRiCG3GUBmB4sGFobC5o1xk Kxld4RxITFdjUuIUSG95E62mnD9C2IkkFtSw5LIIxi79eyXdV7IN0NXPpm980cNlMt+s gmZOCogib/rjz6E6BfFALE1JSia67XifcokTS3Bb3pbhsIRoniq6Q+Cmc5uUbbIuhRCQ dAAgIDLibv+hTV8w349iPB16RTZkJRfYGJ9I86gQHoiXcgsC4a89GDKEnq9uw87K24U1 d9jhF5ufpu9UIGYDTnCdeq2Wr781zy1t+RhVWaBxQP3RoRvQbTdKq6fJC1RSn4MKe7t+ 2NlQ== X-Forwarded-Encrypted: i=1; AJvYcCXhtswYSUQBhntFkvTq+UzPhnT6UCB6zNQWlXrOBAdcUIxBvpWylTCed9uxvsESvsDgU+qfsOURxZ47MZN0eaKwlxjlJhAkLKQe2BHV X-Gm-Message-State: AOJu0YzOSJzkA53MDiTiNI3rFs9MPCU5PwgBxWTMPTi9oHFtQmN4L1kS 3CLY14ede5qbclr6TWscLQ02e8iaZdi9lFXIyZ3LnLm6IB1pC6A2OhMOaFQmkwBXxuR4ZSFHAGl KbDwUdQ== X-Google-Smtp-Source: AGHT+IEbmaQbF7ylO1nyDJgivkzHHy3Dhc+dF+2T8SKBziKDX+/728BYpHWLDYabb5WwkODPfpNU22Bg1vcQ X-Received: from irogers.svl.corp.google.com ([2620:15c:2a3:200:e7f1:b90:720c:35bf]) (user=irogers job=sendgmr) by 2002:a25:abe9:0:b0:e03:5b06:6db2 with SMTP id 3f1490d57ef6-e113cd4619fmr2763276.3.1723495686242; Mon, 12 Aug 2024 13:48:06 -0700 (PDT) Date: Mon, 12 Aug 2024 13:47:10 -0700 In-Reply-To: <20240812204720.631678-1-irogers@google.com> Message-Id: <20240812204720.631678-19-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240812204720.631678-1-irogers@google.com> X-Mailer: git-send-email 2.46.0.76.ge559c4bf1a-goog Subject: [PATCH v7 18/27] perf sched: Use perf_tool__init From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Suzuki K Poulose , Yicong Yang , Jonathan Cameron , Nick Terrell , Nick Desaulniers , Oliver Upton , Anshuman Khandual , Song Liu , Ilkka Koskinen , Athira Rajeev , Huacai Chen , Yanteng Si , Sun Haiyong , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use perf_tool__init so that more uses of struct perf_tool can be const and not relying on perf_tool__fill_defaults. Signed-off-by: Ian Rogers --- tools/perf/builtin-sched.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c index 2c60bd3a8149..34fe8e540c43 100644 --- a/tools/perf/builtin-sched.c +++ b/tools/perf/builtin-sched.c @@ -3100,7 +3100,6 @@ static int perf_sched__timehist(struct perf_sched *sc= hed) sched->tool.tracing_data =3D perf_event__process_tracing_data; sched->tool.build_id =3D perf_event__process_build_id; =20 - sched->tool.ordered_events =3D true; sched->tool.ordering_requires_timestamps =3D true; =20 symbol_conf.use_callchain =3D sched->show_callchain; @@ -3605,14 +3604,6 @@ int cmd_sched(int argc, const char **argv) { static const char default_sort_order[] =3D "avg, max, switch, runtime"; struct perf_sched sched =3D { - .tool =3D { - .sample =3D perf_sched__process_tracepoint_sample, - .comm =3D perf_sched__process_comm, - .namespaces =3D perf_event__process_namespaces, - .lost =3D perf_event__process_lost, - .fork =3D perf_sched__process_fork_event, - .ordered_events =3D true, - }, .cmp_pid =3D LIST_HEAD_INIT(sched.cmp_pid), .sort_list =3D LIST_HEAD_INIT(sched.sort_list), .sort_order =3D default_sort_order, @@ -3733,6 +3724,13 @@ int cmd_sched(int argc, const char **argv) }; int ret; =20 + perf_tool__init(&sched.tool, /*ordered_events=3D*/true); + sched.tool.sample =3D perf_sched__process_tracepoint_sample; + sched.tool.comm =3D perf_sched__process_comm; + sched.tool.namespaces =3D perf_event__process_namespaces; + sched.tool.lost =3D perf_event__process_lost; + sched.tool.fork =3D perf_sched__process_fork_event; + argc =3D parse_options_subcommand(argc, argv, sched_options, sched_subcom= mands, sched_usage, PARSE_OPT_STOP_AT_NON_OPTION); if (!argc) --=20 2.46.0.76.ge559c4bf1a-goog