From nobody Mon Feb 9 01:43:19 2026 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A30A1197A62 for ; Fri, 9 Aug 2024 14:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723212968; cv=none; b=sBxBIS30y2z+LbrbVFMal3ssvFmEODkthyPZy9QtOUAmmVj7TH7jQPTQntyz0iLvfKGT7oih3YwqTakF2NBlt8bIfBkMjxZMN26MFBvgClOk9jj/Ofdc53D6VdWSVIRfVkV3Ucb89IsDwpXxjAeS/ZYXi/f/PvIYalnIU3Il22I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723212968; c=relaxed/simple; bh=i+8btDDh4eAP9SWK/QrveYXoOZhr9JkOlwFDq6hZ13U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eA5x+dqO+PdgIS6fDQUNTT6Wv5y5yK8NrxBhREllhnP5pBkBczn3NXo2OLDoVCYwNna5a9fLWHmsMP/yv0/wX923Y1pNJWYyw5mDbciR4FdSbQkaV2Dc0y/CES11JbIU4pO0s9mW82eHTIzq1w+NPG6Io25m+vdoQMUEiKue+yA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=JsvI8Y55; arc=none smtp.client-ip=209.85.208.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="JsvI8Y55" Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2f15dd0b489so26553891fa.3 for ; Fri, 09 Aug 2024 07:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1723212963; x=1723817763; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jw4ZuLFuVy5A0IKctkeTjrnq6fclS4FD7LJSylrulPM=; b=JsvI8Y55uxyDWBVnlzmj70P18OKqgLdDAdMHugOOVTP8aOkTV2Wl2Feh7vjvX7Uwax 8tE2ZK8W+MWf4uC1ZO891jWmeLPO/F8m5tCIZS1xK3SA9DQv7O3pO2F5Dy+z39hMxliQ u6YvrpBprK9n25Ut2RQoc5gKDu1TfQd70ujGrgFw+iF6t2PqtzB8jOg/ADCyall9P9kS m4Ge3/JFMrzfCdBv7n0uutBnoG14MXXk3T0NgZtIKzHQ++VXJDK8EYP0xjOeqKozP+5K NSdIKXFi2Hqc0kourbv1zqtDJmnQkkJLeqH5uLBYz8wOpwY0vGbgX5KOXsJxV/O7sqEy /jRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723212963; x=1723817763; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jw4ZuLFuVy5A0IKctkeTjrnq6fclS4FD7LJSylrulPM=; b=XSPZuEDTmCLz/EDygGDyA+K0HTNXQG53R+UvzWbS/+tO54GwT2RLw9jkHEhDcyr2jf 96phAKGkkwzSzMYI5NlVui7i7yhUz78uK4OVSheVKERiMWhVxfzuCPWW57+nZIm5anHz Q49vuxedpDymkUxVi/iXo4OgAuQeJzX/bLmiOaOPm/cTpTDiglUi5NvzNSfmnTYYImdl aa5o43uvrLRiZQSGNvjgyg5923LLWRoz2qpi9elsUvWrpH/t52b9/wnpK50aJZngEPVL PAX7F3UfXZCo1qa++IbOM8wzFPlOdBTm7CiTLuulh7QTkUa46lBUD7QHXyZAbiW6XTMM 1HzA== X-Gm-Message-State: AOJu0YyA1NB3qWwDgXJAlY6kYHjzYca0aTRrSFKcS7zj4JkzGFQsuRju 4J1sxc7sOqrmtVdvwvI+M69pM0rkdgN+JHlnMTux9KwviPcGpq54FnsEZ7mhudClAlfE1EuMs6H XRgU= X-Google-Smtp-Source: AGHT+IGSWBqiDzqWNZ16J6q2xOQFHIW/0cm+Wng43GKPXHyaq5g5Ofcwe7rozGe3QCXi21w1t4YbuQ== X-Received: by 2002:a2e:a581:0:b0:2ec:500c:b2e0 with SMTP id 38308e7fff4ca-2f1a6d1d1e9mr16504981fa.22.1723212962223; Fri, 09 Aug 2024 07:16:02 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8289:d6d0:e805:3543]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4290598e049sm130484035e9.23.2024.08.09.07.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 07:16:01 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 09 Aug 2024 16:15:54 +0200 Subject: [PATCH 1/3] memory: ti-aemif: remove platform data support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240809-ti-aemif-v1-1-27b1e5001390@linaro.org> References: <20240809-ti-aemif-v1-0-27b1e5001390@linaro.org> In-Reply-To: <20240809-ti-aemif-v1-0-27b1e5001390@linaro.org> To: Santosh Shilimkar , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4154; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=cpSevJ2ayz1pxZPzQQW6QFuyfNJMjPqSMprWbgtPFNo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBmtiSgMqu6sE1r9IF+kEXBQ4R9OlsWgdltF2P41 j5m/rhZLXWJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZrYkoAAKCRARpy6gFHHX cqWpD/4oV1G8yMje0xaFGMm9dYihYXoH0q8ITVxJYLeGCNIG6x1FTXM8qEfb8ppmRV2gADAWz7L i+BQQvDmJRiL7hgoQ/JbC+GuCfdPROHGYWOJNyX9+63mQ3uaiXW0I13ai0vuQFo/LpLKs6+5an/ QX7x1TSLXOlJJbgwfPg5M8Hth0Wzl9wK9N6gPNPWJ/5YzHOCsNwdgcsnuhTbfcUWgcjDwnOfXhF 3NMq4D7tY2tpyMX890Z8rs+Tlq6CSRoVFyw47/7pRVC7PRb9AgFHIDnu13fnQLA8vgul1OzRs9I FvcT8ycbAt62KQthjFWZR1F/Vr4kiiROkZsg6cdnZn2CLAiQjfMo9i2xninBQUzITFvwyl7NLoF F7/7pgKdiNxaA5eg6ioWaU/CfctrccAD5rK4T/x3Bct9ZxqKVXOB7/TJRHZOgx/QPC1BQw7bp+E ah39POPT+RjKUwP37RNY3zy21YucEvksOns6Ojmv7z2HzPvlDkbe7CVkBGWVq0c1E4hU2RSlwc0 QeT7LXIy0bytVVYtIkt3eddIAiRlWMdoy/3rWTjC0umnazsIM4kFFeuOXY4PxPwR7/uYYD/CAV9 nob17tgJPGpBvbkYtlT1URxTGkBErOxIQjnlvokya0Pni2FtYQre4jO+14WSq15vDAO+Z8Uh2IW hEDgqh9hdlqQZTQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski There are no longer any users of the ti-aemif driver that set up platform data from board files. We can shrink the driver by removing support for it. Signed-off-by: Bartosz Golaszewski --- drivers/memory/ti-aemif.c | 25 +------------------ include/linux/platform_data/ti-aemif.h | 45 ------------------------------= ---- 2 files changed, 1 insertion(+), 69 deletions(-) diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c index e192db9e0e4b..b92cab455cbb 100644 --- a/drivers/memory/ti-aemif.c +++ b/drivers/memory/ti-aemif.c @@ -17,7 +17,6 @@ #include #include #include -#include =20 #define TA_SHIFT 2 #define RHOLD_SHIFT 4 @@ -332,16 +331,11 @@ static int aemif_probe(struct platform_device *pdev) struct device_node *np =3D dev->of_node; struct device_node *child_np; struct aemif_device *aemif; - struct aemif_platform_data *pdata; - struct of_dev_auxdata *dev_lookup; =20 aemif =3D devm_kzalloc(dev, sizeof(*aemif), GFP_KERNEL); if (!aemif) return -ENOMEM; =20 - pdata =3D dev_get_platdata(&pdev->dev); - dev_lookup =3D pdata ? pdata->dev_lookup : NULL; - platform_set_drvdata(pdev, aemif); =20 aemif->clk =3D devm_clk_get(dev, NULL); @@ -358,8 +352,6 @@ static int aemif_probe(struct platform_device *pdev) =20 if (np && of_device_is_compatible(np, "ti,da850-aemif")) aemif->cs_offset =3D 2; - else if (pdata) - aemif->cs_offset =3D pdata->cs_offset; =20 aemif->base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(aemif->base)) { @@ -381,11 +373,6 @@ static int aemif_probe(struct platform_device *pdev) goto error; } } - } else if (pdata && pdata->num_abus_data > 0) { - for (i =3D 0; i < pdata->num_abus_data; i++, aemif->num_cs++) { - aemif->cs_data[i].cs =3D pdata->abus_data[i].cs; - aemif_get_hw_params(pdev, i); - } } =20 for (i =3D 0; i < aemif->num_cs; i++) { @@ -403,22 +390,12 @@ static int aemif_probe(struct platform_device *pdev) */ if (np) { for_each_available_child_of_node(np, child_np) { - ret =3D of_platform_populate(child_np, NULL, - dev_lookup, dev); + ret =3D of_platform_populate(child_np, NULL, NULL, dev); if (ret < 0) { of_node_put(child_np); goto error; } } - } else if (pdata) { - for (i =3D 0; i < pdata->num_sub_devices; i++) { - pdata->sub_devices[i].dev.parent =3D dev; - ret =3D platform_device_register(&pdata->sub_devices[i]); - if (ret) { - dev_warn(dev, "Error register sub device %s\n", - pdata->sub_devices[i].name); - } - } } =20 return 0; diff --git a/include/linux/platform_data/ti-aemif.h b/include/linux/platfor= m_data/ti-aemif.h deleted file mode 100644 index 77625251df07..000000000000 --- a/include/linux/platform_data/ti-aemif.h +++ /dev/null @@ -1,45 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* - * TI DaVinci AEMIF platform glue. - * - * Copyright (C) 2017 BayLibre SAS - * - * Author: - * Bartosz Golaszewski - */ - -#ifndef __TI_DAVINCI_AEMIF_DATA_H__ -#define __TI_DAVINCI_AEMIF_DATA_H__ - -#include - -/** - * struct aemif_abus_data - Async bus configuration parameters. - * - * @cs - Chip-select number. - */ -struct aemif_abus_data { - u32 cs; -}; - -/** - * struct aemif_platform_data - Data to set up the TI aemif driver. - * - * @dev_lookup: of_dev_auxdata passed to of_platform_populate() for aemif - * subdevices. - * @cs_offset: Lowest allowed chip-select number. - * @abus_data: Array of async bus configuration entries. - * @num_abus_data: Number of abus entries. - * @sub_devices: Array of platform subdevices. - * @num_sub_devices: Number of subdevices. - */ -struct aemif_platform_data { - struct of_dev_auxdata *dev_lookup; - u32 cs_offset; - struct aemif_abus_data *abus_data; - size_t num_abus_data; - struct platform_device *sub_devices; - size_t num_sub_devices; -}; - -#endif /* __TI_DAVINCI_AEMIF_DATA_H__ */ --=20 2.43.0 From nobody Mon Feb 9 01:43:19 2026 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA51D197A65 for ; Fri, 9 Aug 2024 14:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723212968; cv=none; b=JCQ1ZyaiX3BBxOuQkcg2svdSPblzaf6OS3tEWLdJLGsZMHiG5Dz976J34v9QhROYeOkL79wqPqAVsn1HA2KXDS6XiMijCjOuEcXcsQ4kGqlSzYvDWSf3seK+Qe0R6L1M+9KOdtLb2XIUnI26yJI7vEhfbbjnal2HSqc/G6iZnvs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723212968; c=relaxed/simple; bh=si420KfCAbUwj7Tl7OeH9FIMAx1kEhyq0ushc0tBMas=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=laIiFjoWwf14fFkG22m3iltvav8Bnhh3xof2a3jL39yNQ3cbxF5aassRlon7gdl36NX3VgSwEmabFN10Hi0bCP2TpRfnC26H11Bj7nw5wZtOXpHXqfAAfrPfkzH4L67g8Q3noUz9ZiaRAvR8nOhjvvVafeQxsGHVa1JnnOkNmgY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=lrzxzqAF; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="lrzxzqAF" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2f15e48f35bso21370981fa.0 for ; Fri, 09 Aug 2024 07:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1723212963; x=1723817763; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=DuEBO4wKbN1vPlCMZPv1/VInONtPQvpG32vpeJJnsnw=; b=lrzxzqAFBZ4Z5iAz72nTvPLaSTMo3McM57G+4F+drQsZt9Lu+6qJLmBk7UGJBkwJU9 vAzUetucm9YkPfdY1tHdDbMYTiPCHNcTbQAis3Ug2lcMQcTAzaxjZVVH7LWLUf6FarTU D6zRMMqt3mD+ewcDBSnUtvhiuzfv/s8iLTI9ekjO26suSxmVHjeYvugOqKC7g4/96DEf eg/9+c5FhPKjTXaKgP9mkOGJCLui7aH+CjWmWZFpCKuO0Ui4jZz6qdwN6iTEQvpFtPWb +apLnUSH6qM42kRwVQSeuMAcVxKZR20bYKIUY46UNn5CdXYo9keRHW9gdXvrKbFK/GSB NFgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723212963; x=1723817763; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DuEBO4wKbN1vPlCMZPv1/VInONtPQvpG32vpeJJnsnw=; b=MQU1FPZi9PRB3zML+oqkcaeKI0FUONheNSxniW/cn3a4odNS5u6U6t/39cNARY+eSq IJsvpWg5gLXuajWXbLdpYi4zNsfTsviDhEp0VawdYDp/NJXVWRqvrMn6dnsxRLKswt7L qJUGcEE3Ie7X5ejzNAlkN1ab2sMgT3SBFBiMxJRar5PkQ5oEH5uFqbHsRONrPp91AT4S pCiVOCI4Za794K3gP62CAhTRFwqckOlYbBZTemSj/2uecRdBAhnjkOO+nsz/WK85qHHf XeOWrIc1OqN3/N7u5nrh4i9qVVejLB+wegr2krQMyhiC5v1z5bZbP/Vvnd82x544Ji5o jMHA== X-Gm-Message-State: AOJu0Yz6leWiMgQW0Ep4WxXM5ohjLkmnhDYRXxRDf2ETC98L8PvLvYBi IQEX1hIRc3WAEnSoYMpmgyrb6UIeBHX2gFXbJuwx6692U6JEnuDnYCRVRD40W0M9D/GaXDhUcqj O8lY= X-Google-Smtp-Source: AGHT+IHVxYZTB3+5C/bLdwl8tmgK2qdlEhZuk6zmXr9zkNR1b9s7hNzCSmnIVjdrgk9ya98wdxofAQ== X-Received: by 2002:a2e:6101:0:b0:2f0:198e:cf86 with SMTP id 38308e7fff4ca-2f1a6d58063mr13387381fa.33.1723212962857; Fri, 09 Aug 2024 07:16:02 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8289:d6d0:e805:3543]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4290598e049sm130484035e9.23.2024.08.09.07.16.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 07:16:02 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 09 Aug 2024 16:15:55 +0200 Subject: [PATCH 2/3] memory: ti-aemif: use devm_clk_get_enabled() and shrink the code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240809-ti-aemif-v1-2-27b1e5001390@linaro.org> References: <20240809-ti-aemif-v1-0-27b1e5001390@linaro.org> In-Reply-To: <20240809-ti-aemif-v1-0-27b1e5001390@linaro.org> To: Santosh Shilimkar , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2490; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=QLCOikcdb83kfBUsdtAVnu7nuom9wFaV6X9ZQKuXYVg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBmtiSgMppcNGIE0Wpw0P2Ejq6cXxo2JMWS1m8+X rXRS5dJ4k+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZrYkoAAKCRARpy6gFHHX cnxUEADL7a37jKreuJKSkNeGmkGxP6NSiJXUjqFFgOIEBNBc3LDde9fg4rpdd8f3Am2ELrahJDk f69Y1FvkBuGz+ziXUXnKGp4n6OF92iLgjj68Uzna36bFtg9Oz4nt1PmUHuOlj4iADLpOHCFtUNm E2U2RhPesW0N5mYY209bdJ/OkqfU38dJC0OyNRoqp1lmobgeFE7VsTq8XX0yJjODbO5r9s3w0gO 7oLwA6JG4x5KRQuK8LzJ5kd2Th3fCtdkQflJy0+cVms37ned0hEC0ppyjafQSpTOMIqNjawZW03 GhXrGf7L9KVPyupQC0+jcCHt8AanX+HJifhRgFOFw07sxpKLVIvkJNubxuSbkIX2dn6La9jObf8 2FJTlKHx48WYfwe/p3WHvR3/K7PjQ68Z+ZIB4O9ZsJxBCYQ87FZyn7FNHqHeJe1KmydjWpOw3aq fcBE4szjMDFfNcMEPOxBAwyJAPf8w6If8GzrYGzA4TW1BkaCa7AGsrtpa5a7j5GFClaidslEtJR e+3HL739Ml1zNqukuq2Tq9hdfcYNeM6hLDXZM7hRj27LYGSBZflq1fkqNJ4FgagHWTh3cQLuSBD El+TaSH31FvVY5iT+jkZQS7mZlm/3JpJ2rtq6gGRkWzbUEy5Gdxu/tAKsPI1zm5CJklLk7DoNe6 PzzEmLCNMWVkMfA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Remove several lines of code and a jump label by using the managed variant of clk_get() that also prepares and enables the clock (and disables and unprepares it on driver detach). Signed-off-by: Bartosz Golaszewski --- drivers/memory/ti-aemif.c | 29 ++++++----------------------- 1 file changed, 6 insertions(+), 23 deletions(-) diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c index b92cab455cbb..fbe0786f5ac4 100644 --- a/drivers/memory/ti-aemif.c +++ b/drivers/memory/ti-aemif.c @@ -338,26 +338,20 @@ static int aemif_probe(struct platform_device *pdev) =20 platform_set_drvdata(pdev, aemif); =20 - aemif->clk =3D devm_clk_get(dev, NULL); + aemif->clk =3D devm_clk_get_enabled(dev, NULL); if (IS_ERR(aemif->clk)) { dev_err(dev, "cannot get clock 'aemif'\n"); return PTR_ERR(aemif->clk); } =20 - ret =3D clk_prepare_enable(aemif->clk); - if (ret) - return ret; - aemif->clk_rate =3D clk_get_rate(aemif->clk) / MSEC_PER_SEC; =20 if (np && of_device_is_compatible(np, "ti,da850-aemif")) aemif->cs_offset =3D 2; =20 aemif->base =3D devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(aemif->base)) { - ret =3D PTR_ERR(aemif->base); - goto error; - } + if (IS_ERR(aemif->base)) + return PTR_ERR(aemif->base); =20 if (np) { /* @@ -370,7 +364,7 @@ static int aemif_probe(struct platform_device *pdev) ret =3D of_aemif_parse_abus_config(pdev, child_np); if (ret < 0) { of_node_put(child_np); - goto error; + return ret; } } } @@ -380,7 +374,7 @@ static int aemif_probe(struct platform_device *pdev) if (ret < 0) { dev_err(dev, "Error configuring chip select %d\n", aemif->cs_data[i].cs); - goto error; + return ret; } } =20 @@ -393,27 +387,16 @@ static int aemif_probe(struct platform_device *pdev) ret =3D of_platform_populate(child_np, NULL, NULL, dev); if (ret < 0) { of_node_put(child_np); - goto error; + return ret; } } } =20 return 0; -error: - clk_disable_unprepare(aemif->clk); - return ret; -} - -static void aemif_remove(struct platform_device *pdev) -{ - struct aemif_device *aemif =3D platform_get_drvdata(pdev); - - clk_disable_unprepare(aemif->clk); } =20 static struct platform_driver aemif_driver =3D { .probe =3D aemif_probe, - .remove_new =3D aemif_remove, .driver =3D { .name =3D "ti-aemif", .of_match_table =3D of_match_ptr(aemif_of_match), --=20 2.43.0 From nobody Mon Feb 9 01:43:19 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97BDE197A66 for ; Fri, 9 Aug 2024 14:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723212969; cv=none; b=PKcn8/Of86Y4Fajci+ozc5/cNpLvbJ2NCW8R+zlK+hmBFN0XeRAIQCHWoxE0A5wBU6t/5CwYf44+i9JWnnwz5I6/rmn2dwQ8RTD0T2zNxQBOlbWc4kFnWsP9qR2JzKZ6ktXPffKRu9wDm33joBw6x9ZNca4LfoRG4XezCN9Y3fg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723212969; c=relaxed/simple; bh=ggvDZFDXx83aRXKsYxtw5YjUyKbrE+InX+rEpXnx5R4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ungsEjUavRpGKiyKUPSii72R0uOClWdFr11W3aG0RV9kp7Ut50i2sQrvGX+b28TkEjy8O8FPHqmtVY9GSAcppRX1Tj/EVGc4IX+KGHN32+Toqoe+kLvv8dSKxiSQnf3TRgU4veHyTlaDFry8RLHkNOIuxzzi7xH5hSJWGcZ2Vj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=lFJeMQ7d; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="lFJeMQ7d" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4281d812d3eso20300915e9.3 for ; Fri, 09 Aug 2024 07:16:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1723212965; x=1723817765; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aQPGc9dApofQX7O8RmOj4WWUlonbWJviZjIvwMVzuhs=; b=lFJeMQ7dMoo7RSy4HTUwgVIkiXAljXEySmbDBK+GjSe8oLl0raiA179UL4pqwismut S2MYXfzIHAb3sPEcbiVurZ4WxCvJ5UskOCUogp6a58Y6t6zp6yN8uOQof89GagrIj6ta Rtr+83kQJgX3GeuC+lpRg6oawhVarEpw0G/LbUGlmVh8TpiNl/zFAweEYEebS+dCc+Xj 8NU7/KqKgAXRBSXBi915tY7zhNexSr//1OUsSSMsa8M6OxgsLdGW25H5OlIZh2ccR1Tv leph/C/u4R/miDMbGGmSSH8B0rFDfS+uzfulPfwoClglJyUN/DSPYMBTTF9Y3GqH4Tpf CfVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723212965; x=1723817765; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aQPGc9dApofQX7O8RmOj4WWUlonbWJviZjIvwMVzuhs=; b=AjdiMNelQYW7W9sK9OkyiSfS8TZfAkAyH7CdMyi4MHtorzxA2F3Jj+lVHVtXGBC/eH WDdqW2mnaI5oX7u7b7E9ys45x+XBmWmj/VaxZFmhuxhXQwYOj4eJN+qWTu/lPJryE9HK a7duIylx+ZDGAfZ45xAHGndmZ5DOQb0afq69+iubuakLCOBNTx5d6OOOwuPkmorIP3/b 96Qzy3vajSv4gslgXrhAF4AkFsHoAbiBEdJ9gzdlbTnWbnESZ2nCfCamDMMhJ5NKXjAg kBOVJqeyAveMPcZTt0zPSSmQCjhu5cOyVf03sAen7sPfURrUtzOG0k6fEuVKh7WBiTL5 LVVA== X-Gm-Message-State: AOJu0Yzt7qSYCkRumWny/7YMvwDxbsiqqtXUs8WxSQbobLB+ar7tBc/9 hXVaKKTvGMmU2spKPT4Lm6quJ0W0zHc0aUYzvEsv5Zf5Kr01UmpDb21pst/Ft4E= X-Google-Smtp-Source: AGHT+IFKIaWHWbci8QZZ2n7KZHpTQJTq8X3FH+0s4WBET5a0XwLzcQi1C+W6ZdH57q8gpmX6bD+Krg== X-Received: by 2002:a05:600c:4fc5:b0:426:6e9a:7a1e with SMTP id 5b1f17b1804b1-429c3a5e344mr15355045e9.35.1723212964533; Fri, 09 Aug 2024 07:16:04 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8289:d6d0:e805:3543]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4290598e049sm130484035e9.23.2024.08.09.07.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Aug 2024 07:16:03 -0700 (PDT) From: Bartosz Golaszewski Date: Fri, 09 Aug 2024 16:15:56 +0200 Subject: [PATCH 3/3] memory: ti-aemif: don't needlessly iterate over child nodes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240809-ti-aemif-v1-3-27b1e5001390@linaro.org> References: <20240809-ti-aemif-v1-0-27b1e5001390@linaro.org> In-Reply-To: <20240809-ti-aemif-v1-0-27b1e5001390@linaro.org> To: Santosh Shilimkar , Krzysztof Kozlowski Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1096; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=h+HcmdehTG8k81RElf2GAXaNvmMSoYgOir/34Z+arm8=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBmtiSgdkIpM4AoEgSTv8HPmcLl+BNouFixeSXAX 2ah96dBZbqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZrYkoAAKCRARpy6gFHHX cqlND/4liOOlmWJvu4c9vkoCDLr1Bdq2rDoYgv0evZd/ewiz29r1VQxGS77NBbmccQk6oLXSxjE q4VBQU3BKbvC6oR6NaTlljHr884SiMq8UVUXpo5+wL1Z0MVKY/nvCQ3MCvuJEENHG5xV6Ab1Sqc 9F+RFi8KiVZsdAVCCV4hnjOWlhS8YAwfJXevn4E86GZdT9zTuUL+6y6NUNSM+V+6Yp3fM2IeY7j B3Nqy2cAmSbHtvHK27DagcHJWEWLANpvyWbp3TnMvkes7opptbs28s36WwmkHxvp7NDuDDmA256 jq+DLPkvEQkxrB/HiTUPG3mB9YyEPvmECAMNPKcALjwBbAfIlG/Aq7F/8H1PeKfgRSMN/IaZBNt Q2D0SB3pThurmVBftLyXVnaTgE7Tvd26m3xxJ24ztyow365i3UJ7JwvQrI3i0RYxFWrg0afU1uB JCdsJnmSwMvn0Mf33rx3+VX+7e+uqmXU3U+ZSUIlYA1UKKn3Nahyp2LbOL3LErC3bU2KF2xmHZK gjKc2q02UXHB0dyL+dIpdsckpsL5r4TAp5mRdM8IeQToGW7jot/a8KT5TiLbKfYtAq3vnoZR3uD fz7xgPdY2dmCGe9D8BZ56YiNzHW1jWhVPCUsUtM0Jj5o1Ug8suev10RA6T7TYLG1zbMS9lwq7u3 s/PMowrQTmCrpkw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski When populating devices from a specific node, we don't need to call of_platform_populate() for every child node manually - the routine will already do it. We can call it directly from the platform device's OF node. While at it: use the managed variant of of_platform_populate(). Signed-off-by: Bartosz Golaszewski --- drivers/memory/ti-aemif.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c index fbe0786f5ac4..49e7cbe98fdb 100644 --- a/drivers/memory/ti-aemif.c +++ b/drivers/memory/ti-aemif.c @@ -383,13 +383,9 @@ static int aemif_probe(struct platform_device *pdev) * child will be probed after the AEMIF timing parameters are set. */ if (np) { - for_each_available_child_of_node(np, child_np) { - ret =3D of_platform_populate(child_np, NULL, NULL, dev); - if (ret < 0) { - of_node_put(child_np); - return ret; - } - } + ret =3D devm_of_platform_populate(dev); + if (ret) + return ret; } =20 return 0; --=20 2.43.0