From nobody Mon Feb 9 03:35:20 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD12618DF83; Thu, 8 Aug 2024 10:36:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723113371; cv=none; b=FQ9BtLP0lFPpr8wzaIZt8KCLgf34qYOzzUhQsvt/iAb1lDPHCYOanUJCjDpPed78fXU4Em2F/3kCfJTdOfTyubMV2uikq2nV/t7eV7bTaQ0eCP7REdcnjdaiBFtPQrWjVKm0erYJ69zINfzA4hV9oHxxsfkTbNKrsvefQhFjjNs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723113371; c=relaxed/simple; bh=Y/kZ6pKUemi1ebXpTMHlyUEYKL9YeGqV57QiLnAlE98=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V7XcC7JPPNkX+h+z8nHvnkbOOts2AmMUXYjIbPCnqHkn1ekh+5exqtZanFf3U7QQ0ZbJTiP1GTve4Qbh4A2N4gZFEGVhFs6MHGqVuGRgUKUbvF/KmxgseRaNycPRAjUH10G/ajGIb2sG20FXx+yOki5r9Y5NF+wmooGWkIUoXqA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=It5DTZ7l; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="It5DTZ7l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4C7F2C4AF0D; Thu, 8 Aug 2024 10:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723113371; bh=Y/kZ6pKUemi1ebXpTMHlyUEYKL9YeGqV57QiLnAlE98=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=It5DTZ7l/sA5ueD/unBsBOvGe19RYLsCYi+EtQwfEWNjolcw6/KF8r0KHDJd7S+Ro ObKgy0j2U2OUvPYa2Hag9OSr4mpqjV6i39V/zaQTGH/sCfZA0Fje+JKMElUmWwKgQs MSsNFCtZzX7keFFx+FCh82H9SE41Kko/rZ3TPb3i1fk+vRzb9Yn3S16CuIdt8IRXWa kvcIC4iVZ4J5x2sV4yZNBlva39jbLZjp2/V7hJy9o2iyXhhV2A2TeKxroTzeOtWQ3R UEdGCHD9cNqu0iajGfKB6XI6Fz0xEqLHg5tHazqlq7e7o3rSp0lOSjNoFxznEND7rY xkKAC1+LcBi8w== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Andreas Koensgen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-hams@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 08/11] 6pack: drop sixpack::mtu Date: Thu, 8 Aug 2024 12:35:44 +0200 Message-ID: <20240808103549.429349-9-jirislaby@kernel.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240808103549.429349-1-jirislaby@kernel.org> References: <20240808103549.429349-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It holds a constant (AX25_MTU + 73), so use that constant in place of the single use directly. And remove the stale comment. Signed-off-by: Jiri Slaby (SUSE) Cc: Greg Kroah-Hartman Cc: Andreas Koensgen Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: linux-hams@vger.kernel.org Cc: netdev@vger.kernel.org --- drivers/net/hamradio/6pack.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c index 29906901a734..f8235b1b60e9 100644 --- a/drivers/net/hamradio/6pack.c +++ b/drivers/net/hamradio/6pack.c @@ -100,7 +100,6 @@ struct sixpack { unsigned int rx_count_cooked; spinlock_t rxlock; =20 - int mtu; /* Our mtu (to spot changes!) */ int buffsize; /* Max buffers sizes */ =20 unsigned long flags; /* Flag values/ mode etc */ @@ -166,7 +165,7 @@ static void sp_encaps(struct sixpack *sp, unsigned char= *icp, int len) unsigned char *msg, *p =3D icp; int actual, count; =20 - if (len > sp->mtu) { /* sp->mtu =3D AX25_MTU =3D max. PACLEN =3D 256 */ + if (len > AX25_MTU + 73) { msg =3D "oversized transmit packet!"; goto out_drop; } @@ -585,7 +584,6 @@ static int sixpack_open(struct tty_struct *tty) =20 sp->xbuff =3D xbuff; =20 - sp->mtu =3D AX25_MTU + 73; sp->buffsize =3D len; sp->rcount =3D 0; sp->rx_count =3D 0; --=20 2.46.0