From nobody Fri Dec 19 17:18:09 2025 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B6B8287E for ; Wed, 7 Aug 2024 15:02:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723042963; cv=none; b=MP0murZbK+MB9uwcYgh7D8srJMkZML6GvM+yiQBpq8/fkZlw9kn6Nmmb0zHWzza1+x9As/HkNyHZf6M02RMxbYTf6Ww0Ehj4lXrAQ0CUZimUYMumHoJ3IH21RSRi7+0BeIF/AR9aC9R5Vz5h7ANT6QXnsp5WcznUjlAPT+4nA0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723042963; c=relaxed/simple; bh=7UDfwJmrMLWgAadMr/nmIe/06eQrWV7hakK6EjfMO1k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hkcsxXGMx9ltlg365o3UrEXvGd9hqaWZdFUFor6VBw65K6tFQCiFpu1ZN3M2O8KJls6QLNlJYdqJmUWri8eZJq9AknNk6OaS18Wgpnpc5+Ja9UvHdwmhGQMgRkVEt/h/8yOHnDACuPIxSWj/DUBKQtS+6zTNyXZI5QU5IhSrhqg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AH2+l3A6; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AH2+l3A6" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5bb85e90ad5so1858003a12.3 for ; Wed, 07 Aug 2024 08:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723042959; x=1723647759; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GOZ9eu7KzFM6ThSYO7rTFdAab7Vy2Og8cSyaXW3jcO4=; b=AH2+l3A6C+2EJMkRvwSfM7aZ6WdxCPhm7Ym6bwQSvWmJCPKSqFuWXDF/0E5/zNUlZG iX59/EWAc2uq/tPgQAsb2rWnZxKwMfOWcA9NLssZg8gx/JiiFL5xe4dUfPysm6CpVLhj bHfLwEQjPfDqoKUrTBYFZkAnmmkfaVnplOThDIXK8+hG7L+M+k+CWSr+MWIIgr9iG6yS M53EChJR/s/9YlZpsiFaBtkQZSeb0bYUPla0tO1IbSF4AL2umwjhZZ6PEnDoQqdE0zIz EtDKvG35jAaPvACdGEVNmrNvvjPnd9W93He9ocqliPC7TBj6+1HA0JAUYJcc8pdnqVPL crug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723042959; x=1723647759; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GOZ9eu7KzFM6ThSYO7rTFdAab7Vy2Og8cSyaXW3jcO4=; b=NWrR/+wBGljxMMUBY8E03SZgm2miZWSLveI92QGeVO5Skbs7/OMvgV06KR6uyCQnW7 Rkf52aZWugnPkrBCjS2ttk0B3mnLybyuVej/NfOopkDs4qZEC5GDH3j094W3SLqoDuZp WfFN/dsMZC3nt51PXq2XIyaxOfBtYWEOujCMsiP5BDqJ3h2pGJ+al7/eZZun1F3GdnQU PoAcycYWYFLhxtMZXwbODxOLisqrxsvpJARQGLdJL4ccUk+rna1ab9nIj0AlMSivnjMp 2w9nIH7hrGuffct0WSAuELckaXDtWZxC3BDYUr6BgnUxxjxoZhFkNn9kD1a6t9KQfgyy nSmA== X-Forwarded-Encrypted: i=1; AJvYcCUOrjPvIEqPVeSHOcCvPlnHwqZJ3fKC/CzVxyRFuyfqtlSFue4C8YxXh1NgIAF2jqA1G+nsF4UypI9DmlwpaOkprG1mQamOYEHkkugJ X-Gm-Message-State: AOJu0YwDRymBxpVjiKzx5ARa7xao0ShWCfKi1kl5fU0JsZ7n3ZiajcYo fS9ka8PaWNDy46wUHeOai6h2RmADH03CCZ3ZLyARWFXEowuix348+JsE0aHoVw2GgZImGE72ydQ g X-Google-Smtp-Source: AGHT+IGzpq+YuuOIP2PFUJ3vNl0MEGcLj5O6pGV4HEUMI9rYt73RXdKBpR8FRW+FrH9d3cp16wWxwA== X-Received: by 2002:a05:6402:60f:b0:5a3:a9f8:cf20 with SMTP id 4fb4d7f45d1cf-5b7f58eb70dmr12836219a12.34.1723042958942; Wed, 07 Aug 2024 08:02:38 -0700 (PDT) Received: from lino.lan ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bb90be3a91sm2583047a12.65.2024.08.07.08.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 08:02:38 -0700 (PDT) From: Linus Walleij Date: Wed, 07 Aug 2024 17:02:32 +0200 Subject: [PATCH v2 1/3] ASoC: tas2781-i2c: Drop weird GPIO code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240807-asoc-tas-gpios-v2-1-bd0f2705d58b@linaro.org> References: <20240807-asoc-tas-gpios-v2-0-bd0f2705d58b@linaro.org> In-Reply-To: <20240807-asoc-tas-gpios-v2-0-bd0f2705d58b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shenghao Ding , Kevin Lu , Baojun Xu Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Shenghao Ding <13916275206@139.com>, alsa-devel@alsa-project.org, Linus Walleij X-Mailer: b4 0.14.0 The tas2781-i2c driver gets an IRQ from either ACPI or device tree, then proceeds to check if the IRQ has a corresponding GPIO and in case it does enforce the GPIO as input and set a label on it. This is abuse of the API: - First we cannot guarantee that the numberspaces of the GPIOs and the IRQs are the same, i.e that an IRQ number corresponds to a GPIO number like that. - Second, GPIO chips and IRQ chips should be treated as orthogonal APIs, the irqchip needs to ascertain that the backing GPIO line is set to input etc just using the irqchip. - Third it is using the legacy API which should not be used in new code yet this was added just a year ago. Delete the offending code. If this creates problems the GPIO and irqchip maintainers can help to fix the issues. It *should* not create any problems, because the irq isn't used anywhere in the driver, it's just obtained and then left unused. Fixes: ef3bcde75d06 ("ASoC: tas2781: Add tas2781 driver") Signed-off-by: Linus Walleij --- include/sound/tas2781.h | 7 +------ sound/pci/hda/tas2781_hda_i2c.c | 2 +- sound/soc/codecs/tas2781-comlib.c | 3 --- sound/soc/codecs/tas2781-fmwlib.c | 1 - sound/soc/codecs/tas2781-i2c.c | 24 +++--------------------- 5 files changed, 5 insertions(+), 32 deletions(-) diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h index 18161d02a96f..dbda552398b5 100644 --- a/include/sound/tas2781.h +++ b/include/sound/tas2781.h @@ -81,11 +81,6 @@ struct tasdevice { bool is_loaderr; }; =20 -struct tasdevice_irqinfo { - int irq_gpio; - int irq; -}; - struct calidata { unsigned char *data; unsigned long total_sz; @@ -93,7 +88,6 @@ struct calidata { =20 struct tasdevice_priv { struct tasdevice tasdevice[TASDEVICE_MAX_CHANNELS]; - struct tasdevice_irqinfo irq_info; struct tasdevice_rca rcabin; struct calidata cali_data; struct tasdevice_fw *fmw; @@ -115,6 +109,7 @@ struct tasdevice_priv { unsigned int chip_id; unsigned int sysclk; =20 + int irq; int cur_prog; int cur_conf; int fw_state; diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2= c.c index 49bd7097d892..8a7fe48043d2 100644 --- a/sound/pci/hda/tas2781_hda_i2c.c +++ b/sound/pci/hda/tas2781_hda_i2c.c @@ -814,7 +814,7 @@ static int tas2781_hda_i2c_probe(struct i2c_client *clt) } else return -ENODEV; =20 - tas_hda->priv->irq_info.irq =3D clt->irq; + tas_hda->priv->irq =3D clt->irq; ret =3D tas2781_read_acpi(tas_hda->priv, device_name); if (ret) return dev_err_probe(tas_hda->dev, ret, diff --git a/sound/soc/codecs/tas2781-comlib.c b/sound/soc/codecs/tas2781-c= omlib.c index 1fbf4560f5cc..28d8b4d7b985 100644 --- a/sound/soc/codecs/tas2781-comlib.c +++ b/sound/soc/codecs/tas2781-comlib.c @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include @@ -411,8 +410,6 @@ EXPORT_SYMBOL_GPL(tasdevice_dsp_remove); =20 void tasdevice_remove(struct tasdevice_priv *tas_priv) { - if (gpio_is_valid(tas_priv->irq_info.irq_gpio)) - gpio_free(tas_priv->irq_info.irq_gpio); mutex_destroy(&tas_priv->codec_lock); } EXPORT_SYMBOL_GPL(tasdevice_remove); diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-f= mwlib.c index 8f9a3ae7153e..f3a7605f0710 100644 --- a/sound/soc/codecs/tas2781-fmwlib.c +++ b/sound/soc/codecs/tas2781-fmwlib.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c index e79d613745b4..fdf0840ac6c7 100644 --- a/sound/soc/codecs/tas2781-i2c.c +++ b/sound/soc/codecs/tas2781-i2c.c @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include @@ -757,7 +756,7 @@ static void tasdevice_parse_dt(struct tasdevice_priv *t= as_priv) { struct i2c_client *client =3D (struct i2c_client *)tas_priv->client; unsigned int dev_addrs[TASDEVICE_MAX_CHANNELS]; - int rc, i, ndev =3D 0; + int i, ndev =3D 0; =20 if (tas_priv->isacpi) { ndev =3D device_property_read_u32_array(&client->dev, @@ -772,7 +771,7 @@ static void tasdevice_parse_dt(struct tasdevice_priv *t= as_priv) "ti,audio-slots", dev_addrs, ndev); } =20 - tas_priv->irq_info.irq_gpio =3D + tas_priv->irq =3D acpi_dev_gpio_irq_get(ACPI_COMPANION(&client->dev), 0); } else if (IS_ENABLED(CONFIG_OF)) { struct device_node *np =3D tas_priv->dev->of_node; @@ -784,7 +783,7 @@ static void tasdevice_parse_dt(struct tasdevice_priv *t= as_priv) dev_addrs[ndev++] =3D addr; } =20 - tas_priv->irq_info.irq_gpio =3D of_irq_get(np, 0); + tas_priv->irq =3D of_irq_get(np, 0); } else { ndev =3D 1; dev_addrs[0] =3D client->addr; @@ -800,23 +799,6 @@ static void tasdevice_parse_dt(struct tasdevice_priv *= tas_priv) __func__); =20 strcpy(tas_priv->dev_name, tasdevice_id[tas_priv->chip_id].name); - - if (gpio_is_valid(tas_priv->irq_info.irq_gpio)) { - rc =3D gpio_request(tas_priv->irq_info.irq_gpio, - "AUDEV-IRQ"); - if (!rc) { - gpio_direction_input( - tas_priv->irq_info.irq_gpio); - - tas_priv->irq_info.irq =3D - gpio_to_irq(tas_priv->irq_info.irq_gpio); - } else - dev_err(tas_priv->dev, "%s: GPIO %d request error\n", - __func__, tas_priv->irq_info.irq_gpio); - } else - dev_err(tas_priv->dev, - "Looking up irq-gpio property failed %d\n", - tas_priv->irq_info.irq_gpio); } =20 static int tasdevice_i2c_probe(struct i2c_client *i2c) --=20 2.45.2 From nobody Fri Dec 19 17:18:09 2025 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 302F484A5C for ; Wed, 7 Aug 2024 15:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723042966; cv=none; b=gg1x9b28uzhUmrBNGPdBkjjB2IQ0+EuQzWDRJQoKhYbmYCxBK43iT5gN3VYFfdmsHsKij7DUIAG0+CKVIvq+riDARlYtZYnRtMOT55RFrfcOhrQ5wYrj5n3GJ749+JYWTd3/gr88y8GOKkbkroQbMLPdTtyrYBJoSGIyjmf2+SE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723042966; c=relaxed/simple; bh=Y7W8wbrOkuNmZ8CQ0WcwZSJsXls2By5/tn0Y2KGbT34=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lHFjZibw/5CEXJLTOCFI5flMW5eoLefwdIUAnqMy+fK7sWGeWujPtlT54wT4JaeVIm2FbL/V0zZxxPT3GZbs9/Mwl3lBzXGFB/+thWIhZp0drXkeWnjJF4NockxD/xENQsNiJPVqjZN6qmQ64iEGI2Dd/gOx4JbsAjFN2WkPznY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GjM1C5kS; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GjM1C5kS" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5b3fff87e6bso2310305a12.0 for ; Wed, 07 Aug 2024 08:02:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723042962; x=1723647762; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WPaeIu/7/ToaPftt+nmZwaEM7lBvNV082estk80tIAQ=; b=GjM1C5kSf+SfapsFA4MuOL0unWnYAvVxP+sq96PLrXGdWi1i4JS+zA6nC8uyRJdZ6C zMh1xba5jQbFiDfKeBi4VxiqcnemXs3CBjNLfvvCKkMbNSOMAQcDp3t7iUB54XULDWJ3 TKzxaruJMd8h0yaIQFihOm7bzrNWZPso8x8wMEzNJcLHpKx5P5K2FZvcaEv0E4BTtQhm mLU6ouxmIbzKEXwRkMYUrJovKqq8euTsNfwswkuRcOVCrYyMCrtHaqg4dPbBl2J7gO+S pQDMCfd6Z/DH2kshXfGdwmPDD6+CQMwIuzSLuzWJyZmheT1V9sWUc4m0yvTvKGamC7/Q Q/ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723042962; x=1723647762; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WPaeIu/7/ToaPftt+nmZwaEM7lBvNV082estk80tIAQ=; b=upKA9A1tsxJWRbG/HBTFasWDsxdNANm3ZeWft/65wemSI6unOkPCrC4Ay9wx2mShbp BK+sVRrI6uUqaCysquaY+2+4hFo9GQpX8fz0YdrBG23hrCQQmm836ksUOUJLjfG8FSTD vmZjc1nAELmP0R4E5ankW3JP7EfFO6QAzkSkquPkWA2Gb1SJmRol/APpxWeHvMFxnHxa vSxpaUNKrIK6D6P5mtGBIuRLUN63bXZpjMYwk/ZhUVBsXpXgQiymjuLW8OCuKmGSs01Q wuX6z2QTNdc01SpU7YI4ZxqecaNLu7SPWjx17ceN6hlZY1lx24o0l/CU+DGNlj1rSBx5 ghNw== X-Forwarded-Encrypted: i=1; AJvYcCUbb/TMxHpSvAv4bUCnT64xBRycSVRVZa2Lf0Ik1QNfkayoTxyoiyqP6aF10gPrIstCSo215y5KbwTwOgKrp5DrjdhD3h59Y4TUJvJ4 X-Gm-Message-State: AOJu0YweoZhrLs22FUGC5nzAtNQwohNyM4Z21j/s7wJGwCu8xJDvvH15 Gyj3Wn7brwvUILgtDLVoqdowK4J6bICaJS7kDmw+0JS5zMEzlA2wgINnTC1Hq17grbpFyYblvyA f X-Google-Smtp-Source: AGHT+IEYpjjpJDMbHBEqI4Rw2M2UUag+5UjvthzgGzzeXam2hAGeCohE28/rAsaJU5XDD5v2iV+kRw== X-Received: by 2002:a05:6402:331:b0:5a2:2654:7fd1 with SMTP id 4fb4d7f45d1cf-5b7f59e04d9mr11178515a12.36.1723042961586; Wed, 07 Aug 2024 08:02:41 -0700 (PDT) Received: from lino.lan ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bb90be3a91sm2583047a12.65.2024.08.07.08.02.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 08:02:39 -0700 (PDT) From: Linus Walleij Date: Wed, 07 Aug 2024 17:02:33 +0200 Subject: [PATCH v2 2/3] ASoC: tas2781-i2c: Get the right GPIO line Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240807-asoc-tas-gpios-v2-2-bd0f2705d58b@linaro.org> References: <20240807-asoc-tas-gpios-v2-0-bd0f2705d58b@linaro.org> In-Reply-To: <20240807-asoc-tas-gpios-v2-0-bd0f2705d58b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shenghao Ding , Kevin Lu , Baojun Xu Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Shenghao Ding <13916275206@139.com>, alsa-devel@alsa-project.org, Linus Walleij X-Mailer: b4 0.14.0 The code is obtaining a GPIO reset using the reset GPIO name "reset-gpios", but the gpiolib is already adding the suffix "-gpios" to anything passed to this function and will be looking for "reset-gpios-gpios" which is most certainly not what the author desired. Fix it up. Fixes: ef3bcde75d06 ("ASoC: tas2781: Add tas2781 driver") Signed-off-by: Linus Walleij --- sound/soc/codecs/tas2781-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c index fdf0840ac6c7..bac5ea6d99b9 100644 --- a/sound/soc/codecs/tas2781-i2c.c +++ b/sound/soc/codecs/tas2781-i2c.c @@ -793,7 +793,7 @@ static void tasdevice_parse_dt(struct tasdevice_priv *t= as_priv) tas_priv->tasdevice[i].dev_addr =3D dev_addrs[i]; =20 tas_priv->reset =3D devm_gpiod_get_optional(&client->dev, - "reset-gpios", GPIOD_OUT_HIGH); + "reset", GPIOD_OUT_HIGH); if (IS_ERR(tas_priv->reset)) dev_err(tas_priv->dev, "%s Can't get reset GPIO\n", __func__); --=20 2.45.2 From nobody Fri Dec 19 17:18:09 2025 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C4798615A for ; Wed, 7 Aug 2024 15:02:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723042967; cv=none; b=bJuMVOR9GQ/N6N4CcB75DSTo3qIyMpd5Vma1ODqCidtsDHVKLMKLTlCLsGp92aCgy/ECtpoYwZFZid2Zk9psal/8VA4bsuwOt3cY3cOV99FhVNXXJXIH6gaIgl2sIbKcoGYbniHEF3wDXA8VQz5dELWG9Olynldza8SMMyqhUjU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723042967; c=relaxed/simple; bh=gD60QMy/QwxxGBLOYwPLMsMir9my6tspif2L4UDaxCo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HkKS5kJcktT2QJtEYjVfTHJIGQqLu2buFNltqRzWNL+n+FTe9tZxrBm/a8TkLPVpV3EqIvbiFn9AHWF9KNDiKjQow/0k5Xo1JesXFptG5YsKeSGGoHctvBsoVYdpsAGXrGrEemh18V1asuBe9W3zxfOuFEuK4/aW0P/nkWreJP8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=V3FwzrXB; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V3FwzrXB" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-58ef19aa69dso2066359a12.3 for ; Wed, 07 Aug 2024 08:02:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723042964; x=1723647764; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zb7lA4qnI7KpE11eMK8Td9pIdoQNK6RGZ1WWHf+hwpk=; b=V3FwzrXBnjaiasK9Ob9h2GAQIct1cF/wb9N4tT0DeGsDybdEV34fB8CoGqEpP5ObiU i1Ft0lqxmzLTQuRBX+Ar6e1EP8QfGCY6eJR9oY6iUrJQ5C+enREUTU201gzIYSyO5pDz X6pSM2sVi/D2Nbt2KYy429MgV3lAP3eRQB5D13Dzdt/Dgf4ccqX0nAqbwvuqT7yMB27P JQjWsOM9AVhzdrCmc8V6iGLhTnLlWbnUkKCRARvX59FeP5HfLPQCCbac30kPTfxfvIwU qs5U/YvY7qWfkNHeMsbAJEhfKwvxDtbHYutR/17C1Jx4UDTxbHAobMk9PhBpexiddh5G nKcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723042964; x=1723647764; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zb7lA4qnI7KpE11eMK8Td9pIdoQNK6RGZ1WWHf+hwpk=; b=eSdMU4A+IZ4L1H4JKZsz7WROU1FCAHiEauY0A0odkOP+wDL68wz7Ti3pZGHZ0WmJ57 leYaRK0TP3Tw5ASkH20Mo0k7yHzPdw6Mgyw14qW0H+/e1SIzPmbRvCw9ejiZbzNUmoKU QGVy54pt5LqlcMwgmR2mS+zDN8DM6/0Vv9Rwkoiv98RSsCm1a9PRlJ2ITX50yHkbvylq PMkv8KZdMzKCKv5KJ2urX//3T3srfCaytXt7uJpiIREbE/sKbN6yOvaLHhNjnd+3hOpd SieRE+c/CztDWIUhmxH9Yu7caoQxQqkzw+ImVSqg8NWwA/GGGxLzy6gV4edT4oC2It+A TCoA== X-Forwarded-Encrypted: i=1; AJvYcCWBNiBQEHi+nSTa9Siy6rNm2laWS2WRFyHjPiSqkuBwOsyIoRJcWDkClC5/AB11ua+BtD1TjGtJlTfvsPJSox/RJWP4MnIQkBWB7m3T X-Gm-Message-State: AOJu0Yw/wAZUfm875OFur8RFi9A69lZZuvH8YCXwQcPx8Ua9z/u8rXyQ wcbdtGMcRxgBejOXzTWFtvDjsplk7JtuV0D+eO0thVka/vQNpTL5BTlknAiT6zXc1yqAdJsGkNn L X-Google-Smtp-Source: AGHT+IEBb/2tO0u0sDAp3dDW7mXSiJkZfOd7Vz4ANN2+MBZgge3MX1YpJhT2vVz4APXcj0lgtag8Kw== X-Received: by 2002:a05:6402:1a3c:b0:5a2:1f7b:dffa with SMTP id 4fb4d7f45d1cf-5b7f350462fmr13646143a12.3.1723042963968; Wed, 07 Aug 2024 08:02:43 -0700 (PDT) Received: from lino.lan ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5bb90be3a91sm2583047a12.65.2024.08.07.08.02.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 08:02:42 -0700 (PDT) From: Linus Walleij Date: Wed, 07 Aug 2024 17:02:34 +0200 Subject: [PATCH v2 3/3] ASoC: tas*: Drop unused GPIO includes Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240807-asoc-tas-gpios-v2-3-bd0f2705d58b@linaro.org> References: <20240807-asoc-tas-gpios-v2-0-bd0f2705d58b@linaro.org> In-Reply-To: <20240807-asoc-tas-gpios-v2-0-bd0f2705d58b@linaro.org> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shenghao Ding , Kevin Lu , Baojun Xu Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Shenghao Ding <13916275206@139.com>, alsa-devel@alsa-project.org, Linus Walleij X-Mailer: b4 0.14.0 These drivers all use and has no business including the legacy headers or . Drop the surplus includes. Signed-off-by: Linus Walleij --- sound/soc/codecs/tas2552.c | 1 - sound/soc/codecs/tas2764.c | 1 - sound/soc/codecs/tas2770.c | 1 - sound/soc/codecs/tas2780.c | 1 - 4 files changed, 4 deletions(-) diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c index 9e68afc09897..684d52ec6600 100644 --- a/sound/soc/codecs/tas2552.c +++ b/sound/soc/codecs/tas2552.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include diff --git a/sound/soc/codecs/tas2764.c b/sound/soc/codecs/tas2764.c index 5eaddf07aadc..d482cd194c08 100644 --- a/sound/soc/codecs/tas2764.c +++ b/sound/soc/codecs/tas2764.c @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include diff --git a/sound/soc/codecs/tas2770.c b/sound/soc/codecs/tas2770.c index 5601fba17c96..9f93b230652a 100644 --- a/sound/soc/codecs/tas2770.c +++ b/sound/soc/codecs/tas2770.c @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include diff --git a/sound/soc/codecs/tas2780.c b/sound/soc/codecs/tas2780.c index 6902bfef185b..a1963415c931 100644 --- a/sound/soc/codecs/tas2780.c +++ b/sound/soc/codecs/tas2780.c @@ -7,7 +7,6 @@ #include #include #include -#include #include #include #include --=20 2.45.2