From nobody Thu Dec 18 20:37:44 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E188920FA9B for ; Tue, 6 Aug 2024 14:00:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722952822; cv=none; b=j/H77x7Xxhcfky1wRkeJVAi8vBsQDazaptVJIWuEmFRTwyvqmsdE9UUO6ohQ2s1Gbd+QdQVVN+kLrE7ekAFvLMbe3Go3PPJKyIUSkACmwIfP3BvKeW/6DNJMk67KJE1Wy0aSIpp6hQq3I+QzfWYCWplvfS89mf54lUEte6qTnIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722952822; c=relaxed/simple; bh=a4pOxli9XW7+v4k6zJrj2UiwKJCQToCB+MB9KHECXIc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MtNE3oMTBZPiCduCndjkTFhIje3syL2BzHCOqNMldG50qBQUjmIRQ9xHWy2NBC8n6qinPmVAY8T/z410TSyEdW4fJ9iZ7M1jwsQMwlQ6y8bfCFXyUaEifIw98oJoC1ZUz6km2Mh9U8vBwoAonkcX/6waqAx9qXNHYYOd+f3dy8g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fPc4Dhpf; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fPc4Dhpf" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-710afa8d1dfso487074b3a.3 for ; Tue, 06 Aug 2024 07:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722952820; x=1723557620; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zHlnE4b+EF1jE+6OxMeMiJgfIbEWX1SJndOm5es4WF8=; b=fPc4DhpfuxZeuo3xU2+VCPU4qoH/V10IoBzF9jGJoSvMPRbgFyRRDb2XChO4vgKMkP fcSExvHb2V4RAVkxowWWzpNCVnDZwylW9EMDTKmohulGTdLgFI0JskqQQKeLpPFtlybD YP7dKW6YYoqpLI1w3qwGUgJaYzen9kiL+WjZ50VKJctCTDkPptYEPC2mFNL+crvRDr/m f9xTZ754I3mUdQAfwv+Mz39zSumJfpFZTI2d6SfOuPZoZLT155dSrsyo7jau3eXGcYWW JiMYwOvzwPed7/c+0ybdeKRrkRn0TB+Oasi4K3jrJLOvyK5FHehtd5oLTPyKMtgVZFum djvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722952820; x=1723557620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zHlnE4b+EF1jE+6OxMeMiJgfIbEWX1SJndOm5es4WF8=; b=sz59BuDAFB8RIG2Em1wsty9rliv4OP+FWAqYDjhk1mijDevdsQgtF0CUqfKwqWtb+w B9lKzVvvY2gTi1O6W9CWEqRaUplNM/JdhvdWdu5rmjzveHbmTiODXFN7TbMsSVf01Z3F UPtR23nahMe3PjeuGnnWkKmvnGProZrsrtDklXspUJkfyRkjMjxFt4bcuP+cHP0kS/TN XtLJ/PfYY/Uwrxu9/lHGzyPjtzkbKpbVyJfsNapiVsl7ZveDSVCrqI0FvLNg1uw7nGpy FoxB8fyhChx0xrOZbd73+x9J9mRaix90W0SyimblCZ+LonHs6fVU79TcDFe4sKKs5rOg ThfQ== X-Forwarded-Encrypted: i=1; AJvYcCVpuYUA1doivV6u72aKLyscP7rp5aD8dg+3o2vA1AMbJBpt1hiK5G0ewZ6yK3uqsMFXX6lYoquMBjzdwRZIaKjyib7rEoP/Cn7Zp5yX X-Gm-Message-State: AOJu0Ywj68dzX9zVVqVT1+HL36wvzr3mRqWTAj1blvZsnEWQVi2vQoKM CRobuBVbOkX/7Xe6Z/6mh1HYi861Lk1RZ+l7js3ULSki06V/snVW X-Google-Smtp-Source: AGHT+IHcJGI37zJWjKZY/3gSGyIlz/mnFiRHe73rgoXzvjKXK3FoUkz2I0fJ9saNOFAKAI5XOa+Prw== X-Received: by 2002:a05:6a20:c990:b0:1c2:8904:14c2 with SMTP id adf61e73a8af0-1c69961543emr14209508637.37.1722952819962; Tue, 06 Aug 2024 07:00:19 -0700 (PDT) Received: from distilledx.srmu.edu.in ([14.96.13.220]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7b8a7453e92sm4415203a12.41.2024.08.06.07.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 07:00:19 -0700 (PDT) From: Tejas Vipin To: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, neil.armstrong@linaro.org, quic_jesszhan@quicinc.com Cc: dianders@chromium.org, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tejas Vipin Subject: [PATCH v3 1/2] drm/mipi-dsi: add more multi functions for better error handling Date: Tue, 6 Aug 2024 19:29:48 +0530 Message-ID: <20240806135949.468636-2-tejasvipin76@gmail.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240806135949.468636-1-tejasvipin76@gmail.com> References: <20240806135949.468636-1-tejasvipin76@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add more functions that can benefit from being multi style and mark older variants as deprecated to eventually convert all mipi_dsi functions to multi style. Acked-by: Maxime Ripard Signed-off-by: Tejas Vipin Reviewed-by: Douglas Anderson --- drivers/gpu/drm/drm_mipi_dsi.c | 194 +++++++++++++++++++++++++++++++++ include/drm/drm_mipi_dsi.h | 10 ++ 2 files changed, 204 insertions(+) diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index a471c46f5ca6..8d0a866cf1e0 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -603,6 +603,8 @@ EXPORT_SYMBOL(mipi_dsi_shutdown_peripheral); * mipi_dsi_turn_on_peripheral() - sends a Turn On Peripheral command * @dsi: DSI peripheral device * + * This function is deprecated. Use mipi_dsi_turn_on_peripheral_multi() in= stead. + * * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_turn_on_peripheral(struct mipi_dsi_device *dsi) @@ -652,6 +654,7 @@ EXPORT_SYMBOL(mipi_dsi_set_maximum_return_packet_size); * @pps_selector: Select PPS from the table of pre-stored or uploaded PPS = entries * * Enable or disable Display Stream Compression on the peripheral. + * This function is deprecated. Use mipi_dsi_compression_mode_ext_multi() = instead. * * Return: 0 on success or a negative error code on failure. */ @@ -703,6 +706,7 @@ EXPORT_SYMBOL(mipi_dsi_compression_mode); * @pps: VESA DSC 1.1 Picture Parameter Set * * Transmit the VESA DSC 1.1 Picture Parameter Set to the peripheral. + * This function is deprecated. Use mipi_dsi_picture_parameter_set_multi()= instead. * * Return: 0 on success or a negative error code on failure. */ @@ -1037,6 +1041,8 @@ EXPORT_SYMBOL(mipi_dsi_dcs_read); * mipi_dsi_dcs_nop() - send DCS nop packet * @dsi: DSI peripheral device * + * This function is deprecated. Use mipi_dsi_dcs_nop_multi() instead. + * * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_dcs_nop(struct mipi_dsi_device *dsi) @@ -1055,6 +1061,8 @@ EXPORT_SYMBOL(mipi_dsi_dcs_nop); * mipi_dsi_dcs_soft_reset() - perform a software reset of the display mod= ule * @dsi: DSI peripheral device * + * This function is deprecated. Use mipi_dsi_dcs_soft_reset_multi() instea= d. + * * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_dcs_soft_reset(struct mipi_dsi_device *dsi) @@ -1124,6 +1132,8 @@ EXPORT_SYMBOL(mipi_dsi_dcs_get_pixel_format); * display module except interface communication * @dsi: DSI peripheral device * + * This function is deprecated. Use mipi_dsi_dcs_enter_sleep_mode_multi() = instead. + * * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_dcs_enter_sleep_mode(struct mipi_dsi_device *dsi) @@ -1143,6 +1153,8 @@ EXPORT_SYMBOL(mipi_dsi_dcs_enter_sleep_mode); * module * @dsi: DSI peripheral device * + * This function is deprecated. Use mipi_dsi_dcs_exit_sleep_mode_multi() i= nstead. + * * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_dcs_exit_sleep_mode(struct mipi_dsi_device *dsi) @@ -1162,6 +1174,8 @@ EXPORT_SYMBOL(mipi_dsi_dcs_exit_sleep_mode); * display device * @dsi: DSI peripheral device * + * This function is deprecated. Use mipi_dsi_dcs_set_display_off_multi() i= nstead. + * * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_dcs_set_display_off(struct mipi_dsi_device *dsi) @@ -1181,6 +1195,8 @@ EXPORT_SYMBOL(mipi_dsi_dcs_set_display_off); * display device * @dsi: DSI peripheral device * + * This function is deprecated. Use mipi_dsi_dcs_set_display_on_multi() in= stead. + * * Return: 0 on success or a negative error code on failure */ int mipi_dsi_dcs_set_display_on(struct mipi_dsi_device *dsi) @@ -1202,6 +1218,9 @@ EXPORT_SYMBOL(mipi_dsi_dcs_set_display_on); * @start: first column of frame memory * @end: last column of frame memory * + * This function is deprecated. Use mipi_dsi_dcs_set_column_address_multi() + * instead. + * * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_dcs_set_column_address(struct mipi_dsi_device *dsi, u16 start, @@ -1226,6 +1245,9 @@ EXPORT_SYMBOL(mipi_dsi_dcs_set_column_address); * @start: first page of frame memory * @end: last page of frame memory * + * This function is deprecated. Use mipi_dsi_dcs_set_page_address_multi() + * instead. + * * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_dcs_set_page_address(struct mipi_dsi_device *dsi, u16 start, @@ -1268,6 +1290,8 @@ EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_off); * @dsi: DSI peripheral device * @mode: the Tearing Effect Output Line mode * + * This function is deprecated. Use mipi_dsi_dcs_set_tear_on_multi() inste= ad. + * * Return: 0 on success or a negative error code on failure */ int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, @@ -1291,6 +1315,9 @@ EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_on); * @dsi: DSI peripheral device * @format: pixel format * + * This function is deprecated. Use mipi_dsi_dcs_set_pixel_format_multi() + * instead. + * * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format) @@ -1334,6 +1361,9 @@ EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_scanline); * @dsi: DSI peripheral device * @brightness: brightness value * + * This function is deprecated. Use mipi_dsi_dcs_set_display_brightness_mu= lti() + * instead. + * * Return: 0 on success or a negative error code on failure. */ int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi, @@ -1639,6 +1669,170 @@ void mipi_dsi_dcs_set_tear_on_multi(struct mipi_dsi= _multi_context *ctx, } EXPORT_SYMBOL(mipi_dsi_dcs_set_tear_on_multi); =20 +/** + * mipi_dsi_turn_on_peripheral_multi() - sends a Turn On Peripheral command + * @ctx: Context for multiple DSI transactions + * + * Like mipi_dsi_turn_on_peripheral() but deals with errors in a way that + * makes it convenient to make several calls in a row. + */ +void mipi_dsi_turn_on_peripheral_multi(struct mipi_dsi_multi_context *ctx) +{ + struct mipi_dsi_device *dsi =3D ctx->dsi; + struct device *dev =3D &dsi->dev; + int ret; + + if (ctx->accum_err) + return; + + ret =3D mipi_dsi_turn_on_peripheral(dsi); + if (ret < 0) { + ctx->accum_err =3D ret; + dev_err(dev, "Failed to turn on peripheral: %d\n", + ctx->accum_err); + } +} +EXPORT_SYMBOL(mipi_dsi_turn_on_peripheral_multi); + +/** + * mipi_dsi_dcs_soft_reset_multi() - perform a software reset of the displ= ay module + * @ctx: Context for multiple DSI transactions + * + * Like mipi_dsi_dcs_soft_reset() but deals with errors in a way that + * makes it convenient to make several calls in a row. + */ +void mipi_dsi_dcs_soft_reset_multi(struct mipi_dsi_multi_context *ctx) +{ + struct mipi_dsi_device *dsi =3D ctx->dsi; + struct device *dev =3D &dsi->dev; + int ret; + + if (ctx->accum_err) + return; + + ret =3D mipi_dsi_dcs_soft_reset(dsi); + if (ret < 0) { + ctx->accum_err =3D ret; + dev_err(dev, "Failed to mipi_dsi_dcs_soft_reset: %d\n", + ctx->accum_err); + } +} +EXPORT_SYMBOL(mipi_dsi_dcs_soft_reset_multi); + +/** + * mipi_dsi_dcs_set_display_brightness_multi() - sets the brightness value= of + * the display + * @ctx: Context for multiple DSI transactions + * @brightness: brightness value + * + * Like mipi_dsi_dcs_set_display_brightness() but deals with errors in a w= ay that + * makes it convenient to make several calls in a row. + */ +void mipi_dsi_dcs_set_display_brightness_multi(struct mipi_dsi_multi_conte= xt *ctx, + u16 brightness) +{ + struct mipi_dsi_device *dsi =3D ctx->dsi; + struct device *dev =3D &dsi->dev; + int ret; + + if (ctx->accum_err) + return; + + ret =3D mipi_dsi_dcs_set_display_brightness(dsi, brightness); + if (ret < 0) { + ctx->accum_err =3D ret; + dev_err(dev, "Failed to write display brightness: %d\n", + ctx->accum_err); + } +} +EXPORT_SYMBOL(mipi_dsi_dcs_set_display_brightness_multi); + +/** + * mipi_dsi_dcs_set_pixel_format_multi() - sets the pixel format for the R= GB image + * data used by the interface + * @ctx: Context for multiple DSI transactions + * @format: pixel format + * + * Like mipi_dsi_dcs_set_pixel_format() but deals with errors in a way that + * makes it convenient to make several calls in a row. + */ +void mipi_dsi_dcs_set_pixel_format_multi(struct mipi_dsi_multi_context *ct= x, + u8 format) +{ + struct mipi_dsi_device *dsi =3D ctx->dsi; + struct device *dev =3D &dsi->dev; + int ret; + + if (ctx->accum_err) + return; + + ret =3D mipi_dsi_dcs_set_pixel_format(dsi, format); + if (ret < 0) { + ctx->accum_err =3D ret; + dev_err(dev, "Failed to set pixel format: %d\n", + ctx->accum_err); + } +} +EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format_multi); + +/** + * mipi_dsi_dcs_set_column_address_multi() - define the column extent of t= he + * frame memory accessed by the host processor + * @ctx: Context for multiple DSI transactions + * @start: first column of frame memory + * @end: last column of frame memory + * + * Like mipi_dsi_dcs_set_column_address() but deals with errors in a way t= hat + * makes it convenient to make several calls in a row. + */ +void mipi_dsi_dcs_set_column_address_multi(struct mipi_dsi_multi_context *= ctx, + u16 start, u16 end) +{ + struct mipi_dsi_device *dsi =3D ctx->dsi; + struct device *dev =3D &dsi->dev; + int ret; + + if (ctx->accum_err) + return; + + ret =3D mipi_dsi_dcs_set_column_address(dsi, start, end); + if (ret < 0) { + ctx->accum_err =3D ret; + dev_err(dev, "Failed to set column address: %d\n", + ctx->accum_err); + } +} +EXPORT_SYMBOL(mipi_dsi_dcs_set_column_address_multi); + +/** + * mipi_dsi_dcs_set_page_address_multi() - define the page extent of the + * frame memory accessed by the host processor + * @ctx: Context for multiple DSI transactions + * @start: first page of frame memory + * @end: last page of frame memory + * + * Like mipi_dsi_dcs_set_page_address() but deals with errors in a way that + * makes it convenient to make several calls in a row. + */ +void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ct= x, + u16 start, u16 end) +{ + struct mipi_dsi_device *dsi =3D ctx->dsi; + struct device *dev =3D &dsi->dev; + int ret; + + if (ctx->accum_err) + return; + + ret =3D mipi_dsi_dcs_set_page_address(dsi, start, end); + if (ret < 0) { + ctx->accum_err =3D ret; + dev_err(dev, "Failed to set page address: %d\n", + ctx->accum_err); + } +} +EXPORT_SYMBOL(mipi_dsi_dcs_set_page_address_multi); + static int mipi_dsi_drv_probe(struct device *dev) { struct mipi_dsi_driver *drv =3D to_mipi_dsi_driver(dev->driver); diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index 0f520eeeaa8e..602be6ce081a 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -365,6 +365,16 @@ void mipi_dsi_dcs_set_display_off_multi(struct mipi_ds= i_multi_context *ctx); void mipi_dsi_dcs_set_display_on_multi(struct mipi_dsi_multi_context *ctx); void mipi_dsi_dcs_set_tear_on_multi(struct mipi_dsi_multi_context *ctx, enum mipi_dsi_dcs_tear_mode mode); +void mipi_dsi_turn_on_peripheral_multi(struct mipi_dsi_multi_context *ctx); +void mipi_dsi_dcs_soft_reset_multi(struct mipi_dsi_multi_context *ctx); +void mipi_dsi_dcs_set_display_brightness_multi(struct mipi_dsi_multi_conte= xt *ctx, + u16 brightness); +void mipi_dsi_dcs_set_pixel_format_multi(struct mipi_dsi_multi_context *ct= x, + u8 format); +void mipi_dsi_dcs_set_column_address_multi(struct mipi_dsi_multi_context *= ctx, + u16 start, u16 end); +void mipi_dsi_dcs_set_page_address_multi(struct mipi_dsi_multi_context *ct= x, + u16 start, u16 end); =20 /** * mipi_dsi_generic_write_seq - transmit data using a generic write packet --=20 2.46.0 From nobody Thu Dec 18 20:37:44 2025 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78E9D20FABD for ; Tue, 6 Aug 2024 14:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722952826; cv=none; b=o/OYkgq1vbkG277FwWXG7FXhZ2j3LQC8t2VlOV9AF2U8eTeQHkHoShMD7GfUEVQ1N843e9erHse4soEIt7UMKmoXdzbp6Id+mzu7usTGoSxKNs4+inZlejTyFMhcfGakasfjuJAyHsg5WwQ1LQsf5aySHLvAw3gxzWn7SNsObDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722952826; c=relaxed/simple; bh=CGXUrPsz/OmExTM5SbVDpLX0u2V4Tt4P9Tx5vcp2+Mc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WOmCHJLfrku1ABsCZaOvCh9dTSRJFi97mExeDi9VWBfeEfGz1zyr+wMSKqSMl77voOi25pVDm7Ee7nUgU7zm+fQM1sM9nOhKnFK80oIFeML4EsvYS9MqyVi9ldmEC3tCzzeAWESMZIO/aBsxylpboz8SVj2eCvupyYpCBWtt2t4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CxpaIOKj; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CxpaIOKj" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2cb81c0ecb4so4824097a91.0 for ; Tue, 06 Aug 2024 07:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722952824; x=1723557624; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CK7ANORZUzGJICKPtXebR+TykgsKwGrzcFtwkmK0p10=; b=CxpaIOKj4eC0Y1MeptRWFCnU1+MkMRa25U/2jl/V3pv5jLRczOgL5FeD9nN5HogvTV 9doGjCrfwW6Mm5JtJauTyT/62DRfBWMufpCOxOmttecQf9K/orPBm/0Sfp+yekTRuha1 nTUtjGWLiDlni8ee/AovoeMQkWQvMNCdzdg1cdhEaOC8a1ldJk2QCL1sKlsoPWY76fl7 H3y+UdwJ8t+RHmiG7ufzCZZf9PtHYgQYJPi4VpbFKSoSWLrVb0pnfmSvTG53GSyhw05E BkzJRcDNpLZlQ/S1IzinaFHeN/wrrLtqdt2RvGrShevykwRLi6q2lqutXPWpiZ9ym0l8 iVwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722952824; x=1723557624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CK7ANORZUzGJICKPtXebR+TykgsKwGrzcFtwkmK0p10=; b=Yw0igTlGjLNx2tzgcVlJ1V30Rlvc0Ekjyggg70cbthQhaa/zixTqjuRfP/5eAfQWId 4GlZ9vXSVyVETzo3FUvJz/Fx+rvJCi2t9+FGuJ2jZn4YSf/6jmSO8l0NkPvleOGV0yrC fo4HDHrQqI6KPndtn1k2f5oK8fD0d6/jtZpU8sM93OgBGrTdUwWuGbgrenvQxjQuHWbc WdZf+6fJTVYSPc6J8ChpOoH01JwPH1CMgJj3wohX5VRxGcGwHX9LYU7JxrOYLuiBBK4l mZV0hBnDAspN/xEeLzC6UpOvwyXN98ie67bEbACqok35pGXLICgBCgMpIpAnG8thsa1z QlNA== X-Forwarded-Encrypted: i=1; AJvYcCVixHzrM6R0evDHFimhUptdpiKhL2MC/HsWpw2qXOvGHG33xWxQi2PfXX4R3fx/d2WOe/Qbmc8wuJGeXkWoJritOnFj/jZGypUtYS4Q X-Gm-Message-State: AOJu0YzWC8xOvWl+mXzQm83doF1rXL/mXsTCiom9WwUuhE8Ww695H0ao xB9IelNzZ9/DioRs3Ci5FYW6AMKQi0yGIE1gaaBNfgdAgTa7fUQ/ X-Google-Smtp-Source: AGHT+IEMJuSc3n8itBDIcMqQLHq9b38TucY0X+Cs8gDQafx/MBSagnSSDNMUT4P1LpKXjey729/MqA== X-Received: by 2002:a17:90b:4c07:b0:2c8:2236:e2c3 with SMTP id 98e67ed59e1d1-2cff0b253a1mr26643464a91.17.1722952823581; Tue, 06 Aug 2024 07:00:23 -0700 (PDT) Received: from distilledx.srmu.edu.in ([14.96.13.220]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7b8a7453e92sm4415203a12.41.2024.08.06.07.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 07:00:23 -0700 (PDT) From: Tejas Vipin To: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, neil.armstrong@linaro.org, quic_jesszhan@quicinc.com Cc: dianders@chromium.org, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tejas Vipin Subject: [PATCH v3 2/2] drm/panel: startek-kd070fhfid015: transition to mipi_dsi wrapped functions Date: Tue, 6 Aug 2024 19:29:49 +0530 Message-ID: <20240806135949.468636-3-tejasvipin76@gmail.com> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240806135949.468636-1-tejasvipin76@gmail.com> References: <20240806135949.468636-1-tejasvipin76@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use multi style wrapped functions for mipi_dsi in the startek-kd070fhfid015 panel. Signed-off-by: Tejas Vipin Reviewed-by: Douglas Anderson Reviewed-by: Jessica Zhang --- .../drm/panel/panel-startek-kd070fhfid015.c | 115 ++++++------------ 1 file changed, 35 insertions(+), 80 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c b/drivers/= gpu/drm/panel/panel-startek-kd070fhfid015.c index 0156689f41cd..c0c95355b743 100644 --- a/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c +++ b/drivers/gpu/drm/panel/panel-startek-kd070fhfid015.c @@ -24,10 +24,10 @@ #include #include =20 -#define DSI_REG_MCAP 0xB0 -#define DSI_REG_IS 0xB3 /* Interface Setting */ -#define DSI_REG_IIS 0xB4 /* Interface ID Setting */ -#define DSI_REG_CTRL 0xB6 +#define DSI_REG_MCAP 0xb0 +#define DSI_REG_IS 0xb3 /* Interface Setting */ +#define DSI_REG_IIS 0xb4 /* Interface ID Setting */ +#define DSI_REG_CTRL 0xb6 =20 enum { IOVCC =3D 0, @@ -52,92 +52,55 @@ static inline struct stk_panel *to_stk_panel(struct drm= _panel *panel) static int stk_panel_init(struct stk_panel *stk) { struct mipi_dsi_device *dsi =3D stk->dsi; - struct device *dev =3D &stk->dsi->dev; - int ret; - - ret =3D mipi_dsi_dcs_soft_reset(dsi); - if (ret < 0) { - dev_err(dev, "failed to mipi_dsi_dcs_soft_reset: %d\n", ret); - return ret; - } - mdelay(5); + struct mipi_dsi_multi_context dsi_ctx =3D {.dsi =3D dsi}; =20 - ret =3D mipi_dsi_dcs_exit_sleep_mode(dsi); - if (ret < 0) { - dev_err(dev, "failed to set exit sleep mode: %d\n", ret); - return ret; - } - msleep(120); + mipi_dsi_dcs_soft_reset_multi(&dsi_ctx); + mipi_dsi_msleep(&dsi_ctx, 5); + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); + mipi_dsi_msleep(&dsi_ctx, 120); =20 - mipi_dsi_generic_write_seq(dsi, DSI_REG_MCAP, 0x04); + mipi_dsi_generic_write_seq_multi(&dsi_ctx, DSI_REG_MCAP, 0x04); =20 /* Interface setting, video mode */ - mipi_dsi_generic_write_seq(dsi, DSI_REG_IS, 0x14, 0x08, 0x00, 0x22, 0x00); - mipi_dsi_generic_write_seq(dsi, DSI_REG_IIS, 0x0C, 0x00); - mipi_dsi_generic_write_seq(dsi, DSI_REG_CTRL, 0x3A, 0xD3); + mipi_dsi_generic_write_seq_multi(&dsi_ctx, DSI_REG_IS, 0x14, 0x08, 0x00, = 0x22, 0x00); + mipi_dsi_generic_write_seq_multi(&dsi_ctx, DSI_REG_IIS, 0x0c, 0x00); + mipi_dsi_generic_write_seq_multi(&dsi_ctx, DSI_REG_CTRL, 0x3a, 0xd3); =20 - ret =3D mipi_dsi_dcs_set_display_brightness(dsi, 0x77); - if (ret < 0) { - dev_err(dev, "failed to write display brightness: %d\n", ret); - return ret; - } + mipi_dsi_dcs_set_display_brightness_multi(&dsi_ctx, 0x77); =20 - mipi_dsi_dcs_write_seq(dsi, MIPI_DCS_WRITE_CONTROL_DISPLAY, - MIPI_DCS_WRITE_MEMORY_START); + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, MIPI_DCS_WRITE_CONTROL_DISPLAY, + MIPI_DCS_WRITE_MEMORY_START); =20 - ret =3D mipi_dsi_dcs_set_pixel_format(dsi, 0x77); - if (ret < 0) { - dev_err(dev, "failed to set pixel format: %d\n", ret); - return ret; - } + mipi_dsi_dcs_set_pixel_format_multi(&dsi_ctx, 0x77); + mipi_dsi_dcs_set_column_address_multi(&dsi_ctx, 0, stk->mode->hdisplay - = 1); + mipi_dsi_dcs_set_page_address_multi(&dsi_ctx, 0, stk->mode->vdisplay - 1); =20 - ret =3D mipi_dsi_dcs_set_column_address(dsi, 0, stk->mode->hdisplay - 1); - if (ret < 0) { - dev_err(dev, "failed to set column address: %d\n", ret); - return ret; - } - - ret =3D mipi_dsi_dcs_set_page_address(dsi, 0, stk->mode->vdisplay - 1); - if (ret < 0) { - dev_err(dev, "failed to set page address: %d\n", ret); - return ret; - } - - return 0; + return dsi_ctx.accum_err; } =20 static int stk_panel_on(struct stk_panel *stk) { struct mipi_dsi_device *dsi =3D stk->dsi; - struct device *dev =3D &stk->dsi->dev; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D {.dsi =3D dsi}; =20 - ret =3D mipi_dsi_dcs_set_display_on(dsi); - if (ret < 0) - dev_err(dev, "failed to set display on: %d\n", ret); + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 - mdelay(20); + mipi_dsi_msleep(&dsi_ctx, 20); =20 - return ret; + return dsi_ctx.accum_err; } =20 static void stk_panel_off(struct stk_panel *stk) { struct mipi_dsi_device *dsi =3D stk->dsi; - struct device *dev =3D &stk->dsi->dev; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D {.dsi =3D dsi}; =20 dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; =20 - ret =3D mipi_dsi_dcs_set_display_off(dsi); - if (ret < 0) - dev_err(dev, "failed to set display off: %d\n", ret); + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); =20 - ret =3D mipi_dsi_dcs_enter_sleep_mode(dsi); - if (ret < 0) - dev_err(dev, "failed to enter sleep mode: %d\n", ret); - - msleep(100); + mipi_dsi_msleep(&dsi_ctx, 100); } =20 static int stk_panel_unprepare(struct drm_panel *panel) @@ -155,7 +118,6 @@ static int stk_panel_unprepare(struct drm_panel *panel) static int stk_panel_prepare(struct drm_panel *panel) { struct stk_panel *stk =3D to_stk_panel(panel); - struct device *dev =3D &stk->dsi->dev; int ret; =20 gpiod_set_value(stk->reset_gpio, 0); @@ -175,16 +137,12 @@ static int stk_panel_prepare(struct drm_panel *panel) gpiod_set_value(stk->reset_gpio, 1); mdelay(10); ret =3D stk_panel_init(stk); - if (ret < 0) { - dev_err(dev, "failed to init panel: %d\n", ret); + if (ret < 0) goto poweroff; - } =20 ret =3D stk_panel_on(stk); - if (ret < 0) { - dev_err(dev, "failed to set panel on: %d\n", ret); + if (ret < 0) goto poweroff; - } =20 return 0; =20 @@ -250,18 +208,15 @@ static int dsi_dcs_bl_get_brightness(struct backlight= _device *bl) static int dsi_dcs_bl_update_status(struct backlight_device *bl) { struct mipi_dsi_device *dsi =3D bl_get_data(bl); - struct device *dev =3D &dsi->dev; - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D {.dsi =3D dsi}; =20 dsi->mode_flags &=3D ~MIPI_DSI_MODE_LPM; - ret =3D mipi_dsi_dcs_set_display_brightness(dsi, bl->props.brightness); - if (ret < 0) { - dev_err(dev, "failed to set DSI control: %d\n", ret); - return ret; - } + mipi_dsi_dcs_set_display_brightness_multi(&dsi_ctx, bl->props.brightness); + if (dsi_ctx.accum_err) + return dsi_ctx.accum_err; =20 dsi->mode_flags |=3D MIPI_DSI_MODE_LPM; - return 0; + return dsi_ctx.accum_err; } =20 static const struct backlight_ops dsi_bl_ops =3D { --=20 2.46.0