From nobody Fri Dec 19 20:33:53 2025 Received: from fhigh7-smtp.messagingengine.com (fhigh7-smtp.messagingengine.com [103.168.172.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84D0BBA34; Tue, 6 Aug 2024 02:08:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722910082; cv=none; b=A3+NNTE4ho209qp4to6iAgXZ9BmHRiED0tQrw9Q406IkFl8mEpufRayiSRl92kgVr5O+hAhSm1KGczFQnPR9nCm/UQuE4StZ+idb16hgb/JRf8IhWK7lYAd3DMGQ8+NvgBR+bIZBpgoHMgvhvPLsl03FMLXUyyq88gMbEnkdPD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722910082; c=relaxed/simple; bh=7GogOe5n9F2zHkC/WirTp89rqrdd3akHu64WR1KTE1Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nF6+wX+MqsjeRJ9ZZEP8sOZaSOPK2vrb7+IWa5hRbXw11Y0D9Y3xwaXuMRYjD9pqU0Z/xiEkgpjKeiBxeWgJU7JB+v0K4gktPERlFc/TAX0wuhq+NEvy+0A9zBg6C88jZ2xV4qPKhCeVb0CTakcXFGJH4YDAjyAccjjpTRX/ctU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ljones.dev; spf=none smtp.mailfrom=ljones.dev; dkim=pass (2048-bit key) header.d=ljones.dev header.i=@ljones.dev header.b=FpcXUiVK; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=q3pCGfZi; arc=none smtp.client-ip=103.168.172.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ljones.dev Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ljones.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ljones.dev header.i=@ljones.dev header.b="FpcXUiVK"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="q3pCGfZi" Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.nyi.internal (Postfix) with ESMTP id A74ED1151A8A; Mon, 5 Aug 2024 22:07:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 05 Aug 2024 22:07:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1722910079; x= 1722996479; bh=gIvWdDLxWY22hhOBPE6JYFoqhl5WH6m9QN6kQjoDgMY=; b=F pcXUiVKTqyZ9SmvDc1uk2RqM9o8BH4dw9md3VBfFxIY4v5corV+kmXtKilN+HGgP FvyYx3faLKiofqaGrqy4Encn+H1r4Nhgz2lGCd+iSeKROuyNyfh5wQkXfO3M/7mp bdH5IRzrXm5ozgxAQ9d2NpLhFxGM2bJt5if6sqzwHSGCQi+2Dlc6I5JUt56KjWVS 08FrB2Diqvxl/F5nWojMzO6RCquU4p4AkbtDeaBvzBkUGoZdIWU9pcThaR+CFg/N Cr1MrLbJV7jhfrS2YXADN8x00aHmejYrovq8DvmZk/upfzic0awWWZugPfaQnOMl Vmsfo5TGR8sf0fffEP7Tw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1722910079; x= 1722996479; bh=gIvWdDLxWY22hhOBPE6JYFoqhl5WH6m9QN6kQjoDgMY=; b=q 3pCGfZiXipAuBzRPJnIvkV6tgXQ5wqTDrJ45IUPrIH7gSGfsei9Tlb6DaAJ5RLOD swRnrWTyD8L/Fc4gBUI/gYRVqRuPhblQn/id5FmRLgHSrocWpjiA2h1aSglrZ2Gh N60YKhgVPmc0UZPwVYPxwPbhkukhC57oY7moY/ura9oj3Llk32xHcgg4MAQBiLoi d5r7pv+YLnt83/jvADP7TmRvjcu7Iqn1RlhdWZSCFk6GE8yuvVirOAAVpe4CuQXE wMBv0LDozXK0vq6exXVXNYecSB6S5Ip63hL8JbFpNvdiVPCNAic/+95tFMI4S0x0 43iRfenv4p0yDBXPfHNAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrkeejgdehiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepfdfnuhhkvgcuffdrucflohhnvghsfdcuoehluhhkvgeslhhj ohhnvghsrdguvghvqeenucggtffrrghtthgvrhhnpefgteefudfgteduueehteejhfeugf fgleeltedvveethfeuueejfedvgeelveehgfenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehluhhkvgeslhhjohhnvghsrdguvghvpdhnsggprh gtphhtthhopedt X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Aug 2024 22:07:56 -0400 (EDT) From: "Luke D. Jones" To: platform-driver-x86@vger.kernel.org Cc: linux-kernel@vger.kernel.org, ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com, corentin.chary@gmail.com, "Luke D. Jones" Subject: [PATCH v2 1/6] platform/x86: asus-wmi: Add quirk for ROG Ally X Date: Tue, 6 Aug 2024 14:07:42 +1200 Message-ID: <20240806020747.365042-2-luke@ljones.dev> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240806020747.365042-1-luke@ljones.dev> References: <20240806020747.365042-1-luke@ljones.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The new ROG Ally X functions the same as the previus model so we can use the same method to ensure the MCU USB devices wake and reconnect correctly. Given that two devices marks the start of a trend, this patch also adds a quirk table to make future additions easier if the MCU is the same. Signed-off-by: Luke D. Jones Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/platform/x86/asus-wmi.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wm= i.c index f15fcb45e1aa..0c80c6b0399b 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -152,6 +152,20 @@ static const char * const ashs_ids[] =3D { "ATK4001", = "ATK4002", NULL }; =20 static int throttle_thermal_policy_write(struct asus_wmi *); =20 +static const struct dmi_system_id asus_ally_mcu_quirk[] =3D { + { + .matches =3D { + DMI_MATCH(DMI_BOARD_NAME, "RC71L"), + }, + }, + { + .matches =3D { + DMI_MATCH(DMI_BOARD_NAME, "RC72L"), + }, + }, + { }, +}; + static bool ashs_present(void) { int i =3D 0; @@ -4751,7 +4765,7 @@ static int asus_wmi_add(struct platform_device *pdev) asus->dgpu_disable_available =3D asus_wmi_dev_is_present(asus, ASUS_WMI_D= EVID_DGPU); asus->kbd_rgb_state_available =3D asus_wmi_dev_is_present(asus, ASUS_WMI_= DEVID_TUF_RGB_STATE); asus->ally_mcu_usb_switch =3D acpi_has_method(NULL, ASUS_USB0_PWR_EC0_CSE= E) - && dmi_match(DMI_BOARD_NAME, "RC71L"); + && dmi_check_system(asus_ally_mcu_quirk); =20 if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MINI_LED_MODE)) asus->mini_led_dev_id =3D ASUS_WMI_DEVID_MINI_LED_MODE; --=20 2.45.2