From nobody Mon Feb 9 03:31:24 2026 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 737011CA9C for ; Tue, 6 Aug 2024 15:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722958200; cv=none; b=I2YTW1qjO38ixaNBHCb5BcpOkrFViX/F4+KENObKZOBZ+nTjqhqx7vu+/HuS4IrG3D+g+JfpCJFr4xEQYkYvWlIB5rABdNh3b9OxrmDf/iN4nWgTTu8Ck5jDCDJ483wl2hLxslLZzISnoAHO//vaGiop2YUVS5BwUn6RCv8T6Wc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722958200; c=relaxed/simple; bh=bPeZihTCF+Ow/O7uL47gsdFVGSiVkl8vSkFqcaDBcF0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fQkJogb4WPZQg+PeBeidbESRTwpbbAe8XZKxy8zdzm3bnKKAvSRgQ2mdKS393ZUQv6/hKHBim7JPfBxy9Hh3/H/CQ/gGg0PPeOe6nk0Jh4/IdP2qX+m1VyYDNt8JjXh+XvaWgV7GxXSDNNhwfmjCkYyWlXmfl/bCL533MO+lvJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FHho+nBb; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FHho+nBb" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-52efabf5d7bso1141123e87.1 for ; Tue, 06 Aug 2024 08:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722958196; x=1723562996; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Rk2Awb+sGDAUp2fed+2uqRPu8RHHDA4mh3PcSw6gyEg=; b=FHho+nBbmIvVErziWtqg1ezzjYrPDFztv2R1cezhc4jRqjKO510g0JZE2akgrISH04 Tc7zVLSv/oGHkwrxNpQ8j8vcxV+OOhjsbJZX3QHzdSI8Pr9PLZJlkZQu3V09Y6qrWNkJ SskT2xzdrTKyv9dsHg0ZTsV+FS7g/6TJjf3XDlBN8xHgj88wZSgogUF7CQE+DhGlteS6 zhMc2HZpdiOy0EDr9h/gRuXxuEDg+OmtPvjAVGkVWcgLMZRcHvu5c4nSLILPu8HjD6UK pn0sNUFtVgIajWG7y4dGxoT3i+2hz/rZa1N46MWkNP54I90smA6yX7kev0LKfu1iEkyf 6cvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722958196; x=1723562996; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rk2Awb+sGDAUp2fed+2uqRPu8RHHDA4mh3PcSw6gyEg=; b=bCSc7XJr8g15zgM8pXDcyyXiuoq6NGv49ghNCL2yG7xxuKRg1qm02bA5A2QCYps5qy 7qUuhJSPn8iNOT39b27cxESbLa2oYxAM5ocVo062rx1ZBSzaN6aXfEUuoQsR72MgRfTJ J525uW/BtC7vPQGw8K2pcY6k6JXoI3Ehr28Sq0jbrl2zzj/d0nnJuAb8mGTmdcmAdxwG qqnj2ATgF2ktvkPHjfakIeJgbxrD7fFKUYeN5AZ9NTKVlfqilwTxkGDRBU43mS4YG9Fk lehdqjgcKaTWVIt1O53i/Ivec9M4nqPjlIz65FlLyYOekL7jZ6VLXZt44+Gx7jCP6Cal FLqA== X-Forwarded-Encrypted: i=1; AJvYcCWkEYcVPP18bhheoStizYTZE1HnpifULenskvpo7mduTkFaLYCi7KCh7mRXjHRPqhR0+IhqAa2GF9lxYhG4znA8WE8YfgXGk2B1rCeO X-Gm-Message-State: AOJu0Yx2yAM/kyhNkkg/olZQn7byQxdYYz91ef6WjZtlACTh+V0D2JaC GaTzDISQHcsYrgjoC9YyM1huokx4T9HLJ7C66/R4cg7Vm3FSieq/g+iFWLmpBmg= X-Google-Smtp-Source: AGHT+IEzRSe9RZ8IZ7a79GIk6K9Ld7GIQxp37hHU2EYAuNypM9NuHuI6ejLRItdRTqLiJvXepFVECQ== X-Received: by 2002:ac2:4c88:0:b0:530:bbe7:4db3 with SMTP id 2adb3069b0e04-530bbe74f4cmr7491016e87.39.1722958196387; Tue, 06 Aug 2024 08:29:56 -0700 (PDT) Received: from puffmais.c.googlers.com (64.227.90.34.bc.googleusercontent.com. [34.90.227.64]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9d4294fsm555274266b.103.2024.08.06.08.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 08:29:56 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 06 Aug 2024 16:29:45 +0100 Subject: [PATCH 1/2] tty: serial: samsung_tty: drop unused argument to irq handlers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240806-samsung-tty-cleanup-v1-1-a68d3abf31fe@linaro.org> References: <20240806-samsung-tty-cleanup-v1-0-a68d3abf31fe@linaro.org> In-Reply-To: <20240806-samsung-tty-cleanup-v1-0-a68d3abf31fe@linaro.org> To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.13.0 The 'irq' argument is not used in any of the callees, we can just drop it and simplify the code. No functional changes. Signed-off-by: Andr=C3=A9 Draszik Reviewed-by: Tudor Ambarus --- drivers/tty/serial/samsung_tty.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_= tty.c index dc35eb77d2ef..1c6d0ffe5649 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -855,7 +855,7 @@ static irqreturn_t s3c24xx_serial_rx_chars_pio(void *de= v_id) return IRQ_HANDLED; } =20 -static irqreturn_t s3c24xx_serial_rx_irq(int irq, void *dev_id) +static irqreturn_t s3c24xx_serial_rx_irq(void *dev_id) { struct s3c24xx_uart_port *ourport =3D dev_id; =20 @@ -928,7 +928,7 @@ static void s3c24xx_serial_tx_chars(struct s3c24xx_uart= _port *ourport) s3c24xx_serial_stop_tx(port); } =20 -static irqreturn_t s3c24xx_serial_tx_irq(int irq, void *id) +static irqreturn_t s3c24xx_serial_tx_irq(void *id) { struct s3c24xx_uart_port *ourport =3D id; struct uart_port *port =3D &ourport->port; @@ -950,11 +950,11 @@ static irqreturn_t s3c64xx_serial_handle_irq(int irq,= void *id) irqreturn_t ret =3D IRQ_HANDLED; =20 if (pend & S3C64XX_UINTM_RXD_MSK) { - ret =3D s3c24xx_serial_rx_irq(irq, id); + ret =3D s3c24xx_serial_rx_irq(id); wr_regl(port, S3C64XX_UINTP, S3C64XX_UINTM_RXD_MSK); } if (pend & S3C64XX_UINTM_TXD_MSK) { - ret =3D s3c24xx_serial_tx_irq(irq, id); + ret =3D s3c24xx_serial_tx_irq(id); wr_regl(port, S3C64XX_UINTP, S3C64XX_UINTM_TXD_MSK); } return ret; @@ -971,11 +971,11 @@ static irqreturn_t apple_serial_handle_irq(int irq, v= oid *id) if (pend & (APPLE_S5L_UTRSTAT_RXTHRESH | APPLE_S5L_UTRSTAT_RXTO)) { wr_regl(port, S3C2410_UTRSTAT, APPLE_S5L_UTRSTAT_RXTHRESH | APPLE_S5L_UTRSTAT_RXTO); - ret =3D s3c24xx_serial_rx_irq(irq, id); + ret =3D s3c24xx_serial_rx_irq(id); } if (pend & APPLE_S5L_UTRSTAT_TXTHRESH) { wr_regl(port, S3C2410_UTRSTAT, APPLE_S5L_UTRSTAT_TXTHRESH); - ret =3D s3c24xx_serial_tx_irq(irq, id); + ret =3D s3c24xx_serial_tx_irq(id); } =20 return ret; --=20 2.46.0.rc2.264.g509ed76dc8-goog From nobody Mon Feb 9 03:31:24 2026 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E89C821105 for ; Tue, 6 Aug 2024 15:29:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722958200; cv=none; b=BjihRBLIj7S6rKPzy0Rqp2E63Sa3naR54dYNWy2ll4vun19WwAfcgPBRxCbnKyyJ+hFQzstNk1RoUFDv77jyUHOeZrObzOn7RRw6q5aCMLwh7ANxwJ7Qd2uzAVxQpovV/68LlXIJf/IEteQa+mTlclf6oy62uVDUFK6IQuCN7zc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722958200; c=relaxed/simple; bh=PF0Vxx/H/Fh+6ybEWx6+PwT0mzFwGK4sk9orjriQwGU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aEhSmfz6KPuR3gFfom5LEEZnaC2y4yjbuDGwITWo1TEvnWu0vlWD1OULZyGXc0W1oTl1ct3Ogz4wecobPeq4CRdBWQxU9gSaaeAwtgI7TvW8ml/G/8WtyT30XgUY+mpFH8lSJYqPR5IKaLsd+NhMR6ULTxV3JGTezL3ilvZObn4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=k88V720B; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k88V720B" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-52efdf02d13so1316886e87.2 for ; Tue, 06 Aug 2024 08:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722958197; x=1723562997; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=McdwXMf+aVpukum1jWBbRDvrxSrkWixRhMvgP59hNnk=; b=k88V720BVBKIcCJIBbzvwKHL25gQJ8JtselYsz6TfTylt3yw8/WpSgPMdTnLaZpbW3 WXkKMw5ptMOGQsm7/TZ/JJqQoR5/jCTV8qeE51wqgBGmOwwLhje8UW86vDMe1ibWfQP0 hJ3X9MIUXvYARLmhN/ScGKpB+rLEaURk8X0+QWJvjEjfEu2yJGw1u9z6c/5YH6FN2foM HwrXclkvislpuZpLkijGPmU2lK7MELLgdYQpupam3dBimBXzueLCwIN1nsY+bWXkOGyI ZUlKM8ye49MSCNiW9meRItSJWH82SMmletmSLNJEv3RI6SXWJ7rQWy2LATFnPm8MCDKi F9OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722958197; x=1723562997; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=McdwXMf+aVpukum1jWBbRDvrxSrkWixRhMvgP59hNnk=; b=Yv9YWbkk6fo/PHnT0myKzefi2nMbw3F19XJbMEx/xXjIqH6ufqy9+HE4yw48B058Qd 3OW5EMNYH6AwfdCDvDCGEQQ0+8iSoBRxeqaAif/wXwtOrlngtWUNLslNScdmCV3SiGHi UdGgc2DPtFyti4lNGdA/ctBPh+EF+pb0Jp7DlcQM44oyHpv+ryKfGQXQaizuzTF0RMeJ OJdXyXnEtdBu6TY3uOITl+3R51KBQppiqj7UVhFYfSs2hJw6/CIu0xt6zzHSbc4gY2V3 yaOcSSacVCxXkD35e/uc87SNLOrgEB5gPHOl9wK0/QBKP7OqhZQ1N0NFidx76BkCcGKO h3Og== X-Forwarded-Encrypted: i=1; AJvYcCXPYouAyUDxbqqbQVu2SXTTeRaPDC8gasxV0BkYR5xUsBN3u4Q35MNDmplljWOzNVGKFHcuG/OQe9DB082c/ffF5z3ZFztAbLtSpihz X-Gm-Message-State: AOJu0Yyu30+M9rmqAzz0hZzR3MRmZA2E7DN8VAH3RPH20X/5MGRtW55Y uzTAti0bzUwNI5ptjPt/h5AG9TnYtNFJBtq0QOadlTOjUFMjudU0JFAOHzhQais= X-Google-Smtp-Source: AGHT+IFyj16EIZLaKK/87iLqK95suicQ+dQY2KgzMLkd9+nLfafpYvKVTsIdMVkQYiVfRocIZ68TBA== X-Received: by 2002:a05:6512:3e26:b0:52c:dd25:9ac6 with SMTP id 2adb3069b0e04-530bb38cae9mr13232800e87.29.1722958196994; Tue, 06 Aug 2024 08:29:56 -0700 (PDT) Received: from puffmais.c.googlers.com (64.227.90.34.bc.googleusercontent.com. [34.90.227.64]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9d4294fsm555274266b.103.2024.08.06.08.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Aug 2024 08:29:56 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 06 Aug 2024 16:29:46 +0100 Subject: [PATCH 2/2] tty: serial: samsung_tty: cast the interrupt's void *id just once Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240806-samsung-tty-cleanup-v1-2-a68d3abf31fe@linaro.org> References: <20240806-samsung-tty-cleanup-v1-0-a68d3abf31fe@linaro.org> In-Reply-To: <20240806-samsung-tty-cleanup-v1-0-a68d3abf31fe@linaro.org> To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.13.0 The interrupt handler routines and helpers are casting the 'void *' pointer to 'struct exynos_uart_port *' all over the place. There is no need for that, we can do the casting once and keep passing the 'struct exynos_uart_port *', simplifying the code and saving a few lines of code. No functional changes. Signed-off-by: Andr=C3=A9 Draszik Reviewed-by: Tudor Ambarus --- drivers/tty/serial/samsung_tty.c | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_= tty.c index 1c6d0ffe5649..971765aaeaca 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -707,9 +707,8 @@ static void enable_rx_pio(struct s3c24xx_uart_port *our= port) =20 static void s3c24xx_serial_rx_drain_fifo(struct s3c24xx_uart_port *ourport= ); =20 -static irqreturn_t s3c24xx_serial_rx_chars_dma(void *dev_id) +static irqreturn_t s3c24xx_serial_rx_chars_dma(struct s3c24xx_uart_port *o= urport) { - struct s3c24xx_uart_port *ourport =3D dev_id; struct uart_port *port =3D &ourport->port; struct s3c24xx_uart_dma *dma =3D ourport->dma; struct tty_struct *tty =3D tty_port_tty_get(&ourport->port.state->port); @@ -843,9 +842,8 @@ static void s3c24xx_serial_rx_drain_fifo(struct s3c24xx= _uart_port *ourport) tty_flip_buffer_push(&port->state->port); } =20 -static irqreturn_t s3c24xx_serial_rx_chars_pio(void *dev_id) +static irqreturn_t s3c24xx_serial_rx_chars_pio(struct s3c24xx_uart_port *o= urport) { - struct s3c24xx_uart_port *ourport =3D dev_id; struct uart_port *port =3D &ourport->port; =20 uart_port_lock(port); @@ -855,13 +853,11 @@ static irqreturn_t s3c24xx_serial_rx_chars_pio(void *= dev_id) return IRQ_HANDLED; } =20 -static irqreturn_t s3c24xx_serial_rx_irq(void *dev_id) +static irqreturn_t s3c24xx_serial_rx_irq(struct s3c24xx_uart_port *ourport) { - struct s3c24xx_uart_port *ourport =3D dev_id; - if (ourport->dma && ourport->dma->rx_chan) - return s3c24xx_serial_rx_chars_dma(dev_id); - return s3c24xx_serial_rx_chars_pio(dev_id); + return s3c24xx_serial_rx_chars_dma(ourport); + return s3c24xx_serial_rx_chars_pio(ourport); } =20 static void s3c24xx_serial_tx_chars(struct s3c24xx_uart_port *ourport) @@ -928,9 +924,8 @@ static void s3c24xx_serial_tx_chars(struct s3c24xx_uart= _port *ourport) s3c24xx_serial_stop_tx(port); } =20 -static irqreturn_t s3c24xx_serial_tx_irq(void *id) +static irqreturn_t s3c24xx_serial_tx_irq(struct s3c24xx_uart_port *ourport) { - struct s3c24xx_uart_port *ourport =3D id; struct uart_port *port =3D &ourport->port; =20 uart_port_lock(port); @@ -950,11 +945,11 @@ static irqreturn_t s3c64xx_serial_handle_irq(int irq,= void *id) irqreturn_t ret =3D IRQ_HANDLED; =20 if (pend & S3C64XX_UINTM_RXD_MSK) { - ret =3D s3c24xx_serial_rx_irq(id); + ret =3D s3c24xx_serial_rx_irq(ourport); wr_regl(port, S3C64XX_UINTP, S3C64XX_UINTM_RXD_MSK); } if (pend & S3C64XX_UINTM_TXD_MSK) { - ret =3D s3c24xx_serial_tx_irq(id); + ret =3D s3c24xx_serial_tx_irq(ourport); wr_regl(port, S3C64XX_UINTP, S3C64XX_UINTM_TXD_MSK); } return ret; @@ -971,11 +966,11 @@ static irqreturn_t apple_serial_handle_irq(int irq, v= oid *id) if (pend & (APPLE_S5L_UTRSTAT_RXTHRESH | APPLE_S5L_UTRSTAT_RXTO)) { wr_regl(port, S3C2410_UTRSTAT, APPLE_S5L_UTRSTAT_RXTHRESH | APPLE_S5L_UTRSTAT_RXTO); - ret =3D s3c24xx_serial_rx_irq(id); + ret =3D s3c24xx_serial_rx_irq(ourport); } if (pend & APPLE_S5L_UTRSTAT_TXTHRESH) { wr_regl(port, S3C2410_UTRSTAT, APPLE_S5L_UTRSTAT_TXTHRESH); - ret =3D s3c24xx_serial_tx_irq(id); + ret =3D s3c24xx_serial_tx_irq(ourport); } =20 return ret; --=20 2.46.0.rc2.264.g509ed76dc8-goog