From nobody Thu Sep 19 01:46:09 2024 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 868B014AD20; Mon, 5 Aug 2024 20:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722889268; cv=none; b=a6HTx2B9rW/DPKwQXebFu2Jt8fnBPL0qljfmxClC3L76D3MNh3z/vESqV+1/aeLIQ/UHM44wvkG5uBDtLvUNP3Um8nksB2P29c+pc5RPWfeoWWK68LjnLxJN2rIMvoR2egWKXVW2pYK+6sSwaK+fsZSUs3+VF96I2B53JDXrAXw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722889268; c=relaxed/simple; bh=W/vR+PQRmt0Z1mLPNPDSv+8wyLx4X5vstVzNBWZLLY4=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=AVaXPsipfzNG25A2Ardgl+suZVNSyN7UdCRhym/Q+/ksjxg0n8LJglU/r5O5LnMJueUUuReAQIXvE/om3LXDgimwss+zp6BVsa/lofng8xWeplj//dM9UrC1mI7pKXu9nzzh6/PUAaSeowmBwi1c/3BolQosp1k1YQ4wXarZ6bs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=OSnRosY/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="OSnRosY/" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 475B9Bxo014256; Mon, 5 Aug 2024 20:20:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=egZuFsuZto1SqcIaxNFXzN 5CTbrwJyyfmgxzlobuFsM=; b=OSnRosY/Ow4cKWaocUuBFyMN0H9jByHdqdXOJK HeP4x/k2kTWbTCcTtQCgXy7WpDXYIzD0c3YaXqs2IyBpVd2c5wdLVWfTyR0pCJwY omzSZAvVyWB6IV3zCyjKwKyyLyZYhmC2gqdbrU8riJUSIprG0ekv/meTf9db6pxJ zQOiAn/s9thh9ny/4yZACfVnQqy9mYeK+/JdUOZ03Q9zBrDTdNreT86L57axJo3f y9izVwqxbp8YeLTWeL+JDgID3kGhcQuX6KeNntBue/oysFYlZ4ngDuVxqUvVe7nc BtersA5h1kM0wFKRO+h6MAuMPwve3FkkfqiA7jt9WZuz59tQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40sdu9520g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Aug 2024 20:20:27 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 475KKQGM002188 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Aug 2024 20:20:26 GMT Received: from abhinavk-linux1.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 5 Aug 2024 13:20:26 -0700 From: Abhinav Kumar To: , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , "Daniel Vetter" , Kuogee Hsieh , Tanmay Shah , Guenter Roeck CC: , , , , , , Chandan Uddaraju , , Subject: [PATCH v3] drm/msm/dp: fix the max supported bpp logic Date: Mon, 5 Aug 2024 13:20:08 -0700 Message-ID: <20240805202009.1120981-1-quic_abhinavk@quicinc.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: RFa42TrQE1efk3rUkDfVjwSDV3l3V7s1 X-Proofpoint-GUID: RFa42TrQE1efk3rUkDfVjwSDV3l3V7s1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-05_08,2024-08-02_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 clxscore=1015 phishscore=0 spamscore=0 bulkscore=0 mlxscore=0 impostorscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2408050144 Content-Type: text/plain; charset="utf-8" Fix the dp_panel_get_supported_bpp() API to return the minimum supported bpp correctly for relevant cases and use this API to correct the behavior of DP driver which hard-codes the max supported bpp to 30. This is incorrect because the number of lanes and max data rate supported by the lanes need to be taken into account. Replace the hardcoded limit with the appropriate math which accounts for the accurate number of lanes and max data rate. changes in v2: - Fix the dp_panel_get_supported_bpp() and use it - Drop the max_t usage as dp_panel_get_supported_bpp() already returns the min_bpp correctly now changes in v3: - replace min_t with just min as all params are u32 Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Reported-by: Dmitry Baryshkov Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/43 Tested-by: Dmitry Baryshkov # SM8350-HDK Signed-off-by: Stephen Boyd Signed-off-by: Abhinav Kumar Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_panel.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_= panel.c index a916b5f3b317..6ff6c9ef351f 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_panel.c @@ -90,22 +90,22 @@ static int dp_panel_read_dpcd(struct dp_panel *dp_panel) static u32 dp_panel_get_supported_bpp(struct dp_panel *dp_panel, u32 mode_edid_bpp, u32 mode_pclk_khz) { - struct dp_link_info *link_info; + const struct dp_link_info *link_info; const u32 max_supported_bpp =3D 30, min_supported_bpp =3D 18; - u32 bpp =3D 0, data_rate_khz =3D 0; + u32 bpp, data_rate_khz; =20 - bpp =3D min_t(u32, mode_edid_bpp, max_supported_bpp); + bpp =3D min(mode_edid_bpp, max_supported_bpp); =20 link_info =3D &dp_panel->link_info; data_rate_khz =3D link_info->num_lanes * link_info->rate * 8; =20 - while (bpp > min_supported_bpp) { + do { if (mode_pclk_khz * bpp <=3D data_rate_khz) - break; + return bpp; bpp -=3D 6; - } + } while (bpp > min_supported_bpp); =20 - return bpp; + return min_supported_bpp; } =20 int dp_panel_read_sink_caps(struct dp_panel *dp_panel, @@ -423,8 +423,9 @@ int dp_panel_init_panel_info(struct dp_panel *dp_panel) drm_mode->clock); drm_dbg_dp(panel->drm_dev, "bpp =3D %d\n", dp_panel->dp_mode.bpp); =20 - dp_panel->dp_mode.bpp =3D max_t(u32, 18, - min_t(u32, dp_panel->dp_mode.bpp, 30)); + dp_panel->dp_mode.bpp =3D dp_panel_get_mode_bpp(dp_panel, dp_panel->dp_mo= de.bpp, + dp_panel->dp_mode.drm_mode.clock); + drm_dbg_dp(panel->drm_dev, "updated bpp =3D %d\n", dp_panel->dp_mode.bpp); =20 --=20 2.44.0