From nobody Fri Dec 19 20:54:31 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8EB715C13F for ; Mon, 5 Aug 2024 16:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722875020; cv=none; b=lOLX5JwBW/cPDwikqtWC+zpECfF2JWrL5Ezin0anqVpuoGIqGLqEM5v3yqZNSYbmnxubcOyrWSGL1jNqAfWS3lfVriTkUSb7L3h6lO6a4AhoyUStCAOxDKflvPD/AFrP31mf6StQ3ls3BM//L7U5bM9p/gd0bzyH2HTAupS4Kug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722875020; c=relaxed/simple; bh=2LkBDOQ8buBKxMXFJgvltXNwl1liYgvvPx8y3g/ioMs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Rhq+Aebab7Qk4rGinsYjlryB1cT6AZeGXO55qUU5HTNS9yaP4o2RiE+QjA+ZOqhhbZZMAj+in5P1SNpJaUd89H5beQqn7LAnl0Rb6fHsgYn5qhzi9I3DjJpdKQoOdHzucEBDAQgK/XBm6KoEbXmmbVK8OgWHCpcleZcVYPrXvi4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sb0Uh-00075N-8q for linux-kernel@vger.kernel.org; Mon, 05 Aug 2024 18:23:35 +0200 Received: from [2a0a:edc0:0:b01:1d::7b] (helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sb0Ug-004klP-LB for linux-kernel@vger.kernel.org; Mon, 05 Aug 2024 18:23:34 +0200 Received: from dspam.blackshift.org (localhost [127.0.0.1]) by bjornoya.blackshift.org (Postfix) with SMTP id 567933173DE for ; Mon, 05 Aug 2024 16:23:34 +0000 (UTC) Received: from hardanger.blackshift.org (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by bjornoya.blackshift.org (Postfix) with ESMTPS id DE7743173C0; Mon, 05 Aug 2024 16:23:31 +0000 (UTC) Received: from [172.20.34.65] (localhost [::1]) by hardanger.blackshift.org (OpenSMTPD) with ESMTP id 3db2daf9; Mon, 5 Aug 2024 16:23:31 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 05 Aug 2024 18:23:20 +0200 Subject: [PATCH 1/2] can: mcp251xfd: fix ring configuration when switching from CAN-CC to CAN-FD mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240805-mcp251xfd-fix-ringconfig-v1-1-72086f0ca5ee@pengutronix.de> References: <20240805-mcp251xfd-fix-ringconfig-v1-0-72086f0ca5ee@pengutronix.de> In-Reply-To: <20240805-mcp251xfd-fix-ringconfig-v1-0-72086f0ca5ee@pengutronix.de> To: Manivannan Sadhasivam , Thomas Kopp , Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-37811 X-Developer-Signature: v=1; a=openpgp-sha256; l=2997; i=mkl@pengutronix.de; h=from:subject:message-id; bh=2LkBDOQ8buBKxMXFJgvltXNwl1liYgvvPx8y3g/ioMs=; b=owEBbQGS/pANAwAKASg4oj56LbxvAcsmYgBmsPx9EX5/qlqur3k/YdflrNGYBunMPQ5NUQFw/ IrGn1TspSSJATMEAAEKAB0WIQRQQLqG4LYE3Sm8Pl8oOKI+ei28bwUCZrD8fQAKCRAoOKI+ei28 b1MPB/4ugnSgc7SodagaDJFNceWpEnIgnUlEg4mpR10YIX5/kO032ZXxAjwTcn2iYDnEqmzCpxG dmEwDs30MyK1v5/fnS8FZJ51vOtPFkOkzS0U4HsD6qmuY4ZA80durUjcbUkJf50namuFiCAMKa3 Gi8dIIIq5+vz+vdJrpeeZVIjXTx3ImJfN9w2VnM3Z4zm08SKJqPXKre1/aw/5PBTPD9sM6DHF8+ xb+fcDrwTlxKRoLEm7ulVPu+zwRv1B6AjjjNHtBxBLsds1UJ3eXXnKn7kD9jw0nlq1VtL/YRRit u+igL6YkmsW4cajCZKIXwa0y+073EUw1uV8TMlFcGcpMHMdb X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org If the ring (rx, tx) and/or coalescing parameters (rx-frames-irq, tx-frames-irq) have been configured while the interface was in CAN-CC mode, but the interface is brought up in CAN-FD mode, the ring parameters might be too big. Use the default CAN-FD values in this case. Fixes: 9263c2e92be9 ("can: mcp251xfd: ring: add support for runtime configu= rable RX/TX ring parameters") Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/mcp251xfd-ram.c | 11 ++++++++++- drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c | 20 +++++++++++++++++--- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-ram.c b/drivers/net/ca= n/spi/mcp251xfd/mcp251xfd-ram.c index 9e8e82cdba46..61b0d6fa52dd 100644 --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-ram.c +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-ram.c @@ -97,7 +97,16 @@ void can_ram_get_layout(struct can_ram_layout *layout, if (ring) { u8 num_rx_coalesce =3D 0, num_tx_coalesce =3D 0; =20 - num_rx =3D can_ram_rounddown_pow_of_two(config, &config->rx, 0, ring->rx= _pending); + /* If the ring parameters have been configured in + * CAN-CC mode, but and we are in CAN-FD mode now, + * they might be to big. Use the default CAN-FD values + * in this case. + */ + num_rx =3D ring->rx_pending; + if (num_rx > layout->max_rx) + num_rx =3D layout->default_rx; + + num_rx =3D can_ram_rounddown_pow_of_two(config, &config->rx, 0, num_rx); =20 /* The ethtool doc says: * To disable coalescing, set usecs =3D 0 and max_frames =3D 1. diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c b/drivers/net/c= an/spi/mcp251xfd/mcp251xfd-ring.c index 7bd2bcb5cf87..f72582d4d3e8 100644 --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c @@ -469,11 +469,25 @@ int mcp251xfd_ring_alloc(struct mcp251xfd_priv *priv) =20 /* switching from CAN-2.0 to CAN-FD mode or vice versa */ if (fd_mode !=3D test_bit(MCP251XFD_FLAGS_FD_MODE, priv->flags)) { + const struct ethtool_ringparam ring =3D { + .rx_pending =3D priv->rx_obj_num, + .tx_pending =3D priv->tx->obj_num, + }; + const struct ethtool_coalesce ec =3D { + .rx_coalesce_usecs_irq =3D priv->rx_coalesce_usecs_irq, + .rx_max_coalesced_frames_irq =3D priv->rx_obj_num_coalesce_irq, + .tx_coalesce_usecs_irq =3D priv->tx_coalesce_usecs_irq, + .tx_max_coalesced_frames_irq =3D priv->tx_obj_num_coalesce_irq, + }; struct can_ram_layout layout; =20 - can_ram_get_layout(&layout, &mcp251xfd_ram_config, NULL, NULL, fd_mode); - priv->rx_obj_num =3D layout.default_rx; - tx_ring->obj_num =3D layout.default_tx; + can_ram_get_layout(&layout, &mcp251xfd_ram_config, &ring, &ec, fd_mode); + + priv->rx_obj_num =3D layout.cur_rx; + priv->rx_obj_num_coalesce_irq =3D layout.rx_coalesce; + + tx_ring->obj_num =3D layout.cur_tx; + priv->tx_obj_num_coalesce_irq =3D layout.tx_coalesce; } =20 if (fd_mode) { --=20 2.43.0 From nobody Fri Dec 19 20:54:31 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FAA115C144 for ; Mon, 5 Aug 2024 16:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722875019; cv=none; b=a9pOa4BzFnenxoB6/UtEIazO2JEWHRjuAPBxEE2alkq8+FiWfzOZPWKmQteTRl8IbRcrKyIzX1G3JeAJv37T08X2+yxw1b861683GXhspOfkNsVbG3cTTyHKHZXm60ZF6tOXBowqfQE8wJI96rsmYonsQTSo+bPU0s+yYeA08vw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722875019; c=relaxed/simple; bh=PEMEOMWCp5/tFfsda7z8jK3ZnwSyWrntpuX+k3ze0FQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iKQCk9iMi+FsveIg5nuihclJgRT4SX/JHU95fcOPHTbrLgUvWZb2BzEBgZNAq3tcLoojK0GVo9O6+9R8hGrSUDyD2Wy15KlumxUzEX7Z356sQBkSv6DP38f+zOtb4Fwz8BH2XtuKy8fqwATYX7gSt3v+33dS1uHm+22XFNJhU7o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sb0Uh-00075U-BV for linux-kernel@vger.kernel.org; Mon, 05 Aug 2024 18:23:35 +0200 Received: from [2a0a:edc0:0:b01:1d::7b] (helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sb0Ug-004klT-O8 for linux-kernel@vger.kernel.org; Mon, 05 Aug 2024 18:23:34 +0200 Received: from dspam.blackshift.org (localhost [127.0.0.1]) by bjornoya.blackshift.org (Postfix) with SMTP id 72DE03173DF for ; Mon, 05 Aug 2024 16:23:34 +0000 (UTC) Received: from hardanger.blackshift.org (unknown [172.20.34.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by bjornoya.blackshift.org (Postfix) with ESMTPS id 0592B3173C2; Mon, 05 Aug 2024 16:23:32 +0000 (UTC) Received: from [172.20.34.65] (localhost [::1]) by hardanger.blackshift.org (OpenSMTPD) with ESMTP id 1fd71a0e; Mon, 5 Aug 2024 16:23:31 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 05 Aug 2024 18:23:21 +0200 Subject: [PATCH 2/2] can: mcp251xfd: mcp251xfd_ring_init(): check TX-coalescing configuration Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240805-mcp251xfd-fix-ringconfig-v1-2-72086f0ca5ee@pengutronix.de> References: <20240805-mcp251xfd-fix-ringconfig-v1-0-72086f0ca5ee@pengutronix.de> In-Reply-To: <20240805-mcp251xfd-fix-ringconfig-v1-0-72086f0ca5ee@pengutronix.de> To: Manivannan Sadhasivam , Thomas Kopp , Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-37811 X-Developer-Signature: v=1; a=openpgp-sha256; l=1856; i=mkl@pengutronix.de; h=from:subject:message-id; bh=PEMEOMWCp5/tFfsda7z8jK3ZnwSyWrntpuX+k3ze0FQ=; b=owEBbQGS/pANAwAKASg4oj56LbxvAcsmYgBmsPyAzhilXHlO6oxOzg0A8c9h0F9536GELXa1j 3ycIzi8c4iJATMEAAEKAB0WIQRQQLqG4LYE3Sm8Pl8oOKI+ei28bwUCZrD8gAAKCRAoOKI+ei28 b3TZB/9JT0Tkb4c3aoQAdICWytGuvH79wIkROi1i/RfnZ5SYmhusvPgka+MsHSyWXT92THXmaR+ FFhVmVlJoXQiOaABsI+IbotpeDTmXuzh8iUSQ/niavxiy5w9ugO13vUF9BGsuCH1Nqe5zT515Xv ev6eZIk721u0JDOBi9Y0cIQLPHiSLphuNnsxa/7KyqKZ3E0n+7kHNXfgDbXI+VBjhikv+aQNDSW wGF9zzMvmUvcoe4ZjJ3Bg/Nbl/HlntH6BOGPwdB9glP/kQQ3ChAdUCb/nYq5bBIhLIYXdW2xIHu JNtyPe/oPMD+5HYM8cQxhopuOr3yJ2V/0KQji9h99jj1bl/G X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org When changing the interface from CAN-CC to CAN-FD mode the old coalescing parameters are re-used. This might cause problem, as the configured parameters are too big for CAN-FD mode. During testing an invalid TX coalescing configuration has been seen. The problem should be been fixed in the previous patch, but add a safeguard here to ensure that the number of TEF coalescing buffers (if configured) is exactly the half of all TEF buffers. Signed-off-by: Marc Kleine-Budde --- drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c b/drivers/net/c= an/spi/mcp251xfd/mcp251xfd-ring.c index f72582d4d3e8..83c18035b2a2 100644 --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-ring.c @@ -290,7 +290,7 @@ int mcp251xfd_ring_init(struct mcp251xfd_priv *priv) const struct mcp251xfd_rx_ring *rx_ring; u16 base =3D 0, ram_used; u8 fifo_nr =3D 1; - int i; + int err =3D 0, i; =20 netdev_reset_queue(priv->ndev); =20 @@ -386,10 +386,18 @@ int mcp251xfd_ring_init(struct mcp251xfd_priv *priv) netdev_err(priv->ndev, "Error during ring configuration, using more RAM (%u bytes) than ava= ilable (%u bytes).\n", ram_used, MCP251XFD_RAM_SIZE); - return -ENOMEM; + err =3D -ENOMEM; } =20 - return 0; + if (priv->tx_obj_num_coalesce_irq && + priv->tx_obj_num_coalesce_irq * 2 !=3D priv->tx->obj_num) { + netdev_err(priv->ndev, + "Error during ring configuration, number of TEF coalescing buffers (= %u) must be half of TEF buffers (%u).\n", + priv->tx_obj_num_coalesce_irq, priv->tx->obj_num); + err =3D -EINVAL; + } + + return err; } =20 void mcp251xfd_ring_free(struct mcp251xfd_priv *priv) --=20 2.43.0