From nobody Fri Dec 19 22:03:10 2025 Received: from mail.rosalinux.ru (mail.rosalinux.ru [195.19.76.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD36D28DCC for ; Sun, 4 Aug 2024 13:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.19.76.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722779934; cv=none; b=qNHfCY+N8PbO6BNAdxs9uLZEcsuPdB1aZoc5tzPCmU3yjmVhtZgbJnA7hrXePIkTcnjd3MgDCsB9TJJGsSrtmyDRs5V02zezVSBDdx5PSsv3zCr7lE6ssV07FDZSS8KxNUt5tpYHpZBRdvnBfrFhfI2E3AGnCSCQaUhYoer4xW4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722779934; c=relaxed/simple; bh=reEOSEE9hk3i3ZFXxbjqi/jPh409UkRWadUJHebS8XI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LJpiafDyBOEkArVG9X7+N6skCURIO4z2EMtUYGMzFHCd1wv4wuaSypBdhrVFSMliE0NtRGFltNVSylShJtbA4pI6lkG5GjrLn7etPcYQ7NxaMAm5gBmhVQ3kOx4Am5No/NPvrtawffnPk2m0v1qVkll2/EbvczMkNY+YxO7RhZY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=rosalinux.ru; spf=pass smtp.mailfrom=rosalinux.ru; dkim=pass (2048-bit key) header.d=rosalinux.ru header.i=@rosalinux.ru header.b=VlJEH5hA; arc=none smtp.client-ip=195.19.76.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=rosalinux.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rosalinux.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rosalinux.ru header.i=@rosalinux.ru header.b="VlJEH5hA" Received: from localhost (localhost [127.0.0.1]) by mail.rosalinux.ru (Postfix) with ESMTP id 65B60DFA330A7; Sun, 4 Aug 2024 16:58:47 +0300 (MSK) Received: from mail.rosalinux.ru ([127.0.0.1]) by localhost (mail.rosalinux.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id V0CqRZtZYTbG; Sun, 4 Aug 2024 16:58:47 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.rosalinux.ru (Postfix) with ESMTP id 2F402DFA330AE; Sun, 4 Aug 2024 16:58:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.rosalinux.ru 2F402DFA330AE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rosalinux.ru; s=1D4BB666-A0F1-11EB-A1A2-F53579C7F503; t=1722779927; bh=darQ1Ny576F9H9QNqgko9qEevQrfo0NSfm0joyfHG88=; h=From:To:Date:Message-ID:MIME-Version; b=VlJEH5hAs5jukBtwUzHSo3H6uNuxR2ONwnh8Oi7KThkafmYXsxWNVh5kKJjxl4lec KB6ubyt2sujZDqjJ8VM2XLYdIOPTvF1gU1SfHEN3qkl747acKReBAU7rNzsm0thjJu OUs2dpABVS7/Mrs2juoDQwSbTMe8hobnBcRVvYJD8u6DN+G6rWxcVfslW5Qub4xv5l BoHImQXDqHXvOhSgAXvHtNG2IJywqHVIxNgfd/HDw0YqNGeqSIpqKJyd3kYNDkQOxi eReSQQUcr/b/Xzge4YS6ca5ub14/Cxp8ukH1kE2uVwRIP4uWicC+HUVpuvRnA69AsS GOocwYTgKjMyA== X-Virus-Scanned: amavisd-new at rosalinux.ru Received: from mail.rosalinux.ru ([127.0.0.1]) by localhost (mail.rosalinux.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1yrFGckKrxEQ; Sun, 4 Aug 2024 16:58:47 +0300 (MSK) Received: from localhost.localdomain (unknown [89.169.48.235]) by mail.rosalinux.ru (Postfix) with ESMTPSA id C7372DFA330A7; Sun, 4 Aug 2024 16:58:46 +0300 (MSK) From: Mikhail Lobanov To: Russell King Cc: Mikhail Lobanov , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , Thierry Reding , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] i2c: Add error handling for drm_hdmi_avi_infoframe_from_display_mode in tda998x_write_avi Date: Sun, 4 Aug 2024 09:57:35 -0400 Message-ID: <20240804135737.62663-1-m.lobanov@rosalinux.ru> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch adds error handling for the return value of the drm_hdmi_avi_inf= oframe_from_display_mode function within the tda998x_write_avi function. The function's return value is check= ed to ensure that any errors=20 encountered during the generation of the AVI infoframe are properly handled= . If the function fails, an error=20 message is logged and the function exits early to avoid further operations = with invalid data. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 13d0add333af ("drm/edid: Pass connector to AVI infoframe functions") Signed-off-by: Mikhail Lobanov --- drivers/gpu/drm/i2c/tda998x_drv.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998= x_drv.c index d8d7de18dd65..6d8b3654d9a9 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -860,8 +860,13 @@ tda998x_write_avi(struct tda998x_priv *priv, const str= uct drm_display_mode *mode { union hdmi_infoframe frame; =20 - drm_hdmi_avi_infoframe_from_display_mode(&frame.avi, + err =3D drm_hdmi_avi_infoframe_from_display_mode(&frame.avi, &priv->connector, mode); + if (err < 0) { + dev_err(&priv->connector.dev, "failed to get AVI infoframe: %d\n", err); + return; + } + frame.avi.quantization_range =3D HDMI_QUANTIZATION_RANGE_FULL; drm_hdmi_avi_infoframe_quant_range(&frame.avi, &priv->connector, mode, priv->rgb_quant_range); --=20 2.43.0