From nobody Thu Dec 18 01:24:00 2025
Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com
 [209.85.167.182])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 638801BF2A;
	Sun,  4 Aug 2024 06:16:16 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
 arc=none smtp.client-ip=209.85.167.182
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1722752178; cv=none;
 b=OnyVQ4LsAXlayNbnhqFmzVcanTt/uxzrVh/8LmE6SNRwD9oT0wINxI7rlsE4C3TDQB/0ibSkvdvfrUa8YYX8AB7DEaH+uYn8x1t7MFNRqBGuNz4OHYpjnwBx8PkgC1Br814b/eKpd5TVvwfiYtx/70hfFhoz5rKXCWNWQaTUT/8=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1722752178; c=relaxed/simple;
	bh=zo1jPPGZRyh7xdwbknWlWhN3yC+6aa+tj0B+EzgtMWE=;
	h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:
	 MIME-Version;
 b=ePLCclk6TCYrZ9lw7B8aOgmeU8cFxsb55+B2uXPIikg0c3KP7rOJDrF7xCvavnE/DUloMkoDwSUAin+lLk1/01rmy4Qzw3hb7XWuQwhWMoLPmDB77nLDEr7DL8L5v19XPw5ihBKN9BBR1J4puwhQgwiZU/8GGATPpp3MMWngBSM=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
 dmarc=pass (p=none dis=none) header.from=gmail.com;
 spf=pass smtp.mailfrom=gmail.com;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b=j+u8VSaW; arc=none smtp.client-ip=209.85.167.182
Authentication-Results: smtp.subspace.kernel.org;
 dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
 spf=pass smtp.mailfrom=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="j+u8VSaW"
Received: by mail-oi1-f182.google.com with SMTP id
 5614622812f47-3db1d4dab7fso5807553b6e.1;
        Sat, 03 Aug 2024 23:16:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1722752175; x=1723356975;
 darn=vger.kernel.org;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:from:to:cc:subject:date
         :message-id:reply-to;
        bh=Fnql3FbykIepF8kn8jYdsbjwm/J1dth3YluSeiLe3RM=;
        b=j+u8VSaW2BE9QN6UfzWZNNRGCEgrlqOmVCrvUASkaS+DIbw4Zzmc39B9h+LA1t/9Li
         JYPiy+W9JgEHc8H0D32i/AJE6mQw7kYdluLl3anob739OPILpWZNn5zxc1oqineL+v+N
         HhEmrBM025FUqOrI7MPjPktmggt4aqJ+X7n5oasEiDe7iVTGhehiB17v/PuCybjuYgur
         UUpzWuXnxtIvpq/k05k6NTILVr52y9MuORkKHmE/K4d5NZMS7p8d+3ErGHC8qiRko4n0
         C3a9zIdQ8SvV0dim2MUbxTeh2MGBoZLk07EaC/t+vvnrn5OTLZdi876OTFdQOh7lP2qw
         qYWg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1722752175; x=1723356975;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
         :subject:date:message-id:reply-to;
        bh=Fnql3FbykIepF8kn8jYdsbjwm/J1dth3YluSeiLe3RM=;
        b=BDxD8fy/fYcDdBImQzOtWlXA2dyqOA5ojHNrEK3Hiyprwy2TNptPmPnvT4buInajmq
         XjqTP/gvRP6DgwlNUY09sQT3KRLBiTCPjWJuD6Vt8gob4dAceynZsqFrEJmvEeTsEps4
         HKib6d4HSV/26o71Bj8J73FLoorQEtxvyyrB6WcTWi+vaMft4bWL0oJe+dVvu1fxHwoR
         SOLrOb0c9tFkadAQ8KVKlMPm78PAXw4sxCvu/q3Fln0xgzrFVg4S5Aw7tckq/jPKWbQS
         11lxKg4HadJ3fJcR3KQFEg2wYmb8kBObnuDRBFh1tBlihD0GysSWbMysIYOyvbnsHlGj
         C1CQ==
X-Forwarded-Encrypted: i=1;
 AJvYcCXShRf6QYOXzwwAuXVwr5MrlitA/TlY027J1C6Im6GhkVrhLRIoSBDuHk0fAYd/qa+Y/pic6XtNHAwKpDZhOcMpzR/XFXYpc/pOsQ==
X-Gm-Message-State: AOJu0YwgOrs91f70ApM8Np9nm5FMu3w/ihQaM7s3zYJ8L/9Rnw6gCHjj
	1zc477pq0txdbNzrxvPVNbMqqJNweBZWIyQyH/WG3gZRqxcr2XWmZ/2EYrSR
X-Google-Smtp-Source: 
 AGHT+IEJzz1gHaqM2q/OdiVr5f66AvMuo9n4CECuHPcEhxtVPnmU2yXtswZqOsJRNmBEGBzil0HePw==
X-Received: by 2002:a05:6808:1a01:b0:3da:c428:1c51 with SMTP id
 5614622812f47-3db557fc32dmr12228412b6e.8.1722752175351;
        Sat, 03 Aug 2024 23:16:15 -0700 (PDT)
Received: from noel.flets-west.jp ([2405:6586:4480:a10:167:9818:d778:5c14])
        by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-1ff58f29ef4sm44194195ad.14.2024.08.03.23.16.11
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Sat, 03 Aug 2024 23:16:15 -0700 (PDT)
From: Hironori KIKUCHI <kikuchan98@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Hironori KIKUCHI <kikuchan98@gmail.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <quic_jesszhan@quicinc.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org
Subject: [PATCH v4 4/5] drm/panel: st7701: Add support for SPI for
 configuration
Date: Sun,  4 Aug 2024 15:14:48 +0900
Message-ID: <20240804061503.881283-5-kikuchan98@gmail.com>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <20240804061503.881283-1-kikuchan98@gmail.com>
References: <20240804061503.881283-1-kikuchan98@gmail.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

The ST7701 supports not only MIPI DSI, but also SPI as an interface
for configuration. To support a panel connected via SPI with an RGB
parallel interface, add support for SPI using MIPI DBI helpers.

Signed-off-by: Hironori KIKUCHI <kikuchan98@gmail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 drivers/gpu/drm/panel/Kconfig                 |   3 +-
 drivers/gpu/drm/panel/panel-sitronix-st7701.c | 123 +++++++++++++++---
 2 files changed, 110 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 9f49b0189d3..5d83ddc06ec 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -784,7 +784,8 @@ config DRM_PANEL_SHARP_LS060T1SX01
 config DRM_PANEL_SITRONIX_ST7701
 	tristate "Sitronix ST7701 panel driver"
 	depends on OF
-	depends on DRM_MIPI_DSI
+	depends on SPI || DRM_MIPI_DSI
+	select DRM_MIPI_DBI if SPI
 	depends on BACKLIGHT_CLASS_DEVICE
 	help
 	  Say Y here if you want to enable support for the Sitronix
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7701.c b/drivers/gpu/dr=
m/panel/panel-sitronix-st7701.c
index a0644f7a4c8..9e83a760a8a 100644
--- a/drivers/gpu/drm/panel/panel-sitronix-st7701.c
+++ b/drivers/gpu/drm/panel/panel-sitronix-st7701.c
@@ -4,6 +4,7 @@
  * Author: Jagan Teki <jagan@amarulasolutions.com>
  */
=20
+#include <drm/drm_mipi_dbi.h>
 #include <drm/drm_mipi_dsi.h>
 #include <drm/drm_modes.h>
 #include <drm/drm_panel.h>
@@ -14,6 +15,7 @@
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/regulator/consumer.h>
+#include <linux/spi/spi.h>
=20
 #include <video/mipi_display.h>
=20
@@ -130,12 +132,16 @@ struct st7701_panel_desc {
 struct st7701 {
 	struct drm_panel panel;
 	struct mipi_dsi_device *dsi;
+	struct mipi_dbi dbi;
 	const struct st7701_panel_desc *desc;
=20
 	struct regulator_bulk_data supplies[2];
 	struct gpio_desc *reset;
 	unsigned int sleep_delay;
 	enum drm_panel_orientation orientation;
+
+	int (*write_command)(struct st7701 *st7701, u8 cmd, const u8 *seq,
+			     size_t len);
 };
=20
 static inline struct st7701 *panel_to_st7701(struct drm_panel *panel)
@@ -143,16 +149,22 @@ static inline struct st7701 *panel_to_st7701(struct d=
rm_panel *panel)
 	return container_of(panel, struct st7701, panel);
 }
=20
-static inline int st7701_dsi_write(struct st7701 *st7701, const void *seq,
-				   size_t len)
+static int st7701_dsi_write(struct st7701 *st7701, u8 cmd, const u8 *seq,
+			    size_t len)
 {
-	return mipi_dsi_dcs_write_buffer(st7701->dsi, seq, len);
+	return mipi_dsi_dcs_write(st7701->dsi, cmd, seq, len);
 }
=20
-#define ST7701_WRITE(st7701, seq...)				\
-	{							\
-		const u8 d[] =3D { seq };				\
-		st7701_dsi_write(st7701, d, ARRAY_SIZE(d));	\
+static int st7701_dbi_write(struct st7701 *st7701, u8 cmd, const u8 *seq,
+			    size_t len)
+{
+	return mipi_dbi_command_stackbuf(&st7701->dbi, cmd, seq, len);
+}
+
+#define ST7701_WRITE(st7701, cmd, seq...)				\
+	{								\
+		const u8 d[] =3D { seq };					\
+		st7701->write_command(st7701, cmd, d, ARRAY_SIZE(d));	\
 	}
=20
 static u8 st7701_vgls_map(struct st7701 *st7701)
@@ -211,10 +223,10 @@ static void st7701_init_sequence(struct st7701 *st770=
1)
 	/* Command2, BK0 */
 	st7701_switch_cmd_bkx(st7701, true, 0);
=20
-	mipi_dsi_dcs_write(st7701->dsi, ST7701_CMD2_BK0_PVGAMCTRL,
-			   desc->pv_gamma, ARRAY_SIZE(desc->pv_gamma));
-	mipi_dsi_dcs_write(st7701->dsi, ST7701_CMD2_BK0_NVGAMCTRL,
-			   desc->nv_gamma, ARRAY_SIZE(desc->nv_gamma));
+	st7701->write_command(st7701, ST7701_CMD2_BK0_PVGAMCTRL, desc->pv_gamma,
+			      ARRAY_SIZE(desc->pv_gamma));
+	st7701->write_command(st7701, ST7701_CMD2_BK0_NVGAMCTRL, desc->nv_gamma,
+			      ARRAY_SIZE(desc->nv_gamma));
 	/*
 	 * Vertical line count configuration:
 	 * Line[6:0]: select number of vertical lines of the TFT matrix in
@@ -1051,6 +1063,10 @@ static int st7701_dsi_probe(struct mipi_dsi_device *=
dsi)
=20
 	st7701 =3D dev_get_drvdata(&dsi->dev);
 	st7701->dsi =3D dsi;
+	st7701->write_command =3D st7701_dsi_write;
+
+	if (!st7701->desc->lanes)
+		return dev_err_probe(&dsi->dev, -EINVAL, "This panel is not for MIPI DSI=
\n");
=20
 	dsi->mode_flags =3D MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
 			  MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS;
@@ -1064,30 +1080,107 @@ static int st7701_dsi_probe(struct mipi_dsi_device=
 *dsi)
 	return 0;
 }
=20
+static int st7701_spi_probe(struct spi_device *spi)
+{
+	struct st7701 *st7701;
+	struct gpio_desc *dc;
+	int err;
+
+	err =3D st7701_probe(&spi->dev, DRM_MODE_CONNECTOR_DPI);
+	if (err)
+		return err;
+
+	st7701 =3D dev_get_drvdata(&spi->dev);
+	st7701->write_command =3D st7701_dbi_write;
+
+	dc =3D devm_gpiod_get_optional(&spi->dev, "dc", GPIOD_OUT_LOW);
+	if (IS_ERR(dc))
+		return dev_err_probe(&spi->dev, PTR_ERR(dc), "Failed to get GPIO for D/C=
X\n");
+
+	err =3D mipi_dbi_spi_init(spi, &st7701->dbi, dc);
+	if (err)
+		return dev_err_probe(&spi->dev, err, "Failed to init MIPI DBI\n");
+	st7701->dbi.read_commands =3D NULL;
+
+	return 0;
+}
+
 static void st7701_dsi_remove(struct mipi_dsi_device *dsi)
 {
 	mipi_dsi_detach(dsi);
 }
=20
-static const struct of_device_id st7701_of_match[] =3D {
+static const struct of_device_id st7701_dsi_of_match[] =3D {
 	{ .compatible =3D "anbernic,rg-arc-panel", .data =3D &rg_arc_desc },
 	{ .compatible =3D "densitron,dmt028vghmcmi-1a", .data =3D &dmt028vghmcmi_=
1a_desc },
 	{ .compatible =3D "elida,kd50t048a", .data =3D &kd50t048a_desc },
 	{ .compatible =3D "techstar,ts8550b", .data =3D &ts8550b_desc },
 	{ }
 };
-MODULE_DEVICE_TABLE(of, st7701_of_match);
+MODULE_DEVICE_TABLE(of, st7701_dsi_of_match);
+
+static const struct of_device_id st7701_spi_of_match[] =3D {
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, st7701_spi_of_match);
+
+static const struct spi_device_id st7701_spi_ids[] =3D {
+	{ /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(spi, st7701_spi_ids);
=20
 static struct mipi_dsi_driver st7701_dsi_driver =3D {
 	.probe		=3D st7701_dsi_probe,
 	.remove		=3D st7701_dsi_remove,
 	.driver =3D {
 		.name		=3D "st7701",
-		.of_match_table	=3D st7701_of_match,
+		.of_match_table	=3D st7701_dsi_of_match,
 	},
 };
-module_mipi_dsi_driver(st7701_dsi_driver);
+
+static struct spi_driver st7701_spi_driver =3D {
+	.probe		=3D st7701_spi_probe,
+	.id_table	=3D st7701_spi_ids,
+	.driver =3D {
+		.name		=3D "st7701",
+		.of_match_table	=3D st7701_spi_of_match,
+	},
+};
+
+static int __init st7701_driver_init(void)
+{
+	int err;
+
+	if (IS_ENABLED(CONFIG_SPI)) {
+		err =3D spi_register_driver(&st7701_spi_driver);
+		if (err)
+			return err;
+	}
+
+	if (IS_ENABLED(CONFIG_DRM_MIPI_DSI)) {
+		err =3D mipi_dsi_driver_register(&st7701_dsi_driver);
+		if (err) {
+			if (IS_ENABLED(CONFIG_SPI))
+				spi_unregister_driver(&st7701_spi_driver);
+			return err;
+		}
+	}
+
+	return 0;
+}
+module_init(st7701_driver_init);
+
+static void __exit st7701_driver_exit(void)
+{
+	if (IS_ENABLED(CONFIG_DRM_MIPI_DSI))
+		mipi_dsi_driver_unregister(&st7701_dsi_driver);
+
+	if (IS_ENABLED(CONFIG_SPI))
+		spi_unregister_driver(&st7701_spi_driver);
+}
+module_exit(st7701_driver_exit);
=20
 MODULE_AUTHOR("Jagan Teki <jagan@amarulasolutions.com>");
+MODULE_AUTHOR("Hironori KIKUCHI <kikuchan98@gmail.com>");
 MODULE_DESCRIPTION("Sitronix ST7701 LCD Panel Driver");
 MODULE_LICENSE("GPL");
--=20
2.45.2