From nobody Thu Sep 19 16:16:29 2024 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6EDD1A76C4 for ; Wed, 31 Jul 2024 07:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722409562; cv=none; b=VwSSDAHlihPMe+xnuoiHuYx09DNnpuFzS1W/hrLIA3DZOmevJebUBHa3gY1Cvj8cXUZUZobic8Lyo85ayi6QPNjU3uWO509V4cVT9XE6xZ0xJOMWzDggjVdeT8rcShvl5NuWFFQHjt1CwCqWi/OHjdHbqzzDf8tSqwqakD2ml8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722409562; c=relaxed/simple; bh=goLFX5mJFdEUFTzNMXZVHME3es4ynEqHdezi548BWHs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VFlxBneHjZeYViiH07VW5JjBpNAiS4z7yhcDxpiPsc1nCKs3SsL8ByyGhAi5HSrwsC9K2TJAvsQPWqA5iF3guQA5noDZqOL0+3ulHVaK0FKSKFN4mEIOGCefF7ch0ZLejL9Wz6nih2QmdVa6qK1yPpSN5LyVum7VrLdXz0kc5TI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=WMUlA8xb; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="WMUlA8xb" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-52f00ad303aso8763334e87.2 for ; Wed, 31 Jul 2024 00:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1722409557; x=1723014357; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oHaY16vQQryIhH+k5EF4MPXtMPGv2rNQp9CaSsAD0ko=; b=WMUlA8xbVlmLhM3B1O/Cmf7wScKKabqSD9ZGjXR0oLAl90nb6UZtkv4G8zRbqZ2YHt y1bsauMlkvbDs7sIo0cCw2vRGNPTL2kj1xwc/btZOpUFZgbAq4UQuP97z5LbziZDYAyb Kr/pS6uAZ4M6a9p4g1A+AmTiVABIXgieFrem/pioheAA3TBlgXBWAdn7hZ+VPXx5fR4Q P+plAX+3sp9L7BRPf+aNwQMFuadRjQOWRJs8ReBns+XHh5T+zcW8ignEbhsK6XUV3ajU ZFICheMm2yOKoF4Z6xe+MB/CIoXyxvMAj0UIzYOuQP7T1eD7ZW7YZJ7RU8Mrct40jS/9 lvYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722409557; x=1723014357; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oHaY16vQQryIhH+k5EF4MPXtMPGv2rNQp9CaSsAD0ko=; b=LVaPN1EIaWXsqSitQPJOUPJWFObSfq2zqyvLjGOG9ktO3G1QpptycHH6yGhtoNCbV8 ZuaRIgHTZE/rDrvLfnGsdOFH5MbcmZ0nergcpl/lbwqQ4vrMjjku+mj1ZLc/YyXm2WpF LFgb86GpbSly26HNPhc+T9zpY2jT9F+bWc0RLdV7Cir8ALBXnRCr5bjlyjwY6B5p+bye m83D/1+3kx8myzlcXZPsc3B8CsO8SwV1KlQoj0Uwi1Q9OuSIuZqRh6z60KYOpKXSeJ8r gxgSE7e0gYVUnnj3XFMKRbd7S9VjIP9X4WNHUXXzZHImxrq1fhGDtGYHtduSQbW2AcQ1 eolA== X-Forwarded-Encrypted: i=1; AJvYcCVlBervFYakwU32vgw463sF16GFjUTwIdckPFUA7atz2OHeYFdTeqIbqrd+RSUfbCRFEaEvP6K5x4CTBjYQw0dQOuVJ+CEFglQxOHPL X-Gm-Message-State: AOJu0YwcTTJ1CVt9PTBwSrLpMjFxfpZ5bpECrzr1abE0R4Nwj6id+rVX n8/1/DVl5pTtMoj6SMRvGfqCRVjd1XPt3GMpL8QtFrHZ8U1t3oX0zU7eqjezZQg= X-Google-Smtp-Source: AGHT+IFgysceqqUPLxcKuas2k9QPG9beRNBgeaGQsYtagKcy+ArO1e5R0azF7E/AbehHI/U/HCFReg== X-Received: by 2002:a05:6512:68f:b0:52c:ce28:82c8 with SMTP id 2adb3069b0e04-5309b2c54demr11138493e87.52.1722409556557; Wed, 31 Jul 2024 00:05:56 -0700 (PDT) Received: from [192.168.1.61] (2a02-842a-d52e-6101-6f8f-5617-c4b6-8627.rev.sfr.net. [2a02:842a:d52e:6101:6f8f:5617:c4b6:8627]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4282b8a2593sm9953215e9.4.2024.07.31.00.05.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 00:05:56 -0700 (PDT) From: Julien Stephan Date: Wed, 31 Jul 2024 09:05:47 +0200 Subject: [PATCH v2 6/7] iio: adc: ad7380: enable sequencer for single-ended parts Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20240731-ad7380-add-single-ended-chips-v2-6-cd63bf05744c@baylibre.com> References: <20240731-ad7380-add-single-ended-chips-v2-0-cd63bf05744c@baylibre.com> In-Reply-To: <20240731-ad7380-add-single-ended-chips-v2-0-cd63bf05744c@baylibre.com> To: Michael Hennerich , =?utf-8?q?Nuno_S=C3=A1?= , David Lechner , Lars-Peter Clausen , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet Cc: Michael Hennerich , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Julien Stephan X-Mailer: b4 0.13.0 ad7386/7/8(-4) single-ended parts have a 2:1 mux in front of each ADC. From an IIO point of view, all inputs are exported, i.e ad7386/7/8 export 4 channels and ad7386-4/7-4/8-4 export 8 channels. First inputs of muxes correspond to the first half of IIO channels (i.e 0-1 or 0-3) and second inputs correspond to second half (i.e 2-3 or 4-7) Currently, the driver supports only sampling first half OR second half of the IIO channels. To enable sampling all channels simultaneously, these parts have an internal sequencer that automatically cycles through the mux entries. When enabled, the maximum throughput is divided by two. Moreover, the ADCs need additional settling time, so we add an extra CS toggle to correctly propagate setting, and an additional spi transfer to read the second half. Signed-off-by: Julien Stephan --- drivers/iio/adc/ad7380.c | 175 +++++++++++++++++++++++++++++++++++--------= ---- 1 file changed, 130 insertions(+), 45 deletions(-) diff --git a/drivers/iio/adc/ad7380.c b/drivers/iio/adc/ad7380.c index 820df04b9eb2..e8bddfb0d07d 100644 --- a/drivers/iio/adc/ad7380.c +++ b/drivers/iio/adc/ad7380.c @@ -33,7 +33,7 @@ #include #include =20 -#define MAX_NUM_CHANNELS 4 +#define MAX_NUM_CHANNELS 8 /* 2.5V internal reference voltage */ #define AD7380_INTERNAL_REF_MV 2500 =20 @@ -52,6 +52,7 @@ #define AD7380_REG_ADDR_ALERT_HIGH_TH 0x5 =20 #define AD7380_CONFIG1_CH BIT(11) +#define AD7380_CONFIG1_SEQ BIT(10) #define AD7380_CONFIG1_OS_MODE BIT(9) #define AD7380_CONFIG1_OSR GENMASK(8, 6) #define AD7380_CONFIG1_CRC_W BIT(5) @@ -290,16 +291,28 @@ static const unsigned long ad7380_4_channel_scan_mask= s[] =3D { * * Since this is simultaneous sampling for AinX0 OR AinX1 we have two sepa= rate * scan masks. + * When sequencer mode is enabled, chip automatically cycles through + * AinX0 and AinX1 channels. From an IIO point of view, we ca enable all + * channels, at the cost of an extra read, thus dividing the maximum rate = by + * two. */ +enum { + AD7380_SCAN_MASK_CH_0, + AD7380_SCAN_MASK_CH_1, + AD7380_SCAN_MASK_SEQ, +}; + static const unsigned long ad7380_2x2_channel_scan_masks[] =3D { - GENMASK(1, 0), - GENMASK(3, 2), + [AD7380_SCAN_MASK_CH_0] =3D GENMASK(1, 0), + [AD7380_SCAN_MASK_CH_1] =3D GENMASK(3, 2), + [AD7380_SCAN_MASK_SEQ] =3D GENMASK(3, 0), 0 }; =20 static const unsigned long ad7380_2x4_channel_scan_masks[] =3D { - GENMASK(3, 0), - GENMASK(7, 4), + [AD7380_SCAN_MASK_CH_0] =3D GENMASK(3, 0), + [AD7380_SCAN_MASK_CH_1] =3D GENMASK(7, 4), + [AD7380_SCAN_MASK_SEQ] =3D GENMASK(7, 0), 0 }; =20 @@ -467,11 +480,14 @@ struct ad7380_state { unsigned int oversampling_ratio; bool resolution_boost_enabled; unsigned int ch; + bool seq; unsigned int vref_mv; unsigned int vcm_mv[MAX_NUM_CHANNELS]; /* xfers, message an buffer for reading sample data */ - struct spi_transfer xfer[2]; - struct spi_message msg; + struct spi_transfer normal_xfer[2]; + struct spi_message normal_msg; + struct spi_transfer seq_xfer[4]; + struct spi_message seq_msg; /* * DMA (thus cache coherency maintenance) requires the transfer buffers * to live in their own cache lines. @@ -609,33 +625,47 @@ static int ad7380_set_ch(struct ad7380_state *st, uns= igned int ch) static void ad7380_update_xfers(struct ad7380_state *st, const struct iio_scan_type *scan_type) { - /* - * First xfer only triggers conversion and has to be long enough for - * all conversions to complete, which can be multiple conversion in the - * case of oversampling. Technically T_CONVERT_X_NS is lower for some - * chips, but we use the maximum value for simplicity for now. - */ - if (st->oversampling_ratio > 1) - st->xfer[0].delay.value =3D T_CONVERT_0_NS + T_CONVERT_X_NS * - (st->oversampling_ratio - 1); - else - st->xfer[0].delay.value =3D T_CONVERT_NS; - - st->xfer[0].delay.unit =3D SPI_DELAY_UNIT_NSECS; + struct spi_transfer *xfer =3D st->seq ? st->seq_xfer : st->normal_xfer; + unsigned int t_convert =3D T_CONVERT_NS; =20 /* - * Second xfer reads all channels. Data size depends on if resolution - * boost is enabled or not. + * In the case of oversampling, conversion time is higher than in normal + * mode. Technically T_CONVERT_X_NS is lower for some chips, but we use + * the maximum value for simplicity for now. */ - st->xfer[1].bits_per_word =3D scan_type->realbits; - st->xfer[1].len =3D BITS_TO_BYTES(scan_type->storagebits) * - st->chip_info->num_simult_channels; + if (st->oversampling_ratio > 1) + t_convert =3D T_CONVERT_0_NS + T_CONVERT_X_NS * + (st->oversampling_ratio - 1); + + if (st->seq) { + xfer[0].delay.value =3D xfer[1].delay.value =3D t_convert; + xfer[0].delay.unit =3D xfer[1].delay.unit =3D SPI_DELAY_UNIT_NSECS; + xfer[2].bits_per_word =3D xfer[3].bits_per_word =3D + scan_type->realbits; + xfer[2].len =3D xfer[3].len =3D + BITS_TO_BYTES(scan_type->storagebits) * + st->chip_info->num_simult_channels; + xfer[3].rx_buf =3D xfer[2].rx_buf + xfer[2].len; + /* Additional delay required here when oversampling is enabled */ + if (st->oversampling_ratio > 1) + xfer[2].delay.value =3D t_convert; + else + xfer[2].delay.value =3D 0; + xfer[2].delay.unit =3D SPI_DELAY_UNIT_NSECS; + } else { + xfer[0].delay.value =3D t_convert; + xfer[0].delay.unit =3D SPI_DELAY_UNIT_NSECS; + xfer[1].bits_per_word =3D scan_type->realbits; + xfer[1].len =3D BITS_TO_BYTES(scan_type->storagebits) * + st->chip_info->num_simult_channels; + } } =20 static int ad7380_triggered_buffer_preenable(struct iio_dev *indio_dev) { struct ad7380_state *st =3D iio_priv(indio_dev); const struct iio_scan_type *scan_type; + struct spi_message *msg =3D &st->normal_msg; =20 /* * Currently, we always read all channels at the same time. The scan_type @@ -651,28 +681,57 @@ static int ad7380_triggered_buffer_preenable(struct i= io_dev *indio_dev) =20 /* * Depending on the requested scan_mask and current state, - * we need to change CH bit to sample correct data. + * we need to either change CH bit, or enable sequencer mode + * to sample correct data. + * Sequencer mode is enabled if active mask corresponds to all + * IIO channels enabled. Otherwise, CH bit is set. */ ret =3D iio_active_scan_mask_index(indio_dev); if (ret < 0) return ret; =20 index =3D ret; - ret =3D ad7380_set_ch(st, index); - if (ret) - return ret; + if (index =3D=3D AD7380_SCAN_MASK_SEQ) { + ret =3D regmap_update_bits(st->regmap, + AD7380_REG_ADDR_CONFIG1, + AD7380_CONFIG1_SEQ, + FIELD_PREP(AD7380_CONFIG1_SEQ, 1)); + if (ret) + return ret; + msg =3D &st->seq_msg; + st->seq =3D true; + } else { + ret =3D ad7380_set_ch(st, index); + if (ret) + return ret; + } + } =20 ad7380_update_xfers(st, scan_type); =20 - return spi_optimize_message(st->spi, &st->msg); + return spi_optimize_message(st->spi, msg); } =20 static int ad7380_triggered_buffer_postdisable(struct iio_dev *indio_dev) { struct ad7380_state *st =3D iio_priv(indio_dev); + struct spi_message *msg =3D &st->normal_msg; + int ret; + + if (st->seq) { + ret =3D regmap_update_bits(st->regmap, + AD7380_REG_ADDR_CONFIG1, + AD7380_CONFIG1_SEQ, + FIELD_PREP(AD7380_CONFIG1_SEQ, 0)); + if (ret) + return ret; + + msg =3D &st->seq_msg; + st->seq =3D false; + } =20 - spi_unoptimize_message(&st->msg); + spi_unoptimize_message(msg); =20 return 0; } @@ -687,9 +746,10 @@ static irqreturn_t ad7380_trigger_handler(int irq, voi= d *p) struct iio_poll_func *pf =3D p; struct iio_dev *indio_dev =3D pf->indio_dev; struct ad7380_state *st =3D iio_priv(indio_dev); + struct spi_message *msg =3D st->seq ? &st->seq_msg : &st->normal_msg; int ret; =20 - ret =3D spi_sync(st->spi, &st->msg); + ret =3D spi_sync(st->spi, msg); if (ret) goto out; =20 @@ -723,7 +783,7 @@ static int ad7380_read_direct(struct ad7380_state *st, = unsigned int scan_index, =20 ad7380_update_xfers(st, scan_type); =20 - ret =3D spi_sync(st->spi, &st->msg); + ret =3D spi_sync(st->spi, &st->normal_msg); if (ret < 0) return ret; =20 @@ -919,6 +979,7 @@ static int ad7380_init(struct ad7380_state *st, struct = regulator *vref) /* This is the default value after reset. */ st->oversampling_ratio =3D 1; st->ch =3D 0; + st->seq =3D false; =20 /* SPI 1-wire mode */ return regmap_update_bits(st->regmap, AD7380_REG_ADDR_CONFIG2, @@ -1020,21 +1081,45 @@ static int ad7380_probe(struct spi_device *spi) "failed to allocate register map\n"); =20 /* - * Setting up a low latency read for getting sample data. Used for both - * direct read an triggered buffer. Additional fields will be set up in - * ad7380_update_xfers() based on the current state of the driver at the - * time of the read. + * Setting up xfer structures for both normal and sequence mode. These + * struct are used for both direct read and triggered buffer. Additional + * fields will be set up in ad7380_update_xfers() based on the current + * state of the driver at the time of the read. */ =20 - /* toggle CS (no data xfer) to trigger a conversion */ - st->xfer[0].cs_change =3D 1; - st->xfer[0].cs_change_delay.value =3D st->chip_info->timing_specs->t_csh_= ns; - st->xfer[0].cs_change_delay.unit =3D SPI_DELAY_UNIT_NSECS; - - /* then do a second xfer to read the data */ - st->xfer[1].rx_buf =3D st->scan_data; + /* + * In normal mode a read is composed of two steps: + * - first, toggle CS (no data xfer) to trigger a conversion + * - then, read data + */ + st->normal_xfer[0].cs_change =3D 1; + st->normal_xfer[0].cs_change_delay.value =3D st->chip_info->timing_specs-= >t_csh_ns; + st->normal_xfer[0].cs_change_delay.unit =3D SPI_DELAY_UNIT_NSECS; + st->normal_xfer[1].rx_buf =3D st->scan_data; =20 - spi_message_init_with_transfers(&st->msg, st->xfer, ARRAY_SIZE(st->xfer)); + spi_message_init_with_transfers(&st->normal_msg, st->normal_xfer, + ARRAY_SIZE(st->normal_xfer)); + /* + * In sequencer mode a read is composed of four steps: + * - CS toggle (no data xfer) to get the right point in the sequence + * - CS toggle (no data xfer) to trigger a conversion of AinX0 and + * acquisition of AinX1 + * - 2 data reads, to read AinX0 and AinX1 + */ + st->seq_xfer[0].cs_change =3D 1; + st->seq_xfer[0].cs_change_delay.value =3D st->chip_info->timing_specs->t_= csh_ns; + st->seq_xfer[0].cs_change_delay.unit =3D SPI_DELAY_UNIT_NSECS; + st->seq_xfer[1].cs_change =3D 1; + st->seq_xfer[1].cs_change_delay.value =3D st->chip_info->timing_specs->t_= csh_ns; + st->seq_xfer[1].cs_change_delay.unit =3D SPI_DELAY_UNIT_NSECS; + + st->seq_xfer[2].rx_buf =3D st->scan_data; + st->seq_xfer[2].cs_change =3D 1; + st->seq_xfer[2].cs_change_delay.value =3D st->chip_info->timing_specs->t_= csh_ns; + st->seq_xfer[2].cs_change_delay.unit =3D SPI_DELAY_UNIT_NSECS; + + spi_message_init_with_transfers(&st->seq_msg, st->seq_xfer, + ARRAY_SIZE(st->seq_xfer)); =20 indio_dev->channels =3D st->chip_info->channels; indio_dev->num_channels =3D st->chip_info->num_channels; --=20 2.45.1