From nobody Mon Feb 9 05:37:12 2026 Received: from fhigh7-smtp.messagingengine.com (fhigh7-smtp.messagingengine.com [103.168.172.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3200615530C for ; Mon, 29 Jul 2024 13:46:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.158 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722260803; cv=none; b=J9Ze3qZcKJM1/onag5SA5hCRrQqEiLWNf1R9MkFL8xWr/YKG5bgKfD01+PmsFSi0xCDk/JK4YGfTACv24flU5JTyTEF5X2VsCcTNQ5N2dg799v+6o6b0TNOX949jlmU0QdP9z2GZ8D96MQpw99jYSW0IY2xwEw5xL++EJPURltE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722260803; c=relaxed/simple; bh=6u4YK7HIh8qzxvNwOc536bUNAr0nGICv+grHBPnyhYo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kaYll5x8RrOwUUgFoqi+omkF8AKl/9e/3Y+j13b09JDyCh5DqepOlg/rKjzE0KlyOsxdE9s9xkNesl88zgaF0a1VVGfNi4c9vOWkjvJzFGaPso//XMJe1pY82D+044WGfr7A/KD8af0D2gXKPfiGBNm3GFftUkQ8eSm+NDmdocU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=m/8rkA9j; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Y0tWsoJ+; arc=none smtp.client-ip=103.168.172.158 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="m/8rkA9j"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Y0tWsoJ+" Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 07F24114018D; Mon, 29 Jul 2024 09:46:41 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 29 Jul 2024 09:46:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1722260801; x= 1722347201; bh=j6bWCSRv+RuSR+rObc2XVVpxBOoLwKSQSviTJPiNqUw=; b=m /8rkA9jZLDzEL2K0EEWBwCNxpzLlA74zT47+ZDjErKcPgHLrN45zHs8QQ5oB5/zd KTjlyzkReQPt1BIuFUWYvcSmfrlZ4ViFN7c5DfmrhXDYWEf/rBToqGIlsc0EaFRw OgYSOwoSgXL9Rcd1uZ9tSJfQxhWxfElwzoGjFWPHhlVVkOIocbG+q7064HJpiwxN KUsyfmfD0mt6taju7biOS+RglMpxh07cs0+NP/I/41OInCapyxZKckl5DPnNgoBe A4xQHIzYohHqwjs6llKsfGXKNb6PMy6nU5uniqq5UUiEVFFrIfyiBn6ja85gqJPM zc5exFH/yoJO9XOptaHew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1722260801; x= 1722347201; bh=j6bWCSRv+RuSR+rObc2XVVpxBOoLwKSQSviTJPiNqUw=; b=Y 0tWsoJ+6jO0E5mjTVUOsKm8IrIO0SBhe0njhLT9CvMHCyYrRiMZ8R7pUKDDZPmuW 6nCddeZxNi1Fa4c7of8zroREcTgIowzc8GF8r4vqbDiIMBYRuIvZ2xzaUWYLgEvx cPe1FUhlZnX1hPmh2LpGHwwlMFxc4RvTP3/xKrI1F3TPs514gIUhwXVc82PpxuqU vD/AQJVMAcFmy8VlQAVq3S/yEjZrzSUJkc3wjuolbqsR0cvlW2BUkuxI+/0huZkS Ve/8fREsnUctghU7OOJz3lqYSUHpT3k71pUbifzfFNjepNFE/CrKjckMJXGItQaf Q0o2S8zrbS7HwXgJfKN5g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrjedvgdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepvfgrkhgrshhhihcuufgrkhgrmhhothhouceoohdqthgrkhgr shhhihesshgrkhgrmhhotggthhhirdhjpheqnecuggftrfgrthhtvghrnhepvdejgfejue dvgfduudekleevtefgtdevhfdtffefiefgveeuteffiedvffekvddtnecuvehluhhsthgv rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepohdqthgrkhgrshhhihessh grkhgrmhhotggthhhirdhjphdpnhgspghrtghpthhtoheptd X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Jul 2024 09:46:39 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH 3/3] firewire: core: use common helper function to serialize phy configuration packet Date: Mon, 29 Jul 2024 22:46:31 +0900 Message-ID: <20240729134631.127189-4-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240729134631.127189-1-o-takashi@sakamocchi.jp> References: <20240729134631.127189-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A common helper function is available to serialize the first quadlet of phy configuration packet. This commit is for the purpose. Signed-off-by: Takashi Sakamoto --- drivers/firewire/core-cdev.c | 4 +++- drivers/firewire/core-transaction.c | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/firewire/core-cdev.c b/drivers/firewire/core-cdev.c index 9a7dc90330a3..619048dcfd72 100644 --- a/drivers/firewire/core-cdev.c +++ b/drivers/firewire/core-cdev.c @@ -37,6 +37,8 @@ #include "core.h" #include =20 +#include "packet-header-definitions.h" + /* * ABI version history is documented in linux/firewire-cdev.h. */ @@ -1635,7 +1637,7 @@ static int ioctl_send_phy_packet(struct client *clien= t, union ioctl_arg *arg) e->client =3D client; e->p.speed =3D SCODE_100; e->p.generation =3D a->generation; - e->p.header[0] =3D TCODE_LINK_INTERNAL << 4; + async_header_set_tcode(e->p.header, TCODE_LINK_INTERNAL); e->p.header[1] =3D a->data[0]; e->p.header[2] =3D a->data[1]; e->p.header_length =3D 12; diff --git a/drivers/firewire/core-transaction.c b/drivers/firewire/core-tr= ansaction.c index 4d2fc1f31fec..a89c841a7dbe 100644 --- a/drivers/firewire/core-transaction.c +++ b/drivers/firewire/core-transaction.c @@ -464,7 +464,6 @@ static void transmit_phy_packet_callback(struct fw_pack= et *packet, =20 static struct fw_packet phy_config_packet =3D { .header_length =3D 12, - .header[0] =3D TCODE_LINK_INTERNAL << 4, .payload_length =3D 0, .speed =3D SCODE_100, .callback =3D transmit_phy_packet_callback, @@ -497,6 +496,7 @@ void fw_send_phy_config(struct fw_card *card, =20 mutex_lock(&phy_config_mutex); =20 + async_header_set_tcode(phy_config_packet.header, TCODE_LINK_INTERNAL); phy_config_packet.header[1] =3D data; phy_config_packet.header[2] =3D ~data; phy_config_packet.generation =3D generation; --=20 2.43.0