From nobody Mon Feb 9 09:00:35 2026 Received: from fout2-smtp.messagingengine.com (fout2-smtp.messagingengine.com [103.168.172.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A0161514F8 for ; Mon, 29 Jul 2024 13:46:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.145 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722260802; cv=none; b=Fmz0hABqwy7Gatp4NbbwJUGJL204ujjf6cEWFU3UFoYI855tHyxr5GsK9ecuwH9Z4/UFc9EBjvbaoTRp35C0G/9wtYUxjgQvNFDcHCNTeh+uCUGfZCEL7hKPGA/SkjzlzNxUznCCuOiFRy99fTMIE36fRvEpU9Bhf5CL+uo8LAA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722260802; c=relaxed/simple; bh=CypZyBAmur8jk1dMIRMI/JD+8QpCn7AnNr+0wvRzl8Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e4dob6xstZO04j4/+iq5o5iA1qZotFmZSpOfutcWWuzzHHreLTKJ9NtAUkUT8afGM2JCoCuPEtSk9E87v85MkCJzy0z1yLAuBfwKrRRrSkl/mP6N6BOT+89VkaV3fUdccRQecPpOmYV1vWDBX1eKrriDeCKy2l/SLbTd5warwuk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=rNoMVBIV; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=KRfRQM55; arc=none smtp.client-ip=103.168.172.145 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="rNoMVBIV"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="KRfRQM55" Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfout.nyi.internal (Postfix) with ESMTP id 9635F13801DC; Mon, 29 Jul 2024 09:46:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 29 Jul 2024 09:46:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1722260799; x= 1722347199; bh=U5rod4RFqqD1jbS5LRRa2T3sPIulvkc5tgqY5IiVoIQ=; b=r NoMVBIVIN9jiii48x1LG/QTqho54xKGnlT2/NCByyNPQLNm+hXllHuHW1pgniabU 3ST42kxzKnp3jDdwRhZOdUHgUuzAGiQI7J201XV5+lQQo/d3K40PAmlLlS71wuMO H8JMuY0ZfTFL7YCIYwThKuNKbdnzVTryYcQ0BDB/LG6u9Jcib6Sr9xb/Uw4To5pj QOcVPltJScrvAG48w63NGAX9Lny+C0n29DAOf2zRsmNoeyCH7jFrg77QevwkkndP s9kbNs7zUn7YtOHN4epkcjrzNPap0OJLcmSAvPWel/KUb2YylijCe2uZcEIezrXT F35QA2n7MUziAvi1DUtog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1722260799; x= 1722347199; bh=U5rod4RFqqD1jbS5LRRa2T3sPIulvkc5tgqY5IiVoIQ=; b=K RfRQM55xCLgw5MYHyDzB9vbRQx9qUi2z1+P6/md8EBK1AEA4A6y8tHzVT5ikgU6/ LXtnSoUKycysmI/E+pQec/I8cgGEEhEKrwENPbZ+e9x953L0T8t+rZBF4ZH9jTyh 02uLsVv6xfn3+gC3ABT0wfYI9B7/GzANqA0M6/y3u4yLz9u2bnfgvOcql7s8j8e7 tPcanwizvT5wzwhtMFDhfdf1QXgBKynLGCm1U/Mj81nGqvto8X2txmOkIVyhUxyt K9OjMF5zpwrEjnLArCaLH2/JR3h7OwWvTudc3MV+FlrK7N8NZahRm5Q4KsIe1WtJ 79SsuefXKEnUNzRLDiUuQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrjedvgdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvvefufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepvfgrkhgrshhhihcuufgrkhgrmhhothhouceoohdqthgrkhgr shhhihesshgrkhgrmhhotggthhhirdhjpheqnecuggftrfgrthhtvghrnhepvdejgfejue dvgfduudekleevtefgtdevhfdtffefiefgveeuteffiedvffekvddtnecuvehluhhsthgv rhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepohdqthgrkhgrshhhihessh grkhgrmhhotggthhhirdhjphdpnhgspghrtghpthhtoheptd X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Jul 2024 09:46:37 -0400 (EDT) From: Takashi Sakamoto To: linux1394-devel@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/3] firewire: ohci: minor code refactoring to localize text table Date: Mon, 29 Jul 2024 22:46:30 +0900 Message-ID: <20240729134631.127189-3-o-takashi@sakamocchi.jp> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240729134631.127189-1-o-takashi@sakamocchi.jp> References: <20240729134631.127189-1-o-takashi@sakamocchi.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The string table for tcode is just used by log_ar_at_event(). In the case, it is suitable to move the table inner the function definition. This commit is for the purpose. Additionally, the hard-coded value for tcode is replaced with defined macros as many as possible. Signed-off-by: Takashi Sakamoto --- drivers/firewire/ohci.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index c3fff94b13e5..a0bb0e87e18a 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -531,20 +531,28 @@ static const char *evts[] =3D { [0x1e] =3D "ack_type_error", [0x1f] =3D "-reserved-", [0x20] =3D "pending/cancelled", }; -static const char *tcodes[] =3D { - [0x0] =3D "QW req", [0x1] =3D "BW req", - [0x2] =3D "W resp", [0x3] =3D "-reserved-", - [0x4] =3D "QR req", [0x5] =3D "BR req", - [0x6] =3D "QR resp", [0x7] =3D "BR resp", - [0x8] =3D "cycle start", [0x9] =3D "Lk req", - [0xa] =3D "async stream packet", [0xb] =3D "Lk resp", - [0xc] =3D "-reserved-", [0xd] =3D "-reserved-", - [0xe] =3D "link internal", [0xf] =3D "-reserved-", -}; =20 static void log_ar_at_event(struct fw_ohci *ohci, char dir, int speed, u32 *header, int evt) { + static const char *const tcodes[] =3D { + [TCODE_WRITE_QUADLET_REQUEST] =3D "QW req", + [TCODE_WRITE_BLOCK_REQUEST] =3D "BW req", + [TCODE_WRITE_RESPONSE] =3D "W resp", + [0x3] =3D "-reserved-", + [TCODE_READ_QUADLET_REQUEST] =3D "QR req", + [TCODE_READ_BLOCK_REQUEST] =3D "BR req", + [TCODE_READ_QUADLET_RESPONSE] =3D "QR resp", + [TCODE_READ_BLOCK_RESPONSE] =3D "BR resp", + [TCODE_CYCLE_START] =3D "cycle start", + [TCODE_LOCK_REQUEST] =3D "Lk req", + [TCODE_STREAM_DATA] =3D "async stream packet", + [TCODE_LOCK_RESPONSE] =3D "Lk resp", + [0xc] =3D "-reserved-", + [0xd] =3D "-reserved-", + [TCODE_LINK_INTERNAL] =3D "link internal", + [0xf] =3D "-reserved-", + }; int tcode =3D async_header_get_tcode(header); char specific[12]; =20 --=20 2.43.0