From nobody Thu Dec 18 19:25:23 2025 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2A9279B8E for ; Mon, 29 Jul 2024 11:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.188 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722253477; cv=none; b=KA0GaH+BktzLwGD91lvaWRLu5+qfgFgbw19jv3Oo931sZNOHTrYyhTTH4w6fyBN6nrli/GHtdC+LhHSYqMaXO4GFNq6hL5CWq8cipFBfOD5iexp+gthWq3ImoWzH4rCds+lHiRDPclGvl4vEMo8c9ojgXaOYT+dTvp7+Kfpd1TQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722253477; c=relaxed/simple; bh=DrDDx1tjZc4+DP6s+1WmfatygIPl0lO0VMe7Hyvpsh0=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=sLndtdSntZJIbO1oVjMhfSS3JSbTAc6htFbTOuPzGuDXOG7DE5vvGZt40sVYs6xk4sduHoWN9s8dgEuLCaa9o+GMnQQ8jt/E3Zc7FuoDHLDf9tMsTazn6U7m8E0SlG4VbxoeIEdwoQ6i9rIEB8K5Oa3oW99HMn2q4o3OfRZl7jk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WXc1z68Tzznd22; Mon, 29 Jul 2024 19:43:35 +0800 (CST) Received: from kwepemi100008.china.huawei.com (unknown [7.221.188.57]) by mail.maildlp.com (Postfix) with ESMTPS id 52FA1140E5D; Mon, 29 Jul 2024 19:44:32 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi100008.china.huawei.com (7.221.188.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 29 Jul 2024 19:44:31 +0800 From: Jinjie Ruan To: , , , , , , , , , , CC: Subject: [PATCH v6] crash: Fix crash memory reserve exceed system memory bug Date: Mon, 29 Jul 2024 19:50:12 +0800 Message-ID: <20240729115012.1656042-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi100008.china.huawei.com (7.221.188.57) Content-Type: text/plain; charset="utf-8" On x86_32 Qemu machine with 1GB memory, the cmdline "crashkernel=3D4G" is ok as below: crashkernel reserved: 0x0000000020000000 - 0x0000000120000000 (4096 MB) It's similar on other architectures, such as ARM32 and RISCV32. The cause is that the crash_size is parsed and printed with "unsigned long long" data type which is 8 bytes but allocated used with "phys_addr_t" which is 4 bytes in memblock_phys_alloc_range(). Fix it by checking if crash_size is greater than system RAM size and return error if so. After this patch, there is no above confusing reserve success info. Signed-off-by: Jinjie Ruan Suggested-by: Mike Rapoport Acked-by: Baoquan He Cc: Andrew Morton --- v6: - Take off Baoquan's Suggested-by. v5: - Fix it in common parse_crashkernel() instead of per-arch. - Add suggested-by. v4: - Update the warn info to align with parse_crashkernel_mem(). - Rebased on the "ARM: Use generic interface to simplify crashkernel reservation" patch. - Also fix for riscv32. - Update the commit message. v3: - Handle the check in reserve_crashkernel() Baoquan suggested. - Split x86_32 and arm32. - Add Suggested-by. - Drop the wrong fix tag. v2: - Also fix for x86_32. - Update the fix method. - Peel off the other two patches. - Update the commit message. --- kernel/crash_reserve.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/crash_reserve.c b/kernel/crash_reserve.c index ad5b3f2c5487..5387269114f6 100644 --- a/kernel/crash_reserve.c +++ b/kernel/crash_reserve.c @@ -335,6 +335,9 @@ int __init parse_crashkernel(char *cmdline, if (!*crash_size) ret =3D -EINVAL; =20 + if (*crash_size >=3D system_ram) + ret =3D -EINVAL; + return ret; } =20 --=20 2.34.1